r353459 - [Sema][ObjC] Disallow non-trivial C struct fields in unions.

Author: ahatanak Date: Thu Feb 7 12:21:46 2019 New Revision: 353459 URL: http://llvm.org/viewvc/llvm-project?rev=353459&view=rev Log: [Sema][ObjC] Disallow non-trivial C struct fields in unions. This patch fixes a bug where clang doesn’t reject union fields of non-trivial C struct types. For exa

r353556 - Pass the base element type of an array type to the visit method instead

Author: ahatanak Date: Fri Feb 8 11:46:53 2019 New Revision: 353556 URL: http://llvm.org/viewvc/llvm-project?rev=353556&view=rev Log: Pass the base element type of an array type to the visit method instead of the array type itself. This fixes a bug found by inspection that was introduced in r353

r313717 - [Sema][ObjC] Warn about mismatches in attributes between overriding and

Author: ahatanak Date: Tue Sep 19 22:39:18 2017 New Revision: 313717 URL: http://llvm.org/viewvc/llvm-project?rev=313717&view=rev Log: [Sema][ObjC] Warn about mismatches in attributes between overriding and overridden methods when compiling for non-ARC. Previously, clang would error out when comp

r313720 - Add support for attribute 'noescape'.

Author: ahatanak Date: Tue Sep 19 23:22:51 2017 New Revision: 313720 URL: http://llvm.org/viewvc/llvm-project?rev=313720&view=rev Log: Add support for attribute 'noescape'. The attribute informs the compiler that the annotated pointer parameter of a function cannot escape and enables IRGen to att

r313721 - Revert "Add support for attribute 'noescape'."

Author: ahatanak Date: Tue Sep 19 23:27:39 2017 New Revision: 313721 URL: http://llvm.org/viewvc/llvm-project?rev=313721&view=rev Log: Revert "Add support for attribute 'noescape'." This reverts r313717. I closed the wrong phabricator review. Removed: cfe/trunk/test/CodeGenCXX/noescape.cpp

r313722 - Add support for attribute 'noescape'.

Author: ahatanak Date: Tue Sep 19 23:32:45 2017 New Revision: 313722 URL: http://llvm.org/viewvc/llvm-project?rev=313722&view=rev Log: Add support for attribute 'noescape'. The attribute informs the compiler that the annotated pointer parameter of a function cannot escape and enables IRGen to att

r313725 - Revert "Add support for attribute 'noescape'."

Author: ahatanak Date: Tue Sep 19 23:55:43 2017 New Revision: 313725 URL: http://llvm.org/viewvc/llvm-project?rev=313725&view=rev Log: Revert "Add support for attribute 'noescape'." This reverts commit r313722. It looks like compiler-rt/lib/tsan/rtl/tsan_libdispatch_mac.cc cannot be compiled bec

r313945 - Add support for attribute 'noescape'.

Author: ahatanak Date: Thu Sep 21 17:41:05 2017 New Revision: 313945 URL: http://llvm.org/viewvc/llvm-project?rev=313945&view=rev Log: Add support for attribute 'noescape'. The attribute informs the compiler that the annotated pointer parameter of a function cannot escape and enables IRGen to att

r313952 - Add test cases that weren't committed in r313945.

Author: ahatanak Date: Thu Sep 21 18:54:36 2017 New Revision: 313952 URL: http://llvm.org/viewvc/llvm-project?rev=313952&view=rev Log: Add test cases that weren't committed in r313945. Added: cfe/trunk/test/CodeGenCXX/noescape.cpp cfe/trunk/test/CodeGenObjC/noescape.m cfe/trunk/test/S

r314029 - [CodeGen][ObjC] Build the global block structure before emitting the

Author: ahatanak Date: Fri Sep 22 14:32:06 2017 New Revision: 314029 URL: http://llvm.org/viewvc/llvm-project?rev=314029&view=rev Log: [CodeGen][ObjC] Build the global block structure before emitting the body of global block invoke functions. This commit fixes an infinite loop in IRGen that occur

r314056 - Promote storage-only __fp16 vector operands to float vectors.

Author: ahatanak Date: Fri Sep 22 22:02:02 2017 New Revision: 314056 URL: http://llvm.org/viewvc/llvm-project?rev=314056&view=rev Log: Promote storage-only __fp16 vector operands to float vectors. This commit fixes a bug in the handling of storage-only __fp16 vectors where clang didn't promote __

Re: r350917 - [Sema] If CheckPlaceholderExpr rewrites the initializer of an auto

we should check for a placeholder type before attempting > deduction, just like we correct typos in the initializer before > attempting deduction. > > On Thu, 10 Jan 2019 at 21:01, Akira Hatanaka via cfe-commits > wrote: >> >> Author: ahatanak >> Date: Thu Jan

r362464 - Add a release note entry for the change made in r362034.

Author: ahatanak Date: Mon Jun 3 16:48:14 2019 New Revision: 362464 URL: http://llvm.org/viewvc/llvm-project?rev=362464&view=rev Log: Add a release note entry for the change made in r362034. Modified: cfe/trunk/docs/ReleaseNotes.rst Modified: cfe/trunk/docs/ReleaseNotes.rst URL: http://llv

r362521 - [CodeGen][ObjC] Convert '[self alloc]' in a class method to a call to

Author: ahatanak Date: Tue Jun 4 09:29:58 2019 New Revision: 362521 URL: http://llvm.org/viewvc/llvm-project?rev=362521&view=rev Log: [CodeGen][ObjC] Convert '[self alloc]' in a class method to a call to 'objc_alloc(self)' Also convert '[[self alloc] init]' in a class method to a call to 'objc_a

r362651 - Fix FileCheck prefixes in test case.

Author: ahatanak Date: Wed Jun 5 14:11:06 2019 New Revision: 362651 URL: http://llvm.org/viewvc/llvm-project?rev=362651&view=rev Log: Fix FileCheck prefixes in test case. Modified: cfe/trunk/test/CodeGenObjC/local-static-block.m Modified: cfe/trunk/test/CodeGenObjC/local-static-block.m URL:

r363467 - [CodeGen][ObjC] Annotate retain-agnostic ObjC globals with attribute

Author: ahatanak Date: Fri Jun 14 15:06:28 2019 New Revision: 363467 URL: http://llvm.org/viewvc/llvm-project?rev=363467&view=rev Log: [CodeGen][ObjC] Annotate retain-agnostic ObjC globals with attribute 'objc_arc_inert' The attribute enables the ARC optimizer to delete ObjC ARC runtime calls on

r365985 - [Sema] Diagnose default-initialization, destruction, and copying of

Author: ahatanak Date: Fri Jul 12 18:47:15 2019 New Revision: 365985 URL: http://llvm.org/viewvc/llvm-project?rev=365985&view=rev Log: [Sema] Diagnose default-initialization, destruction, and copying of non-trivial C union types This patch diagnoses uses of non-trivial C unions and structs/unions

r365989 - Initialize the non-trivial C union bits I added to RecordDeclBitfields

Author: ahatanak Date: Fri Jul 12 20:59:55 2019 New Revision: 365989 URL: http://llvm.org/viewvc/llvm-project?rev=365989&view=rev Log: Initialize the non-trivial C union bits I added to RecordDeclBitfields in r365985 These bits weren't being initialized in the RecordDecl's constructor, which prob

r367076 - Revert "[Sema] Diagnose default-initialization, destruction, and copying of"

Author: ahatanak Date: Thu Jul 25 17:02:17 2019 New Revision: 367076 URL: http://llvm.org/viewvc/llvm-project?rev=367076&view=rev Log: Revert "[Sema] Diagnose default-initialization, destruction, and copying of" This reverts commit r365985. Prior to r365985, clang used to mark C union fields tha

r364595 - Pattern match struct types in test case.

Author: ahatanak Date: Thu Jun 27 14:16:19 2019 New Revision: 364595 URL: http://llvm.org/viewvc/llvm-project?rev=364595&view=rev Log: Pattern match struct types in test case. This simplifies the test cases in a patch I'm planning to send later. Modified: cfe/trunk/test/CodeGenObjC/strong-in

r365382 - [Sema] Resolve placeholder types before type deduction to silence

Author: ahatanak Date: Mon Jul 8 13:04:39 2019 New Revision: 365382 URL: http://llvm.org/viewvc/llvm-project?rev=365382&view=rev Log: [Sema] Resolve placeholder types before type deduction to silence spurious `-Warc-repeated-use-of-weak` warnings The spurious -Warc-repeated-use-of-weak warnings

r360404 - Assume `__cxa_allocate_exception` returns an under-aligned memory on

Author: ahatanak Date: Thu May 9 19:16:37 2019 New Revision: 360404 URL: http://llvm.org/viewvc/llvm-project?rev=360404&view=rev Log: Assume `__cxa_allocate_exception` returns an under-aligned memory on Darwin if the version of libc++abi isn't new enough to include the fix in r319123 This patch

r360474 - [CodeGen][ObjC] Emit invoke instead of call to call `objc_release` when

Author: ahatanak Date: Fri May 10 14:54:16 2019 New Revision: 360474 URL: http://llvm.org/viewvc/llvm-project?rev=360474&view=rev Log: [CodeGen][ObjC] Emit invoke instead of call to call `objc_release` when necessary. Prior to r349952, clang used to call objc_msgSend when sending a release messag

Re: r361340 - [Analysis] Link library dependencies to Analysis plugins

Hi Petr, This seems to have caused Analysis/checker-plugins.c to fail. Can you investigate it or revert your commit? http://green.lab.llvm.org/green/job/clang-stage2-cmake-RgSan/6381/consoleFull#-5275661368254eaf0-7326-4999-85b0-388101f2d404 > On May 21, 2019, at 5:47 PM, Petr Hosek via cfe-com

r361685 - Revert "[Analysis] Link library dependencies to Analysis plugins"

Author: ahatanak Date: Fri May 24 17:50:03 2019 New Revision: 361685 URL: http://llvm.org/viewvc/llvm-project?rev=361685&view=rev Log: Revert "[Analysis] Link library dependencies to Analysis plugins" This reverts commit r361340. The following builder has been broken for the past few days because

Re: r361340 - [Analysis] Link library dependencies to Analysis plugins

I reverted the patch in r361685 to make the bot green again. > On May 23, 2019, at 5:22 PM, Akira Hatanaka wrote: > > Hi Petr, > > This seems to have caused Analysis/checker-plugins.c to fail. Can you > investigate it or revert your commit? > > http://green.lab.llvm.org/green/job/clang-stage2

r362034 - [ObjC] Fix encoding of ObjC pointer types that are pointers to typedefs

Author: ahatanak Date: Wed May 29 14:23:30 2019 New Revision: 362034 URL: http://llvm.org/viewvc/llvm-project?rev=362034&view=rev Log: [ObjC] Fix encoding of ObjC pointer types that are pointers to typedefs clang was encoding pointers to typedefs as if they were pointers to structs because that i

r349890 - [Sema] Produce diagnostics when C++17 aligned allocation/deallocation

Author: ahatanak Date: Thu Dec 20 23:05:36 2018 New Revision: 349890 URL: http://llvm.org/viewvc/llvm-project?rev=349890&view=rev Log: [Sema] Produce diagnostics when C++17 aligned allocation/deallocation functions that are unavailable on Darwin are explicitly called or called from deleting destru

r350157 - [CodeGen] Replace '@' characters in block descriptors' symbol names with

Author: ahatanak Date: Sat Dec 29 09:28:30 2018 New Revision: 350157 URL: http://llvm.org/viewvc/llvm-project?rev=350157&view=rev Log: [CodeGen] Replace '@' characters in block descriptors' symbol names with '\1'. '@' can't be used in block descriptors' symbol names since it is reserved on ELF pl

r350887 - [Sema] Call CheckPlaceholderExpr to resolve typeof or decltype

Author: ahatanak Date: Thu Jan 10 12:12:16 2019 New Revision: 350887 URL: http://llvm.org/viewvc/llvm-project?rev=350887&view=rev Log: [Sema] Call CheckPlaceholderExpr to resolve typeof or decltype placeholder expressions while an unevaluated context is still on the expression evaluation context s

r329879 - [Sema][ObjC] Ensure that the return type of an ObjC method is a complete

Author: ahatanak Date: Wed Apr 11 23:01:41 2018 New Revision: 329879 URL: http://llvm.org/viewvc/llvm-project?rev=329879&view=rev Log: [Sema][ObjC] Ensure that the return type of an ObjC method is a complete type. Copy the code in ActOnStartOfFunctionDef that checks a function's return type to Ac

r330151 - [CodeGen] Fix a crash that occurs when a non-trivial C struct with a

Author: ahatanak Date: Mon Apr 16 12:38:00 2018 New Revision: 330151 URL: http://llvm.org/viewvc/llvm-project?rev=330151&view=rev Log: [CodeGen] Fix a crash that occurs when a non-trivial C struct with a volatile array field is copied. The crash occurs because method 'visitArray' passes a null Fi

r330153 - Revert "[CodeGen] Fix a crash that occurs when a non-trivial C struct with a"

Author: ahatanak Date: Mon Apr 16 12:53:59 2018 New Revision: 330153 URL: http://llvm.org/viewvc/llvm-project?rev=330153&view=rev Log: Revert "[CodeGen] Fix a crash that occurs when a non-trivial C struct with a" This reverts commit r330151, which caused bots to fail. Modified: cfe/trunk/lib

r330155 - [CodeGen] Fix a crash that occurs when a non-trivial C struct with a

Author: ahatanak Date: Mon Apr 16 13:23:52 2018 New Revision: 330155 URL: http://llvm.org/viewvc/llvm-project?rev=330155&view=rev Log: [CodeGen] Fix a crash that occurs when a non-trivial C struct with a volatile array field is copied. The crash occurs because method 'visitArray' passes a null Fi

r330199 - Add a command line option 'fregister_global_dtors_with_atexit' to

Author: ahatanak Date: Tue Apr 17 11:41:52 2018 New Revision: 330199 URL: http://llvm.org/viewvc/llvm-project?rev=330199&view=rev Log: Add a command line option 'fregister_global_dtors_with_atexit' to register destructor functions annotated with __attribute__((destructor)) using __cxa_atexit or at

r330201 - Move the visitor classes that are used to traverse non-trivial C structs

Author: ahatanak Date: Tue Apr 17 12:05:17 2018 New Revision: 330201 URL: http://llvm.org/viewvc/llvm-project?rev=330201&view=rev Log: Move the visitor classes that are used to traverse non-trivial C structs to a header file. This is in preparation for using the visitor classes to warn about memc

r330202 - [Sema] Warn about memcpy'ing non-trivial C structs.

Author: ahatanak Date: Tue Apr 17 12:13:41 2018 New Revision: 330202 URL: http://llvm.org/viewvc/llvm-project?rev=330202&view=rev Log: [Sema] Warn about memcpy'ing non-trivial C structs. Issue a warning when non-trivial C structs are copied or initialized by calls to memset, bzero, memcpy, or mem

r330304 - [CodeGen] Do not push a destructor cleanup for a struct that doesn't

Author: ahatanak Date: Wed Apr 18 16:33:15 2018 New Revision: 330304 URL: http://llvm.org/viewvc/llvm-project?rev=330304&view=rev Log: [CodeGen] Do not push a destructor cleanup for a struct that doesn't have a non-trivial destructor. This fixes a bug introduced in r328731 where CodeGen emits cal

r331010 - [Driver] Don't enable "-fregister-global-dtors-with-atexit" by default

Author: ahatanak Date: Thu Apr 26 18:42:33 2018 New Revision: 331010 URL: http://llvm.org/viewvc/llvm-project?rev=331010&view=rev Log: [Driver] Don't enable "-fregister-global-dtors-with-atexit" by default when compiling the kernel or kexts. Destructors should be registered with atexit by default

r331016 - [CodeGen] Avoid destructing a callee-destructued struct type in a

Author: ahatanak Date: Thu Apr 26 21:21:51 2018 New Revision: 331016 URL: http://llvm.org/viewvc/llvm-project?rev=331016&view=rev Log: [CodeGen] Avoid destructing a callee-destructued struct type in a function if a function delegates to another function. Fix a bug introduced in r328731, which cau

r331019 - Revert "[CodeGen] Avoid destructing a callee-destructued struct type in a"

Author: ahatanak Date: Thu Apr 26 22:56:55 2018 New Revision: 331019 URL: http://llvm.org/viewvc/llvm-project?rev=331019&view=rev Log: Revert "[CodeGen] Avoid destructing a callee-destructued struct type in a" This reverts commit r331016, which broke a windows bot. http://lab.llvm.org:8011/build

r331020 - [CodeGen] Avoid destructing a callee-destructued struct type in a

Author: ahatanak Date: Thu Apr 26 23:57:00 2018 New Revision: 331020 URL: http://llvm.org/viewvc/llvm-project?rev=331020&view=rev Log: [CodeGen] Avoid destructing a callee-destructued struct type in a function if a function delegates to another function. Fix a bug introduced in r328731, which cau

r336629 - Fix parsing of privacy annotations in os_log format strings.

Author: ahatanak Date: Mon Jul 9 17:50:25 2018 New Revision: 336629 URL: http://llvm.org/viewvc/llvm-project?rev=336629&view=rev Log: Fix parsing of privacy annotations in os_log format strings. Privacy annotations shouldn't have to appear in the first comma-delimited string in order to be recog

r336863 - os_log: When there are multiple privacy annotations in the format

Author: ahatanak Date: Wed Jul 11 15:19:14 2018 New Revision: 336863 URL: http://llvm.org/viewvc/llvm-project?rev=336863&view=rev Log: os_log: When there are multiple privacy annotations in the format string, choose the strictest one instead of the last. Also fix an undefined behavior. Move the p

Re: [clang] c90e198 - Fix parsing of enum-base to follow C++11 rules.

Hi Richard, It looks like this patch will reject the following code, which used to compile fine: $ cat test.cpp #include typedef CF_ENUM(unsigned, TestEnum) { A = 2, B = 3, }; $ clang++ -std=c++11 -c test.cpp test.cpp:3:9: error: non-defining declaration of enumeration with a fixed unde

Re: [clang] c90e198 - Fix parsing of enum-base to follow C++11 rules.

> On May 20, 2020, at 5:53 PM, Richard Smith wrote: > > On Wed, 20 May 2020 at 16:30, Akira Hatanaka via cfe-commits > mailto:cfe-commits@lists.llvm.org>> wrote: > Hi Richard, > > It looks like this patch will reject the following code, which used to > com

[clang] 959517a - Clean up clang/test/CodeGenObjC/os_log.m

Author: Akira Hatanaka Date: 2020-06-01T13:47:20-07:00 New Revision: 959517ace1cd9e8bcd0af3be6259dd4d78a9bd84 URL: https://github.com/llvm/llvm-project/commit/959517ace1cd9e8bcd0af3be6259dd4d78a9bd84 DIFF: https://github.com/llvm/llvm-project/commit/959517ace1cd9e8bcd0af3be6259dd4d78a9bd84.diff

[clang] 73bc23f - Fix the data layout mangling specification for 'i686-pc-macho'

Author: Akira Hatanaka Date: 2020-07-21T12:58:17-07:00 New Revision: 73bc23ff86655b4e041ce14a991a8bd5cce985e0 URL: https://github.com/llvm/llvm-project/commit/73bc23ff86655b4e041ce14a991a8bd5cce985e0 DIFF: https://github.com/llvm/llvm-project/commit/73bc23ff86655b4e041ce14a991a8bd5cce985e0.diff

Build czar switchover

Hi Volodymyr and Azhar, Here is the current status of the bots: 1. Automerger Automerger has almost caught up. [apple/master -> internal/master] has just 13 unmerged commits and no conflicts. 2. BlueDragon There are a few clang-1200 bots that are failing. - The following bot is failing because

Re: changes to matrix size check

+ Volodymyr, Azhar > On Apr 8, 2020, at 6:28 AM, Florian Hahn wrote: > > Hi Akira, > >> On Apr 7, 2020, at 21:12, Akira Hatanaka > > wrote: >> >> Hi Adam and Florian, >> >> Just to give you a heads up, I’ve made changes to the code that checks >> matrix size and t

[clang] f56659d - Don't use a variable that isn't defined

Author: Akira Hatanaka Date: 2020-06-09T16:07:29-07:00 New Revision: f56659d2bae67b26c016aed6503585d93fbafd23 URL: https://github.com/llvm/llvm-project/commit/f56659d2bae67b26c016aed6503585d93fbafd23 DIFF: https://github.com/llvm/llvm-project/commit/f56659d2bae67b26c016aed6503585d93fbafd23.diff

[clang] f466f0b - Disallow trivial_abi on a class if all copy and move constructors are

Author: Akira Hatanaka Date: 2020-06-10T14:12:13-07:00 New Revision: f466f0beda59af1af182deb3cc8c006093d5a169 URL: https://github.com/llvm/llvm-project/commit/f466f0beda59af1af182deb3cc8c006093d5a169 DIFF: https://github.com/llvm/llvm-project/commit/f466f0beda59af1af182deb3cc8c006093d5a169.diff

[clang] c9a52de - [CodeGen] Simplify the way lifetime of block captures is extended

Author: Akira Hatanaka Date: 2020-06-11T16:06:22-07:00 New Revision: c9a52de0026093327daedda7ea2eead8b64657b4 URL: https://github.com/llvm/llvm-project/commit/c9a52de0026093327daedda7ea2eead8b64657b4 DIFF: https://github.com/llvm/llvm-project/commit/c9a52de0026093327daedda7ea2eead8b64657b4.diff

[clang] 2cfb027 - [CodeGen][NFC] Add a helper function that returns the addresses of

Author: Akira Hatanaka Date: 2020-06-15T15:59:16-07:00 New Revision: 2cfb027369e6e297c2dee70e56ec384afe883ec3 URL: https://github.com/llvm/llvm-project/commit/2cfb027369e6e297c2dee70e56ec384afe883ec3 DIFF: https://github.com/llvm/llvm-project/commit/2cfb027369e6e297c2dee70e56ec384afe883ec3.diff

[clang] 0402705 - [Sema] Teach -Wcast-align to compute alignment of CXXThisExpr

Author: Akira Hatanaka Date: 2020-07-07T17:45:04-07:00 New Revision: 04027052a72f982c9e09472427ec7339415fb777 URL: https://github.com/llvm/llvm-project/commit/04027052a72f982c9e09472427ec7339415fb777 DIFF: https://github.com/llvm/llvm-project/commit/04027052a72f982c9e09472427ec7339415fb777.diff

[clang] e9bf0a7 - [CodeGen] Store the return value of the target function call to the

Author: Akira Hatanaka Date: 2020-07-10T17:24:13-07:00 New Revision: e9bf0a710c993b932fa69c95ef6d0130fd721115 URL: https://github.com/llvm/llvm-project/commit/e9bf0a710c993b932fa69c95ef6d0130fd721115 DIFF: https://github.com/llvm/llvm-project/commit/e9bf0a710c993b932fa69c95ef6d0130fd721115.diff

[clang] 3a5617c - Fix build error

Author: Akira Hatanaka Date: 2020-07-10T17:40:37-07:00 New Revision: 3a5617c02e38618bd5534491077afbc7178adf3f URL: https://github.com/llvm/llvm-project/commit/3a5617c02e38618bd5534491077afbc7178adf3f DIFF: https://github.com/llvm/llvm-project/commit/3a5617c02e38618bd5534491077afbc7178adf3f.diff

[clang] ed6b578 - [CodeGen] Emit a call instruction instead of an invoke if the called

Author: Akira Hatanaka Date: 2020-07-15T14:47:45-07:00 New Revision: ed6b578040a85977026c93bf4188f996148f3218 URL: https://github.com/llvm/llvm-project/commit/ed6b578040a85977026c93bf4188f996148f3218 DIFF: https://github.com/llvm/llvm-project/commit/ed6b578040a85977026c93bf4188f996148f3218.diff

[clang] cdd6a27 - [ObjC] Copy a block to the heap if it is passed as a variadic argument

Author: Akira Hatanaka Date: 2020-06-24T11:46:38-07:00 New Revision: cdd6a2788caced6b377af818154138d9983dba5f URL: https://github.com/llvm/llvm-project/commit/cdd6a2788caced6b377af818154138d9983dba5f DIFF: https://github.com/llvm/llvm-project/commit/cdd6a2788caced6b377af818154138d9983dba5f.diff

[clang] 41b1e97 - [CodeGen][ObjC] Mark calls to objc_unsafeClaimAutoreleasedReturnValue as

Author: Akira Hatanaka Date: 2020-08-03T13:25:25-07:00 New Revision: 41b1e97b12c1407e40d8e5081bf1f9cf183934b0 URL: https://github.com/llvm/llvm-project/commit/41b1e97b12c1407e40d8e5081bf1f9cf183934b0 DIFF: https://github.com/llvm/llvm-project/commit/41b1e97b12c1407e40d8e5081bf1f9cf183934b0.diff

[clang] dc4e25d - [CodeGen][ObjC] Don't try to retain a __unsafe_unretained ARC pointer

Author: Akira Hatanaka Date: 2020-05-06T12:47:17-07:00 New Revision: dc4e25d4f238afb171aacb3774e1162c69574a0a URL: https://github.com/llvm/llvm-project/commit/dc4e25d4f238afb171aacb3774e1162c69574a0a DIFF: https://github.com/llvm/llvm-project/commit/dc4e25d4f238afb171aacb3774e1162c69574a0a.diff

[clang] 50a81ea - Don't apply lvalue-to-rvalue conversion in DefaultLValueConversion to

Author: Akira Hatanaka Date: 2020-05-13T20:12:10-07:00 New Revision: 50a81ea2bce3aec01ae6fae1505e57ec7aa36ac7 URL: https://github.com/llvm/llvm-project/commit/50a81ea2bce3aec01ae6fae1505e57ec7aa36ac7 DIFF: https://github.com/llvm/llvm-project/commit/50a81ea2bce3aec01ae6fae1505e57ec7aa36ac7.diff

[clang] 854f5f3 - [Sema] Teach -Wcast-align to compute an accurate alignment using the

Author: Akira Hatanaka Date: 2020-05-15T00:59:03-07:00 New Revision: 854f5f332af4640d9425e9a94442629e4f5a3f98 URL: https://github.com/llvm/llvm-project/commit/854f5f332af4640d9425e9a94442629e4f5a3f98 DIFF: https://github.com/llvm/llvm-project/commit/854f5f332af4640d9425e9a94442629e4f5a3f98.diff

Re: [PATCH] D24472: [Sema] Support lax conversions for compound assignments

ahatanak added inline comments. Comment at: lib/Sema/SemaExpr.cpp:8084 @@ +8083,3 @@ + *RHSExpr = ImpCastExprToType(RHSExpr->get(), LHSType, CK_BitCast); + return LHSType; +} My understanding is that, when we have a compound assign like "LHS += RHS",

Re: [PATCH] D24693: [CodeGen] Don't emit lifetime intrinsics for some local variables

ahatanak added a subscriber: ahatanak. ahatanak added a comment. Can you add some test cases? https://reviews.llvm.org/D24693 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D24693: [CodeGen] Don't emit lifetime intrinsics for some local variables

ahatanak added a comment. It looks like the test case was removed when this patch we rebased. https://reviews.llvm.org/D24693 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D24472: [Sema] Support lax conversions for compound assignments

ahatanak added a comment. Thanks Bruno. I have a couple more questions. Comment at: lib/Sema/SemaExpr.cpp:8090 @@ +8089,3 @@ + *RHSExpr = ImpCastExprToType(RHSExpr->get(), LHSType, CK_BitCast); + return VecType; +} Sorry I wasn't clear, but I was a

Re: [PATCH] D24693: [CodeGen] Don't emit lifetime intrinsics for some local variables

ahatanak added a comment. Do we want to remove lifetime intrinsics when we aren't doing the asan-use-after-scope check? Since this isn't a mis-compile caused by inaccurate lifetime intrinsics, I was wondering whether we should do this only when asan-use-after-scope is on to minimize the impact

Re: [PATCH] D24693: [CodeGen] Don't emit lifetime intrinsics for some local variables

ahatanak added a comment. In https://reviews.llvm.org/D24693#549095, @majnemer wrote: > This doesn't sound right. Given the example in the description, we are > accessing the memory location after end has been called: this seems like a > real miscompile. It would appear unsafe to only do this

Re: [PATCH] D24693: [CodeGen] Don't emit lifetime intrinsics for some local variables

ahatanak added a comment. Thank you for the great example! I can now see this patch does fix mis-compiles. There are probably other lifetime bugs you'll see when the code being compiled includes gotos that jump past variable declarations, including the one here: http://lists.llvm.org/pipermail/

Re: [PATCH] D24693: [CodeGen] Don't emit lifetime intrinsics for some local variables

ahatanak added a comment. In https://reviews.llvm.org/D24693#551050, @vitalybuka wrote: > I can see how to insert starts, e.g. on every label which bypass declaration, > but I am not sure where to put ends. > Probably it's possible, but patch will be significantly more complicated. > I'd prefe

Re: [PATCH] D23096: [Sema] Pass CombineWithOuterScope = true to constructor of LocalInstantiationScope

ahatanak updated this revision to Diff 72356. ahatanak added a comment. I agree that extending the logic of getTemplateInstantiationArgs seems like a better approach. I changed Sema::getTemplateInstantiationArgs to search for the template arguments twice, first for the initializer's template arg

Re: [PATCH] D23236: When ARC is enabled, no warning will be generated when a method1. Returns 'nil' in a method that is attributed to return a 'nonnull'2. The return-statement is a ConditionalOperator

ahatanak added a comment. This looks fine to me. https://reviews.llvm.org/D23236 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D24969: [Sema] Use the instantiated name of destructors in FindInstantiatedDecl and RebuildMemberExpr

ahatanak created this revision. ahatanak added reviewers: doug.gregor, rsmith. ahatanak added a subscriber: cfe-commits. This fixes PR30361. clang was failing to compile the test case because it was passing "~C1" instead of "~C1" to FindInstantiatedDecl and RebuildMemberExpr. https://reviews.ll

[PATCH] D25001: [Module] Merge function prototype with a non-prototype function declaration

ahatanak created this revision. ahatanak added reviewers: doug.gregor, rsmith. ahatanak added a subscriber: cfe-commits. This patch fixes a crash that occurs when a non-prototype function is declared before a header containing a prototype of the same function is included. This caused Sema::Looku

[PATCH] D15075: No error for conflict between inputs\outputs and clobber list

ahatanak added a comment. This patch doesn't detect more complex conflicts (like the following code), but I think it's OK for now. asm ("foo" : "=Q" (x) : : "%rax", "%rbx", "%rcx", "%rdx"); // Q: Any register accessible as rh: a, b, c, and d. > TargetInfo.h:593 >/// >/// For examp

[PATCH] D25206: [Parser] Correct typo after lambda capture initializer is parsed

ahatanak created this revision. ahatanak added a reviewer: rsmith. ahatanak added a subscriber: cfe-commits. This fixes PR30566. The assertion is triggered when RecordLayoutBuilder tries to compute the size of a field (for capture "name" in the test case) whose type hasn't been deduced. This fi

[PATCH] D24999: [Sema] Only relax array-at-end-of-object checks in __builtin_object_size when -fno-strict-aliasing is given.

ahatanak added a comment. Just want to give you a heads up that I was going to abandon the patch that adds support for attribute "flexible_array" (https://reviews.llvm.org/D21453) after r281277, but I'll probably need the attribute after all if we are going to make the changes in this patch.

[PATCH] D24669: {Sema] Gcc compatibility of vector shift.

ahatanak added inline comments. > SemaExpr.cpp:8787 > } > +if (!S.LangOpts.OpenCL && !S.LangOpts.ZVector) { > + const BuiltinType *LHSBT = LHSEleType->getAs(); Is it possible to use ASTContext::getTypeSize here? https://reviews.llvm.org/D24669 __

[PATCH] D25001: [Module] Merge function prototype with a non-prototype function declaration

ahatanak added a comment. ping https://reviews.llvm.org/D25001 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D24969: [Sema] Use the instantiated name of destructors in FindInstantiatedDecl and RebuildMemberExpr

ahatanak added a comment. ping https://reviews.llvm.org/D24969 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D24969: [Sema] Use the instantiated name of destructors in FindInstantiatedDecl and RebuildMemberExpr

ahatanak added inline comments. > rsmith wrote in SemaTemplateInstantiateDecl.cpp:4849 > Do we need to do this for conversion function names too? (Eg, `operator > C1*`) I added a definition of "operator C1*" and called it in C1::foo1. I didn't see any crashes or asserts. Calls to a destructor

[PATCH] D15075: No error for conflict between inputs\outputs and clobber list

ahatanak added inline comments. > TargetInfo.cpp:430 >if (AN == Name && ARN.RegNum < Names.size()) > -return Name; > +if (ReturnCanonical) > + return Names[ARN.RegNum]; Please use braces or a ternary operator here. > ahatanak wrote in Targets.cpp:2718 > Can we s

[PATCH] D15075: No error for conflict between inputs\outputs and clobber list

ahatanak added a comment. I have a couple of minor comments, but patch looks good to me. Comment at: lib/Sema/SemaStmtAsm.cpp:141 +// Extracting the register name from the Expression value, +// if there is no register name to extract, returns "" Please remove

Re: patch: clean up in EmitValueForIvarAtOffset

LGTM > On Oct 9, 2016, at 2:39 PM, Nick Lewycky via cfe-commits > wrote: > > The attached patch makes the LValue created in EmitValueForIvarAtOffset have > the same Qualifiers in the LValue as the QualType in the LValue. Noticed when > auditing for reasons the QualType would different from th

[PATCH] D15075: No error for conflict between inputs\outputs and clobber list

ahatanak accepted this revision. ahatanak added a comment. LGTM with a few nits. Please fix lib/Headers/intrin.h too and commit it as a separate patch. Comment at: lib/Sema/SemaStmtAsm.cpp:142 +// Extracting the register name from the Expression value, +// if there is no regis

[PATCH] D25480: __builtin_fpclassify missing one int parameter

ahatanak added a comment. __builtin_fpclassify takes five int arguments followed by one last argument that is of floating point type. Do you know if there is a way to specify the last one argument is a floating point rather than using '.'? https://reviews.llvm.org/D25480 ___

[PATCH] D24969: [Sema] Use the instantiated name of destructors in FindInstantiatedDecl and RebuildMemberExpr

ahatanak updated this revision to Diff 74324. ahatanak added a comment. Added a call to operator C1* in test case. https://reviews.llvm.org/D24969 Files: lib/Sema/SemaTemplateInstantiateDecl.cpp lib/Sema/TreeTransform.h test/SemaCXX/destructor.cpp Index: test/SemaCXX/destructor.cpp

[PATCH] D24969: [Sema] Use the instantiated name of destructors in FindInstantiatedDecl and RebuildMemberExpr

ahatanak marked an inline comment as done. ahatanak added a comment. (I'm replying to the comment near TreeTransform.h:11967 because phab doesn't let me hit save) It looks like RebuildCXXPseudoDestructorExpr isn't even called because a MemberExpr is created instead of a CXXPseudoDestructorExpr.

[PATCH] D25001: [Module] Merge function prototype with a non-prototype function declaration

ahatanak added a comment. It looks like this patch doesn't do what I thought would do when the unprototyped function declaration is in the header and the prototyped function declaration is in the source code. The DeclRefExpr created for the call to func1("abc", 12) points to the unprototyped fu

[PATCH] D25547: [CodeGen][ObjC] Do not emit objc_storeStrong to initialize a constexpr variable

ahatanak created this revision. ahatanak added a reviewer: rjmccall. ahatanak added a subscriber: cfe-commits. When compiling a constexpr NSString initialized with an objective-c string literal, CodeGen currently emits objc_storeStrong on an uninitialized alloca, which causes a crash: constex

[PATCH] D25556: [Sema] Add variable captured by a block to the enclosing lambda's potential capture list

ahatanak created this revision. ahatanak added reviewers: rsmith, rjmccall. ahatanak added a subscriber: cfe-commits. When compiling the following code, DoMarkVarDeclReferenced fails to capture variable "outerp": auto lambda =[&](auto p) { return ^{ return p + outerp; }(); };

[PATCH] D25547: [CodeGen][ObjC] Do not emit objc_storeStrong to initialize a constexpr variable

ahatanak added a comment. There are two overloaded functions of CodeGenFunction::EmitScalarInit. Are you suggesting we fold both of them into EmitStoreThroughLValue and remove them? https://reviews.llvm.org/D25547 ___ cfe-commits mailing list cfe-c

[PATCH] D25547: [CodeGen][ObjC] Do not emit objc_storeStrong to initialize a constexpr variable

ahatanak updated this revision to Diff 74760. ahatanak added a comment. Fold EmitScalarInit into EmitStoreThroughLValue and remove EmitScalarInit. I don't think ElementType in EmitObjCCollectionLiteral has a lifetime qualifier, so it should be safe to call EmitStoreThroughLValue instead of Emit

[libcxxabi] r319123 - Insert padding before the __cxa_exception header to ensure the thrown

Author: ahatanak Date: Mon Nov 27 16:36:29 2017 New Revision: 319123 URL: http://llvm.org/viewvc/llvm-project?rev=319123&view=rev Log: Insert padding before the __cxa_exception header to ensure the thrown object is sufficiently aligned. r303175 annotated field unwindHeader of __cxa_exception with

r320215 - [CodeGen][X86] Fix handling of __fp16 vectors.

Author: ahatanak Date: Fri Dec 8 16:02:37 2017 New Revision: 320215 URL: http://llvm.org/viewvc/llvm-project?rev=320215&view=rev Log: [CodeGen][X86] Fix handling of __fp16 vectors. This commit fixes a bug in IRGen where it generates completely broken code for __fp16 vectors on X86. For example w

[clang] [ARC][Documentation] Explicitly state that messaging weak objects keeps a strong reference during call lifetime (PR #72169)

https://github.com/ahatanak created https://github.com/llvm/llvm-project/pull/72169 rdar://113636046 >From 99c6bac064fbb7eb8f5462b58389b33703faf3f2 Mon Sep 17 00:00:00 2001 From: Akira Hatanaka Date: Mon, 13 Nov 2023 14:27:28 -0800 Subject: [PATCH] [ARC][Documentation] Explicitly state that me

[clang] [ARC][Documentation] Explicitly state that messaging weak objects keeps a strong reference during call lifetime (PR #72169)

https://github.com/ahatanak closed https://github.com/llvm/llvm-project/pull/72169 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[llvm] [clang] [CodeGen][arm64e] Add methods and data members to Address, which are needed to authenticate signed pointers (PR #67454)

@@ -232,19 +232,19 @@ static Value *MakeBinaryAtomicValue( static Value *EmitNontemporalStore(CodeGenFunction &CGF, const CallExpr *E) { Value *Val = CGF.EmitScalarExpr(E->getArg(0)); - Value *Address = CGF.EmitScalarExpr(E->getArg(1)); + Address Addr = CGF.EmitPointerWith

[clang] [CodeGen] Emit a more accurate alignment for non-temporal loads/stores (PR #75675)

https://github.com/ahatanak created https://github.com/llvm/llvm-project/pull/75675 Call EmitPointerWithAlignment to compute the alignment based on the underlying lvalue's alignment when it's available. >From 641aba730a38038da0d5a9ef8a56fab908131144 Mon Sep 17 00:00:00 2001 From: Akira Hatanak

<    1   2   3   4   5   6   7   8   9   10   >