[PATCH] D125936: [Sema] Relax an assertion in BuildStmtExpr

ahatanak added a comment. ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125936/new/ https://reviews.llvm.org/D125936 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cg

[PATCH] D125936: [Sema] Relax an assertion in BuildStmtExpr

ahatanak added a comment. No, I don't think there are any problems. We can probably just pop the cleanups at the end of the asm statement. The original commit message said the asm calls had to be wrapped in `StmtExpr`s because temporaries would get destroyed before the asm calls, but that doesn

[PATCH] D125936: [Sema] Relax an assertion in BuildStmtExpr

ahatanak updated this revision to Diff 437248. ahatanak added a comment. Stop wrapping a `GCCAsmStmt` with an `ExprWithCleanups`. Instead, just pop the cleanups after the asm statement to destruct the temporaries. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://review

[PATCH] D125936: [Sema] Relax an assertion in BuildStmtExpr

ahatanak added a comment. I've removed the call to `ActOnFinishFullStmt` in `CoroutineStmtBuilder::makeOnFallthrough` too. `BuildCoreturnStmt` calls `ActOnFinishFullExpr`, so I don't think it's necessary to call `ActOnFinishFullStmt` after that. Repository: rG LLVM Github Monorepo CHANGES

[PATCH] D125936: [Sema] Relax an assertion in BuildStmtExpr

ahatanak added subscribers: ChuanqiXu, EricWF. ahatanak added a comment. Adding more people to get more eyes on the changes I made to SemaCoroutine.cpp. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125936/new/ https://reviews.llvm.org/D125936 ___

[PATCH] D125936: [Sema] Relax an assertion in BuildStmtExpr

ahatanak updated this revision to Diff 437566. ahatanak added a comment. Revert the changes made to SemaCoroutine.cpp. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125936/new/ https://reviews.llvm.org/D125936 Files: clang/lib/CodeGen/CGStmt.cpp

[PATCH] D125936: [Sema] Relax an assertion in BuildStmtExpr

ahatanak updated this revision to Diff 437796. ahatanak added a comment. Fix misleading comment and add a test case for C compound literal. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125936/new/ https://reviews.llvm.org/D125936 Files: clang/l

[PATCH] D125936: [Sema] Relax an assertion in BuildStmtExpr

ahatanak added inline comments. Comment at: clang/lib/CodeGen/CGStmt.cpp:2291 + // statement. + CodeGenFunction::RunCleanupsScope Cleanups(*this); + rjmccall wrote: > Do we need to do anything special when entering the full expressions to make > sure that encl

[PATCH] D125936: [Sema] Relax an assertion in BuildStmtExpr

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG8fc3d719eee7: Stop wrapping GCCAsmStmts inside StmtExprs to destruct temporaries (authored by ahatanak). Changed prior to commit: https://reviews.

[PATCH] D128373: [Sema] Check whether `__auto_type` has been deduced before merging

ahatanak created this revision. ahatanak added a reviewer: aaron.ballman. ahatanak added a project: clang. Herald added a project: All. ahatanak requested review of this revision. This fixes a bug in clang where it emits the following diagnostic when compiling the test case: `argument to 'sizeof

[PATCH] D128373: [Sema] Check whether `__auto_type` has been deduced before merging

ahatanak updated this revision to Diff 439574. ahatanak added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128373/new/ https://reviews.llvm.org/D128373 Files: clang/lib/AST/ASTContext.cpp clang/test/Sema/warn-memset-bad-size

[PATCH] D128373: [Sema] Check whether `__auto_type` has been deduced before merging

ahatanak updated this revision to Diff 439636. ahatanak added a comment. Change the type of `memset`'s length parameter to silence warnings on windows. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128373/new/ https://reviews.llvm.org/D128373 File

[PATCH] D128373: [Sema] Check whether `__auto_type` has been deduced before merging

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG5fa4629581f6: [Sema] Check whether `__auto_type` has been deduced before merging (authored by ahatanak). Changed prior to commit: https://reviews.

[PATCH] D126084: [Sema] Reject implicit conversions between different scoped enum types in list initialization

ahatanak added inline comments. Comment at: clang/lib/Sema/SemaInit.cpp:4506 !S.Context.hasSameUnqualifiedType(E->getType(), DestType) && -(E->getType()->isIntegralOrEnumerationType() || +(E->getType()->isIntegralOrUnscopedEnumerationType() || E

[PATCH] D125839: [gmodules] Skip CXXDeductionGuideDecls when visiting FunctionDecls in DebugTypeVisitor

ahatanak added a comment. ping. Does debug info need information on deduction guides? I think it's safe to skip deduction guides as they are used only for template argument deduction. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125839/new/ http

[PATCH] D125936: [Sema] Relax an assertion in BuildStmtExpr

ahatanak added a comment. ping I think the assertion is assuming `StmtExpr` is created only for GNU statement expressions, but it's created for asm statements too (see https://github.com/llvm/llvm-project/commit/3050d9bdb84e322e122219d54aedfe2d8ef7c51c). Repository: rG LLVM Github Monorepo

[PATCH] D125936: [Sema] Relax an assertion in BuildStmtExpr

ahatanak updated this revision to Diff 432398. ahatanak edited the summary of this revision. ahatanak added a comment. Add a codegen test that checks destructors for temporaries inside asm statements are called. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.

[PATCH] D126084: [Sema] Reject implicit conversions between different scoped enum types in list initialization

ahatanak added inline comments. Comment at: clang/lib/Sema/SemaInit.cpp:4506 !S.Context.hasSameUnqualifiedType(E->getType(), DestType) && -(E->getType()->isIntegralOrEnumerationType() || +(E->getType()->isIntegralOrUnscopedEnumerationType() || E

[PATCH] D126084: [Sema] Reject implicit conversions between different scoped enum types in list initialization

ahatanak added inline comments. Comment at: clang/lib/Sema/SemaInit.cpp:4506 !S.Context.hasSameUnqualifiedType(E->getType(), DestType) && -(E->getType()->isIntegralOrEnumerationType() || +(E->getType()->isIntegralOrUnscopedEnumerationType() || E

[PATCH] D125936: [Sema] Relax an assertion in BuildStmtExpr

ahatanak added inline comments. Comment at: clang/lib/Sema/SemaExpr.cpp:15746 ExprResult Sema::BuildStmtExpr(SourceLocation LPLoc, Stmt *SubStmt, SourceLocation RPLoc, unsigned TemplateDepth) { assert(SubStmt && isa(SubStmt) && "Invalid action

[PATCH] D126084: [Sema] Reject implicit conversions between different scoped enum types in list initialization

ahatanak added inline comments. Comment at: clang/lib/Sema/SemaInit.cpp:4506 !S.Context.hasSameUnqualifiedType(E->getType(), DestType) && -(E->getType()->isIntegralOrEnumerationType() || +(E->getType()->isIntegralOrUnscopedEnumerationType() || E

[PATCH] D126084: [Sema] Reject implicit conversions between different scoped enum types in list initialization

ahatanak added inline comments. Comment at: clang/lib/Sema/SemaInit.cpp:4506 !S.Context.hasSameUnqualifiedType(E->getType(), DestType) && -(E->getType()->isIntegralOrEnumerationType() || +(E->getType()->isIntegralOrUnscopedEnumerationType() || E

[PATCH] D126084: [Sema] Reject list-initialization of a scoped enum variable from an element of a different scoped enum type

ahatanak added inline comments. Comment at: clang/lib/Sema/SemaInit.cpp:4506 !S.Context.hasSameUnqualifiedType(E->getType(), DestType) && -(E->getType()->isIntegralOrEnumerationType() || +(E->getType()->isIntegralOrUnscopedEnumerationType() || E

[PATCH] D126084: [Sema] Reject list-initialization of enumeration types from a brace-init-list containing a single element of a different scoped enumeration type

ahatanak updated this revision to Diff 433922. ahatanak added a comment. Fix the comment to match the code. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126084/new/ https://reviews.llvm.org/D126084 Files: clang/lib/Sema/SemaInit.cpp clang/tes

[PATCH] D126084: [Sema] Reject list-initialization of enumeration types from a brace-init-list containing a single element of a different scoped enumeration type

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG66e08995b0b7: [Sema] Reject list-initialization of enumeration types from a (authored by ahatanak). Repository: rG LLVM Github Monorepo CHANGES S

[PATCH] D125936: [Sema] Relax an assertion in BuildStmtExpr

ahatanak updated this revision to Diff 434144. ahatanak added a comment. Add a flag to `StmtExpr` that indicates whether it needs cleanup. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125936/new/ https://reviews.llvm.org/D125936 Files: clang/in

[PATCH] D125839: [gmodules] Skip CXXDeductionGuideDecls when visiting FunctionDecls in DebugTypeVisitor

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGd1346e2ee274: [gmodules] Skip CXXDeductionGuideDecls when visiting FunctionDecls in (authored by ahatanak). Repository: rG LLVM Github Monorepo C

[PATCH] D125839: [gmodules] Skip CXXDeductionGuideDecls when visiting FunctionDecls in DebugTypeVisitor

ahatanak added inline comments. Comment at: clang/test/Modules/gmodules-deduction-guide.cpp:3 +// RUN: -o %t.pch %S/Inputs/gmodules-deduction-guide.h \ +// RUN: -mllvm -debug-only=pchcontainer &>%t-pch.ll +// RUN: cat %t-pch.ll | FileCheck %s chapuni wrote: >

[PATCH] D125936: [Sema] Relax an assertion in BuildStmtExpr

ahatanak updated this revision to Diff 434960. ahatanak marked an inline comment as done. ahatanak added a comment. Check that the destructor is called at the end of the asm. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125936/new/ https://reviews

[PATCH] D127442: [Sema] Fix a bug where clang doesn't detect uses of unavailable decls in C++ base or member initializers

ahatanak created this revision. ahatanak added a reviewer: arphaman. ahatanak added a project: clang. Herald added a project: All. ahatanak requested review of this revision. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D127442 Files: clang/lib/Sema/SemaAvailability.cpp cla

[PATCH] D155012: Fix types of arm64 MSVC __readx18/__writex18 intrinsics

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG4ae87b3f8adc: Fix types of arm64 MSVC __readx18/__writex18 intrinsics (authored by ahatanak). Repository: rG LLVM Github Monorepo CHANGES SINCE L

[PATCH] D147283: [Sema] Search template parameter scopes before searching namespace/file scopes when performing unqualified name lookup

ahatanak updated this revision to Diff 542150. ahatanak added a comment. - Defer collecting using directives until lookup into local scopes is done. - Simplify the second loop. - Add more comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D14728

[PATCH] D147283: [Sema] Search template parameter scopes before searching namespace/file scopes when performing unqualified name lookup

ahatanak added inline comments. Comment at: clang/lib/Sema/SemaLookup.cpp:1392 - if (!VisitedUsingDirectives) { -// Add using directives from this context up to the top level. -for (DeclContext *UCtx = Ctx; UCtx; UCtx = UCtx->getParent()) { --

[PATCH] D147283: [Sema] Search template parameter scopes before searching namespace/file scopes when performing unqualified name lookup

ahatanak added inline comments. Comment at: clang/lib/Sema/SemaLookup.cpp:1403 + // Find the innermost file scope, so we can add using directives + // from local scopes. + InnermostFileScope = S; This isn't needed as `InnermostFileScope

[PATCH] D147283: [Sema] Search template parameter scopes before searching namespace/file scopes when performing unqualified name lookup

ahatanak updated this revision to Diff 542165. ahatanak added a comment. Remove unneeded code. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147283/new/ https://reviews.llvm.org/D147283 Files: clang/lib/Sema/SemaLookup.cpp clang/test/SemaCXX/n

[PATCH] D143109: [Sema] Push a LambdaScopeInfo before calling SubstDefaultArgument

ahatanak abandoned this revision. ahatanak added a comment. It looks like a7579b25df78a9f53d62300020d4ae3c4734 fixed the crash. Thank you! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://review

[PATCH] D147283: [Sema] Search template parameter scopes before searching namespace/file scopes when performing unqualified name lookup

ahatanak added a comment. ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147283/new/ https://reviews.llvm.org/D147283 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cg

[PATCH] D157520: [Driver] Replace a link to openradar with a comment. NFC

ahatanak updated this revision to Diff 549165. ahatanak added a comment. Mention that the linker bug has been fixed. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157520/new/ https://reviews.llvm.org/D157520 Files: clang/lib/Driver/ToolChains/Cl

[PATCH] D157520: [Driver] Replace a link to openradar with a comment. NFC

ahatanak added a comment. It looks like the linker bug has been fixed, but we probably need extensive testing before enabling it on Darwin. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157520/new/ https://reviews.llvm.org/D157520 ___

[PATCH] D156576: Remove rdar links in clang/lib. NFC

ahatanak created this revision. ahatanak added a reviewer: ravikandhadai. ahatanak added a project: clang. Herald added a project: All. ahatanak requested review of this revision. Herald added a subscriber: MaskRay. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D156576 Files:

[PATCH] D156576: Remove rdar links in clang/lib. NFC

ahatanak updated this revision to Diff 545300. ahatanak added a comment. Remove git commit hash in comment. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156576/new/ https://reviews.llvm.org/D156576 Files: clang/lib/CodeGen/CGObjCMac.cpp clang

[PATCH] D156576: Remove rdar links in clang/lib. NFC

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGb08d358e8ac8: Remove private rdar links. NFC (authored by ahatanak). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://revi

[PATCH] D156728: [Sema] Ignore nullability qualifiers when deducing types for `auto` and `__auto_type`

ahatanak created this revision. ahatanak added reviewers: doug.gregor, rjmccall. ahatanak added a project: clang. Herald added a project: All. ahatanak requested review of this revision. Prior to https://reviews.llvm.org/D110216, the deduced types didn't inherit the nullability qualifiers of the

[PATCH] D156728: [Sema] Ignore nullability qualifiers when deducing types for `auto` and `__auto_type`

ahatanak added inline comments. Comment at: clang/lib/Sema/SemaTemplateDeduction.cpp:3885 ParamType = ParamType.getUnqualifiedType(); +(void)AttributedType::stripOuterNullability(ParamType); + } This isn't needed to fix the test cases I added, but I thi

[PATCH] D156728: [Sema] Ignore nullability qualifiers when deducing types for `auto` and `__auto_type`

ahatanak added a comment. Also, `_Atomic` has the same problem, but it's not clear whether we want to strip the qualifiers. See https://github.com/llvm/llvm-project/issues/63659 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156728/new/ https://rev

[PATCH] D156728: [Sema] Ignore nullability qualifiers when deducing types for `auto` and `__auto_type`

ahatanak added a comment. I think we still need to do something like what this patch is doing (i.e., drop the nullability qualifiers) when deducing types for `auto` or `__auto_type`, assuming that's the rule we want and we want to restore the previous behavior. I agree with you that we should m

[PATCH] D147283: [Sema] Search template parameter scopes before searching namespace/file scopes when performing unqualified name lookup

ahatanak added a comment. ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147283/new/ https://reviews.llvm.org/D147283 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cg

[PATCH] D157520: [Driver] Replace a link to openradar with a comment. NFC

ahatanak created this revision. ahatanak added a reviewer: ravikandhadai. ahatanak added a project: clang. Herald added a project: All. ahatanak requested review of this revision. Herald added a subscriber: MaskRay. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D157520 Files:

[PATCH] D154251: Add a flag to disable "duplicate definition of category" warnings

ahatanak updated this revision to Diff 536479. ahatanak added a comment. Fix clang/test/Misc/warning-flags.c Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154251/new/ https://reviews.llvm.org/D154251 Files: clang/include/clang/Basic/DiagnosticCo

[PATCH] D154388: Don't pass -ibuiltininc, which is used only by the driver, to CC1

ahatanak created this revision. ahatanak added reviewers: arphaman, fahad, MaskRay. ahatanak added a project: clang. Herald added a project: All. ahatanak requested review of this revision. This fixes a fallout from 5b77e752dcd073846b89559d6c0e1a7699e58615

[PATCH] D154251: Add a flag to disable "duplicate definition of category" warnings

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGcff99b76ac4f: Add a flag to disable "duplicate definition of category" warnings (authored by ahatanak). Repository: rG LLVM Github Monorepo CHANG

[PATCH] D154388: Don't pass -ibuiltininc, which is used only by the driver, to CC1

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. ahatanak marked an inline comment as done. Closed by commit rGa2b7297dff34: Don't pass -ibuiltininc, which is used only by the driver, to CC1 (authored by ahatanak). C

[PATCH] D155012: Fix types of arm64 MSVC __readx18/__writex18 intrinsics

ahatanak created this revision. ahatanak added reviewers: ravikandhadai, Bigcheese, steplong. ahatanak added a project: clang. Herald added a subscriber: kristof.beyls. Herald added a project: All. ahatanak requested review of this revision. Herald added a subscriber: wangpc. Using `L` for type `l

[PATCH] D155123: [Driver] Warn about -mios-version-min instead of erroring out when targeting MachO embedded architectures

ahatanak created this revision. ahatanak added reviewers: arphaman, t.p.northover, MaskRay. ahatanak added a project: clang. Herald added a subscriber: kristof.beyls. Herald added a project: All. ahatanak requested review of this revision. Sometimes users pass this option when targeting embedded a

[PATCH] D155123: [Driver] Warn about -mios-version-min instead of erroring out when targeting MachO embedded architectures

ahatanak closed this revision. ahatanak marked 2 inline comments as done. ahatanak added a comment. Thank you for the review. 509d051606e837d1b8291743cd1683cf8c582afc Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D155408: [Driver] Also warn about -mwatchos-version-min and -mtvos-version-min

ahatanak added inline comments. Comment at: clang/lib/Driver/ToolChains/Darwin.cpp:89 +// Don't reject these -version-min= if we have the appropriate triple. if (T.isiOS()) for (Arg *A : Args.filtered(options::OPT_mios_version_min_EQ)) I just real

[PATCH] D155408: [Driver] Also warn about -mwatchos-version-min and -mtvos-version-min

ahatanak accepted this revision. ahatanak added a comment. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D155408/new/ https://reviews.llvm.org/D155408 ___ cfe-commits mailing list cfe-commits@lists.l

[PATCH] D139171: Don't revisit the subexpressions of PseudoObjectExpr when building a ParentMap

ahatanak created this revision. ahatanak added reviewers: rjmccall, jordan_rose. ahatanak added a project: clang. Herald added a project: All. ahatanak requested review of this revision. The assertion that is removed in this patch was failing when ObjC dot notation expressions appear in both side

[PATCH] D139171: Don't revisit the subexpressions of PseudoObjectExpr when building a ParentMap

This revision was automatically updated to reflect the committed changes. Closed by commit rG1127e479e850: Don't revisit the subexpressions of PseudoObjectExpr when building a (authored by ahatanak). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D1391

[PATCH] D66094: [CodeGen] Emit destructor calls for non-trivial C structs returned by function calls and loaded from volatile objects

This revision was automatically updated to reflect the committed changes. Closed by commit rGd35a454170da: [CodeGen] Emit destructor calls to destruct non-trivial C struct objects… (authored by ahatanak). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/

[PATCH] D75491: [CodeGenObjC] Privatize some ObjC metadata symbols

ahatanak accepted this revision. ahatanak added a comment. This revision is now accepted and ready to land. LGTM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75491/new/ https://reviews.llvm.org/D75491 ___ cfe-commits mailing list cfe-commi

[PATCH] D64464: [CodeGen] Emit destructor calls to destruct compound literals

ahatanak updated this revision to Diff 247919. ahatanak marked 5 inline comments as done. ahatanak retitled this revision from "[CodeGen] Emit destructor calls for non-trivial C structs" to "[CodeGen] Emit destructor calls to destruct compound literals". ahatanak edited the summary of this revisi

[PATCH] D64464: [CodeGen] Emit destructor calls to destruct compound literals

ahatanak added inline comments. Comment at: test/Import/objc-arc/Inputs/cleanup-objects.m:6 +id getObj(int c, id a) { + // Commenting out the following line because AST importer crashes when trying + // to import a BlockExpr. martong wrote: > Perhaps then this

[PATCH] D64464: [CodeGen] Emit destructor calls to destruct compound literals

ahatanak marked an inline comment as done. ahatanak added inline comments. Comment at: lib/CodeGen/CGExpr.cpp:4100 + if (E->getType().isDestructedType() == QualType::DK_nontrivial_c_struct) +pushDestroy(QualType::DK_nontrivial_c_struct, DeclPtr, E->getType()); +

[PATCH] D66094: [CodeGen] Emit destructor calls for non-trivial C structs returned by function calls and loaded from volatile objects

ahatanak updated this revision to Diff 248363. ahatanak marked 2 inline comments as done. ahatanak removed a project: LLVM. ahatanak removed a subscriber: llvm-commits. ahatanak added a comment. Herald added a subscriber: ributzka. Address review comments. - Declare the flags in `ReturnValueSlot`

[PATCH] D58164: Block+lambda: allow reference capture

ahatanak updated this revision to Diff 248371. ahatanak changed the repository for this revision from rC Clang to rG LLVM Github Monorepo. ahatanak added a comment. Herald added a subscriber: ributzka. Rebase and ping. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://r

[Diffusion] rG825235c140e7: Revert "[Sema] Use the canonical type in function isVector"

ahatanak added a subscriber: cfe-commits. BRANCHES master Users: ahatanak (Author) https://reviews.llvm.org/rG825235c140e7 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[Diffusion] rG825235c140e7: Revert "[Sema] Use the canonical type in function isVector"

ahatanak added a comment. The test is failing because `float16x4_t` is defined as a vector of `__fp16` in arm_neon.h and Sema promotes vectors of `__fp16` to vectors of float since `__fp16` is a storage-only type. The test used to pass because of a bug in function `isVector`, which was fixed i

[PATCH] D70935: [CodeGen][ObjC] Emit a primitive store to store a __strong field in ExpandTypeFromArgs

ahatanak created this revision. ahatanak added a reviewer: rjmccall. ahatanak added a project: clang. Herald added subscribers: ributzka, dexonsmith, jkorous. This fixes a bug in IRGen where a call to `llvm.objc.storeStrong` was being emitted to initialize a __strong field of an uninitialized tem

[PATCH] D70935: [CodeGen][ObjC] Emit a primitive store to store a __strong field in ExpandTypeFromArgs

ahatanak added a comment. Note that passing `isInit=true` to `EmitStoreThroughLValue` to make it emit `llvm.objc.retain` would be incorrect since the callee destructs the struct argument. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70935/new/ h

[PATCH] D70935: [CodeGen][ObjC] Emit a primitive store to store a __strong field in ExpandTypeFromArgs

ahatanak updated this revision to Diff 232027. ahatanak marked 2 inline comments as done. ahatanak added a comment. Call `EmitStoreThroughLValue` and `EmitLoadOfLValue` only when the lvalue is a bitfield. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.or

[PATCH] D70935: [CodeGen][ObjC] Emit a primitive store to store a __strong field in ExpandTypeFromArgs

ahatanak added inline comments. Comment at: clang/lib/CodeGen/CGCall.cpp:1054 + "pointer to __strong expected"); + EmitStoreOfScalar(*AI++, LV); +} else rjmccall wrote: > This definitely deserves a comment. > > I don't think the assertion is

[PATCH] D70935: [CodeGen][ObjC] Emit a primitive store to store a __strong field in ExpandTypeFromArgs

ahatanak closed this revision. ahatanak added a comment. Fixed in d8136f14f125fb27f2326f397df0964bf62078ca Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70935/new/ https://revie

[PATCH] D71431: Call objc_retainBlock before passing a block as a variadic argument

ahatanak created this revision. ahatanak added reviewers: rjmccall, arphaman. ahatanak added a project: clang. Herald added subscribers: ributzka, dexonsmith, jkorous. Copy the block to the heap before passing it to the callee in case the block escapes in the callee. rdar://problem/55683462 Re

[PATCH] D71431: Call objc_retainBlock before passing a block as a variadic argument

ahatanak updated this revision to Diff 233851. ahatanak added a comment. Explain why this change is needed in ARC documentation. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71431/new/ https://reviews.llvm.org/D71431 Files: clang/docs/Automatic

[PATCH] D71431: Call objc_retainBlock before passing a block as a variadic argument

ahatanak marked an inline comment as done. ahatanak added inline comments. Comment at: clang/docs/AutomaticReferenceCounting.rst:1866 +When a block pointer type is converted to type ``id``, ``Block_copy`` is called. +This is necessary because a block allocated on the stack won

[PATCH] D71431: Call objc_retainBlock before passing a block as a variadic argument

This revision was automatically updated to reflect the committed changes. Closed by commit rGa0a670614a36: Call objc_retainBlock before passing a block as a variadic argument (authored by ahatanak). Changed prior to commit: https://reviews.llvm.org/D71431?vs=233851&id=233862#toc Repository:

[Diffusion] rG825235c140e7: Revert "[Sema] Use the canonical type in function isVector"

ahatanak added a comment. I'm still not sure why `__fp16`, which is a storage-only type, is used for the element type of `float16x4_t` if we want to avoid promotion to a float vector type. https://clang.llvm.org/docs/LanguageExtensions.html#half-precision-floating-point Was there a discussion

[PATCH] D64464: [CodeGen] Emit destructor calls to destruct compound literals

ahatanak updated this revision to Diff 248586. ahatanak marked an inline comment as done. ahatanak added a comment. Return `make_error` instead of a nullptr. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64464/new/ https://reviews.llvm.org/D64464

[PATCH] D64464: [CodeGen] Emit destructor calls to destruct compound literals

ahatanak marked an inline comment as done. ahatanak added inline comments. Comment at: lib/CodeGen/CGExpr.cpp:4100 + if (E->getType().isDestructedType() == QualType::DK_nontrivial_c_struct) +pushDestroy(QualType::DK_nontrivial_c_struct, DeclPtr, E->getType()); +

[PATCH] D64464: [CodeGen] Emit destructor calls to destruct compound literals

ahatanak marked an inline comment as done. ahatanak added inline comments. Comment at: lib/CodeGen/CGExpr.cpp:4100 + if (E->getType().isDestructedType() == QualType::DK_nontrivial_c_struct) +pushDestroy(QualType::DK_nontrivial_c_struct, DeclPtr, E->getType()); +

[PATCH] D64464: [CodeGen] Emit destructor calls to destruct compound literals

ahatanak updated this revision to Diff 248797. ahatanak added a comment. Don't try to push a cleanup in C++. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64464/new/ https://reviews.llvm.org/D64464 Files: clang/include/clang/AST/ASTImporter.h

[PATCH] D64464: [CodeGen] Emit destructor calls to destruct compound literals

ahatanak updated this revision to Diff 249173. ahatanak marked 4 inline comments as done. ahatanak added a comment. Address review comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64464/new/ https://reviews.llvm.org/D64464 Files: clang/inc

[PATCH] D64464: [CodeGen] Emit destructor calls to destruct compound literals

ahatanak marked an inline comment as done. ahatanak added inline comments. Comment at: clang/lib/CodeGen/CGBlocks.cpp:869 + if (auto *BD = C.dyn_cast()) +enterBlockScope(*this, BD); } rjmccall wrote: > I wonder if we could just switch blocks to th

[PATCH] D58164: Block+lambda: allow reference capture

This revision was automatically updated to reflect the committed changes. Closed by commit rGe4dfc9f5bda3: Fix the type of the capture passed to LambdaIntroducer::addCapture in… (authored by ahatanak). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58

[PATCH] D66094: [CodeGen] Emit destructor calls for non-trivial C structs returned by function calls and loaded from volatile objects

ahatanak updated this revision to Diff 249190. ahatanak marked an inline comment as done. ahatanak added a comment. Fix the way `IsExternallyDestructed` is used. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66094/new/ https://reviews.llvm.org/D660

[PATCH] D64464: [CodeGen] Emit destructor calls to destruct compound literals

ahatanak marked 3 inline comments as done. ahatanak added inline comments. Comment at: lib/CodeGen/CGExpr.cpp:4100 + if (E->getType().isDestructedType() == QualType::DK_nontrivial_c_struct) +pushDestroy(QualType::DK_nontrivial_c_struct, DeclPtr, E->getType()); +

[PATCH] D64464: [CodeGen] Emit destructor calls to destruct compound literals

This revision was automatically updated to reflect the committed changes. ahatanak marked an inline comment as done. Closed by commit rG40568fec7e3e: [CodeGen] Emit destructor calls to destruct compound literals (authored by ahatanak). Changed prior to commit: https://reviews.llvm.org/D64464?vs

[Diffusion] rG825235c140e7: Revert "[Sema] Use the canonical type in function isVector"

ahatanak added a comment. Can we change the element type of the vector to `_Float16`? `typedef __attribute__((neon_vector_type(4))) _Float16 float16x4_t;` It seems that the original plan discussed on llvm-dev (http://lists.llvm.org/pipermail/cfe-dev/2017-May/053768.html) was to introduce `_Flo

[Diffusion] rG825235c140e7: Revert "[Sema] Use the canonical type in function isVector"

ahatanak added a comment. In rG825235c140e7747f686bd7902cb0f9af77590841#909794 , @SjoerdMeijer wrote: > > I'm still not sure why __fp16, which is a storage-only type, is used for > > the element type of float16x4_t if

[PATCH] D66094: [CodeGen] Emit destructor calls for non-trivial C structs returned by function calls and loaded from volatile objects

ahatanak updated this revision to Diff 250934. ahatanak marked 2 inline comments as done. ahatanak added a comment. Address review comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66094/new/ https://reviews.llvm.org/D66094 Files: clang/li

[PATCH] D66094: [CodeGen] Emit destructor calls for non-trivial C structs returned by function calls and loaded from volatile objects

ahatanak added inline comments. Comment at: clang/lib/Sema/SemaExpr.cpp:677 + E->getType().isDestructedType() == QualType::DK_nontrivial_c_struct) +Cleanup.setExprNeedsCleanups(true); + rjmccall wrote: > Why only when the l-value is volatile? I was tryin

[PATCH] D66094: [CodeGen] Emit destructor calls for non-trivial C structs returned by function calls and loaded from volatile objects

ahatanak marked an inline comment as done. ahatanak added inline comments. Comment at: clang/lib/Sema/SemaExpr.cpp:677 + E->getType().isDestructedType() == QualType::DK_nontrivial_c_struct) +Cleanup.setExprNeedsCleanups(true); + rjmccall wrote: > ahatana

[PATCH] D66094: [CodeGen] Emit destructor calls for non-trivial C structs returned by function calls and loaded from volatile objects

ahatanak marked an inline comment as done. ahatanak added inline comments. Comment at: clang/lib/Sema/SemaExpr.cpp:677 + E->getType().isDestructedType() == QualType::DK_nontrivial_c_struct) +Cleanup.setExprNeedsCleanups(true); + rjmccall wrote: > ahatana

[PATCH] D66094: [CodeGen] Emit destructor calls for non-trivial C structs returned by function calls and loaded from volatile objects

ahatanak added inline comments. Comment at: clang/lib/Sema/SemaExpr.cpp:677 + E->getType().isDestructedType() == QualType::DK_nontrivial_c_struct) +Cleanup.setExprNeedsCleanups(true); + rjmccall wrote: > ahatanak wrote: > > rjmccall wrote: > > > ahatanak

[PATCH] D66094: [CodeGen] Emit destructor calls for non-trivial C structs returned by function calls and loaded from volatile objects

ahatanak updated this revision to Diff 251463. ahatanak marked an inline comment as done. ahatanak added a comment. Teach `Expr::isConstantInitializer` that `ExprWithCleanups` can be a constant. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66094/ne

[PATCH] D42776: [Sema] Fix an assertion failure in constant expression evaluation of calls to functions with default arguments

ahatanak updated this revision to Diff 139797. ahatanak added a comment. Assign an uninitialized APValue to a temporary instead of removing it from the temporary map when the temporary's lifetime has ended. https://reviews.llvm.org/D42776 Files: include/clang/AST/APValue.h lib/AST/APValue.

[PATCH] D44908: [ObjC++] Make parameter passing and function return compatible with ObjC

ahatanak created this revision. ahatanak added reviewers: rjmccall, doug.gregor, rsmith. r326307 and r327870 made changes that enable __strong and __weak fields to be declared in C structs. This patch changes the ObjC++ ABI so that structs with __strong or __weak pointers can be passed to or ret

[PATCH] D44908: [ObjC++] Make parameter passing and function return compatible with ObjC

ahatanak added a comment. I tried to move the code in MicrosoftCXXABI::getRecordArgABI and ItaniumCXXABI::passClassIndirect that determine whether a struct is passed indirectly to Sema::CheckCompletedCXXClass, but couldn't do so since getClangABICompat() is a method of CodeGenOpts, which Sema d

[PATCH] D36918: [Sema] Take into account the current context when checking the accessibility of a member function pointer

ahatanak added a comment. ping https://reviews.llvm.org/D36918 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

<    4   5   6   7   8   9   10   11   12   13   >