[PATCH] D150860: [OpenMP] Change clang emitTargetDataCalls to use OMPIRBuilder

TIFitis marked 2 inline comments as not done. TIFitis added a comment. Ping for reviews :) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150860/new/ https://reviews.llvm.org/D150860 ___ cfe-commits maili

[PATCH] D147218: [OpenMP][Flang][MLIR] Lowering of OpenMP requires directive from parse tree to MLIR

TIFitis added inline comments. Comment at: flang/lib/Lower/OpenMP.cpp:2552 + +void handleDeclareTarget(Fortran::lower::AbstractConverter &converter, + Fortran::lower::pft::Evaluation &eval, This seems to be the only function name with the

[PATCH] D147218: [OpenMP][Flang][MLIR] Lowering of OpenMP requires directive from parse tree to MLIR

TIFitis accepted this revision. TIFitis added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147218/new/ https://reviews.llvm.org/D147218 _

[PATCH] D150860: [OpenMP] Change clang emitTargetDataCalls to use OMPIRBuilder

TIFitis updated this revision to Diff 527931. TIFitis marked 2 inline comments as done. TIFitis added a comment. Addressed reviewer comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150860/new/ https://reviews.llvm.org/D150860 Files: clang

[PATCH] D142914: [MLIR][OpenMP] Added OMPIRBuilder support for Target Data directives.

TIFitis updated this revision to Diff 495493. TIFitis marked 4 inline comments as done. TIFitis added a comment. Changed namespace to mlir::LLVM for common files. Addressed reviewer comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142914/new/

[PATCH] D142914: [MLIR][OpenMP] Added OMPIRBuilder support for Target Data directives.

TIFitis updated this revision to Diff 495530. TIFitis edited the summary of this revision. TIFitis added a comment. Added explicit failure for use_device_ptr and use_device_addr clauses. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142914/new/ htt

[PATCH] D142914: [MLIR][OpenMP] Added OMPIRBuilder support for Target Data directives.

TIFitis updated this revision to Diff 495864. TIFitis marked 5 inline comments as done. TIFitis added a comment. Addressed reviewer comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142914/new/ https://reviews.llvm.org/D142914 Files: clang/

[PATCH] D142914: [MLIR][OpenMP] Added OMPIRBuilder support for Target Data directives.

TIFitis updated this revision to Diff 497045. TIFitis added a comment. Fixing build errors. Added mlir/lib/Target/LLVMIR/Dialect/Utils.cpp, made it part of the MLIRTargetLLVMIRExport lib. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142914/new/ h

[PATCH] D142914: [MLIR][OpenMP] Added OMPIRBuilder support for Target Data directives.

TIFitis added a comment. @kiranchandramohan @clementval can you please take a look and let me know if any more changes are required for this patch? Thanks, Akash Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142914/new/ https://reviews.llvm.org/D

[PATCH] D142914: [MLIR][OpenMP] Added OMPIRBuilder support for Target Data directives.

TIFitis marked 4 inline comments as done. TIFitis added a comment. In D142914#4144475 , @kiranchandramohan wrote: > Please add tests for the MLIR portion. Can you please tell me where to add these? > Could you also post the full LLVM IR for a construct

[PATCH] D142914: [MLIR][OpenMP] Added OMPIRBuilder support for Target Data directives.

TIFitis updated this revision to Diff 499583. TIFitis marked an inline comment as done. TIFitis added a comment. Addressed reviewer comments, fixed error in MLIR translation. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142914/new/ https://reviews

[PATCH] D149666: [OpenMP][OMPIRBuilder] Migrate MapCombinedInfoTy from Clang to OpenMPIRBuilder

This revision was automatically updated to reflect the committed changes. TIFitis marked 2 inline comments as done. Closed by commit rG35309db7dcef: [OpenMP][OMPIRBuilder] Migrate MapCombinedInfoTy from Clang to OpenMPIRBuilder (authored by TIFitis). Repository: rG LLVM Github Monorepo CHANGES

[PATCH] D149872: [OpenMP][OMPIRBuilder] Migrate emitOffloadingArrays and EmitNonContiguousDescriptor from Clang

TIFitis created this revision. TIFitis added reviewers: jdoerfert, jsjodin. Herald added subscribers: sunshaoce, guansong, hiraditya, yaxunl. Herald added a project: All. TIFitis requested review of this revision. Herald added subscribers: llvm-commits, cfe-commits, jplehr, sstefan1. Herald added p

[PATCH] D149872: [OpenMP][OMPIRBuilder] Migrate emitOffloadingArrays and EmitNonContiguousDescriptor from Clang

TIFitis updated this revision to Diff 519822. TIFitis added a comment. Changed std::function to llvm::function_ref for the callbacks. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D149872/new/ https://reviews.llvm.org/D149872 Files: clang/lib/Cod

[PATCH] D149872: [OpenMP][OMPIRBuilder] Migrate emitOffloadingArrays and EmitNonContiguousDescriptor from Clang

TIFitis updated this revision to Diff 520730. TIFitis added a comment. Addressed reviewer comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D149872/new/ https://reviews.llvm.org/D149872 Files: clang/lib/CodeGen/CGOpenMPRuntime.cpp llvm/in

[PATCH] D149872: [OpenMP][OMPIRBuilder] Migrate emitOffloadingArrays and EmitNonContiguousDescriptor from Clang

TIFitis marked 3 inline comments as done. TIFitis added a comment. Ping for review :) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D149872/new/ https://reviews.llvm.org/D149872 ___ cfe-commits mailing li

[PATCH] D146557: [MLIR][OpenMP] Refactoring how map clause is processed

TIFitis updated this revision to Diff 523303. TIFitis added a comment. Done migrating from Clang. This makes use of the clang functions now. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146557/new/ https://reviews.llvm.org/D146557 Files: llvm/i

[PATCH] D146557: [MLIR][OpenMP] Refactoring createTargetData in OMPIRBuilder

TIFitis updated this revision to Diff 523304. TIFitis edited the summary of this revision. TIFitis added a comment. Small fix to code comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146557/new/ https://reviews.llvm.org/D146557 Files: llv

[PATCH] D146557: [MLIR][OpenMP] Refactoring createTargetData in OMPIRBuilder

TIFitis updated this revision to Diff 523316. TIFitis added a comment. Rebased Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146557/new/ https://reviews.llvm.org/D146557 Files: llvm/include/llvm/Frontend/OpenMP/OMPIRBuilder.h llvm/lib/Frontend

[PATCH] D146557: [MLIR][OpenMP] Refactoring createTargetData in OMPIRBuilder

TIFitis updated this revision to Diff 523318. TIFitis added a comment. Fix lint messages Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146557/new/ https://reviews.llvm.org/D146557 Files: llvm/include/llvm/Frontend/OpenMP/OMPIRBuilder.h llvm/li

[PATCH] D146557: [MLIR][OpenMP] Refactoring createTargetData in OMPIRBuilder

TIFitis updated this revision to Diff 523331. TIFitis added a comment. Try to fix patch application. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146557/new/ https://reviews.llvm.org/D146557 Files: llvm/include/llvm/Frontend/OpenMP/OMPIRBuilder

[PATCH] D150860: [OpenMP] Change clang emitTargetDataCalls to use OMPIRBuilder

TIFitis created this revision. TIFitis added reviewers: jsjodin, dpalermo, kiranktp, jdoerfert. Herald added subscribers: sunshaoce, guansong, hiraditya, yaxunl. Herald added a project: All. TIFitis requested review of this revision. Herald added subscribers: llvm-commits, cfe-commits, jplehr, sste

[PATCH] D149872: [OpenMP][OMPIRBuilder] Migrate emitOffloadingArrays and EmitNonContiguousDescriptor from Clang

TIFitis updated this revision to Diff 523340. TIFitis added a comment. Rebasing Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D149872/new/ https://reviews.llvm.org/D149872 Files: clang/lib/CodeGen/CGOpenMPRuntime.cpp llvm/include/llvm/Frontend/

[PATCH] D150860: [OpenMP] Change clang emitTargetDataCalls to use OMPIRBuilder

TIFitis added inline comments. Comment at: clang/test/OpenMP/target_data_codegen.cpp:67-68 - // CK1-DAG: call void @__tgt_target_data_end_mapper(ptr @{{.+}}, i64 [[DEV:%[^,]+]], i32 1, ptr [[GEPBP:%.+]], ptr [[GEPP:%.+]], ptr [[SIZE00]], ptr [[MTYPE00]], ptr null, ptr null) -

[PATCH] D146557: [MLIR][OpenMP] Refactoring how map clause is processed

TIFitis added a comment. In D146557#4283149 , @kiranchandramohan wrote: > Please update the summary to convey all the changes introduced in the patch. > > From the tests, it looks like there is a substantial change in the IR. I was > hoping this to be a

[PATCH] D146557: [MLIR][OpenMP] Refactoring how map clause is processed

TIFitis updated this revision to Diff 515805. TIFitis marked an inline comment as done. TIFitis edited the summary of this revision. TIFitis added a comment. Updated tests. Addressed reviewer comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D1

[PATCH] D146557: [MLIR][OpenMP] Refactoring how map clause is processed

TIFitis marked 2 inline comments as done. TIFitis added inline comments. Comment at: mlir/test/Target/LLVMIR/omptarget-llvm.mlir:4-5 -llvm.func @_QPopenmp_target_data() { - %0 = llvm.mlir.constant(1 : i64) : i64 - %1 = llvm.alloca %0 x i32 {bindc_name = "i", in_type = i32, ope

[PATCH] D142914: [MLIR][OpenMP] Added OMPIRBuilder support for Target Data directives.

TIFitis added inline comments. Comment at: mlir/lib/Target/LLVMIR/Dialect/OpenMP/OpenMPToLLVMIRTranslation.cpp:1533 +ompLoc, builder.saveIP(), mapTypeFlags, mapNames, mapperAllocas, +mapperFunc, deviceID, ifCond, processMapOpCB, bodyCB)); + } else {

[PATCH] D142914: [MLIR][OpenMP] Added OMPIRBuilder support for Target Data directives.

TIFitis added inline comments. Comment at: mlir/lib/Target/LLVMIR/Dialect/OpenMP/OpenMPToLLVMIRTranslation.cpp:1533 +ompLoc, builder.saveIP(), mapTypeFlags, mapNames, mapperAllocas, +mapperFunc, deviceID, ifCond, processMapOpCB, bodyCB)); + } else {

[PATCH] D142914: [MLIR][OpenMP] Added OMPIRBuilder support for Target Data directives.

TIFitis marked 3 inline comments as done. TIFitis added inline comments. Comment at: mlir/lib/Target/LLVMIR/Dialect/OpenMP/OpenMPToLLVMIRTranslation.cpp:1491 +mapTypes = exitDataOp.getMapTypes(); +mapperFunc = false; +return success(); ---

[PATCH] D146557: [MLIR][OpenMP] Refactoring how map clause is processed

TIFitis updated this revision to Diff 516379. TIFitis marked an inline comment as done. TIFitis added a comment. Cleaned up how IsBegin argument is passed for createTargetData call. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146557/new/ https://

[PATCH] D146557: [MLIR][OpenMP] Refactoring how map clause is processed

TIFitis added a comment. In D146557#4295550 , @kiranchandramohan wrote: > In D146557#4292223 , @TIFitis wrote: > >> Cleaned up how IsBegin argument is passed for createTargetData call. > > Please submit this dire

[PATCH] D146557: [MLIR][OpenMP] Refactoring how map clause is processed

TIFitis updated this revision to Diff 517548. TIFitis added a comment. Rebased Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146557/new/ https://reviews.llvm.org/D146557 Files: clang/lib/CodeGen/CGOpenMPRuntime.cpp llvm/include/llvm/Frontend/O

[PATCH] D146557: [MLIR][OpenMP] Refactoring how map clause is processed

TIFitis updated this revision to Diff 517921. TIFitis added a comment. Rebased Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146557/new/ https://reviews.llvm.org/D146557 Files: clang/lib/CodeGen/CGOpenMPRuntime.cpp llvm/include/llvm/Frontend/O

[PATCH] D146557: [MLIR][OpenMP] Refactoring how map clause is processed

TIFitis planned changes to this revision. TIFitis added a comment. @kiranchandramohan I am in the process of submitting a new patch for review which moves the map processing from Clang Codegen to OMPIRBuilder. Once that is moved we can just use that for dealing with the map operands. Thus puttin

[PATCH] D149666: [OpenMP][OMPIRBuilder] Migrate MapCombinedInfoTy from Clang to OpenMPIRBuilder

TIFitis created this revision. TIFitis added reviewers: jsjodin, jdoerfert, dpalermo. Herald added subscribers: sunshaoce, guansong, yaxunl. Herald added a project: All. TIFitis requested review of this revision. Herald added subscribers: llvm-commits, cfe-commits, jplehr, sstefan1. Herald added pr

[PATCH] D149666: [OpenMP][OMPIRBuilder] Migrate MapCombinedInfoTy from Clang to OpenMPIRBuilder

TIFitis marked 2 inline comments as done. TIFitis added inline comments. Comment at: clang/lib/CodeGen/CGOpenMPRuntime.cpp:6848 + class MapCombinedInfoTy : public llvm::OpenMPIRBuilder::MapCombinedInfoTy { + public: MapExprsArrayTy Exprs; jdoerfert wrote:

[PATCH] D149666: [OpenMP][OMPIRBuilder] Migrate MapCombinedInfoTy from Clang to OpenMPIRBuilder

TIFitis updated this revision to Diff 518847. TIFitis marked 2 inline comments as done. TIFitis added a comment. Merged MapDevPtrsArrayTy and MapMappersArrayTy into single type named MapValueDeclsArrayTy in CGOpenMPRuntime.cpp Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION h

[PATCH] D149666: [OpenMP][OMPIRBuilder] Migrate MapCombinedInfoTy from Clang to OpenMPIRBuilder

TIFitis updated this revision to Diff 519054. TIFitis added a comment. Changed name from llvm::OpenMPIRBuilder::MapCombinedInfoTy to llvm::OpenMPIRBuilder::MapInfosTy, and changed to struct instead of class. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm

[PATCH] D149666: [OpenMP][OMPIRBuilder] Migrate MapCombinedInfoTy from Clang to OpenMPIRBuilder

TIFitis marked 2 inline comments as done. TIFitis added inline comments. Comment at: clang/lib/CodeGen/CGOpenMPRuntime.cpp:6848 + class MapCombinedInfoTy : public llvm::OpenMPIRBuilder::MapCombinedInfoTy { + public: MapExprsArrayTy Exprs; jdoerfert wrote:

[PATCH] D150860: [OpenMP] Change clang emitTargetDataCalls to use OMPIRBuilder

TIFitis marked an inline comment as done. TIFitis added inline comments. Comment at: clang/test/OpenMP/target_data_codegen.cpp:355-356 // Region 00 +// CK2-DAG: [[DEV:%[^,]+]] = sext i32 [[DEVi32:%[^,]+]] to i64 +// CK2-DAG: [[DEVi32]] = load i32, ptr %{{[^,]+}}, // CK2: br i1

[PATCH] D152554: [OpenMP] Migrate deviice code privatization from Clang CodeGen to OMPIRBuilder

TIFitis created this revision. TIFitis added reviewers: jsjodin, jdoerfert, kiranktp. Herald added subscribers: sunshaoce, guansong, hiraditya, yaxunl. Herald added a project: All. TIFitis requested review of this revision. Herald added subscribers: llvm-commits, cfe-commits, jplehr, sstefan1. Hera

[PATCH] D152554: [OpenMP] Migrate deviice code privatization from Clang CodeGen to OMPIRBuilder

TIFitis added inline comments. Comment at: clang/lib/CodeGen/CGStmtOpenMP.cpp:7170-7234 +const llvm::Value *DevPtr = nullptr; // In order to identify the right initializer we need to match the // declaration used by the mapping logic. In some cases we may get

[PATCH] D149872: [OpenMP][OMPIRBuilder] Migrate emitOffloadingArrays and EmitNonContiguousDescriptor from Clang

TIFitis updated this revision to Diff 530508. TIFitis marked 4 inline comments as done. TIFitis added a comment. Addressed reviewer comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D149872/new/ https://reviews.llvm.org/D149872 Files: clang

[PATCH] D149872: [OpenMP][OMPIRBuilder] Migrate emitOffloadingArrays and EmitNonContiguousDescriptor from Clang

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG3401a5f7584a: [OpenMP][OMPIRBuilder] Migrate emitOffloadingArrays and… (authored by TIFitis). Repository: rG LLVM Github Monorepo CHANGES SINCE L

[PATCH] D146557: [MLIR][OpenMP] Refactoring createTargetData in OMPIRBuilder

TIFitis updated this revision to Diff 530518. TIFitis marked 5 inline comments as done and an inline comment as not done. TIFitis added a comment. Addressed reviewer comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146557/new/ https://review

[PATCH] D146557: [MLIR][OpenMP] Refactoring createTargetData in OMPIRBuilder

TIFitis added inline comments. Comment at: llvm/lib/Frontend/OpenMP/OMPIRBuilder.cpp:4727 + Builder.ClearInsertionPoint(); +} + jdoerfert wrote: > This function doesn't make sense to me. For one, I don't know what a "unreal > block" is. Nor would I have expecte

[PATCH] D150860: [OpenMP] Change clang emitTargetDataCalls to use OMPIRBuilder

TIFitis updated this revision to Diff 530533. TIFitis marked an inline comment as done. TIFitis added a comment. Rebased Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150860/new/ https://reviews.llvm.org/D150860 Files: clang/lib/CodeGen/CGOpenMP

[PATCH] D152554: [OpenMP] Migrate deviice code privatization from Clang CodeGen to OMPIRBuilder

TIFitis updated this revision to Diff 530548. TIFitis added a comment. Rebased Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152554/new/ https://reviews.llvm.org/D152554 Files: clang/lib/CodeGen/CGOpenMPRuntime.cpp clang/lib/CodeGen/CGOpenMPRu

[PATCH] D146557: [MLIR][OpenMP] Refactoring createTargetData in OMPIRBuilder

TIFitis updated this revision to Diff 530671. TIFitis marked 6 inline comments as done. TIFitis added a comment. Addressed reviewer comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146557/new/ https://reviews.llvm.org/D146557 Files: llvm/

[PATCH] D146557: [MLIR][OpenMP] Refactoring createTargetData in OMPIRBuilder

TIFitis updated this revision to Diff 530680. TIFitis added a comment. Update MLIR BodyGen callback. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146557/new/ https://reviews.llvm.org/D146557 Files: llvm/include/llvm/Frontend/OpenMP/OMPIRBuilder

[PATCH] D146557: [MLIR][OpenMP] Refactoring createTargetData in OMPIRBuilder

TIFitis added inline comments. Comment at: llvm/lib/Frontend/OpenMP/OMPIRBuilder.cpp:4741 + if (IsFinished && BB->use_empty()) { +delete BB; +return; jdoerfert wrote: > you should not just delete BB. eraseFromParent is a better way. That said, it > is a

[PATCH] D150860: [OpenMP] Change clang emitTargetDataCalls to use OMPIRBuilder

TIFitis updated this revision to Diff 530865. TIFitis added a comment. Rebased Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150860/new/ https://reviews.llvm.org/D150860 Files: clang/lib/CodeGen/CGOpenMPRuntime.cpp clang/test/OpenMP/target_dat

[PATCH] D152554: [OpenMP] Migrate deviice code privatization from Clang CodeGen to OMPIRBuilder

TIFitis updated this revision to Diff 531395. TIFitis added a comment. Rebased Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152554/new/ https://reviews.llvm.org/D152554 Files: clang/lib/CodeGen/CGOpenMPRuntime.cpp clang/lib/CodeGen/CGOpenMPRu

[PATCH] D152554: [OpenMP] Migrate deviice code privatization from Clang CodeGen to OMPIRBuilder

TIFitis updated this revision to Diff 531401. TIFitis added a comment. Fixed typo Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152554/new/ https://reviews.llvm.org/D152554 Files: clang/lib/CodeGen/CGOpenMPRuntime.cpp clang/lib/CodeGen/CGOpenM

[PATCH] D146557: [MLIR][OpenMP] Refactoring createTargetData in OMPIRBuilder

TIFitis updated this revision to Diff 531760. TIFitis marked 3 inline comments as done. TIFitis added a comment. Addressed reviewer comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146557/new/ https://reviews.llvm.org/D146557 Files: llvm/i

[PATCH] D146557: [MLIR][OpenMP] Refactoring createTargetData in OMPIRBuilder

TIFitis added inline comments. Comment at: llvm/include/llvm/Frontend/OpenMP/OMPIRBuilder.h:1487 + // possible, or else at the end of the function. + void emitBlock(BasicBlock *BB, Function *CurFn, bool IsFinished = false); + jdoerfert wrote: > jdoerfert wrote:

[PATCH] D150860: [OpenMP] Change clang emitTargetDataCalls to use OMPIRBuilder

TIFitis updated this revision to Diff 531761. TIFitis added a comment. Rebased Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150860/new/ https://reviews.llvm.org/D150860 Files: clang/lib/CodeGen/CGOpenMPRuntime.cpp clang/test/OpenMP/target_dat

[PATCH] D131915: [MLIR][OpenMP] Added target data, exit data, and enter data operation definition for MLIR.

TIFitis updated this revision to Diff 480029. TIFitis added a comment. Herald added a subscriber: Moerafaat. Changed map_operands to VariadicOfVariadic type. Variadic Enums are not supported, hence I've changed the map type to VariadicOfVariadic which allows to store the entire map clause includ

[PATCH] D131915: [MLIR][OpenMP] Added target data, exit data, and enter data operation definition for MLIR.

TIFitis marked an inline comment as done. TIFitis added a comment. If people are happy with this structure then I'll work on adding a pretty printer for the map clause. Please suggest any other changes that are required. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https:/

[PATCH] D131915: [MLIR][OpenMP] Added target data, exit data, and enter data operation definition for MLIR.

TIFitis updated this revision to Diff 482732. TIFitis added a comment. Added custom printer & parser for map clause. Updated ops.mlir test to address reviewer comments. Custom Printer example: OMP: !$omp target exit data map(from: a,b) map(release: c) map(delete: d) map(always, from: e) Custom

[PATCH] D131915: [MLIR][OpenMP] Added target data, exit data, and enter data operation definition for MLIR.

TIFitis marked 10 inline comments as done. TIFitis added inline comments. Comment at: mlir/test/Dialect/OpenMP/ops.mlir:389 +// CHECK: omp.target_data +"omp.target_data"(%if_cond, %device, %data1, %data2) ({ + clementval wrote: > Can you switch to

[PATCH] D131915: [MLIR][OpenMP] Added target data, exit data, and enter data operation definition for MLIR.

TIFitis updated this revision to Diff 483545. TIFitis marked 2 inline comments as done. TIFitis added a comment. Addresed reviewer comments. Added second map clause to test. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131915/new/ https://reviews.

[PATCH] D131915: [MLIR][OpenMP] Added target data, exit data, and enter data operation definition for MLIR.

TIFitis marked 3 inline comments as done. TIFitis added a comment. > Can you add this as a test? AFAIS, the tests attached to this patch do not > seem to be exercising the `VariadicofVariadic` requirement. An explanation > with an example would be great. `VariadicOfVariadic` gives us a `SmallVe

<    1   2