aybassiouny updated this revision to Diff 347504.
aybassiouny added a comment.
Add an assert
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D99031/new/
https://reviews.llvm.org/D99031
Files:
clang/lib/Format/TokenAnnotator.cpp
clang/unittests/Format/FormatTest.cpp
Index: clang/unit
aybassiouny added a comment.
Thanks @curdeius for checking this in, apologies for delay on my side. Glad the
bug is not there in the new version!
Comment at: clang/lib/Format/TokenAnnotator.cpp:3498
+ !Tok.isOneOf(TT_ObjCBlockLBrace, TT_DictLiteral) &&
+ !Tok
aybassiouny created this revision.
aybassiouny added reviewers: curdeius, Wawha, MyDeveloperDay,
HazardyKnusperkeks.
aybassiouny added a project: clang-format.
aybassiouny requested review of this revision.
Herald added a project: clang.
**Summary** `CompactNamespaces` config stops work when
`Al
aybassiouny added a comment.
> How about verifyFormat? Would that fail without your patch?
@HazardyKnusperkeks sorry, but not sure that I understand your point. Are you
suggesting to use verifyFormat in my UT instead of EXPECT_EQ?
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTIO
aybassiouny updated this revision to Diff 338403.
aybassiouny edited the summary of this revision.
aybassiouny added a comment.
After rechecking, turns out `AllowShortLambdasOnASingleLine` and
`BeforeLambdaBody` both need to be turned on in order for the regression to be
expressed, this affects
