Re: r304201 - [ARM] Fix Neon vector type alignment to 64-bit

2017-05-30 Thread Ahmed Bougacha via cfe-commits
On Tue, May 30, 2017 at 3:12 AM, Javed Absar via cfe-commits wrote: > Author: javed.absar > Date: Tue May 30 05:12:15 2017 > New Revision: 304201 > > URL: http://llvm.org/viewvc/llvm-project?rev=304201&view=rev > Log: > [ARM] Fix Neon vector type alignment to 64-bit > > The maximum alignment for A

Re: r321301 - [AArch64] Enable fp16 data type for the Builtin for AArch64 only.

2017-12-21 Thread Ahmed Bougacha via cfe-commits
On Thu, Dec 21, 2017 at 12:10 PM, Abderrazek Zaafrani via cfe-commits wrote: > Author: az > Date: Thu Dec 21 12:10:03 2017 > New Revision: 321301 > > URL: http://llvm.org/viewvc/llvm-project?rev=321301&view=rev > Log: > [AArch64] Enable fp16 data type for the Builtin for AArch64 only. > > Differen

r334550 - [CMake][Darwin] Match cxx-headers -> cxx_headers libcxx target rename.

2018-06-12 Thread Ahmed Bougacha via cfe-commits
Author: ab Date: Tue Jun 12 14:27:36 2018 New Revision: 334550 URL: http://llvm.org/viewvc/llvm-project?rev=334550&view=rev Log: [CMake][Darwin] Match cxx-headers -> cxx_headers libcxx target rename. This was changed in r334477. Modified: cfe/trunk/cmake/caches/Apple-stage2.cmake Modified:

Re: [libcxx] r334477 - [CMake] Use common variable for all header targets NFC

2018-06-12 Thread Ahmed Bougacha via cfe-commits
Hey Petr, FYI: clang has cmake caches that listed cxx-headers as a dependency; I fixed that in: r334550 [CMake][Darwin] Match cxx-headers -> cxx_headers libcxx target rename. -Ahmed On Mon, Jun 11, 2018 at 11:58 PM, Petr Hosek via cfe-commits wrote: > Author: phosek > Date: Mon Jun 11 23:58:06

Re: [libcxx] r334477 - [CMake] Use common variable for all header targets NFC

2018-06-12 Thread Ahmed Bougacha via cfe-commits
Well, that was wrong. There are more install-cxx-headers targets that the cache distribution implicitly depends on. Is there a reason for your cxx-headers -> cxx_headers change? If there is, should the other cxx-headers targets change as well? If not, can we revert it? I'll try to reproduce in

r354538 - [AArch64] Change size suffix for FP16FML intrinsics.

2019-02-20 Thread Ahmed Bougacha via cfe-commits
Author: ab Date: Wed Feb 20 17:13:27 2019 New Revision: 354538 URL: http://llvm.org/viewvc/llvm-project?rev=354538&view=rev Log: [AArch64] Change size suffix for FP16FML intrinsics. These currently use _u32, but they should instead use _f16, the types of the multiplication (matching the various i

Re: [libcxx] r334477 - [CMake] Use common variable for all header targets NFC

2018-06-27 Thread Ahmed Bougacha via cfe-commits
On Tue, Jun 12, 2018 at 8:04 PM, Ahmed Bougacha wrote: > Well, that was wrong. There are more install-cxx-headers targets that > the cache distribution implicitly depends on. > > Is there a reason for your cxx-headers -> cxx_headers change? If > there is, should the other cxx-headers targets cha

r335898 - [CMake] Make bootstrap and compiler-rt depend on cxx-headers.

2018-06-28 Thread Ahmed Bougacha via cfe-commits
Author: ab Date: Thu Jun 28 11:35:25 2018 New Revision: 335898 URL: http://llvm.org/viewvc/llvm-project?rev=335898&view=rev Log: [CMake] Make bootstrap and compiler-rt depend on cxx-headers. Since r334468, we no longer always copy the libcxx headers by virtue of their presence when cmake runs. T

[libcxx] r335899 - [CMake] Rename cxx_headers back to cxx-headers.

2018-06-28 Thread Ahmed Bougacha via cfe-commits
Author: ab Date: Thu Jun 28 11:35:35 2018 New Revision: 335899 URL: http://llvm.org/viewvc/llvm-project?rev=335899&view=rev Log: [CMake] Rename cxx_headers back to cxx-headers. r334477 renamed the cxx-headers target to cxx_headers, but various pieces sort-of expect the target names to match the c

Re: r319727 - Generalize "static data member instantiated" notification to cover variable templates too.

2017-12-05 Thread Ahmed Bougacha via cfe-commits
On Tue, Dec 5, 2017 at 11:40 AM, Richard Smith via cfe-commits wrote: > Sorry about that, fixed in r319817. Hey Richard, Looks like that's not enough on darwin: http://green.lab.llvm.org/green/job/clang-stage1-cmake-RA-incremental/44764/consoleFull#-126347322349ba4694-19c4-4d7e-bec5-911270d8a

r320112 - Remove line-endings added by r320089. NFC.

2017-12-07 Thread Ahmed Bougacha via cfe-commits
Author: ab Date: Thu Dec 7 14:58:02 2017 New Revision: 320112 URL: http://llvm.org/viewvc/llvm-project?rev=320112&view=rev Log: Remove line-endings added by r320089. NFC. Modified: cfe/trunk/include/clang/Basic/LangOptions.def Modified: cfe/trunk/include/clang/Basic/LangOptions.def URL: ht

Re: r320089 - Add new language mode flags for C17.

2017-12-07 Thread Ahmed Bougacha via cfe-commits
On Thu, Dec 7, 2017 at 2:56 PM, Richard Smith via cfe-commits wrote: > Looks like this might have messed up the line endings in a few files? Should be taken care of in r320112. -Ahmed > On 7 December 2017 at 13:46, Aaron Ballman via cfe-commits > wrote: >> >> Author: aaronballman >> Date: Thu

Re: r320089 - Add new language mode flags for C17.

2017-12-07 Thread Ahmed Bougacha via cfe-commits
On Thu, Dec 7, 2017 at 3:00 PM, Aaron Ballman wrote: > On Thu, Dec 7, 2017 at 5:59 PM, Ahmed Bougacha > wrote: >> On Thu, Dec 7, 2017 at 2:56 PM, Richard Smith via cfe-commits >> wrote: >>> Looks like this might have messed up the line endings in a few files? >> >> Should be taken care of in r3

Re: r320089 - Add new language mode flags for C17.

2017-12-07 Thread Ahmed Bougacha via cfe-commits
On Thu, Dec 7, 2017 at 3:05 PM, Aaron Ballman wrote: > On Thu, Dec 7, 2017 at 6:00 PM, Aaron Ballman wrote: >> On Thu, Dec 7, 2017 at 5:59 PM, Ahmed Bougacha >> wrote: >>> On Thu, Dec 7, 2017 at 2:56 PM, Richard Smith via cfe-commits >>> wrote: Looks like this might have messed up the lin

Re: r315996 - [CMake][OpenMP] Customize default offloading arch

2017-12-07 Thread Ahmed Bougacha via cfe-commits
Hi Jonas, On Tue, Oct 17, 2017 at 6:37 AM, Jonas Hahnfeld via cfe-commits wrote: > Author: hahnfeld > Date: Tue Oct 17 06:37:36 2017 > New Revision: 315996 > > URL: http://llvm.org/viewvc/llvm-project?rev=315996&view=rev > Log: > [CMake][OpenMP] Customize default offloading arch > > For the shuff

[clang] [llvm] [clang-tools-extra] [llvm] Support IFuncs on Darwin platforms (PR #73686)

2023-12-05 Thread Ahmed Bougacha via cfe-commits
@@ -882,8 +882,11 @@ class AsmPrinter : public MachineFunctionPass { GCMetadataPrinter *getOrCreateGCPrinter(GCStrategy &S); void emitGlobalAlias(Module &M, const GlobalAlias &GA); - void emitGlobalIFunc(Module &M, const GlobalIFunc &GI); +protected: + virtual void emi

[llvm] [clang] [clang-tools-extra] [llvm] Support IFuncs on Darwin platforms (PR #73686)

2023-12-05 Thread Ahmed Bougacha via cfe-commits
@@ -144,7 +144,12 @@ bool CallLowering::lowerCall(MachineIRBuilder &MIRBuilder, const CallBase &CB, // Try looking through a bitcast from one function type to another. // Commonly happens with calls to objc_msgSend(). const Value *CalleeV = CB.getCalledOperand()->stripPo

[clang] [clang-tools-extra] [llvm] [llvm] Support IFuncs on Darwin platforms (PR #73686)

2023-12-05 Thread Ahmed Bougacha via cfe-commits
@@ -1809,6 +1814,255 @@ void AArch64AsmPrinter::emitInstruction(const MachineInstr *MI) { EmitToStreamer(*OutStreamer, TmpInst); } +void AArch64AsmPrinter::emitGlobalIFunc(Module &M, const GlobalIFunc &GI) { + if (!TM.getTargetTriple().isOSBinFormatMachO()) +return Asm

[llvm] [clang] [clang-tools-extra] [llvm] Support IFuncs on Darwin platforms (PR #73686)

2023-12-05 Thread Ahmed Bougacha via cfe-commits
https://github.com/ahmedbougacha edited https://github.com/llvm/llvm-project/pull/73686 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[libc] [lld] [clang] [libcxx] [lldb] [mlir] [clang-tools-extra] [libcxxabi] [flang] [llvm] [openmp] [compiler-rt] [llvm] Support IFuncs on Darwin platforms (PR #73686)

2023-12-13 Thread Ahmed Bougacha via cfe-commits
https://github.com/ahmedbougacha commented: Only a couple minor comments, LG otherwise, thanks! The Subtarget weirdness is unfortunate but I can't say I have a better alternative https://github.com/llvm/llvm-project/pull/73686 ___ cfe-commits mailing

[libcxx] [clang] [libcxxabi] [lld] [flang] [openmp] [mlir] [llvm] [libc] [compiler-rt] [clang-tools-extra] [lldb] [llvm] Support IFuncs on Darwin platforms (PR #73686)

2023-12-13 Thread Ahmed Bougacha via cfe-commits
https://github.com/ahmedbougacha edited https://github.com/llvm/llvm-project/pull/73686 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[lldb] [clang] [openmp] [lld] [compiler-rt] [libc] [flang] [libcxxabi] [llvm] [libcxx] [clang-tools-extra] [mlir] [llvm] Support IFuncs on Darwin platforms (PR #73686)

2023-12-13 Thread Ahmed Bougacha via cfe-commits
@@ -599,6 +599,26 @@ class AsmPrinter : public MachineFunctionPass { /// instructions in verbose mode. virtual void emitImplicitDef(const MachineInstr *MI) const; + /// getSubtargetInfo() cannot be used where this is needed because we don't + /// have a MachineFunction w

[llvm] [libcxxabi] [compiler-rt] [mlir] [openmp] [lldb] [flang] [clang-tools-extra] [libc] [lld] [libcxx] [clang] [llvm] Support IFuncs on Darwin platforms (PR #73686)

2023-12-13 Thread Ahmed Bougacha via cfe-commits
@@ -2147,24 +2148,80 @@ void AsmPrinter::emitGlobalIFunc(Module &M, const GlobalIFunc &GI) { assert(!TM.getTargetTriple().isOSBinFormatXCOFF() && "IFunc is not supported on AIX."); - MCSymbol *Name = getSymbol(&GI); + auto EmitLinkage = [&](MCSymbol *Sym) { +

[lld] [clang] [libcxx] [llvm] [libc] [mlir] [libcxxabi] [openmp] [lldb] [clang-tools-extra] [compiler-rt] [flang] [llvm] Support IFuncs on Darwin platforms (PR #73686)

2023-12-14 Thread Ahmed Bougacha via cfe-commits
@@ -2169,8 +2169,11 @@ void AsmPrinter::emitGlobalIFunc(Module &M, const GlobalIFunc &GI) { MCSymbol *LocalAlias = getSymbolPreferLocal(GI); if (LocalAlias != Name) OutStreamer->emitAssignment(LocalAlias, Expr); - } else if (TM.getTargetTriple().isOSBinFormatMac

[clang-tools-extra] [libc] [openmp] [lld] [compiler-rt] [libcxxabi] [clang] [libcxx] [lldb] [mlir] [flang] [llvm] [llvm] Support IFuncs on Darwin platforms (PR #73686)

2023-12-14 Thread Ahmed Bougacha via cfe-commits
https://github.com/ahmedbougacha approved this pull request. Neat, ty! https://github.com/llvm/llvm-project/pull/73686 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[llvm] [clang] AArch64: add support for currently released Apple CPUs. (PR #73499)

2023-11-28 Thread Ahmed Bougacha via cfe-commits
https://github.com/ahmedbougacha approved this pull request. https://github.com/llvm/llvm-project/pull/73499 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[llvm] [clang] [AArch64][PAC] Support ptrauth builtins and -fptrauth-intrinsics. (PR #65996)

2024-01-08 Thread Ahmed Bougacha via cfe-commits
https://github.com/ahmedbougacha updated https://github.com/llvm/llvm-project/pull/65996 >From c4e7c86eb967b4313e19587e33fdc6b50c8cd6a7 Mon Sep 17 00:00:00 2001 From: Ahmed Bougacha Date: Wed, 16 Aug 2023 09:17:12 -0700 Subject: [PATCH] [AArch64][PAC] Support and document ptrauth builtins and

[clang] 89c94c2 - [clang][Driver] Get darwin -Xarch_ working for subtypes, again.

2022-03-09 Thread Ahmed Bougacha via cfe-commits
Author: Ahmed Bougacha Date: 2022-03-09T18:21:45-08:00 New Revision: 89c94c242c7ddcc700aba6af7243dcac7a9a4ef2 URL: https://github.com/llvm/llvm-project/commit/89c94c242c7ddcc700aba6af7243dcac7a9a4ef2 DIFF: https://github.com/llvm/llvm-project/commit/89c94c242c7ddcc700aba6af7243dcac7a9a4ef2.diff

[clang] 6ba68a5 - [clang][Driver] Use a VersionTuple for darwin linker version checks.

2022-02-08 Thread Ahmed Bougacha via cfe-commits
Author: Ahmed Bougacha Date: 2022-02-08T14:30:39-08:00 New Revision: 6ba68a5fc34271c85f438217f50e165cb0158c04 URL: https://github.com/llvm/llvm-project/commit/6ba68a5fc34271c85f438217f50e165cb0158c04 DIFF: https://github.com/llvm/llvm-project/commit/6ba68a5fc34271c85f438217f50e165cb0158c04.diff

[clang] ca9f0ec - [clang] Document objc_unsafeClaimAutoreleasedReturnValue.

2022-02-08 Thread Ahmed Bougacha via cfe-commits
Author: Ahmed Bougacha Date: 2022-02-08T14:30:39-08:00 New Revision: ca9f0ec1a30b899ce9df3d2173aa9a295b510509 URL: https://github.com/llvm/llvm-project/commit/ca9f0ec1a30b899ce9df3d2173aa9a295b510509 DIFF: https://github.com/llvm/llvm-project/commit/ca9f0ec1a30b899ce9df3d2173aa9a295b510509.diff

[clang] [llvm] [CodeGen][AArch64][FMV] PAC the stub_helper's frame on arm64e (PR #84704)

2024-03-15 Thread Ahmed Bougacha via cfe-commits
@@ -2085,6 +2099,37 @@ void AArch64AsmPrinter::emitMachOIFuncStubHelperBody(Module &M, .addImm(2), *STI); + if (TM.getTargetTriple().isArm64e()) { +// autibsp ahmedbougacha wrote: Leave

[clang] [llvm] [AArch64][PAC] Support ptrauth builtins and -fptrauth-intrinsics. (PR #65996)

2024-03-15 Thread Ahmed Bougacha via cfe-commits
https://github.com/ahmedbougacha updated https://github.com/llvm/llvm-project/pull/65996 >From 1492d6362a1a4f6d65fb7001bdefb5250f30754e Mon Sep 17 00:00:00 2001 From: Ahmed Bougacha Date: Wed, 16 Aug 2023 09:17:12 -0700 Subject: [PATCH] [AArch64][PAC] Support and document ptrauth builtins and

[clang] [llvm] [AArch64][PAC] Support ptrauth builtins and -fptrauth-intrinsics. (PR #65996)

2024-03-15 Thread Ahmed Bougacha via cfe-commits
https://github.com/ahmedbougacha edited https://github.com/llvm/llvm-project/pull/65996 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [AArch64][PAC] Support ptrauth builtins and -fptrauth-intrinsics. (PR #65996)

2024-03-15 Thread Ahmed Bougacha via cfe-commits
https://github.com/ahmedbougacha closed https://github.com/llvm/llvm-project/pull/65996 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [CodeGen][AArch64][FMV] PAC the stub_helper's frame on arm64e (PR #84704)

2024-03-15 Thread Ahmed Bougacha via cfe-commits
@@ -2085,6 +2099,37 @@ void AArch64AsmPrinter::emitMachOIFuncStubHelperBody(Module &M, .addImm(2), *STI); + if (TM.getTargetTriple().isArm64e()) { +// autibsp ahmedbougacha wrote: There

[clang] [llvm] [AArch64][PAC] Support ptrauth builtins and -fptrauth-intrinsics. (PR #65996)

2024-02-26 Thread Ahmed Bougacha via cfe-commits
https://github.com/ahmedbougacha updated https://github.com/llvm/llvm-project/pull/65996 >From c5cde09a5ea4a4cfcf3287f7462c38335493c02d Mon Sep 17 00:00:00 2001 From: Ahmed Bougacha Date: Wed, 16 Aug 2023 09:17:12 -0700 Subject: [PATCH] [AArch64][PAC] Support and document ptrauth builtins and

[clang] [llvm] [AArch64][PAC] Support ptrauth builtins and -fptrauth-intrinsics. (PR #65996)

2024-02-26 Thread Ahmed Bougacha via cfe-commits
@@ -0,0 +1,265 @@ +Pointer Authentication +== + +.. contents:: + :local: + +Introduction + + +Pointer authentication is a technology which offers strong probabilistic protection against exploiting a broad class of memory bugs to take control of

[clang] [llvm] [AArch64][PAC] Support ptrauth builtins and -fptrauth-intrinsics. (PR #65996)

2024-02-26 Thread Ahmed Bougacha via cfe-commits
@@ -0,0 +1,265 @@ +Pointer Authentication +== + +.. contents:: + :local: + +Introduction + + +Pointer authentication is a technology which offers strong probabilistic protection against exploiting a broad class of memory bugs to take control of

[clang] [llvm] [AArch64][PAC] Support ptrauth builtins and -fptrauth-intrinsics. (PR #65996)

2024-02-26 Thread Ahmed Bougacha via cfe-commits
@@ -0,0 +1,265 @@ +Pointer Authentication +== + +.. contents:: + :local: + +Introduction + + +Pointer authentication is a technology which offers strong probabilistic protection against exploiting a broad class of memory bugs to take control of

[clang] [llvm] [AArch64][PAC] Support ptrauth builtins and -fptrauth-intrinsics. (PR #65996)

2024-02-26 Thread Ahmed Bougacha via cfe-commits
ahmedbougacha wrote: Updated, tried to address all the comments; let me know if I missed something! https://github.com/llvm/llvm-project/pull/65996 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo

[clang] f77c948 - [Triple][MachO] Define "arm64e", an AArch64 subarch for Pointer Auth.

2020-12-03 Thread Ahmed Bougacha via cfe-commits
Author: Ahmed Bougacha Date: 2020-12-03T07:53:59-08:00 New Revision: f77c948d56b09b839262e258af5c6ad701e5b168 URL: https://github.com/llvm/llvm-project/commit/f77c948d56b09b839262e258af5c6ad701e5b168 DIFF: https://github.com/llvm/llvm-project/commit/f77c948d56b09b839262e258af5c6ad701e5b168.diff

[clang] [AArch64][PAC] Support ptrauth builtins and -fptrauth-intrinsics. (PR #65996)

2023-09-11 Thread Ahmed Bougacha via cfe-commits
https://github.com/ahmedbougacha labeled https://github.com/llvm/llvm-project/pull/65996 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [AArch64][PAC] Support ptrauth builtins and -fptrauth-intrinsics. (PR #65996)

2023-09-11 Thread Ahmed Bougacha via cfe-commits
https://github.com/ahmedbougacha created https://github.com/llvm/llvm-project/pull/65996: This defines the basic set of pointer authentication clang builtins (provided in a new header, ptrauth.h), with diagnostics and IRGen support. The availability of the builtins is gated on a new flag, `-f

[clang] [AArch64][PAC] Support ptrauth builtins and -fptrauth-intrinsics. (PR #65996)

2023-09-11 Thread Ahmed Bougacha via cfe-commits
https://github.com/ahmedbougacha review_requested https://github.com/llvm/llvm-project/pull/65996 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [AArch64][PAC] Support ptrauth builtins and -fptrauth-intrinsics. (PR #65996)

2023-09-11 Thread Ahmed Bougacha via cfe-commits
https://github.com/ahmedbougacha review_requested https://github.com/llvm/llvm-project/pull/65996 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [AArch64][PAC] Support ptrauth builtins and -fptrauth-intrinsics. (PR #65996)

2023-09-11 Thread Ahmed Bougacha via cfe-commits
https://github.com/ahmedbougacha review_requested https://github.com/llvm/llvm-project/pull/65996 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [AArch64][PAC] Support ptrauth builtins and -fptrauth-intrinsics. (PR #65996)

2023-09-11 Thread Ahmed Bougacha via cfe-commits
https://github.com/ahmedbougacha review_requested https://github.com/llvm/llvm-project/pull/65996 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [AArch64][PAC] Support ptrauth builtins and -fptrauth-intrinsics. (PR #65996)

2023-09-11 Thread Ahmed Bougacha via cfe-commits
https://github.com/ahmedbougacha labeled https://github.com/llvm/llvm-project/pull/65996 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [AArch64][PAC] Support ptrauth builtins and -fptrauth-intrinsics. (PR #65996)

2023-09-11 Thread Ahmed Bougacha via cfe-commits
https://github.com/ahmedbougacha review_requested https://github.com/llvm/llvm-project/pull/65996 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [AArch64][PAC] Support ptrauth builtins and -fptrauth-intrinsics. (PR #65996)

2023-09-11 Thread Ahmed Bougacha via cfe-commits
https://github.com/ahmedbougacha review_requested https://github.com/llvm/llvm-project/pull/65996 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [AArch64][PAC] Support ptrauth builtins and -fptrauth-intrinsics. (PR #65996)

2023-09-11 Thread Ahmed Bougacha via cfe-commits
https://github.com/ahmedbougacha review_requested https://github.com/llvm/llvm-project/pull/65996 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [AArch64][PAC] Support ptrauth builtins and -fptrauth-intrinsics. (PR #65996)

2023-09-11 Thread Ahmed Bougacha via cfe-commits
https://github.com/ahmedbougacha review_requested https://github.com/llvm/llvm-project/pull/65996 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [AArch64][PAC] Support ptrauth builtins and -fptrauth-intrinsics. (PR #65996)

2023-09-11 Thread Ahmed Bougacha via cfe-commits
https://github.com/ahmedbougacha review_requested https://github.com/llvm/llvm-project/pull/65996 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [AArch64][PAC] Support ptrauth builtins and -fptrauth-intrinsics. (PR #65996)

2023-09-11 Thread Ahmed Bougacha via cfe-commits
https://github.com/ahmedbougacha review_requested https://github.com/llvm/llvm-project/pull/65996 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [AArch64][PAC] Support ptrauth builtins and -fptrauth-intrinsics. (PR #65996)

2023-09-12 Thread Ahmed Bougacha via cfe-commits
@@ -303,6 +303,10 @@ bool Module::directlyUses(const Module *Requested) { if (!Requested->Parent && Requested->Name == "_Builtin_stddef_max_align_t") return true; + // Anyone is allowed to use our builtin ptrauth.h and its accompanying module. + if (!Requested->Parent

[clang] [AArch64][PAC] Support ptrauth builtins and -fptrauth-intrinsics. (PR #65996)

2023-09-12 Thread Ahmed Bougacha via cfe-commits
@@ -0,0 +1,548 @@ +Pointer Authentication +== + +.. contents:: + :local: + +Introduction + + +Pointer authentication is a technology which offers strong probabilistic protection against exploiting a broad class of memory bugs to take control of

[clang] [AArch64][PAC] Support ptrauth builtins and -fptrauth-intrinsics. (PR #65996)

2023-09-12 Thread Ahmed Bougacha via cfe-commits
@@ -0,0 +1,548 @@ +Pointer Authentication +== + +.. contents:: + :local: + +Introduction + + +Pointer authentication is a technology which offers strong probabilistic protection against exploiting a broad class of memory bugs to take control of

[clang] [AArch64][PAC] Support ptrauth builtins and -fptrauth-intrinsics. (PR #65996)

2023-09-12 Thread Ahmed Bougacha via cfe-commits
@@ -0,0 +1,548 @@ +Pointer Authentication +== + +.. contents:: + :local: + +Introduction + + +Pointer authentication is a technology which offers strong probabilistic protection against exploiting a broad class of memory bugs to take control of

[clang] [AArch64][PAC] Support ptrauth builtins and -fptrauth-intrinsics. (PR #65996)

2023-09-12 Thread Ahmed Bougacha via cfe-commits
@@ -0,0 +1,548 @@ +Pointer Authentication +== + +.. contents:: + :local: + +Introduction + + +Pointer authentication is a technology which offers strong probabilistic protection against exploiting a broad class of memory bugs to take control of

[clang] [AArch64][PAC] Support ptrauth builtins and -fptrauth-intrinsics. (PR #65996)

2023-09-12 Thread Ahmed Bougacha via cfe-commits
@@ -0,0 +1,548 @@ +Pointer Authentication +== + +.. contents:: + :local: + +Introduction + + +Pointer authentication is a technology which offers strong probabilistic protection against exploiting a broad class of memory bugs to take control of

[clang] [AArch64][PAC] Support ptrauth builtins and -fptrauth-intrinsics. (PR #65996)

2023-09-12 Thread Ahmed Bougacha via cfe-commits
@@ -0,0 +1,548 @@ +Pointer Authentication +== + +.. contents:: + :local: + +Introduction + + +Pointer authentication is a technology which offers strong probabilistic protection against exploiting a broad class of memory bugs to take control of

[clang] [AArch64][PAC] Support ptrauth builtins and -fptrauth-intrinsics. (PR #65996)

2023-09-12 Thread Ahmed Bougacha via cfe-commits
@@ -0,0 +1,548 @@ +Pointer Authentication +== + +.. contents:: + :local: + +Introduction + + +Pointer authentication is a technology which offers strong probabilistic protection against exploiting a broad class of memory bugs to take control of

[clang] [AArch64][PAC] Support ptrauth builtins and -fptrauth-intrinsics. (PR #65996)

2023-09-12 Thread Ahmed Bougacha via cfe-commits
@@ -0,0 +1,548 @@ +Pointer Authentication +== + +.. contents:: + :local: + +Introduction + + +Pointer authentication is a technology which offers strong probabilistic protection against exploiting a broad class of memory bugs to take control of

[clang] [AArch64][PAC] Support ptrauth builtins and -fptrauth-intrinsics. (PR #65996)

2023-09-12 Thread Ahmed Bougacha via cfe-commits
https://github.com/ahmedbougacha edited https://github.com/llvm/llvm-project/pull/65996 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [AArch64][PAC] Support ptrauth builtins and -fptrauth-intrinsics. (PR #65996)

2023-09-12 Thread Ahmed Bougacha via cfe-commits
https://github.com/ahmedbougacha updated https://github.com/llvm/llvm-project/pull/65996: >From fccf0643bd7812301819f5c7fce30d81c6e86a80 Mon Sep 17 00:00:00 2001 From: Ahmed Bougacha Date: Wed, 16 Aug 2023 09:17:12 -0700 Subject: [PATCH] [AArch64][PAC] Support and document ptrauth builtins and

[clang] [AArch64][PAC] Support ptrauth builtins and -fptrauth-intrinsics. (PR #65996)

2023-09-12 Thread Ahmed Bougacha via cfe-commits
https://github.com/ahmedbougacha edited https://github.com/llvm/llvm-project/pull/65996 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [AArch64][PAC] Support ptrauth builtins and -fptrauth-intrinsics. (PR #65996)

2023-09-12 Thread Ahmed Bougacha via cfe-commits
@@ -303,6 +303,10 @@ bool Module::directlyUses(const Module *Requested) { if (!Requested->Parent && Requested->Name == "_Builtin_stddef_max_align_t") return true; + // Anyone is allowed to use our builtin ptrauth.h and its accompanying module. + if (!Requested->Parent

r318545 - [CodeGen] Compute the objc EH vtable address point using inbounds GEP.

2017-11-17 Thread Ahmed Bougacha via cfe-commits
Author: ab Date: Fri Nov 17 11:46:47 2017 New Revision: 318545 URL: http://llvm.org/viewvc/llvm-project?rev=318545&view=rev Log: [CodeGen] Compute the objc EH vtable address point using inbounds GEP. The object is provided by the objc runtime and is never visible in the module itself, but even so

r289839 - [Driver] Bump default x86 cpu to Penryn when targeting macosx10.12+.

2016-12-15 Thread Ahmed Bougacha via cfe-commits
Author: ab Date: Thu Dec 15 12:14:27 2016 New Revision: 289839 URL: http://llvm.org/viewvc/llvm-project?rev=289839&view=rev Log: [Driver] Bump default x86 cpu to Penryn when targeting macosx10.12+. 10.12 dropped support for all pre-Penryn Macs. Modified: cfe/trunk/lib/Driver/Tools.cpp cf

Re: [clang-tools-extra] r280839 - Resubmit "Add a test for clang-tidy using the clang-cl driver."

2016-09-08 Thread Ahmed Bougacha via cfe-commits
Hi Zachary, This test has been failing on some OS X machines, e.g.: http://lab.llvm.org:8080/green/job/clang-stage1-configure-RA_check/21470/consoleFull#19036563798254eaf0-7326-4999-85b0-388101f2d404 My hypothesis is that the %s path ('/Users/...') is somehow interpreted as a '/U' by the clan

Re: [clang-tools-extra] r280839 - Resubmit "Add a test for clang-tidy using the clang-cl driver."

2016-09-08 Thread Ahmed Bougacha via cfe-commits
On Thu, Sep 8, 2016 at 9:38 AM, Zachary Turner wrote: > What happens if you put the %s in quotes? Same error -Ahmed > > On Thu, Sep 8, 2016 at 9:32 AM Ahmed Bougacha > wrote: >> >> Hi Zachary, >> >> This test has been failing on some OS X machines, e.g.: >> >> http://lab.llvm.org:8080/green/jo

[clang-tools-extra] r280975 - Revert "Resubmit "Add a test for clang-tidy using the clang-cl driver.""

2016-09-08 Thread Ahmed Bougacha via cfe-commits
Author: ab Date: Thu Sep 8 13:02:14 2016 New Revision: 280975 URL: http://llvm.org/viewvc/llvm-project?rev=280975&view=rev Log: Revert "Resubmit "Add a test for clang-tidy using the clang-cl driver."" This reverts commit r280839. It's problematic on OS X, where the '/Users/...' paths are interpr

Re: [clang-tools-extra] r280839 - Resubmit "Add a test for clang-tidy using the clang-cl driver."

2016-09-08 Thread Ahmed Bougacha via cfe-commits
On Thu, Sep 8, 2016 at 9:52 AM, Zachary Turner wrote: > I don't have access to an OSX machine to test on, but if you do, is there > any way you could test this command line manually using a path that starts > with /U and see if you can reproduce it? (Did you mean to include a command line?) I tri

Re: r301410 - [OPENMP] Move handling of threadprivate vars from the stack, NFC.

2017-04-26 Thread Ahmed Bougacha via cfe-commits
Hey Alexey, This is causing asan errors, e.g.: ==4735==ERROR: AddressSanitizer: heap-buffer-overflow on address 0x61f00e70 at pc 0x00010a8a7f4a bp 0x7fff5c57a390 sp 0x7fff5c57a388 READ of size 4 at 0x61f00e70 thread T0 #0 0x10a8a7f49 in (anonymous namespace)::DSAStackTy::hasDSA(clang:

r302079 - [Driver] Update AArch64 testcase to match llvm r302078.

2017-05-03 Thread Ahmed Bougacha via cfe-commits
Author: ab Date: Wed May 3 15:34:32 2017 New Revision: 302079 URL: http://llvm.org/viewvc/llvm-project?rev=302079&view=rev Log: [Driver] Update AArch64 testcase to match llvm r302078. Modified: cfe/trunk/test/Preprocessor/aarch64-target-features.c Modified: cfe/trunk/test/Preprocessor/aarch

r249205 - Don't nil check non-nil class receiver of AArch64 stret calls.

2015-10-02 Thread Ahmed Bougacha via cfe-commits
Author: ab Date: Fri Oct 2 17:41:59 2015 New Revision: 249205 URL: http://llvm.org/viewvc/llvm-project?rev=249205&view=rev Log: Don't nil check non-nil class receiver of AArch64 stret calls. I randomly came across this difference between AArch64 and other targets: on the latter, we don't emit ni

r249213 - [Headers][X86] Fix stream_load (movntdqa) to accept const*.

2015-10-02 Thread Ahmed Bougacha via cfe-commits
Author: ab Date: Fri Oct 2 18:29:26 2015 New Revision: 249213 URL: http://llvm.org/viewvc/llvm-project?rev=249213&view=rev Log: [Headers][X86] Fix stream_load (movntdqa) to accept const*. Per Intel intrinsics guide: - _mm256_stream_load_si256 takes `__m256i const *' - _mm_stream_load_si128 takes

Re: [PATCH] D7297: [clang][Headers] _mm_stream_load_si128 should accept const arguments.

2015-10-02 Thread Ahmed Bougacha via cfe-commits
ab closed this revision. ab added a comment. Stumbled upon this while looking for the intel guide! Fixed in r249213. http://reviews.llvm.org/D7297 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo

Re: [PATCH] D12143: [X86][AVX2] Replace avx2.pbroadcast / avx2.vbroadcast intrinsics usage in avx2intrin.h with __builtin_shufflevector

2015-08-19 Thread Ahmed Bougacha via cfe-commits
ab added a comment. Heh, this is http://reviews.llvm.org/D10556, no? :P Repository: rL LLVM http://reviews.llvm.org/D12143 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

r245605 - [Headers][X86] Use __builtin_shufflevector in AVX2 broadcasts.

2015-08-20 Thread Ahmed Bougacha via cfe-commits
Author: ab Date: Thu Aug 20 15:27:21 2015 New Revision: 245605 URL: http://llvm.org/viewvc/llvm-project?rev=245605&view=rev Log: [Headers][X86] Use __builtin_shufflevector in AVX2 broadcasts. This lets us optimize them better. We agreed to remove the intrinsics, instead of combining them later, a

Re: [PATCH] D10556: [Headers][X86] Replace avx2.pbroadcast intrinsics with native IR.

2015-08-20 Thread Ahmed Bougacha via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL245605: [Headers][X86] Use __builtin_shufflevector in AVX2 broadcasts. (authored by ab). Changed prior to commit: http://reviews.llvm.org/D10556?vs=27973&id=32729#toc Repository: rL LLVM http://revi

[PATCH] D12212: [Headers][X86] Add -O0 assembly tests for intrinsics.

2015-08-20 Thread Ahmed Bougacha via cfe-commits
ab created this revision. ab added reviewers: spatel, RKSimon. ab added subscribers: cfe-commits, chandlerc, silvas, qcolombet. We agreed in D10555 that, as long as we don't affect -O0 codegen too much, it's OK to use native constructs rather than intrinsics. Let's test that, starting with AVX2

Re: [PATCH] D12240: [AArch64] Define the macro __ARM_FP16_ARGS

2015-08-21 Thread Ahmed Bougacha via cfe-commits
ab added a subscriber: ab. ab accepted this revision. ab added a reviewer: ab. ab added a comment. This revision is now accepted and ready to land. LGTM, thanks! http://reviews.llvm.org/D12240 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

r245761 - [ARM NEON] Factor out FP-prototype checking. NFC.

2015-08-21 Thread Ahmed Bougacha via cfe-commits
Author: ab Date: Fri Aug 21 18:24:18 2015 New Revision: 245761 URL: http://llvm.org/viewvc/llvm-project?rev=245761&view=rev Log: [ARM NEON] Factor out FP-prototype checking. NFC. Modified: cfe/trunk/utils/TableGen/NeonEmitter.cpp Modified: cfe/trunk/utils/TableGen/NeonEmitter.cpp URL: http:

r245763 - [ARM NEON] Use the common naming scheme for vcvt f16 builtins. NFC.

2015-08-21 Thread Ahmed Bougacha via cfe-commits
Author: ab Date: Fri Aug 21 18:34:20 2015 New Revision: 245763 URL: http://llvm.org/viewvc/llvm-project?rev=245763&view=rev Log: [ARM NEON] Use the common naming scheme for vcvt f16 builtins. NFC. We had "vcvt_f16" and "VCVT_HIGH_F16": for other FP types, this naming is used for intrinsics with i

r245778 - [ARM NEON] Remove special-case for f16 vcvt handling. NFCI.

2015-08-21 Thread Ahmed Bougacha via cfe-commits
Author: ab Date: Fri Aug 21 20:30:13 2015 New Revision: 245778 URL: http://llvm.org/viewvc/llvm-project?rev=245778&view=rev Log: [ARM NEON] Remove special-case for f16 vcvt handling. NFCI. We can use the 'H' typespec modifier to use 128-bit vectors directly in the only two users of this special-c

r245901 - [ARM NEON] Add missing AArch64 vget tests.

2015-08-24 Thread Ahmed Bougacha via cfe-commits
Author: ab Date: Mon Aug 24 18:34:25 2015 New Revision: 245901 URL: http://llvm.org/viewvc/llvm-project?rev=245901&view=rev Log: [ARM NEON] Add missing AArch64 vget tests. Added: cfe/trunk/test/CodeGen/aarch64-neon-vget.c - copied, changed from r245893, cfe/trunk/test/CodeGen/arm64_vget

r245904 - [ARM NEON] Replace redundant code with a new GetFloatNeonType. NFC.

2015-08-24 Thread Ahmed Bougacha via cfe-commits
Author: ab Date: Mon Aug 24 18:41:31 2015 New Revision: 245904 URL: http://llvm.org/viewvc/llvm-project?rev=245904&view=rev Log: [ARM NEON] Replace redundant code with a new GetFloatNeonType. NFC. Modified: cfe/trunk/lib/CodeGen/CGBuiltin.cpp Modified: cfe/trunk/lib/CodeGen/CGBuiltin.cpp URL

r245906 - [ARM NEON] Use CGF cached Types instead of llvm::Type::get. NFC.

2015-08-24 Thread Ahmed Bougacha via cfe-commits
Author: ab Date: Mon Aug 24 18:47:29 2015 New Revision: 245906 URL: http://llvm.org/viewvc/llvm-project?rev=245906&view=rev Log: [ARM NEON] Use CGF cached Types instead of llvm::Type::get. NFC. Modified: cfe/trunk/lib/CodeGen/CGBuiltin.cpp Modified: cfe/trunk/lib/CodeGen/CGBuiltin.cpp URL:

r245915 - [ARM NEON] Remove the old AArch64 vset_lane tests. NFC.

2015-08-24 Thread Ahmed Bougacha via cfe-commits
Author: ab Date: Mon Aug 24 20:00:05 2015 New Revision: 245915 URL: http://llvm.org/viewvc/llvm-project?rev=245915&view=rev Log: [ARM NEON] Remove the old AArch64 vset_lane tests. NFC. They are now properly tested, since r245901. Removed: cfe/trunk/test/CodeGen/arm64_vset_lane.c Removed: cf

r245987 - [Headers][X86] Add -O0 assembly tests for avx2 intrinsics.

2015-08-25 Thread Ahmed Bougacha via cfe-commits
Author: ab Date: Tue Aug 25 18:09:05 2015 New Revision: 245987 URL: http://llvm.org/viewvc/llvm-project?rev=245987&view=rev Log: [Headers][X86] Add -O0 assembly tests for avx2 intrinsics. We agreed for r245605 that, as long as we don't affect -O0 codegen too much, it's OK to use native constructs

Re: [PATCH] D12212: [Headers][X86] Add -O0 assembly tests for intrinsics.

2015-08-25 Thread Ahmed Bougacha via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL245987: [Headers][X86] Add -O0 assembly tests for avx2 intrinsics. (authored by ab). Changed prior to commit: http://reviews.llvm.org/D12212?vs=32732&id=33147#toc Repository: rL LLVM http://reviews.

Re: [PATCH] D12212: [Headers][X86] Add -O0 assembly tests for intrinsics.

2015-08-25 Thread Ahmed Bougacha via cfe-commits
ab added a comment. Thanks Simon! Replaced the FIXMEs with proper tests and committed. Whenever I have time I'll have a look at the others, filed PR24580. Repository: rL LLVM http://reviews.llvm.org/D12212 ___ cfe-commits mailing list cfe-commi

r245992 - [Headers] Require x86-registered for r245987 codegen tests.

2015-08-25 Thread Ahmed Bougacha via cfe-commits
Author: ab Date: Tue Aug 25 18:42:55 2015 New Revision: 245992 URL: http://llvm.org/viewvc/llvm-project?rev=245992&view=rev Log: [Headers] Require x86-registered for r245987 codegen tests. Modified: cfe/trunk/test/CodeGen/avx2-builtins.c Modified: cfe/trunk/test/CodeGen/avx2-builtins.c URL:

r246094 - [ARM] Mark mcr/mrc builtin operands as required-immediate.

2015-08-26 Thread Ahmed Bougacha via cfe-commits
Author: ab Date: Wed Aug 26 17:21:07 2015 New Revision: 246094 URL: http://llvm.org/viewvc/llvm-project?rev=246094&view=rev Log: [ARM] Mark mcr/mrc builtin operands as required-immediate. An early error message is better than the "cannot select" alternative. Modified: cfe/trunk/include/clang

[PATCH] D12389: Conditionalize X86 Darwin MaxVectorAlign on the presence of AVX.

2015-08-26 Thread Ahmed Bougacha via cfe-commits
ab created this revision. ab added a reviewer: rjmccall. ab added a subscriber: cfe-commits. The long-overdue (sorry!) prequel to D10724. http://reviews.llvm.org/D12389 Files: lib/Basic/Targets.cpp test/CodeGen/vector-alignment.c Index: test/CodeGen/vector-alignment.c ==

[PATCH] D12390: Also enable the avx/avx512 ABIs for i386, not just x86_64.

2015-08-26 Thread Ahmed Bougacha via cfe-commits
ab created this revision. ab added a reviewer: rjmccall. ab added a subscriber: cfe-commits. One problem that came up in D12389 is that i386 doesn't know about the "avx" ABIs. Judging by the commit that originally introduced the X86_64 check and the "avx" ABI (r145652), it was just unnecessary.

Re: [PATCH] D12390: Also enable the avx/avx512 ABIs for i386, not just x86_64.

2015-08-27 Thread Ahmed Bougacha via cfe-commits
ab added a comment. Unless I'm misunderstanding, I believe this has much less impact than you're thinking; there are three cases: - x86_64: no change (-mno-mmx is guarded by x86) - x86, with -mno-mmx: no change (because previously, we'd only set avx/avx512 for x86_64) - x86, without -mno-mmx: t

Re: [PATCH] D12389: Conditionalize X86 Darwin MaxVectorAlign on the presence of AVX.

2015-08-27 Thread Ahmed Bougacha via cfe-commits
ab accepted this revision. ab added a reviewer: ab. ab added a comment. This revision is now accepted and ready to land. Yep, thanks! http://reviews.llvm.org/D12389 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bi

r246228 - [X86] Use AVX features instead of ABI to init. SimdDefaultAlign.

2015-08-27 Thread Ahmed Bougacha via cfe-commits
Author: ab Date: Thu Aug 27 17:24:56 2015 New Revision: 246228 URL: http://llvm.org/viewvc/llvm-project?rev=246228&view=rev Log: [X86] Use AVX features instead of ABI to init. SimdDefaultAlign. The ABI string only exists to communicate with TargetCodeGenInfo. Concretely, since we only used "avx*"

  1   2   3   >