r340188 - Close FileEntries of cached files in ModuleManager::addModule().

Author: adrian Date: Mon Aug 20 10:10:27 2018 New Revision: 340188 URL: http://llvm.org/viewvc/llvm-project?rev=340188&view=rev Log: Close FileEntries of cached files in ModuleManager::addModule(). While investigating why LLDB (which can build hundreds of clang modules during one debug session) w

r314700 - Add a testcase to check that debug info is upgraded when compiling LLVM IR

Author: adrian Date: Mon Oct 2 11:31:52 2017 New Revision: 314700 URL: http://llvm.org/viewvc/llvm-project?rev=314700&view=rev Log: Add a testcase to check that debug info is upgraded when compiling LLVM IR through clang. Added: cfe/trunk/test/CodeGen/verify-debuginfo.ll Added: cfe/trunk/te

r315392 - Include getting generated struct offsets in CodegenABITypes

Author: adrian Date: Tue Oct 10 16:54:21 2017 New Revision: 315392 URL: http://llvm.org/viewvc/llvm-project?rev=315392&view=rev Log: Include getting generated struct offsets in CodegenABITypes This change adds a new function, CodeGen::getFieldNumber, that enables a user of clang's code generation

r341842 - Remove all uses of DIFlagBlockByrefStruct

Author: adrian Date: Mon Sep 10 09:14:28 2018 New Revision: 341842 URL: http://llvm.org/viewvc/llvm-project?rev=341842&view=rev Log: Remove all uses of DIFlagBlockByrefStruct This patch removes the last reason why DIFlagBlockByrefStruct from Clang by directly implementing the drilling into the me

r324761 - Introduce an API for LLDB to compute the default module cache path

Author: adrian Date: Fri Feb 9 10:43:10 2018 New Revision: 324761 URL: http://llvm.org/viewvc/llvm-project?rev=324761&view=rev Log: Introduce an API for LLDB to compute the default module cache path LLDB creates Clang modules and had an incomplete copy of the clang Driver code that compute the -

r324917 - Add a unit test for Driver::getDefaultModuleCachePath().

Author: adrian Date: Mon Feb 12 09:59:54 2018 New Revision: 324917 URL: http://llvm.org/viewvc/llvm-project?rev=324917&view=rev Log: Add a unit test for Driver::getDefaultModuleCachePath(). Added: cfe/trunk/unittests/Driver/ModuleCacheTest.cpp Modified: cfe/trunk/unittests/Driver/CMakeLis

Re: [PATCH] D43128: Introduce an API for LLDB to compute the default module cache path

> On Feb 12, 2018, at 8:32 AM, David Blaikie wrote: > > Unit test? Added in r324917. -- adrian ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

r321115 - Silence a bunch of implicit fallthrough warnings

Author: adrian Date: Tue Dec 19 14:06:11 2017 New Revision: 321115 URL: http://llvm.org/viewvc/llvm-project?rev=321115&view=rev Log: Silence a bunch of implicit fallthrough warnings Modified: cfe/trunk/lib/AST/ASTDumper.cpp cfe/trunk/lib/AST/Expr.cpp cfe/trunk/lib/AST/ExprCXX.cpp

r321116 - Add explicit break (PR35700).

Author: adrian Date: Tue Dec 19 14:21:48 2017 New Revision: 321116 URL: http://llvm.org/viewvc/llvm-project?rev=321116&view=rev Log: Add explicit break (PR35700). Modified: cfe/trunk/lib/Sema/SemaTemplateDeduction.cpp Modified: cfe/trunk/lib/Sema/SemaTemplateDeduction.cpp URL: http://llvm.o

r321321 - Delete dead code.

Author: adrian Date: Thu Dec 21 15:03:05 2017 New Revision: 321321 URL: http://llvm.org/viewvc/llvm-project?rev=321321&view=rev Log: Delete dead code. Modified: cfe/trunk/lib/CodeGen/CGDebugInfo.cpp Modified: cfe/trunk/lib/CodeGen/CGDebugInfo.cpp URL: http://llvm.org/viewvc/llvm-project/cfe

r321750 - Simplify code (NFC)

Author: adrian Date: Wed Jan 3 10:31:04 2018 New Revision: 321750 URL: http://llvm.org/viewvc/llvm-project?rev=321750&view=rev Log: Simplify code (NFC) Modified: cfe/trunk/lib/CodeGen/ObjectFilePCHContainerOperations.cpp Modified: cfe/trunk/lib/CodeGen/ObjectFilePCHContainerOperations.cpp U

r321754 - -gmodules: Emit debug info for implicit module imports via #include.

Author: adrian Date: Wed Jan 3 11:10:21 2018 New Revision: 321754 URL: http://llvm.org/viewvc/llvm-project?rev=321754&view=rev Log: -gmodules: Emit debug info for implicit module imports via #include. When a type is only used as a template parameter and that type is the only type imported from a

r321845 - Debug Info: Support DW_AT_calling_convention on composite types.

Author: adrian Date: Thu Jan 4 17:13:52 2018 New Revision: 321845 URL: http://llvm.org/viewvc/llvm-project?rev=321845&view=rev Log: Debug Info: Support DW_AT_calling_convention on composite types. This implements the DWARF 5 feature described at http://www.dwarfstd.org/ShowIssue.php?issue=141215.

r321846 - Remove redundant test

Author: adrian Date: Thu Jan 4 17:28:59 2018 New Revision: 321846 URL: http://llvm.org/viewvc/llvm-project?rev=321846&view=rev Log: Remove redundant test Modified: cfe/trunk/test/CodeGenCXX/debug-info-composite-cc.cpp Modified: cfe/trunk/test/CodeGenCXX/debug-info-composite-cc.cpp URL: htt

Re: r321845 - Debug Info: Support DW_AT_calling_convention on composite types.

ng these things in mind)) Yes, this was in fact my primary motivation for the feature. Since the code is asking the ABI object, it looks like this might work out of the box with the trivial_abi attribute, but I will definitely at least add a testcase once it's in. -- adrian > > On Thu,

r327078 - Add a debug info testcase for the trvial_abi attribute.

Author: adrian Date: Thu Mar 8 15:11:46 2018 New Revision: 327078 URL: http://llvm.org/viewvc/llvm-project?rev=327078&view=rev Log: Add a debug info testcase for the trvial_abi attribute. Modified: cfe/trunk/test/CodeGenCXX/debug-info-composite-cc.cpp Modified: cfe/trunk/test/CodeGenCXX/deb

r344915 - Ensure sanitizer check function calls have a !dbg location

Author: adrian Date: Mon Oct 22 09:27:41 2018 New Revision: 344915 URL: http://llvm.org/viewvc/llvm-project?rev=344915&view=rev Log: Ensure sanitizer check function calls have a !dbg location Function calls without a !dbg location inside a function that has a DISubprogram make it impossible to co

r345071 - Fix doxygen comment.

Author: adrian Date: Tue Oct 23 12:39:02 2018 New Revision: 345071 URL: http://llvm.org/viewvc/llvm-project?rev=345071&view=rev Log: Fix doxygen comment. Modified: cfe/trunk/include/clang/AST/DeclTemplate.h Modified: cfe/trunk/include/clang/AST/DeclTemplate.h URL: http://llvm.org/viewvc/llv

r345109 - Debug Info (-gmodules): emit full types for non-anchored template specializations

Author: adrian Date: Tue Oct 23 17:06:02 2018 New Revision: 345109 URL: http://llvm.org/viewvc/llvm-project?rev=345109&view=rev Log: Debug Info (-gmodules): emit full types for non-anchored template specializations Before this patch, clang would emit a (module-)forward declaration for template i

Re: r345109 - Debug Info (-gmodules): emit full types for non-anchored template specializations

> On Oct 29, 2018, at 11:26 AM, David Blaikie wrote: > > Is this a workaround for now with the intent to fix this to allow such > implicit specializations to have their debug info modularized? I believe this > does work correctly in modular debug info with expliict modules, would > probably

r346048 - Add an explicit -std=c++14 to this test.

Author: adrian Date: Fri Nov 2 15:19:02 2018 New Revision: 346048 URL: http://llvm.org/viewvc/llvm-project?rev=346048&view=rev Log: Add an explicit -std=c++14 to this test. rdar://problem/45642490 Modified: cfe/trunk/test/Modules/lsv-debuginfo.cpp Modified: cfe/trunk/test/Modules/lsv-debug

r346454 - Fix a use-after-free introduced by r344915.

Author: adrian Date: Thu Nov 8 16:26:15 2018 New Revision: 346454 URL: http://llvm.org/viewvc/llvm-project?rev=346454&view=rev Log: Fix a use-after-free introduced by r344915. r344915 added a call to ApplyDebugLocation to the sanitizer check function emitter. Some of the sanitizers are emitted i

r346542 - Fix a nondeterminism in the debug info for VLA size expressions.

Author: adrian Date: Fri Nov 9 11:17:56 2018 New Revision: 346542 URL: http://llvm.org/viewvc/llvm-project?rev=346542&view=rev Log: Fix a nondeterminism in the debug info for VLA size expressions. The artificial variable describing the array size is supposed to be called "__vla_expr", but this w

r346556 - Revert "Revert rL346454: Fix a use-after-free introduced by r344915."

Author: adrian Date: Fri Nov 9 13:17:38 2018 New Revision: 346556 URL: http://llvm.org/viewvc/llvm-project?rev=346556&view=rev Log: Revert "Revert rL346454: Fix a use-after-free introduced by r344915." This un-reverts commit 346454 with a relaxed CHECK for Windows. Added: cfe/trunk/test/Cod

r347810 - Ensure sanitizer check function calls have a !dbg location

Author: adrian Date: Wed Nov 28 13:44:06 2018 New Revision: 347810 URL: http://llvm.org/viewvc/llvm-project?rev=347810&view=rev Log: Ensure sanitizer check function calls have a !dbg location Function calls without a !dbg location inside a function that has a DISubprogram make it impossible to co

r347926 - [-gmodules] Honor -fdebug-prefix-map in the debug info inside PCMs.

Author: adrian Date: Thu Nov 29 14:33:09 2018 New Revision: 347926 URL: http://llvm.org/viewvc/llvm-project?rev=347926&view=rev Log: [-gmodules] Honor -fdebug-prefix-map in the debug info inside PCMs. This patch passes -fdebug-prefix-map (a feature for renaming source paths in the debug info) thr

r348060 - Honor -fdebug-prefix-map when creating function names for the debug info.

Author: adrian Date: Fri Nov 30 16:24:27 2018 New Revision: 348060 URL: http://llvm.org/viewvc/llvm-project?rev=348060&view=rev Log: Honor -fdebug-prefix-map when creating function names for the debug info. This adds a callback to PrintingPolicy to allow CGDebugInfo to remap file paths according

r348062 - Relax test to also work on Windows.

Author: adrian Date: Fri Nov 30 17:30:00 2018 New Revision: 348062 URL: http://llvm.org/viewvc/llvm-project?rev=348062&view=rev Log: Relax test to also work on Windows. Modified: cfe/trunk/test/CodeGenCXX/debug-prefix-map-lambda.cpp Modified: cfe/trunk/test/CodeGenCXX/debug-prefix-map-lambda

r348154 - Avoid emitting redundant or unusable directories in DIFile metadata entries.

Author: adrian Date: Mon Dec 3 09:55:27 2018 New Revision: 348154 URL: http://llvm.org/viewvc/llvm-project?rev=348154&view=rev Log: Avoid emitting redundant or unusable directories in DIFile metadata entries. As discussed on llvm-dev recently, Clang currently emits redundant directories in DIFil

Re: r348154 - Avoid emitting redundant or unusable directories in DIFile metadata entries.

to understand what an appropriate fix > is. I've not yet reverted these changes to give you a chance to take a look. > > On Mon, Dec 3, 2018 at 9:58 AM Adrian Prantl via cfe-commits > mailto:cfe-commits@lists.llvm.org>> wrote: > Author: adrian > Date: Mon Dec 3 09:

Re: r348154 - Avoid emitting redundant or unusable directories in DIFile metadata entries.

This should be fixed by LLVM r348203. Thanks for your patience! -- adrian > On Dec 3, 2018, at 1:27 PM, Adrian Prantl via cfe-commits > wrote: > > I'll take a look right away. Thanks for letting me know! > > -- adrian > >> On Dec 3, 2018, at 1:26 PM, Vlad

Re: r348154 - Avoid emitting redundant or unusable directories in DIFile metadata entries.

; Failing Tests (2): > Clang :: CodeGen/debug-prefix-map.c > Clang :: Modules/module-debuginfo-prefix.m > > The builders were already red and no notifications were sent on this. > Please have a look? > > Thanks > > Galina > > On Mon, Dec 3, 2018 at 9:58 AM

r348211 - Relax tests to also work on Windows

Author: adrian Date: Mon Dec 3 15:11:19 2018 New Revision: 348211 URL: http://llvm.org/viewvc/llvm-project?rev=348211&view=rev Log: Relax tests to also work on Windows Modified: cfe/trunk/test/CodeGen/debug-prefix-map.c cfe/trunk/test/Modules/module-debuginfo-prefix.m Modified: cfe/trun

Re: r348154 - Avoid emitting redundant or unusable directories in DIFile metadata entries.

Should be fixed in r348211. -- adrian > On Dec 3, 2018, at 3:07 PM, Adrian Prantl via cfe-commits > wrote: > > No, your failures are Windows-specific (/ vs \), and I haven't fixed them > yet. Thanks for letting me know! > > -- adrian > >> On Dec 3, 2018,

r348213 - Relax test even more for Windows

Author: adrian Date: Mon Dec 3 15:40:51 2018 New Revision: 348213 URL: http://llvm.org/viewvc/llvm-project?rev=348213&view=rev Log: Relax test even more for Windows Modified: cfe/trunk/test/CodeGen/debug-prefix-map.c Modified: cfe/trunk/test/CodeGen/debug-prefix-map.c URL: http://llvm.org/

r348397 - Honor -fdebug-prefix-map when creating function names for the debug info.

Author: adrian Date: Wed Dec 5 10:37:44 2018 New Revision: 348397 URL: http://llvm.org/viewvc/llvm-project?rev=348397&view=rev Log: Honor -fdebug-prefix-map when creating function names for the debug info. This adds a callback to PrintingPolicy to allow CGDebugInfo to remap file paths according

r348513 - Reapply "Avoid emitting redundant or unusable directories in DIFile metadata entries.""

Author: adrian Date: Thu Dec 6 10:44:50 2018 New Revision: 348513 URL: http://llvm.org/viewvc/llvm-project?rev=348513&view=rev Log: Reapply "Avoid emitting redundant or unusable directories in DIFile metadata entries."" This reverts commit r348280 and reapplies D55085 without modifications. Or

r348612 - Make testcase more robust for completely-out-of-tree builds.

Author: adrian Date: Fri Dec 7 09:04:26 2018 New Revision: 348612 URL: http://llvm.org/viewvc/llvm-project?rev=348612&view=rev Log: Make testcase more robust for completely-out-of-tree builds. Thats to Dave Zarzycki for reprorting this! Modified: cfe/trunk/test/CodeGen/debug-info-abspath.c

r348618 - Make testcase more robust for bots actually building in /var

Author: adrian Date: Fri Dec 7 09:57:44 2018 New Revision: 348618 URL: http://llvm.org/viewvc/llvm-project?rev=348618&view=rev Log: Make testcase more robust for bots actually building in /var Modified: cfe/trunk/test/CodeGen/debug-prefix-map.c Modified: cfe/trunk/test/CodeGen/debug-prefix-

r348865 - Reuse code from CGDebugInfo::getOrCreateFile() when creating the file

Author: adrian Date: Tue Dec 11 08:58:43 2018 New Revision: 348865 URL: http://llvm.org/viewvc/llvm-project?rev=348865&view=rev Log: Reuse code from CGDebugInfo::getOrCreateFile() when creating the file for the DICompileUnit. This addresses post-commit feedback for D55085. Without this patch, a m

r348866 - Remove CGDebugInfo::getOrCreateFile() and use TheCU->getFile() directly.

Author: adrian Date: Tue Dec 11 08:58:46 2018 New Revision: 348866 URL: http://llvm.org/viewvc/llvm-project?rev=348866&view=rev Log: Remove CGDebugInfo::getOrCreateFile() and use TheCU->getFile() directly. Modified: cfe/trunk/lib/CodeGen/CGDebugInfo.cpp cfe/trunk/lib/CodeGen/CGDebugInfo.h

Re: r357713 - Verify that Android targets generate DWARF 4 by default.

IIRC, the dwarf version on Darwin depends on the deployment target and is 2 for earlier versions of macOS and and 4 for newer ones (I need to dig through the driver code to determine the exact version). I can take a look at this tomorrow morning. -- adrian > On Apr 4, 2019, at 6:21 PM, Alex L

r353219 - Fix a missing word in comment

Author: adrian Date: Tue Feb 5 13:21:01 2019 New Revision: 353219 URL: http://llvm.org/viewvc/llvm-project?rev=353219&view=rev Log: Fix a missing word in comment Modified: cfe/trunk/lib/CodeGen/CGDebugInfo.cpp Modified: cfe/trunk/lib/CodeGen/CGDebugInfo.cpp URL: http://llvm.org/viewvc/llvm

r353568 - Fix typo

Author: adrian Date: Fri Feb 8 13:13:25 2019 New Revision: 353568 URL: http://llvm.org/viewvc/llvm-project?rev=353568&view=rev Log: Fix typo Modified: cfe/trunk/include/clang/Basic/LangOptions.h Modified: cfe/trunk/include/clang/Basic/LangOptions.h URL: http://llvm.org/viewvc/llvm-project/

r353578 - -gmodules: Don't emit incomplete breadcrumbs pointing to nonexistant PCM files.

Author: adrian Date: Fri Feb 8 15:15:42 2019 New Revision: 353578 URL: http://llvm.org/viewvc/llvm-project?rev=353578&view=rev Log: -gmodules: Don't emit incomplete breadcrumbs pointing to nonexistant PCM files. When a module name is specified as -fmodule-name, that module gets a clang::Module o

r354165 - Relax assertion to account for private framework modules, too.

Author: adrian Date: Fri Feb 15 12:24:26 2019 New Revision: 354165 URL: http://llvm.org/viewvc/llvm-project?rev=354165&view=rev Log: Relax assertion to account for private framework modules, too. rdar://problem/48116069 Modified: cfe/trunk/lib/CodeGen/CGDebugInfo.cpp cfe/trunk/test/Modul

Re: r311601 - Fix a bug in CGDebugInfo::EmitInlineFunctionStart causing DILocations to be

David Blaikie wrote: > > Seems like a rather complex test case - could you explain what's going on > there? (maybe in the form of a comment in the code - what path through all > those classes is required to tickle this) > > On Wed, Aug 23, 2017 at 2:25 PM Adrian Prantl v

r312148 - Adapt testcases to LLVM change r312144 in DIGlobalVariableExpression

Author: adrian Date: Wed Aug 30 11:22:23 2017 New Revision: 312148 URL: http://llvm.org/viewvc/llvm-project?rev=312148&view=rev Log: Adapt testcases to LLVM change r312144 in DIGlobalVariableExpression Modified: cfe/trunk/test/CodeGen/2009-10-20-GlobalDebug.c cfe/trunk/test/CodeGen/debug-

r312175 - Test-case golfing.

Author: adrian Date: Wed Aug 30 14:31:16 2017 New Revision: 312175 URL: http://llvm.org/viewvc/llvm-project?rev=312175&view=rev Log: Test-case golfing. Modified: cfe/trunk/test/CodeGenCXX/debug-info-inlined.cpp Modified: cfe/trunk/test/CodeGenCXX/debug-info-inlined.cpp URL: http://llvm.org/

Re: r311601 - Fix a bug in CGDebugInfo::EmitInlineFunctionStart causing DILocations to be

On Aug 28, 2017, at 4:43 PM, David Blaikie wrote: >> >> Seems like a rather complex test case - could you explain what's going on >> there? (maybe in the form of a comment in the code - what path through all >> those classes is required to tickle this) >> >

Re: [PATCH] D37604: Disable debuginfo-tests for non-native configurations

> On Sep 8, 2017, at 10:54 AM, Paul Robinson via Phabricator > wrote: > > probinson added a comment. > > In https://reviews.llvm.org/D37604#864187, @aprantl wrote: > >> This seems reasonable to me, thanks! >> When you commit this, could you please double-check that the tests are still >> run

Re: [PATCH] D37604: Disable debuginfo-tests for non-native configurations

> On Sep 8, 2017, at 11:43 AM, Adrian Prantl wrote: > > >> On Sep 8, 2017, at 10:54 AM, Paul Robinson via Phabricator >> wrote: >> >> probinson added a comment. >> >> In https://reviews.llvm.org/D37604#864187, @aprantl wrote: >> >>> This seems reasonable to me, thanks! >>> When you commit

r349065 - Reinstate DW_AT_comp_dir support after D55519.

Author: adrian Date: Thu Dec 13 09:53:29 2018 New Revision: 349065 URL: http://llvm.org/viewvc/llvm-project?rev=349065&view=rev Log: Reinstate DW_AT_comp_dir support after D55519. The DIFile used by the CU is special and distinct from the main source file. Its directory part specifies what become

Re: r349065 - Reinstate DW_AT_comp_dir support after D55519.

> On Dec 13, 2018, at 1:18 PM, Reid Kleckner wrote: > > On Thu, Dec 13, 2018 at 9:56 AM Adrian Prantl via cfe-commits > mailto:cfe-commits@lists.llvm.org>> wrote: > > +// RUN: cd %t/UNIQUEISH_SENTINEL > +// RUN: %clang_cc1 -debug-info-kind=limited -triple %ita

r371530 - Don't emit .gnu_pubnames when tuning for LLDB.

Author: adrian Date: Tue Sep 10 08:53:18 2019 New Revision: 371530 URL: http://llvm.org/viewvc/llvm-project?rev=371530&view=rev Log: Don't emit .gnu_pubnames when tuning for LLDB. LLDB reads the various .apple* accelerator tables (and in the near future: the DWARF 5 accelerator tables) which shou

r372663 - Support for DWARF-5 C++ language tags.

Author: adrian Date: Mon Sep 23 15:01:49 2019 New Revision: 372663 URL: http://llvm.org/viewvc/llvm-project?rev=372663&view=rev Log: Support for DWARF-5 C++ language tags. This patch provides support for DW_LANG_C_plus_plus_11, DW_LANG_C_plus_plus_14 tags in the Clang C++ frontend. Patch by Sour

r372681 - Support for DWARF-5 C++ language tags.

Author: adrian Date: Mon Sep 23 17:38:49 2019 New Revision: 372681 URL: http://llvm.org/viewvc/llvm-project?rev=372681&view=rev Log: Support for DWARF-5 C++ language tags. This patch provides support for DW_LANG_C_plus_plus_11, DW_LANG_C_plus_plus_14 tags in the Clang C++ frontend. Patch by Sour

Re: r372681 - Support for DWARF-5 C++ language tags.

> On Oct 1, 2019, at 6:40 PM, David Blaikie wrote: > > This broke gnu_pubnames and other forms of DWARF index of C++ code - fixed in > r373420 (feel free to post-comimt review, etc, of course) > Thanks! -- adrian > On Mon, Sep 23, 2019 at 5:36 PM Adrian Pran

Re: r372681 - Support for DWARF-5 C++ language tags.

>> On Oct 1, 2019, at 6:40 PM, David Blaikie wrote: >> >> This broke gnu_pubnames and other forms of DWARF index of C++ code - fixed >> in r373420 (feel free to post-comimt review, etc, of course) >> > patch for reference: >case dwarf::DW_TAG_union_type: >case dwarf::DW_TAG_enumerat

Re: r374484 - Move most CXXRecordDecl::DefinitionData bit-fields out into a separate

Hi Richard, it's possible that this broke the module build http://lab.llvm.org:8080/green/view/LLDB/job/lldb-cmake/2482/consoleFull#-432653710a1ca8a51-895e-46c6-af87-ce24fa4cd561

r375012 - [DWARF5] Added support for DW_AT_noreturn attribute to be emitted for

Author: adrian Date: Wed Oct 16 09:30:38 2019 New Revision: 375012 URL: http://llvm.org/viewvc/llvm-project?rev=375012&view=rev Log: [DWARF5] Added support for DW_AT_noreturn attribute to be emitted for C++ class member functions. Patch by Sourabh Singh Tomar! Differential Revision: https://revi

r375423 - PCH debug info: Avoid appending the source directory to an absolute path

Author: adrian Date: Mon Oct 21 09:44:37 2019 New Revision: 375423 URL: http://llvm.org/viewvc/llvm-project?rev=375423&view=rev Log: PCH debug info: Avoid appending the source directory to an absolute path When building a precompiled header in -fmodule-format=obj (i.e., `-gmodules) in an absolute

Re: [PATCH] D67723: [DebugInfo] Add option to disable inline line tables.

> On Oct 24, 2019, at 3:02 PM, David Blaikie via Phabricator > wrote: > > dblaikie added a comment. > > In D67723#1720509 , @aprantl wrote: > >> In D67723#1720353 , @rnk wrote: >> >>> In D67723#1717468

[clang] 6b7d51a - Add missing forward decl to unbreak the modular build

Author: Adrian Prantl Date: 2020-05-26T09:08:27-07:00 New Revision: 6b7d51ad4a16579b0a7d41c77715be4d9e266d8c URL: https://github.com/llvm/llvm-project/commit/6b7d51ad4a16579b0a7d41c77715be4d9e266d8c DIFF: https://github.com/llvm/llvm-project/commit/6b7d51ad4a16579b0a7d41c77715be4d9e266d8c.diff

[clang] b59b364 - Debug Info: Mark os_log helper functions as artificial

Author: Adrian Prantl Date: 2020-05-26T09:08:27-07:00 New Revision: b59b3640bcbdfc6cf4b35ff3a6ad5f524a073b45 URL: https://github.com/llvm/llvm-project/commit/b59b3640bcbdfc6cf4b35ff3a6ad5f524a073b45 DIFF: https://github.com/llvm/llvm-project/commit/b59b3640bcbdfc6cf4b35ff3a6ad5f524a073b45.diff

[clang] b907ad5 - [NFC] Clean up doc comment and implementation for Module::isSubModuleOf.

Author: Adrian Prantl Date: 2020-07-21T16:23:36-07:00 New Revision: b907ad539a900279443dc8ef8816b6b5a76b1ea1 URL: https://github.com/llvm/llvm-project/commit/b907ad539a900279443dc8ef8816b6b5a76b1ea1 DIFF: https://github.com/llvm/llvm-project/commit/b907ad539a900279443dc8ef8816b6b5a76b1ea1.diff

Re: [PATCH] D24820: Add -stats-file option

aprantl added inline comments. Comment at: include/clang/Basic/DiagnosticFrontendKinds.td:111 @@ -110,1 +110,3 @@ +def warn_fe_unable_to_open_stats_file : Warning< +"unable to open statistic output file '%0': '%1'">; def err_fe_no_pch_in_dir : Error< statstic

Re: [PATCH] D24820: Add -stats-stats option

aprantl added a comment. Awesome. Sorry! Repository: rL LLVM https://reviews.llvm.org/D24820 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D22227: [ubsan] Disable bounds-check for flexible array ivars

aprantl added a comment. Not knowing the specifics of the ObjC class layout: Does this work correctly with private ivars (i.e.: Does this need an extra check that there are no extra ivars in a later @implementation)? https://reviews.llvm.org/D7 __

[PATCH] D22227: [ubsan] Disable bounds-check for flexible array ivars

aprantl accepted this revision. aprantl added a comment. This revision is now accepted and ready to land. Can you double-check that the memory layout is actually what we think it is by inspecting the generated IR? Otherwise this LGTM. https://reviews.llvm.org/D7 _

[PATCH] D25321: Fix PR13910: Don't warn that __builtin_unreachable() is unreachable

aprantl added inline comments. > ReachableCode.cpp:64 > +const FunctionDecl *FDecl = dyn_cast(DRE->getDecl()); > +return FDecl && FDecl->getIdentifier() && > + FDecl->getBuiltinID() == Builtin::BI__builtin_unreachable; Maybe also wrap the inner dyn_cast in an if for symmetry?

[PATCH] D25321: Fix PR13910: Don't warn that __builtin_unreachable() is unreachable

aprantl accepted this revision. aprantl added a reviewer: aprantl. aprantl added a comment. This revision is now accepted and ready to land. Thanks, LGTM! Repository: rL LLVM https://reviews.llvm.org/D25321 ___ cfe-commits mailing list cfe-commit

r283810 - [Driver] Let -gline-tables-only win when it comes after -gmodules.

Author: adrian Date: Mon Oct 10 16:56:20 2016 New Revision: 283810 URL: http://llvm.org/viewvc/llvm-project?rev=283810&view=rev Log: [Driver] Let -gline-tables-only win when it comes after -gmodules. The -gmodules option is all about putting debug type info into clang modules and for line tables t

[PATCH] D25621: DebugInfo: use DIAlignment type.

aprantl added inline comments. Comment at: include/clang/AST/ASTContext.h:83 uint64_t Width; -unsigned Align; +llvm::DIAlignment Align; bool AlignIsRequired : 1; I'm not sure we want to use a debug info type inside the AST. I think we only want

[clang] [lldb] Reland "[clang][DebugInfo] Emit global variable definitions for static data members with constant initializers" (PR #71780)

https://github.com/adrian-prantl edited https://github.com/llvm/llvm-project/pull/71780 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [lldb] Reland "[clang][DebugInfo] Emit global variable definitions for static data members with constant initializers" (PR #71780)

@@ -5596,6 +5587,42 @@ void CGDebugInfo::EmitGlobalVariable(const ValueDecl *VD, const APValue &Init) { TemplateParameters, Align)); } +void CGDebugInfo::EmitGlobalVariable(const VarDecl *VD) { + assert(VD->hasInit()); + assert(CGM.getCodeGenOpts().hasReducedDebugInfo

[clang] [lldb] Reland "[clang][DebugInfo] Emit global variable definitions for static data members with constant initializers" (PR #71780)

https://github.com/adrian-prantl approved this pull request. Minor comments inside. https://github.com/llvm/llvm-project/pull/71780 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[lldb] [clang] Reland "[clang][DebugInfo] Emit global variable definitions for static data members with constant initializers" (PR #71780)

@@ -5800,6 +5827,18 @@ void CGDebugInfo::setDwoId(uint64_t Signature) { } void CGDebugInfo::finalize() { + for (auto const *VD : StaticDataMemberDefinitionsToEmit) { +assert(VD->isStaticDataMember()); + +if (DeclCache.contains(VD)) + continue; + +if (!VD->has

[llvm] [clang-tools-extra] [lldb] [clang] [lldb][test] Apply @expectedFailureAll/@skipIf early for debug_info tests (PR #73067)

adrian-prantl wrote: Is this a performance optimization or a function al change? https://github.com/llvm/llvm-project/pull/73067 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang-tools-extra] [lldb] [llvm] [lldb][test] Apply @expectedFailureAll/@skipIf early for debug_info tests (PR #73067)

adrian-prantl wrote: SGTM, maybe wait one more day for @JDevlieghere to chime in. https://github.com/llvm/llvm-project/pull/73067 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [llvm][DebugInfo] DWARFv5: static data members declarations are DW_TAG_variable (PR #72234)

https://github.com/adrian-prantl approved this pull request. https://github.com/llvm/llvm-project/pull/72234 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [llvm][DebugInfo] DWARFv5: static data members declarations are DW_TAG_variable (PR #72234)

https://github.com/adrian-prantl edited https://github.com/llvm/llvm-project/pull/72234 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[llvm] [clang] [llvm][DebugInfo] DWARFv5: static data members declarations are DW_TAG_variable (PR #72234)

@@ -1315,17 +1315,15 @@ LLVMDIBuilderCreateUnspecifiedType(LLVMDIBuilderRef Builder, const char *Name, return wrap(unwrap(Builder)->createUnspecifiedType({Name, NameLen})); } -LLVMMetadataRef -LLVMDIBuilderCreateStaticMemberType( +LLVMMetadataRef LLVMDIBuilderCreateStaticMe

[llvm] [clang] [llvm][DebugInfo] DWARFv5: static data members declarations are DW_TAG_variable (PR #72234)

https://github.com/adrian-prantl requested changes to this pull request. I think this is missing a test in clang/test/CodeGenCXX that verifies Clang generates the expected LLVM IR. https://github.com/llvm/llvm-project/pull/72234 ___ cfe-commits mailin

[llvm] [clang] [llvm][DebugInfo] DWARFv5: static data members declarations are DW_TAG_variable (PR #72234)

@@ -1681,7 +1681,8 @@ CGDebugInfo::CreateRecordStaticField(const VarDecl *Var, llvm::DIType *RecordTy, llvm::DINode::DIFlags Flags = getAccessFlag(Var->getAccess(), RD); auto Align = getDeclAlignIfRequired(Var, CGM.getContext()); llvm::DIDerivedType *GV = DBuilder.create

[llvm] [clang] [llvm][DebugInfo] DWARFv5: static data members declarations are DW_TAG_variable (PR #72234)

https://github.com/adrian-prantl approved this pull request. LGTM, then https://github.com/llvm/llvm-project/pull/72234 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[lldb] [flang] [clang] [clang-tools-extra] [llvm] [mlir] [compiler-rt] [CodeGen][DebugInfo] Add missing debug info for jump table BB (PR #71021)

https://github.com/adrian-prantl approved this pull request. https://github.com/llvm/llvm-project/pull/71021 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] 1adb898 - Mark headers as textual and unbreak the modules build

Author: Adrian Prantl Date: 2023-10-31T09:10:50-07:00 New Revision: 1adb898e2db980fc402b8eac7ebc762c75d05826 URL: https://github.com/llvm/llvm-project/commit/1adb898e2db980fc402b8eac7ebc762c75d05826 DIFF: https://github.com/llvm/llvm-project/commit/1adb898e2db980fc402b8eac7ebc762c75d05826.diff

[clang] [llvm] [CloneFunction][DebugInfo] Avoid cloning DILocalVariables of inlined functions (PR #75385)

@@ -238,6 +238,13 @@ void llvm::CloneFunctionInto(Function *NewFunc, const Function *OldFunc, } } +// Avoid cloning local variables of subprograms that won't be cloned. adrian-prantl wrote: Can you add a sentence explaining why some subprograms

[clang] [llvm] [CloneFunction][DebugInfo] Avoid cloning DILocalVariables of inlined functions (PR #75385)

https://github.com/adrian-prantl commented: I think this LGTM, but it would be good if someone else also took a look. https://github.com/llvm/llvm-project/pull/75385 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin

[clang] [clang] Remove unused argument. NFC. (PR #73594)

https://github.com/adrian-prantl approved this pull request. I can't even remember what this was supposed to do. https://github.com/llvm/llvm-project/pull/73594 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mail

[clang] [clang][DebugInfo] Improve heuristic to determine whether to evaluate a static variable's initializer (PR #72974)

https://github.com/adrian-prantl approved this pull request. https://github.com/llvm/llvm-project/pull/72974 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [BoundsSafety] Initial documentation for -fbounds-safety (PR #70749)

https://github.com/adrian-prantl edited https://github.com/llvm/llvm-project/pull/70749 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [BoundsSafety] Initial documentation for -fbounds-safety (PR #70749)

https://github.com/adrian-prantl approved this pull request. Debug info part looks good! https://github.com/llvm/llvm-project/pull/70749 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [BoundsSafety] Initial documentation for -fbounds-safety (PR #70749)

@@ -0,0 +1,255 @@ + +Implementation plans for ``-fbounds-safety`` + + +.. contents:: + :local: + +External bounds annotations +=== + +The bounds annotations are C type

[clang] [clang][modules] Reset codegen options. (PR #74006)

https://github.com/adrian-prantl approved this pull request. https://github.com/llvm/llvm-project/pull/74006 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][ASTImporter] Only reorder fields of RecordDecls (PR #77079)

https://github.com/adrian-prantl approved this pull request. Test would be nice, but generally this looks like a reasonable modification. https://github.com/llvm/llvm-project/pull/77079 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://li

[clang] baac665 - Revert "[lld/coff] Make lld-link work in a non-MSVC shell, add /winsysroot:"

Author: Adrian Prantl Date: 2022-02-11T13:07:23-08:00 New Revision: baac665adf324672802dcc7037a25468e9569c95 URL: https://github.com/llvm/llvm-project/commit/baac665adf324672802dcc7037a25468e9569c95 DIFF: https://github.com/llvm/llvm-project/commit/baac665adf324672802dcc7037a25468e9569c95.diff

[clang] 0604d86 - Darwin: introduce a global override for debug prefix map entries.

Author: Adrian Prantl Date: 2022-02-16T08:36:26-08:00 New Revision: 0604d86c07ab8a28b95df689aff4ddd26347f35f URL: https://github.com/llvm/llvm-project/commit/0604d86c07ab8a28b95df689aff4ddd26347f35f DIFF: https://github.com/llvm/llvm-project/commit/0604d86c07ab8a28b95df689aff4ddd26347f35f.diff

[clang] [clang] Move CCC_OVERRIDE_OPTIONS implementation to Driver (PR #85425)

https://github.com/adrian-prantl approved this pull request. https://github.com/llvm/llvm-project/pull/85425 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

  1   2   3   4   5   6   >