[PATCH] D32603: Build the Apple-style stage2 with modules and full debug info

aprantl added a comment. > It would simplify fallout, reverting, triaging issues, understanding compile > time impact, etc., if the debug info change was left for a separate commit > (maybe waiting a day). Thoughts? Sounds like a good plan. https://reviews.llvm.org/D32603 _

[PATCH] D31440: PR32382: Adapt to LLVM changes in DIExpression.

aprantl accepted this revision. aprantl added a comment. This revision now requires changes to proceed. I think I may haved screwed up the phabricator process for this one. This landed as r300523. https://reviews.llvm.org/D31440 ___ cfe-commits mail

[PATCH] D32745: Correct debug info bit offset calculation for big-endian targets

aprantl accepted this revision. aprantl added a comment. This revision is now accepted and ready to land. Doesn't the test need some kind of `REQUIRES: mips` line? Otherwise looks fine. https://reviews.llvm.org/D32745 ___ cfe-commits mailing list cf

[PATCH] D32745: Correct debug info bit offset calculation for big-endian targets

aprantl added a comment. Ah. Thanks for clarifying! We should remove it, then. https://reviews.llvm.org/D32745 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D32724: [Modules] Include the enabled sanitizers in the module hash

aprantl added a comment. Is it the right solution to use the module hash for correctness, or should the mismatch of the serialized langopts trigger a module rebuild and the module hash is only there to tune the performance/disk size tradeoff? https://reviews.llvm.org/D32724

[PATCH] D29951: Load lazily the template specialization in multi-module setups.

aprantl added inline comments. Comment at: lib/Serialization/ASTReaderDecl.cpp:3814 + } else // TypeAliasTemplateDecl +assert(0 && "TypeAliasTemplateDecl doesn't have specs!"); +} llvm_unreachable() Repository: rL LLVM https://reviews.llvm.o

[PATCH] D32724: [Modules] Handle sanitizer feature mismatches when importing modules

aprantl added inline comments. Comment at: include/clang/Basic/Sanitizers.h:64 - /// \brief Disable all sanitizers. - void clear() { Mask = 0; } + /// \brief Disable the sanitizers specified in \p K (by default, disable + /// all sanitizers). Might as well

[PATCH] D32724: [Modules] Handle sanitizer feature mismatches when importing modules

aprantl accepted this revision. aprantl added a comment. This is good from my point of view now. You might want to wait for an ok from @spyffe. https://reviews.llvm.org/D32724 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llv

[PATCH] D113718: Don't append the working directory to absolute paths

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG2cd9a86da54f: Don't append the working directory to absolute paths (authored by aprantl). Herald added a project: clang. Repository: rG LLVM Githu

[PATCH] D116113: Add LLDB synthetic child and summary scripts for llvm::SmallVector, llvm::Optional, llvm::ErrorOr and llvm::Expected.

aprantl added a comment. How does this relate to the code in `llvm/utils/lldbDataFormatters.py` and should it be added there instead? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116113/new/ https://reviews.llvm.org/D116113 _

[PATCH] D116790: C++ -gmodules .pcm files don't have the same DW_AT_language dialect

This revision was automatically updated to reflect the committed changes. Closed by commit rGeb200e584ece: Emit the C++ dialect in -gmodules .pcm files. (authored by aprantl). Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo CHANGES SIN

[PATCH] D99250: [DebugInfo] Fix the mismatching of C++ language tags and Dwarf versions.

aprantl requested changes to this revision. aprantl added a comment. This revision now requires changes to proceed. Can you explain your motivation? There is usually no good reason not to emit more specific attributes from future DWARF versions if they aren't in direct conflict with the older ve

[PATCH] D99400: [debug-info] support new tuning debugger type DBX for XCOFF DWARF

aprantl accepted this revision. aprantl added inline comments. This revision is now accepted and ready to land. Comment at: llvm/include/llvm/Target/TargetOptions.h:112 +SCE, // Tune debug info for SCE targets (e.g. PS4). +DBX // Tune debug info for dbx. };

[PATCH] D99250: [DebugInfo] Fix the mismatching of C++ language tags and Dwarf versions.

aprantl added a subscriber: shafik. aprantl added a comment. > If LLDB actually does _not_ have behavior change based on dialect, then we > might as well control language codes based on DWARF version, and the patch > should proceed. @shafik Can you think of situations where LLDB is sensitive to

[PATCH] D99250: [DebugInfo] Fix the mismatching of C++ language tags and Dwarf versions.

aprantl accepted this revision. aprantl added a comment. This revision is now accepted and ready to land. Sorry for the delay! Looks like this doesn't have any drawbacks for any other debuggers, but helps dbx. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.ll

[PATCH] D91806: [InstCombine] Update valueCoversEntireFragment to use TypeSize

aprantl added a comment. this lgtm with all other reviewer's concerns addressed. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91806/new/ https://reviews.llvm.org/D91806 ___ cfe-commits mailing list cfe-

[PATCH] D94224: [clang][AST] Get rid of an alignment hack in DeclObjC.h [NFCI]

aprantl added inline comments. Comment at: clang/include/clang/AST/DeclObjC.h:660 + /// Location of the left and right angle brackets. + alignas(ObjCTypeParamDecl *) SourceRange Brackets; /// The number of parameters in the list, which are tail-allocated. Ca

[PATCH] D94231: [clang][Sema] Compare SourceLocations directly [NFCI]

aprantl accepted this revision. aprantl added a comment. This revision is now accepted and ready to land. Based on your explanation, this seems good. Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D94231/new/ https://reviews.llvm.org/D94231

[PATCH] D94224: [clang][AST] Get rid of an alignment hack in DeclObjC.h [NFCI]

aprantl accepted this revision. aprantl added a comment. This revision is now accepted and ready to land. That's even better! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D94224/new/ https://reviews.llvm.org/D94224

[PATCH] D94391: CGDebugInfo: Drop Loc.isInvalid() special case from getLineNumber

aprantl added a comment. I like that this makes getLineNumber behave less "magic". I'm slightly worried that this isn't quite as NFC as think (and the other cases are just not caught by the testsuite). Perhaps you could compile Clang (and a sample of Clang's ObjC(xx) tests) with the patch and d

[PATCH] D107024: [DIBuilder] Do not replace empty enum types

aprantl accepted this revision. aprantl added a comment. This revision is now accepted and ready to land. Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107024/new/ https://reviews.llvm.org/D107024 __

<    1   2   3   4   5   6