[PATCH] D139570: Add -Wreturn-local-addr, GCC alias for -Wreturn-stack-address

adriandole updated this revision to Diff 486980. adriandole added a comment. Add test and release note. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139570/new/ https://reviews.llvm.org/D139570 Files: clang/docs/ReleaseNotes.rst clang/include

[PATCH] D141310: [clang] add -Wcompare-function-pointers

adriandole created this revision. Herald added a project: All. adriandole requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Using `icf=all` with lld can cause comparisons between function pointers that previously compared as unequal to compa

[PATCH] D141310: [clang] add -Wcompare-function-pointers

adriandole updated this revision to Diff 487511. adriandole added a comment. Release note. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141310/new/ https://reviews.llvm.org/D141310 Files: clang/docs/ReleaseNotes.rst clang/include/clang/Basic/

[PATCH] D141310: [clang] add -Wcompare-function-pointers

adriandole added inline comments. Comment at: clang/include/clang/Basic/DiagnosticSemaKinds.td:7006 +def warn_typecheck_comparison_of_function_pointers : Warning< + "comparison of function pointers (%0 and %1)">, + InGroup, DefaultIgnore; aaron.ballman wrote: >

[PATCH] D141310: [clang] add -Wcompare-function-pointers

adriandole added inline comments. Comment at: clang/include/clang/Basic/DiagnosticSemaKinds.td:7006 +def warn_typecheck_comparison_of_function_pointers : Warning< + "comparison of function pointers (%0 and %1)">, + InGroup, DefaultIgnore; aaron.ballman wrote: >

[PATCH] D139570: Add -Wreturn-local-addr, GCC alias for -Wreturn-stack-address

adriandole updated this revision to Diff 488699. adriandole added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139570/new/ https://reviews.llvm.org/D139570 Files: clang/docs/ReleaseNotes.rst clang/include/clang/Basic/Diagnos

[PATCH] D141310: [clang] add -Wcompare-function-pointers

adriandole added inline comments. Comment at: clang/include/clang/Basic/DiagnosticGroups.td:565 +def CompareFunctionPointers : DiagGroup<"compare-function-pointers">; def OrderedCompareFunctionPointers : DiagGroup<"ordered-compare-function-pointers">; def PackedNonPod : DiagGr

[PATCH] D141310: [clang] add -Wcompare-function-pointers

adriandole updated this revision to Diff 489109. adriandole added a comment. - More helpful diagnostic message. - Check variable and type names are printed in tests. - Enable `-Wordered-function-pointer-comparison` when this warning is enabled. Repository: rG LLVM Github Monorepo CHANGES SINC

[PATCH] D141310: [clang] add -Wcompare-function-pointers

adriandole added a comment. @dblaikie, we would use this warning in Chrome OS. We use `icf=all` and have encountered bugs caused by function pointer comparisons. It's not that noisy compiling clang (eight hits). Working on testing it for Chrome OS. Repository: rG LLVM Github Monorepo CHANG

[PATCH] D141310: [clang] add -Wcompare-function-pointers

adriandole updated this revision to Diff 490671. adriandole added a comment. Only trigger this warning when comparing function pointers of the same type, since comparing distinct types is already an error. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.o

[PATCH] D139570: Add -Wreturn-local-addr, GCC alias for -Wreturn-stack-address

adriandole created this revision. Herald added a subscriber: jeroen.dobbelaere. Herald added a project: All. adriandole requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D139570