Author: hiraditya
Date: Wed Jun 14 18:17:45 2017
New Revision: 305427
URL: http://llvm.org/viewvc/llvm-project?rev=305427&view=rev
Log:
[locale] Avoid copy of __atoms when char_type is char
The function num_get<_CharT>::stage2_int_prep makes unnecessary copy of src
into atoms when char_type is ch
Author: hiraditya
Date: Thu May 31 07:45:32 2018
New Revision: 333657
URL: http://llvm.org/viewvc/llvm-project?rev=333657&view=rev
Log:
Add dump method for selectors
Differential Revision: https://reviews.llvm.org/D45935
Reviewers: compnerd
Modified:
cfe/trunk/include/clang/Basic/IdentifierT
hiraditya updated this revision to Diff 71827.
hiraditya added a comment.
Added a test case (contributed by Eric).
https://reviews.llvm.org/D24682
Files:
clang/lib/CodeGen/CGCXX.cpp
clang/test/CodeGenCXX/alias-available-externally.cpp
Index: clang/test/CodeGenCXX/alias-available-externally
hiraditya marked 2 inline comments as done.
hiraditya added a comment.
https://reviews.llvm.org/D24682
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
hiraditya added a comment.
ping!
https://reviews.llvm.org/D24682
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
hiraditya updated this revision to Diff 72827.
hiraditya added a comment.
Addressed Richard's comments.
https://reviews.llvm.org/D24682
Files:
clang/lib/CodeGen/CGCXX.cpp
clang/test/CodeGenCXX/alias-available-externally.cpp
Index: clang/test/CodeGenCXX/alias-available-externally.cpp
==
hiraditya marked 3 inline comments as done.
hiraditya added a comment.
https://reviews.llvm.org/D24682
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
hiraditya added inline comments.
Comment at: clang/lib/CodeGen/CGCXX.cpp:169
@@ -170,3 +168,3 @@
// If we have a weak, non-discardable alias (weak, weak_odr), like an extern
// template instantiation or a dllexported class, avoid forming it on COFF.
Thanks
hiraditya updated this revision to Diff 72898.
hiraditya added a comment.
Addressed Richard's comment.
https://reviews.llvm.org/D24682
Files:
clang/lib/CodeGen/CGCXX.cpp
clang/test/CodeGenCXX/alias-available-externally.cpp
Index: clang/test/CodeGenCXX/alias-available-externally.cpp
===
Author: hiraditya
Date: Wed Sep 28 22:32:04 2016
New Revision: 282679
URL: http://llvm.org/viewvc/llvm-project?rev=282679&view=rev
Log:
[PR30341] Alias must point to a definition
Inlining the destructor caused the compiler to generate bad IR which failed the
Verifier in the backend.
https://llvm
This revision was automatically updated to reflect the committed changes.
Closed by commit rL282679: [PR30341] Alias must point to a definition (authored
by hiraditya).
Changed prior to commit:
https://reviews.llvm.org/D24682?vs=72898&id=72947#toc
Repository:
rL LLVM
https://reviews.llvm.or
hiraditya added a comment.
I think now the original patch can be re-applied now that the bug:
https://llvm.org/bugs/show_bug.cgi?id=30341
has been fixed in https://reviews.llvm.org/D24682
https://reviews.llvm.org/D24599
___
cfe-commits mailing list
Author: hiraditya
Date: Thu Sep 29 06:37:23 2016
New Revision: 282710
URL: http://llvm.org/viewvc/llvm-project?rev=282710&view=rev
Log:
Revert "[PR30341] Alias must point to a definition"
This reverts commit r282679.
Ninja check fails, reverting to debug the issue.
Removed:
cfe/trunk/test/C
hiraditya added a comment.
I had to revert the patch because this test case was failing. The problem was
that the destructors have different return type for different targets. So I'll
modify the testcase and put the patch back in.
Repository:
rL LLVM
https://reviews.llvm.org/D24682
_
Author: hiraditya
Date: Sat Oct 1 22:06:36 2016
New Revision: 283063
URL: http://llvm.org/viewvc/llvm-project?rev=283063&view=rev
Log:
Alias must point to a definition
Reapplying the patch after modifying the test case.
Inlining the destructor caused the compiler to generate bad IR which failed
Author: hiraditya
Date: Sun Oct 2 21:36:33 2016
New Revision: 283085
URL: http://llvm.org/viewvc/llvm-project?rev=283085&view=rev
Log:
Keep the test only for Itanium abi
Modified:
cfe/trunk/test/CodeGenCXX/alias-available-externally.cpp
Modified: cfe/trunk/test/CodeGenCXX/alias-available-ex
hiraditya created this revision.
hiraditya added reviewers: EricWF, mclow.lists.
hiraditya added subscribers: sebpop, cfe-commits.
https://reviews.llvm.org/D25522
Files:
libcxx/benchmarks/ContainerBenchmarks.hpp
libcxx/benchmarks/GenerateInput.hpp
Index: libcxx/benchmarks/GenerateInput.hpp
hiraditya created this revision.
hiraditya added reviewers: mclow.lists, EricWF.
hiraditya added subscribers: laxmansole, sebpop, cfe-commits.
Author: laxmansole
Original Differential Revision: https://reviews.llvm.org/D22834
Posting the patch again as the bug https://llvm.org/bu
hiraditya added a comment.
Marshall suggests using macro as we discussed offline. For some reason the
reply does not appear here:
http://lists.llvm.org/pipermail/cfe-commits/Week-of-Mon-20161010/173780.html
Repository:
rL LLVM
https://reviews.llvm.org/D24991
_
Author: hiraditya
Date: Sun Aug 20 03:38:55 2017
New Revision: 311283
URL: http://llvm.org/viewvc/llvm-project?rev=311283&view=rev
Log:
[NFC] remove trailing WS
Modified:
libcxx/trunk/include/memory
Modified: libcxx/trunk/include/memory
URL:
http://llvm.org/viewvc/llvm-project/libcxx/trunk/
Author: Aditya Kumar
Date: 2022-06-05T14:49:01-07:00
New Revision: 8f7b14898fe32f9c41059517a5a3872ef089174b
URL:
https://github.com/llvm/llvm-project/commit/8f7b14898fe32f9c41059517a5a3872ef089174b
DIFF:
https://github.com/llvm/llvm-project/commit/8f7b14898fe32f9c41059517a5a3872ef089174b.diff
hiraditya added a comment.
In https://reviews.llvm.org/D22834#522499, @EricWF wrote:
> No benchmark needed but one would be appreciated if possible.
I guess @laxmansole sent you a synthetic benchmark because we were having
trouble integrating it to the libcxx testsuite. I can send you that aga
hiraditya created this revision.
hiraditya added reviewers: mclow.lists, EricWF.
hiraditya added a subscriber: cfe-commits.
https://reviews.llvm.org/D23784
Files:
libcxx/include/algorithm
Index: libcxx/include/algorithm
===
--- li
Author: hiraditya
Date: Thu Aug 25 06:52:38 2016
New Revision: 279731
URL: http://llvm.org/viewvc/llvm-project?rev=279731&view=rev
Log:
Remove trailing WS [NFC]
Modified:
libcxx/trunk/include/algorithm
Modified: libcxx/trunk/include/algorithm
URL:
http://llvm.org/viewvc/llvm-project/libcxx/
Author: hiraditya
Date: Fri Aug 26 21:26:42 2016
New Revision: 279903
URL: http://llvm.org/viewvc/llvm-project?rev=279903&view=rev
Log:
Add attribute noreturn to functions that throw
Reviewers: mclow.lists, EricWF, howard.hinnant, sebpop
Subscribers: cfe-commits
Differential Revision: https://re
hiraditya closed this revision.
hiraditya added a comment.
commit fdb4f1713ece3c6f7fbf98f3ea3f8c19fa0c249e
Author: Aditya Kumar
Date: Thu Aug 25 11:52:38 2016 +
Remove trailing WS [NFC]
git-svn-id: https://llvm.org/svn/llvm-project/libcxx/trunk@279731
91177308-0d34-0410-b5e6-96231b
Author: hiraditya
Date: Thu Sep 8 09:31:44 2016
New Revision: 280944
URL: http://llvm.org/viewvc/llvm-project?rev=280944&view=rev
Log:
Added 'inline' attribute to basic_string's destructor
Author: laxmansole
Reviewers: howard.hinnant
mclow.lists
Subscribers: EricWF, flyingforyou, eva
hiraditya added a comment.
IIRC, I was the primary author of this code, I'd really appreciate if you could
attribute the code to the authors. Thanks
https://reviews.llvm.org/D24411
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://list
hiraditya added a comment.
@EricWF, since inline is only a hint, the compiler would not inline in many
cases, it might give the inliner a little bit of push to inline. When we were
working on this patch, adding inline wasn't enough and hence we added the
_LIBCPP_INLINE_VISIBILITY flag. The comp
hiraditya created this revision.
hiraditya added reviewers: rafael, eugenis.
hiraditya added subscribers: sebpop, mclow.lists, cfe-commits, EricWF.
Inlining the destructor caused the compiler to generate bad IR which failed the
Verifier in the backend.
https://llvm.org/bugs/show_bug.cgi?id=30341
hiraditya added a comment.
Please also see: https://reviews.llvm.org/D24682
https://reviews.llvm.org/D24599
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
hiraditya created this revision.
hiraditya added reviewers: EricWF, mclow.lists.
hiraditya added a subscriber: cfe-commits.
Worked with Sebastian Pop
https://reviews.llvm.org/D26991
Files:
libcxx/include/algorithm
Index: libcxx/include/algorithm
=
hiraditya created this revision.
hiraditya added reviewers: mclow.lists, EricWF.
hiraditya added subscribers: sebpop, cfe-commits.
Improving string::find such that it ultimately gets converted to calls to
memchr and memcmp. This is an intermediate patch to see if there is an interest
in this opti
Author: hiraditya
Date: Tue Nov 29 08:43:42 2016
New Revision: 288143
URL: http://llvm.org/viewvc/llvm-project?rev=288143&view=rev
Log:
[libcxx] remove unused code
The macro _LIBCPP_UNROLL_LOOPS isn't used anywhere
so the code was dead.
Differential Revision: https://reviews.llvm.org/D26991
Mod
hiraditya updated this revision to Diff 75915.
hiraditya added a comment.
Added macro to keep the definition of destructor of basic_string in string.cpp
https://reviews.llvm.org/D25624
Files:
libcxx/include/string
libcxx/src/string.cpp
Index: libcxx/src/string.cpp
hiraditya updated this revision to Diff 76192.
hiraditya added a comment.
Addressed Sebastian's comments.
https://reviews.llvm.org/D25624
Files:
libcxx/include/string
libcxx/src/string.cpp
Index: libcxx/src/string.cpp
===
---
hiraditya updated this revision to Diff 76240.
https://reviews.llvm.org/D25624
Files:
libcxx/include/string
Index: libcxx/include/string
===
--- libcxx/include/string
+++ libcxx/include/string
@@ -1834,6 +1834,7 @@
#endif // _L
hiraditya added inline comments.
Comment at: libcxx/include/string:1837
template
+inline _LIBCPP_EXTERN_TEMPLATE_INLINE_VISIBILITY
basic_string<_CharT, _Traits, _Allocator>::~basic_string()
EricWF wrote:
> The attribute should appear on the first declaration n
Author: hiraditya
Date: Fri Oct 28 16:27:24 2016
New Revision: 285456
URL: http://llvm.org/viewvc/llvm-project?rev=285456&view=rev
Log:
Added 'inline' attribute to basic_string's destructor
Author: laxmansole
Reviewers: howard.hinnant
mclow.lists
Subscribers: EricWF, flyingforyou, eva
hiraditya added a comment.
In https://reviews.llvm.org/D25624#583167, @mehdi_amini wrote:
> I talked with Eric on IRC, he mentioned some benchmarks were ran. I'd like to
> understand what was the baseline?
> Here we add *both* the inline keyword and the always_inline attribute. I'd
> like to k
hiraditya added a comment.
In https://reviews.llvm.org/D25624#582756, @mehdi_amini wrote:
> In https://reviews.llvm.org/D25624#582752, @mehdi_amini wrote:
>
> > (The commit message is confusing, it mentions "Currently basic_string's
> > destructor is not getting inlined. So adding 'inline' attri
hiraditya abandoned this revision.
hiraditya added a comment.
In https://reviews.llvm.org/D25624#588748, @mehdi_amini wrote:
> I think @EricWF already committed the patch with just the inline keyword?
Yes he's done already. Closing this.
Thanks for your feedback.
https://reviews.llvm.org/D256
hiraditya added a comment.
Please review my patch. Thanks.
http://reviews.llvm.org/D9924
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
hiraditya updated this revision to Diff 34323.
hiraditya added a comment.
Rebase with latest changes.
http://reviews.llvm.org/D9924
Files:
lib/StaticAnalyzer/Checkers/MallocOverflowSecurityChecker.cpp
test/Analysis/malloc-overflow.c
test/Analysis/malloc-overflow2.c
Index: test/Analysis/m
hiraditya updated this revision to Diff 34525.
hiraditya added a comment.
Emit warning when numerator is unknown (may overflow).
The checker will ignore warning when numerator and denominator are both
known.
Added test case.
Format patch with clang-format.
http://reviews.llvm.org/D9924
Files:
hiraditya added a comment.
Hi Anna,
I have updated the patch to address the changes you asked for.
http://reviews.llvm.org/D9924
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
hiraditya updated this revision to Diff 35461.
hiraditya added a comment.
Updated commit message and summary.
http://reviews.llvm.org/D9924
Files:
lib/StaticAnalyzer/Checkers/MallocOverflowSecurityChecker.cpp
test/Analysis/malloc-overflow.c
test/Analysis/malloc-overflow2.c
Index: test/An
hiraditya abandoned this revision.
hiraditya added a comment.
Duplicate of:
http://reviews.llvm.org/D9924
http://reviews.llvm.org/D9741
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commi
hiraditya added inline comments.
Comment at: lib/StaticAnalyzer/Checkers/MallocOverflowSecurityChecker.cpp:182
@@ +181,3 @@
+ if (rhs->isEvaluatable(Context))
+eraseAssign = true;
+ // Erase if the multiplicand was assigned a value,
zaks.anna wro
hiraditya updated this revision to Diff 31904.
hiraditya added a comment.
Added comments and changed the variable name.
http://reviews.llvm.org/D9924
Files:
lib/StaticAnalyzer/Checkers/MallocOverflowSecurityChecker.cpp
test/Analysis/malloc-overflow.c
test/Analysis/malloc-overflow2.c
Inde
hiraditya updated this revision to Diff 31913.
hiraditya added a comment.
Added free, to avoid an unrelated warning.
http://reviews.llvm.org/D9924
Files:
lib/StaticAnalyzer/Checkers/MallocOverflowSecurityChecker.cpp
test/Analysis/malloc-overflow.c
test/Analysis/malloc-overflow2.c
Index:
hiraditya updated this revision to Diff 32381.
hiraditya added a comment.
Refactored the code and check whether denominator > 0.
http://reviews.llvm.org/D9924
Files:
lib/StaticAnalyzer/Checkers/MallocOverflowSecurityChecker.cpp
test/Analysis/malloc-overflow.c
test/Analysis/malloc-overflow
hiraditya added a comment.
In https://reviews.llvm.org/D22782#495436, @mclow.lists wrote:
> Do we have a test for the problem that this is solving?
We are looking at the libcxx testsuite, it seems there are only
correctness/functionality tests. Do you have any pointers on how to add tests
to
hiraditya added a comment.
In https://reviews.llvm.org/D22782#504416, @EricWF wrote:
> The change itself LGTM, although we probably want to inline the forward/input
> iterator __init's as well.
>
> However I would like to see a small benchmark that demonstrates the
> performance change. Please
hiraditya added a comment.
In https://reviews.llvm.org/D22834#504425, @EricWF wrote:
> LGTM.
>
> However I would like to see a small benchmark that demonstrates the
> performance change. Please try and write the benchmark using Google Benchmark.
> Some helpful links:
>
> http://libcxx.llvm.org/
hiraditya added a comment.
In https://reviews.llvm.org/D22834#504425, @EricWF wrote:
> LGTM.
>
> However I would like to see a small benchmark that demonstrates the
> performance change. Please try and write the benchmark using Google Benchmark.
> Some helpful links:
>
> http://libcxx.llvm.org/
Author: Aditya Kumar
Date: 2021-10-08T17:54:44-07:00
New Revision: 0f00aa502d79acf8a92b0b8490489895a9f28829
URL:
https://github.com/llvm/llvm-project/commit/0f00aa502d79acf8a92b0b8490489895a9f28829
DIFF:
https://github.com/llvm/llvm-project/commit/0f00aa502d79acf8a92b0b8490489895a9f28829.diff
57 matches
Mail list logo
