[PATCH] D11765: [sanitizer] Enable tsan for aarch64

zatrazz created this revision. zatrazz added reviewers: rengolin, t.p.northover, aemerson, pcc. zatrazz added a subscriber: cfe-commits. Herald added subscribers: rengolin, aemerson. This patch enables the -fsanitizer=thread option for Linux/aarch64. http://reviews.llvm.org/D11765 Files: lib/D

Re: [PATCH] D60728: [clang] [test] Add a (xfailing) test for PR41027

On 05/06/2019 05:19, Michał Górny via Phabricator via llvm-commits wrote: > This revision was automatically updated to reflect the committed changes. > Closed by commit rL362587: [clang] [test] Add a (xfailing) test for PR41027 > (authored by mgorny, committed by ). > Herald added a project: LLVM.

r360896 - [clang] Handle lround/llround builtins

Author: azanella Date: Thu May 16 06:43:25 2019 New Revision: 360896 URL: http://llvm.org/viewvc/llvm-project?rev=360896&view=rev Log: [clang] Handle lround/llround builtins As for other floating-point rounding builtins that can be optimized when build with -fno-math-errno, this patch adds suppor

r361878 - [clang] Handle lrint/llrint builtins

Author: azanella Date: Tue May 28 14:16:04 2019 New Revision: 361878 URL: http://llvm.org/viewvc/llvm-project?rev=361878&view=rev Log: [clang] Handle lrint/llrint builtins As for other floating-point rounding builtins that can be optimized when build with -fno-math-errno, this patch adds support

[clang-tools-extra] [libc] [clang] [flang] [llvm] [compiler-rt] [X86] Do not end 'note.gnu.property' section with -fcf-protection (PR #79360)

https://github.com/zatrazz updated https://github.com/llvm/llvm-project/pull/79360 >From 240ec1a6b9dda5e6c625e096c52d70eb6458180b Mon Sep 17 00:00:00 2001 From: Adhemerval Zanella Date: Wed, 24 Jan 2024 16:49:30 -0300 Subject: [PATCH] [X86] Do not end 'note.gnu.property' secti

[clang] 92e1723 - [clang][Headers] Only define FLT_EVAL_METHOD for C99 and later

Author: Adhemerval Zanella Date: 2022-11-08T13:58:37-03:00 New Revision: 92e172309cf6624487ef6b3a79a5445276f9 URL: https://github.com/llvm/llvm-project/commit/92e172309cf6624487ef6b3a79a5445276f9 DIFF: https://github.com/llvm/llvm-project/commit/92e172309cf6624487ef6b3a79a5445276f9

[clang] 9e95699 - [clang][Headers] Do not define varargs macros for __need___va_list

Author: Adhemerval Zanella Date: 2022-11-08T16:29:35-03:00 New Revision: 9e956995db1fc7e792e3dfb3a465a52626195557 URL: https://github.com/llvm/llvm-project/commit/9e956995db1fc7e792e3dfb3a465a52626195557 DIFF: https://github.com/llvm/llvm-project/commit/9e956995db1fc7e792e3dfb3a465a52626195557

[libcxx] r278745 - libcxx: Fix path.compare.pass expected result

Author: azanella Date: Mon Aug 15 16:24:50 2016 New Revision: 278745 URL: http://llvm.org/viewvc/llvm-project?rev=278745&view=rev Log: libcxx: Fix path.compare.pass expected result The expected 'filesystem::path::compare' result states that for different path only result sign contains the informa

Re: [PATCH] D23420: libcxx: Fix libcxx test on aarch64 with libunwind

zatrazz added a comment. Ping (x2). https://reviews.llvm.org/D23420 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[libcxx] r279552 - libcxx: Fix libcxx tests on aarch64 with libunwind

Author: azanella Date: Tue Aug 23 14:25:12 2016 New Revision: 279552 URL: http://llvm.org/viewvc/llvm-project?rev=279552&view=rev Log: libcxx: Fix libcxx tests on aarch64 with libunwind Some tests uses 'long double' to/from conversions and for some targets they are provided by compiler runtime (e

[PATCH] D12708: [PATCH] [AArch64] Enable memory sanitizer on clang

zatrazz created this revision. zatrazz added reviewers: t.p.northover, aemerson, pcc, rengolin. zatrazz added a subscriber: cfe-commits. Herald added subscribers: rengolin, aemerson. This patch enables MSan for aarch64/linux. http://reviews.llvm.org/D12708 Files: lib/Driver/ToolChains.cpp Ind

r247808 - [sanitizers] Enable memory sanitizer on clang

Author: azanella Date: Wed Sep 16 10:11:21 2015 New Revision: 247808 URL: http://llvm.org/viewvc/llvm-project?rev=247808&view=rev Log: [sanitizers] Enable memory sanitizer on clang This patch enables MSan for aarch64/linux Modified: cfe/trunk/lib/Driver/ToolChains.cpp Modified: cfe/trunk/li

[PATCH] D13109: [sanitizer] Enable lsan for AArch64

zatrazz created this revision. zatrazz added reviewers: rengolin, pcc, aemerson, t.p.northover. zatrazz added a subscriber: cfe-commits. Herald added subscribers: rengolin, aemerson. compiler-rt related patch: http://reviews.llvm.org/D13108 http://reviews.llvm.org/D13109 Files: lib/Driver/Tool

r249338 - [sanitizer] Enable lsan for AArch64

Author: azanella Date: Mon Oct 5 14:16:42 2015 New Revision: 249338 URL: http://llvm.org/viewvc/llvm-project?rev=249338&view=rev Log: [sanitizer] Enable lsan for AArch64 Modified: cfe/trunk/lib/Driver/ToolChains.cpp Modified: cfe/trunk/lib/Driver/ToolChains.cpp URL: http://llvm.org/viewvc/

[PATCH] D23420: libcxx: Fix libcxx test on aarch64 with libunwind

zatrazz created this revision. zatrazz added reviewers: jroelofs, danalbert. zatrazz added subscribers: rengolin, cfe-commits. Herald added a subscriber: aemerson. Some tests uses 'long double' to/from conversions and for some targets they are provided by compiler runtime (either compiler-rt or li

Re: [PATCH] D23420: libcxx: Fix libcxx test on aarch64 with libunwind

zatrazz added a comment. I tried to find why exactly libgcc has to appear before and after but I couldn't get any information from commit history. On my system (aarch64/linux) I am also getting "-lc++" "-lm" "-lgcc_s" "-lgcc" "-lpthread" "-lc" "-lgcc_s" "-lgcc". I think we can got by the safe

Re: [PATCH] D23420: libcxx: Fix libcxx test on aarch64 with libunwind

zatrazz updated this revision to Diff 67835. zatrazz added a comment. What about this version? The only difference is for libunwind libgcc is still included. https://reviews.llvm.org/D23420 Files: test/libcxx/test/target_info.py Index: test/libcxx/test/target_info.py ===

[PATCH] D23449: libcxx: Fix path.compare.pass expected result

zatrazz created this revision. zatrazz added reviewers: jroelofs, danalbert, EricWF. zatrazz added subscribers: rmaprath, aemerson, rengolin, cfe-commits. The expected 'filesystem::path::compare' result states that for different only the sign of result integer contains the information about passed

Re: [PATCH] D23420: libcxx: Fix libcxx test on aarch64 with libunwind

zatrazz added a comment. Yes, but my understaning is the proposed link order will force libc++ to link against _Unwind* symbols from libunwind (this is what I am observing also). https://reviews.llvm.org/D23420 ___ cfe-commits mailing list cfe-comm

Re: [PATCH] D23420: libcxx: Fix libcxx test on aarch64 with libunwind

zatrazz added a comment. Yes, although in pratice for shared libraries this is not an issue (at least on Linux with current linker strategies). And I open for suggestion on how to proceed in this case since we have some other options: 1. Add the required soft-sp implementations when building fo

Re: [PATCH] D23420: libcxx: Fix libcxx test on aarch64 with libunwind

zatrazz added a comment. In https://reviews.llvm.org/D23420#513824, @jroelofs wrote: > In https://reviews.llvm.org/D23420#513820, @zatrazz wrote: > > > Yes, although in pratice for shared libraries this is not an issue (at > > least on Linux with current linker strategies). And I open for sugges

Re: [PATCH] D23420: libcxx: Fix libcxx test on aarch64 with libunwind

zatrazz updated this revision to Diff 67850. zatrazz added a comment. I think patch should be safe now. https://reviews.llvm.org/D23420 Files: test/libcxx/test/target_info.py Index: test/libcxx/test/target_info.py === --- test/l

Re: [PATCH] D23449: libcxx: Fix path.compare.pass expected result

zatrazz added a comment. Ping. https://reviews.llvm.org/D23449 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D23420: libcxx: Fix libcxx test on aarch64 with libunwind

zatrazz added a comment. Ping. https://reviews.llvm.org/D23420 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D61392: [clang] Handle lround/llround builtins

zatrazz created this revision. zatrazz added reviewers: efriedma, rengolin, javed.absar, huntergr, SjoerdMeijer, t.p.northover, echristo, evandro. zatrazz added a project: clang. Herald added subscribers: kristina, kristof.beyls. As for other floating-point rounding builtins that can be optimized

[PATCH] D62019: [clang] Handle lrint/llrint builtins

zatrazz created this revision. zatrazz added reviewers: efriedma, rengolin, javed.absar, huntergr, SjoerdMeijer, t.p.northover, echristo, evandro. zatrazz added a project: clang. Herald added subscribers: kristina, kristof.beyls. As for other floating-point rounding builtins that can be optimized

[PATCH] D62019: [clang] Handle lrint/llrint builtins

zatrazz updated this revision to Diff 200291. zatrazz added a comment. Updated patch based on D62026 . CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62019/new/ https://reviews.llvm.org/D62019 Files: clang/lib/CodeGen/CGBuiltin.cpp clang/test/CodeGen

[PATCH] D131307: [Clang] Allow downgrading to a warning the diagnostic for setting a non fixed enum to a value outside the range of the enumeration values

zatrazz added a comment. This commit seems to have broken test-suite on aarch64 [1]. The warning shows: FAILED: MultiSource/Benchmarks/PAQ8p/CMakeFiles/paq8p.dir/paq8p.cpp.o /home/adhemerval.zanella/projects/llvm/test-suite-build/tools/timeit --summary MultiSource/Benchmarks/PAQ8p/CMakeFiles

[PATCH] D131528: [Clang] Restrict non fixed enum to a value outside the range of the enumeration values warning to context requiring a constant expression

zatrazz added a comment. It does help on test-suite, thanks. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131528/new/ https://reviews.llvm.org/D131528 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mai

[PATCH] D71111: [Sema] Improve diagnostic about addr spaces for overload candidates

zatrazz added a comment. Hi, I am investigating a recurring regression on aarch64-linux bots and bisecting the commits on the build [1] that introduced the regression it points to this one. I don't understand exactly what is triggering the issue, but it only happen on the stage2 build with sta

[PATCH] D72449: [PATCH] [llvm-ranlib] Take in consideration UTC offset for D-flag.test

zatrazz created this revision. zatrazz added reviewers: arichardson, emaste, rupprecht. Herald added a subscriber: kristof.beyls. Herald added a project: LLVM. The llvm-ar uses localtime to print the object timestamp and it is subject to UTC offset (daylight for instance). The patch changes the t

[PATCH] D72449: [PATCH] [llvm-ranlib] Take in consideration UTC offset for D-flag.test

zatrazz marked 2 inline comments as done. zatrazz added inline comments. Comment at: llvm/test/tools/llvm-ranlib/D-flag.test:13 # RUN: cp %t-no-index.a %t.a && llvm-ranlib -D %t.a -# RUN: env TZ=UTC llvm-ar tv %t.a | FileCheck %s --check-prefix=DETERMINISTIC-VALUES +# RUN: (env

[PATCH] D72449: [PATCH] [llvm-ranlib] Take in consideration UTC offset for D-flag.test

zatrazz updated this revision to Diff 237134. zatrazz added a comment. Updated patch based on previous comments. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72449/new/ https://reviews.llvm.org/D72449 Files: llvm/test/tools/llvm-ranlib/D-flag.test Index: llvm/test/tools/llvm-ranli

[PATCH] D72449: [PATCH] [llvm-ranlib] Take in consideration UTC offset for D-flag.test

zatrazz added a comment. In D72449#1812130 , @arichardson wrote: > I was careful in the test to use `TZ=UTC` for all commands printing dates and > it works fine for me in UTC+1 and in the UK which is currently UTC. Does the > bot in question ignore the T

[PATCH] D72449: [PATCH] [llvm-ranlib] Take in consideration UTC offset for D-flag.test

zatrazz added a comment. In D72449#1812818 , @arichardson wrote: > I'm fine with this workaround although I'm very surprised that the test is > not working. Especially since `deterministic-archive.test` and > `replace-update.test` also set TZ to get repr

[PATCH] D96803: EntryExitInstrumenter: Move to a module pass and enable at all optimization levels (PR49143)

zatrazz created this revision. zatrazz added reviewers: lenary, ostannard, aeubanks. Herald added a subscriber: hiraditya. zatrazz requested review of this revision. Herald added projects: clang, LLVM. The function passes are disabled by default for optnone with the new pass manager. The pass is

[PATCH] D96803: EntryExitInstrumenter: Move to a module pass and enable at all optimization levels (PR49143)

zatrazz added a comment. In D96803#2566322 , @aeubanks wrote: > why is this now a module pass? Mainly to avoid the default rule from new pass manager to *not* apply any FunctionPass for optnone (which is the main issue for PR49143). Is there a better wa

[PATCH] D96803: EntryExitInstrumenter: Move to a module pass and enable at all optimization levels (PR49143)

zatrazz added a comment. In D96803#2569436 , @aeubanks wrote: > In D96803#2568179 , @zatrazz wrote: > >> In D96803#2566322 , @aeubanks wrote: >> >>> why is this now a module

[PATCH] D96803: EntryExitInstrumenter: Enable at all optimization levels (PR49143)

zatrazz updated this revision to Diff 325004. zatrazz retitled this revision from "EntryExitInstrumenter: Move to a module pass and enable at all optimization levels (PR49143)" to "EntryExitInstrumenter: Enable at all optimization levels (PR49143)". zatrazz edited the summary of this revision. za

[PATCH] D137267: [clang][Headers] Only define FLT_EVAL_METHOD for C99 and later

zatrazz created this revision. zatrazz added reviewers: jfb, eli.friedman, MaskRay. Herald added a subscriber: StephenFan. Herald added a project: All. zatrazz requested review of this revision. Herald added a project: clang. It was reported by glibc conform test [1]. [1] https://sourceware.org/

[PATCH] D137268: [clang][Headers] Do not define varargs macros for __need___va_list

zatrazz created this revision. zatrazz added reviewers: jfb, eli.friedman, MaskRay. Herald added subscribers: Enna1, StephenFan. Herald added a project: All. zatrazz requested review of this revision. Herald added projects: clang, Sanitizers. Herald added a subscriber: Sanitizers. The glibc uses t

[PATCH] D137267: [clang][Headers] Only define FLT_EVAL_METHOD for C99 and later

This revision was automatically updated to reflect the committed changes. Closed by commit rG92e172309cf6: [clang][Headers] Only define FLT_EVAL_METHOD for C99 and later (authored by zatrazz). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137267/new/

[PATCH] D137268: [clang][Headers] Do not define varargs macros for __need___va_list

zatrazz marked 2 inline comments as done. zatrazz added inline comments. Comment at: clang/lib/Headers/stdarg.h:17 +#ifndef __GNUC_VA_LIST +#define __GNUC_VA_LIST 1 +typedef __builtin_va_list __gnuc_va_list; MaskRay wrote: > To match gcc stdarg.h, `#define __GNUC

[PATCH] D137268: [clang][Headers] Do not define varargs macros for __need___va_list

zatrazz updated this revision to Diff 474028. zatrazz marked 2 inline comments as done. zatrazz added a comment. Update review based on reviewers comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137268/new/ https://reviews.llvm.org/D137268

[PATCH] D137268: [clang][Headers] Do not define varargs macros for __need___va_list

This revision was automatically updated to reflect the committed changes. Closed by commit rG9e956995db1f: [clang][Headers] Do not define varargs macros for __need___va_list (authored by zatrazz). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137268/

[PATCH] D137268: [clang][Headers] Do not define varargs macros for __need___va_list

zatrazz added a comment. In D137268#4069779 , @enh wrote: > is there a corresponding glibc change so that `va_list` is exported for > `_POSIX_SOURCE` cases? see > https://android-review.git.corp.google.com/c/platform/bionic/+/2397313 where > i'm having

[PATCH] D137268: [clang][Headers] Do not define varargs macros for __need___va_list

zatrazz added a comment. In D137268#4069935 , @enh wrote: > In D137268#4069856 , @zatrazz wrote: > >> I think I have caught this because your standard conformance tests checks >> for __gnuc_va_list >> on wchar.h