[PATCH] D111971: [clang] Allocate 2 bits to store the constexpr specifier kind when serializing

2021-10-18 Thread Adam Czachorowski via Phabricator via cfe-commits
adamcz accepted this revision. adamcz added a comment. This revision is now accepted and ready to land. Fix LGTM As for the test, I suggest putting it in clang/test/AST/, maybe in ast-dump-constant-expr? You can write a CHECK-NEXT: thingy to verify that consteval is preserved. The test already

[PATCH] D110823: [clangd] Add code completion of param name on /* inside function calls.

2021-10-19 Thread Adam Czachorowski via Phabricator via cfe-commits
adamcz updated this revision to Diff 380636. adamcz marked an inline comment as done. adamcz added a comment. final review comment (dropped Preamble check) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110823/new/ https://reviews.llvm.org/D110823

[PATCH] D110823: [clangd] Add code completion of param name on /* inside function calls.

2021-10-19 Thread Adam Czachorowski via Phabricator via cfe-commits
adamcz added inline comments. Comment at: clang-tools-extra/clangd/CodeComplete.cpp:1963 +auto OffsetBeforeComment = *Offset - 2; +return codeCompleteComment(FileName, OffsetBeforeComment, Preamble, + ParseInput); kadircet wr

[PATCH] D110823: [clangd] Add code completion of param name on /* inside function calls.

2021-10-19 Thread Adam Czachorowski via Phabricator via cfe-commits
This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG8fbac4e88ac3: [clangd] Add code completion of param name on /* inside function calls. (authored by adamcz). Repository: rG LLVM Github Monorepo C

<    1   2   3   4