[PATCH] D105478: [clang] Make CXXRecrdDecl invalid if it contains any undeduced fields.

adamcz created this revision. adamcz added a reviewer: hokein. adamcz requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Undeduced fields in a valid record cause crashes when trying to obtain the size and/or layout of the record. Repository:

[PATCH] D105478: [clang] Make CXXRecrdDecl invalid if it contains any undeduced fields.

adamcz updated this revision to Diff 356925. adamcz added a comment. changed to marking field type as invalid Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105478/new/ https://reviews.llvm.org/D105478 Files: clang/lib/Sema/SemaDecl.cpp clang/t

[PATCH] D105478: [clang] Make CXXRecrdDecl invalid if it contains any undeduced fields.

adamcz added inline comments. Comment at: clang/test/SemaCXX/cxx11-crashes.cpp:117 + // The missing expression makes A undeduced. + static constexpr auto A = ; // expected-error {{expected expression}} + Foo::type B; // The type of B is also undeduced (wrapped in Elaborated

[PATCH] D105478: [clang] Make CXXRecrdDecl invalid if it contains any undeduced fields.

adamcz updated this revision to Diff 357511. adamcz added a comment. Fix a more generic case of invalid static initializer Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105478/new/ https://reviews.llvm.org/D105478 Files: clang/lib/Parse/ParseDec

[PATCH] D105478: [clang] Make CXXRecrdDecl invalid if it contains any undeduced fields.

adamcz added a comment. OK, I think we've got it now :-) I kept the original crash test in the change, but I'm not sure if it's appropriate anymore. Let me know if you think I should remove it. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105478/

[PATCH] D112527: [clangd] Fix a hover crash on templated spaceship operator.

adamcz created this revision. adamcz added a reviewer: kadircet. Herald added subscribers: usaxena95, arphaman, yaxunl. adamcz requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added a project: clang-tools-extra. We make assumption that: getDe

[PATCH] D112530: [clangd] AddUsing: Fix support for template specializations.

adamcz created this revision. Herald added subscribers: usaxena95, kadircet, arphaman. adamcz requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added a project: clang-tools-extra. Before this change, we would add "using std::vector" instead of

[PATCH] D112527: [clangd] Fix a hover crash on templated spaceship operator.

adamcz updated this revision to Diff 382326. adamcz marked 2 inline comments as done. adamcz added a comment. review comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112527/new/ https://reviews.llvm.org/D112527 Files: clang-tools-extra/cla

[PATCH] D112530: [clangd] AddUsing: Fix support for template specializations.

adamcz removed a reviewer: usaxena95. adamcz added a comment. Thanks Kadir! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112530/new/ https://reviews.llvm.org/D112530 ___ cfe-commits mailing list cfe-com

[PATCH] D112530: [clangd] AddUsing: Fix support for template specializations.

adamcz updated this revision to Diff 382335. adamcz added a comment. review comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112530/new/ https://reviews.llvm.org/D112530 Files: clang-tools-extra/clangd/refactor/tweaks/AddUsing.cpp clang-

[PATCH] D112527: [clangd] Fix a hover crash on templated spaceship operator.

This revision was automatically updated to reflect the committed changes. Closed by commit rGe8f4a0118914: [clangd] Fix a hover crash on templated spaceship operator. (authored by adamcz). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112527/new/ ht

[PATCH] D112530: [clangd] AddUsing: Fix support for template specializations.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG2174524116a8: [clangd] AddUsing: Fix support for template specializations. (authored by adamcz). Repository: rG LLVM Github Monorepo CHANGES SINC

[PATCH] D112628: NOT READY FOR REVIEW Nothing to see here, just exporting to show this to someone.

adamcz created this revision. Herald added subscribers: usaxena95, kadircet, arphaman. adamcz requested review of this revision. Herald added a project: clang-tools-extra. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D112628 Files: clan

[PATCH] D113029: [clangd] Find definition of ClassTemplate without going through index.

adamcz created this revision. adamcz added a reviewer: kadircet. Herald added subscribers: usaxena95, arphaman. adamcz requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added a project: clang-tools-extra. I noticed that, while go-to-def works

[PATCH] D113120: [clang] Add early exit when checking for const init of arrays.

adamcz created this revision. adamcz added a reviewer: kadircet. adamcz requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Before this commit, on code like: struct S { ... }; S arr[1000]; while checking if arr is constexpr, clang wou

[PATCH] D113120: [clang] Add early exit when checking for const init of arrays.

adamcz added a comment. Hey Kadir. This is my naive approach at solving that large memory usage issue you reported. It works, although I wish this was more generic. I'm not an expert on this piece of code, so I tried to keep things similar to how they worked previously. Let me know what you thi

[PATCH] D113029: [clangd] Find definition of ClassTemplate without going through index.

This revision was automatically updated to reflect the committed changes. Closed by commit rG97fbc975fab1: [clangd] Find definition of ClassTemplate without going through index. (authored by adamcz). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D1130

[PATCH] D111318: [clang][clangd] Improve signature help for variadic functions.

adamcz updated this revision to Diff 385071. adamcz added a comment. addressed review comment Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111318/new/ https://reviews.llvm.org/D111318 Files: clang-tools-extra/clangd/CodeComplete.cpp clang-too

[PATCH] D111318: [clang][clangd] Improve signature help for variadic functions.

adamcz added a comment. Sorry for delay, I got distracted with other stuff. I addressed your comment, partially, and also added more tests and fixed one more issue (see the FunctionType test, it would've failed before). Comment at: clang/lib/Sema/SemaOverload.cpp:6460 // l

[PATCH] D113120: [clang] Add early exit when checking for const init of arrays.

adamcz updated this revision to Diff 385102. adamcz marked an inline comment as done. adamcz added a comment. review comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D113120/new/ https://reviews.llvm.org/D113120 Files: clang/lib/AST/ExprCon

[PATCH] D113120: [clang] Add early exit when checking for const init of arrays.

adamcz added inline comments. Comment at: clang/lib/AST/ExprConstant.cpp:10617 +// copying the data, which is wasteful. +for (const unsigned N : {1u, FinalSize}) { + unsigned OldElts = Value->getArrayInitializedElts(); kadircet wrote: > maybe unroll

[PATCH] D113570: [clang] Do not crash in APValue::prettyPrint() on forward-decl structs.

adamcz created this revision. adamcz added a reviewer: hokein. Herald added subscribers: usaxena95, kadircet, arphaman. adamcz requested review of this revision. Herald added projects: clang, clang-tools-extra. Herald added a subscriber: cfe-commits. The call to getTypeSizeInChars() is replaced wi

[PATCH] D113570: [clang] Do not crash in APValue::prettyPrint() on forward-decl structs.

This revision was automatically updated to reflect the committed changes. Closed by commit rG7a2b1bdb4c8a: [clang] Do not crash in APValue::prettyPrint() on forward-decl structs. (authored by adamcz). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D113

[PATCH] D113120: [clang] Add early exit when checking for const init of arrays.

This revision was automatically updated to reflect the committed changes. Closed by commit rG48bb5f4cbe8d: [clang] Add early exit when checking for const init of arrays. (authored by adamcz). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D113120/new/

[PATCH] D113583: [clang] Fix armv7-quick build by hardcoding -triple=x86_64 in OOM test.

adamcz created this revision. adamcz added a reviewer: kadircet. Herald added a subscriber: kristof.beyls. adamcz requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. The test was added in 48bb5f4cbe8d5951c1153e469dc6713a122b7fa3

[PATCH] D113583: [clang] Fix armv7-quick build by hardcoding -triple=x86_64 in OOM test.

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG581a6a8118f5: [clang] Fix armv7-quick build by hardcoding -triple=

[PATCH] D113120: [clang] Add early exit when checking for const init of arrays.

adamcz added a comment. Sorry for trouble, I will revert this for now. It's only the test that's causing the problem, the fix is fine, as far as I can tell. Still, better revert the whole thing for now. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org

[PATCH] D113599: Revert "[clang] Add early exit when checking for const init of arrays."

adamcz created this revision. adamcz added a reviewer: kadircet. Herald added a subscriber: kristof.beyls. adamcz requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This reverts commit 48bb5f4cbe8d5951c1153e469dc6713a122b7fa3

[PATCH] D113599: Revert "[clang] Add early exit when checking for const init of arrays."

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG6d09aaecdfe5: Revert "[clang] Add early exit when checking for con

[PATCH] D97965: [clang] Fix crash when creating deduction guide.

adamcz created this revision. adamcz requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. We used to trigger assertion when transforming c-tor with unparsed default argument. Now we ignore such constructors for this purpose. Repository: rG L

[PATCH] D97965: [clang] Fix crash when creating deduction guide.

adamcz updated this revision to Diff 328206. adamcz added a comment. format Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97965/new/ https://reviews.llvm.org/D97965 Files: clang/lib/Sema/SemaTemplate.cpp clang/test/SemaCXX/cxx1z-class-template

[PATCH] D97965: [clang] Fix crash when creating deduction guide.

adamcz updated this revision to Diff 329346. adamcz added a comment. expanded a comment Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97965/new/ https://reviews.llvm.org/D97965 Files: clang/lib/Sema/SemaTemplate.cpp clang/test/SemaCXX/cxx1z-cl

[PATCH] D97965: [clang] Fix crash when creating deduction guide.

adamcz added inline comments. Comment at: clang/test/SemaCXX/cxx1z-class-template-argument-deduction.cpp:425 + // This used to crash due to unparsed default arg above. + B(); // expected-error {{deduction guide declaration without trailing return type}} +}; ho

[PATCH] D97965: [clang] Fix crash when creating deduction guide.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG4e1c487004a2: [clang] Fix crash when creating deduction guide. (authored by adamcz). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTIO

[PATCH] D111971: [clang] Allocate 2 bits to store the constexpr specifier kind when serializing

adamcz accepted this revision. adamcz added a comment. This revision is now accepted and ready to land. Looks good. Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111971/new/ https://reviews.llvm.org/D111971

[PATCH] D111318: [clang][clangd] Improve signature help for variadic functions.

adamcz updated this revision to Diff 388167. adamcz marked an inline comment as done. adamcz added a comment. addressed review comments, added new test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111318/new/ https://reviews.llvm.org/D111318 File

[PATCH] D111318: [clang][clangd] Improve signature help for variadic functions.

adamcz added a comment. Added a slightly awkward clang (not clangd) test. The output is suboptimial, because it's not clangd, but it shows things work as they should. Comment at: clang-tools-extra/clangd/CodeComplete.cpp:929 +// +// This only matters for variad

[PATCH] D111318: [clang][clangd] Improve signature help for variadic functions.

This revision was automatically updated to reflect the committed changes. Closed by commit rG55a79318c60d: [clang][clangd] Improve signature help for variadic functions. (authored by adamcz). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111318/new/

[PATCH] D131569: [clangd] Allow updates to be canceled after compile flags retrieval

adamcz added inline comments. Comment at: clang-tools-extra/clangd/TUScheduler.cpp:898 +if (isCancelled()) { + log("ASTWorker skipping update {0} for file {1}", Inputs.Version, + FileName); I'd add something like "due to cancellation". I know yo

[PATCH] D134180: [clang] Fix a nullptr-access crash in CheckTemplateArgument.

adamcz accepted this revision. adamcz added inline comments. This revision is now accepted and ready to land. Comment at: clang/lib/Sema/SemaTemplate.cpp:6960 +if (ParamType.isNull()) + return ExprError(); // CheckNonTypeTemplateParameterType will produce a diagnost

[PATCH] D135226: [clangd] Optimize Dex::generateProximityURIs().

adamcz added inline comments. Comment at: clang-tools-extra/clangd/index/dex/Dex.cpp:358 +// Returns^ +const char *findPathInURI(const char *S) { + // Skip over scheme. Is there a reason why you're doing this with manual manipulation of C-strings instea

[PATCH] D127749: [clangd] Wire up compilation for style blocks

adamcz accepted this revision. adamcz added a comment. This revision is now accepted and ready to land. Wait, what? How? Whaaat? How did that happen? Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D127749/new/ https://reviews.llvm.org/D12774

[PATCH] D76432: [clangd] Add a tweak for adding "using" statement.

adamcz updated this revision to Diff 253164. adamcz marked 22 inline comments as done. adamcz added a comment. Addressed review comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76432/new/ https://reviews.llvm.org/D76432 Files: clang-tools-

[PATCH] D76432: [clangd] Add a tweak for adding "using" statement.

adamcz added inline comments. Comment at: clang-tools-extra/clangd/refactor/tweaks/AddUsing.cpp:34 +// True iff "using" already exists and we should not add it. +bool IdenticalUsingFound = false; +// Location to insert the "using" statement. sammccall

[PATCH] D76432: [clangd] Add a tweak for adding "using" statement.

adamcz updated this revision to Diff 253165. adamcz added a comment. clang-format Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76432/new/ https://reviews.llvm.org/D76432 Files: clang-tools-extra/clangd/refactor/tweaks/AddUsing.cpp clang-tools

[PATCH] D76432: [clangd] Add a tweak for adding "using" statement.

adamcz updated this revision to Diff 253583. adamcz marked 10 inline comments as done. adamcz added a comment. review round 2 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76432/new/ https://reviews.llvm.org/D76432 Files: clang-tools-extra/clang

[PATCH] D76432: [clangd] Add a tweak for adding "using" statement.

adamcz added inline comments. Comment at: clang-tools-extra/clangd/refactor/tweaks/AddUsing.cpp:89 + + // If we're looking at a type or NestedNameSpecifier, walk up the tree until + // we find the "main" node we care about, which would be ElaboratedTypeLoc or s

[PATCH] D76432: [clangd] Add a tweak for adding "using" statement.

adamcz added a comment. In D76432#1952798 , @sammccall wrote: > Still LG, should I land this? Yes please :) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76432/new/ https://reviews.llvm.org/D76432

[PATCH] D76429: [clangd] Fix elog message when preamble build fails.

adamcz created this revision. adamcz added a reviewer: sammccall. Herald added subscribers: cfe-commits, usaxena95, kadircet, arphaman, jkorous, MaskRay, ilya-biryukov. Herald added a project: clang. sammccall accepted this revision. This revision is now accepted and ready to land. Repository:

[PATCH] D76432: [clangd] Add a tweak for adding "using" statement.

adamcz created this revision. Herald added subscribers: cfe-commits, usaxena95, kadircet, arphaman, mgrang, jkorous, MaskRay, ilya-biryukov, mgorny. Herald added a project: clang. This triggers on types and function calls with namespace qualifiers. The action is to remove the qualifier and instea

[PATCH] D120569: [clang] Improve laziness of resolving module map headers.

adamcz created this revision. adamcz added a reviewer: kadircet. adamcz requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. clang has support for lazy headers in module maps - if size and/or modtime and provided in the cppmap file, headers are

[PATCH] D120569: [clang] Improve laziness of resolving module map headers.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG8f4ea36bfe4c: [clang] Improve laziness of resolving module map headers. (authored by adamcz). Repository: rG LLVM Github Monorepo CHANGES SINCE L

[PATCH] D100675: [clang] Do not crash on template specialization following a fatal error

This revision was automatically updated to reflect the committed changes. Closed by commit rGddfbdbfefae0: [clang] Do not crash on template specialization following a fatal error (authored by adamcz). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100

[PATCH] D100667: [clang] Fix assert() crash when checking undeduced arg alignment

adamcz added inline comments. Comment at: clang/lib/Sema/SemaChecking.cpp:4543 // getTypeAlignInChars requires complete types - if (ParamTy->isIncompleteType() || ArgTy->isIncompleteType() || - ParamTy->isUndeducedType() || ArgTy->isUndeducedType()) + auto CheckTypeOK =

[PATCH] D100667: [clang] Fix assert() crash when checking undeduced arg alignment

adamcz updated this revision to Diff 340527. adamcz added a comment. Added a fix in CreateRecoveryExpr Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100667/new/ https://reviews.llvm.org/D100667 Files: clang/lib/Sema/SemaChecking.cpp clang/lib/

[PATCH] D100667: [clang] Fix assert() crash when checking undeduced arg alignment

adamcz updated this revision to Diff 340802. adamcz marked 2 inline comments as done. adamcz added a comment. review comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100667/new/ https://reviews.llvm.org/D100667 Files: clang/lib/Sema/SemaCh

[PATCH] D100667: [clang] Fix assert() crash when checking undeduced arg alignment

adamcz added inline comments. Comment at: clang/lib/Sema/SemaExpr.cpp:19668 T = Context.DependentTy; + else if (const auto *U = T->getUnqualifiedDesugaredType()) +if (U->isUndeducedType()) hokein wrote: > I'm not sure we need this well. I think the abov

[PATCH] D100667: [clang] Fix assert() crash when checking undeduced arg alignment

adamcz updated this revision to Diff 341244. adamcz added a comment. moved the test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100667/new/ https://reviews.llvm.org/D100667 Files: clang/lib/Sema/SemaChecking.cpp clang/lib/Sema/SemaExpr.cpp

[PATCH] D100667: [clang] Fix assert() crash when checking undeduced arg alignment

adamcz updated this revision to Diff 341898. adamcz added a comment. typeof Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100667/new/ https://reviews.llvm.org/D100667 Files: clang/lib/Sema/SemaChecking.cpp clang/lib/Sema/SemaExpr.cpp clang/t

[PATCH] D100667: [clang] Fix assert() crash when checking undeduced arg alignment

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGfbfcfdbf6828: [clang] Fix assert() crash when checking undeduced arg alignment (authored by adamcz). Repository: rG LLVM Github Monorepo CHANGES

[PATCH] D100667: [clang] Fix assert() crash when checking undeduced arg alignment

adamcz created this revision. Herald added a subscriber: kristof.beyls. adamcz requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. There already was a check for undeduced and incomplete types, but it failed to trigger when outer type (SubstTemp

[PATCH] D100675: [clang] Do not crash on template specialization following a fatal error

adamcz created this revision. adamcz added a reviewer: sammccall. adamcz requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. There was a missing isInvalid() check leading to an attempt to instantiate template with an empty instantiation stack.

[PATCH] D100675: [clang] Do not crash on template specialization following a fatal error

adamcz updated this revision to Diff 338497. adamcz added a comment. minor changes to test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100675/new/ https://reviews.llvm.org/D100675 Files: clang/lib/Sema/SemaTemplateDeduction.cpp clang/test/Se

[PATCH] D93220: [clangd] Add error handling (elog) in code completion.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG0999408aea79: [clangd] Add error handling (elog) in code completion. (authored by adamcz). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D94259: [clangd] Fix type printing in the presence of qualifiers

adamcz created this revision. Herald added subscribers: usaxena95, kadircet, arphaman. adamcz requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added a project: clang. When printing QualType with qualifiers like "const", or pointing to an elab

[PATCH] D94259: [clangd] Fix type printing in the presence of qualifiers

adamcz updated this revision to Diff 315363. adamcz marked an inline comment as done. adamcz added a comment. Addressed review comment Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D94259/new/ https://reviews.llvm.org/D94259 Files: clang-tools-ex

[PATCH] D94259: [clangd] Fix type printing in the presence of qualifiers

adamcz added a comment. Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D94259/new/ https://reviews.llvm.org/D94259 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi

[PATCH] D94259: [clangd] Fix type printing in the presence of qualifiers

adamcz updated this revision to Diff 315398. adamcz marked an inline comment as done. adamcz added a comment. final review comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D94259/new/ https://reviews.llvm.org/D94259 Files: clang-tools-extra

[PATCH] D94259: [clangd] Fix type printing in the presence of qualifiers

adamcz updated this revision to Diff 315401. adamcz added a comment. s/NS/DC Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D94259/new/ https://reviews.llvm.org/D94259 Files: clang-tools-extra/clangd/AST.cpp clang-tools-extra/clangd/unittests/tw

[PATCH] D94259: [clangd] Fix type printing in the presence of qualifiers

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGd4af86581e80: [clangd] Fix type printing in the presence of qualifiers (authored by adamcz). Repository: rG LLVM Github Monorepo CHANGES SINCE LA

[PATCH] D94314: [clangd] Add missing "override" to fix the build.

adamcz created this revision. Herald added subscribers: usaxena95, kadircet, arphaman. adamcz requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added a project: clang. Follow-up to d4af86581e80ef0f7a6f4a4fff1c97260a726e71

[PATCH] D94314: [clangd] Add missing "override" to fix the build.

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG2e1bb7940a4d: [clangd] Add missing "override" to fix the build. (a

[PATCH] D94321: [clangd] Prevent tests from failing when /tmp/compile_flags.txt exists

adamcz created this revision. Herald added subscribers: usaxena95, kadircet, arphaman. adamcz requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added a project: clang. The BuildDir test uses RealFS and would fail when /tmp/compile_flags.txt or

[PATCH] D94359: [clangd] Remove ScratchFS from tests

adamcz accepted this revision. adamcz added a comment. This revision is now accepted and ready to land. Thanks, that's better than my hacky workaround! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D94359/new/ https://reviews.llvm.org/D94359 __

[PATCH] D94424: [clangd] Make AST-based signals available to runWithPreamble.

adamcz added inline comments. Comment at: clang-tools-extra/clangd/TUScheduler.cpp:858 +std::string RelatedNS = OS.str(); +if (!RelatedNS.empty()) { + Signals.RelatedNamespaces[RelatedNS + "::"] += 1; nit: I think you can just

[PATCH] D94699: [clangd] Set correct CWD when using compile_flags.txt

adamcz created this revision. Herald added subscribers: usaxena95, kadircet, arphaman. adamcz requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added a project: clang. This fixes a bug where clangd would attempt to set CWD to the compile_flags

[PATCH] D94704: [clang] Do not crash when CXXRecordDecl has a non-CXXRecordDecl base.

adamcz created this revision. adamcz added a reviewer: hokein. adamcz requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This can happen on some invalid code, like the included test case. Repository: rG LLVM Github Monorepo https://review

[PATCH] D94704: [clang] Do not crash when CXXRecordDecl has a non-CXXRecordDecl base.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGa71877edfbb7: [clang] Do not crash when CXXRecordDecl has a non-CXXRecordDecl base. (authored by adamcz). Repository: rG LLVM Github Monorepo CHA

[PATCH] D94719: [clangd] Make ExpandAutoType not available on template params.

adamcz created this revision. adamcz added a reviewer: hokein. Herald added subscribers: usaxena95, kadircet, arphaman. adamcz requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added a project: clang. We cannot expand auto when used inside a t

[PATCH] D94697: [clangd] Update CC Ranking model with better sampling.

adamcz accepted this revision. adamcz added inline comments. This revision is now accepted and ready to land. Comment at: clang-tools-extra/clangd/Quality.cpp:515 + E.setFractionNameInContext( + Relevance.ContextWords ? NumMatch * 1.0 / Relevance.ContextWords->size() +

[PATCH] D94473: [clangd] Use AST-based signals in CodeCompletion.

adamcz added inline comments. Comment at: clang-tools-extra/clangd/Quality.cpp:349 + }; + DeriveASTSignals(); // Declarations are scoped, others (like macros) are assumed global. Maybe it's just me, but using a lambda like this seems quite confusing. I don't

[PATCH] D94719: [clangd] Make ExpandAutoType not available on template params.

This revision was automatically updated to reflect the committed changes. Closed by commit rGaeaeb9e6bdc9: [clangd] Make ExpandAutoType not available on template params. (authored by adamcz). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D94719/new/

[PATCH] D94699: [clangd] Set correct CWD when using compile_flags.txt

This revision was automatically updated to reflect the committed changes. Closed by commit rGc77c3d1d18cd: [clangd] Set correct CWD when using compile_flags.txt (authored by adamcz). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D94699/new/ https://r

[PATCH] D94804: [clang] Allow LifetimeExtendedTemporary to have no access specifier

adamcz created this revision. adamcz added a reviewer: hokein. adamcz requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. The check only runs in debug mode during serialization, but assert()-fail on: struct S { const int& x = 7; }; in C++ m

[PATCH] D94804: [clang] Allow LifetimeExtendedTemporary to have no access specifier

adamcz added inline comments. Comment at: clang/lib/AST/DeclBase.cpp:986 + isa(this) || + isa(this)) return true; hokein wrote: > nit: personally I'd keep the old format style, just appending the new case. I like the old formatting a little better

[PATCH] D94919: [clangd] Fix a crash when indexing invalid ObjC method declaration

adamcz created this revision. Herald added subscribers: usaxena95, kadircet, arphaman. adamcz requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added a project: clang. This fix will make us not crash, but ideally we would handle this case bett

[PATCH] D94804: [clang] Allow LifetimeExtendedTemporary to have no access specifier

This revision was automatically updated to reflect the committed changes. Closed by commit rG196cc96f9a64: [clang] Allow LifetimeExtendedTemporary to have no access specifier (authored by adamcz). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D94804/n

[PATCH] D94933: [clang] Check for nullptr when instantiating late attrs

adamcz created this revision. adamcz added a reviewer: hokein. Herald added subscribers: usaxena95, kadircet. adamcz requested review of this revision. Herald added subscribers: cfe-commits, ilya-biryukov. Herald added a project: clang. This was already done in SemaTemplateInstantiateDecl.cpp, but

[PATCH] D94933: [clang] Check for nullptr when instantiating late attrs

This revision was automatically updated to reflect the committed changes. Closed by commit rGa6f9077b16da: [clang] Check for nullptr when instantiating late attrs (authored by adamcz). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D94933/new/ https:/

[PATCH] D94927: [clangd] Use ASTSignals in Heuristics CC Ranking.

adamcz accepted this revision. adamcz added inline comments. This revision is now accepted and ready to land. Comment at: clang-tools-extra/clangd/Quality.cpp:477 + if (MainFileRefs >= 2) { +// E.g.: (2, 1.12), (9, 2.0), (48, 3.0). Can you add a comment ex

[PATCH] D95145: [clang] Fix a nullptr dereference bug on invalid code

adamcz created this revision. adamcz added a reviewer: hokein. adamcz requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. When working with invalid code, we would try to dereference a nullptr while deducing template arguments in some dependend

[PATCH] D111318: [clang][clangd] Improve signature help for variadic functions.

adamcz created this revision. adamcz added a reviewer: sammccall. Herald added subscribers: usaxena95, kadircet, arphaman. adamcz requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added projects: clang, clang-tools-extra. This covers both C-st

[PATCH] D110823: [clangd] Add code completion of param name on /* inside function calls.

adamcz updated this revision to Diff 377891. adamcz marked an inline comment as done. adamcz added a comment. addressed review comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110823/new/ https://reviews.llvm.org/D110823 Files: clang-tools

[PATCH] D110823: [clangd] Add code completion of param name on /* inside function calls.

adamcz added inline comments. Comment at: clang-tools-extra/clangd/CodeComplete.cpp:1148 + std::set ParamNamesSeen; +}; // SignatureHelpCollector + kadircet wrote: > change the ending comment (well, I'd actually drop it completely) Oops, too much copy/paste. We

[PATCH] D111648: [clangd] TargetFinder: Fix assert-crash on TemplateExpansion args.

adamcz created this revision. adamcz added a reviewer: nridge. Herald added subscribers: usaxena95, kadircet, arphaman. adamcz requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added a project: clang-tools-extra. Previously we would call getAs

[PATCH] D111648: [clangd] TargetFinder: Fix assert-crash on TemplateExpansion args.

adamcz added a comment. Hi Nathan Would you mind reviewing this change? It's related to your https://reviews.llvm.org/D85503 Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111648/new/ https://reviews.llvm.org/D111648

[PATCH] D110823: [clangd] Add code completion of param name on /* inside function calls.

adamcz updated this revision to Diff 379070. adamcz marked 3 inline comments as done. adamcz added a comment. next round of review comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110823/new/ https://reviews.llvm.org/D110823 Files: clang-t

[PATCH] D110823: [clangd] Add code completion of param name on /* inside function calls.

adamcz added inline comments. Comment at: clang-tools-extra/clangd/CodeComplete.cpp:1145 + CodeCompletionTUInfo CCTUInfo; + std::vector &ParamNames; + // For de-duplication only. StringRefs based on strings in ParamNames. kadircet wrote: > nit: Why not directl

[PATCH] D111648: [clangd] TargetFinder: Fix assert-crash on TemplateExpansion args.

adamcz updated this revision to Diff 379335. adamcz marked an inline comment as done. adamcz added a comment. removed unnecessary Flags.clear() Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111648/new/ https://reviews.llvm.org/D111648 Files: cla

[PATCH] D111648: [clangd] TargetFinder: Fix assert-crash on TemplateExpansion args.

This revision was automatically updated to reflect the committed changes. Closed by commit rGfba563e92b64: [clangd] TargetFinder: Fix assert-crash on TemplateExpansion args. (authored by adamcz). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111648/n

<    1   2   3   4   >