[PATCH] D128663: Removed old test file.

abrahamcd created this revision. Herald added a project: All. abrahamcd requested review of this revision. Herald added a project: clang-tools-extra. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D128663 Files: clang-tools-extra/test/cla

[PATCH] D128372: [Clang-Tidy] Empty Check

abrahamcd updated this revision to Diff 440286. abrahamcd added a comment. Removed old test file. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128372/new/ https://reviews.llvm.org/D128372 Files: clang-tools-extra/clang-tidy/bugprone/BugproneTid

[PATCH] D128372: [Clang-Tidy] Empty Check

abrahamcd added inline comments. Comment at: clang-tools-extra/clang-tidy/bugprone/StandaloneEmptyCheck.cpp:51-57 +auto Methods = MemberCall->getRecordDecl()->methods(); +auto Clear = llvm::find_if(Methods, [](const CXXMethodDecl *F) { + return F->getDeclName().getAs

[PATCH] D128372: [Clang-Tidy] Empty Check

abrahamcd updated this revision to Diff 440346. abrahamcd marked 7 inline comments as done. abrahamcd added a comment. Addressed review edits and clarity feedback. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128372/new/ https://reviews.llvm.org/D

[PATCH] D128372: [Clang-Tidy] Empty Check

abrahamcd updated this revision to Diff 440742. abrahamcd added a comment. Progress Update Hit a roadblock with determining unused return value, uploading current state for further work. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128372/new/ ht

[PATCH] D128372: [Clang-Tidy] Empty Check

abrahamcd planned changes to this revision. abrahamcd added a comment. Stuck on determining unused return value, uploaded current state for @denik and @cjdb to take a look. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128372/new/ https://reviews.

[PATCH] D128372: [Clang-Tidy] Empty Check

abrahamcd updated this revision to Diff 443017. abrahamcd edited the summary of this revision. abrahamcd added a comment. Adds functionality for only warning on the case of unused return value of the call to `empty()` and removes using-directive. Repository: rG LLVM Github Monorepo CHANGES SI

[PATCH] D128372: [Clang-Tidy] Empty Check

abrahamcd updated this revision to Diff 443056. abrahamcd marked 3 inline comments as done. abrahamcd added a comment. Adds argument 0 test case and refactoring based on feedback. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128372/new/ https://re

[PATCH] D128372: [Clang-Tidy] Empty Check

abrahamcd added a comment. Hi all, I just wanted to check in on this again and see if any more feedback or progress could be made. Thank you! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128372/new/ https://reviews.llvm.org/D128372 _

[PATCH] D131084: Add support for specifying the severity of a SARIF Result.

abrahamcd added a comment. In D131084#3697211 , @vaibhav.y wrote: > Submitting for review: > > Some notes: > > There are a couple of ways I think we can acheive this, per the spec: > > 1. The reportingDescriptor (rule) objects can be given a default > co

[PATCH] D128372: [Clang-Tidy] Empty Check

abrahamcd updated this revision to Diff 450407. abrahamcd added a comment. Checks for `clear()` in base classes as well. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128372/new/ https://reviews.llvm.org/D128372 Files: clang-tools-extra/clang-ti

[PATCH] D128372: [Clang-Tidy] Empty Check

abrahamcd updated this revision to Diff 450430. abrahamcd added a comment. Adds non-dependent base class test case. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128372/new/ https://reviews.llvm.org/D128372 Files: clang-tools-extra/clang-tidy/bu

[PATCH] D128372: [Clang-Tidy] Empty Check

abrahamcd added inline comments. Comment at: clang-tools-extra/clang-tidy/bugprone/StandaloneEmptyCheck.cpp:177-178 + diag(NonMemberLoc, "ignoring the result of '%0', did you mean 'clear()'?") + << llvm::dyn_cast(NonMemberCall->getCalleeDecl()) + -

[PATCH] D128372: [Clang-Tidy] Empty Check

abrahamcd updated this revision to Diff 451209. abrahamcd marked 5 inline comments as done. abrahamcd added a comment. Adds check for the compatibility of qualifiers on the clear method and the object it is called on. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://re

[PATCH] D128372: [Clang-Tidy] Empty Check

abrahamcd updated this revision to Diff 451212. abrahamcd added a comment. Minor formatting/naming fixes. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128372/new/ https://reviews.llvm.org/D128372 Files: clang-tools-extra/clang-tidy/bugprone/Bug

[PATCH] D131632: [WIP] Enable SARIF Diagnostics

abrahamcd created this revision. Herald added a subscriber: mgorny. Herald added a project: All. abrahamcd requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Work in progress to enable Clang to emit SARIF diagnostics. Repository: rG LLVM G

[PATCH] D109701: [clang] Emit SARIF Diagnostics: Create `clang::SarifDocumentWriter` interface

abrahamcd added a subscriber: denik. abrahamcd added a comment. Hi! I'm interning with @cjdb and @denik this summer and I was working on adding a `-fdiagnostics-format=sarif` option to start off my project, but I just found that a previous abandoned version of this change (D109697

[PATCH] D109701: [clang] Emit SARIF Diagnostics: Create `clang::SarifDocumentWriter` interface

abrahamcd added a comment. In D109701#3648168 , @vaibhav.y wrote: > In D109701#3646856 , @abrahamcd > wrote: > >> Hi! I'm interning with @cjdb and @denik this summer and I was working on >> adding a `-fdiagnosti

[PATCH] D128372: [Clang-Tidy] Empty Check

abrahamcd added a comment. Gentle ping! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128372/new/ https://reviews.llvm.org/D128372 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.ll

[PATCH] D129886: Adds `-fdiagnostics-format=sarif` flag option and warning.

abrahamcd created this revision. Herald added a project: All. abrahamcd requested review of this revision. Herald added subscribers: cfe-commits, MaskRay. Herald added a project: clang. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D129886 Files: clang/include/clang/Basic/Diag

[PATCH] D129886: Adds `-fdiagnostics-format=sarif` flag option and warning.

abrahamcd updated this revision to Diff 445073. abrahamcd added a comment. Edited commit message Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129886/new/ https://reviews.llvm.org/D129886 Files: clang/include/clang/Basic/DiagnosticDriverKinds.td

[PATCH] D129886: [clang] Add -fdiagnostics-format=sarif for SARIF diagnostics

abrahamcd updated this revision to Diff 445077. abrahamcd retitled this revision from "Adds `-fdiagnostics-format=sarif` flag option and warning." to "[clang] Add -fdiagnostics-format=sarif for SARIF diagnostics". abrahamcd edited the summary of this revision. abrahamcd added a comment. Commit m

[PATCH] D129886: [clang] Add -fdiagnostics-format=sarif option for future SARIF output

abrahamcd updated this revision to Diff 445554. abrahamcd retitled this revision from "[clang] Add -fdiagnostics-format=sarif for SARIF diagnostics" to "[clang] Add -fdiagnostics-format=sarif option for future SARIF output". abrahamcd edited the summary of this revision. abrahamcd added a comment

[PATCH] D129886: [clang] Add -fdiagnostics-format=sarif option for future SARIF output

abrahamcd added a comment. In D129886#3656221 , @vaibhav.y wrote: > Might be worth hiding it from `--help`, despite the instability warning. I already couldn't find any mention of `-fdiagnostics-format` or `sarif` when I ran `clang --help`. Is there so

[PATCH] D129886: [clang] Add -fdiagnostics-format=sarif option for future SARIF output

abrahamcd added inline comments. Comment at: clang/include/clang/Basic/DiagnosticDriverKinds.td:684 + "diagnostic formatting in SARIF mode is currently unstable">, + InGroup>; } Please let me know if there's a better warning group you think this should be in.

[PATCH] D129886: [clang] Add -fdiagnostics-format=sarif option for future SARIF output

abrahamcd updated this revision to Diff 445845. abrahamcd marked 5 inline comments as done. abrahamcd edited the summary of this revision. abrahamcd added a comment. Update test file to check for warning and address other minor comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST A

[PATCH] D129886: [clang] Add -fdiagnostics-format=sarif option for future SARIF output

abrahamcd updated this revision to Diff 445904. abrahamcd marked 2 inline comments as done. abrahamcd added a comment. Herald added a reviewer: jdoerfert. Herald added subscribers: abrachet, sstefan1, phosek, ormris. Enabled both "sarif" and "SARIF" as flag spellings. Repository: rG LLVM Githu

[PATCH] D129886: [clang] Add -fdiagnostics-format=sarif option for future SARIF output

abrahamcd added inline comments. Comment at: clang/lib/Driver/ToolChains/Clang.cpp:4009-4011 +if (StringRef(A->getValue()) == "sarif") { + D.Diag(diag::warn_drv_sarif_format_unstable); +} cjdb wrote: > aaron.ballman wrote: > > Do we want to be kind t

[PATCH] D129886: [clang] Add -fdiagnostics-format=sarif option for future SARIF output

abrahamcd updated this revision to Diff 445917. abrahamcd marked an inline comment as done. abrahamcd added a comment. Removed unintended formatting. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129886/new/ https://reviews.llvm.org/D129886 Files:

[PATCH] D129886: [clang] Add -fdiagnostics-format=sarif option for future SARIF output

abrahamcd added inline comments. Comment at: clang/lib/Driver/ToolChains/Clang.cpp:80-81 Args.getLastArg(options::OPT_dynamic, options::OPT_mdynamic_no_pic)) - D.Diag(diag::err_drv_argument_not_allowed_with) << A->getAsString(Args) -

[PATCH] D131632: [clang] Enable output of SARIF diagnostics

abrahamcd updated this revision to Diff 452833. abrahamcd retitled this revision from "[WIP] Enable SARIF Diagnostics" to "[clang] Enable output of SARIF diagnostics". abrahamcd edited the summary of this revision. abrahamcd added a comment. Removed unused remaining parts of traditional text diag

[PATCH] D131632: [clang] Enable output of SARIF diagnostics

abrahamcd updated this revision to Diff 452840. abrahamcd added a comment. Minor cleanup. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131632/new/ https://reviews.llvm.org/D131632 Files: clang/include/clang/Frontend/SARIFDiagnostic.h clang/in

[PATCH] D131632: [clang] Enable output of SARIF diagnostics

abrahamcd updated this revision to Diff 452843. abrahamcd added a comment. Naming fixes. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131632/new/ https://reviews.llvm.org/D131632 Files: clang/include/clang/Frontend/SARIFDiagnostic.h clang/inc

[PATCH] D131632: [clang] Enable output of SARIF diagnostics

abrahamcd added inline comments. Comment at: clang/lib/Frontend/SARIFDiagnostic.cpp:75 +emitFilename(FE->getName(), Loc.getManager()); +// FIXME: No current way to add file-only location to SARIF object + } @vaibhav.y , just wanted to con

[PATCH] D131632: [clang] Enable output of SARIF diagnostics

abrahamcd updated this revision to Diff 453126. abrahamcd added a comment. Fixed FileCheck test case and added multiple source range error. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131632/new/ https://reviews.llvm.org/D131632 Files: clang/i

[PATCH] D128372: [Clang-Tidy] Empty Check

abrahamcd marked 2 inline comments as done. abrahamcd added a comment. Hi, checking in on this again, thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128372/new/ https://reviews.llvm.org/D128372 __

[PATCH] D131632: [clang] Enable output of SARIF diagnostics

abrahamcd updated this revision to Diff 453346. abrahamcd added a comment. Removed Clang name from FileCheck test. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131632/new/ https://reviews.llvm.org/D131632 Files: clang/include/clang/Frontend/SAR

[PATCH] D131632: [clang] Enable output of SARIF diagnostics

abrahamcd updated this revision to Diff 453788. abrahamcd added a comment. Commented out unfinished test case Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131632/new/ https://reviews.llvm.org/D131632 Files: clang/include/clang/Frontend/SARIFDia

[PATCH] D131632: [clang] Enable output of SARIF diagnostics

abrahamcd added a comment. In D131632#3733068 , @aaron.ballman wrote: > Precommit CI found a relevant failure. I think this was just from the unfinished unit test. I can go ahead and remove `clang/unittests/Frontend/SARIFDiagnosticTest.cpp` entirely if

[PATCH] D131632: [clang] Enable output of SARIF diagnostics

abrahamcd updated this revision to Diff 454113. abrahamcd marked 2 inline comments as done. abrahamcd added a comment. Added diagnostic level and default configuration to SARIF output. Removed unit test file. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm

[PATCH] D131632: [clang] Enable output of SARIF diagnostics

abrahamcd updated this revision to Diff 454129. abrahamcd edited the summary of this revision. abrahamcd added a comment. Addressed review style comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131632/new/ https://reviews.llvm.org/D131632 F

[PATCH] D128372: [Clang-Tidy] Empty Check

abrahamcd updated this revision to Diff 454635. abrahamcd marked 2 inline comments as done. abrahamcd added a comment. Formatting fixes and synchronization of documentation. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128372/new/ https://reviews.

[PATCH] D131632: [clang] Enable output of SARIF diagnostics

abrahamcd updated this revision to Diff 454652. abrahamcd marked 26 inline comments as done. abrahamcd added a comment. Addressed review comments on formatting, style, C++ best practices. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131632/new/ ht

[PATCH] D131632: [clang] Enable output of SARIF diagnostics

abrahamcd added inline comments. Comment at: clang/include/clang/Frontend/SARIFDiagnosticPrinter.h:63-65 + void setSarifWriter(SarifDocumentWriter *SarifWriter) { +Writer = std::unique_ptr(SarifWriter); + } aaron.ballman wrote: > This interface seems danger

[PATCH] D131632: [clang] Enable output of SARIF diagnostics

abrahamcd updated this revision to Diff 454918. abrahamcd marked 4 inline comments as done. abrahamcd added a comment. Modified Printer's interface to use unique pointers when setting the SARIF writer. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D

[PATCH] D131632: [clang] Enable output of SARIF diagnostics

abrahamcd updated this revision to Diff 454926. abrahamcd added a comment. Documented issue with representing PresumedLocs modified by \#line directives. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131632/new/ https://reviews.llvm.org/D131632 Fi

[PATCH] D131632: [clang] Enable output of SARIF diagnostics

abrahamcd added inline comments. Comment at: clang/lib/Frontend/SARIFDiagnostic.cpp:116 + +Locations.push_back( +CharSourceRange{SourceRange{BeginLoc, EndLoc}, /* ITR = */ false}); I noticed that when processing additional source ranges, regular sourc

[PATCH] D131632: [clang] Enable output of SARIF diagnostics

abrahamcd updated this revision to Diff 454950. abrahamcd marked 2 inline comments as done. abrahamcd added a comment. Added use of std::make_unique. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131632/new/ https://reviews.llvm.org/D131632 Files:

[PATCH] D131632: [clang] Enable output of SARIF diagnostics

abrahamcd updated this revision to Diff 455005. abrahamcd added a comment. Removed use of pointer reset in Printer. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131632/new/ https://reviews.llvm.org/D131632 Files: clang/include/clang/Frontend/SA

[PATCH] D131632: [clang] Enable output of SARIF diagnostics

abrahamcd updated this revision to Diff 455394. abrahamcd marked 4 inline comments as done. abrahamcd added a comment. Deleted copy/move from renderer and returned OS to reference. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131632/new/ https://r

[PATCH] D131632: [clang] Enable output of SARIF diagnostics

abrahamcd updated this revision to Diff 455728. abrahamcd marked 15 inline comments as done. abrahamcd added a comment. Addressed some refactoring and reformatting comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131632/new/ https://reviews.

[PATCH] D131632: [clang] Enable output of SARIF diagnostics

abrahamcd added inline comments. Comment at: clang/include/clang/Frontend/SARIFDiagnostic.h:45-47 + void emitCodeContext(FullSourceLoc Loc, DiagnosticsEngine::Level Level, + SmallVectorImpl &Ranges, + ArrayRef Hints) override {} --

[PATCH] D131632: [clang] Enable output of SARIF diagnostics

abrahamcd updated this revision to Diff 455729. abrahamcd added a comment. Ran clang-format. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131632/new/ https://reviews.llvm.org/D131632 Files: clang/include/clang/Frontend/SARIFDiagnostic.h clang

[PATCH] D131632: [clang] Enable output of SARIF diagnostics

abrahamcd updated this revision to Diff 455955. abrahamcd marked 10 inline comments as done. abrahamcd added a comment. Resolved pending comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131632/new/ https://reviews.llvm.org/D131632 Files:

[PATCH] D131632: [clang] Enable output of SARIF diagnostics

abrahamcd added inline comments. Comment at: clang/lib/Frontend/SARIFDiagnostic.cpp:58 + + if (Loc.isValid()) +Result = addLocationToResult(Result, Loc, PLoc, Ranges, *Diag); denik wrote: > abrahamcd wrote: > > denik wrote: > > > I think we should add a test

[PATCH] D131632: [clang] Enable output of SARIF diagnostics

abrahamcd updated this revision to Diff 455964. abrahamcd added a comment. Deleted copy and move for Printer and added asserts. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131632/new/ https://reviews.llvm.org/D131632 Files: clang/include/clang

[PATCH] D131632: [clang] Enable output of SARIF diagnostics

abrahamcd updated this revision to Diff 455968. abrahamcd added a comment. Reset SARIFDiag during EndSourceFile(). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131632/new/ https://reviews.llvm.org/D131632 Files: clang/include/clang/Frontend/SAR

[PATCH] D128368: added clear check functionality

abrahamcd created this revision. Herald added a subscriber: carlosgalvezp. Herald added a project: All. abrahamcd requested review of this revision. Herald added a project: clang-tools-extra. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D1

[PATCH] D128372: Clang-Tidy Empty Check

abrahamcd created this revision. Herald added subscribers: carlosgalvezp, abrachet, phosek, mgorny. Herald added a project: All. abrahamcd requested review of this revision. Herald added a reviewer: jdoerfert. Herald added subscribers: cfe-commits, sstefan1. Herald added a project: clang-tools-extr

[PATCH] D128372: [Clang-Tidy] Empty Check

abrahamcd updated this revision to Diff 439938. abrahamcd marked 7 inline comments as done. abrahamcd retitled this revision from "Clang-Tidy Empty Check" to "[Clang-Tidy] Empty Check". abrahamcd added a comment. Herald added a subscriber: xazax.hun. Added functionality to check if member functio