[PATCH] D100056: [SystemZ][z/OS] Set files in FileRemapper.cpp are text

abhina.sreeskantharajan created this revision. abhina.sreeskantharajan requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This patch sets files in FileRemapper to open as text. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/

[PATCH] D93031: Enable fexec-charset option

abhina.sreeskantharajan updated this revision to Diff 336416. abhina.sreeskantharajan added a comment. Rebase + fix CharLiteralParser endian issue by saving the char to a char variable first and then creating a StringRef Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https:/

[PATCH] D93031: Enable fexec-charset option

abhina.sreeskantharajan updated this revision to Diff 336417. abhina.sreeskantharajan added a comment. Accidentally added dependent patch in this one. Removing that Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93031/new/ https://reviews.llvm.org/D

[PATCH] D100197: Enable creation of large response file on z/OS

abhina.sreeskantharajan accepted this revision. abhina.sreeskantharajan added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100197/new/ https://reviews.llvm.org/D100197 _

[PATCH] D100197: Enable creation of large response file on z/OS

This revision was automatically updated to reflect the committed changes. Closed by commit rG06c8b29d23ac: Enable creation of large response file on z/OS (authored by SeanP, committed by abhina.sreeskantharajan). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.l

[PATCH] D100488: [SystemZ][z/OS] Add IsText Argument to GetFile and GetFileOrSTDIN

abhina.sreeskantharajan accepted this revision. abhina.sreeskantharajan added a comment. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100488/new/ https://reviews.llvm.org/D100488 ___ cfe-commits ma

[PATCH] D100488: [SystemZ][z/OS] Add IsText Argument to GetFile and GetFileOrSTDIN

abhina.sreeskantharajan added a comment. In D100488#2692772 , @rnk wrote: > In D100488#2689494 , @amccarth > wrote: > >> Personally, I'm not a fan of boolean function parameters because of the >> inline comments

[PATCH] D100488: [SystemZ][z/OS] Add IsText Argument to GetFile and GetFileOrSTDIN

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGe71994a239d5: [SystemZ][z/OS] Add IsText Argument to GetFile and GetFileOrSTDIN (authored by Jonathan.Crowther, committed by abhina.sreeskantharajan

[PATCH] D100654: [SystemZ][z/OS] Set more text files as text

abhina.sreeskantharajan created this revision. Herald added subscribers: dexonsmith, arphaman. abhina.sreeskantharajan requested review of this revision. Herald added projects: clang, LLVM. Herald added subscribers: llvm-commits, cfe-commits. This patch corrects more instances of text files being

[PATCH] D100056: [SystemZ][z/OS] Set files in FileRemapper.cpp are text

abhina.sreeskantharajan updated this revision to Diff 338192. abhina.sreeskantharajan added a comment. fix formatting Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100056/new/ https://reviews.llvm.org/D100056 Files: clang/lib/ARCMigrate/FileRema

[PATCH] D100056: [SystemZ][z/OS] Set files in FileRemapper.cpp are text

This revision was automatically updated to reflect the committed changes. Closed by commit rGfbc325934661: [SystemZ][z/OS] Set files in FileRemapper.cpp are text (authored by abhina.sreeskantharajan). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100

[PATCH] D100654: [SystemZ][z/OS] Set more text files as text

This revision was automatically updated to reflect the committed changes. Closed by commit rG05b4babc9d85: [SystemZ][z/OS] Set more text files as text (authored by abhina.sreeskantharajan). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100654/new/ h

[PATCH] D93031: Enable fexec-charset option

abhina.sreeskantharajan updated this revision to Diff 338565. abhina.sreeskantharajan added a comment. Rebase + set size of char as 1 when creating a StringRef to fix lit failure Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93031/new/ https://revi

[PATCH] D100872: Use OpenFlags instead of boolean to set a file as text/binary

abhina.sreeskantharajan created this revision. abhina.sreeskantharajan requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This patch updates the functions createDefaultOutputFile, createOutputFile, createOutputFileImpl to use OpenFlags instea

[PATCH] D100872: Use OpenFlags instead of boolean to set a file as text/binary

abhina.sreeskantharajan added inline comments. Comment at: clang/include/clang/Frontend/CompilerInstance.h:738-740 + createOutputFileImpl(StringRef OutputPath, llvm::sys::fs::OpenFlags Flags, bool RemoveFileOnSignal, bool UseTemporary,

[PATCH] D93031: Enable fexec-charset option

abhina.sreeskantharajan updated this revision to Diff 339355. abhina.sreeskantharajan added a reviewer: ThePhD. abhina.sreeskantharajan added a comment. Thanks for catching that. This sets the __clang_literal_encoding__ to Opts.ExecCharset or defaults to SystemCharset. Repository: rG LLVM G

[PATCH] D93031: Enable fexec-charset option

abhina.sreeskantharajan updated this revision to Diff 313990. abhina.sreeskantharajan added a comment. Thanks for the review! I've addressed most of the comments but I still need to work on the translation issues in CharLiteralParser that was kindly pointed out by Tom and Richard. Here are the s

[PATCH] D93031: Enable fexec-charset option

abhina.sreeskantharajan marked 8 inline comments as done. abhina.sreeskantharajan added inline comments. Comment at: clang/include/clang/Lex/LiteralSupport.h:244 bool Pascal; + ConversionState TranslationState; + tahonermann wrote: > abhina.sreeskantharajan w

[PATCH] D93031: Enable fexec-charset option

abhina.sreeskantharajan marked an inline comment as done. abhina.sreeskantharajan added inline comments. Comment at: clang/lib/Lex/LiteralSupport.cpp:234 +SmallString<8> ResultCharConv; +Converter->convert(std::string(1, ByteChar), ResultCharConv); +memcpy((void *)&Re

[PATCH] D93031: Enable fexec-charset option

abhina.sreeskantharajan updated this revision to Diff 314115. abhina.sreeskantharajan added a comment. This patch replaces the memcpy in CharLiteralParser with an assignment. I've added an assertion for cases where the character size increases after translation. Repository: rG LLVM Github Mo

[PATCH] D93031: Enable fexec-charset option

abhina.sreeskantharajan marked 2 inline comments as done. abhina.sreeskantharajan added inline comments. Comment at: clang/lib/Lex/LiteralSupport.cpp:235 +Converter->convert(std::string(1, ByteChar), ResultCharConv); +memcpy((void *)&ResultChar, ResultCharConv.data(), siz

[PATCH] D93031: Enable fexec-charset option

abhina.sreeskantharajan added inline comments. Comment at: clang/lib/Lex/LiteralSupport.cpp:1593-1597 + ConversionState State = TranslationState; + if (Kind == tok::wide_string_literal) +State = TranslateToSystemCharset; + else if (isUTFLiteral(Kind)) +State = NoTransl

[PATCH] D94239: [SystemZ][z/OS] Fix No such file or directory expression error matching in lit tests

abhina.sreeskantharajan created this revision. abhina.sreeskantharajan added reviewers: Kai, fanbo-meng, muiez, zibi, hubert.reinterpretcast. Herald added subscribers: wenlei, rupprecht, steven_wu, gbedwell, hiraditya, emaste. Herald added a reviewer: JDevlieghere. Herald added a reviewer: espind

[PATCH] D94239: [SystemZ][z/OS] Fix No such file or directory expression error matching in lit tests

abhina.sreeskantharajan updated this revision to Diff 315182. abhina.sreeskantharajan added a comment. There was an extra ^M carriage return at the end of two lines in lld/test/COFF/pdb-type-server-invalid-signature.yaml CHECK lines. This update removes them. Repository: rG LLVM Github Monor

[PATCH] D94239: [SystemZ][z/OS] Fix No such file or directory expression error matching in lit tests

This revision was automatically updated to reflect the committed changes. Closed by commit rG689aaba7acf5: [SystemZ][z/OS] Fix No such file or directory expression error matching in lit… (authored by abhina.sreeskantharajan). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION http

[PATCH] D108819: [MCParser][z/OS] Mark test as unsupported for the z/OS Target

abhina.sreeskantharajan accepted this revision. abhina.sreeskantharajan added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108819/new/ https://reviews.llvm.org/D108819 _

[PATCH] D108998: [SystemZ][z/OS] Create html report file with text flag

abhina.sreeskantharajan accepted this revision. abhina.sreeskantharajan added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108998/new/ https://reviews.llvm.org/D108998 _

[PATCH] D109362: [SystemZ][z/OS] Add GOFF Support to the DataLayout

abhina.sreeskantharajan accepted this revision. abhina.sreeskantharajan added a comment. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109362/new/ https://reviews.llvm.org/D109362 ___ cfe-commits ma

<    1   2   3