[PATCH] D81422: Change filecheck default to dump input on failure

aartbik accepted this revision. aartbik added a comment. This revision is now accepted and ready to land. Yes, assuming nobody remembers an adverse side-effect, I think this change will help debugging future failures. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://re

[PATCH] D113043: "[mlir][sparse]Rename SparseUtils.cpp library to SparseTensorUtils.cpp"

aartbik added a comment. One last question, I just noticed you started a whole new revision (instead of updating https://reviews.llvm.org/D112995). Was that intentional? If you use arc, then arc diff first time creates one, but subsequent updates should use arc diff ... --update D to

[PATCH] D113043: [mlir][sparse] Rename SparseUtils.cpp file to SparseTensorUtils.cpp

aartbik accepted this revision. aartbik added a comment. This revision is now accepted and ready to land. I removed the quotes from the title, no need for these. Also, please address the last open question (on arc diff --update). But good to go as revision. I have approved the revision and will

[PATCH] D113043: [mlir][sparse] Rename SparseUtils.cpp file to SparseTensorUtils.cpp

This revision was automatically updated to reflect the committed changes. Closed by commit rG8a91bc7bf436: [mlir][sparse] Rename SparseUtils.cpp file to SparseTensorUtils.cpp (authored by HarrietAkot, committed by aartbik). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https:

[PATCH] D137338: Fix dupe word typos

aartbik added a comment. LGTM for sparse changes (note that you could have made your life a bit easier if you had broken this revision up at least over different projects, getting a global "LGTM" from somebody may be a bit hard now ;-) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST