r360628 - Removing an unused member variable; NFC.

2019-05-13 Thread Aaron Ballman via cfe-commits
Author: aaronballman Date: Mon May 13 15:29:16 2019 New Revision: 360628 URL: http://llvm.org/viewvc/llvm-project?rev=360628&view=rev Log: Removing an unused member variable; NFC. Modified: cfe/trunk/include/clang/AST/JSONNodeDumper.h Modified: cfe/trunk/include/clang/AST/JSONNodeDumper.h UR

r360667 - Add a new language mode for C2x; enable [[attribute]] support by default in C2x.

2019-05-14 Thread Aaron Ballman via cfe-commits
Author: aaronballman Date: Tue May 14 05:09:55 2019 New Revision: 360667 URL: http://llvm.org/viewvc/llvm-project?rev=360667&view=rev Log: Add a new language mode for C2x; enable [[attribute]] support by default in C2x. Modified: cfe/trunk/include/clang/Basic/LangOptions.def cfe/trunk/inc

r361172 - Dump macro expansion information as needed when outputting the AST to JSON.

2019-05-20 Thread Aaron Ballman via cfe-commits
Author: aaronballman Date: Mon May 20 09:46:44 2019 New Revision: 361172 URL: http://llvm.org/viewvc/llvm-project?rev=361172&view=rev Log: Dump macro expansion information as needed when outputting the AST to JSON. Added: cfe/trunk/test/AST/ast-dump-macro-json.c Modified: cfe/trunk/includ

r361265 - Add support for dumping AST comment nodes to JSON.

2019-05-21 Thread Aaron Ballman via cfe-commits
Author: aaronballman Date: Tue May 21 07:38:29 2019 New Revision: 361265 URL: http://llvm.org/viewvc/llvm-project?rev=361265&view=rev Log: Add support for dumping AST comment nodes to JSON. Added: cfe/trunk/test/AST/ast-dump-comment-json.cpp Modified: cfe/trunk/include/clang/AST/JSONNodeD

r361274 - Do not use the incorrect attribute spelling list index when translating a no_sanitize_foo attribute into a no_sanitize("foo") attribute.

2019-05-21 Thread Aaron Ballman via cfe-commits
Author: aaronballman Date: Tue May 21 10:24:49 2019 New Revision: 361274 URL: http://llvm.org/viewvc/llvm-project?rev=361274&view=rev Log: Do not use the incorrect attribute spelling list index when translating a no_sanitize_foo attribute into a no_sanitize("foo") attribute. This fixes a crash w

r361325 - Rename identifiers to spell out analyze; NFC.

2019-05-21 Thread Aaron Ballman via cfe-commits
Author: aaronballman Date: Tue May 21 15:43:48 2019 New Revision: 361325 URL: http://llvm.org/viewvc/llvm-project?rev=361325&view=rev Log: Rename identifiers to spell out analyze; NFC. Modified: cfe/trunk/test/SemaCXX/attr-no-sanitize-address.cpp cfe/trunk/test/SemaCXX/attr-no-sanitize-me

r361378 - Clang-formatting the header in advance of other planned changes; NFC.

2019-05-22 Thread Aaron Ballman via cfe-commits
Author: aaronballman Date: Wed May 22 06:01:28 2019 New Revision: 361378 URL: http://llvm.org/viewvc/llvm-project?rev=361378&view=rev Log: Clang-formatting the header in advance of other planned changes; NFC. Modified: cfe/trunk/utils/TableGen/TableGenBackends.h Modified: cfe/trunk/utils/Tab

r361652 - Add support for dumping Objective C AST declaration nodes to JSON.

2019-05-24 Thread Aaron Ballman via cfe-commits
Author: aaronballman Date: Fri May 24 10:39:55 2019 New Revision: 361652 URL: http://llvm.org/viewvc/llvm-project?rev=361652&view=rev Log: Add support for dumping Objective C AST declaration nodes to JSON. Added: cfe/trunk/test/AST/ast-dump-decl-json.m Modified: cfe/trunk/include/clang/AS

r361660 - Add JSON dumping tests for ObjC statements; add support for dumping @catch catch-all statements.

2019-05-24 Thread Aaron Ballman via cfe-commits
Author: aaronballman Date: Fri May 24 11:58:29 2019 New Revision: 361660 URL: http://llvm.org/viewvc/llvm-project?rev=361660&view=rev Log: Add JSON dumping tests for ObjC statements; add support for dumping @catch catch-all statements. Added: cfe/trunk/test/AST/ast-dump-stmt-json.m Modified:

r361662 - Adding an explicit triple to this test to appease build bots.

2019-05-24 Thread Aaron Ballman via cfe-commits
Author: aaronballman Date: Fri May 24 12:19:00 2019 New Revision: 361662 URL: http://llvm.org/viewvc/llvm-project?rev=361662&view=rev Log: Adding an explicit triple to this test to appease build bots. Modified: cfe/trunk/test/AST/ast-dump-stmt-json.m Modified: cfe/trunk/test/AST/ast-dump-stm

r361766 - When dumping the AST to JSON, dump the argument name to a sizeof pack expression.

2019-05-27 Thread Aaron Ballman via cfe-commits
Author: aaronballman Date: Mon May 27 07:17:32 2019 New Revision: 361766 URL: http://llvm.org/viewvc/llvm-project?rev=361766&view=rev Log: When dumping the AST to JSON, dump the argument name to a sizeof pack expression. Modified: cfe/trunk/include/clang/AST/JSONNodeDumper.h cfe/trunk/li

r361767 - When dumping the AST to JSON, dump the declared name of a MemberExpr operand.

2019-05-27 Thread Aaron Ballman via cfe-commits
Author: aaronballman Date: Mon May 27 07:25:04 2019 New Revision: 361767 URL: http://llvm.org/viewvc/llvm-project?rev=361767&view=rev Log: When dumping the AST to JSON, dump the declared name of a MemberExpr operand. Modified: cfe/trunk/lib/AST/JSONNodeDumper.cpp cfe/trunk/test/AST/ast-du

r361768 - When dumping the AST to JSON, dump whether a function is variadic or not.

2019-05-27 Thread Aaron Ballman via cfe-commits
Author: aaronballman Date: Mon May 27 07:29:10 2019 New Revision: 361768 URL: http://llvm.org/viewvc/llvm-project?rev=361768&view=rev Log: When dumping the AST to JSON, dump whether a function is variadic or not. Modified: cfe/trunk/lib/AST/JSONNodeDumper.cpp cfe/trunk/test/AST/ast-dump-e

r361769 - When dumping the AST to JSON, dump the type information from a typeid expression with a type operand.

2019-05-27 Thread Aaron Ballman via cfe-commits
Author: aaronballman Date: Mon May 27 07:34:31 2019 New Revision: 361769 URL: http://llvm.org/viewvc/llvm-project?rev=361769&view=rev Log: When dumping the AST to JSON, dump the type information from a typeid expression with a type operand. Modified: cfe/trunk/include/clang/AST/JSONNodeDumpe

r349082 - Update the scan-build to generate SARIF.

2018-12-13 Thread Aaron Ballman via cfe-commits
Author: aaronballman Date: Thu Dec 13 12:55:34 2018 New Revision: 349082 URL: http://llvm.org/viewvc/llvm-project?rev=349082&view=rev Log: Update the scan-build to generate SARIF. This updates the scan-build perl script to allow outputting to sarif in a more natural fashion by specifying -sarif

r349188 - Update our SARIF support from 10-10 to 11-28.

2018-12-14 Thread Aaron Ballman via cfe-commits
Author: aaronballman Date: Fri Dec 14 12:34:23 2018 New Revision: 349188 URL: http://llvm.org/viewvc/llvm-project?rev=349188&view=rev Log: Update our SARIF support from 10-10 to 11-28. Functional changes include: * The run.files property is now an array instead of a mapping. * fileLocation objec

r349197 - Using llvm::find_if() instead of a range-based for loop; NFC.

2018-12-14 Thread Aaron Ballman via cfe-commits
Author: aaronballman Date: Fri Dec 14 13:14:44 2018 New Revision: 349197 URL: http://llvm.org/viewvc/llvm-project?rev=349197&view=rev Log: Using llvm::find_if() instead of a range-based for loop; NFC. This addresses post-commit review feedback from r349188. Modified: cfe/trunk/lib/StaticAnal

r349497 - Emit -Wformat properly for bit-field promotions.

2018-12-18 Thread Aaron Ballman via cfe-commits
Author: aaronballman Date: Tue Dec 18 07:54:38 2018 New Revision: 349497 URL: http://llvm.org/viewvc/llvm-project?rev=349497&view=rev Log: Emit -Wformat properly for bit-field promotions. Only explicitly look through integer and floating-point promotion where the result type is actually a promot

r349547 - Fix errors with the Clang natvis file.

2018-12-18 Thread Aaron Ballman via cfe-commits
Author: aaronballman Date: Tue Dec 18 13:42:20 2018 New Revision: 349547 URL: http://llvm.org/viewvc/llvm-project?rev=349547&view=rev Log: Fix errors with the Clang natvis file. This updates the FunctionProtoType visualizer to use the proper bits for determining parameter information and the Dec

r349776 - Correct the diagnose_if attribute documentation. Fixes PR35845.

2018-12-20 Thread Aaron Ballman via cfe-commits
Author: aaronballman Date: Thu Dec 20 09:28:32 2018 New Revision: 349776 URL: http://llvm.org/viewvc/llvm-project?rev=349776&view=rev Log: Correct the diagnose_if attribute documentation. Fixes PR35845. Modified: cfe/trunk/include/clang/Basic/AttrDocs.td Modified: cfe/trunk/include/clang/Bas

r349815 - Fix build failures from r349812 due to a missing argument.

2018-12-20 Thread Aaron Ballman via cfe-commits
Author: aaronballman Date: Thu Dec 20 12:32:59 2018 New Revision: 349815 URL: http://llvm.org/viewvc/llvm-project?rev=349815&view=rev Log: Fix build failures from r349812 due to a missing argument. Modified: cfe/trunk/unittests/StaticAnalyzer/RegisterCustomCheckersTest.cpp Modified: cfe/trun

r349816 - Fix the example checker plugin after r349812.

2018-12-20 Thread Aaron Ballman via cfe-commits
Author: aaronballman Date: Thu Dec 20 12:35:01 2018 New Revision: 349816 URL: http://llvm.org/viewvc/llvm-project?rev=349816&view=rev Log: Fix the example checker plugin after r349812. Modified: cfe/trunk/examples/analyzer-plugin/MainCallChecker.cpp Modified: cfe/trunk/examples/analyzer-plug

r349940 - Switch from cast<> to dyn_cast<>.

2018-12-21 Thread Aaron Ballman via cfe-commits
Author: aaronballman Date: Fri Dec 21 11:16:38 2018 New Revision: 349940 URL: http://llvm.org/viewvc/llvm-project?rev=349940&view=rev Log: Switch from cast<> to dyn_cast<>. This avoids a potential failed assertion that is happening on someone's out-of-tree build. Modified: cfe/trunk/utils/T

Re: [PATCH] D55792: Allow direct navigation to static analysis checker documentation through SARIF exports

2018-12-21 Thread Aaron Ballman via cfe-commits
On Fri, Dec 21, 2018 at 12:35 PM Phil Camp via Phabricator wrote: > > FlameTop added a comment. > > I'm afraid we are seeing a build failure here on our local Windows checking > MSVC build. Unfortunately I cannot find a public buildbot that uses the exact > configuration that causes the assertio

r349955 - Switch from static_cast<> to cast<>, update identifier for coding conventions; NFC.

2018-12-21 Thread Aaron Ballman via cfe-commits
Author: aaronballman Date: Fri Dec 21 13:11:36 2018 New Revision: 349955 URL: http://llvm.org/viewvc/llvm-project?rev=349955&view=rev Log: Switch from static_cast<> to cast<>, update identifier for coding conventions; NFC. Modified: cfe/trunk/lib/Sema/SemaStmt.cpp Modified: cfe/trunk/lib/Se

r350004 - Improving this fatal diagnostic to help checker developers figure out what's actually gone wrong when they hit it.

2018-12-22 Thread Aaron Ballman via cfe-commits
Author: aaronballman Date: Sat Dec 22 07:31:57 2018 New Revision: 350004 URL: http://llvm.org/viewvc/llvm-project?rev=350004&view=rev Log: Improving this fatal diagnostic to help checker developers figure out what's actually gone wrong when they hit it. Modified: cfe/trunk/utils/TableGen/Cla

r350317 - Diagnose an unused result from a call through a function pointer whose return type is marked [[nodiscard]].

2019-01-03 Thread Aaron Ballman via cfe-commits
Author: aaronballman Date: Thu Jan 3 06:24:31 2019 New Revision: 350317 URL: http://llvm.org/viewvc/llvm-project?rev=350317&view=rev Log: Diagnose an unused result from a call through a function pointer whose return type is marked [[nodiscard]]. When a function returns a type and that type was

r350404 - Refactor the way we handle diagnosing unused expression results.

2019-01-04 Thread Aaron Ballman via cfe-commits
Author: aaronballman Date: Fri Jan 4 08:58:14 2019 New Revision: 350404 URL: http://llvm.org/viewvc/llvm-project?rev=350404&view=rev Log: Refactor the way we handle diagnosing unused expression results. Rather than sprinkle calls to DiagnoseUnusedExprResult() around in places where we want diag

r350414 - Add two new pragmas for controlling software pipelining optimizations.

2019-01-04 Thread Aaron Ballman via cfe-commits
Author: aaronballman Date: Fri Jan 4 09:20:00 2019 New Revision: 350414 URL: http://llvm.org/viewvc/llvm-project?rev=350414&view=rev Log: Add two new pragmas for controlling software pipelining optimizations. This patch adds #pragma clang loop pipeline and #pragma clang loop pipeline_initiation

Re: r350404 - Refactor the way we handle diagnosing unused expression results.

2019-01-05 Thread Aaron Ballman via cfe-commits
;t too onerous for Chromium (or other projects)? ~Aaron > >> Code is here: >> https://cs.chromium.org/chromium/src/third_party/crashpad/crashpad/util/win/process_info.cc?q=crashpad/util/win/process_info.cc&sq=package:chromium&g=0&l=227 >> https://cs.chromium.or

Re: r350404 - Refactor the way we handle diagnosing unused expression results.

2019-01-06 Thread Aaron Ballman via cfe-commits
t too onerous for Chromium (or other >> projects)? > > > It wasn't a problem for us, no. The warning found a bug, we fixed the bug, > everyone's happy. Just thought I'd mention the diag looks strange; thanks for > the explanation (and the warning improvement) :-) I'm gla

r350756 - Removing an include that was not necessary; NFC.

2019-01-09 Thread Aaron Ballman via cfe-commits
Author: aaronballman Date: Wed Jan 9 12:15:10 2019 New Revision: 350756 URL: http://llvm.org/viewvc/llvm-project?rev=350756&view=rev Log: Removing an include that was not necessary; NFC. The include also had a using namespace llvm in it, so this adds qualifiers where needed as well. Modified:

r350817 - Correct the spelling of helpURI to helpUri.

2019-01-10 Thread Aaron Ballman via cfe-commits
Author: aaronballman Date: Thu Jan 10 05:19:48 2019 New Revision: 350817 URL: http://llvm.org/viewvc/llvm-project?rev=350817&view=rev Log: Correct the spelling of helpURI to helpUri. JSON is case sensitive and the SARIF spec uses the corrected spelling. Modified: cfe/trunk/lib/StaticAnalyzer

r350891 - Correct the source range returned from preprocessor callbacks.

2019-01-10 Thread Aaron Ballman via cfe-commits
Author: aaronballman Date: Thu Jan 10 13:22:13 2019 New Revision: 350891 URL: http://llvm.org/viewvc/llvm-project?rev=350891&view=rev Log: Correct the source range returned from preprocessor callbacks. This adjusts the source range passed in to the preprocessor callbacks to only include the cond

[clang-tools-extra] r350892 - Update clang-tools-extra for r350891 from Clang.

2019-01-10 Thread Aaron Ballman via cfe-commits
Author: aaronballman Date: Thu Jan 10 13:22:28 2019 New Revision: 350892 URL: http://llvm.org/viewvc/llvm-project?rev=350892&view=rev Log: Update clang-tools-extra for r350891 from Clang. Modified: clang-tools-extra/trunk/test/modularize/ProblemsInconsistent.modularize clang-tools-extra/t

Re: r350891 - Correct the source range returned from preprocessor callbacks.

2019-01-10 Thread Aaron Ballman via cfe-commits
^ Sorry about that -- fixed in r350912 ~Aaron > > On Thu, Jan 10, 2019 at 4:26 PM Aaron Ballman via cfe-commits > wrote: >> >> Author: aaronballman >> Date: Thu Jan 10 13:22:13 2019 >> New Revision: 350891 >> >> URL: http://llvm.org/viewvc/llvm-pr

r350912 - Add an explicit initializer to silence a -Wmissing-field-initializers diagnostic; NFC.

2019-01-10 Thread Aaron Ballman via cfe-commits
Author: aaronballman Date: Thu Jan 10 16:13:57 2019 New Revision: 350912 URL: http://llvm.org/viewvc/llvm-project?rev=350912&view=rev Log: Add an explicit initializer to silence a -Wmissing-field-initializers diagnostic; NFC. Modified: cfe/trunk/lib/Lex/PPExpressions.cpp Modified: cfe/trunk

r372323 - Remove an unsafe member variable that wasn't needed; NFC.

2019-09-19 Thread Aaron Ballman via cfe-commits
Author: aaronballman Date: Thu Sep 19 06:51:50 2019 New Revision: 372323 URL: http://llvm.org/viewvc/llvm-project?rev=372323&view=rev Log: Remove an unsafe member variable that wasn't needed; NFC. People use the AST dumping interface while debugging, so it's not safe to assume that a declaration

r372325 - Reverting r372323 because it broke color tests on Linux.

2019-09-19 Thread Aaron Ballman via cfe-commits
Author: aaronballman Date: Thu Sep 19 06:59:53 2019 New Revision: 372325 URL: http://llvm.org/viewvc/llvm-project?rev=372325&view=rev Log: Reverting r372323 because it broke color tests on Linux. http://lab.llvm.org:8011/builders/clang-x86_64-debian-fast/builds/17919 Modified: cfe/trunk/incl

r372334 - Revert r372325 - Reverting r372323 because it broke color tests on Linux.

2019-09-19 Thread Aaron Ballman via cfe-commits
Author: aaronballman Date: Thu Sep 19 08:10:51 2019 New Revision: 372334 URL: http://llvm.org/viewvc/llvm-project?rev=372334&view=rev Log: Revert r372325 - Reverting r372323 because it broke color tests on Linux. This corrects the testing issues. Modified: cfe/trunk/include/clang/AST/TextNod

r373213 - Correct function declarations; NFC.

2019-09-30 Thread Aaron Ballman via cfe-commits
Author: aaronballman Date: Mon Sep 30 07:43:52 2019 New Revision: 373213 URL: http://llvm.org/viewvc/llvm-project?rev=373213&view=rev Log: Correct function declarations; NFC. This header is included by C code so the functions need to have a prototype. Also, fix the function definitions so that t

[clang-tools-extra] r373489 - Add the misc-init-local-variables check.

2019-10-02 Thread Aaron Ballman via cfe-commits
Author: aaronballman Date: Wed Oct 2 10:18:57 2019 New Revision: 373489 URL: http://llvm.org/viewvc/llvm-project?rev=373489&view=rev Log: Add the misc-init-local-variables check. This checks finds all primitive type local variables (integers, doubles, pointers) that are declared without an init

r329904 - Allow [[maybe_unused]] on static data members; these are considered variables and the attribute should appertain to them.

2018-04-12 Thread Aaron Ballman via cfe-commits
Author: aaronballman Date: Thu Apr 12 05:21:41 2018 New Revision: 329904 URL: http://llvm.org/viewvc/llvm-project?rev=329904&view=rev Log: Allow [[maybe_unused]] on static data members; these are considered variables and the attribute should appertain to them. Patch by S. B. Tam. Modified:

r329924 - Correctly diagnose when a conversion function is declared with a type qualifier in the declaration specifiers rather than in the conversion type id. Fixes PR30595.

2018-04-12 Thread Aaron Ballman via cfe-commits
Author: aaronballman Date: Thu Apr 12 09:41:55 2018 New Revision: 329924 URL: http://llvm.org/viewvc/llvm-project?rev=329924&view=rev Log: Correctly diagnose when a conversion function is declared with a type qualifier in the declaration specifiers rather than in the conversion type id. Fixes PR

r329930 - Fix the try_acquire_capability attribute to behave like the other try-lock functions. Fixes PR32954.

2018-04-12 Thread Aaron Ballman via cfe-commits
Author: aaronballman Date: Thu Apr 12 10:53:21 2018 New Revision: 329930 URL: http://llvm.org/viewvc/llvm-project?rev=329930&view=rev Log: Fix the try_acquire_capability attribute to behave like the other try-lock functions. Fixes PR32954. Modified: cfe/trunk/lib/Analysis/ThreadSafety.cpp

r330159 - Defer adding keywords to the identifier table until after the language options have been loaded from the AST file.

2018-04-16 Thread Aaron Ballman via cfe-commits
Author: aaronballman Date: Mon Apr 16 14:07:08 2018 New Revision: 330159 URL: http://llvm.org/viewvc/llvm-project?rev=330159&view=rev Log: Defer adding keywords to the identifier table until after the language options have been loaded from the AST file. This fixes issues with "class" being repor

r330185 - Add checks for format specifiers used by __builtin_dump_struct and added a new specifier for null-terminated constant strings.

2018-04-17 Thread Aaron Ballman via cfe-commits
Author: aaronballman Date: Tue Apr 17 04:57:47 2018 New Revision: 330185 URL: http://llvm.org/viewvc/llvm-project?rev=330185&view=rev Log: Add checks for format specifiers used by __builtin_dump_struct and added a new specifier for null-terminated constant strings. Patch by Paul Semel. Modified

r330188 - Add modifiers for unsigned char and signed char field printing for __builtin_dump_struct.

2018-04-17 Thread Aaron Ballman via cfe-commits
Author: aaronballman Date: Tue Apr 17 07:00:06 2018 New Revision: 330188 URL: http://llvm.org/viewvc/llvm-project?rev=330188&view=rev Log: Add modifiers for unsigned char and signed char field printing for __builtin_dump_struct. Patch by Paul Semel. Modified: cfe/trunk/lib/CodeGen/CGBuiltin

r330759 - Improve -Warray-bounds to handle multiple array extents rather than only handling the top-most array extent.

2018-04-24 Thread Aaron Ballman via cfe-commits
Author: aaronballman Date: Tue Apr 24 12:21:04 2018 New Revision: 330759 URL: http://llvm.org/viewvc/llvm-project?rev=330759&view=rev Log: Improve -Warray-bounds to handle multiple array extents rather than only handling the top-most array extent. Patch by Bevin Hansson. Modified: cfe/trunk

Re: If I want to disable certain attributes, such as "swiftcall", is there any way to do it now?

2018-04-28 Thread Aaron Ballman via cfe-commits
On Fri, Apr 27, 2018 at 11:23 PM, 朴素 via cfe-commits wrote: >As the title says,thanks. You could build a custom clang with specific attributes removed, but there are no compiler flags that allow you to disable arbitrary attributes like swiftcall. ~Aaron __

Re: If I want to disable certain attributes, such as "swiftcall", isthere any way to do it now?

2018-05-02 Thread Aaron Ballman via cfe-commits
On Wed, May 2, 2018 at 4:59 AM, 朴素 <772847...@qq.com> wrote: > Thanks. > > If I remove some specific attributes, now I can think of the following > method.First of all, let me talk about my method. > > 1.Define target platforms that do not support attributes.such as def > TargetPower : TargetArch<[

Re: If I want to disable certain attributes, such as "swiftcall",isthere any way to do it now?

2018-05-03 Thread Aaron Ballman via cfe-commits
On Thu, May 3, 2018 at 1:25 AM, 朴素 <772847...@qq.com> wrote: > hi, Aaron > > The reason why i not use of TargetSpecificAttr is as follows.If I plan to > support a new platform, I don't want to let users use certain attributes > because of hardware or simply not want to. Yes, we can use > TargetSp

r331459 - Allow writing calling convention attributes on function types.

2018-05-03 Thread Aaron Ballman via cfe-commits
Author: aaronballman Date: Thu May 3 08:33:50 2018 New Revision: 331459 URL: http://llvm.org/viewvc/llvm-project?rev=331459&view=rev Log: Allow writing calling convention attributes on function types. Calling convention attributes notionally appertain to the function type -- they modify the man

r331598 - Disallow pointers to const in __sync_fetch_and_xxx.

2018-05-05 Thread Aaron Ballman via cfe-commits
Author: aaronballman Date: Sat May 5 10:38:42 2018 New Revision: 331598 URL: http://llvm.org/viewvc/llvm-project?rev=331598&view=rev Log: Disallow pointers to const in __sync_fetch_and_xxx. Diagnoses code like: void f(const int *ptr) { __sync_fetch_and_add(ptr, 1); } which matches the behavi

Re: If I want to disable certain attributes, such as"swiftcall", isthere any way to do it now?

2018-05-06 Thread Aaron Ballman via cfe-commits
On Sun, May 6, 2018 at 10:01 AM, 朴素 <772847...@qq.com> wrote: > hi, Aaron > >Can I ask you some questions?Is there such a demand for me in the > community? Does my code need to be submitted to the community? >Thanks. Generally speaking, the community will accept production-quality patches

Re: If I want to disable certain attributes, such as"swiftcall", isthereany way to do it now?

2018-05-07 Thread Aaron Ballman via cfe-commits
On Mon, May 7, 2018 at 5:48 AM, 朴素 <772847...@qq.com> wrote: > hi, Aaron > > > I may found a useful example. For example, I tested the alias attribute on > my own Apple laptop (Target: x86_64-apple-darwin17.5.0). First, I use > __has_attribute to test that the alias is usable or not. The test cod

r335841 - Fix the indentation in this documentation to remove a Sphinx warning; NFC.

2018-06-28 Thread Aaron Ballman via cfe-commits
Author: aaronballman Date: Thu Jun 28 05:00:16 2018 New Revision: 335841 URL: http://llvm.org/viewvc/llvm-project?rev=335841&view=rev Log: Fix the indentation in this documentation to remove a Sphinx warning; NFC. Modified: cfe/trunk/include/clang/Basic/AttrDocs.td Modified: cfe/trunk/includ

r335842 - Correct the code highlighting marker to be Objective-C rather than C++ which fixes a Sphinx build warning; NFC.

2018-06-28 Thread Aaron Ballman via cfe-commits
Author: aaronballman Date: Thu Jun 28 05:02:38 2018 New Revision: 335842 URL: http://llvm.org/viewvc/llvm-project?rev=335842&view=rev Log: Correct the code highlighting marker to be Objective-C rather than C++ which fixes a Sphinx build warning; NFC. Modified: cfe/trunk/docs/ClangFormatStyle

r335843 - The :option: syntax was generating Sphinx build warnings; switched to double backticks to silence the warning; NFC.

2018-06-28 Thread Aaron Ballman via cfe-commits
Author: aaronballman Date: Thu Jun 28 05:05:40 2018 New Revision: 335843 URL: http://llvm.org/viewvc/llvm-project?rev=335843&view=rev Log: The :option: syntax was generating Sphinx build warnings; switched to double backticks to silence the warning; NFC. Modified: cfe/trunk/docs/ReleaseNotes

r335896 - Set the line ending of clang.natvis to CRLF.

2018-06-28 Thread Aaron Ballman via cfe-commits
Author: aaronballman Date: Thu Jun 28 11:03:00 2018 New Revision: 335896 URL: http://llvm.org/viewvc/llvm-project?rev=335896&view=rev Log: Set the line ending of clang.natvis to CRLF. This corresponds to r335889, which does the same thing for llvm.natvis. Modified: cfe/trunk/utils/ClangVisua

Re: r336225 - Fix allocation of Nullability attribute.

2018-07-03 Thread Aaron Ballman via cfe-commits
On Tue, Jul 3, 2018 at 4:30 PM, Erich Keane via cfe-commits wrote: > Author: erichkeane > Date: Tue Jul 3 13:30:34 2018 > New Revision: 336225 > > URL: http://llvm.org/viewvc/llvm-project?rev=336225&view=rev > Log: > Fix allocation of Nullability attribute. > > Existing code always allocates for

[clang-tools-extra] r336301 - Add the cert-msc51-cpp and cert-msc32-c checks.

2018-07-04 Thread Aaron Ballman via cfe-commits
Author: aaronballman Date: Wed Jul 4 18:16:31 2018 New Revision: 336301 URL: http://llvm.org/viewvc/llvm-project?rev=336301&view=rev Log: Add the cert-msc51-cpp and cert-msc32-c checks. These checks flag use of random number generators with poor seeds that would possibly lead to degraded random

[clang-tools-extra] r336302 - Adding some documentation changes that were missed in r336301.

2018-07-04 Thread Aaron Ballman via cfe-commits
Author: aaronballman Date: Wed Jul 4 18:35:49 2018 New Revision: 336302 URL: http://llvm.org/viewvc/llvm-project?rev=336302&view=rev Log: Adding some documentation changes that were missed in r336301. Added: clang-tools-extra/trunk/docs/clang-tidy/checks/cert-msc51-cpp.rst Modified: clan

Re: r336225 - Fix allocation of Nullability attribute.

2018-07-05 Thread Aaron Ballman via cfe-commits
On Thu, Jul 5, 2018 at 8:54 AM, Keane, Erich wrote: > Unfortunately I'm not sure of a good way to validate this. The only way I > was able to even discover this was with manual instrumentation of D48788. > There is a future opportunity to better instrument the source to find these > things in

Re: r336658 - Fixing builtin __atomic_fetch_min declaration

2018-07-10 Thread Aaron Ballman via cfe-commits
On Tue, Jul 10, 2018 at 8:04 AM, Omer Paparo Bivas via cfe-commits wrote: > Author: opaparo > Date: Tue Jul 10 05:04:04 2018 > New Revision: 336658 > > URL: http://llvm.org/viewvc/llvm-project?rev=336658&view=rev > Log: > Fixing builtin __atomic_fetch_min declaration Can a test case also be commi

r337125 - Run thread safety tests with both lock and capability attributes; NFC to the analysis behavior.

2018-07-15 Thread Aaron Ballman via cfe-commits
Author: aaronballman Date: Sun Jul 15 05:08:52 2018 New Revision: 337125 URL: http://llvm.org/viewvc/llvm-project?rev=337125&view=rev Log: Run thread safety tests with both lock and capability attributes; NFC to the analysis behavior. Patch thanks to Aaron Puchert. Modified: cfe/trunk/test/

[clang] 522934d - Support GCC [[gnu::attributes]] in C2x mode

2020-06-01 Thread Aaron Ballman via cfe-commits
Author: Aaron Ballman Date: 2020-06-01T10:42:42-04:00 New Revision: 522934da1f0c78c1de1a80d4ba14204a11f5afa8 URL: https://github.com/llvm/llvm-project/commit/522934da1f0c78c1de1a80d4ba14204a11f5afa8 DIFF: https://github.com/llvm/llvm-project/commit/522934da1f0c78c1de1a80d4ba14204a11f5afa8.diff

[clang-tools-extra] 7dfff42 - Silencing some 'logical operation on address of string constant diagnostics; NFC

2020-07-19 Thread Aaron Ballman via cfe-commits
Author: Aaron Ballman Date: 2020-07-19T10:53:51-04:00 New Revision: 7dfff42f019583076c55993d30a63889613922dd URL: https://github.com/llvm/llvm-project/commit/7dfff42f019583076c55993d30a63889613922dd DIFF: https://github.com/llvm/llvm-project/commit/7dfff42f019583076c55993d30a63889613922dd.diff

[clang-tools-extra] b79ca34 - Revert 7dfff42f019583076c55993d30a63889613922dd as it broke non-Windows builds.

2020-07-19 Thread Aaron Ballman via cfe-commits
Author: Aaron Ballman Date: 2020-07-19T11:12:39-04:00 New Revision: b79ca34530e88c3a13a9c7afb1df42d7a622e3dd URL: https://github.com/llvm/llvm-project/commit/b79ca34530e88c3a13a9c7afb1df42d7a622e3dd DIFF: https://github.com/llvm/llvm-project/commit/b79ca34530e88c3a13a9c7afb1df42d7a622e3dd.diff

[clang-tools-extra] 9791416 - Silence a "logical operation on address of string constant" via CMake instead.

2020-07-19 Thread Aaron Ballman via cfe-commits
Author: Aaron Ballman Date: 2020-07-19T11:19:48-04:00 New Revision: 97914164f8454e745219566d58479b5762cccd51 URL: https://github.com/llvm/llvm-project/commit/97914164f8454e745219566d58479b5762cccd51 DIFF: https://github.com/llvm/llvm-project/commit/97914164f8454e745219566d58479b5762cccd51.diff

Re: [clang-tools-extra] 9791416 - Silence a "logical operation on address of string constant" via CMake instead.

2020-07-21 Thread Aaron Ballman via cfe-commits
make sense to disable it globally at that point, but I wouldn't be strongly opposed to silencing it globally if someone felt strongly. ~Aaron > > On Sun, Jul 19, 2020 at 8:20 AM Aaron Ballman via cfe-commits > wrote: > > > > > > Author

[clang-tools-extra] 3bbf3e0 - Replace comment by private method; NFC.

2020-07-26 Thread Aaron Ballman via cfe-commits
Author: Hannes Käufler Date: 2020-07-26T13:59:45-04:00 New Revision: 3bbf3e026d3c692966583075ae6d12c4575e9d72 URL: https://github.com/llvm/llvm-project/commit/3bbf3e026d3c692966583075ae6d12c4575e9d72 DIFF: https://github.com/llvm/llvm-project/commit/3bbf3e026d3c692966583075ae6d12c4575e9d72.diff

[clang] 2aa593b - Fix a typo in an assert message; NFC.

2020-04-06 Thread Aaron Ballman via cfe-commits
Author: BoYao Zhang Date: 2020-04-06T11:50:50-04:00 New Revision: 2aa593be5486a9c5d3092647f2576273f84f3159 URL: https://github.com/llvm/llvm-project/commit/2aa593be5486a9c5d3092647f2576273f84f3159 DIFF: https://github.com/llvm/llvm-project/commit/2aa593be5486a9c5d3092647f2576273f84f3159.diff L

[clang] 86b5eab - Allow parameter names to be elided in a function definition in C.

2020-04-07 Thread Aaron Ballman via cfe-commits
Author: Aaron Ballman Date: 2020-04-07T14:43:38-04:00 New Revision: 86b5eabfeab164dcb680f6690e7718e3d21ceeb5 URL: https://github.com/llvm/llvm-project/commit/86b5eabfeab164dcb680f6690e7718e3d21ceeb5 DIFF: https://github.com/llvm/llvm-project/commit/86b5eabfeab164dcb680f6690e7718e3d21ceeb5.diff

[clang-tools-extra] b2d8c89 - Remove false positive in AvoidNonConstGlobalVariables.

2020-04-15 Thread Aaron Ballman via cfe-commits
Author: Kim Viggedal Date: 2020-04-15T14:48:06-04:00 New Revision: b2d8c89ea48beb83e0392b1f00c9eafa33c09ca8 URL: https://github.com/llvm/llvm-project/commit/b2d8c89ea48beb83e0392b1f00c9eafa33c09ca8 DIFF: https://github.com/llvm/llvm-project/commit/b2d8c89ea48beb83e0392b1f00c9eafa33c09ca8.diff

[clang] d4cf4c6 - Fix some typos (unkown -> unknown); NFC

2020-07-02 Thread Aaron Ballman via cfe-commits
Author: Aaron Ballman Date: 2020-07-02T06:41:05-04:00 New Revision: d4cf4c66b5b75393fd68e3aee8ab6c788bb628e3 URL: https://github.com/llvm/llvm-project/commit/d4cf4c66b5b75393fd68e3aee8ab6c788bb628e3 DIFF: https://github.com/llvm/llvm-project/commit/d4cf4c66b5b75393fd68e3aee8ab6c788bb628e3.diff

[clang-tools-extra] dfa0db7 - Warn pointer captured in async block

2020-07-07 Thread Aaron Ballman via cfe-commits
Author: Ellis Hoag Date: 2020-07-07T13:31:14-04:00 New Revision: dfa0db79d0e37d5cf24a63d1e2b7ba5f40617574 URL: https://github.com/llvm/llvm-project/commit/dfa0db79d0e37d5cf24a63d1e2b7ba5f40617574 DIFF: https://github.com/llvm/llvm-project/commit/dfa0db79d0e37d5cf24a63d1e2b7ba5f40617574.diff LO

[clang-tools-extra] aef04d3 - Speculatively fix the sphinx build.

2020-07-07 Thread Aaron Ballman via cfe-commits
Author: Aaron Ballman Date: 2020-07-07T13:54:28-04:00 New Revision: aef04d3306bff492f69f50675f65c9c4eedfab57 URL: https://github.com/llvm/llvm-project/commit/aef04d3306bff492f69f50675f65c9c4eedfab57 DIFF: https://github.com/llvm/llvm-project/commit/aef04d3306bff492f69f50675f65c9c4eedfab57.diff

[clang] 006c49d - Change behavior with zero-sized static array extents

2020-07-10 Thread Aaron Ballman via cfe-commits
Author: Aaron Ballman Date: 2020-07-10T15:58:11-04:00 New Revision: 006c49d890da633d1ce502117fc2a49863cd65b7 URL: https://github.com/llvm/llvm-project/commit/006c49d890da633d1ce502117fc2a49863cd65b7 DIFF: https://github.com/llvm/llvm-project/commit/006c49d890da633d1ce502117fc2a49863cd65b7.diff

[clang] 8a93119 - Handle invalid types in the nullPointerConstant AST matcher

2020-06-23 Thread Aaron Ballman via cfe-commits
Author: Aaron Ballman Date: 2020-06-23T07:14:33-04:00 New Revision: 8a9311940a26372dab6706edfd07288667394cfe URL: https://github.com/llvm/llvm-project/commit/8a9311940a26372dab6706edfd07288667394cfe DIFF: https://github.com/llvm/llvm-project/commit/8a9311940a26372dab6706edfd07288667394cfe.diff

[clang-tools-extra] 95a3550 - Repair various issues with modernize-avoid-bind

2020-06-25 Thread Aaron Ballman via cfe-commits
Author: Jeff Trull Date: 2020-06-25T07:29:53-04:00 New Revision: 95a3550dc89a0d424d90e2c0ad30d9ecfa9422cf URL: https://github.com/llvm/llvm-project/commit/95a3550dc89a0d424d90e2c0ad30d9ecfa9422cf DIFF: https://github.com/llvm/llvm-project/commit/95a3550dc89a0d424d90e2c0ad30d9ecfa9422cf.diff LO

[clang] 3765799 - Fix a crash with [[clang::acquire_handle]] when written as a type

2020-06-25 Thread Aaron Ballman via cfe-commits
Author: Aaron Ballman Date: 2020-06-25T08:45:32-04:00 New Revision: 37657991d17a274b1ac9c6ee63697a0138eab317 URL: https://github.com/llvm/llvm-project/commit/37657991d17a274b1ac9c6ee63697a0138eab317 DIFF: https://github.com/llvm/llvm-project/commit/37657991d17a274b1ac9c6ee63697a0138eab317.diff

[clang] 38ca7b1 - Expose AtomicType in the libclang C API.

2020-04-16 Thread Aaron Ballman via cfe-commits
Author: Henry Jen Date: 2020-04-16T08:06:58-04:00 New Revision: 38ca7b11db2d22e0fdfbff3f19276f9796f747d3 URL: https://github.com/llvm/llvm-project/commit/38ca7b11db2d22e0fdfbff3f19276f9796f747d3 DIFF: https://github.com/llvm/llvm-project/commit/38ca7b11db2d22e0fdfbff3f19276f9796f747d3.diff LOG

[clang] 2ec5520 - Disallow [[nodiscard]] on a function pointer declaration.

2020-04-16 Thread Aaron Ballman via cfe-commits
Author: Aaron Ballman Date: 2020-04-16T09:28:49-04:00 New Revision: 2ec5520a54ef9b359c6154adf857ba690bc117f1 URL: https://github.com/llvm/llvm-project/commit/2ec5520a54ef9b359c6154adf857ba690bc117f1 DIFF: https://github.com/llvm/llvm-project/commit/2ec5520a54ef9b359c6154adf857ba690bc117f1.diff

[clang] 6a30894 - C++2a -> C++20 in some identifiers; NFC.

2020-04-21 Thread Aaron Ballman via cfe-commits
Author: Aaron Ballman Date: 2020-04-21T15:37:19-04:00 New Revision: 6a30894391ca671bab16c505eff30c7819bd8e8e URL: https://github.com/llvm/llvm-project/commit/6a30894391ca671bab16c505eff30c7819bd8e8e DIFF: https://github.com/llvm/llvm-project/commit/6a30894391ca671bab16c505eff30c7819bd8e8e.diff

[clang] 1b3f1f4 - Rename warning identifiers from cxx2a to cxx20; NFC.

2020-04-22 Thread Aaron Ballman via cfe-commits
Author: Aaron Ballman Date: 2020-04-22T14:31:13-04:00 New Revision: 1b3f1f443670f202a0490ccf9d1f7b28e949bfe7 URL: https://github.com/llvm/llvm-project/commit/1b3f1f443670f202a0490ccf9d1f7b28e949bfe7 DIFF: https://github.com/llvm/llvm-project/commit/1b3f1f443670f202a0490ccf9d1f7b28e949bfe7.diff

[clang] e00071d - Fixing typo (singed -> signed); NFC

2020-04-29 Thread Aaron Ballman via cfe-commits
Author: Aaron Ballman Date: 2020-04-29T10:33:21-04:00 New Revision: e00071db0854ae9030e3b80a1f82c7cd66d57930 URL: https://github.com/llvm/llvm-project/commit/e00071db0854ae9030e3b80a1f82c7cd66d57930 DIFF: https://github.com/llvm/llvm-project/commit/e00071db0854ae9030e3b80a1f82c7cd66d57930.diff

[clang-tools-extra] a441616 - Support member expressions in bugprone-bool-pointer-implicit-conversion.

2020-08-05 Thread Aaron Ballman via cfe-commits
Author: Alex Cameron Date: 2020-08-05T07:14:28-04:00 New Revision: a44161692ae879068d4086a7e568a348800ba01d URL: https://github.com/llvm/llvm-project/commit/a44161692ae879068d4086a7e568a348800ba01d DIFF: https://github.com/llvm/llvm-project/commit/a44161692ae879068d4086a7e568a348800ba01d.diff

[clang] 9936b96 - Support the standards-based dates for __has_c_attribute

2020-08-13 Thread Aaron Ballman via cfe-commits
Author: Aaron Ballman Date: 2020-08-13T08:47:40-04:00 New Revision: 9936b96d5333af4e6dff55025943366bb5f07272 URL: https://github.com/llvm/llvm-project/commit/9936b96d5333af4e6dff55025943366bb5f07272 DIFF: https://github.com/llvm/llvm-project/commit/9936b96d5333af4e6dff55025943366bb5f07272.diff

[clang-tools-extra] 3450533 - Add support for C++20 concepts and decltype to modernize-use-trailing-return-type.

2020-08-15 Thread Aaron Ballman via cfe-commits
Author: Bernhard Manfred Gruber Date: 2020-08-15T10:40:22-04:00 New Revision: 345053390ac17dd4a2e759de9e0e24c2605035db URL: https://github.com/llvm/llvm-project/commit/345053390ac17dd4a2e759de9e0e24c2605035db DIFF: https://github.com/llvm/llvm-project/commit/345053390ac17dd4a2e759de9e0e24c26050

Re: [PATCH] D24507: Add attribute for return values that shouldn't be cast to bool

2016-09-19 Thread Aaron Ballman via cfe-commits
aaron.ballman added a comment. In https://reviews.llvm.org/D24507#546241, @urusant wrote: > Thank you for the feedback. > > > The patch is missing Sema tests for the attribute (that it only applies to > > declarations you expect, accepts no args, etc). > > > There is one test case for that in te

Re: [PATCH] D22910: Add support for CXXOperatorCallExpr in Expr::HasSideEffects

2016-09-21 Thread Aaron Ballman via cfe-commits
aaron.ballman added a comment. The other thing this patch is missing are tests, btw. Comment at: lib/AST/Expr.cpp:2869 @@ +2868,3 @@ +// assignment operator is intended to have a side-effect and other overloaded +// operators are not. Otherwise fall through the logic of

Re: [PATCH] D24513: [AMDGPU] Expose flat work group size, register and wave control attributes

2016-09-21 Thread Aaron Ballman via cfe-commits
aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM, thank you! https://reviews.llvm.org/D24513 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-

Re: [PATCH] D24669: {Sema] Gcc compatibility of vector shift.

2016-09-21 Thread Aaron Ballman via cfe-commits
aaron.ballman added a comment. In clang 3.8, your test code already produces a diagnostic for me: http://coliru.stacked-crooked.com/a/752a4ea34123bdae Repository: rL LLVM https://reviews.llvm.org/D24669 ___ cfe-commits mailing list cfe-commits@l

r282148 - Fixing sphinx build due to diagnostic:

2016-09-22 Thread Aaron Ballman via cfe-commits
Author: aaronballman Date: Thu Sep 22 07:15:18 2016 New Revision: 282148 URL: http://llvm.org/viewvc/llvm-project?rev=282148&view=rev Log: Fixing sphinx build due to diagnostic: /opt/llvm/build.attributes.src/tools/clang/docs/CommandGuide/clang.rst:338: WARNING: unknown option: -flto=full Modif

Re: [PATCH] D22910: Add support for CXXOperatorCallExpr in Expr::HasSideEffects

2016-09-22 Thread Aaron Ballman via cfe-commits
aaron.ballman added a comment. In https://reviews.llvm.org/D22910#549611, @sylvestre.ledru wrote: > What about landing this version now (with test) and do the other operators in > the a second commit? thanks I don't see a whole lot of value in that, but I may be missing information -- is this

Re: r282148 - Fixing sphinx build due to diagnostic:

2016-09-22 Thread Aaron Ballman via cfe-commits
usage from the paragraph and leave the .. option:: directive in the title. That's another way I've solved this in the past. ~Aaron > > Thanks, > Teresa > > > On Thu, Sep 22, 2016 at 6:10 AM, Teresa Johnson > wrote: >> >> Thank you! >> Teresa >>

Re: r282148 - Fixing sphinx build due to diagnostic:

2016-09-22 Thread Aaron Ballman via cfe-commits
rting more errors. > Do you know if the pages at http://clang.llvm.org/docs/ will automatically be > refreshed once this is fixed? I believe they should, yes. ~Aaron > > Teresa > >> >> ~Aaron >> >> > >> > Thanks, >> > Teresa >> > &

Re: [PATCH] D24807: [Serialization] ArrayTypeTraitExpr: serialize sub-expression to avoid keeping it undefined

2016-09-22 Thread Aaron Ballman via cfe-commits
aaron.ballman added a comment. Serialization tests usually come from PCH, so you could probably look in test/PCH to get ideas on how to test this. https://reviews.llvm.org/D24807 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.

Re: [PATCH] D24862: Workaround ASTMatcher crashes. Added some more test cases.

2016-09-23 Thread Aaron Ballman via cfe-commits
aaron.ballman added a subscriber: aaron.ballman. aaron.ballman added reviewers: klimek, sbenza. aaron.ballman added a comment. Should this perhaps be fixed in the AST matchers rather than in the check itself? https://reviews.llvm.org/D24862 ___ cfe

<    1   2   3   4   5   6   7   8   9   10   >