Author: aaronballman
Date: Sat Mar 3 13:02:09 2018
New Revision: 326665
URL: http://llvm.org/viewvc/llvm-project?rev=326665&view=rev
Log:
Create a subject list for the `used` attribute rather than use custom checking
logic.
This changes the diagnostic wording somewhat, but otherwise intends no
Author: aaronballman
Date: Sun Mar 4 07:32:01 2018
New Revision: 326675
URL: http://llvm.org/viewvc/llvm-project?rev=326675&view=rev
Log:
Replace the custom handling for several attributes; NFC.
These attributes were only customized because of the need to check for
attribute mutual exclusion, b
Author: aaronballman
Date: Sun Mar 4 08:24:10 2018
New Revision: 326676
URL: http://llvm.org/viewvc/llvm-project?rev=326676&view=rev
Log:
Amend r326665 to print out the `used` attribute subjects in a different order.
Modified:
cfe/trunk/include/clang/Basic/Attr.td
cfe/trunk/test/Sema/att
a polish thing.)
>
> On Sat, Mar 3, 2018, 4:04 PM Aaron Ballman via cfe-commits
> wrote:
>>
>> Author: aaronballman
>> Date: Sat Mar 3 13:02:09 2018
>> New Revision: 326665
>>
>> URL: http://llvm.org/viewvc/llvm-project?rev=326665&view=rev
>>
Joel, can you investigate the issue?
~Aaron
On Wed, Mar 7, 2018 at 4:32 PM, Nico Weber via cfe-commits
wrote:
> (I had to revert this since it caused
> https://bugs.llvm.org/show_bug.cgi?id=36620)
>
> On Fri, Mar 2, 2018 at 2:03 PM, Joel E. Denny via cfe-commits
> wrote:
>>
>> Author: jdenny
>>
Author: aaronballman
Date: Mon Mar 12 06:09:13 2018
New Revision: 327264
URL: http://llvm.org/viewvc/llvm-project?rev=327264&view=rev
Log:
Update the supported C language standards in the user manual.
Remove mention of -std=c94 (it is spelled iso9899:1994, not c94) and add
mention of -std=c17 an
On Tue, Mar 13, 2018 at 4:50 PM, Gheorghe-Teodor Bercea via
cfe-commits wrote:
> Author: gbercea
> Date: Tue Mar 13 13:50:12 2018
> New Revision: 327447
>
> URL: http://llvm.org/viewvc/llvm-project?rev=327447&view=rev
> Log:
> Revert revision 327438.
Can you give some extra context as to why this
Author: aaronballman
Date: Sat Mar 17 14:08:40 2018
New Revision: 327781
URL: http://llvm.org/viewvc/llvm-project?rev=327781&view=rev
Log:
Implement DR2229, which prohibits unnamed bit-fields from having qualifiers in
C++.
Added:
cfe/trunk/test/CXX/drs/dr22xx.cpp
Modified:
cfe/trunk/incl
Author: aaronballman
Date: Thu May 31 06:57:09 2018
New Revision: 333653
URL: http://llvm.org/viewvc/llvm-project?rev=333653&view=rev
Log:
Add a new driver mode to dump compiler feature and extension options.
Add the ability to dump compiler option-related information to a JSON file via
the -com
On Fri, Jun 1, 2018 at 6:52 PM, Eric Fiselier via cfe-commits
wrote:
> Author: ericwf
> Date: Fri Jun 1 15:51:59 2018
> New Revision: 333802
>
> URL: http://llvm.org/viewvc/llvm-project?rev=333802&view=rev
> Log:
> Add Features.def to module map
Thank you! I didn't know I had missed that.
~Aaro
Author: aaronballman
Date: Tue Jun 5 05:14:47 2018
New Revision: 334013
URL: http://llvm.org/viewvc/llvm-project?rev=334013&view=rev
Log:
Silence a "truncation from double to float" diagnostic in MSVC; NFC.
Modified:
clang-tools-extra/trunk/unittests/clangd/QualityTests.cpp
Modified: clang-
On Wed, Jun 6, 2018 at 4:40 AM Jonas Toth via Phabricator
wrote:
>
> JonasToth added a comment.
>
> @shuaiwang I can commit it in 2 hours for you if you want, after my lecture.
That's sooner than my "I can commit next week." :-D
~Aaron
>
>
> Repository:
> rCTE Clang Tools Extra
>
> https://re
On Wed, Jun 6, 2018 at 11:24 PM Richard Trieu via cfe-commits
wrote:
>
> Author: rtrieu
> Date: Wed Jun 6 20:20:30 2018
> New Revision: 334160
>
> URL: http://llvm.org/viewvc/llvm-project?rev=334160&view=rev
> Log:
> Change return value of trivial visibility check.
>
> Previous, if no Decl's were
Author: aaronballman
Date: Wed Jun 13 07:41:42 2018
New Revision: 334604
URL: http://llvm.org/viewvc/llvm-project?rev=334604&view=rev
Log:
Add a new class to analyze whether an expression is mutated within a statement.
ExprMutationAnalyzer is a generally useful helper that can be used in differen
Author: aaronballman
Date: Wed Jun 13 08:02:34 2018
New Revision: 334606
URL: http://llvm.org/viewvc/llvm-project?rev=334606&view=rev
Log:
Reverting r334604 due to failing tests.
http://lab.llvm.org:8011/builders/llvm-clang-lld-x86_64-scei-ps4-ubuntu-fast/builds/31500
Removed:
clang-tools-ex
Author: aaronballman
Date: Tue Jun 19 07:36:04 2018
New Revision: 335048
URL: http://llvm.org/viewvc/llvm-project?rev=335048&view=rev
Log:
Implement semantic checking for __builtin_signbit.
r242675 changed the signature for the signbit builtin but did not introduce
proper semantic checking to en
Author: aaronballman
Date: Tue Jun 19 07:53:20 2018
New Revision: 335049
URL: http://llvm.org/viewvc/llvm-project?rev=335049&view=rev
Log:
Reverting due to line ending changes; will reapply after addressing that.
Modified:
cfe/trunk/lib/Sema/SemaChecking.cpp
cfe/trunk/test/Sema/builtins.c
Author: aaronballman
Date: Tue Jun 19 07:59:11 2018
New Revision: 335050
URL: http://llvm.org/viewvc/llvm-project?rev=335050&view=rev
Log:
Implement semantic checking for __builtin_signbit.
r242675 changed the signature for the signbit builtin but did not introduce
proper semantic checking to en
On Wed, Sep 7, 2016 at 2:37 PM Zachary Turner via cfe-commits
wrote:
>
> Author: zturner
> Date: Wed Sep 7 13:28:55 2016
> New Revision: 280840
>
> URL: http://llvm.org/viewvc/llvm-project?rev=280840&view=rev
> Log:
> Add a clang-tidy visual studio extension.
>
> For now this only adds the UI nec
On Wed, Oct 10, 2018 at 4:54 PM Zachary Turner wrote:
>
> Honestly I hadn’t thought about this ever since the patch. Out of curiosity,
> have you tried the clang power tools extension? I think it’s more actively
> maintained and at this point probably even is good enough that this one could
> j
On Wed, Oct 10, 2018 at 5:11 PM Zachary Turner wrote:
>
> Yea, that’s actually another reason I suggest trying the Clang Power Tools
> extension. It seems to have “won” in this area, and few people ever used the
> LLVM one to begin with.
Given that this isn't being updated and it may not work,
Author: aaronballman
Date: Thu Oct 11 05:57:29 2018
New Revision: 344244
URL: http://llvm.org/viewvc/llvm-project?rev=344244&view=rev
Log:
Revert r344241 as it broke multiple bots.
http://lab.llvm.org:8011/builders/clang-x86_64-debian-fast/builds/10814
http://lab.llvm.org:8011/builders/llvm-clang
On Thu, Oct 11, 2018 at 8:23 AM Umann Kristóf via Phabricator via
llvm-commits wrote:
>
> Szelethus added a comment.
>
> I'm afraid this may have broken many buildbots, I'm having issues building
> from scratch. Can you please take a look?
I've reverted in r344244.
~Aaron
__
Author: aaronballman
Date: Thu Oct 11 09:40:18 2018
New Revision: 344259
URL: http://llvm.org/viewvc/llvm-project?rev=344259&view=rev
Log:
Improve -Wshadow warnings with enumerators.
Addresses PR24718 by checking for enumerators that shadow other enumerators.
Catches issues like:
enum E1{e1};
v
Author: aaronballman
Date: Thu Oct 18 10:42:41 2018
New Revision: 344749
URL: http://llvm.org/viewvc/llvm-project?rev=344749&view=rev
Log:
Add language standard aliases for -std=c18, -std=gnu18, and -std=iso9899:2018.
As described in D40225, the C17 standard was balloted and approved in 2017, but
Author: aaronballman
Date: Thu Oct 18 10:47:18 2018
New Revision: 344750
URL: http://llvm.org/viewvc/llvm-project?rev=344750&view=rev
Log:
Add check-clang-python to the Clang tests directory in IDEs; NFC.
Modified:
cfe/trunk/bindings/python/tests/CMakeLists.txt
Modified: cfe/trunk/bindings/p
Author: aaronballman
Date: Mon Oct 22 06:05:53 2018
New Revision: 344898
URL: http://llvm.org/viewvc/llvm-project?rev=344898&view=rev
Log:
Silence the -Wshadow warning for enumerators shadowing a type.
Amends r344259 so that enumerators shadowing types are not diagnosed, as
shadowing under those
Author: aaronballman
Date: Tue Oct 23 12:44:51 2018
New Revision: 345073
URL: http://llvm.org/viewvc/llvm-project?rev=345073&view=rev
Log:
Change getRedeclContext() to support enumerations as another kind of
transparent context in C.
This change fixes PR15071 and ensures that enumerators redefin
Author: aaronballman
Date: Wed Oct 24 05:26:23 2018
New Revision: 345132
URL: http://llvm.org/viewvc/llvm-project?rev=345132&view=rev
Log:
Support accepting __gnu__ as a scoped attribute namespace that aliases to gnu.
This is useful in libstdc++ to avoid clashes with identifiers in the user's
na
Author: aaronballman
Date: Mon Oct 29 06:47:56 2018
New Revision: 345502
URL: http://llvm.org/viewvc/llvm-project?rev=345502&view=rev
Log:
Add the isStaticLocal() AST matcher for matching on local static variables.
Patch by Joe Ranieri.
Modified:
cfe/trunk/docs/LibASTMatchersReference.html
Author: aaronballman
Date: Tue Oct 30 11:55:38 2018
New Revision: 345628
URL: http://llvm.org/viewvc/llvm-project?rev=345628&view=rev
Log:
Add the ability to output static analysis results to SARIF.
This allows users to specify SARIF (https://github.com/oasis-tcs/sarif-spec) as
the output from t
Author: aaronballman
Date: Tue Oct 30 12:06:58 2018
New Revision: 345630
URL: http://llvm.org/viewvc/llvm-project?rev=345630&view=rev
Log:
Fixing some build bot failures from r345628; NFC intended.
Modified:
cfe/trunk/lib/StaticAnalyzer/Core/SarifDiagnostics.cpp
Modified: cfe/trunk/lib/Stati
Author: aaronballman
Date: Tue Oct 30 12:23:06 2018
New Revision: 345633
URL: http://llvm.org/viewvc/llvm-project?rev=345633&view=rev
Log:
Silencing a -Wunused-variable warning; NFC.
Modified:
cfe/trunk/lib/StaticAnalyzer/Core/SarifDiagnostics.cpp
Modified: cfe/trunk/lib/StaticAnalyzer/Core/
Author: aaronballman
Date: Tue Oct 30 12:49:17 2018
New Revision: 345635
URL: http://llvm.org/viewvc/llvm-project?rev=345635&view=rev
Log:
Speculatively attempt to fix a failing testbot.
A testbot (
http://green.lab.llvm.org/green/job/clang-stage1-cmake-RA-incremental/54690/)
was failing wi
Author: aaronballman
Date: Tue Oct 30 13:55:18 2018
New Revision: 345649
URL: http://llvm.org/viewvc/llvm-project?rev=345649&view=rev
Log:
Changing the command line parameters sent to diff for this test.
On some systems, -U 1 was being interpreted as -U -1. Trying -U1 to see if
that's the univer
On Fri, Jan 11, 2019 at 7:46 PM Stephen Kelly via cfe-commits
wrote:
>
> Author: steveire
> Date: Fri Jan 11 16:42:59 2019
> New Revision: 350984
>
> URL: http://llvm.org/viewvc/llvm-project?rev=350984&view=rev
> Log:
> NFC: Port loop to cxx_range_for
Thanks for the cleanup!
>
> Modified:
>
On Sat, Jan 12, 2019 at 11:39 AM Stephen Kelly via cfe-commits
wrote:
>
> Author: steveire
> Date: Sat Jan 12 08:35:37 2019
> New Revision: 351012
>
> URL: http://llvm.org/viewvc/llvm-project?rev=351012&view=rev
> Log:
> Implement TemplateArgument dumping in terms of Visitor
>
> Summary: Split the
On Tue, Jan 15, 2019 at 4:33 AM Stephen Kelly via cfe-commits
wrote:
>
> Author: steveire
> Date: Tue Jan 15 01:30:00 2019
> New Revision: 351172
>
> URL: http://llvm.org/viewvc/llvm-project?rev=351172&view=rev
> Log:
> [ASTDump] NFC: Move dump of type nodes to NodeDumper
>
> Reviewers: aaron.ball
On Tue, Jan 15, 2019 at 4:39 AM Stephen Kelly via cfe-commits
wrote:
>
> Author: steveire
> Date: Tue Jan 15 01:35:52 2019
> New Revision: 351175
>
> URL: http://llvm.org/viewvc/llvm-project?rev=351175&view=rev
> Log:
> NFC: Move Decl node handling to TextNodeDumper
>
> Reviewers: aaron.ballman
>
On Tue, Jan 15, 2019 at 5:54 PM Stephen Kelly via cfe-commits
wrote:
>
> Author: steveire
> Date: Tue Jan 15 14:50:37 2019
> New Revision: 351269
>
> URL: http://llvm.org/viewvc/llvm-project?rev=351269&view=rev
> Log:
> Re-order overrides in FunctionDecl dump
>
> Output all content which is local
On Wed, Jan 16, 2019 at 1:57 AM Akira Hatanaka wrote:
>
> Yes, the behavior of the compiler doesn’t match what’s explained in the
> documentation anymore.
>
> Please take a look at the attached patch, which updates the documentation.
Patch mostly LGTM, but I did have one wording suggestion.
> d
Author: aaronballman
Date: Wed Jan 16 07:40:23 2019
New Revision: 351350
URL: http://llvm.org/viewvc/llvm-project?rev=351350&view=rev
Log:
Added a test case for dumping blocks that capture 'this'; NFC.
Modified:
cfe/trunk/test/AST/ast-dump-decl.mm
Modified: cfe/trunk/test/AST/ast-dump-decl.m
Author: aaronballman
Date: Wed Jan 16 08:12:30 2019
New Revision: 351355
URL: http://llvm.org/viewvc/llvm-project?rev=351355&view=rev
Log:
Added test cases for dumping variadic-like functions; NFC.
Modified:
cfe/trunk/test/AST/ast-dump-decl.c
cfe/trunk/test/AST/ast-dump-expr.cpp
cfe/t
Author: aaronballman
Date: Thu Jan 17 12:21:34 2019
New Revision: 351470
URL: http://llvm.org/viewvc/llvm-project?rev=351470&view=rev
Log:
Revert r351209 (which was a revert of r350891) with a fix.
The test case had a parse error that was causing the condition string to be
misreported. We now ha
Author: aaronballman
Date: Thu Jan 17 12:21:44 2019
New Revision: 351471
URL: http://llvm.org/viewvc/llvm-project?rev=351471&view=rev
Log:
Revert r351208 (which was a revert of r350892).
This corresponds to the fix to Clang in r351470.
Modified:
clang-tools-extra/trunk/test/modularize/Proble
On Tue, Jan 15, 2019 at 12:23 PM Benjamin Kramer via cfe-commits
wrote:
>
> Author: d0k
> Date: Tue Jan 15 09:20:05 2019
> New Revision: 351209
>
> URL: http://llvm.org/viewvc/llvm-project?rev=351209&view=rev
> Log:
> Revert "Correct the source range returned from preprocessor callbacks."
>
> This
On Thu, Jan 17, 2019 at 3:56 PM Reid Kleckner via cfe-commits
wrote:
>
> Author: rnk
> Date: Thu Jan 17 12:52:46 2019
> New Revision: 351478
>
> URL: http://llvm.org/viewvc/llvm-project?rev=351478&view=rev
> Log:
> Fix -Wsign-compare in new tests
Thank you for the warning fix -- I wasn't seeing t
Author: aaronballman
Date: Mon Jan 21 08:21:14 2019
New Revision: 351749
URL: http://llvm.org/viewvc/llvm-project?rev=351749&view=rev
Log:
Regenerating the C++ DR status page from the latest Core issues list.
Modified:
cfe/trunk/www/cxx_dr_status.html
Author: aaronballman
Date: Mon Jan 21 08:25:08 2019
New Revision: 351750
URL: http://llvm.org/viewvc/llvm-project?rev=351750&view=rev
Log:
Mark the lambda function pointer conversion operator as noexcept.
This implements CWG DR 1722 and fixes PR40309. Patch by Ignat Loskutov.
Added:
cfe/trun
Author: aaronballman
Date: Wed Jan 23 10:02:17 2019
New Revision: 351969
URL: http://llvm.org/viewvc/llvm-project?rev=351969&view=rev
Log:
Merge similar target diagnostics for interrupt attribute into one; NFC
Patch by Kristina Bessonova!
Modified:
cfe/trunk/include/clang/Basic/DiagnosticSem
On Wed, Jan 30, 2019 at 10:41 AM Roman Lebedev via cfe-commits
wrote:
>
> Author: lebedevri
> Date: Wed Jan 30 07:41:20 2019
> New Revision: 352631
>
> URL: http://llvm.org/viewvc/llvm-project?rev=352631&view=rev
> Log:
> [ASTDumper][OpenMP] CapturedDecl has a 'nothrow' bit
>
> Summary:
> Was tryi
On Wed, Jan 30, 2019 at 10:49 AM Roman Lebedev wrote:
>
> On Wed, Jan 30, 2019 at 6:46 PM Aaron Ballman wrote:
> >
> > On Wed, Jan 30, 2019 at 10:41 AM Roman Lebedev via cfe-commits
> > wrote:
> > >
> > > Author: lebedevri
> > > Date: Wed Jan 30 07:41:20 2019
> > > New Revision: 352631
> > >
> >
Author: aaronballman
Date: Wed Oct 31 12:11:38 2018
New Revision: 345764
URL: http://llvm.org/viewvc/llvm-project?rev=345764&view=rev
Log:
Implement the readability-const-return-type check.
This check flags function top-level const-qualified return types and suggests
removing the mostly-superflu
Author: aaronballman
Date: Wed Oct 31 12:17:44 2018
New Revision: 345766
URL: http://llvm.org/viewvc/llvm-project?rev=345766&view=rev
Log:
Removing a reliance on system headers from this test; NFC.
Modified:
clang-tools-extra/trunk/test/clang-tidy/readability-const-return-type.cpp
Modified:
Author: aaronballman
Date: Thu Nov 1 04:52:07 2018
New Revision: 345823
URL: http://llvm.org/viewvc/llvm-project?rev=345823&view=rev
Log:
Update to the 10-10 SARIF spec.
This removes the Step property (which can be calculated by consumers
trivially), and updates the schema and version numbers a
Author: aaronballman
Date: Thu Nov 1 11:57:38 2018
New Revision: 345874
URL: http://llvm.org/viewvc/llvm-project?rev=345874&view=rev
Log:
Output "rule" information in SARIF exports.
SARIF allows you to export descriptions about rules that are present in the
SARIF log. Expose the help text table
On Fri, Nov 2, 2018 at 12:34 PM Kristof Umann via cfe-commits
wrote:
>
> Author: szelethus
> Date: Fri Nov 2 09:32:15 2018
> New Revision: 345993
>
> URL: http://llvm.org/viewvc/llvm-project?rev=345993&view=rev
> Log:
> Didn't -> didnt, because #errors complains about untermianted '
Why not quot
Author: aaronballman
Date: Fri Nov 2 14:04:44 2018
New Revision: 346041
URL: http://llvm.org/viewvc/llvm-project?rev=346041&view=rev
Log:
Diagnose parameter names that shadow the names of inherited fields under
-Wshadow-field.
This addresses PR34120. Note, unlike GCC, we take into account the
Author: aaronballman
Date: Tue Nov 6 13:12:44 2018
New Revision: 346266
URL: http://llvm.org/viewvc/llvm-project?rev=346266&view=rev
Log:
Don't use std::next() on an input iterator; NFC.
Instead, advance the old-fashioned way, as std::next() cannot be used on an
input iterator until C++17.
Mod
Author: aaronballman
Date: Fri Nov 9 09:19:45 2018
New Revision: 346521
URL: http://llvm.org/viewvc/llvm-project?rev=346521&view=rev
Log:
Introduce the _Clang scoped attribute token.
Currently, we only accept clang as the scoped attribute identifier for double
square bracket attributes provided
Author: aaronballman
Date: Fri Nov 9 11:37:18 2018
New Revision: 346547
URL: http://llvm.org/viewvc/llvm-project?rev=346547&view=rev
Log:
Allow a double-underscore spelling of Clang attributes using double square
bracket syntax.
This matches a similar behavior with GCC accepting [[gnu::__attr__
gt; a condition?
I think an assertion would make the most sense. I can't devise a way
where there wouldn't be at least a root path and a file name, so
skipping over the root component should always be okay. I'll fix that
up.
~Aaron
>
> On Tue, Nov 6, 2018 at 1:14 PM Aaron Ballman via
Author: aaronballman
Date: Mon Nov 12 14:32:38 2018
New Revision: 346714
URL: http://llvm.org/viewvc/llvm-project?rev=346714&view=rev
Log:
Convert a condition into an assertion per post-review feedback; NFC intended.
Modified:
cfe/trunk/lib/StaticAnalyzer/Core/SarifDiagnostics.cpp
Modified:
>> > of a condition?
>>
>> I think an assertion would make the most sense. I can't devise a way
>> where there wouldn't be at least a root path and a file name, so
>> skipping over the root component should always be okay. I'll fix that
>>
Author: aaronballman
Date: Wed Nov 14 05:03:50 2018
New Revision: 346856
URL: http://llvm.org/viewvc/llvm-project?rev=346856&view=rev
Log:
Adding myself as the code owner for clang-query as discussed in
https://reviews.llvm.org/D54453.
Modified:
clang-tools-extra/trunk/CODE_OWNERS.TXT
Modif
Author: aaronballman
Date: Sun Nov 18 08:41:06 2018
New Revision: 347163
URL: http://llvm.org/viewvc/llvm-project?rev=347163&view=rev
Log:
Add the abseil-duration-factory-scale check.
This check removes unneeded scaling of arguments when calling Abseil Time
factory functions.
Patch by Hyrum Wri
Author: aaronballman
Date: Tue Nov 20 07:23:07 2018
New Revision: 347312
URL: http://llvm.org/viewvc/llvm-project?rev=347312&view=rev
Log:
Update the documentation for attribute feature tests.
This clarifies that __has_cpp_attribute is no longer always an extension since
it's now available in C+
On Sat, Nov 24, 2018 at 9:43 PM Alexander Kornienko via cfe-commits
wrote:
>
> Author: alexfh
> Date: Sat Nov 24 18:41:01 2018
> New Revision: 347520
>
> URL: http://llvm.org/viewvc/llvm-project?rev=347520&view=rev
> Log:
> A bit of AST matcher cleanup, NFC.
>
> Removed the uses of the allOf() mat
Clang currently supports various -cc1 options that allow displaying
AST information (-ast-dump, -ast-print, -ast-list, etc), but these
options are not convenient to consume by third-party tools. GrammaTech
has ongoing research efforts where we would like to output some
information from the AST to a
On Mon, Nov 26, 2018 at 2:27 PM Keane, Erich via cfe-commits
wrote:
>
> I'd be tentative to commit to any stability guarantees, particularly as the
> AST tends to change reasonably often.
Understood. This presupposes that there are stability guarantees to be
made surrounding the information prov
On Mon, Nov 26, 2018 at 3:13 PM Zola Bridges via cfe-commits
wrote:
>
> Author: zbrid
> Date: Mon Nov 26 12:11:18 2018
> New Revision: 347588
>
> URL: http://llvm.org/viewvc/llvm-project?rev=347588&view=rev
> Log:
> Revert "[clang][slh] add attribute for speculative load hardening"
>
> This revert
On Tue, Nov 27, 2018 at 4:50 AM Stephen Kelly via cfe-commits
wrote:
>
> On 26/11/2018 19:20, Aaron Ballman via cfe-commits wrote:
> > Once upon a time, there was -ast-print-xml. This -cc1 option was
> > dropped because it was frequently out of sync with the AST data. It is
>
Author: aaronballman
Date: Wed Nov 28 03:57:13 2018
New Revision: 347745
URL: http://llvm.org/viewvc/llvm-project?rev=347745&view=rev
Log:
Fix a false-positive with cert-err58-cpp.
If a variable is declared constexpr then its initializer needs to be a constant
expression, and thus, cannot throw.
Author: aaronballman
Date: Wed Nov 28 07:04:38 2018
New Revision: 347761
URL: http://llvm.org/viewvc/llvm-project?rev=347761&view=rev
Log:
Fix false positive with lambda assignments in cert-err58-cpp.
This check is about preventing exceptions from being thrown before main()
executes, and assigni
Author: aaronballman
Date: Thu Nov 29 04:45:50 2018
New Revision: 347860
URL: http://llvm.org/viewvc/llvm-project?rev=347860&view=rev
Log:
Adding a FIXME test to document an area for improvement with the cert-err58-cpp
check; NFC.
Modified:
clang-tools-extra/trunk/test/clang-tidy/cert-static
On Thu, Nov 29, 2018 at 2:34 PM Stephen Kelly via cfe-commits
wrote:
>
> Author: steveire
> Date: Thu Nov 29 11:31:32 2018
> New Revision: 347901
>
> URL: http://llvm.org/viewvc/llvm-project?rev=347901&view=rev
> Log:
> NFC: Fix case of CommentVisitor::Visit methods
>
> This difference is very vis
Author: aaronballman
Date: Fri Nov 30 06:43:21 2018
New Revision: 347994
URL: http://llvm.org/viewvc/llvm-project?rev=347994&view=rev
Log:
Adding tests for -ast-dump; NFC.
This adds tests for the majority of the functionality around FunctionDecl and
CXXMethodDecl.
Added:
cfe/trunk/test/Misc
Author: aaronballman
Date: Fri Nov 30 07:11:16 2018
New Revision: 347996
URL: http://llvm.org/viewvc/llvm-project?rev=347996&view=rev
Log:
Adding tests for -ast-dump; NFC.
This adds tests for DeclStmt and demonstrates that we don't create such an AST
node for global declarations currently.
Adde
Author: aaronballman
Date: Fri Nov 30 09:19:06 2018
New Revision: 348008
URL: http://llvm.org/viewvc/llvm-project?rev=348008&view=rev
Log:
Adding tests for -ast-dump; NFC.
This adds tests for GenericSelectionExpr; note that it points out a minor
whitespace bug for selection expression cases.
Mo
Author: aaronballman
Date: Fri Nov 30 10:52:51 2018
New Revision: 348020
URL: http://llvm.org/viewvc/llvm-project?rev=348020&view=rev
Log:
Reverting r347949-r347951 because they broke the test bots.
http://lab.llvm.org:8011/builders/clang-cmake-armv8-lld/builds/440/steps/ninja%20check%202/logs/FA
On Fri, Nov 30, 2018 at 9:37 AM Artem Dergachev via Phabricator via
cfe-commits wrote:
>
> NoQ added inline comments.
>
>
>
> Comment at: clang/test/Analysis/osobject-retain-release.cpp:27
> +
> + static void * operator new(unsigned long size);
> +
>
> NoQ wrote:
Author: aaronballman
Date: Fri Nov 30 11:15:07 2018
New Revision: 348023
URL: http://llvm.org/viewvc/llvm-project?rev=348023&view=rev
Log:
Updating this test, which changed after the reverts from r348020.
Modified:
cfe/trunk/test/Misc/pragma-attribute-supported-attributes-list.test
Modified:
On Fri, Nov 30, 2018 at 2:19 PM George Karpenkov wrote:
>
> Thanks and sorry about the trouble. I’ll recommit with size_t.
No worries, it happens! FYI, I also had to commit r348023 as part of
the reverts.
~Aaron
>
> On Nov 30, 2018, at 10:56 AM, Aaron Ballman wrote:
>
> On Fri, Nov 30, 2018 at
On Fri, Nov 30, 2018 at 2:26 PM George Karpenkov wrote:
>
> Thanks I’ll take a look.
>
> BTW when reverting could you use “git revert” or mention manually the
> phabricator revision being reverted,
> and apply reverts atomically?
> I (and many others) work exclusively using a git monorepo, so I d
Author: aaronballman
Date: Fri Nov 30 11:32:35 2018
New Revision: 348026
URL: http://llvm.org/viewvc/llvm-project?rev=348026&view=rev
Log:
Revert an inadvertent change from r348020.
Modified:
cfe/trunk/.gitignore
Modified: cfe/trunk/.gitignore
URL:
http://llvm.org/viewvc/llvm-project/cfe/tr
t in r348026 -- sorry for the churn there!
~Aaron
>
>
> Cheers
>
> Dave
>
> ____
> From: cfe-commits on behalf of Aaron
> Ballman via cfe-commits
> Sent: 30 November 2018 18:52:51
> To: cfe-commits@lists.llvm.org
> Subject: r348020
Author: aaronballman
Date: Fri Nov 30 12:55:26 2018
New Revision: 348033
URL: http://llvm.org/viewvc/llvm-project?rev=348033&view=rev
Log:
Adding tests for -ast-dump; NFC.
This adds tests for struct and union declarations in C. It also points out a
bug when dumping anonymous record types -- they
On Mon, Dec 3, 2018 at 6:29 AM Ilya Biryukov via cfe-commits
wrote:
>
> Author: ibiryukov
> Date: Mon Dec 3 03:26:35 2018
> New Revision: 348123
>
> URL: http://llvm.org/viewvc/llvm-project?rev=348123&view=rev
> Log:
> [clang] Do not read from 'test/SemaCXX/Inputs' inside 'test/AST'
>
> Our integ
Author: aaronballman
Date: Mon Dec 3 10:00:31 2018
New Revision: 348156
URL: http://llvm.org/viewvc/llvm-project?rev=348156&view=rev
Log:
Adding tests for -ast-dump; NFC.
This adds tests for struct and union declarations in C++.
Added:
cfe/trunk/test/AST/ast-dump-records.cpp
Added: cfe/tru
Author: aaronballman
Date: Mon Dec 3 13:27:15 2018
New Revision: 348192
URL: http://llvm.org/viewvc/llvm-project?rev=348192&view=rev
Log:
Typo correction; NFC.
Modified:
cfe/trunk/include/clang/AST/DeclCXX.h
Modified: cfe/trunk/include/clang/AST/DeclCXX.h
URL:
http://llvm.org/viewvc/llvm-p
Author: aaronballman
Date: Tue Dec 4 13:49:24 2018
New Revision: 348308
URL: http://llvm.org/viewvc/llvm-project?rev=348308&view=rev
Log:
Add tests for dumping base classes; NFC.
Modified:
cfe/trunk/test/AST/ast-dump-records.cpp
Modified: cfe/trunk/test/AST/ast-dump-records.cpp
URL:
http:/
Author: aaronballman
Date: Tue Dec 4 13:50:08 2018
New Revision: 348309
URL: http://llvm.org/viewvc/llvm-project?rev=348309&view=rev
Log:
Adding tests for -ast-dump; NFC.
This adds tests for the definition data of C++ record objects as well as
special member functions.
Added:
cfe/trunk/tes
On Tue, Dec 4, 2018 at 7:35 PM George Karpenkov wrote:
>
> Hi Roman,
>
> I’m against this new warning.
>
> A very common idiom is defining a “DEBUG” macro to be a no-op in release, and
> a logging function otherwise.
> The new introduced warning warns on all such cases (e.g. 'DEBUG(“mystring”);')
hen compiling a project,
> as the warning would be duplicated for every TU including the problematic
> header
> - A warning on declaration without a body is useful: nothing can collide
> there,
> and the actual definition might use a different name.
>
> George
>
On Wed, Dec 5, 2018 at 1:40 AM Roman Lebedev wrote:
>
> On Wed, Dec 5, 2018 at 4:07 AM Artem Dergachev via cfe-commits
> wrote:
> >
> >
> >
> > On 12/4/18 5:04 PM, George Karpenkov via cfe-dev wrote:
> > >
> > >> On Dec 4, 2018, at 4:47 PM, Aaron Ballman wrote:
> > >>
> > >> On Tue, Dec 4, 2018
ng the problematic
> >> header
> >> - A warning on declaration without a body is useful: nothing can collide
> >> there,
> >> and the actual definition might use a different name.
> >>
> >> George
> >>
> >>> On Nov 2, 201
Author: aaronballman
Date: Wed Dec 5 10:53:57 2018
New Revision: 348399
URL: http://llvm.org/viewvc/llvm-project?rev=348399&view=rev
Log:
Adding tests for -ast-dump; NFC.
This adds tests for various function and class template declarations.
Added:
cfe/trunk/test/AST/ast-dump-template-decls.
Author: aaronballman
Date: Wed Dec 5 10:56:57 2018
New Revision: 348400
URL: http://llvm.org/viewvc/llvm-project?rev=348400&view=rev
Log:
Do not check for parameters shadowing fields in function declarations.
We would issue a false-positive diagnostic for parameters in function
declarations sha
On Wed, Dec 5, 2018 at 2:14 PM Alex L via cfe-commits
wrote:
>
> We have about 100k unique occurrences of this warning across a slice of our
> software stack. It's simply not feasible to us to adopt it, so we would
> prefer for it to be reverted to avoid downstream divergence in Apple's clang.
On Wed, Dec 5, 2018 at 3:24 PM Stephen Kelly via cfe-commits
wrote:
>
> Author: steveire
> Date: Wed Dec 5 12:21:13 2018
> New Revision: 348408
>
> URL: http://llvm.org/viewvc/llvm-project?rev=348408&view=rev
> Log:
> Add dump tests for inherited default template parameters
>
> Modified:
> cf
101 - 200 of 7727 matches
Mail list logo
