[PATCH] D106215: Make wide multi-character character literals ill-formed in C++ mode

aaron.ballman added a comment. In D106215#2943631 , @cor3ntin wrote: > In D106215#2943611 , @aaron.ballman > wrote: > >> I think that C and C++ should behave the same here; at least, I don't see >> any reason wh

[PATCH] D104975: Implement P1949

aaron.ballman added inline comments. Comment at: clang/lib/Lex/Lexer.cpp:1444 +static const llvm::sys::UnicodeCharSet XIDContinueChars(XIDContinueRanges); +return C == '_' || XIDStartChars.contains(C) || + XIDContinueChars.contains(C); Is lookin

[PATCH] D106215: Make wide multi-character character literals ill-formed in C++ mode

aaron.ballman added a comment. In D106215#2943675 , @cor3ntin wrote: > In D106215#2943653 , @aaron.ballman > wrote: > >> In D106215#2943631 , @cor3ntin >> wrote: >> >>>

[PATCH] D108029: [clang][Codegen] Introduce the no_sanitizer_instrumentation attribute

aaron.ballman requested changes to this revision. aaron.ballman added inline comments. This revision now requires changes to proceed. Comment at: clang/include/clang/Basic/AttrDocs.td:2601-2602 + +This is not the same as ``__attribute__((no_sanitize(...)))``, which depending +on

[PATCH] D104975: Implement P1949

aaron.ballman added a subscriber: rsmith. aaron.ballman added inline comments. Comment at: clang/lib/Lex/Lexer.cpp:1444 +static const llvm::sys::UnicodeCharSet XIDContinueChars(XIDContinueRanges); +return C == '_' || XIDStartChars.contains(C) || + XIDContinueCha

[PATCH] D104975: Implement P1949

aaron.ballman added a reviewer: rsmith. aaron.ballman added a comment. Adding @rsmith to hopefully answer the question about how to handle the dr status page for these changes. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104975/new/ https://revi

[PATCH] D106577: [clang] Define __STDC_ISO_10646__

aaron.ballman added a comment. In D106577#2943837 , @jyknight wrote: > In D106577#2904960 , @rsmith wrote: > >>> One specific example I'd like to be considered: >>> Suppose the C standard library implementation's

[PATCH] D106215: Make wide multi-character character literals ill-formed in C++ mode

aaron.ballman added a comment. I'm okay with the changes, but I think we should call this out in the release notes as there's technically the potential for this to be a breaking change (in both C and C++). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.

[PATCH] D104975: Implement P1949

aaron.ballman added inline comments. Comment at: clang/www/cxx_dr_status.html:3 "http://www.w3.org/TR/html4/strict.dtd";> You might have missed this at the top of the file -- this one is a generated file, and that's why I was trying to figure out

[PATCH] D108029: [clang][Codegen] Introduce the no_sanitizer_instrumentation attribute

aaron.ballman added inline comments. Comment at: clang/include/clang/Basic/AttrDocs.td:2601-2602 + +This is not the same as ``__attribute__((no_sanitize(...)))``, which depending +on the tool may still insert instrumentation to prevent false positive reports. + }]; -

[PATCH] D106215: Make wide multi-character character literals ill-formed in C++ mode

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM, but going to wait a bit to land it in case @rsmith has opinions. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106215/new/ h

[PATCH] D107933: [clang] Expose unreachable fallthrough annotation warning

aaron.ballman added a comment. In D107933#2944135 , @nathanchance wrote: > In D107933#2942430 , @xbolva00 > wrote: > >> Yes, something like that, plus I think you want put >> UnreachableCodeFallthrough into gro

[PATCH] D108029: [clang][Codegen] Introduce the no_sanitizer_instrumentation attribute

aaron.ballman added inline comments. Comment at: clang/include/clang/Basic/AttrDocs.td:2601-2602 + +This is not the same as ``__attribute__((no_sanitize(...)))``, which depending +on the tool may still insert instrumentation to prevent false positive reports. + }]; -

[PATCH] D108029: [clang][Codegen] Introduce the disable_sanitizer_instrumentation attribute

aaron.ballman added inline comments. Comment at: clang/include/clang/Basic/Attr.td:2945 + let Spellings = [Clang<"disable_sanitizer_instrumentation">]; + let Subjects = SubjectList<[Function]>; + let Documentation = [DisableSanitizerInstrumentationDocs]; Do we

[PATCH] D108110: Fix LLVM_ENABLE_THREADS check from 26a92d5852b2c6bf77efd26f6c0194c913f40285

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM! > Since the other branch has never been used I wonder if we should just remove > it instead? I don't think removing the other branch entirely is a good approach because t

[PATCH] D104975: Implement P1949

aaron.ballman added inline comments. Comment at: clang/lib/Lex/Lexer.cpp:1622-1623 + + const bool isIDStart = isAllowedInitiallyIDChar(CodePoint, LangOpts); + const bool isIDContinue = isIDStart || isAllowedIDChar(CodePoint, LangOpts); + Com

[PATCH] D107873: [clang-tidy] Add 'performance-const-parameter-value-or-ref' for checking const-qualified parameters

aaron.ballman added a comment. It seems like there may be some considerable overlap between this check and the one proposed in https://reviews.llvm.org/D54943. I know the other check is more about C++ Core Guidelines so it's not perfect overlap. But I do wonder if it'd make sense to combine the

[PATCH] D107933: [clang] Expose unreachable fallthrough annotation warning

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM, I think this is incremental progress. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107933/new/ https://reviews.llvm.org/D10

[PATCH] D106030: [Clang] add support for error+warning fn attrs

aaron.ballman added inline comments. Comment at: clang/test/Sema/attr-error.c:31-32 + +__attribute__((error("foo"))) int bad5(void); // expected-error {{'error' and 'warning' attributes are not compatible}} +__attribute__((warning("foo"))) int bad5(void); // expected-note {{co

[PATCH] D106030: [Clang] add support for error+warning fn attrs

aaron.ballman added inline comments. Comment at: clang/test/Sema/attr-error.c:31-32 + +__attribute__((error("foo"))) int bad5(void); // expected-error {{'error' and 'warning' attributes are not compatible}} +__attribute__((warning("foo"))) int bad5(void); // expected-note {{co

[PATCH] D104285: [analyzer][AST] Retrieve value by direct index from list initialization of constant array declaration.

aaron.ballman added a comment. In D104285#2947255 , @ASDenysPetrov wrote: > In D104285#2943449 , @aaron.ballman > wrote: > >> One thing I think is worth asking in this thread is whether what you're >> analyzing

[PATCH] D104975: Implement P1949

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM aside from a commenting nit that I managed to miss last time (sorry about that). Btw, would you like to apply for commit privileges now that you've gotten a few patches unde

[PATCH] D106030: [Clang] add support for error+warning fn attrs

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. Clang parts LGTM, thank you for this! Comment at: clang/test/Sema/attr-error.c:31-32 + +__attribute__((error("foo"))) int bad5(void); // expected-error {{'err

[PATCH] D108029: [clang][Codegen] Introduce the disable_sanitizer_instrumentation attribute

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. Clang bits LGTM with a few minor documentation nits. Comment at: clang/include/clang/Basic/AttrDocs.td:2598-2599 + let Content = [{ +Use the ``disable_sanitize

[PATCH] D104285: [analyzer][AST] Retrieve value by direct index from list initialization of constant array declaration.

aaron.ballman added a comment. In D104285#2949273 , @ASDenysPetrov wrote: > @aaron.ballman > Ok, I got your concerns. Thanks for sticking with me! > As I can see we shall only reason about objects within the bounds. Otherwise, > we shall return `Undef

[PATCH] D104285: [analyzer][AST] Retrieve value by direct index from list initialization of constant array declaration.

aaron.ballman added a comment. In D104285#2949638 , @ASDenysPetrov wrote: > @aaron.ballman > Let me speak some thoughts. Consider next: > > int arr[2][5]; > int *ptr1 = &arr[0][0]; > int *ptr2 = &arr[1][0]; > > The Standard tells that `ptr1[5]` is

[PATCH] D108211: Emit sizeof/alignof values as notes when a static_assert fails

aaron.ballman added a reviewer: rsmith. aaron.ballman added inline comments. Comment at: clang/lib/Sema/SemaTemplate.cpp:3598 return true; +} else if (auto *UE = dyn_cast(E)) { + Expr::EvalResult Result; Comment at: clang/test/

[PATCH] D104975: Implement P1949

aaron.ballman closed this revision. aaron.ballman added a comment. Thank you for the patch, I've landed it on your behalf in 4e80636db71a1b6123d15ed1f9eda3979b4292de Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D104285: [analyzer][AST] Retrieve value by direct index from list initialization of constant array declaration.

aaron.ballman added a comment. In D104285#2951911 , @ASDenysPetrov wrote: > This is really significant obstructions. As what I see the only thing left > for us is to wait until the Standard transforms this //shenanigans// into > legal operations and be

[PATCH] D108296: Do not emit diagnostics for invalid unicode characters in preprocessing mode

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM! Comment at: clang/test/Lexer/unicode.c:3 // RUN: %clang_cc1 -fsyntax-only -verify -x c++ -std=c++11 %s +// RUN: %clang_cc1 -triple x86_64-scei-ps4 -E -DP

[PATCH] D108296: Do not emit diagnostics for invalid unicode characters in preprocessing mode

aaron.ballman closed this revision. aaron.ballman added a comment. I've landed this in 2715c4da50387ed6dae49a2a17fdcfad8a769a3c , thanks for the quick fix! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION ht

[PATCH] D108109: [CodeCompletion] Provide placeholders for known attribute arguments

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108109/new/ https://reviews.llvm.org/D108109

[PATCH] D108111: [CodeComplete] Only complete attributes that match the current LangOpts

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108111/new/ https://reviews.llvm.org/D108111

[PATCH] D108403: Fix assertion when generating diagnostic for inline namespaces

aaron.ballman created this revision. aaron.ballman added reviewers: erichkeane, rsmith, rjmccall, jyknight. aaron.ballman requested review of this revision. Herald added a project: clang. When calculating the name to display for inline namespaces, we have custom logic to try to hide redundant inl

[PATCH] D75041: [clang-tidy] Extend 'bugprone-easily-swappable-parameters' with mixability because of implicit conversions

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. In D75041#2799036 , @whisperity wrote: > In D75041#2799023 , @martong wrote: > >> Perhaps all con

[PATCH] D69560: [clang-tidy] Add 'bugprone-easily-swappable-parameters' check

aaron.ballman accepted this revision. aaron.ballman added a comment. This is a very involved check that I think is going to produce some interesting results for users, thank you for working so diligently on it! I think all of the patches in the series have now been accepted and this is ready to

[PATCH] D69560: [clang-tidy] Add 'bugprone-easily-swappable-parameters' check

aaron.ballman added a comment. In D69560#2840579 , @whisperity wrote: > In D69560#2840554 , @aaron.ballman > wrote: > >> This is a very involved check that I think is going to produce some >> interesting results f

[PATCH] D20689: [clang-tidy] Add 'readability-suspicious-call-argument' check

aaron.ballman added inline comments. Comment at: clang-tools-extra/clang-tidy/readability/SuspiciousCallArgumentCheck.cpp:185 +for (std::size_t J = 0; J < Param.size(); ++J) { + if (Arg[I] == Param[J]) { +if (I == 0 || J == 0) Should this be a c

[PATCH] D103380: [C++20] Support for lambdas in unevaluated context

aaron.ballman closed this revision. aaron.ballman added a comment. Thank you for the patch! I've committed in 22aa3680eaccb9b77ca224711c4da3a354aa2d45 . Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https

[PATCH] D105024: Add papers adopted by the C++ committee in the June 2021 plenary.

aaron.ballman added inline comments. Comment at: clang/www/cxx_status.html:1289 + https://wg21.link/P1938R3";>P1938R3 + NO + Same fix applies elsewhere Comment at: clang/www/cxx_status.html:1294 + https://wg21.link/P2156R1";>

[PATCH] D105024: Add papers adopted by the C++ committee in the June 2021 plenary.

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105024/new/ https://reviews.llvm.org/D105024

[PATCH] D105024: Add papers adopted by the C++ committee in the June 2021 plenary.

aaron.ballman closed this revision. aaron.ballman added a comment. I've commit on your behalf in 18c3c7784975700ae463bb461487d46e74324a66 , thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://rev

[PATCH] D105052: [clang][darwin] add support for Mac Catalyst availability

aaron.ballman added inline comments. Comment at: clang/include/clang/Basic/Attr.td:860 + .Case("maccatalyst", "macCatalyst") + .Case("maccatalyst_app_extension", "macCatalyst App Extension") .Case("swift", "Swift") Should thi

[PATCH] D105052: [clang][darwin] add support for Mac Catalyst availability

aaron.ballman added a comment. Btw, the CI failures look to be unrelated to the patch. (It's pretty unfortunate how often this is the case lately...) CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105052/new/ https://reviews.llvm.org/D105052

[PATCH] D20689: [clang-tidy] Add 'readability-suspicious-call-argument' check

aaron.ballman added a comment. I think this looks good to me. @alexfh, you had raised questions about this meeting the quality bar. I think those concerns are valid in the abstract (swapped argument checking requires heuristics), but I'd argue that most existing code bases that actually have sw

[PATCH] D104601: [Preprocessor] Implement -fnormalize-whitespace.

aaron.ballman added a comment. I'm still mulling over the feature, but I have some nits with the patch while I was exploring it. I share the concerns raised by @dblaikie and would add that it's very common for implementers to ask developers to run their code through `-E` mode to submit preproce

[PATCH] D105257: [clang][darwin] add support for remapping macOS availability to Mac Catalyst availability

aaron.ballman added inline comments. Comment at: clang/include/clang/Basic/DarwinSDKInfo.h:40 +llvm::Triple::EnvironmentType ToEnv) +: Value(((uint64_t(FromOS) * uint64_t(llvm::Triple::LastOSType) + + uint64_t(FromEnv)) ---

[PATCH] D103426: Clang: Extend format string checking to wprintf/wscanf

aaron.ballman added inline comments. Comment at: clang/lib/AST/OSLog.cpp:212 + } else if (Lit->isUTF16()) { +std::wstring_convert, char16_t> Convert; +std::u16string U16 = Lit->getStringAsChar16(); MarcusJohnson91 wrote: > aaron.ballman wrote: > > cor3nt

[PATCH] D105287: Fix an accepts-invalid issue with [[]] attributes in the type position in C

aaron.ballman created this revision. aaron.ballman added reviewers: erichkeane, rsmith. aaron.ballman requested review of this revision. Herald added a project: clang. A user reported an issue to me via email that Clang was accepting some code that GCC was rejecting. After investigation, it turne

[PATCH] D105287: Fix an accepts-invalid issue with [[]] attributes in the type position in C

aaron.ballman added a comment. > I guess I don't see how this patch 'works' here. I don't see anything > preventing the type-location in C, but not C++? See comments in the code, I left one where the interesting bit is. Comment at: clang/lib/Sema/SemaType.cpp:8091 + // A

[PATCH] D105287: Fix an accepts-invalid issue with [[]] attributes in the type position in C

aaron.ballman updated this revision to Diff 355893. aaron.ballman added a comment. Added a test that `overloadable` should fail when in the type position. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105287/new/ https://reviews.llvm.org/D105287 Files: clang/include/clang/Basic/Attri

[PATCH] D105287: Fix an accepts-invalid issue with [[]] attributes in the type position in C

aaron.ballman closed this revision. aaron.ballman added a comment. Thanks for the review, Erich! I've committed in bc7cc2074b7b7043e05cb46346f1368eb4ae9949 CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105287/new/ h

[PATCH] D99005: [clang] Implement P2266 Simpler implicit move

aaron.ballman added a comment. In D99005#2844365 , @mizvekov wrote: > But is this example a reduction from a real world code base? > The committee wants feedback and we are interested how hard you believe this > change affects you. This is an example tha

[PATCH] D99005: [clang] Implement P2266 Simpler implicit move

aaron.ballman added a comment. In D99005#2843201 , @mizvekov wrote: > Thank you again @sberg. > > I have talked to the MSVC STL maintainers. They would be open to a pull > request for fixing this. > The repo can be found at https://github.com/microsoft/ST

[PATCH] D99005: [clang] Implement P2266 Simpler implicit move

aaron.ballman added a comment. In D99005#2859886 , @mizvekov wrote: > In D99005#2859476 , @aaron.ballman > wrote: > >> https://godbolt.org/z/dvEbv7GKo >> >> I'm not certain if this is as expected of an issue, thoug

[PATCH] D105518: [clang] disable P2266 simpler implicit moves under -fms-compatibility

aaron.ballman added a reviewer: rsmith. aaron.ballman added a comment. Thank you for working on this! I applied the patch locally and confirmed that it solves the issue at hand. However, I'm not certain this is the right approach; what's the plan moving forward? This patch means that users of c

[PATCH] D99005: [clang] Implement P2266 Simpler implicit move

aaron.ballman added a comment. In D99005#2860494 , @mizvekov wrote: >> I'd prefer to keep existing code working without requiring users to enable a >> flag, if at all possible (esp because I don't expect the flag to be needed >> forever). That said, I st

[PATCH] D105518: [clang] disable P2266 simpler implicit moves under -fms-compatibility

aaron.ballman added a comment. In D105518#2861635 , @aaron.ballman wrote: > Thank you for working on this! I applied the patch locally and confirmed that > it solves the issue at hand. > > However, I'm not certain this is the right approach; what's the

[PATCH] D105451: [clang] Fix crash when there is an invalid declaration with flag -Wcast-align

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. Thank you for the fix, LGTM! Do you need help landing the change? If so, please let me know what name and email address you'd like me to use for patch attribution. CHANGES SINC

[PATCH] D105518: [clang] disable P2266 simpler implicit moves under -fms-compatibility

aaron.ballman added a comment. Ping? Normally I wouldn't bother people so quickly, but this patch is addressing a major regression on trunk that had a revert request. We either need to get this landed ASAP or revert the original commit. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D105451: [clang] Fix crash when there is an invalid declaration with flag -Wcast-align

aaron.ballman closed this revision. aaron.ballman added a comment. Thank you for the fix! I've applied in 3c5721d77275d2a7bdaeeadd0b1c3864f1166110 CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105451/new/ https://rev

[PATCH] D105479: [clang-tidy] [PR50069] readability-braces-around-statements doesn't work well with [[likely]] [[unlikely]]

aaron.ballman added a comment. Thank you for working on this! Comment at: clang-tools-extra/test/clang-tidy/checkers/readability-braces-around-statements-attributes.cpp:7-14 + if (b) [[likely]] { +// CHECK-FIXES-NOT: if (b) { {{[[][[]}}likely{{[]][]]}} { +return; + }

[PATCH] D105518: [clang] disable P2266 simpler implicit moves under -fms-compatibility

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM, thank you! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105518/new/ https://reviews.llvm.org/D105518 _

[PATCH] D69764: [clang-format] Add East/West Const fixer capability

aaron.ballman added a comment. In D69764#2863213 , @steveire wrote: > @MyDeveloperDay Does anything prevent this being merged, instead of just > rebased? Please see my comments from https://reviews.llvm.org/D69764#2533538. CHANGES SINCE LAST ACTION

[PATCH] D105479: [clang-tidy] [PR50069] readability-braces-around-statements doesn't work well with [[likely]] [[unlikely]]

aaron.ballman added a comment. In D105479#2863819 , @MyDeveloperDay wrote: > In D105479#2862819 , @aaron.ballman > wrote: > >> Thank you for working on this! > > So I looked into do what you suggested originally

[PATCH] D69764: [clang-format] Add East/West Const fixer capability

aaron.ballman added a comment. In D69764#2863312 , @steveire wrote: > In D69764#2863266 , @aaron.ballman > wrote: > >> In D69764#2863213 , @steveire wrote: >> >>> @MyDevelop

[PATCH] D105648: [OpenMP] Support OpenMP 5.1 attributes

aaron.ballman created this revision. aaron.ballman added reviewers: ABataev, jdoerfert, erichkeane, bader, rsmith. Herald added subscribers: dexonsmith, zzheng, guansong, yaxunl. aaron.ballman requested review of this revision. Herald added a subscriber: sstefan1. Herald added a project: clang. Op

[PATCH] D105648: [OpenMP] Support OpenMP 5.1 attributes

aaron.ballman marked 2 inline comments as done. aaron.ballman added inline comments. Comment at: clang/include/clang/Basic/TokenKinds.def:869 PRAGMA_ANNOTATION(pragma_openmp) +PRAGMA_ANNOTATION(pragma_openmp_from_attr) PRAGMA_ANNOTATION(pragma_openmp_end) erich

[PATCH] D105648: [OpenMP] Support OpenMP 5.1 attributes

aaron.ballman updated this revision to Diff 357327. aaron.ballman marked 8 inline comments as done. aaron.ballman added a comment. Addressing review feedback CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105648/new/ https://reviews.llvm.org/D105648 Files: clang/docs/OpenMPSupport.rst

[PATCH] D105648: [OpenMP] Support OpenMP 5.1 attributes

aaron.ballman added inline comments. Comment at: clang/lib/Parse/ParseDeclCXX.cpp:4473-4486 +void Parser::ParseCXX11Attributes(ParsedAttributesWithRange &Attrs, + SourceLocation *EndLoc) { assert(standardAttributesAllowed()); SourceLocatio

[PATCH] D105648: [OpenMP] Support OpenMP 5.1 attributes

aaron.ballman added inline comments. Comment at: clang/lib/Parse/ParseDeclCXX.cpp:4285 +// created for us by the caller. +return true; + } erichkeane wrote: > ABataev wrote: > > erichkeane wrote: > > > aaron.ballman wrote: > > > > erichkeane wrote: > > >

[PATCH] D105648: [OpenMP] Support OpenMP 5.1 attributes

aaron.ballman added inline comments. Comment at: clang/lib/Parse/ParseDeclCXX.cpp:4285 +// created for us by the caller. +return true; + } aaron.ballman wrote: > erichkeane wrote: > > ABataev wrote: > > > erichkeane wrote: > > > > aaron.ballman wrote: >

[PATCH] D105648: [OpenMP] Support OpenMP 5.1 attributes

aaron.ballman updated this revision to Diff 357338. aaron.ballman marked 2 inline comments as done. aaron.ballman added a comment. Address review feedback, add a link to this review to the OpenMP status page for the feature. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105648/new/ htt

[PATCH] D105648: [OpenMP] Support OpenMP 5.1 attributes

aaron.ballman marked an inline comment as done. aaron.ballman added inline comments. Comment at: clang/lib/Parse/ParseDeclCXX.cpp:2670-2676 + + // The next token may be an OpenMP pragma annotation token. That would + // normally be handled from ParseCXXClassMemberDeclarationWit

[PATCH] D105648: [OpenMP] Support OpenMP 5.1 attributes

aaron.ballman updated this revision to Diff 357479. aaron.ballman marked an inline comment as done. aaron.ballman added a comment. Change `annot_pragma_openmp_from_attr` into `annot_attr_openmp` based on review feedback. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105648/new/ https:/

[PATCH] D105648: [OpenMP] Support OpenMP 5.1 attributes

aaron.ballman marked 8 inline comments as done. aaron.ballman added inline comments. Comment at: clang/lib/Parse/ParseDeclCXX.cpp:2670-2676 + + // The next token may be an OpenMP pragma annotation token. That would + // normally be handled from ParseCXXClassMemberDeclarationWit

[PATCH] D105648: [OpenMP] Support OpenMP 5.1 attributes

aaron.ballman updated this revision to Diff 357487. aaron.ballman added a comment. Enable attribute support as an extension (with the usual diagnostics). Note that this adds some new diagnostic groups for OpenMP as well. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105648/new/ https:/

[PATCH] D105648: [OpenMP] Support OpenMP 5.1 attributes

aaron.ballman added a comment. In D105648#2866893 , @ABataev wrote: > LG, but wait for others' comments/suggestions/etc. Thank you for the review! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105648/new/ https://reviews.llvm.org/D105648

[PATCH] D105479: [clang-tidy] [PR50069] readability-braces-around-statements doesn't work well with [[likely]] [[unlikely]]

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM, thank you for the fix! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105479/new/ https://reviews.llvm.org/D105479 ___

[PATCH] D105660: [PowerPC][AIX] Add warning when alignment is incompatible with XL

aaron.ballman added inline comments. Comment at: clang/include/clang/Basic/DiagnosticSemaKinds.td:3255-3256 +def warn_not_xl_compatible +: Warning<"requested alignment of arguments 16 bytes or greater is not" + " compatible with previous versions of the AIX XL co

[PATCH] D105127: Implement P1401R5

aaron.ballman added inline comments. Comment at: clang/include/clang/Basic/DiagnosticSemaKinds.td:1491 +def err_constexpr_if_condition_expression_is_not_constant : Error< + "constexpr if condition is not a constant expression convertible to bool">; def err_static_assert_failed

[PATCH] D105127: Implement P1401R5

aaron.ballman requested changes to this revision. aaron.ballman added a comment. This revision now requires changes to proceed. Making it clear that there are still some minor changes left to be made. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D10

[PATCH] D105127: Implement P1401R5

aaron.ballman added a comment. This LGTM aside from a small nit, but you should wait a bit to land in case other reviewers have comments. Comment at: clang/test/CXX/stmt.stmt/stmt.select/stmt.if/p2.cpp:42-43 + +struct S { +} s; void f() { This looks like it

[PATCH] D105127: Implement P1401R5

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. Oops, I chanted the magic incantation but forgot to press the button. LGTM again. ;-) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org

[PATCH] D105648: [OpenMP] Support OpenMP 5.1 attributes

aaron.ballman closed this revision. aaron.ballman added a comment. Thank you for the reviews, everyone. I've commit in de59f564400de1b0fe30ae07f3c800562a025e27 . CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105648/ne

[PATCH] D105127: Implement P1401R5

aaron.ballman closed this revision. aaron.ballman added a comment. Thanks for the patch! I've committed on your behalf in 8747234032c9c6270a6198ab3cca14ce2bd18721 . Repository: rG LLVM Github Monorepo CHANGES SINCE LAST AC

[PATCH] D69764: [clang-format] Add East/West Const fixer capability

aaron.ballman added a comment. In D69764#2873225 , @MyDeveloperDay wrote: > If this is something we think we wouldn't want in clang-format, what about > the idea of building a new binary which did allow the modification of the > tokens, This comes up fr

[PATCH] D105892: [NFC] Silence build warning by placing parentheses around condition

aaron.ballman added a reviewer: alexfh. aaron.ballman added a comment. Note: https://reviews.llvm.org/D105890 that was just landed to touch the same area. FWIW, I agree that this should probably be using some local variables to make the conditions a bit more clear. Repository: rG LLVM Githu

[PATCH] D69764: [clang-format] Add East/West Const fixer capability

aaron.ballman added a comment. In D69764#2874404 , @MyDeveloperDay wrote: >> What you're describing sounds like clang-tidy but perhaps with improved >> support for composing source modifications from fix-its, or do you envision >> something rather diffe

[PATCH] D69764: [clang-format] Add East/West Const fixer capability

aaron.ballman added a comment. In D69764#2874464 , @atomgalaxy wrote: > It's very difficult to use a compile_commands database if you can't > actually check out all the code and a remote service builds it for you. In D69764#2874514

[PATCH] D69764: [clang-format] Add East/West Const fixer capability

aaron.ballman added a comment. In D69764#2874790 , @MyDeveloperDay wrote: >> so there's something like precedent here > > I think its worth mentioning, that my personal preference would STILL be to > land this inside clang-format with default configurati

[PATCH] D20689: [clang-tidy] Add 'readability-suspicious-call-argument' check

aaron.ballman accepted this revision. aaron.ballman added a comment. In D20689#2874473 , @whisperity wrote: > Bump. 🙂 I would prefer this check to be able to go into Clang-Tidy 13 if it's > okay, together with the other check I implemented. @alexfh has h

[PATCH] D105973: [ASTMatchers] NFC: Fix the annotation.

aaron.ballman added a comment. The change looks good to me, but you need to regenerate the documentation manually. You can do so by running clang/docs/tools/dump_ast_matchers.py. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105973/new/ https://re

[PATCH] D105997: Implement _ExtInt conversion rules

aaron.ballman created this revision. aaron.ballman added reviewers: rsmith, erichkeane, mibintc, jyknight, rjmccall. aaron.ballman requested review of this revision. Herald added a project: clang. Clang implemented the _ExtInt datatype as a bit-precise integer type, which was then proposed to WG1

[PATCH] D105997: Implement _ExtInt conversion rules

aaron.ballman added inline comments. Comment at: clang/test/Sema/ext-int.c:7 _ExtInt(32) s32, int b) { - b ? s30 : s31a; // expected-error{{incompatible operand types}} - b ? s31a : s30; // expected-error{{incompatible operand types}} - b ? s32 : 0; // expected-e

[PATCH] D105997: Implement _ExtInt conversion rules

aaron.ballman added inline comments. Comment at: clang/test/Sema/ext-int.c:7 _ExtInt(32) s32, int b) { - b ? s30 : s31a; // expected-error{{incompatible operand types}} - b ? s31a : s30; // expected-error{{incompatible operand types}} - b ? s32 : 0; // expected-e

[PATCH] D105997: Implement _ExtInt conversion rules

aaron.ballman updated this revision to Diff 358663. aaron.ballman added a comment. Added more test coverage in C for conversion type results. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105997/new/ https://reviews.llvm.org/D105997 Files: clang/lib/Sema/SemaExpr.cpp clang/test/Sem

[PATCH] D105951: [clang] P2266 implicit moves STL workaround

aaron.ballman added a comment. Thank you for working on this! We're testing the patch out internally to see if it solves issues for us with some of the failures we're seeing. Comment at: clang/lib/Sema/SemaStmt.cpp:3314 +return false; + const Decl *D = E.getReferencedDecl

[PATCH] D105660: [PowerPC][AIX] Add warning when alignment is incompatible with XL

aaron.ballman added inline comments. Comment at: clang/include/clang/Basic/DiagnosticSemaKinds.td:3255-3256 +def warn_not_xl_compatible +: Warning<"requested alignment of arguments 16 bytes or greater is not" + " compatible with previous versions of the AIX XL co

[PATCH] D105052: [clang][darwin] add support for Mac Catalyst availability

aaron.ballman accepted this revision. aaron.ballman added a comment. LGTM! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105052/new/ https://reviews.llvm.org/D105052 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.o

<    44   45   46   47   48   49   50   51   52   53   >