[PATCH] D41056: [clang-tidy] New check misc-uniqueptr-release-unused-retval

aaron.ballman added a comment. In https://reviews.llvm.org/D41056#951507, @khuttun wrote: > P0600R1 seems to suggest quite conservative approach (and rightly so, IMO) in > taking `[[nodiscard]]` in use in std lib. For example it proposes *not* to > use it with `unique_ptr::release`. I think the

[PATCH] D36915: [Sema] Diagnose local variables and parameters captured by lambda and block expressions in a default argument

aaron.ballman added inline comments. Comment at: lib/Sema/Sema.cpp:1677-1684 +Sema::DefaultArgRAII::DefaultArgRAII(Sema &S) +: Actions(S), PrevParent(S.getParentOfDefaultArg()) { + S.setParentOfDefaultArg(S.CurContext); +} + +Sema::DefaultArgRAII::~DefaultArgRAII() { + Acti

[PATCH] D40854: [clang-tidy] WIP implement cppcoreguidelines check for mixed integer arithmetic

aaron.ballman added a comment. In https://reviews.llvm.org/D40854#950640, @JonasToth wrote: > > The "enforcement" listed on the C++ Core Guidelines is very unhelpful, so > > it might be worth bringing it up as an issue on their bug tracker. ES.100 > > basically says "you know what we mean, wink

[PATCH] D39937: [Sema] Improve diagnostics for const- and ref-qualified member functions

aaron.ballman added a comment. You're set to commit (if there are concerns, @rsmith can raise them post-commit). Do you need me to commit on your behalf? https://reviews.llvm.org/D39937 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http:/

[PATCH] D40671: [clang-tidy] Support specific checks for NOLINT directive

aaron.ballman added a comment. In https://reviews.llvm.org/D40671#953291, @xgsa wrote: > @aaron.ballman, sorry for my insistence, but it seems all the comments are > fixed and the patch is ready for commit or am I missing something? Could you > please commit it on my behalf, as I don't have rig

[PATCH] D36892: [clang-tidy] check_clang_tidy.py: support CHECK-NOTES prefix

aaron.ballman added a comment. I think you're set to commit this -- if @alexfh has concerns, they can be addressed post-commit. Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D36892 ___ cfe-commits mailing list cfe-commits@lists.llv

[PATCH] D40819: Implement Attribute Target MultiVersioning (Improved edition!)

aaron.ballman added inline comments. Comment at: include/clang/Basic/Attr.td:1809 bool DuplicateArchitecture = false; + bool operator==(const ParsedTargetAttr &Other) { +return DuplicateArchitecture == Other.DuplicateArchitecture && This funct

[PATCH] D36892: [clang-tidy] check_clang_tidy.py: support CHECK-NOTES prefix

aaron.ballman added a comment. In https://reviews.llvm.org/D36892#953953, @lebedev.ri wrote: > In https://reviews.llvm.org/D36892#953891, @aaron.ballman wrote: > > > I think you're set to commit this > > > Should i commit it though? > Until licensing concerns with https://reviews.llvm.org/D36836

[PATCH] D40448: Add a printing policy for AST dumping

aaron.ballman added a comment. Ping https://reviews.llvm.org/D40448 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D131479: Handle explicitly defaulted consteval special members.

aaron.ballman added a comment. In D131479#3753462 , @Mordante wrote: > This change breaks the libc++ test > `libcxx/test/std/utilities/optional/optional.object/optional.object.ctor/move.fail.cpp`. > > (https://buildkite.com/llvm-project/libcxx-ci/build

[PATCH] D132592: [Clang] Implement function attribute nouwtable

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM, though please add a release note for the new attribute. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D132592/new/ https://re

[PATCH] D132749: Expose QualType::getUnqualifiedType in libclang

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG123062ec2f3e: Expose QualType::getUnqualifiedType in libclang (authored by diseraluca, committed by aaron.ballman). Repository: rG LLVM Github Mon

[PATCH] D132791: Fix formatting in release notes

aaron.ballman accepted this revision. aaron.ballman added a comment. LGTM! I did not test building the docs, but the changes all look correct based on my experience with RST. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D132791/new/ https://review

[PATCH] D131479: Handle explicitly defaulted consteval special members.

aaron.ballman added a comment. In D131479#3753586 , @Mordante wrote: > In D131479#3753533 , @aaron.ballman > wrote: > >> In D131479#3753462 , @Mordante >> wrote: >> >>>

[PATCH] D128095: [clang] Improve diagnostics for expansion length mismatch

aaron.ballman added inline comments. Comment at: clang/lib/Sema/SemaTemplateVariadic.cpp:103-106 +VisitSubstNonTypeTemplateParmPackExpr(SubstNonTypeTemplateParmPackExpr *E) { + Unexpanded.push_back({E, E->getParameterPackLocation()}); + return true; +}

[PATCH] D128095: [clang] Improve diagnostics for expansion length mismatch

aaron.ballman added inline comments. Comment at: clang/lib/Sema/SemaTemplateVariadic.cpp:103-106 +VisitSubstNonTypeTemplateParmPackExpr(SubstNonTypeTemplateParmPackExpr *E) { + Unexpanded.push_back({E, E->getParameterPackLocation()}); + return true; +}

[PATCH] D131632: [clang] Enable output of SARIF diagnostics

aaron.ballman added inline comments. Comment at: clang/test/Frontend/sarif-diagnostics.cpp:8 +// Omit filepath to llvm project directory +// CHECK: clang/test/Frontend/sarif-diagnostics.cpp"},"mimeType":"text/plain","roles":["resultFile"]}],"columnKind":"unicodeCodePoints","resu

[PATCH] D132851: Further update -Wbitfield-constant-conversion for 1-bit bitfield

aaron.ballman created this revision. aaron.ballman added reviewers: ShawnZhong, thakis, clang-language-wg, erichkeane. Herald added a project: All. aaron.ballman requested review of this revision. Herald added a project: clang. https://reviews.llvm.org/D131255 (82afc9b169a67e8b8a1862fb9c41a2cd974

[PATCH] D131255: Fix Wbitfield-constant-conversion on 1-bit signed bitfield

aaron.ballman added a comment. In D131255#3729304 , @aaron.ballman wrote: > After some more thought and some offline discussions, I think I have a > reasonable way forward: let's add `-Wsingle-bit-bitfield-constant-conversion` > as a new warning group

[PATCH] D132851: Further update -Wbitfield-constant-conversion for 1-bit bitfield

aaron.ballman updated this revision to Diff 456343. aaron.ballman added a comment. Added a test case for `true` in C++, and added similar logic for C to reduce the chance for false positives. If the user uses `true` (the macro from stdbool.h), they're signaling an intent that the field is used i

[PATCH] D131464: [test] Make tests pass regardless of gnu++14/gnu++17 default

aaron.ballman added a comment. I like the direction this is going; I ran into some questions on the tests about whether we should use a range or not and other small things, but I think this is getting close. Comment at: clang/test/CXX/temp/temp.res/temp.local/p3.cpp:2 +// RUN

[PATCH] D132727: [clang][Interp] Implement array initializers and subscript expressions

aaron.ballman added a comment. Precommit CI found a relevant failure: FAIL: Clang :: AST/Interp/arrays.cpp (67 of 15858) TEST 'Clang :: AST/Interp/arrays.cpp' FAILED Script: -- : 'RUN: at line 1'; c:\ws\w5\llvm-project\premerge-checks\build\

[PATCH] D132829: [clang][Interp] Handle ImplictValueInitExprs

aaron.ballman added a comment. > I don't have a test case handy for them since I'm not sure how to trigger > them reliably, but they are easy enough to implement and I ran into them > while working on array fillers. I think we should have test coverage for this if possible. https://godbolt.org

[PATCH] D132851: Further update -Wbitfield-constant-conversion for 1-bit bitfield

aaron.ballman updated this revision to Diff 456366. aaron.ballman added a comment. Update based on review feedback. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D132851/new/ https://reviews.llvm.org/D132851 Files: clang/docs/ReleaseNotes.rst clang/include/clang/Basic/DiagnosticGrou

[PATCH] D132136: [clang] Perform implicit lvalue-to-rvalue cast with new interpreter

aaron.ballman added a comment. In D132136#3753290 , @tbaeder wrote: > In D132136#3751702 , @erichkeane > wrote: > >> Would be great if we had a better test here... is there anything we can do >> to validate this

[PATCH] D132821: [clang][Parse] Fix crash when emitting template diagnostic

aaron.ballman added a comment. Please be sure to add a release note for the fix as well. Comment at: clang/include/clang/Basic/DiagnosticParseKinds.td:776-779 "identifier followed by '<' indicates a class template specialization but " "%0 %select{does not refer to a templ

[PATCH] D132853: [clang] Fix -Warray-bound interaction with -fstrict-flex-arrays=1

aaron.ballman added a comment. Can you add some more details to the patch summary about what this is fixing? Also, should this have a release note? Documentation changes? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D132853/new/ https://reviews.ll

[PATCH] D132727: [clang][Interp] Implement array initializers and subscript expressions

aaron.ballman added a comment. In D132727#3755843 , @tbaeder wrote: > In D132727#3755571 , @aaron.ballman > wrote: > >> Precommit CI found a relevant failure: > > That needs the lvalue-to-rvalue conversion patch

[PATCH] D132821: [clang][Parse] Fix crash when emitting template diagnostic

aaron.ballman accepted this revision. aaron.ballman added a comment. LGTM presuming precommit CI comes back green, but please don't forget the release note. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D132821/new/ https://reviews.llvm.org/D132821 _

[PATCH] D132848: [clang] Fix checking for emulated TLS in shouldAssumeDSOLocal in CodeGen

aaron.ballman added reviewers: rjmccall, efriedma. aaron.ballman added a comment. Adding a few more reviewers for better opinions, but the changes look reasonable to me. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D132848/new/ https://reviews.llv

[PATCH] D132877: Downgrade the UAX31 diagnostic to a warning which defaults to an error

aaron.ballman created this revision. aaron.ballman added reviewers: tahonermann, cor3ntin, clang-language-wg. Herald added a project: All. aaron.ballman requested review of this revision. Herald added a project: clang. WG21 P1949 and WG14 N2836 were both adopted w

[PATCH] D132877: Downgrade the UAX31 diagnostic to a warning which defaults to an error

aaron.ballman added subscribers: thieta, tstellar. aaron.ballman added a comment. CC @tstellar and @thieta for any early backporting concerns. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D132877/new/ https://reviews.llvm.org/D132877 _

[PATCH] D132877: Downgrade the UAX31 diagnostic to a warning which defaults to an error

aaron.ballman marked an inline comment as done. aaron.ballman added a comment. In D132877#3756328 , @efriedma wrote: > If we don't specifically call out the deprecation period in the diagnostic, > usage will grow beyond what we expect. (Most people don'

[PATCH] D132877: Downgrade the UAX31 diagnostic to a warning which defaults to an error

aaron.ballman marked an inline comment as done. aaron.ballman added a comment. In D132877#3756458 , @cor3ntin wrote: > I am strongly against this change. If we do want to do this, we need to > restore the original tables from c++11 and check against them

[PATCH] D132853: [clang] Fix -Warray-bound interaction with -fstrict-flex-arrays=1

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. Thank you for the updated description! LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D132853/new/ https://reviews.llvm.org/D13

[PATCH] D131464: [test] Make tests pass regardless of gnu++14/gnu++17 default

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. This LGTM but I'd appreciate it if @dblaikie could also give it a once over so we have more than one sets of eyes on the changes in case I've missed something.

[PATCH] D129488: [Sema] Delay evaluation of std::source_location::current() in default arguments

aaron.ballman added a comment. In D129488#3758449 , @jyknight wrote: > I'm confused about this new strategy of special-casing > `source_location::current()`. Isn't it wrong to eagerly evaluate _other_ > calls in default args, as well? ISTM that source_l

[PATCH] D132952: [Sema] disable -Wvla for function array parameters

aaron.ballman added a comment. Thank you for working on this! Can you be sure to add more information to the description so that reviewers more quickly understand why the changes are being made? In terms of the changes themselves, I don't think they're heading in the right direction just yet.

[PATCH] D129488: [Sema] Delay evaluation of std::source_location::current() in default arguments

aaron.ballman added a comment. In D129488#3758798 , @ilya-biryukov wrote: > I was also under impression that this should fall out of the C++ semantics, > but after playing around with it I am not so sure anymore. I'm also starting to question that. :-)

[PATCH] D130867: [clang] adds builtin `std::invoke` and `std::invoke_r`

aaron.ballman added a reviewer: libc++. aaron.ballman added a comment. Thanks for working on this; these sort of improvements to compile time overhead are very much appreciated! Has this been tested against libc++ (our preccommit CI doesn't test that), and if so, do all the results come back cl

[PATCH] D132952: [Sema] disable -Wvla for function array parameters

aaron.ballman added a comment. In D132952#3759109 , @efriedma wrote: >> We have the VariableArrayType to represent a VLA type and I think we're >> using that type when we should be using a variably modified type > > The clang AST for function signatures

[PATCH] D131268: [HLSL] Generate buffer subscript operators

aaron.ballman added inline comments. Comment at: clang/lib/Sema/HLSLExternalSemaSource.cpp:108-113 +if (Template) { + if (auto TTD = dyn_cast( + Template->getTemplateParameters()->getParam(0))) +Ty = Record->getASTContext().getPointerType( +

[PATCH] D132906: [Clang] Fix lambda CheckForDefaultedFunction(...) so that it checks the CXXMethodDecl is a special member function before attempting to call DefineDefaultedFunction(...)

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM aside from a minor test formatting nit. Please be sure to also write a release note for the fix. Comment at: clang/test/SemaCXX/constant-expression-cxx2a.

[PATCH] D132952: [Sema] disable -Wvla for function array parameters

aaron.ballman added a comment. In D132952#3759398 , @efriedma wrote: > In D132952#3759226 , @aaron.ballman > wrote: > >>> We could theoretically mess with the AST representation somehow, but I >>> don't see any

[PATCH] D132918: [clang] Fix a crash in constant evaluation

aaron.ballman added inline comments. Comment at: clang/lib/AST/ExprConstant.cpp:4797 } +// Can't access properties of an incomplete type. +if (!RD->hasDefinition()) { kadircet wrote: > shafik wrote: > > erichkeane wrote: > > > It seems to me that we

[PATCH] D132918: [clang] Fix a crash in constant evaluation

aaron.ballman added reviewers: aaron.ballman, clang-language-wg. aaron.ballman requested changes to this revision. aaron.ballman added a comment. This revision now requires changes to proceed. Marking this as requesting changes so we don't have another accidental commit. Repository: rG LLVM Gi

[PATCH] D132851: Further update -Wbitfield-constant-conversion for 1-bit bitfield

This revision was automatically updated to reflect the committed changes. Closed by commit rG3b00e486797c: Further update -Wbitfield-constant-conversion for 1-bit bitfield (authored by aaron.ballman). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D132

[PATCH] D131563: [clang] Fix clang multiarch isssue with musl

aaron.ballman added a reviewer: echristo. aaron.ballman added a comment. Adding another reviewer to try to get this unstuck. Can you add test coverage for the changes (to clang\test\Driver)? Also, there should be a release note so users know about the fix (that can go into clang\docs\ReleaseNot

[PATCH] D132568: [clang][Sema] check default argument promotions for printf

aaron.ballman accepted this revision. aaron.ballman added a comment. Basically LGTM as well, just some nits about comments and a small fix to the c status page. In D132568#3753512 , @inclyc wrote: > Currently this patch has not fully implemented `wchar_

[PATCH] D132952: [Sema] disable -Wvla for function array parameters

aaron.ballman added a comment. In D132952#3759731 , @efriedma wrote: > As a practical matter, there isn't any reason to force variably modified > parameters to make a function variably modified. The types of parameters > aren't visible in the caller of

[PATCH] D133085: [clang] trim trailing space in format tests. NFC

aaron.ballman added a comment. In D133085#3763233 , @inclyc wrote: > In D133085#3763198 , @ChuanqiXu > wrote: > >> Do you have commit access? If you have, I remember LLVM encourages to land >> such fixes directl

[PATCH] D133085: [clang] trim trailing space in format tests. NFC

aaron.ballman added a comment. In D133085#3764067 , @inclyc wrote: > Thank you for your patience and detailed explanation! Sorry for waste your > time though ( No worries, it's definitely not a waste of time to explain this sort of stuff! :-) Reposit

[PATCH] D132550: Changes to code ownership in clang and clang-tidy

aaron.ballman updated this revision to Diff 457289. aaron.ballman marked an inline comment as done. aaron.ballman added a comment. Herald added subscribers: sstefan1, arphaman. Herald added a reviewer: jdoerfert. Because I'm touching this file so much anyway to add the GitHub handles, I had some

[PATCH] D133082: [clang] Implement setting crash_diagnostics_dir through env variable

aaron.ballman added subscribers: cor3ntin, tahonermann. aaron.ballman added a comment. In D133082#3763829 , @erichkeane wrote: > I don't mind the idea, but wonder if some level of RFC/project-wide decision > should be made here? WDYT @aaron.ballman ?

[PATCH] D133082: [clang] Implement setting crash_diagnostics_dir through env variable

aaron.ballman added inline comments. Comment at: clang/lib/Driver/Driver.cpp:5427 + ? A->getValue() + : std::getenv("CLANG_CRASH_DIAGNOSTICS_DIR"); + if (CrashDirectory) { mizvekov wrote: > aar

[PATCH] D133066: fix a typo in comment of AddConversionCandidate

aaron.ballman added a comment. The existing comment is correct according to my copy of the C++11 standard, but the standard has changed since C++11 and those words no longer appear in http://eel.is/c++draft/dcl.init.ref#5. Some more investigation is needed, but I suspect the correct action to t

[PATCH] D133043: [clangd] Fix tests for implicit C function declaration

aaron.ballman added a comment. LGTM, but someone with more clangd experience should do the final sign off (seeing as how I caused the issue in the first place, sorry about that!). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133043/new/ https://r

[PATCH] D132851: Further update -Wbitfield-constant-conversion for 1-bit bitfield

aaron.ballman added inline comments. Comment at: clang/test/Sema/constant-conversion.c:30 + s.b = 1; // one-bit-warning {{implicit truncation from 'int' to a one-bit wide bit-field changes value from 1 to -1}} + s.b = true; // no-warning (we suppress it manually to reduce

[PATCH] D132952: [Sema] disable -Wvla for function array parameters

aaron.ballman added a comment. In D132952#3761874 , @aaron.ballman wrote: > I'll ask on the WG14 reflectors to see if I'm interpreting the variably > modified type specification wrong or not. There's some agreement that the existing words could stand t

[PATCH] D133155: Update the docs about IRC

aaron.ballman created this revision. aaron.ballman added reviewers: jdoerfert, tonic, asl. Herald added a project: All. aaron.ballman requested review of this revision. Herald added a project: LLVM. We haven't had a Geordi bot in years and we moved the build bot to another channel. This updates t

[PATCH] D133155: Update the docs about IRC

This revision was automatically updated to reflect the committed changes. Closed by commit rG3da23970ed75: Update the docs about IRC (authored by aaron.ballman). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133155/new/ https://reviews.llvm.org/D133

[PATCH] D132851: Further update -Wbitfield-constant-conversion for 1-bit bitfield

aaron.ballman added inline comments. Comment at: clang/test/Sema/constant-conversion.c:30 + s.b = 1; // one-bit-warning {{implicit truncation from 'int' to a one-bit wide bit-field changes value from 1 to -1}} + s.b = true; // no-warning (we suppress it manually to reduce

[PATCH] D133194: rewording note note_constexpr_invalid_cast

aaron.ballman requested changes to this revision. aaron.ballman added a comment. This revision now requires changes to proceed. Thanks for the cleanup here! Precommit CI pointed out places where test coverage found issues, and you're missing new test coverage for the change. If you run the faili

[PATCH] D133197: [clang] Fix crash when parsing scanf format string with missing arguments

aaron.ballman accepted this revision. aaron.ballman added a comment. LGTM! In D133197#3766797 , @inclyc wrote: > Thanks @serge-sans-paille! Basically LGTM. Maybe we need to backport this > patch though? @aaron.ballman Clang 15 is closed for backports t

[PATCH] D133195: Expose QualType::getNonReferenceType in libclang

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM! The precommit CI failure on Debian looks to be unrelated, so I will land this on your behalf. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://re

[PATCH] D133195: Expose QualType::getNonReferenceType in libclang

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGe7d9917a60dc: Expose QualType::getNonReferenceType in libclang (authored by diseraluca, committed by aaron.ballman). Repository: rG LLVM Github Mo

[PATCH] D132136: [clang] Perform implicit lvalue-to-rvalue cast with new interpreter

aaron.ballman added a comment. In D132136#3766140 , @tbaeder wrote: > @aaron.ballman Can you comment on my last question? I'd like to land this > patch since the others depend on it. Sorry for the delay! In D132136#3760738

[PATCH] D126864: [clang] Introduce -fstrict-flex-arrays= for stricter handling of flexible arrays

aaron.ballman added inline comments. Comment at: clang/docs/ClangCommandLineReference.rst:2646 +.. option:: -fstrict-flex-arrays=, -fno-strict-flex-arrays + From the top of this file: ``` --- N

[PATCH] D133209: [clang] Document environment variables used by the driver

aaron.ballman added subscribers: jansvoboda11, aaron.ballman. aaron.ballman added inline comments. Comment at: clang/docs/ClangCommandLineReference.rst:2-5 --- NOTE: This file is automatically generated by runn

[PATCH] D133209: [clang] Document environment variables used by the driver

aaron.ballman added inline comments. Comment at: clang/docs/ClangCommandLineReference.rst:2-5 --- NOTE: This file is automatically generated by running clang-tblgen -gen-opt-docs. Do not edit this file by ha

[PATCH] D133066: fix a typo in comment of AddConversionCandidate

aaron.ballman added a comment. In D133066#3765503 , @zhouyizhou wrote: > In D133066#3764384 , @aaron.ballman > wrote: > >> The existing comment is correct according to my copy of the C++11 standard, >> but the

[PATCH] D133158: [NFC] Make MultiplexExternalSemaSource own sources

aaron.ballman accepted this revision. aaron.ballman added a comment. LGTM aside from some minor nits (also, please run clang-format over the patch before landing). Comment at: clang/lib/Sema/MultiplexExternalSemaSource.cpp:32 +MultiplexExternalSemaSource::~MultiplexExternalSem

[PATCH] D127284: [clang-repl] Support statements on global scope in incremental mode.

aaron.ballman added a comment. > The patch conceptually models the possible "top-level" statements between two > top-level declarations into a block which is emitted as part of the global > init function. > Currently we model this "statement block" as a function body to a void > function taking

[PATCH] D131268: [HLSL] Generate buffer subscript operators

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM aside from a nit that was missed. Thanks for switching to static_cast, that makes me happier. :-) Comment at: clang/lib/Sema/HLSLExternalSemaSource.cpp:10

[PATCH] D132829: [clang][Interp] Handle ImplictValueInitExprs

aaron.ballman accepted this revision. aaron.ballman added a comment. LGTM! Comment at: clang/test/AST/Interp/arrays.cpp:13 +/// currently evaluate other parts of it. +#if 0 +struct fred { I wish we could find some solution that didn't require this so that the

[PATCH] D132727: [clang][Interp] Implement array initializers and subscript expressions

aaron.ballman added inline comments. Comment at: clang/lib/AST/Interp/ByteCodeExprGen.cpp:277 +template +bool ByteCodeExprGen::VisitConstantExpr (const ConstantExpr *E) { + // TODO: Check if the ConstantExpr already has a value set and if so, ===

[PATCH] D132990: [Clang] Fix compat diagnostic to detect a nontype template parameter has a placeholder type using getContainedAutoType()

aaron.ballman added a comment. Can you also add a release note for the changes? Comment at: clang/lib/Sema/SemaTemplate.cpp:1534-1538 + if (const auto *T = TInfo->getType()->getContainedDeducedType()) +if (isa(T)) + Diag(D.getIdentifierLoc(), + diag::warn_cx

[PATCH] D132831: [clang][Interp] Handle SubstNonTypeTemplateParmExprs

aaron.ballman accepted this revision. aaron.ballman added a comment. LGTM on the assumption that the extra test coverage doesn't find anything. Comment at: clang/test/AST/Interp/functions.cpp:68-69 static_assert(recursion(10) == 0, ""); + + +template ==

[PATCH] D132779: Enforce module decl-use restrictions and private header restrictions in textual headers

aaron.ballman added a comment. The changes look reasonable to me, though if you think the flag is a temporary one, we might want to consider changes to document that explicitly. Comment at: clang/docs/ReleaseNotes.rst:126 +

[PATCH] D132550: Changes to code ownership in clang and clang-tidy

This revision was automatically updated to reflect the committed changes. Closed by commit rG3c604e9f1560: Update the clang and clang-tools-extra code owners files (authored by aaron.ballman). Changed prior to commit: https://reviews.llvm.org/D132550?vs=457289&id=458149#toc Repository: rG LL

[PATCH] D133248: [clang] Fix crash upon stray coloncolon token in C2x mode

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. Good catch that this was crashing! LGTM aside from the nit pointed out by @tbaeder. Can you also add a release note for the fix? Do you need someone to commit on your behalf? If

[PATCH] D133349: [clang][doc] Do not keep a copy of ClangCommandLineReference.rst in tree

aaron.ballman added a comment. In D133349#3771780 , @serge-sans-paille wrote: > @aaron.ballman this is just a patch to start a discussion: We already have > the cmake rule to generate this file, so removing it from tree actually > doesn't break compila

[PATCH] D127284: [clang-repl] Support statements on global scope in incremental mode.

aaron.ballman added inline comments. Comment at: clang/include/clang/AST/ASTConsumer.h:54-59 + /// HandleTopLevelStmts - Handle the specified top-level statements. This is + /// called by the parser to process every top-level Stmt* in incremental + /// compilation mode. + ///

[PATCH] D131465: C++/ObjC++: switch to gnu++17 as the default standard

aaron.ballman added a comment. Precomit CI found valid failures that seem plausibly related to your changes, but Windows and Debian found different failures which is a bit of a surprise to me. Can you check those? Comment at: clang/test/lit.site.cfg.py.in:27 config.clang_ena

[PATCH] D132952: [Sema] disable -Wvla for function array parameters

aaron.ballman added inline comments. Comment at: clang/test/Sema/warn-vla.c:8-12 +void test2(int n, int v[n]) { // c99 no-warning +#if __STDC_VERSION__ < 199901L +// expected-warning@-2{{variable length arrays are a C99 feature}} +#endif } inclyc wrote: > aaron.

[PATCH] D132952: [Sema] disable -Wvla for function array parameters

aaron.ballman added inline comments. Comment at: clang/test/Sema/warn-vla.c:8-12 +void test2(int n, int v[n]) { // c99 no-warning +#if __STDC_VERSION__ < 199901L +// expected-warning@-2{{variable length arrays are a C99 feature}} +#endif } aaron.ballman wrote: >

[PATCH] D132779: Enforce module decl-use restrictions and private header restrictions in textual headers

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM with a suggestion to also document the command line reference. Thanks! Comment at: clang/include/clang/Driver/Options.td:2290 + MarshallingInfoNegativeFl

[PATCH] D132952: [Sema] disable -Wvla for function array parameters

aaron.ballman added inline comments. Comment at: clang/test/Sema/warn-vla.c:8-12 +void test2(int n, int v[n]) { // c99 no-warning +#if __STDC_VERSION__ < 199901L +// expected-warning@-2{{variable length arrays are a C99 feature}} +#endif } efriedma wrote: > aaro

[PATCH] D132952: [Sema] disable -Wvla for function array parameters

aaron.ballman added inline comments. Comment at: clang/test/Sema/warn-vla.c:8-12 +void test2(int n, int v[n]) { // c99 no-warning +#if __STDC_VERSION__ < 199901L +// expected-warning@-2{{variable length arrays are a C99 feature}} +#endif } efriedma wrote: > aaro

[PATCH] D133349: [clang][doc] Do not keep a copy of ClangCommandLineReference.rst in tree

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. In D133349#3772353 , @serge-sans-paille wrote: > That's sounds like an "OK" to me, right? Yeah, this LGTM, thank you! Repository: r

[PATCH] D133082: [clang] Implement setting crash_diagnostics_dir through env variable

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM, thank you! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133082/new/ https://reviews.llvm.org/D133082 _

[PATCH] D133249: [libc++] Documents details of the pre-commit CI.

aaron.ballman added a comment. Thank you for working on this! Comment at: clang/www/hacking.html:33 Testing on the Command Line +Testing changes affecting libcxx Similar capitalization is used in the file. Comment at:

[PATCH] D132952: [Sema] disable -Wvla for function array parameters

aaron.ballman added inline comments. Comment at: clang/test/Sema/warn-vla.c:8-12 +void test2(int n, int v[n]) { // c99 no-warning +#if __STDC_VERSION__ < 199901L +// expected-warning@-2{{variable length arrays are a C99 feature}} +#endif } efriedma wrote: > aaro

[PATCH] D132977: [HLSL] Call global constructors inside entry

aaron.ballman added inline comments. Comment at: clang/test/CodeGenHLSL/GlobalConstructors.hlsl:3 + +RWBuffer Buffer; + Can you also add a test using `__attribute__((constructor))`? And probably one using `__attribute__((destructor))` at some point as well? htt

[PATCH] D131465: C++/ObjC++: switch to gnu++17 as the default standard

aaron.ballman added inline comments. Comment at: clang/test/lit.site.cfg.py.in:27 config.clang_enable_opaque_pointers = @CLANG_ENABLE_OPAQUE_POINTERS_INTERNAL@ +config.clang_default_std_cxx = "@CLANG_DEFAULT_STD_CXX@" config.clang_default_cxx_stdlib = "@CLANG_DEFAULT_CXX_STDLIB

[PATCH] D133202: [Clang][CodeGen] Avoid __builtin_assume_aligned crash when the 1st arg is array type

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM, but can you add a release note to clang/docs/ReleaseNotes.rst for the fix? Also, do you need someone to commit this on your behalf? If so, what name and email address would

[PATCH] D132952: [Sema] disable -Wvla for function array parameters

aaron.ballman added inline comments. Comment at: clang/test/Sema/warn-vla.c:8-12 +void test2(int n, int v[n]) { // c99 no-warning +#if __STDC_VERSION__ < 199901L +// expected-warning@-2{{variable length arrays are a C99 feature}} +#endif } efriedma wrote: > aaro

[PATCH] D131465: C++/ObjC++: switch to gnu++17 as the default standard

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. In D131465#3772803 , @MaskRay wrote: > Update clang-tools-extra/clangd/unittests/SelectionTests.cpp @sammccall This one looks to still b

[PATCH] D133375: [CMake] Remove CLANG_DEFAULT_STD_C/CLANG_DEFAULT_STD_CXX

aaron.ballman added a comment. So the basic idea here is that the default can be specified by a configuration file and thus we don't need any configure-time variable for it? But then why do we need other configuration macros like default stdlib or default linker? Mostly trying to understand wha

[PATCH] D129883: [HLSL] Support cbuffer/tbuffer for hlsl.

aaron.ballman added a comment. Thanks for the update, this is heading in a good direction! I think there's still a lot of test coverage missing. Consider: namespace Name { cbuffer a { int x; } } struct S { cbuffer what { int y; } }; void func() { tbuffer

<    19   20   21   22   23   24   25   26   27   28   >