ayartsev updated this revision to Diff 34583.
ayartsev added a comment.
Updated the patch after r246978. Please review!
http://reviews.llvm.org/D9040
Files:
lib/StaticAnalyzer/Checkers/MallocChecker.cpp
test/Analysis/malloc.c
Index: test/Analysis/malloc.c
==
ayartsev added a comment.
Thanks, Honggyu!
http://reviews.llvm.org/D12827
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
ayartsev added a comment.
Ping.
http://reviews.llvm.org/D9040
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
ayartsev added a comment.
Ping.
http://reviews.llvm.org/D9040
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
ayartsev added inline comments.
Comment at: lib/StaticAnalyzer/Core/RegionStore.cpp:2359
@@ -2314,1 +2358,3 @@
+RegionAndSymbolInvalidationTraits ITraits;
+W.AddToWorkList(*I, ITraits);
}
Too much unnecessary passing around of RegionAndSymbolInvalidatio
ayartsev added a reviewer: zaks.anna.
ayartsev removed a subscriber: zaks.anna.
ayartsev updated this revision to Diff 31868.
ayartsev added a comment.
Hi Honggyu,
thanks for updating the patch!
The new patch contains changes introduced by r244400
(http://reviews.llvm.org/D10356) and r244673 pl
ayartsev added inline comments.
Comment at: lib/StaticAnalyzer/Core/RegionStore.cpp:746
@@ -739,1 +745,3 @@
+return static_cast(this)->hasTrait(MR, IK);
+ }
};
Hmm.. Either we completely encapsulate 'RegionAndSymbolInvalidationTraits' in
the 'invalidateRegi
ayartsev updated this revision to Diff 32969.
ayartsev added a comment.
Updated the patch with r245621.
OK to commit?
http://reviews.llvm.org/D6551
Files:
tools/scan-build/scan-build
Index: tools/scan-build/scan-build
===
--- to
ayartsev closed this revision.
ayartsev added a comment.
Committed as r241201
http://reviews.llvm.org/D8774
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
ayartsev closed this revision.
ayartsev added a comment.
Merged with http://reviews.llvm.org/D8774.
http://reviews.llvm.org/D9357
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
ayartsev updated this revision to Diff 33134.
http://reviews.llvm.org/D9040
Files:
lib/StaticAnalyzer/Checkers/MallocChecker.cpp
test/Analysis/malloc.c
Index: test/Analysis/malloc.c
===
--- test/Analysis/malloc.c
+++ test/Analys
ayartsev added a comment.
Please review!
Comment at: lib/StaticAnalyzer/Checkers/MallocChecker.cpp:158
@@ +157,3 @@
+/// zero-allocated memory returned by 'realloc(ptr, 0)'.
+struct ReallocSizeZero {
+ void Profile(llvm::FoldingSetNodeID &ID) const {
zaks.anna
ayartsev added a comment.
Ping
http://reviews.llvm.org/D9040
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
ayartsev updated this revision to Diff 33740.
http://reviews.llvm.org/D9040
Files:
lib/StaticAnalyzer/Checkers/MallocChecker.cpp
test/Analysis/malloc.c
Index: test/Analysis/malloc.c
===
--- test/Analysis/malloc.c
+++ test/Analys
ayartsev added inline comments.
Comment at: lib/StaticAnalyzer/Checkers/MallocChecker.cpp:523
@@ -510,2 +522,3 @@
REGISTER_MAP_WITH_PROGRAMSTATE(ReallocPairs, SymbolRef, ReallocPair)
+REGISTER_MAP_WITH_PROGRAMSTATE(ReallocSizeZeroFlag, SymbolRef, ReallocSizeZero)
--
ayartsev added a comment.
Removed trailing whitespaces and committed as r246710.
Thanks for reviews and assistance!
http://reviews.llvm.org/D6551
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/
ayartsev added a comment.
Ping.
http://reviews.llvm.org/D9040
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
ayartsev updated this revision to Diff 46538.
ayartsev added a comment.
Updated the patch, please review.
http://reviews.llvm.org/D16317
Files:
lib/StaticAnalyzer/Checkers/CStringChecker.cpp
test/Analysis/string.c
Index: test/Analysis/string.c
==
ayartsev added a comment.
Ping.
http://reviews.llvm.org/D16317
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
ayartsev added a comment.
Ping.
http://reviews.llvm.org/D14629
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
ayartsev created this revision.
ayartsev added a reviewer: zaks.anna.
ayartsev added a subscriber: cfe-commits.
The patch is a fix for [[ https://llvm.org/bugs/show_bug.cgi?id=23790 | PR23790
]]. Call to StringRef::Compare() returning [1,0,-1] is replaced with the real
call to strcmp to be more
ayartsev created this revision.
ayartsev added a reviewer: zaks.anna.
ayartsev added subscribers: jordan_rose, krememek, sylvestre.ledru, cfe-commits.
A simple INI configuration file for scan-build with options - aliases to
scan-build command line arguments. This configuration file can be used to
ayartsev added a comment.
In http://reviews.llvm.org/D14629#288478, @jroelofs wrote:
> `CommonStuff.pm` (which could stand to have a more descriptive name,
> `libscanbuild.pm` maybe?) and `scan-build.cfg` belong in `share`.
Got it, I'll rename `CommonStuff.pm` and put it to `share` in the next
ayartsev updated this revision to Diff 42762.
ayartsev added a comment.
Updated the patch following Laszlo's advises:
+ Changed config file format to YAML.
+ Dump current configuration.
+ Search for config file from the current folder and upper.
In http://reviews.llvm.org/D14629#294023, @jroelofs
ayartsev added a comment.
Upd: Forgot to remove the printHash() subroutine from libscanbuild.pm. Using it
locally for debug purpose.
http://reviews.llvm.org/D14629
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bi
ayartsev added a comment.
Ping
http://reviews.llvm.org/D14629
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
26 matches
Mail list logo
