[PATCH] D83857: Harmonize python shebang

This revision was automatically updated to reflect the committed changes. Closed by commit rG515bc8c1554f: Harmonize Python shebang (authored by serge-sans-paille). Herald added projects: clang, Sanitizers, LLDB, libc++, OpenMP, libc-project. Herald added subscribers: libc-commits, openmp-commits,

[PATCH] D83149: [gcov] Add __gcov_dump/__gcov_reset and delete __gcov_flush

serge-sans-paille accepted this revision. serge-sans-paille added a comment. This revision is now accepted and ready to land. LGTM, I still would appreciate @calixte feedback here. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83149/new/ https://re

[PATCH] D79961: [PGO] Fix computation of fuction Hash

serge-sans-paille added a comment. In D79961#2065605 , @alanphipps wrote: > It looks like clang/test/Profile/Inputs/c-general.profdata.v5 is being read > as v6 rather than v5. Can you double check? Yep, I'll have a look. Repository: rG LLVM Github

[PATCH] D79961: [PGO] Fix computation of fuction Hash

serge-sans-paille added a comment. In D79961#2065605 , @alanphipps wrote: > It looks like clang/test/Profile/Inputs/c-general.profdata.v5 is being read > as v6 rather than v5. Can you double check? Thanks for spotting the issue. Should be fixed by 634

[PATCH] D83149: [gcov] Add __gcov_dump/__gcov_reset and delete __gcov_flush

serge-sans-paille added a comment. Some nit-picking, lgtm otherwise. Please wait for @calixte review though :-) Comment at: compiler-rt/test/profile/Inputs/instrprof-dlopen-dlclose-main.c:49 dlerror(); - void (*gcov_flush1)() = (void (*)())dlsym(f1_handle, "__gcov_flush");

[PATCH] D83149: [gcov] Add __gcov_dump/__gcov_reset and delete __gcov_flush

serge-sans-paille added inline comments. Comment at: compiler-rt/test/profile/Inputs/instrprof-dlopen-dlclose-main.c:49 dlerror(); - void (*gcov_flush1)() = (void (*)())dlsym(f1_handle, "__gcov_flush"); - if (gcov_flush1 == NULL) { -fprintf(stderr, "unable to find __gcov

[PATCH] D82767: clang-format: Explicitly use python3

serge-sans-paille added a comment. In D82767#2132903 , @MyDeveloperDay wrote: > We may not be consistent across all of LLVM > > $ find . -name '*.py' -print -exec /usr/bin/head -2 {} \; | grep "#!" | > sort | uniq -c > 6 #! /usr/bin/env python

[PATCH] D82767: clang-format: Explicitly use python3

serge-sans-paille added a comment. >> My understanding is that explicitly requiring python3 may make sense if the >> script is not backward-compatible with python2, while requiring python means >> the version is not important. >> At the end-of-year, we should be able to harmonize shebangs to

[PATCH] D82291: Make it possible for client code to consume CLANG_LINK_CLANG_DYLIB

This revision was automatically updated to reflect the committed changes. Closed by commit rG05c479491c1d: Make it possible for client code to consume CLANG_LINK_CLANG_DYLIB (authored by serge-sans-paille). Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LL

[PATCH] D78192: Support compiler extensions as a normal component

serge-sans-paille updated this revision to Diff 259284. serge-sans-paille added a comment. Herald added subscribers: cfe-commits, dang, dexonsmith, steven_wu, hiraditya. Herald added a project: clang. Instead of linking all compiler extensions to the different possible tagets (clang, opt lto etc)

[PATCH] D78192: Support compiler extensions as a normal component

serge-sans-paille added a comment. @Meinersbur with the latest updat, it should also be compatible with https://github.com/intel/opencl-clang/blob/83837744ef076c1285ed2ee9349febc2208d3252/CMakeLists.txt#L266 as all contains the `Extensions` component. Repository: rG LLVM Github Monorepo CHA

[PATCH] D78192: Support compiler extensions as a normal component

serge-sans-paille added a comment. Note that this should solve in an elegant (?) way the multiple link errors found when linking clang with LLVM_DYLIB. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78192/new/ https://reviews.llvm.org/D78192 ___

[PATCH] D78192: Support compiler extensions as a normal component

serge-sans-paille added a comment. In D78192#1997698 , @Meinersbur wrote: > Is this ready to try out? It is! > > > In D78192#1996859 , > @serge-sans-paille wrote: > >> Note that this should solve in an elegan

[PATCH] D78192: Support compiler extensions as a normal component

serge-sans-paille updated this revision to Diff 259495. serge-sans-paille added a comment. Fix dependency order for extension libraries, as spotted by @Meinersbur CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78192/new/ https://reviews.llvm.org/D78192 Files: clang/lib/CodeGen/CMakeLi

[PATCH] D78192: Support compiler extensions as a normal component

This revision was automatically updated to reflect the committed changes. Closed by commit rG8f766e382b77: Update compiler extension integration into the build system (authored by serge-sans-paille). Changed prior to commit: https://reviews.llvm.org/D78192?vs=259495&id=259827#toc Repository:

[PATCH] D78477: [profile] Don't crash when forking in several threads

serge-sans-paille added inline comments. Comment at: llvm/lib/Transforms/Instrumentation/GCOVProfiling.cpp:697 +Builder.CreateCall(WriteoutF); +if (NextInst != Parent->end()) { + DebugLoc Loc = E->getDebugLoc(); I'm puzzled by this test. ``F`` is a C

[PATCH] D78192: Support compiler extensions as a normal component

serge-sans-paille added a comment. The patch landed without much errors, only added the patchset e307eeba0137700e75893089cf0de03383d851ca Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llv

[PATCH] D83984: Explicitly use utf-8 in send_string

serge-sans-paille added a comment. According to the doc, `'utf-8'` is already the default encoding, at least on py3, but not on py2. i guess that the problem you're trying to fix? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83984/new/ https://re

[PATCH] D85485: Fix quiet mode in git-clang-format

serge-sans-paille accepted this revision. serge-sans-paille added inline comments. This revision is now accepted and ready to land. Comment at: clang/tools/clang-format/git-clang-format:151 if not changed_lines: -print('no modified files to format') +if opts.verbose >=

[PATCH] D79961: [PGO] Fix computation of fuction Hash

serge-sans-paille created this revision. serge-sans-paille added reviewers: dexonsmith, zturner. serge-sans-paille added a project: clang. Herald added a subscriber: cfe-commits. Previous implementation was incorrectly passing an integer, that got converted to a pointer, to finalize the hash compu

[PATCH] D79961: [PGO] Fix computation of fuction Hash

serge-sans-paille updated this revision to Diff 264084. serge-sans-paille added a comment. Update test case Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79961/new/ https://reviews.llvm.org/D79961 Files: clang/lib/CodeGen/CodeGenPGO.cpp clang/

[PATCH] D79961: [PGO] Fix computation of fuction Hash

serge-sans-paille updated this revision to Diff 264552. serge-sans-paille edited the summary of this revision. serge-sans-paille added a comment. Updated summary + removed namespace. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79961/new/ https://

[PATCH] D79961: [PGO] Fix computation of fuction Hash

serge-sans-paille added a comment. > May I ask how you found this? This was a long (and painful) quest when tracking https://bugzilla.redhat.com/show_bug.cgi?id=1827282 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79961/new/ https://reviews.ll

[PATCH] D132853: [clang] Fix -Warray-bound interaction with -fstrict-flex-arrays=1

serge-sans-paille created this revision. serge-sans-paille added reviewers: sberg, kees. Herald added a project: All. serge-sans-paille requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.l

[PATCH] D132853: [clang] Fix -Warray-bound interaction with -fstrict-flex-arrays=1

serge-sans-paille added a comment. Description updated, it's just a bug in the previous implementation (by myself!) I don't think it's worth an entry in the release notes. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D132853/new/ https://reviews.l

[PATCH] D132853: [clang] Fix -Warray-bound interaction with -fstrict-flex-arrays=1

This revision was automatically updated to reflect the committed changes. Closed by commit rG31dd0255aeaa: [clang] Fix -Warray-bound interaction with -fstrict-flex-arrays=1 (authored by serge-sans-paille). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org

[PATCH] D132944: [clang] cleanup -fstrict-flex-arrays implementation

serge-sans-paille created this revision. serge-sans-paille added a reviewer: jyknight. Herald added a project: All. serge-sans-paille requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This is a follow up to https://reviews.llvm.org/D126864, a

[PATCH] D132944: [clang] cleanup -fstrict-flex-arrays implementation

serge-sans-paille updated this revision to Diff 456971. serge-sans-paille edited the summary of this revision. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D132944/new/ https://reviews.llvm.org/D132944 Files: clang/include/clang/Driver/Options.td clang/lib/CodeGen/CGExpr.cpp clang/

[PATCH] D132944: [clang] cleanup -fstrict-flex-arrays implementation

This revision was automatically updated to reflect the committed changes. Closed by commit rGe0746a8a8d64: [clang] cleanup -fstrict-flex-arrays implementation (authored by serge-sans-paille). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D132944/new/

[PATCH] D133108: [clang] Rework IsTailPaddedMemberArray into isFlexibleArrayMemberExpr

serge-sans-paille created this revision. serge-sans-paille added a reviewer: jyknight. Herald added a project: All. serge-sans-paille requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This fixes a bunch of FIXME within IsTailPaddedMemberArray

[PATCH] D133197: [clang] Fix crash when parsing scanf format string with missing arguments

serge-sans-paille created this revision. Herald added a project: All. serge-sans-paille requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. When parsing a format string with less argument than specified, one should check argument access because

[PATCH] D133197: [clang] Fix crash when parsing scanf format string with missing arguments

This revision was automatically updated to reflect the committed changes. Closed by commit rGab09043a1985: [clang] Fix crash when parsing scanf format string with missing arguments (authored by serge-sans-paille). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.

[PATCH] D133349: [clang][doc] Do not keep a copy of ClangCommandLineReference.rst in tree

serge-sans-paille added a comment. @aaron.ballman this is just a patch to start a discussion: We already have the cmake rule to generate this file, so removing it from tree actually doesn't break compilation. So I'm wondering why and if we should keep it checked in? Removing it would make it le

[PATCH] D133349: [clang][doc] Do not keep a copy of ClangCommandLineReference.rst in tree

serge-sans-paille added a comment. That's sounds like an "OK" to me, right? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133349/new/ https://reviews.llvm.org/D133349 ___ cfe-commits mailing list cfe-com

[PATCH] D128643: [clang] -fsanitize=array-bounds: treat all trailing size-1 arrays as flexible

serge-sans-paille added inline comments. Comment at: clang/include/clang/AST/Expr.h:455 + bool isFlexibleArrayMember(ASTContext &Ctx, int StrictFlexArraysLevel, + bool IgnoreSizeFromMacro) const; Maybe default to `false` here? ===

[PATCH] D128449: [clang] Introduce -Warray-parameter

serge-sans-paille updated this revision to Diff 440352. serge-sans-paille marked 3 inline comments as done. serge-sans-paille added a comment. Take review into account + add C++ test file. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128449/new/ https://reviews.llvm.org/D128449 Files:

[PATCH] D128449: [clang] Introduce -Warray-parameter

serge-sans-paille added inline comments. Comment at: clang/test/Sema/array-parameter.c:2 +// RUN: %clang_cc1 -triple x86_64-pc-linux-gnu -fsyntax-only -Warray-parameter -verify %s + +void f0(int a[]); aaron.ballman wrote: > aaron.ballman wrote: > > I'd like to s

[PATCH] D128715: [clang-tidy] Fix confusable identifiers interaction with DeclContext

serge-sans-paille created this revision. serge-sans-paille added a reviewer: aaron.ballman. Herald added subscribers: carlosgalvezp, xazax.hun. Herald added a project: All. serge-sans-paille requested review of this revision. Herald added a project: clang-tools-extra. Herald added a subscriber: cfe

[PATCH] D126864: [clang] Introduce -fstrict-flex-arrays= for stricter handling of flexible arrays

serge-sans-paille added a comment. GCC and Clang don't have the same behavior wrt. macros-as-abound and standard-layout-requirement, see https://godbolt.org/z/3vc4TcTYz I'm fine with keeping the CLang behavior, but do we want to keep it only for level=0, and drop it for higher level (this would

[PATCH] D126864: [clang] Introduce -fstrict-flex-arrays= for stricter handling of flexible arrays

serge-sans-paille updated this revision to Diff 440942. serge-sans-paille added a subscriber: chandlerc. serge-sans-paille added a comment. Code updated to take into account two situations: - size resulting from macro expansion. Previous behavior was inconsistent in that situation. I chose to co

[PATCH] D128783: [test] Check for more -fsanitize=array-bounds regressions

serge-sans-paille added a comment. In D128783#3617924 , @MaskRay wrote: > Do we need a C test (just add a `-x c` RUN line)? @serge-sans-paille Do you > think we may likely make C++ stricter than C? I've started a similar discussion on https://reviews.ll

[PATCH] D128783: [test] Check for more -fsanitize=array-bounds regressions

serge-sans-paille added a comment. And note that with current clang, the behavior I describe here is not uniform across clang code base :-/ Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128783/new/ https://reviews.llvm.org/D128783 ___

[PATCH] D128715: [clang-tidy] Fix confusable identifiers interaction with DeclContext

serge-sans-paille added a comment. @aaron.ballman : I agree with most of your suggestion except the one below that I annotated accordingly struct Base { virtual void O0(); private: void II(); }; struct Derived : Base { void OO(); // We should warn about this void I

[PATCH] D128715: [clang-tidy] Fix confusable identifiers interaction with DeclContext

serge-sans-paille updated this revision to Diff 441505. serge-sans-paille added a comment. Update test case to take into accounts reviewers suggestions. As a consequence use a more complex approach to detect whether two `NamedDecl` may interfere. CHANGES SINCE LAST ACTION https://reviews.ll

[PATCH] D128449: [clang] Introduce -Warray-parameter

serge-sans-paille updated this revision to Diff 441530. serge-sans-paille added a comment. Extra test CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128449/new/ https://reviews.llvm.org/D128449 Files: clang/docs/ReleaseNotes.rst clang/include/clang/Basic/DiagnosticGroups.td clang/

[PATCH] D128783: [test] Check for more -fsanitize=array-bounds regressions

serge-sans-paille added inline comments. Comment at: clang/test/CodeGen/bounds-checking-fam.c:59 + // CXX-STRICT-0-NOT: @__ubsan + return p->a[i] + (p->a)[i]; +} Another C++-specific behavior: if the bound results from the substitution of a template parameter,

[PATCH] D128119: [clang] enforce instantiation of constexpr template functions

serge-sans-paille added a comment. gentle ping o/ CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128119/new/ https://reviews.llvm.org/D128119 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listin

[PATCH] D128449: [clang] Introduce -Warray-parameter

serge-sans-paille updated this revision to Diff 442084. serge-sans-paille added a comment. Fix handling of `ConstantArrayType`, thanks @aaron.ballman for the hint. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128449/new/ https://reviews.llvm.org/D128449 Files: clang/docs/ReleaseNote

[PATCH] D128783: [test] Check for more -fsanitize=array-bounds regressions

serge-sans-paille accepted this revision. serge-sans-paille added a comment. I'm fine with these tests has they reflect current implementation. But beware that ubsan and `-Warray-bounds` don't behave the same wrt. FAM, which I find disturbing. I'll discuss that in another review. CHANGES SINCE

[PATCH] D128715: [clang-tidy] Fix confusable identifiers interaction with DeclContext

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG7a550212e8ff: [clang-tidy] Fix confusable identifiers interaction with DeclContext (authored by serge-sans-paille). Changed prior to commit: https

[PATCH] D128715: [clang-tidy] Fix confusable identifiers interaction with DeclContext

serge-sans-paille added a comment. In D128715#3629253 , @thakis wrote: > Looks like this breaks tests on windows: > http://45.33.8.238/win/61559/step_8.txt I'm on it. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.l

[PATCH] D129061: [Lex] Diagnose macro in command lines

serge-sans-paille added a comment. great addition. Missing a test case though, which would probably trigger @aaron.ballman scenario Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129061/new/ https://reviews.llvm.org/D129061 ___

[PATCH] D126864: [clang] Introduce -fstrict-flex-arrays= for stricter handling of flexible arrays

serge-sans-paille updated this revision to Diff 442592. serge-sans-paille added a comment. Herald added a reviewer: NoQ. Do *not* try to syndicate code across different location. Alhtough that would be benefitial to the project, it also makes this patch too complex and controversial because it w

[PATCH] D126864: [clang] Introduce -fstrict-flex-arrays= for stricter handling of flexible arrays

serge-sans-paille added inline comments. Comment at: clang/docs/ClangCommandLineReference.rst:2644 + +Control which arrays are considered as flexible arrays members. +can be 1 (array of size 0, 1 and undefined are considered), 2 (array of size 0 jyknight wrote:

[PATCH] D126864: [clang] Introduce -fstrict-flex-arrays= for stricter handling of flexible arrays

serge-sans-paille updated this revision to Diff 442686. serge-sans-paille edited the summary of this revision. serge-sans-paille added a comment. Take into account @jyknight review. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126864/new/ https://

[PATCH] D126864: [clang] Introduce -fstrict-flex-arrays= for stricter handling of flexible arrays

serge-sans-paille updated this revision to Diff 442692. serge-sans-paille edited the summary of this revision. serge-sans-paille added a comment. Remove debug code CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126864/new/ https://reviews.llvm.org/D126864 Files: clang/docs/ClangComman

[PATCH] D128449: [clang] Introduce -Warray-parameter

serge-sans-paille updated this revision to Diff 442844. serge-sans-paille marked an inline comment as done. serge-sans-paille added a comment. Take review into account. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128449/new/ https://reviews.llvm.org/D128449 Files: clang/docs/Releas

[PATCH] D126864: [clang] Introduce -fstrict-flex-arrays= for stricter handling of flexible arrays

serge-sans-paille updated this revision to Diff 443185. serge-sans-paille marked 4 inline comments as done. serge-sans-paille added a comment. Take reviews into account, basically spreading a lot of FIXME across the codebase :'( Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D128119: [clang] Enforce instantiation of constexpr template functions during non-constexpr evaluation

serge-sans-paille updated this revision to Diff 443230. serge-sans-paille retitled this revision from "[clang] enforce instantiation of constexpr template functions" to "[clang] Enforce instantiation of constexpr template functions during non-constexpr evaluation". serge-sans-paille edited the su

[PATCH] D128119: [clang] Enforce instantiation of constexpr template functions during non-constexpr evaluation

serge-sans-paille added a comment. @shafik: I've implemented your patch which indeed looks closer to the original intent @aaron.ballman : test case and code updated. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128119/new/ https://reviews.llvm.or

[PATCH] D128119: [clang] Enforce instantiation of constexpr template functions during non-constexpr evaluation

serge-sans-paille updated this revision to Diff 443243. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128119/new/ https://reviews.llvm.org/D128119 Files: clang/lib/Sema/SemaTemplateInstantiateDecl.cpp clang/test/CodeGenCXX/constexpr-late-instantiation.cpp clang/test/SemaCXX/constex

[PATCH] D128119: [clang] Enforce instantiation of constexpr template functions during non-constexpr evaluation

serge-sans-paille updated this revision to Diff 443276. serge-sans-paille added a comment. + release note + take review into account Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128119/new/ https://reviews.llvm.org/D128119 Files: clang/docs/Rel

[PATCH] D128119: [clang] Enforce instantiation of constexpr template functions during non-constexpr evaluation

serge-sans-paille updated this revision to Diff 443337. serge-sans-paille added a comment. ++review CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128119/new/ https://reviews.llvm.org/D128119 Files: clang/docs/ReleaseNotes.rst clang/lib/Sema/SemaTemplateInstantiateDecl.cpp clang/t

[PATCH] D128119: [clang] Enforce instantiation of constexpr template functions during non-constexpr evaluation

serge-sans-paille added inline comments. Comment at: clang/docs/ReleaseNotes.rst:184 initializer is not allowed this is now diagnosed as an error. +- Clang now correctly emit symbols for implicitly instanciated constexpr + template function. Fixes `Issue 55560

[PATCH] D128449: [clang] Introduce -Warray-parameter

serge-sans-paille added inline comments. Comment at: clang/lib/Sema/SemaDecl.cpp:3213 +static bool EquivalentArrayTypes(QualType Old, QualType New, + ASTContext const &Ctx) { + aaron.ballman wrote: > East const? MONSTEROUS! ;-) (We

[PATCH] D128449: [clang] Introduce -Warray-parameter

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGcc5b77273af3: [clang] Introduce -Warray-parameter (authored by serge-sans-paille). Changed prior to commit: https://reviews.llvm.org/D128449?vs=44

[PATCH] D128119: [clang] Enforce instantiation of constexpr template functions during non-constexpr evaluation

serge-sans-paille updated this revision to Diff 443459. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128119/new/ https://reviews.llvm.org/D128119 Files: clang/docs/ReleaseNotes.rst clang/lib/Sema/SemaTemplateInstantiateDecl.cpp clang/test/CodeGenCXX/constexpr-late-instantiation.cp

[PATCH] D128119: [clang] Enforce instantiation of constexpr template functions during non-constexpr evaluation

This revision was automatically updated to reflect the committed changes. Closed by commit rGda6a14b91ad9: [clang] Enforce instantiation of constexpr template functions during non… (authored by serge-sans-paille). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.

[PATCH] D122378: Be more explicit about -fvisibility= documentation

serge-sans-paille created this revision. serge-sans-paille added a reviewer: aaron.ballman. Herald added a project: All. serge-sans-paille requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. When in need, I had to look into gcc info page, then

[PATCH] D122378: Be more explicit about -fvisibility= documentation

serge-sans-paille added a comment. thanks for the guidance. I'll check if I can update tablegen to generate possible options then :-) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122378/new/ https://reviews.llvm.org/D122378 _

[PATCH] D122378: [doc] Rely on tblgen to dump supported options value when generating doc

serge-sans-paille updated this revision to Diff 418579. serge-sans-paille retitled this revision from "Be more explicit about -fvisibility= documentation" to "[doc] Rely on tblgen to dump supported options value when generating doc". serge-sans-paille edited the summary of this revision. serge-sa

[PATCH] D122378: [doc] Rely on tblgen to dump supported options value when generating doc

serge-sans-paille updated this revision to Diff 418608. serge-sans-paille added a comment. Minor Options.td nits CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122378/new/ https://reviews.llvm.org/D122378 Files: clang/include/clang/Driver/Options.td llvm/utils/TableGen/OptRSTEmitter

[PATCH] D122378: [doc] Rely on tblgen to dump supported options value when generating doc

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGf5c666742f7b: [doc] Rely on tblgen to dump supported options value when generating doc (authored by serge-sans-paille). Repository: rG LLVM Github

[PATCH] D119996: [safestack] Support safestack in stack size diagnostics

serge-sans-paille added inline comments. Comment at: clang/test/Frontend/stack-usage-safestack.c:1 +/// Check that stack frame size warnings behave the same when safe stack is enabled + I think this should be a bitcode-level test à la test/CodeGen/X86/warn-stack

[PATCH] D103849: Fix undeduced type when instanciating template member

This revision was automatically updated to reflect the committed changes. Closed by commit rG4b219051a331: Fix undeduced type assert (authored by serge-sans-paille). Herald added a project: clang. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103849/

[PATCH] D106093: SubstTemplateTypeParmType can contain an 'auto' type in their replacement type

serge-sans-paille created this revision. serge-sans-paille added reviewers: rsmith, aaron.ballman. Herald added a subscriber: kristof.beyls. serge-sans-paille requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This fixes bug 36064 Repository

[PATCH] D106093: SubstTemplateTypeParmType can contain an 'auto' type in their replacement type

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG8ada884cbc2f: SubstTemplateTypeParmType can contain an 'auto' type in their replacement type (authored by serge-sans-paille). Changed prior to commi

[PATCH] D105594: cmake: Allow shared libraries to customize the soname using LLVM_ABI_REVISION

serge-sans-paille added inline comments. Comment at: clang/tools/clang-shlib/CMakeLists.txt:2 +# In the main branch, LLVM_ABI_REVISION should always be 0. In the release +# branches, this should be incremented before each release candidate every +# time the ABI of libclang-cpp.s

[PATCH] D121592: [clangd] Expose include cleaner interface in clangd

serge-sans-paille created this revision. serge-sans-paille added a reviewer: sammccall. Herald added subscribers: usaxena95, kadircet, arphaman. Herald added a project: All. serge-sans-paille requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald ad

[PATCH] D121593: [clangd][WIP] Provide clang-include-cleaner

serge-sans-paille created this revision. serge-sans-paille added reviewers: kbobyrev, sammccall. Herald added subscribers: usaxena95, kadircet, arphaman, mgorny. Herald added a project: All. serge-sans-paille requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-bi

[PATCH] D123308: Handle a subtle hole in inline builtin handling

serge-sans-paille created this revision. serge-sans-paille added reviewers: nickdesaulniers, aaron.ballman, tstellar. Herald added a project: All. serge-sans-paille requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. When an inline builtin decl

[PATCH] D123308: Handle a subtle hole in inline builtin handling

This revision was automatically updated to reflect the committed changes. Closed by commit rG301e0d91354b: [Clang][Fortify] drop inline decls when redeclared (authored by serge-sans-paille). Changed prior to commit: https://reviews.llvm.org/D123308?vs=421187&id=421438#toc Repository: rG LLVM

[PATCH] D123308: Handle a subtle hole in inline builtin handling

serge-sans-paille added a comment. @nickdesaulniers changes taken into account and pushed, thanks for the review! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123308/new/ https://reviews.llvm.org/D123308 __

[PATCH] D123682: [clang-tblgen] Automatically document options values

serge-sans-paille created this revision. serge-sans-paille added a reviewer: MaskRay. Herald added a subscriber: StephenFan. Herald added a project: All. serge-sans-paille requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This is a port of f5

[PATCH] D123682: [clang-tblgen] Automatically document options values

serge-sans-paille added a comment. @aaron.ballman Any thoughs on the above suggestion? I'd be happy to adopt any of those :-) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123682/new/ https://reviews.llvm.org/D123682 _

[PATCH] D124038: [clang] Prevent folding of non-const compound expr

serge-sans-paille created this revision. serge-sans-paille added a reviewer: aaron.ballman. Herald added a project: All. serge-sans-paille requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. When a non-const compound statement is used to initia

[PATCH] D124038: [clang] Prevent folding of non-const compound expr

serge-sans-paille added a comment. In D124038#3460731 , @efriedma wrote: > The fix doesn't look right. > > A CompoundLiteralExpr is itself an lvalue; we should catch any issues when we > visit it, not a VarDecl that contains a pointer to it. Well, the v

[PATCH] D124038: [clang] Prevent folding of non-const compound expr

serge-sans-paille added a comment. Alternatively, the following also works, but it splits the logic into anotherplace, while current patch is at least consistent with existing state diff --git a/clang/lib/AST/ExprConstant.cpp b/clang/lib/AST/ExprConstant.cpp index 498f0d4..233307f 100644 -

[PATCH] D123682: [clang-tblgen] Automatically document options values

serge-sans-paille updated this revision to Diff 423890. serge-sans-paille marked an inline comment as done. serge-sans-paille added a comment. Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Adopt a better wording. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D123682: [clang-tblgen] Automatically document options values

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGaf7b98c383df: [clang-tblgen] Automatically document options values (authored by serge-sans-paille). Repository: rG LLVM Github Monorepo CHANGES S

[PATCH] D118781: Reduce dependencies on llvm/BinaryFormat/Dwarf.h

serge-sans-paille added a comment. In D118781#3291801 , @MaskRay wrote: > $ clang++ -E -Iinclude -I../llvm/include > ../llvm/lib/Transforms/Scalar/*.cpp -std=c++14 -fno-rtti -fno-exceptions | wc > -l > before: 10978519 > after: 11245451 > > The nu

[PATCH] D118781: Reduce dependencies on llvm/BinaryFormat/Dwarf.h

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGffe8720aa060: Reduce dependencies on llvm/BinaryFormat/Dwarf.h (authored by serge-sans-paille). Repository: rG LLVM Github Monorepo CHANGES SINCE

[PATCH] D126864: [clang] Introduce -fstrict-flex-arrays= for stricter handling of flexible arrays

serge-sans-paille added a comment. @kees are you ok with current state? Comment at: clang/lib/CodeGen/CGExpr.cpp:906 // member, only a T[0] or T[] member gets that treatment. + // Under StrictFlexArraysLevel, obey c99+ that disallows FAM in union, see + // C11

[PATCH] D128449: [clang] Introduce -Warray-parameter

serge-sans-paille added a comment. Thanks for the extra test case! > Do you see an obvious fix? If not, please revert while investigating. Obvious fix landed in 66fa2847a775dda27ddcac3832769441727db42f Repository: rG LLVM

[PATCH] D126864: [clang] Introduce -fstrict-flex-arrays= for stricter handling of flexible arrays

serge-sans-paille added a comment. > I'd like to see the set of concrete examples you cannot otherwise deal with. I'm also very curious, I fail to understand the need of not considering [0] as a FAM, esp. given that to my understanding, this is the only use of that syntax. Repository: rG L

[PATCH] D129797: [clang-tidy] Reduce the dependencies for the "make-confusable-table" tool

serge-sans-paille accepted this revision. serge-sans-paille added a comment. This revision is now accepted and ready to land. I'm fine with this too. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129797/new/ https://reviews.llvm.org/D129797 __

[PATCH] D129798: [clang-tidy] Add a "clang-" namespace prefix to the make-confusable-target executable

serge-sans-paille accepted this revision. serge-sans-paille added a comment. This revision is now accepted and ready to land. LGTM, thanks for doing this. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129798/new/ https://reviews.llvm.org/D129798 _

[PATCH] D126864: [clang] Introduce -fstrict-flex-arrays= for stricter handling of flexible arrays

serge-sans-paille closed this revision. serge-sans-paille added a comment. Forgot the commit tag: just landed it as f764dc99b37e1e6428724a61f36bcb49c015dc70 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D124038: [clang] Prevent folding of non-const compound expr

serge-sans-paille updated this revision to Diff 428042. serge-sans-paille added a comment. Match GCC behavior here: some test case were previously accepted while having the opposite behavior. This pacth both fixes the original issue and adopt gcc behavior. CHANGES SINCE LAST ACTION https://r

[PATCH] D124038: [clang] Prevent folding of non-const compound expr

serge-sans-paille added inline comments. Comment at: clang/lib/AST/ExprConstant.cpp:4267 + bool IsConstant = CLETy.isConstant(Info.Ctx); + if (!IsConstant && CLETy->isArrayType()) { +Info.FFDiag(Conv); efriedma wrote: > Is the "isArrayType()" ch

<    1   2   3   4   5   6   7   8   9   >