[PATCH] D101041: [analyzer] Find better description for tracked symbolic values

vsavchenko created this revision. vsavchenko added reviewers: NoQ, martong, steakhal, xazax.hun. Herald added subscribers: ASDenysPetrov, Charusso, dkrupp, donat.nagy, Szelethus, mikhail.ramalho, a.sidorin, rnkovacs, szepet, baloghadamsoftware. vsavchenko requested review of this revision. Herald

[PATCH] D93630: [Attr] Apply GNU-style attributes to expression statements

vsavchenko added inline comments. Comment at: clang/lib/Parse/ParseStmt.cpp:213 ParsedStmtContext()) && -(GNUAttributeLoc.isValid() || isDeclarationStatement())) { +((GNUAttributeLoc.isValid() && !Attrs.back().isStmtAttr()) || + isDeclaration

[PATCH] D93630: [Attr] Apply GNU-style attributes to expression statements

vsavchenko added a comment. I guess I want to clarify one point here, after this patch the parser **will not assume** that statement always follows statement attributes. We simply turn off the assumption that what follows is a declaration, parser will simply determine whether it is a statement

[PATCH] D93630: [Attr] Apply GNU-style attributes to expression statements

vsavchenko added a comment. In D93630#2479260 , @aaron.ballman wrote: > In D93630#2478977 , @vsavchenko > wrote: > >> I guess I want to clarify one point here, after this patch the parser **will >> not assume** t

[PATCH] D92039: [-Wcalled-once-parameter] Introduce 'called_once' attribute

vsavchenko added inline comments. Comment at: clang/lib/Analysis/CalledOnceCheck.cpp:822 + /// calling the parameter itself, but rather uses it as the argument. + template + void checkIndirectCall(const CallLikeExpr *CallOrMessage) { NoQ wrote: > vsavchenko w

[PATCH] D93630: [Attr] Apply GNU-style attributes to expression statements

vsavchenko added a comment. In D93630#2479757 , @aaron.ballman wrote: > In D93630#2479343 , @vsavchenko > wrote: > >> In D93630#2479260 , @aaron.ballman >> wrote: >> >>> I

[PATCH] D94177: [analyze] Add better support for leaks (and similar diagnostics)

vsavchenko created this revision. vsavchenko added reviewers: NoQ, xazax.hun, jkorous, aaron.ballman, martong, Szelethus, steakhal. Herald added subscribers: Charusso, rnkovacs. vsavchenko requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. In

[PATCH] D94476: [analyzer] Implement conversion from Clang diagnostics to PathDiagnostics.

vsavchenko added inline comments. Comment at: clang/include/clang/Analysis/PathDiagnosticConverterDiagnosticConsumer.h:23 + +class PathDiagnosticConverterDiagnosticConsumer : public DiagnosticConsumer { +public: I think that this class (or file?) needs to have s

[PATCH] D94673: [analyzer][CTU] API for CTU macro expansions

vsavchenko added inline comments. Comment at: clang/include/clang/CrossTU/CrossTranslationUnit.h:186 - /// Determine the original source location in the original TU for an - /// imported source location. + /// Returns the MacroExpansionContext for the imported TU to which th

[PATCH] D93630: [Attr] Apply GNU-style attributes to expression statements

vsavchenko added a comment. In D93630#2490034 , @aaron.ballman wrote: > In D93630#2486574 , @aaron.ballman > wrote: > >> I'm going to see if I can run the patch against our internal corpus here at >> work to see

[PATCH] D93630: [Attr] Apply GNU-style attributes to expression statements

vsavchenko added inline comments. Comment at: clang/test/Parser/stmt-attributes.c:5 + + __attribute__((unknown_attribute));// expected-warning {{unknown attribute 'unknown_attribute' ignored}} + __attribute__((unknown_attribute)) {} // expected-warning {{u

[PATCH] D93630: [Attr] Apply GNU-style attributes to expression statements

vsavchenko added inline comments. Comment at: clang/test/Parser/stmt-attributes.c:5 + + __attribute__((unknown_attribute));// expected-warning {{unknown attribute 'unknown_attribute' ignored}} + __attribute__((unknown_attribute)) {} // expected-warning {{u

[PATCH] D93630: [Attr] Apply GNU-style attributes to expression statements

vsavchenko added a comment. In D93630#2506604 , @aaron.ballman wrote: > In D93630#2504758 , @vsavchenko > wrote: > >> I'll clean up the tests! But, unfortunately, I couldn't proceed with GCC >> folks. I asked a

[PATCH] D93110: [analyzer] Implement a first version of suppressions via attributes

vsavchenko updated this revision to Diff 317805. vsavchenko added a comment. Herald added a subscriber: mgorny. Squash all three commits, introduce new attribute and add documentation. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93110/new/ https:

[PATCH] D93464: [analyzer] Refine suppression mechanism to better support AST checks

vsavchenko abandoned this revision. vsavchenko added a comment. This change was squashed into https://reviews.llvm.org/D93110 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93464/new/ https://reviews.llvm.org/D93464

[PATCH] D94177: [analyze] Add better support for leaks (and similar diagnostics)

vsavchenko abandoned this revision. vsavchenko added a comment. This change was squashed into https://reviews.llvm.org/D93110 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D94177/new/ https://reviews.llvm.org/D94177

[PATCH] D93630: [Attr] Apply GNU-style attributes to expression statements

vsavchenko updated this revision to Diff 318159. vsavchenko added a comment. Add more tests Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93630/new/ https://reviews.llvm.org/D93630 Files: clang/lib/Parse/ParseStmt.cpp clang/test/Parser/stmt-at

[PATCH] D93110: [analyzer] Implement fine-grained suppressions via attributes

vsavchenko updated this revision to Diff 367788. vsavchenko added a comment. Herald added a subscriber: manas. Join 'suppress' and 'analyzer_suppress' attributes. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93110/new/ https://reviews.llvm.org/D93

[PATCH] D93110: [analyzer] Implement fine-grained suppressions via attributes

vsavchenko added a comment. Finally I had a chance to come back to this patch. @aaron.ballman what do you think about it? I tried to address your notes and implemented both features under one attribute. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org

[PATCH] D93110: [analyzer] Implement fine-grained suppressions via attributes

vsavchenko added a comment. @aaron.ballman a gentle ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93110/new/ https://reviews.llvm.org/D93110 ___ cfe-commits mailing list cfe-commits@lists.llvm.org h

<    4   5   6   7   8   9