[PATCH] D70861: [NFCI] update formating for misleading indentation warning

This revision was automatically updated to reflect the committed changes. Closed by commit rG2f9604727526: [NFCI] update formating for misleading indentation warning (authored by Tyker). Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo

[PATCH] D70638: [Diagnostic] add a warning which warns about misleading indentation

Tyker marked 6 inline comments as done. Tyker added a comment. i did a few test on the linux kernel on prior version of this patchs and the mix of spaces and tabs caused some false positives. but i do believe there is still a bug here. for the mix of space and tabs. gcc has a -ftabstop=//X// to

[PATCH] D70638: [Diagnostic] add a warning which warns about misleading indentation

Tyker added a comment. the warning was not affected by -ftabstop. i made a patch that fix this. https://reviews.llvm.org/D71037 and I agree that mixing tabs and space is a horrible idea for many reasons. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.or

[PATCH] D70638: [Diagnostic] add a warning which warns about misleading indentation

Tyker added a comment. i have not tested the performance impact. but i tried to do the heavier checks last to minimize the impact. i added your tests file to the improvement commit. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70638/new/ https://

[PATCH] D63960: [C++20] Add consteval-specific semantic for functions

Tyker added inline comments. Comment at: clang/lib/AST/ExprConstant.cpp:13618 + if (InPlace) { +LValue LVal; +if (!::EvaluateInPlace(Result.Val, Info, LVal, this) || rsmith wrote: > This isn't sufficient: the evaluation process can refer back to the obje

[PATCH] D63960: [C++20] Add consteval-specific semantic for functions

Tyker updated this revision to Diff 232450. Tyker marked 14 inline comments as done. Tyker added a comment. comments were fixed. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63960/new/ https://reviews.llvm.org/D63960 Files: clang/include/clang/AST/Expr.h clang/include/clang/AST/St

[PATCH] D63640: [clang] Improve Serialization/Imporing/Dumping of APValues

Tyker added a comment. now that the issue with uniqueness of expressions is solved. we should be able to keep going on that review @rsmith. https://reviews.llvm.org/D63960 should be i think close to completion. so maybe for testing i could use immediate invocation as a source for ConstantExpr i

[PATCH] D71083: [Diagnsotics] Small Improvement on -Wmisleading-indentation

This revision was automatically updated to reflect the committed changes. Tyker marked an inline comment as done. Closed by commit rG9c8cfa09d762: [Diagnsotics] Small Improvement on -Wmisleading-indentation (authored by Tyker). Herald added a project: clang. Herald added a subscriber: cfe-commits.

[PATCH] D63960: [C++20] Add consteval-specific semantic for functions

Tyker added a comment. ping @rsmith CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63960/new/ https://reviews.llvm.org/D63960 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D76396: Allow immediate invocation of constructors

Tyker added a comment. thanks for the the patch, but I have already a patch aiming to do the same thing. D74007 > Provide improvements which allow the cached values of ConstantExpr to be used > by both the constant evaluator and code gen this is definitely som

[PATCH] D76420: Prevent IR-gen from emitting consteval declarations

Tyker created this revision. Tyker added a reviewer: rsmith. Herald added a project: clang. Herald added a subscriber: cfe-commits. Tyker added a parent revision: D74130: [clang] fix consteval call in default arguements . with this patch instead of emitting calls to consteval function. the IR-gen

[PATCH] D74007: [clang] Add support for consteval constructors

This revision was automatically updated to reflect the committed changes. Closed by commit rG180581cfcf51: [clang] Add support for consteval constructors (authored by Tyker). Herald added a project: clang. Herald added a subscriber: cfe-commits. Changed prior to commit: https://reviews.llvm.org

[PATCH] D63960: [C++20] Add consteval-specific semantic for functions

Tyker added a comment. @aaron.ballman do you think you can review this ? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63960/new/ https://reviews.llvm.org/D63960 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org

[PATCH] D63960: [C++20] Add consteval-specific semantic for functions

Tyker marked 8 inline comments as done. Tyker added a comment. thank you for the review. i am sorry there were so many back and forth. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63960/new/ https://reviews.llvm.org/D63960 ___ cfe-commits

[PATCH] D63960: [C++20] Add consteval-specific semantic for functions

This revision was automatically updated to reflect the committed changes. Closed by commit rG008e7bf92343: [C++20] Add consteval-specific semantic for functions (authored by Tyker). Changed prior to commit: https://reviews.llvm.org/D63960?vs=232450&id=242391#toc Repository: rG LLVM Github Mo

[PATCH] D74130: [clang] fix consteval call in default arguments

Tyker updated this revision to Diff 381416. Tyker added a comment. In D74130#3073271 , @aaron.ballman wrote: > @Tyker -- are you planning to pick this review back up again sometime in the > near future? If not, do you care if the review gets commandeered

<    1   2   3