[clang] [OpenCL] Put constant initializer globals into constant addrspace (PR #90048)

2024-04-29 Thread Sven van Haastregt via cfe-commits
@@ -536,6 +536,8 @@ void AggExprEmitter::EmitArrayInit(Address DestPtr, llvm::ArrayType *AType, CodeGen::CodeGenModule &CGM = CGF.CGM; ConstantEmitter Emitter(CGF); LangAS AS = ArrayQTy.getAddressSpace(); +if (CGF.getLangOpts().OpenCL) + AS = LangAS::openc

[clang] [OpenCL] Put constant initializer globals into constant addrspace (PR #90048)

2024-04-29 Thread Sven van Haastregt via cfe-commits
@@ -536,6 +536,8 @@ void AggExprEmitter::EmitArrayInit(Address DestPtr, llvm::ArrayType *AType, CodeGen::CodeGenModule &CGM = CGF.CGM; ConstantEmitter Emitter(CGF); LangAS AS = ArrayQTy.getAddressSpace(); +if (CGF.getLangOpts().OpenCL) + AS = LangAS::openc

[clang] [OpenCL] Put constant initializer globals into constant addrspace (PR #90048)

2024-04-30 Thread Sven van Haastregt via cfe-commits
https://github.com/svenvh updated https://github.com/llvm/llvm-project/pull/90048 >From c5e7b2d5936a7317ebc33159b4cb72bf2aa66cf9 Mon Sep 17 00:00:00 2001 From: Sven van Haastregt Date: Thu, 25 Apr 2024 14:10:19 +0100 Subject: [PATCH 1/4] [OpenCL] Put constant initializer globals into constant

[clang] [OpenCL] Put constant initializer globals into constant addrspace (PR #90048)

2024-04-30 Thread Sven van Haastregt via cfe-commits
@@ -535,20 +535,24 @@ void AggExprEmitter::EmitArrayInit(Address DestPtr, llvm::ArrayType *AType, elementType.isTriviallyCopyableType(CGF.getContext())) { CodeGen::CodeGenModule &CGM = CGF.CGM; ConstantEmitter Emitter(CGF); -LangAS AS = ArrayQTy.getAddressSpa

[clang] [OpenCL] Put constant initializer globals into constant addrspace (PR #90048)

2024-05-02 Thread Sven van Haastregt via cfe-commits
https://github.com/svenvh closed https://github.com/llvm/llvm-project/pull/90048 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [libclc] [llvm] [openmp] [Clang] `__attribute__((assume))` refactor (PR #84934)

2024-05-08 Thread Sven van Haastregt via cfe-commits
svenvh wrote: The libclc usage seems to have been added by @rjodinchr in https://reviews.llvm.org/D147773 (and approved by @alan-baker). Perhaps they have an opinion? https://github.com/llvm/llvm-project/pull/84934 ___ cfe-commits mailing list cfe-c

[clang] [OpenCL] Add cl_khr_kernel_clock builtins (PR #91950)

2024-05-13 Thread Sven van Haastregt via cfe-commits
https://github.com/svenvh created https://github.com/llvm/llvm-project/pull/91950 Provisional extension description: https://registry.khronos.org/OpenCL/specs/3.0-unified/html/OpenCL_API.html#cl_khr_kernel_clock and https://registry.khronos.org/OpenCL/specs/3.0-unified/html/OpenCL_C.html#kerne

[clang] [libclc] [llvm] [openmp] [Clang] `__attribute__((assume))` refactor (PR #84934)

2024-05-14 Thread Sven van Haastregt via cfe-commits
svenvh wrote: > It allows the source to be parsed, but then I don't see the attribute in the > LLVM IR generated for libclc. You will need to also convert the attribute into an LLVM IR construct (e.g. metadata) in Clang CodeGen. See `CodeGenFunction::EmitKernelMetadata` for inspiration for e

[clang] [OpenCL] Emit opencl.cxx.version metadata for C++ (PR #92140)

2024-05-14 Thread Sven van Haastregt via cfe-commits
https://github.com/svenvh created https://github.com/llvm/llvm-project/pull/92140 Currently there is no way to tell whether an IR module was generated using `-cl-std=cl3.0` or `-cl-std=clc++2021`, i.e., whether the origin was a OpenCL C or C++ for OpenCL source. Add new `opencl.cxx.version` n

[clang] [SPIR-V] Prefer llvm-spirv- tool (PR #77897)

2024-05-16 Thread Sven van Haastregt via cfe-commits
Henry =?utf-8?q?Linjam=C3=A4ki?= Message-ID: In-Reply-To: https://github.com/svenvh approved this pull request. https://github.com/llvm/llvm-project/pull/77897 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/ma

[clang] [OpenCL] Put constant initializer globals into constant addrspace (PR #90048)

2024-05-17 Thread Sven van Haastregt via cfe-commits
@@ -535,20 +535,23 @@ void AggExprEmitter::EmitArrayInit(Address DestPtr, llvm::ArrayType *AType, elementType.isTriviallyCopyableType(CGF.getContext())) { CodeGen::CodeGenModule &CGM = CGF.CGM; ConstantEmitter Emitter(CGF); -LangAS AS = ArrayQTy.getAddressSpa

[clang] [OpenCL] Add cl_khr_kernel_clock builtins (PR #91950)

2024-05-20 Thread Sven van Haastregt via cfe-commits
https://github.com/svenvh closed https://github.com/llvm/llvm-project/pull/91950 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [SPIR-V] Prefer llvm-spirv- tool (PR #77897)

2024-05-24 Thread Sven van Haastregt via cfe-commits
Henry =?utf-8?q?Linjamäki?= Message-ID: In-Reply-To: svenvh wrote: > Thanks for the review. Could you merge this PR on my behalf (I don't have > write access)? Yes I am happy to do so, but would you mind rebasing this PR onto latest `main` first? Just so that the checks can run again to av

[clang] 91a0b46 - [OpenCL] Make read_write images optional for -fdeclare-opencl-builtins

2022-01-25 Thread Sven van Haastregt via cfe-commits
Author: Sven van Haastregt Date: 2022-01-25T11:40:31Z New Revision: 91a0b464a853821734db8b1c521df03f8e2e56e7 URL: https://github.com/llvm/llvm-project/commit/91a0b464a853821734db8b1c521df03f8e2e56e7 DIFF: https://github.com/llvm/llvm-project/commit/91a0b464a853821734db8b1c521df03f8e2e56e7.diff

[clang] 35fff20 - [OpenCL] opencl-c.h: add missing read_write image guards

2022-01-27 Thread Sven van Haastregt via cfe-commits
Author: Sven van Haastregt Date: 2022-01-27T10:33:12Z New Revision: 35fff208cad6f271410800998447dc0dd2704085 URL: https://github.com/llvm/llvm-project/commit/35fff208cad6f271410800998447dc0dd2704085 DIFF: https://github.com/llvm/llvm-project/commit/35fff208cad6f271410800998447dc0dd2704085.diff

[clang] bfd8210 - [OpenCL] opencl-c.h: refactor named addrspace builtins

2022-01-28 Thread Sven van Haastregt via cfe-commits
Author: Sven van Haastregt Date: 2022-01-28T10:24:47Z New Revision: bfd8210f6f470d79a78f57ebe02650bbb5a79129 URL: https://github.com/llvm/llvm-project/commit/bfd8210f6f470d79a78f57ebe02650bbb5a79129 DIFF: https://github.com/llvm/llvm-project/commit/bfd8210f6f470d79a78f57ebe02650bbb5a79129.diff

[clang] 8e60992 - [OpenCL] Make generic addrspace optional for -fdeclare-opencl-builtins

2022-01-31 Thread Sven van Haastregt via cfe-commits
Author: Sven van Haastregt Date: 2022-01-31T10:21:05Z New Revision: 8e6099291dcb49b90e59a591ec24c77f348239b6 URL: https://github.com/llvm/llvm-project/commit/8e6099291dcb49b90e59a591ec24c77f348239b6 DIFF: https://github.com/llvm/llvm-project/commit/8e6099291dcb49b90e59a591ec24c77f348239b6.diff

[clang] e0e6f3a - [OpenCL] Test -fdeclare-opencl-builtins with CL3 and CLC++2021

2022-02-02 Thread Sven van Haastregt via cfe-commits
Author: Sven van Haastregt Date: 2022-02-02T10:23:02Z New Revision: e0e6f3a6a2e13ee11b014ca45a48997e78d3efc5 URL: https://github.com/llvm/llvm-project/commit/e0e6f3a6a2e13ee11b014ca45a48997e78d3efc5 DIFF: https://github.com/llvm/llvm-project/commit/e0e6f3a6a2e13ee11b014ca45a48997e78d3efc5.diff

[clang] e7e17b3 - [OpenCL] opencl-c.h: use uint/ulong consistently

2022-02-22 Thread Sven van Haastregt via cfe-commits
Author: Sven van Haastregt Date: 2022-02-22T10:15:40Z New Revision: e7e17b30d02d4f0035fef92850d529f16849c6f0 URL: https://github.com/llvm/llvm-project/commit/e7e17b30d02d4f0035fef92850d529f16849c6f0 DIFF: https://github.com/llvm/llvm-project/commit/e7e17b30d02d4f0035fef92850d529f16849c6f0.diff

[clang] aa9c2d1 - [OpenCL] Align subgroup builtin guards

2022-02-23 Thread Sven van Haastregt via cfe-commits
Author: Sven van Haastregt Date: 2022-02-23T12:22:09Z New Revision: aa9c2d19d9b73589d72114d6e0a4fb4ce42b922b URL: https://github.com/llvm/llvm-project/commit/aa9c2d19d9b73589d72114d6e0a4fb4ce42b922b DIFF: https://github.com/llvm/llvm-project/commit/aa9c2d19d9b73589d72114d6e0a4fb4ce42b922b.diff

[clang] 88182e2 - [OpenCL] opencl-c.h: remove arg names for image builtins

2022-02-24 Thread Sven van Haastregt via cfe-commits
Author: Sven van Haastregt Date: 2022-02-24T11:52:32Z New Revision: 88182e2dfde295a8f6adc9e6148410e86c71680d URL: https://github.com/llvm/llvm-project/commit/88182e2dfde295a8f6adc9e6148410e86c71680d DIFF: https://github.com/llvm/llvm-project/commit/88182e2dfde295a8f6adc9e6148410e86c71680d.diff

[clang] 28cdcf8 - [OpenCL] Handle TypeExtensions in OpenCLBuiltinFileEmitter

2022-02-24 Thread Sven van Haastregt via cfe-commits
Author: Sven van Haastregt Date: 2022-02-24T15:17:24Z New Revision: 28cdcf8e3c8e6c51d42051b54f67c6920b5d8cf3 URL: https://github.com/llvm/llvm-project/commit/28cdcf8e3c8e6c51d42051b54f67c6920b5d8cf3 DIFF: https://github.com/llvm/llvm-project/commit/28cdcf8e3c8e6c51d42051b54f67c6920b5d8cf3.diff

[clang-tools-extra] ba18c36 - [clang-tidy] Remove opencl-c.h inclusion from tests

2022-02-24 Thread Sven van Haastregt via cfe-commits
Author: Sven van Haastregt Date: 2022-02-24T16:28:52Z New Revision: ba18c360b2f3c25fe9091c7a7931eded374b3cf6 URL: https://github.com/llvm/llvm-project/commit/ba18c360b2f3c25fe9091c7a7931eded374b3cf6 DIFF: https://github.com/llvm/llvm-project/commit/ba18c360b2f3c25fe9091c7a7931eded374b3cf6.diff

[clang] b48e3c8 - [OpenCL] opencl-c.h: Fix incorrect get_image_width guard

2022-02-25 Thread Sven van Haastregt via cfe-commits
Author: Sven van Haastregt Date: 2022-02-25T11:05:56Z New Revision: b48e3c805c253d0a1194bede81b3f8e225f40824 URL: https://github.com/llvm/llvm-project/commit/b48e3c805c253d0a1194bede81b3f8e225f40824 DIFF: https://github.com/llvm/llvm-project/commit/b48e3c805c253d0a1194bede81b3f8e225f40824.diff

[clang] 4138e7b - [OpenCL] Add missing C++ legacy atomics with generic

2021-04-22 Thread Sven van Haastregt via cfe-commits
Author: Sven van Haastregt Date: 2021-04-22T15:08:36+01:00 New Revision: 4138e7bd7692c27a4959191939bba899b4f240da URL: https://github.com/llvm/llvm-project/commit/4138e7bd7692c27a4959191939bba899b4f240da DIFF: https://github.com/llvm/llvm-project/commit/4138e7bd7692c27a4959191939bba899b4f240da.

[clang] 18772de - [OpenCL] Add inc/dec/cmpxchg C++ legacy atomics with generic

2021-04-26 Thread Sven van Haastregt via cfe-commits
Author: Sven van Haastregt Date: 2021-04-26T09:46:11+01:00 New Revision: 18772de1ecb1a23b483e29987ae708ab641b1134 URL: https://github.com/llvm/llvm-project/commit/18772de1ecb1a23b483e29987ae708ab641b1134 DIFF: https://github.com/llvm/llvm-project/commit/18772de1ecb1a23b483e29987ae708ab641b1134.

[clang] 37bc1dc - [NFC] Workaround MSVC2019 32-bit compiler crash

2021-04-27 Thread Sven van Haastregt via cfe-commits
Author: Sven van Haastregt Date: 2021-04-27T11:15:47+01:00 New Revision: 37bc1dc9877fc480493c85c6d02709b3015bb5e8 URL: https://github.com/llvm/llvm-project/commit/37bc1dc9877fc480493c85c6d02709b3015bb5e8 DIFF: https://github.com/llvm/llvm-project/commit/37bc1dc9877fc480493c85c6d02709b3015bb5e8.

[clang] 4b14fc6 - [SPIR-V] Drop double quote from test pattern

2022-01-11 Thread Sven van Haastregt via cfe-commits
Author: Sven van Haastregt Date: 2022-01-11T16:58:08Z New Revision: 4b14fc6fe5a7d01fb42a3cdede77c59f03b867af URL: https://github.com/llvm/llvm-project/commit/4b14fc6fe5a7d01fb42a3cdede77c59f03b867af DIFF: https://github.com/llvm/llvm-project/commit/4b14fc6fe5a7d01fb42a3cdede77c59f03b867af.diff

[clang] 4b85800 - [OpenCL] Set external linkage for block enqueue kernels

2022-01-12 Thread Sven van Haastregt via cfe-commits
Author: Sven van Haastregt Date: 2022-01-12T13:30:09Z New Revision: 4b85800bfd6ca6c3ecedf68ffbba6c3f2bc9c8ae URL: https://github.com/llvm/llvm-project/commit/4b85800bfd6ca6c3ecedf68ffbba6c3f2bc9c8ae DIFF: https://github.com/llvm/llvm-project/commit/4b85800bfd6ca6c3ecedf68ffbba6c3f2bc9c8ae.diff

[clang] c5c4a88 - [OpenCL] Remove spurious atomic_fetch tablegen builtins

2021-03-18 Thread Sven van Haastregt via cfe-commits
Author: Sven van Haastregt Date: 2021-03-18T12:17:12Z New Revision: c5c4a88a840037fd38cb35d5efd524d51dcc091b URL: https://github.com/llvm/llvm-project/commit/c5c4a88a840037fd38cb35d5efd524d51dcc091b DIFF: https://github.com/llvm/llvm-project/commit/c5c4a88a840037fd38cb35d5efd524d51dcc091b.diff

[clang] 20d9326 - [OpenCL] Use -fdeclare-opencl-builtins for some tests

2021-03-22 Thread Sven van Haastregt via cfe-commits
Author: Sven van Haastregt Date: 2021-03-22T09:46:28Z New Revision: 20d93267e18463292d54791f3c19211a85b27227 URL: https://github.com/llvm/llvm-project/commit/20d93267e18463292d54791f3c19211a85b27227 DIFF: https://github.com/llvm/llvm-project/commit/20d93267e18463292d54791f3c19211a85b27227.diff

[clang] 2bbc9bc - [OpenCL] Support template parameters for as_type

2021-03-22 Thread Sven van Haastregt via cfe-commits
Author: Sven van Haastregt Date: 2021-03-22T11:59:05Z New Revision: 2bbc9bccf095b92b3ed1ab9669fab8a7dc96ee6d URL: https://github.com/llvm/llvm-project/commit/2bbc9bccf095b92b3ed1ab9669fab8a7dc96ee6d DIFF: https://github.com/llvm/llvm-project/commit/2bbc9bccf095b92b3ed1ab9669fab8a7dc96ee6d.diff

[clang] 1c6521a - [OpenCL] Remove mixed signedness atomic_fetch_ from opencl-c.h

2021-03-23 Thread Sven van Haastregt via cfe-commits
Author: Sven van Haastregt Date: 2021-03-23T10:20:13Z New Revision: 1c6521a0ddfabb9c451f57164369e49b2826ee6d URL: https://github.com/llvm/llvm-project/commit/1c6521a0ddfabb9c451f57164369e49b2826ee6d DIFF: https://github.com/llvm/llvm-project/commit/1c6521a0ddfabb9c451f57164369e49b2826ee6d.diff

[clang] 8fbfc92 - Reuse `os` variable in AllocateTarget; NFC

2021-03-25 Thread Sven van Haastregt via cfe-commits
Author: Sven van Haastregt Date: 2021-03-25T14:38:02Z New Revision: 8fbfc92a5cef5e709ca47742e7bf11035607abcc URL: https://github.com/llvm/llvm-project/commit/8fbfc92a5cef5e709ca47742e7bf11035607abcc DIFF: https://github.com/llvm/llvm-project/commit/8fbfc92a5cef5e709ca47742e7bf11035607abcc.diff

[clang] b5995fc - [OpenCL] Limit popcount to OpenCL 1.2 and above

2021-03-31 Thread Sven van Haastregt via cfe-commits
Author: Sven van Haastregt Date: 2021-03-31T09:54:18+01:00 New Revision: b5995fced41de0885a5ef8f1b8a25ef45d8be711 URL: https://github.com/llvm/llvm-project/commit/b5995fced41de0885a5ef8f1b8a25ef45d8be711 DIFF: https://github.com/llvm/llvm-project/commit/b5995fced41de0885a5ef8f1b8a25ef45d8be711.

[clang] 35bc756 - [OpenCL] Add as_size/ptrdiff/intptr/uintptr_t operators

2021-04-07 Thread Sven van Haastregt via cfe-commits
Author: Sven van Haastregt Date: 2021-04-07T10:16:41+01:00 New Revision: 35bc7569f8ad8e76d36560386bbc45ca40716410 URL: https://github.com/llvm/llvm-project/commit/35bc7569f8ad8e76d36560386bbc45ca40716410 DIFF: https://github.com/llvm/llvm-project/commit/35bc7569f8ad8e76d36560386bbc45ca40716410.

[clang] 8fcb114 - [OpenCL] Fix mipmap read_image return types

2021-04-08 Thread Sven van Haastregt via cfe-commits
Author: Sven van Haastregt Date: 2021-04-08T09:51:44+01:00 New Revision: 8fcb114d002bf7cd61309af80b26af68389944d0 URL: https://github.com/llvm/llvm-project/commit/8fcb114d002bf7cd61309af80b26af68389944d0 DIFF: https://github.com/llvm/llvm-project/commit/8fcb114d002bf7cd61309af80b26af68389944d0.

[clang] af67deb - [OpenCL] Simplify InsertOCLBuiltinDeclarationsFromTable

2021-04-09 Thread Sven van Haastregt via cfe-commits
Author: Sven van Haastregt Date: 2021-04-09T11:54:15+01:00 New Revision: af67deb005cae4e87109d8ad534446b300351483 URL: https://github.com/llvm/llvm-project/commit/af67deb005cae4e87109d8ad534446b300351483 DIFF: https://github.com/llvm/llvm-project/commit/af67deb005cae4e87109d8ad534446b300351483.

[clang] 731bf28 - [OpenCL] Accept .rgba in OpenCL 3.0

2021-04-12 Thread Sven van Haastregt via cfe-commits
Author: Sven van Haastregt Date: 2021-04-12T09:30:06+01:00 New Revision: 731bf28a6092286dde6972803b35c026e32bd6b1 URL: https://github.com/llvm/llvm-project/commit/731bf28a6092286dde6972803b35c026e32bd6b1 DIFF: https://github.com/llvm/llvm-project/commit/731bf28a6092286dde6972803b35c026e32bd6b1.

[clang] b757bc1 - [OpenCL][NFC] Rename isOpenCLVersionContainedInMask

2021-04-13 Thread Sven van Haastregt via cfe-commits
Author: Sven van Haastregt Date: 2021-04-13T10:27:37+01:00 New Revision: b757bc14e673c8f8b987cadfe165853fb3de10f1 URL: https://github.com/llvm/llvm-project/commit/b757bc14e673c8f8b987cadfe165853fb3de10f1 DIFF: https://github.com/llvm/llvm-project/commit/b757bc14e673c8f8b987cadfe165853fb3de10f1.

[clang] 856c49d - [OpenCL][Docs] Update OpenCL 3.0 implementation status

2021-04-14 Thread Sven van Haastregt via cfe-commits
Author: Sven van Haastregt Date: 2021-04-14T13:56:26+01:00 New Revision: 856c49d79c0d717fb3e9ff6deebfe740a4f752e2 URL: https://github.com/llvm/llvm-project/commit/856c49d79c0d717fb3e9ff6deebfe740a4f752e2 DIFF: https://github.com/llvm/llvm-project/commit/856c49d79c0d717fb3e9ff6deebfe740a4f752e2.

[clang] 6cb7631 - [OpenCL] Change OpenCL builtin version encoding

2021-04-19 Thread Sven van Haastregt via cfe-commits
Author: Sven van Haastregt Date: 2021-04-19T10:23:13+01:00 New Revision: 6cb7631df348a0fa8bb64c518d47838525f4a40b URL: https://github.com/llvm/llvm-project/commit/6cb7631df348a0fa8bb64c518d47838525f4a40b DIFF: https://github.com/llvm/llvm-project/commit/6cb7631df348a0fa8bb64c518d47838525f4a40b.

[clang] fdcb9c2 - [OpenCL] Refactor shuffle builtin decls

2021-04-21 Thread Sven van Haastregt via cfe-commits
Author: Sven van Haastregt Date: 2021-04-21T11:59:24+01:00 New Revision: fdcb9c272899fc270bd9bd067dc20363f54ff190 URL: https://github.com/llvm/llvm-project/commit/fdcb9c272899fc270bd9bd067dc20363f54ff190 DIFF: https://github.com/llvm/llvm-project/commit/fdcb9c272899fc270bd9bd067dc20363f54ff190.

[clang] e2b3b89 - [OpenCL] Do not add builtins with unavailable types

2021-04-21 Thread Sven van Haastregt via cfe-commits
Author: Sven van Haastregt Date: 2021-04-21T11:59:29+01:00 New Revision: e2b3b89bf1ce74bf889897e0353a3e3fa93e4452 URL: https://github.com/llvm/llvm-project/commit/e2b3b89bf1ce74bf889897e0353a3e3fa93e4452 DIFF: https://github.com/llvm/llvm-project/commit/e2b3b89bf1ce74bf889897e0353a3e3fa93e4452.

[clang] 0e4d236 - [OpenCL] Warn about side effects for unevaluated vec_step arg

2021-01-05 Thread Sven van Haastregt via cfe-commits
Author: Sven van Haastregt Date: 2021-01-05T11:51:10Z New Revision: 0e4d2361b817bd16f97cd45d5792017edc3891ee URL: https://github.com/llvm/llvm-project/commit/0e4d2361b817bd16f97cd45d5792017edc3891ee DIFF: https://github.com/llvm/llvm-project/commit/0e4d2361b817bd16f97cd45d5792017edc3891ee.diff

[clang] 29d375f - [OpenCL][NFC] Improve OpenCL test file naming

2021-01-06 Thread Sven van Haastregt via cfe-commits
Author: Sven van Haastregt Date: 2021-01-06T14:16:44Z New Revision: 29d375f5ff27dc49c2c88c2ec1093cfcd826d449 URL: https://github.com/llvm/llvm-project/commit/29d375f5ff27dc49c2c88c2ec1093cfcd826d449 DIFF: https://github.com/llvm/llvm-project/commit/29d375f5ff27dc49c2c88c2ec1093cfcd826d449.diff

[clang] 7c77b53 - [OpenCL] Improve OpenCL operator tests

2021-01-13 Thread Sven van Haastregt via cfe-commits
Author: Sven van Haastregt Date: 2021-01-13T14:50:49Z New Revision: 7c77b536efdd953d6d97bffbd9ca320c517b26d7 URL: https://github.com/llvm/llvm-project/commit/7c77b536efdd953d6d97bffbd9ca320c517b26d7 DIFF: https://github.com/llvm/llvm-project/commit/7c77b536efdd953d6d97bffbd9ca320c517b26d7.diff

[clang] 544d89e - [OpenCL] Add atomic_half type builtins

2021-10-12 Thread Sven van Haastregt via cfe-commits
Author: Sven van Haastregt Date: 2021-10-12T10:45:30+01:00 New Revision: 544d89e847d42ce8856296752b0fb279aa89aace URL: https://github.com/llvm/llvm-project/commit/544d89e847d42ce8856296752b0fb279aa89aace DIFF: https://github.com/llvm/llvm-project/commit/544d89e847d42ce8856296752b0fb279aa89aace.

[clang] f45d740 - [docs] Fix hyperlink

2021-10-20 Thread Sven van Haastregt via cfe-commits
Author: Sven van Haastregt Date: 2021-10-20T10:20:17+01:00 New Revision: f45d7407168d08c4d80216ca13feb1e1c21ad6bb URL: https://github.com/llvm/llvm-project/commit/f45d7407168d08c4d80216ca13feb1e1c21ad6bb DIFF: https://github.com/llvm/llvm-project/commit/f45d7407168d08c4d80216ca13feb1e1c21ad6bb.

[clang] d353d1c - [OpenCL] Support cl_ext_float_atomics

2021-09-13 Thread Sven van Haastregt via cfe-commits
Author: Sven van Haastregt Date: 2021-09-13T12:12:40+01:00 New Revision: d353d1c50112a1cb315eccdab18ce7bd1563cd06 URL: https://github.com/llvm/llvm-project/commit/d353d1c50112a1cb315eccdab18ce7bd1563cd06 DIFF: https://github.com/llvm/llvm-project/commit/d353d1c50112a1cb315eccdab18ce7bd1563cd06.

[clang] Reject half vector types without cl_khr_fp16 (PR #96640)

2024-06-25 Thread Sven van Haastregt via cfe-commits
https://github.com/svenvh created https://github.com/llvm/llvm-project/pull/96640 Reject `half` vector types (`halfn`) if the `cl_khr_fp16` extension is disabled, in line with the already existing rejection of `half` scalar types and `half` array types. >From e26114f1aa6809e7b5f93f4e866e7ff25

[clang] [OpenCL] Restore addrspacecast for pipe builtins and update test (PR #112514)

2024-10-16 Thread Sven van Haastregt via cfe-commits
https://github.com/svenvh created https://github.com/llvm/llvm-project/pull/112514 Commit 84ee629bc515 ("clang: Remove some pointer bitcasts (#112324)", 2024-10-15) triggered some "Call parameter type does not match function signature!" errors when using the OpenCL pipe builtin functions under

[clang] [OpenCL] Restore addrspacecast for pipe builtins and update test (PR #112514)

2024-10-16 Thread Sven van Haastregt via cfe-commits
@@ -1,69 +1,67 @@ -// RUN: %clang_cc1 -triple %itanium_abi_triple -emit-llvm -cl-ext=+cl_khr_subgroups -O0 -cl-std=clc++ -o - %s | FileCheck %s -// FIXME: Add MS ABI manglings of OpenCL things and remove %itanium_abi_triple svenvh wrote: Surely I can add the old

[clang] [OpenCL] Restore addrspacecast for pipe builtins and update test (PR #112514)

2024-10-16 Thread Sven van Haastregt via cfe-commits
https://github.com/svenvh closed https://github.com/llvm/llvm-project/pull/112514 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [OpenCL] Add cl_ext_image_unorm_int_2_101010_EXT extension (PR #113145)

2024-10-21 Thread Sven van Haastregt via cfe-commits
svenvh wrote: Extension specification: https://github.com/KhronosGroup/OpenCL-Docs/pull/1223 https://github.com/llvm/llvm-project/pull/113145 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-co

[clang] [OpenCL] Add cl_ext_image_unorm_int_2_101010_EXT extension (PR #113145)

2024-10-21 Thread Sven van Haastregt via cfe-commits
https://github.com/svenvh created https://github.com/llvm/llvm-project/pull/113145 Add the defines for the `cl_ext_image_unorm_int_2_101010_EXT` extension. >From 168a54775bb876094fe90ef89cab66b8cc08e4f3 Mon Sep 17 00:00:00 2001 From: Sven van Haastregt Date: Mon, 21 Oct 2024 11:19:13 +0100 Sub

[clang] [OpenCL] Replace a CreatePointerCast call; NFC (PR #112676)

2024-10-17 Thread Sven van Haastregt via cfe-commits
https://github.com/svenvh created https://github.com/llvm/llvm-project/pull/112676 With opaque pointers, the only purpose of the cast here is to cast between address spaces, similar to the 4-argument case below. >From 7dff616c6cd8ffb2c58e26132370f9329a0bf4cd Mon Sep 17 00:00:00 2001 From: Sven

[clang] [OpenCL] Replace a CreatePointerCast call; NFC (PR #112676)

2024-10-18 Thread Sven van Haastregt via cfe-commits
https://github.com/svenvh closed https://github.com/llvm/llvm-project/pull/112676 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [OpenCL] Diagnose block references in selection operator (PR #114824)

2024-11-04 Thread Sven van Haastregt via cfe-commits
https://github.com/svenvh created https://github.com/llvm/llvm-project/pull/114824 In addition to the invocation case that is already diagnosed, also diagnose when a block reference appears on either side of a ternary selection operator. >From 386b891dce07f37d3b886008f42160e7224f6e4c Mon Sep 1

[clang] [OpenCL] Diagnose block references in selection operator (PR #114824)

2024-11-04 Thread Sven van Haastregt via cfe-commits
https://github.com/svenvh edited https://github.com/llvm/llvm-project/pull/114824 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [TableGen] Avoid repeated hash lookups (NFC) (PR #109372)

2024-09-20 Thread Sven van Haastregt via cfe-commits
https://github.com/svenvh approved this pull request. https://github.com/llvm/llvm-project/pull/109372 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][bytecode] Not all null pointers are 0 (PR #118601)

2024-12-04 Thread Sven van Haastregt via cfe-commits
@@ -0,0 +1,12 @@ +// RUN: %clang_cc1 -no-enable-noundef-analysis %s -cl-std=CL2.0 -include opencl-c.h -triple amdgcn -emit-llvm -o - | FileCheck %s svenvh wrote: I don't think you need the `-include opencl-c.h` for this test? (it's rather big, so slows down tes

[clang] [clang][bytecode] Not all null pointers are 0 (PR #118601)

2024-12-04 Thread Sven van Haastregt via cfe-commits
https://github.com/svenvh commented: LGTM, but I'm not an expert in this area so I'll leave the formal approval to someone else. https://github.com/llvm/llvm-project/pull/118601 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llv

[clang] [Driver][SPIR-V] Use consistent tools to convert between text and binary form (PR #120266)

2025-01-08 Thread Sven van Haastregt via cfe-commits
https://github.com/svenvh requested changes to this pull request. Thanks for drawing this to my attention! The output produced by llvm-spirv's `-to-text` is an internal textual format, intended for testing llvm-spirv only (@MrSidims please correct me if I'm wrong). I don't think we should be

[clang] 9cdb7d2 - [NFC] Maintainers.rst: align email address formatting

2024-12-11 Thread Sven van Haastregt via cfe-commits
Author: Sven van Haastregt Date: 2024-12-11T08:51:44Z New Revision: 9cdb7d2b6c333874ec969ef6ac64e0354bb3aa91 URL: https://github.com/llvm/llvm-project/commit/9cdb7d2b6c333874ec969ef6ac64e0354bb3aa91 DIFF: https://github.com/llvm/llvm-project/commit/9cdb7d2b6c333874ec969ef6ac64e0354bb3aa91.diff

[clang] Nominating Sven van Haastregt as OpenCL maintainer in Clang (PR #119383)

2024-12-10 Thread Sven van Haastregt via cfe-commits
https://github.com/svenvh approved this pull request. Sorry to see you stepping down, thank you for all your contributions over the years! Thanks for the nomination, I gladly accept. https://github.com/llvm/llvm-project/pull/119383 ___ cfe-commits ma

[clang] [OpenCL] Diagnose block references in selection operator (PR #114824)

2025-01-21 Thread Sven van Haastregt via cfe-commits
https://github.com/svenvh updated https://github.com/llvm/llvm-project/pull/114824 >From 20c2eacae61d245384db226d3dfe53628b4b2ba8 Mon Sep 17 00:00:00 2001 From: Sven van Haastregt Date: Mon, 4 Nov 2024 13:36:04 + Subject: [PATCH] [OpenCL] Diagnose block references in selection operator In

[clang] [OpenCL] Diagnose block references in selection operator (PR #114824)

2025-01-22 Thread Sven van Haastregt via cfe-commits
https://github.com/svenvh closed https://github.com/llvm/llvm-project/pull/114824 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][Driver][SPIR-V] Make tool names consistent (PR #122343)

2025-01-10 Thread Sven van Haastregt via cfe-commits
https://github.com/svenvh approved this pull request. LGTM, thanks; good to see consistent naming! https://github.com/llvm/llvm-project/pull/122343 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/

[clang] [Driver][SPIR-V] Use consistent tools to convert between text and binary form (PR #120266)

2025-01-09 Thread Sven van Haastregt via cfe-commits
https://github.com/svenvh approved this pull request. https://github.com/llvm/llvm-project/pull/120266 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang][OpenCL] Fix wait_for_event argument address space with -fdeclare-opencl-builtins (PR #134598)

2025-04-07 Thread Sven van Haastregt via cfe-commits
https://github.com/svenvh approved this pull request. LGTM, thanks for the fix! https://github.com/llvm/llvm-project/pull/134598 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [OpenCL] Add test for __kernel_exec macro (PR #138287)

2025-05-05 Thread Sven van Haastregt via cfe-commits
https://github.com/svenvh closed https://github.com/llvm/llvm-project/pull/138287 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [OpenCL] Add test for __kernel_exec macro (PR #138287)

2025-05-02 Thread Sven van Haastregt via cfe-commits
https://github.com/svenvh created https://github.com/llvm/llvm-project/pull/138287 The `__kernel_exec` macro is mandated by the OpenCL C specification and supplied by `opencl-c-base.h`, but it was not covered in any tests. Rate limit · GitHub body {

[clang] [clang][SPIR-V] Use the SPIR-V backend by default (PR #129545)

2025-03-07 Thread Sven van Haastregt via cfe-commits
https://github.com/svenvh approved this pull request. https://github.com/llvm/llvm-project/pull/129545 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang] Add support for missing OpenCL extensions (PR #129777)

2025-03-06 Thread Sven van Haastregt via cfe-commits
svenvh wrote: > When someone passes the `-Xclang -cl-ext=+all`, the compiler should add > defines for all the supported extensions. Indeed; we already have such a list in `opencl-c-base.h` to enable all header-only extensions for the `spir`/`spirv` targets, so it should be easy to make `-cl-e

[clang] [HLSL] error on out of bounds vector accesses (PR #128952)

2025-02-27 Thread Sven van Haastregt via cfe-commits
@@ -14017,6 +14017,24 @@ void Sema::CheckCastAlign(Expr *Op, QualType T, SourceRange TRange) { << TRange << Op->getSourceRange(); } +void Sema::CheckVectorAccess(const Expr *BaseExpr, const Expr *IndexExpr) { + const VectorType *VTy = BaseExpr->getType()->getAs(); + if

[clang] [Clang] Add support for missing OpenCL extensions (PR #129777)

2025-03-05 Thread Sven van Haastregt via cfe-commits
https://github.com/svenvh requested changes to this pull request. What is the motivation for this change? We are trying to move away from adding extensions to this file for extensions that only add builtin functions, see e.g. https://reviews.llvm.org/D92231 . What functionality are you gainin

[clang] clang: Do not implicitly addrspacecast in EmitAggExprToLValue (PR #129837)

2025-03-05 Thread Sven van Haastregt via cfe-commits
https://github.com/svenvh approved this pull request. https://github.com/llvm/llvm-project/pull/129837 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [HLSL] error on out of bounds vector accesses (PR #128952)

2025-03-05 Thread Sven van Haastregt via cfe-commits
@@ -14017,6 +14017,24 @@ void Sema::CheckCastAlign(Expr *Op, QualType T, SourceRange TRange) { << TRange << Op->getSourceRange(); } +void Sema::CheckVectorAccess(const Expr *BaseExpr, const Expr *IndexExpr) { + const VectorType *VTy = BaseExpr->getType()->getAs(); + if

[clang] [Clang] Add support for missing OpenCL extensions (PR #129777)

2025-03-05 Thread Sven van Haastregt via cfe-commits
svenvh wrote: > @svenvh, I'm trying to unify the extensions enablement in the user interface. > We can enable or disable some of the extensions with the `-Xclang > -cl-ext=+extension` command line options. For example, a user can pass > `-Xclang -cl-ext=+cl_khr_subgroups` successfully, but the

[clang] [OpenCL] Add cl_ext_image_unsigned_10x6_12x4_14x2 extension (PR #134216)

2025-04-03 Thread Sven van Haastregt via cfe-commits
svenvh wrote: Extension specification: https://github.com/KhronosGroup/OpenCL-Docs/pull/1352 https://github.com/llvm/llvm-project/pull/134216 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-co

[clang] [OpenCL] Add cl_ext_image_unsigned_10x6_12x4_14x2 extension (PR #134216)

2025-04-03 Thread Sven van Haastregt via cfe-commits
https://github.com/svenvh created https://github.com/llvm/llvm-project/pull/134216 Add the defines for the `cl_ext_image_unsigned_10x6_12x4_14x2` extension. >From f55b84bcd1f324f1b7a316cee049d21ea65dd41e Mon Sep 17 00:00:00 2001 From: Sven van Haastregt Date: Thu, 3 Apr 2025 09:15:22 +0100 Sub

[clang] [OpenCL] No need to check array of struct for kernel arguments (PR #138894)

2025-05-13 Thread Sven van Haastregt via cfe-commits
https://github.com/svenvh approved this pull request. LGTM, thanks! https://github.com/llvm/llvm-project/pull/138894 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [OpenCL] No need to check array of struct for kernel arguments (PR #138894)

2025-05-23 Thread Sven van Haastregt via cfe-commits
https://github.com/svenvh closed https://github.com/llvm/llvm-project/pull/138894 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [OpenCL] No need to check array of struct for kernel arguments (PR #138894)

2025-05-23 Thread Sven van Haastregt via cfe-commits
svenvh wrote: Merged now, thanks for your contribution! https://github.com/llvm/llvm-project/pull/138894 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [NVPTX] Support the OpenCL generic addrspace feature by default (PR #137940)

2025-05-21 Thread Sven van Haastregt via cfe-commits
@@ -170,6 +170,8 @@ class LLVM_LIBRARY_VISIBILITY NVPTXTargetInfo : public TargetInfo { Opts["cl_khr_global_int32_extended_atomics"] = true; Opts["cl_khr_local_int32_base_atomics"] = true; Opts["cl_khr_local_int32_extended_atomics"] = true; + +Opts["__opencl_c_

<    1   2   3