@@ -341,6 +341,13 @@ class SPIRVInstructionSelector : public
InstructionSelector {
GIntrinsic &HandleDef, MachineInstr &Pos)
const;
};
+bool sampledTypeIsSignedInteger(const llvm::Type *HandleType) {
+ const TargetExtType *TET = cast(HandleTy
https://github.com/s-perron updated
https://github.com/llvm/llvm-project/pull/144774
>From 7d3d8bb30863dd860183f7b9635aa34b72a9c3ae Mon Sep 17 00:00:00 2001
From: Steven Perron
Date: Wed, 18 Jun 2025 09:19:45 -0400
Subject: [PATCH 1/2] [HLSL][SPRIV] Handle sign RWBuffer correctly
MIME-Version:
https://github.com/s-perron closed
https://github.com/llvm/llvm-project/pull/144902
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/s-perron updated
https://github.com/llvm/llvm-project/pull/144774
>From 7d3d8bb30863dd860183f7b9635aa34b72a9c3ae Mon Sep 17 00:00:00 2001
From: Steven Perron
Date: Wed, 18 Jun 2025 09:19:45 -0400
Subject: [PATCH] [HLSL][SPRIV] Handle sign RWBuffer correctly
MIME-Version: 1.0
https://github.com/s-perron edited
https://github.com/llvm/llvm-project/pull/144774
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/s-perron updated
https://github.com/llvm/llvm-project/pull/144774
>From 7d3d8bb30863dd860183f7b9635aa34b72a9c3ae Mon Sep 17 00:00:00 2001
From: Steven Perron
Date: Wed, 18 Jun 2025 09:19:45 -0400
Subject: [PATCH 1/3] [HLSL][SPRIV] Handle sign RWBuffer correctly
MIME-Version:
s-perron wrote:
https://lab.llvm.org/buildbot/#/builders/24/builds/9606
https://github.com/llvm/llvm-project/pull/143544
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/s-perron closed
https://github.com/llvm/llvm-project/pull/144812
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/s-perron created
https://github.com/llvm/llvm-project/pull/144812
Reverts llvm/llvm-project#143544
>From 9d775256000726929f826ec164aa514d4a6e2288 Mon Sep 17 00:00:00 2001
From: Steven Perron
Date: Wed, 18 Jun 2025 19:30:17 -0400
Subject: [PATCH] Revert "[HLSL][SPIRV] Add vk:
https://github.com/s-perron created
https://github.com/llvm/llvm-project/pull/144774
- **Add sign extend image operand.**
- **[HLSL][SPRIV] Handle sign RWBuffer correctly**
>From 488fb5961105305e50e3d787f286354754a73fe9 Mon Sep 17 00:00:00 2001
From: Steven Perron
Date: Wed, 18 Jun 2025 09:19
s-perron wrote:
@michalpaszkowski Any problems with me creating the new parallel type
`spirv.SignedImage`?
https://github.com/llvm/llvm-project/pull/144774
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/
@@ -1033,12 +1033,15 @@ void SemaHLSL::handleRootSignatureAttr(Decl *D, const
ParsedAttr &AL) {
void SemaHLSL::handleNumThreadsAttr(Decl *D, const ParsedAttr &AL) {
llvm::VersionTuple SMVersion =
getASTContext().getTargetInfo().getTriple().getOSVersion();
+ bool IsDXI
https://github.com/s-perron created
https://github.com/llvm/llvm-project/pull/145063
- **[HLSL][SPIRV] Allow large z value in numthreads**
- **Implement DXC layout cli options.**
- **[HLSL] Add option for VK layouts**
>From 0b809d5a51a76ef76a68574b8dc447de10d4654a Mon Sep 17 00:00:00 2001
From
https://github.com/s-perron approved this pull request.
https://github.com/llvm/llvm-project/pull/144929
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/s-perron closed
https://github.com/llvm/llvm-project/pull/145063
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/s-perron updated
https://github.com/llvm/llvm-project/pull/145327
>From 43f9f0e69c121c25f0519340f2aaa236f9820cba Mon Sep 17 00:00:00 2001
From: Steven Perron
Date: Thu, 19 Jun 2025 14:27:46 -0400
Subject: [PATCH] [HLSL] Add option for VK layouts
We add the options to the dri
https://github.com/s-perron created
https://github.com/llvm/llvm-project/pull/145536
In DXC, there is an option to enable all KHR extension. This is added by
passing the KHR option to the SPIR-V backend, which will enable all of
the appropriate extensions.
Part of https://github.com/llvm/llvm-p
https://github.com/s-perron updated
https://github.com/llvm/llvm-project/pull/145577
>From 44cb96a30dc3b2b28449661a52ac5a73c63e2139 Mon Sep 17 00:00:00 2001
From: Steven Perron
Date: Tue, 24 Jun 2025 15:44:10 -0400
Subject: [PATCH] [HLSL][SPIRV] Handle `uint` type for spec constant
The testing
https://github.com/s-perron created
https://github.com/llvm/llvm-project/pull/145577
The testing only tried `unsigned int` and not `uint`. We want to
correctly handle these surgared types as specialization constants.
>From 2bed922b3bd084fa43c8dc1843fb5bf67731e5ab Mon Sep 17 00:00:00 2001
From:
https://github.com/s-perron created
https://github.com/llvm/llvm-project/pull/145327
We add the options to the driver, so that the one option that is being
implemented at this time can be used. Issue an error for the other
options.
When we start to implement the other options, we will have to f
https://github.com/s-perron closed
https://github.com/llvm/llvm-project/pull/144934
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/s-perron updated
https://github.com/llvm/llvm-project/pull/144774
>From 7d3d8bb30863dd860183f7b9635aa34b72a9c3ae Mon Sep 17 00:00:00 2001
From: Steven Perron
Date: Wed, 18 Jun 2025 09:19:45 -0400
Subject: [PATCH 1/3] [HLSL][SPRIV] Handle sign RWBuffer correctly
MIME-Version:
s-perron wrote:
@michalpaszkowski The SPIR-V backend meeting was canceled, so we won't be able
to talk about this there. Do you have any feedback?
https://github.com/llvm/llvm-project/pull/144774
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
s-perron wrote:
Broken builds fixed by #144116
https://github.com/llvm/llvm-project/pull/143412
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/s-perron closed
https://github.com/llvm/llvm-project/pull/143412
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
s-perron wrote:
In discussions with the teams implementing HLSL, we changed the design for the
`export` keyword in HLSL.
See
https://github.com/llvm/wg-hlsl/blob/02098f6d85af1534c296c71790a24df55bd40374/proposals/0026-symbol-visibility.md
https://github.com/llvm/llvm-project/pull/134260
_
https://github.com/s-perron closed
https://github.com/llvm/llvm-project/pull/134260
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/s-perron ready_for_review
https://github.com/llvm/llvm-project/pull/140292
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/s-perron updated
https://github.com/llvm/llvm-project/pull/143544
>From 954a86f3c8da88c4ac276231a40cd88e6f628253 Mon Sep 17 00:00:00 2001
From: Steven Perron
Date: Fri, 30 May 2025 12:32:21 -0400
Subject: [PATCH 1/7] [HLSL][SPIRV] Add vk::constant_id attribute.
The vk::const
@@ -1661,6 +1661,11 @@ void
CodeGenModule::setGlobalVisibility(llvm::GlobalValue *GV,
return;
}
+ if (Context.getLangOpts().HLSL && !D->isInExportDeclContext()) {
+GV->setVisibility(llvm::GlobalValue::HiddenVisibility);
s-perron wrote:
I'll look i
https://github.com/s-perron approved this pull request.
https://github.com/llvm/llvm-project/pull/142679
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/s-perron edited
https://github.com/llvm/llvm-project/pull/141759
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/s-perron created
https://github.com/llvm/llvm-project/pull/143412
None
>From 20eb30e74884a8327f2f0fa7f357a1434347b0c4 Mon Sep 17 00:00:00 2001
From: Steven Perron
Date: Mon, 9 Jun 2025 12:53:06 -0400
Subject: [PATCH] [HLSL][SPIRV] Use resource names
---
clang/lib/CodeGen/C
https://github.com/s-perron updated
https://github.com/llvm/llvm-project/pull/143412
>From fadeeac5a79cbae0edffbabbe383d7451c254afb Mon Sep 17 00:00:00 2001
From: Steven Perron
Date: Mon, 9 Jun 2025 12:53:06 -0400
Subject: [PATCH] [HLSL][SPIRV] Use resource names
The SPIR-V backend does not ha
https://github.com/s-perron edited
https://github.com/llvm/llvm-project/pull/143412
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/s-perron edited
https://github.com/llvm/llvm-project/pull/143412
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/s-perron created
https://github.com/llvm/llvm-project/pull/143384
The HLSL driver currently defaults the triple to an unversioned os and
subarch when targeting SPIR-V. This means the SPIR-V backend decides the
default value. That is not a great option because a change the back
https://github.com/s-perron approved this pull request.
https://github.com/llvm/llvm-project/pull/145334
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/s-perron closed
https://github.com/llvm/llvm-project/pull/145536
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/s-perron created
https://github.com/llvm/llvm-project/pull/142638
The vk::constant_id attribute is used to indicate that a global const variable
represents a specialization constant in SPIR-V. This PR adds this
attribute to clang.
The documetation for the attribute is
[here]
https://github.com/s-perron approved this pull request.
LGTM
https://github.com/llvm/llvm-project/pull/141759
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Nathan =?utf-8?q?Gau=C3=ABr?=
Message-ID:
In-Reply-To:
https://github.com/s-perron approved this pull request.
https://github.com/llvm/llvm-project/pull/143127
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/ma
https://github.com/s-perron created
https://github.com/llvm/llvm-project/pull/143180
The vk::constant_id attribute is used to indicate that a global const variable
represents a specialization constant in SPIR-V. This PR adds this
attribute to clang.
The documetation for the attribute is
[here]
https://github.com/s-perron edited
https://github.com/llvm/llvm-project/pull/143544
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/s-perron edited
https://github.com/llvm/llvm-project/pull/143544
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/s-perron updated
https://github.com/llvm/llvm-project/pull/143180
>From de57697e0f9b0f9d4bb5be7ca6be631fe2502484 Mon Sep 17 00:00:00 2001
From: Steven Perron
Date: Fri, 30 May 2025 12:32:21 -0400
Subject: [PATCH] [HLSL][SPIRV] Add vk::constant_id attribute.
The vk::constant_
https://github.com/s-perron updated
https://github.com/llvm/llvm-project/pull/143384
>From ee4c25c47d58ba8707d8a36934186bce3c9fde4f Mon Sep 17 00:00:00 2001
From: Steven Perron
Date: Mon, 9 Jun 2025 10:21:47 -0400
Subject: [PATCH 1/2] [HLSL][Driver] Make vk1.3 the default.
The HLSL driver curr
@@ -243,7 +243,7 @@ CGHLSLRuntime::getCreateHandleFromBindingIntrinsic() {
case llvm::Triple::dxil:
return std::pair(llvm::Intrinsic::dx_resource_handlefrombinding, true);
case llvm::Triple::spirv:
-return std::pair(llvm::Intrinsic::spv_resource_handlefrombinding, f
https://github.com/s-perron updated
https://github.com/llvm/llvm-project/pull/143412
>From fadeeac5a79cbae0edffbabbe383d7451c254afb Mon Sep 17 00:00:00 2001
From: Steven Perron
Date: Mon, 9 Jun 2025 12:53:06 -0400
Subject: [PATCH 1/2] [HLSL][SPIRV] Use resource names
The SPIR-V backend does no
@@ -213,7 +213,8 @@ getScopeFromNormalizedScopeName(StringRef ScopeName) {
.Case("vk", AttributeCommonInfo::Scope::VK)
.Case("msvc", AttributeCommonInfo::Scope::MSVC)
.Case("omp", AttributeCommonInfo::Scope::OMP)
- .Case("riscv", AttributeCommonInfo::Scop
https://github.com/s-perron updated
https://github.com/llvm/llvm-project/pull/143544
>From 954a86f3c8da88c4ac276231a40cd88e6f628253 Mon Sep 17 00:00:00 2001
From: Steven Perron
Date: Fri, 30 May 2025 12:32:21 -0400
Subject: [PATCH 1/3] [HLSL][SPIRV] Add vk::constant_id attribute.
The vk::const
@@ -774,6 +775,77 @@ Value *CodeGenFunction::EmitHLSLBuiltinExpr(unsigned
BuiltinID,
return EmitRuntimeCall(
Intrinsic::getOrInsertDeclaration(&CGM.getModule(), ID));
}
+ case Builtin::BI__builtin_get_spirv_spec_constant_bool:
+ case Builtin::BI__builtin_get_sp
@@ -213,7 +213,8 @@ getScopeFromNormalizedScopeName(StringRef ScopeName) {
.Case("vk", AttributeCommonInfo::Scope::VK)
.Case("msvc", AttributeCommonInfo::Scope::MSVC)
.Case("omp", AttributeCommonInfo::Scope::OMP)
- .Case("riscv", AttributeCommonInfo::Scop
https://github.com/s-perron approved this pull request.
https://github.com/llvm/llvm-project/pull/143519
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/s-perron updated
https://github.com/llvm/llvm-project/pull/143384
>From ee4c25c47d58ba8707d8a36934186bce3c9fde4f Mon Sep 17 00:00:00 2001
From: Steven Perron
Date: Mon, 9 Jun 2025 10:21:47 -0400
Subject: [PATCH 1/2] [HLSL][Driver] Make vk1.3 the default.
The HLSL driver curr
https://github.com/s-perron closed
https://github.com/llvm/llvm-project/pull/143180
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/s-perron closed
https://github.com/llvm/llvm-project/pull/142638
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/s-perron approved this pull request.
https://github.com/llvm/llvm-project/pull/147806
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/s-perron closed
https://github.com/llvm/llvm-project/pull/145327
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -4855,6 +4857,17 @@ LinkageInfo
LinkageComputer::computeTypeLinkageInfo(const Type *T) {
return computeTypeLinkageInfo(cast(T)
->getContainedType()
->getCanonicalTypeInternal());
+ case Type::H
https://github.com/s-perron updated
https://github.com/llvm/llvm-project/pull/144774
>From 7d3d8bb30863dd860183f7b9635aa34b72a9c3ae Mon Sep 17 00:00:00 2001
From: Steven Perron
Date: Wed, 18 Jun 2025 09:19:45 -0400
Subject: [PATCH 1/4] [HLSL][SPRIV] Handle sign RWBuffer correctly
MIME-Version:
https://github.com/s-perron updated
https://github.com/llvm/llvm-project/pull/144774
>From 7d3d8bb30863dd860183f7b9635aa34b72a9c3ae Mon Sep 17 00:00:00 2001
From: Steven Perron
Date: Wed, 18 Jun 2025 09:19:45 -0400
Subject: [PATCH 1/3] [HLSL][SPRIV] Handle sign RWBuffer correctly
MIME-Version:
https://github.com/s-perron closed
https://github.com/llvm/llvm-project/pull/144774
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
s-perron wrote:
The failing spir-v test is caused by an update to spir-val
(https://github.com/KhronosGroup/SPIRV-Tools/pull/6184), and is unrelated to
this change.
https://github.com/llvm/llvm-project/pull/144774
___
cfe-commits mailing list
cfe-com
https://github.com/s-perron updated
https://github.com/llvm/llvm-project/pull/144774
>From 7d3d8bb30863dd860183f7b9635aa34b72a9c3ae Mon Sep 17 00:00:00 2001
From: Steven Perron
Date: Wed, 18 Jun 2025 09:19:45 -0400
Subject: [PATCH 1/4] [HLSL][SPRIV] Handle sign RWBuffer correctly
MIME-Version:
https://github.com/s-perron updated
https://github.com/llvm/llvm-project/pull/144774
>From 7d3d8bb30863dd860183f7b9635aa34b72a9c3ae Mon Sep 17 00:00:00 2001
From: Steven Perron
Date: Wed, 18 Jun 2025 09:19:45 -0400
Subject: [PATCH 1/5] [HLSL][SPRIV] Handle sign RWBuffer correctly
MIME-Version:
https://github.com/s-perron created
https://github.com/llvm/llvm-project/pull/146365
In a case statement for Type::HLSLInlineSpirv, the first statment
returns, and the remaining statement are never executed. This removes
the dead code.
https://github.com/llvm/llvm-project/pull/134034/files/7d8e
@@ -4855,6 +4857,17 @@ LinkageInfo
LinkageComputer::computeTypeLinkageInfo(const Type *T) {
return computeTypeLinkageInfo(cast(T)
->getContainedType()
->getCanonicalTypeInternal());
+ case Type::H
s-perron wrote:
The test failures are unrelated to this change.
https://github.com/llvm/llvm-project/pull/146365
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/s-perron closed
https://github.com/llvm/llvm-project/pull/146365
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/s-perron closed
https://github.com/llvm/llvm-project/pull/145577
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/s-perron updated
https://github.com/llvm/llvm-project/pull/145536
>From af0773cd9677d90d2fe2466fa113d70983fc2c32 Mon Sep 17 00:00:00 2001
From: Steven Perron
Date: Tue, 24 Jun 2025 11:41:12 -0400
Subject: [PATCH 1/2] [HLSL][SPIRV] Add option to add all KHR extensions
In DXC,
301 - 372 of 372 matches
Mail list logo
