[PATCH] D97567: [clang-tidy] performance-* checks: Also allow allow member expressions to be used in a const manner.

xgupta updated this revision to Diff 543307. xgupta added a comment. Address comment Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97567/new/ https://reviews.llvm.org/D97567 Files: clang-tools-extra/clang-tidy/utils/DeclRefExprUtils.cpp clang-

[PATCH] D97567: [clang-tidy] performance-* checks: Also allow allow member expressions to be used in a const manner.

This revision was automatically updated to reflect the committed changes. Closed by commit rG1e512688376c: [clang-tidy] performance-* checks: Also allow allow member expressions to be… (authored by shivam-amd). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llv

[PATCH] D155457: [clang] Skip tautological comparison if the comparison involves the 'size_t' type

xgupta added a comment. In D155457#4523227 , @aaron.ballman wrote: > In D155457#4513812 , @xgupta wrote: > >> In D155457#4511652 , >> @aaron.ballman wrote: >> >>> In the

[PATCH] D155457: [clang] Skip tautological comparison if the comparison involves the 'size_t' type

xgupta added a comment. In D155457#4523388 , @cor3ntin wrote: > I'm not sure I understand the motivation for this change. Sure, people do > that but they also might do the same thing for ssize_t, intmax_t, or to > compare int to int32_t. > I think a bet

[PATCH] D146368: [clang-tidy] Add readability-reference-to-constructed-temporary check

xgupta added inline comments. Comment at: clang-tools-extra/clang-tidy/readability/ReferenceToConstructedTemporaryCheck.cpp:20 + +struct NotExtendedByDeclBoundToPredicate { + bool operator()(const internal::BoundNodesMap &Nodes) const { A comment might be good

[PATCH] D144135: [clang-tidy] Add performance-enum-size check

xgupta accepted this revision. xgupta added a comment. This revision is now accepted and ready to land. LGTM, thanks. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144135/new/ https://reviews.llvm.org/D144135 __

[PATCH] D146368: [clang-tidy] Add readability-reference-to-constructed-temporary check

xgupta added inline comments. Comment at: clang-tools-extra/docs/clang-tidy/checks/readability/reference-to-constructed-temporary.rst:18 + + const std::string& value("hello"); + PiotrZSL wrote: > xgupta wrote: > > The below comment is not matching, do you wan

[PATCH] D146368: [clang-tidy] Add readability-reference-to-constructed-temporary check

xgupta added a comment. This LGTM, I will wait for two days before accepting the revision in case other reviewers might have some more comments/suggestions. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146368/new/ https://reviews.llvm.org/D146368

[PATCH] D155457: [clang] Skip tautological comparison if the comparison involves the 'size_t' type

xgupta added a comment. ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D155457/new/ https://reviews.llvm.org/D155457 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-

[PATCH] D155457: [clang] Skip tautological comparison if the comparison involves the 'size_t' type

xgupta updated this revision to Diff 544622. xgupta added a comment. Update as per comment of @cor3ntin Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D155457/new/ https://reviews.llvm.org/D155457 Files: clang/lib/Sema/SemaChecking.cpp clang/tes

[PATCH] D155457: [clang] Skip tautological comparison if the comparison involves the 'size_t' type

xgupta added a comment. In D155457#4535941 , @aaron.ballman wrote: > In D155457#4526168 , @xgupta wrote: > >> In D155457#4523388 , @cor3ntin >> wrote: >> >>> I'm not sur

[PATCH] D155457: [clang] Skip tautological comparison if the comparison involves the 'size_t' type

xgupta updated this revision to Diff 544728. xgupta added a comment. updated code as per the comment of @cor3ntin Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D155457/new/ https://reviews.llvm.org/D155457 Files: clang/lib/Sema/SemaChecking.cpp

[PATCH] D155457: [clang] Skip tautological comparison if the comparison involves the 'size_t' type

xgupta updated this revision to Diff 544732. xgupta added a comment. minor update Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D155457/new/ https://reviews.llvm.org/D155457 Files: clang/lib/Sema/SemaChecking.cpp clang/test/Sema/type-limit-comp

[PATCH] D149084: [clang-tidy] Added bugprone-multi-level-implicit-pointer-conversion check

xgupta accepted this revision. xgupta added a comment. This revision is now accepted and ready to land. LGTM, Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D149084/new/ https://reviews.llvm.org/D149084 __

[PATCH] D146368: [clang-tidy] Add readability-reference-to-constructed-temporary check

xgupta accepted this revision. xgupta added a comment. This revision is now accepted and ready to land. LGTM! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146368/new/ https://reviews.llvm.org/D146368 __

[PATCH] D149015: [clang-tidy] Added bugprone-inc-dec-in-conditions check

xgupta added inline comments. Comment at: clang-tools-extra/clang-tidy/bugprone/IncDecInConditionsCheck.cpp:30 +void IncDecInConditionsCheck::registerMatchers(MatchFinder *Finder) { + auto OperatorMacher = expr( + anyOf(binaryOperator(anyOf(isComparisonOperator(), isLogical

[PATCH] D149015: [clang-tidy] Added bugprone-inc-dec-in-conditions check

xgupta accepted this revision. xgupta added a comment. This revision is now accepted and ready to land. LGTM! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D149015/new/ https://reviews.llvm.org/D149015 __

[PATCH] D147357: [clang-tidy] Add bugprone-optional-value-conversion check

xgupta added inline comments. Comment at: clang-tools-extra/clang-tidy/bugprone/OptionalValueConversionCheck.cpp:61 + matchers::matchesAnyListedName(ValueMethods) + .bind("fun")), + hasType(qualType().bind("value-type"))); --

[PATCH] D147357: [clang-tidy] Add bugprone-optional-value-conversion check

xgupta accepted this revision. xgupta added a comment. This revision is now accepted and ready to land. LGTM, Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147357/new/ https://reviews.llvm.org/D147357 __

[PATCH] D157352: Revert "[Clang] Fix -Wconstant-logical-operand when LHS is a constant"

xgupta created this revision. Herald added a project: All. xgupta requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This reverts commit dfdfd306cfaf54fbc43e2d5eb36489dac3eb9976

[PATCH] D157352: Revert "[Clang] Fix -Wconstant-logical-operand when LHS is a constant"

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGa84525233776: Revert "[Clang] Fix -Wconstant-logical-operand when

[PATCH] D142609: [Clang] Fix -Wconstant-logical-operand when LHS is a constant

xgupta added a comment. In D142609#4566418 , @aaron.ballman wrote: > Concerns have been raised in > https://github.com/llvm/llvm-project/issues/64356 that this is an undesirable > change in diagnostic behavior. The diagnostic is supposed to fire when

[PATCH] D4784: [clang-tidy] Add check for possibly incomplete switch statements

xgupta updated this revision to Diff 539378. xgupta retitled this revision from "[clang-tidy] Add check for possibly incomplete switch statements " to "[clang-tidy] Add check for possibly incomplete switch statements". xgupta added a reviewer: PiotrZSL. xgupta added a comment. Herald added a revie

[PATCH] D4784: [clang-tidy] Add check for possibly incomplete switch statements

xgupta updated this revision to Diff 539383. xgupta added a comment. . CHANGES SINCE LAST ACTION https://reviews.llvm.org/D4784/new/ https://reviews.llvm.org/D4784 Files: clang-tools-extra/clang-tidy/misc/CMakeLists.txt clang-tools-extra/clang-tidy/misc/IncompleteSwitchCheck.cpp clang-

[PATCH] D4784: [clang-tidy] Add check for possibly incomplete switch statements

xgupta updated this revision to Diff 539389. xgupta added a comment. Address bkramer's comments except one for "checking that you're casting from an enum". CHANGES SINCE LAST ACTION https://reviews.llvm.org/D4784/new/ https://reviews.llvm.org/D4784 Files: clang-tools-extra/clang-tidy/misc

[PATCH] D4784: [clang-tidy] Add check for possibly incomplete switch statements

xgupta updated this revision to Diff 539390. xgupta added a comment. Update ReleaseNotes.rst CHANGES SINCE LAST ACTION https://reviews.llvm.org/D4784/new/ https://reviews.llvm.org/D4784 Files: clang-tools-extra/clang-tidy/misc/CMakeLists.txt clang-tools-extra/clang-tidy/misc/IncompleteSw

[PATCH] D4784: [clang-tidy] Add check for possibly incomplete switch statements

xgupta updated this revision to Diff 539558. xgupta edited the summary of this revision. xgupta added a comment. Address some comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D4784/new/ https://reviews.llvm.org/D4784 Files: clang-tools-extr

[PATCH] D4784: [clang-tidy] Add check for possibly incomplete switch statements

xgupta updated this revision to Diff 539593. xgupta marked 3 inline comments as done. xgupta added a comment. Address more comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D4784/new/ https://reviews.llvm.org/D4784 Files: clang-tools-extra/c

[PATCH] D4784: [clang-tidy] Add check for possibly incomplete switch statements

xgupta updated this revision to Diff 539602. xgupta added a comment. Add documentation Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D4784/new/ https://reviews.llvm.org/D4784 Files: clang-tools-extra/clang-tidy/bugprone/BugproneTidyModule.cpp c

[PATCH] D4784: [clang-tidy] Add check for possibly incomplete switch statements

xgupta updated this revision to Diff 539857. xgupta marked 12 inline comments as done. xgupta added a comment. Address all comments excpet in SwitchMissingDefaultCaseCheck.cpp Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D4784/new/ https://reviews.

[PATCH] D4784: [clang-tidy] Add check for possibly incomplete switch statements

xgupta added inline comments. Comment at: clang-tools-extra/docs/ReleaseNotes.rst:225 + + Ensures that incomplete switch statements without default cases are + flagged, covering cases beyond enums where the compiler may not issue warnings. PiotrZSL wrote: > ac

[PATCH] D4784: [clang-tidy] Add check for possibly incomplete switch statements

xgupta updated this revision to Diff 540102. xgupta added a comment. Updated SwitchMissingDefaultCaseCheck.cpp but still WIP Will look again on saturday/sunday Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D4784/new/ https://reviews.llvm.org/D4784

[PATCH] D4784: [clang-tidy] Add check for possibly incomplete switch statements

xgupta updated this revision to Diff 540119. xgupta marked an inline comment as done. xgupta added a comment. Address latest two comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D4784/new/ https://reviews.llvm.org/D4784 Files: clang-tools-e

[PATCH] D4784: [clang-tidy] Add check for possibly incomplete switch statements

xgupta marked an inline comment as done. xgupta added inline comments. Comment at: clang-tools-extra/docs/clang-tidy/checks/bugprone/switch-missing-default-case.rst:52 +.. note:: + Enum types are already covered by compiler warnings when a switch statement + does not handle

[PATCH] D4784: [clang-tidy] Add check for possibly incomplete switch statements

xgupta updated this revision to Diff 540798. xgupta marked an inline comment as done. xgupta added a comment. Address comment Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D4784/new/ https://reviews.llvm.org/D4784 Files: clang-tools-extra/clang-t

[PATCH] D4784: [clang-tidy] Add check for possibly incomplete switch statements

xgupta marked 3 inline comments as done. xgupta added inline comments. Comment at: clang-tools-extra/clang-tidy/bugprone/SwitchMissingDefaultCaseCheck.cpp:16-29 +void SwitchMissingDefaultCaseCheck::registerMatchers( +ast_matchers::MatchFinder *Finder) { + Finder->addMatcher

[PATCH] D4784: [clang-tidy] Add check for possibly incomplete switch statements

xgupta updated this revision to Diff 540818. xgupta marked 5 inline comments as done. xgupta added a comment. Address comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D4784/new/ https://reviews.llvm.org/D4784 Files: clang-tools-extra/clang-

[PATCH] D4784: [clang-tidy] Add check for possibly incomplete switch statements

xgupta added inline comments. Comment at: clang-tools-extra/clang-tidy/bugprone/SwitchMissingDefaultCaseCheck.cpp:19 + Finder->addMatcher( + switchStmt(has(implicitCastExpr().bind("cast")), + unless(hasAncestor(switchStmt(has(defaultStmt())

[PATCH] D4784: [clang-tidy] Add check for possibly incomplete switch statements

xgupta updated this revision to Diff 540845. xgupta marked an inline comment as done. xgupta added a comment. Updated testcase [WIP] Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D4784/new/ https://reviews.llvm.org/D4784 Files: clang-tools-extra/

[PATCH] D4784: [clang-tidy] Add check for possibly incomplete switch statements

xgupta updated this revision to Diff 540857. xgupta marked 6 inline comments as done. xgupta added a comment. Address comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D4784/new/ https://reviews.llvm.org/D4784 Files: clang-tools-extra/clang-

[PATCH] D4784: [clang-tidy] Add check for possibly incomplete switch statements

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG42179bbf6bcc: [clang-tidy] Add check for possibly incomplete switch statements (authored by shivam-amd). Repository: rG LLVM Github Monorepo CHAN

[PATCH] D4784: [clang-tidy] Add check for possibly incomplete switch statements

xgupta added a comment. In D4784#4504690 , @PiotrZSL wrote: > Just few nits (column numbers in test, missing doxygen comment, ...). > Please fix those before committing. > > Except that, looking good to me. Thanks for this nice code review. Repository:

[PATCH] D142609: [Clang] Fix -Wconstant-logical-operand when LHS is a constant

xgupta updated this revision to Diff 540914. xgupta marked 5 inline comments as done. xgupta added a comment. Address comments CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142609/new/ https://reviews.llvm.org/D142609 Files: clang/include/clang/Sema/Sema.h clang/lib/Sema/SemaExpr.c

[PATCH] D142609: [Clang] Fix -Wconstant-logical-operand when LHS is a constant

xgupta added inline comments. Comment at: clang/lib/Sema/SemaExpr.cpp:13635 + if (ECDHS && ECDHS->getInitVal() != 0 && ECDHS->getInitVal() != 1) +EnumConstantInBoolContext = true; +} xgupta wrote: > nickdesaulniers wrote: > > Hmm...I wonder if we

[PATCH] D142609: [Clang] Fix -Wconstant-logical-operand when LHS is a constant

xgupta updated this revision to Diff 540922. xgupta added a comment. Address xbolva00's comments CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142609/new/ https://reviews.llvm.org/D142609 Files: clang/include/clang/Sema/Sema.h clang/lib/Sema/SemaExpr.cpp clang/test/C/drs/dr4xx.c

[PATCH] D155457: [clang] Skip tautological comparison if the comparison involves the 'size_t' type

xgupta created this revision. xgupta added reviewers: aaron.ballman, xbolva00. Herald added a project: All. xgupta requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. The issue with size_t comes when we are trying to addd -Wtype-limits to -Wext

[PATCH] D155457: [clang] Skip tautological comparison if the comparison involves the 'size_t' type

xgupta added a comment. I am not sure if this is correct but this passes `ninja check-clang`. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D155457/new/ https://reviews.llvm.org/D155457 ___ cfe-commits ma

[PATCH] D155457: [clang] Skip tautological comparison if the comparison involves the 'size_t' type

xgupta added a comment. In D155457#4506405 , @xbolva00 wrote: > You should add a testcase which uses “expected no diagnostics”. There is some issue writing test $ cat type-limit-compare.cpp // RUN: %clang_cc1 -fsyntax-only -Wtautological-type-limit

[PATCH] D158540: Improve error message for constexpr constructors of virtual base classes

xgupta added reviewers: shafik, aaron.ballman. xgupta added a comment. Test case updates are missing due to which 7 test cases are failing on pre-merge check - https://buildkite.com/llvm-project/premerge-checks/builds/172995#018a2776-1461-4f98-b12d-bd0521352d50/6-14972. Repository: rG LLVM G

[PATCH] D158540: Improve error message for constexpr constructors of virtual base classes

xgupta added a comment. In D158540#4620286 , @NoumanAmir657 wrote: > @xgupta It passed the test cases now Thanks, I think we also want a note similar to MSVC diagnostic: (6): note: see reference to function 'Derived::Derived(void)' CHANGES SINCE LAS

[PATCH] D158540: Improve error message for constexpr constructors of virtual base classes

xgupta added a subscriber: rsmith. xgupta added a comment. Just address @rsmith, I think after that we are fine to commit this review. > + "%sub{select_special_member_kind}0 cannot be 'constexpr' in a class or > struct with virtual base classes">; Please don't say "class or struct" here. Eithe

[PATCH] D158540: Improve error message for constexpr constructors of virtual base classes

xgupta accepted this revision. xgupta added a comment. This revision is now accepted and ready to land. LGTM, Thanks! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158540/new/ https://reviews.llvm.org/D158540 ___ cfe-commits mailing list cfe-

[PATCH] D148439: [clang-rename] Exit gracefully when no input provided

xgupta created this revision. xgupta added reviewers: vmiklos, alexander-shaposhnikov, kbobyrev, aaron.ballman. Herald added a project: All. xgupta requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. clang-rename on a non existing file segfaul

[PATCH] D148439: [clang-rename] Exit gracefully when no input provided

xgupta updated this revision to Diff 514093. xgupta added a comment. address comment Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148439/new/ https://reviews.llvm.org/D148439 Files: clang/tools/clang-rename/ClangRename.cpp Index: clang/tools/

[PATCH] D148439: [clang-rename] Exit gracefully when no input provided

xgupta marked an inline comment as done. xgupta added inline comments. Comment at: clang/tools/clang-rename/ClangRename.cpp:130 + } else { +errs() << "clang-rename: No input provided.\n"; +return 1; kbobyrev wrote: > Probably something like "input must b

[PATCH] D148439: [clang-rename] Exit gracefully when no input provided

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. xgupta marked an inline comment as done. Closed by commit rG726199146a0b: [clang-rename] Exit gracefully when no input provided (authored by xgupta). Repository: rG

[PATCH] D148439: [clang-rename] Exit gracefully when no input provided

xgupta added a comment. In D148439#4272810 , @dyung wrote: > Is there a reason a test was not added with this change? Sorry, I missed that. Adding. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148439/new/

[PATCH] D148439: [clang-rename] Exit gracefully when no input provided

xgupta added a comment. In D148439#4272813 , @dyung wrote: > This change is also causing 33 test failures on a build bot > https://lab.llvm.org/buildbot/#/builders/139/builds/39267 Yes, checking for the reason, and honestly I never tried to run clang-re

[PATCH] D148439: [clang-rename] Exit gracefully when no input provided

xgupta updated this revision to Diff 514262. xgupta added a comment. adjust the return and add test case Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148439/new/ https://reviews.llvm.org/D148439 Files: clang/test/clang-rename/NonExistFile.cpp

[PATCH] D148439: [clang-rename] Exit gracefully when no input provided

xgupta added a comment. In D148439#4272904 , @kbobyrev wrote: > Oh, wait, I'm sorry, I didn't look into it closely :( Yeah, the `Input` file > is not really needed, most of the time the users of `clang-rename` (not sure > there are many with `clangd` be

[PATCH] D142609: [Clang] Fix -Wconstant-logical-operand when LHS is a constant

xgupta updated this revision to Diff 495375. xgupta added a comment. address comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142609/new/ https://reviews.llvm.org/D142609 Files: clang/include/clang/Sema/Sema.h clang/lib/Sema/SemaExpr.cpp

[PATCH] D142609: [Clang] Fix -Wconstant-logical-operand when LHS is a constant

xgupta marked 5 inline comments as done. xgupta added inline comments. Comment at: clang/lib/Sema/SemaExpr.cpp:13635 + if (ECDHS && ECDHS->getInitVal() != 0 && ECDHS->getInitVal() != 1) +EnumConstantInBoolContext = true; +} nickdesaulniers wrote:

[PATCH] D142609: [Clang] Fix -Wconstant-logical-operand when LHS is a constant

xgupta added a comment. gentle ping for review. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142609/new/ https://reviews.llvm.org/D142609 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://

[PATCH] D149713: [Sema] Avoid emitting warnings for constant destruction.

This revision was automatically updated to reflect the committed changes. Closed by commit rGdd6a58babc85: [Sema] Avoid emitting warnings for constant destruction. (authored by pkasting, committed by xgupta). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.

[PATCH] D146370: [Clang][OpenMP]Solved the the always truth condition in Arm64

This revision was automatically updated to reflect the committed changes. Closed by commit rGc1ab19850d5c: [Clang][OpenMP]Solved the the always truth condition in Arm64 (authored by samuelmaina, committed by xgupta). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://revie

[PATCH] D148439: [clang-rename] Exit gracefully when no input provided

xgupta updated this revision to Diff 514842. xgupta marked an inline comment as done. xgupta added a comment. address comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148439/new/ https://reviews.llvm.org/D148439 Files: clang/test/clang-ren

[PATCH] D148439: [clang-rename] Exit gracefully when no input provided

xgupta added inline comments. Comment at: clang/tools/clang-rename/ClangRename.cpp:233 + if (!Entry) { +errs() << "clang-rename: input file does not exist.\n"; +return 1; kbobyrev wrote: > It is worth including the filename in the error messa

[PATCH] D148439: [clang-rename] Exit gracefully when no input provided

xgupta added a comment. Ping for reivew. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148439/new/ https://reviews.llvm.org/D148439 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.l

[PATCH] D148439: [clang-rename] Exit gracefully when no input provided

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rG62eec1584d2c: [clang-rename] Exit gracefully when no input provided (authored by xgupta). Changed prior to commit: http

[PATCH] D148439: [clang-rename] Exit gracefully when no input provided

xgupta added a comment. In D148439#4298606 , @aaron.ballman wrote: > LGTM, but please add a release note when landing the changes. Thanks for the review, added a release note for change. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D149405: [Clang][Doc] Added an open project for improving command line docs

xgupta created this revision. xgupta added a reviewer: aaron.ballman. Herald added a project: All. xgupta requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. There seems to be a lot of documentation is missing for different command line flags u

[PATCH] D149405: [Clang][Doc] Added an open project for improving command line docs

xgupta updated this revision to Diff 517996. xgupta added a comment. address comment Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D149405/new/ https://reviews.llvm.org/D149405 Files: clang/www/OpenProjects.html Index: clang/www/OpenProjects.ht

[PATCH] D149405: [Clang][Doc] Added an open project for improving command line docs

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. xgupta marked an inline comment as done. Closed by commit rGa70485493803: [Clang][Doc] Added an open project for improving command line docs (authored by xgupta). Repo

[PATCH] D149405: [Clang][Doc] Added an open project for improving command line docs

xgupta added a comment. In D149405#4305856 , @aaron.ballman wrote: > Thank you, this is a great suggestion! Just some minor wording changes, but > otherwise LGTM. Thanks. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://revi

[PATCH] D149456: Basic documentation of -mrecip=... option

This revision was automatically updated to reflect the committed changes. Closed by commit rG85ed0fb5037b: Basic documentation of -mrecip=... option (authored by tim.schmielau, committed by xgupta). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D14945

[PATCH] D101352: [DOCS] Removed inconsistency in clang vs Clang usage in docs (c vs C)

xgupta accepted this revision. xgupta added a comment. This revision is now accepted and ready to land. LGTM, Thanks for the patch! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101352/new/ https://reviews.llvm.org/D101352

[PATCH] D101352: [DOCS] Removed inconsistency in clang vs Clang usage in docs (c vs C)

xgupta added a subscriber: rnk. xgupta added a comment. In D101352#2726406 , @jrtc27 wrote: > I'm not convinced by these changes? Yes, I also thought first, clang man page can't be incorrect/inconsistent. I think @rnk can suggest the changes as he has a

[PATCH] D101352: [DOCS] Removed inconsistency in clang vs Clang usage in docs (c vs C)

xgupta added a comment. @sushmaunnibhavi Please close this revision, I got some misunderstading. Changes are not expected here. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101352/new/ https://reviews.llvm.org/D101352 ___

[PATCH] D101433: Added a faster method to clone llvm project [DOCS]

This revision was automatically updated to reflect the committed changes. Closed by commit rG67ee2f870d3b: Added a faster method to clone llvm project [DOCS] (authored by sushmaunnibhavi, committed by xgupta). Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG

[PATCH] D115094: Fix -Wdeclaration-after-statement doesn't work when used with -std=c99

xgupta added subscribers: zero9178, xgupta. xgupta added a comment. In D115094#3174635 , @dblaikie wrote: > This'll at least need a test case added - though the specifics of how the > warning should work I'll leave up to @aaron.ballman - unless he wants

[PATCH] D100696: Fixed typos

xgupta requested changes to this revision. xgupta added a comment. This revision now requires changes to proceed. Thanks @jnyfah for the patch! It looks you need to rebase your branch to llvm upstream main branch. Because polly/docs/ReleaseNotes.rst is recently change. Now its contain nothing se

[PATCH] D100696: Fixed typos

xgupta accepted this revision. xgupta added a comment. This revision now requires review to proceed. Oh sorry, Your patch is correct. I misunderstand something :) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100696/new/ https://reviews.llvm.org/D1

[PATCH] D100696: Fixed typos

xgupta added a comment. Actually, I am not able to apply this patch with `arc patch D100696`. Created and checked out branch arcpatch-D100696. Checking patch polly/docs/ReleaseNotes.rst... error: while searching for: .. warning:: These release notes are for the next release of Polly and it de

[PATCH] D100696: Fixed typos

xgupta added a comment. @jnyfah If you are missing something I am just telling you the steps - 1. First fork the llvm github repository 2. git clone https://github.com/jynfah/llvm-project 3. git checkout -b type-fix 4. make changes to files. 5. git diff > mypatch.patch 6. git commit -m "fix typo

[PATCH] D100705: Fixed Typos

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG21bef4e11e48: [NFC] Fixed Typos (authored by jnyfah, committed by

[PATCH] D100705: Fixed Typos

xgupta added a subscriber: curdeius. xgupta added a comment. Nice work @jnyfah! @Mordante Review is already accepted by @curdeius in https://reviews.llvm.org/D100696. And actually, I see your message after committing the patch. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D100696: Fixed typos

xgupta added a comment. @jnyfah you may close this revision. changes are committed by https://reviews.llvm.org/rG21bef4e11e48d5d4bff7a23babbd420e86dd420a. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100696/new/ https://reviews.llvm.org/D100696

[PATCH] D100705: Fixed Typos

xgupta added a comment. Thanks, @Mordante for the tips, I remember from next time :) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100705/new/ https://reviews.llvm.org/D100705 ___ cfe-commits mailing lis

[PATCH] D110836: [CMake] Fix typo in error message for LLD in bootstrap builds.

This revision was automatically updated to reflect the committed changes. Closed by commit rGf043b765: [CMake] Fix typo in error message for LLD in bootstrap builds. (authored by fcambus, committed by xgupta). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.

[PATCH] D109825: [AArch64]Enabling Cortex-A510 Support

xgupta added a comment. Where are the other patches? Or diff is not uploaded correctly. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109825/new/ https://reviews.llvm.org/D109825 ___ cfe-commits mailing

[PATCH] D109825: [AArch64]Enabling Cortex-A510 Support

xgupta added a comment. Yeah, those changes are in history, But we need them in the present to commit :) The patch is incorrectly updated, did you followed https://llvm.org/docs/Phabricator.html#requesting-a-review-via-the-command-line? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D108441: [clang] Fix JSON AST output when a filter is used

xgupta added a comment. @woodruffw Please rebase the patch. clang/test/AST/ast-dump-if-json.cpp testcase is not applying cleanly. If you don't commit access, I can commit on your behalf. Thanks. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108441

[PATCH] D111490: [DOCS] Update ninja build doc (new: github link, build command, and chmod requirements)

xgupta added inline comments. Comment at: clang/docs/HowToSetupToolingForLLVM.rst:157 - $ git clone git://github.com/martine/ninja.git + $ git clone git://github.com/ninja-build/ninja.git $ cd ninja/ git -> https Comment at: clang/docs/L

[PATCH] D111490: [DOCS] Update ninja build doc (new: github link, build command, and chmod requirements)

xgupta added inline comments. Comment at: clang/docs/LibASTMatchersTutorial.rst:34 - git clone https://github.com/martine/ninja.git - cd ninja - git checkout release SamuelMarks wrote: > xgupta wrote: > > why removed `cd ninja` & `git checkout rele

[PATCH] D111490: [DOCS] Update ninja build doc (new: github link, build command, and chmod requirements)

xgupta added a comment. Please update the patch full context, see https://llvm.org/docs/Phabricator.html#requesting-a-review-via-the-web-interface if using the web interface. (git diff HEAD~1 -U99 > mypatch.patch) CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111490/new/ https://

[PATCH] D108441: [clang] Fix JSON AST output when a filter is used

This revision was automatically updated to reflect the committed changes. Closed by commit rG451d0596d706: [clang] Fix JSON AST output when a filter is used (authored by woodruffw, committed by xgupta). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D1

[PATCH] D111490: [DOCS] Update ninja build doc (new: github link, build command, and chmod requirements)

xgupta added a reviewer: Mordante. xgupta added a subscriber: Mordante. xgupta added a comment. The patch is not applying cleanly so can't be committed. please follow the above phabricator docs I suggested before to upload it. add @Mordante for libcxx change. CHANGES SINCE LAST ACTION https:

[PATCH] D109825: [AArch64]Enabling Cortex-A510 Support

xgupta added a comment. It misses llvm/test/CodeGen/AArch64 and llvm/test/MC/AArch64 testcases changes, see for example https://reviews.llvm.org/D36667 (Cortex-A55 support). CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109825/new/ https://reviews.llvm.org/D109825

[PATCH] D109825: [AArch64]Enabling Cortex-A510 Support

xgupta added a comment. oh thanks for the clarification, I am not aware of it. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109825/new/ https://reviews.llvm.org/D109825 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.ll

[PATCH] D91815: Fix small typo in Block ABI docs

This revision was automatically updated to reflect the committed changes. Closed by commit rGa94bc9d81bfc: Fix small typo in Block ABI docs (authored by dmaclach, committed by xgupta). Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo CH

<    1   2   3   >