[PATCH] D68245: [Clangd] ExtractFunction: Don't extract body of enclosing function.

SureYeaah created this revision. SureYeaah added reviewers: sammccall, kadircet. Herald added subscribers: cfe-commits, usaxena95, arphaman, jkorous, MaskRay, ilya-biryukov. Herald added a project: clang. This patch disable extraction of the body of the enclosing function. `void f() [[{}]]` Extr

[PATCH] D68182: [Clangd] Ensure children are always RootStmt in ExtractFunction (Fixes #153)

SureYeaah updated this revision to Diff 222585. SureYeaah marked 2 inline comments as done. SureYeaah added a comment. Address review comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68182/new/ https://reviews.llvm.org/D68182 Files: clang-

[PATCH] D68245: [Clangd] ExtractFunction: Don't extract body of enclosing function.

SureYeaah updated this revision to Diff 222815. SureYeaah marked an inline comment as done. SureYeaah added a comment. Added assert and removed fixme Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68245/new/ https://reviews.llvm.org/D68245 Files:

[PATCH] D68182: [Clangd] Ensure children are always RootStmt in ExtractFunction (Fixes #153)

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rL373471: [Clangd] Ensure children are always RootStmt in ExtractFunction (Fixes #153) (authored by SureYeaah, committed by

[PATCH] D68245: [Clangd] ExtractFunction: Don't extract body of enclosing function.

This revision was automatically updated to reflect the committed changes. Closed by commit rL373472: [Clangd] ExtractFunction: Don't extract body of enclosing function. (authored by SureYeaah, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to

[PATCH] D65526: [Clangd] Initial prototype version of ExtractFunction

SureYeaah updated this revision to Diff 216669. SureYeaah marked 33 inline comments as done. SureYeaah added a comment. Herald added a subscriber: mgrang. Addressed Review comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65526/new/ https://re

[PATCH] D65526: [Clangd] Initial prototype version of ExtractFunction

SureYeaah updated this revision to Diff 216805. SureYeaah marked 4 inline comments as done. SureYeaah added a comment. Addressed more review comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65526/new/ https://reviews.llvm.org/D65526 Files:

[PATCH] D66590: [clangd] Fix toHalfOpenFileRange where start/end endpoints are in different files due to #include

SureYeaah accepted this revision. SureYeaah added a comment. This revision is now accepted and ready to land. LGTM Comment at: clang-tools-extra/clangd/SourceCode.cpp:284 + return SM.getComposedLoc(IncludingFile, Offset); +if (Buf[Offset] == '\n' || Offset == 0) // no

[PATCH] D65526: [Clangd] First version of ExtractFunction

SureYeaah added inline comments. Comment at: clang-tools-extra/clangd/refactor/tweaks/ExtractFunction.cpp:214 +bool IsConst; +Parameter(std::string Name, std::string Type, bool IsConst) +: Name(Name), Type(Type), IsConst(IsConst) {} sammccall wrot

[PATCH] D65526: [Clangd] First version of ExtractFunction

SureYeaah marked an inline comment as done. SureYeaah added inline comments. Comment at: clang-tools-extra/clangd/refactor/tweaks/ExtractFunction.cpp:360 + +CapturedSourceInfo::DeclInformation & +CapturedSourceInfo::getDeclInformationFor(const Decl *D) { SureYeaa

[PATCH] D65526: [Clangd] First version of ExtractFunction

SureYeaah updated this revision to Diff 216831. SureYeaah marked 2 inline comments as done. SureYeaah edited the summary of this revision. SureYeaah added a comment. Removed extra code Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65526/new/ https:

[PATCH] D65526: [Clangd] First version of ExtractFunction

SureYeaah updated this revision to Diff 217108. SureYeaah added a comment. Fixed typo Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65526/new/ https://reviews.llvm.org/D65526 Files: clang-tools-extra/clangd/refactor/tweaks/CMakeLists.txt clang

[PATCH] D66732: [Clangd] ExtractFunction Added checks for broken control flow

SureYeaah created this revision. SureYeaah added reviewers: sammccall, kadircet. Herald added subscribers: cfe-commits, arphaman, jkorous, MaskRay, ilya-biryukov. Herald added a project: clang. - Added a SelectionTreeVisitor to check for broken control flow - Added unittests Repository: rG LL

[PATCH] D65526: [Clangd] First version of ExtractFunction

SureYeaah updated this revision to Diff 217619. SureYeaah marked 45 inline comments as done. SureYeaah added a comment. Addressed review comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65526/new/ https://reviews.llvm.org/D65526 Files: cla

[PATCH] D65526: [Clangd] First version of ExtractFunction

SureYeaah added inline comments. Comment at: clang-tools-extra/clangd/refactor/tweaks/ExtractFunction.cpp:165 +else + SR.setEnd(ChildFileRange->getEnd()); + } kadircet wrote: > I suppose this relies on the fact that "AST contains the nodes ordered by >

[PATCH] D65526: [Clangd] First version of ExtractFunction

SureYeaah updated this revision to Diff 217620. SureYeaah added a comment. NFC: Whitespace formatting Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65526/new/ https://reviews.llvm.org/D65526 Files: clang-tools-extra/clangd/refactor/tweaks/CMakeL

[PATCH] D65526: [Clangd] First version of ExtractFunction

SureYeaah added inline comments. Comment at: clang-tools-extra/clangd/refactor/tweaks/ExtractFunction.cpp:119 + case SelectionTree::Selection::Partial: +// Treat Partially selected VarDecl as completely selected since +// SelectionTree doesn't always select VarDecls corr

[PATCH] D65526: [Clangd] First version of ExtractFunction

SureYeaah updated this revision to Diff 217701. SureYeaah marked 14 inline comments as done. SureYeaah added a comment. Addressed review comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65526/new/ https://reviews.llvm.org/D65526 Files: cla

[PATCH] D65526: [Clangd] First version of ExtractFunction

This revision was automatically updated to reflect the committed changes. Closed by commit rL370249: [Clangd] Initial version of ExtractFunction (authored by SureYeaah, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit: https://review

[PATCH] D66732: [Clangd] ExtractFunction Added checks for broken control flow

SureYeaah updated this revision to Diff 217865. SureYeaah added a comment. Removed selectionTree Visitor Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66732/new/ https://reviews.llvm.org/D66732 Files: clang-tools-extra/clangd/refactor/tweaks/Ext

[PATCH] D66732: [Clangd] ExtractFunction Added checks for broken control flow

SureYeaah updated this revision to Diff 217881. SureYeaah added a comment. Added null statement check in TraverseStmt Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66732/new/ https://reviews.llvm.org/D66732 Files: clang-tools-extra/clangd/refact

[PATCH] D66732: [Clangd] ExtractFunction Added checks for broken control flow

SureYeaah updated this revision to Diff 218053. SureYeaah marked 4 inline comments as done. SureYeaah added a comment. Addressed review comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66732/new/ https://reviews.llvm.org/D66732 Files: clan

[PATCH] D66732: [Clangd] ExtractFunction Added checks for broken control flow

This revision was automatically updated to reflect the committed changes. Closed by commit rL370455: [Clangd] ExtractFunction Added checks for broken control flow (authored by SureYeaah, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit

[PATCH] D98493: [WoA][MSVC] Use default linker setting in MSVC-compatible driver

SureYeaah added a comment. What if CLANG_DEFAULT_LINKER=ld? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D98493/new/ https://reviews.llvm.org/D98493 ___ cfe-commits mailing list cfe-commits@lists.llvm.or

[PATCH] D98493: [WoA][MSVC] Use default linker setting in MSVC-compatible driver

SureYeaah added a comment. We are seeing some internal breakage in google because CLANG_DEFAULT_LINKER is set to ld. It would be nice to make the tests more tolerant. Can we revert this patch until then? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.or

[PATCH] D93956: Revert "[LoopDeletion] Allows deletion of possibly infinite side-effect free loops"

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG8bee4d4e8f54: Revert "[LoopDeletion] Allows deletion of possibly infinite side-effect free… (authored by bgraur, committed by SureYeaah). Repositor

<    1   2