[PATCH] D101462: Make it possible for targets to define their own MCObjectFileInfo

shafik added inline comments. Comment at: lldb/source/Plugins/Disassembler/LLVMC/DisassemblerLLVMC.cpp:909 + new llvm::MCContext(llvm::Triple(triple), asm_info_up.get(), + reg_info_up.get(), nullptr, subtarget_info_up.get())); if (!context_up) --

[PATCH] D101462: Make it possible for targets to define their own MCObjectFileInfo

shafik added inline comments. Comment at: clang/lib/Parse/ParseStmtAsm.cpp:589 + TheTarget->createMCObjectFileInfo( + /*PIC*/ false, Ctx)); + Ctx.setObjectFileInfo(MOFI.get()); `/*PIC=*/false` Comment at: llvm/tools/llvm-mca/llvm

[PATCH] D116155: [clang][AST][ASTImporter] Set record to complete during import of its members.

shafik added inline comments. Comment at: clang/lib/AST/ASTImporter.cpp:2021 + // fields imported) at that time without multiple AST import passes. + To->setCompleteDefinition(true); // Complete the definition even if error is returned. So `DefinitionComplet

[PATCH] D115355: Fix build failure with GCC 11 in C++20 mode

shafik added a comment. LGTM but I want to give a chance for others to chime in. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115355/new/ https://reviews.llvm.org/D115355 ___ cfe-commits mailing list cf

[PATCH] D98951: [clang][ASTImporter] Add import API for 'const Type *' (NFC).

shafik accepted this revision. shafik added a comment. Can we add a test for the `getCapturedVLAType` case? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D98951/new/ https://reviews.llvm.org/D98951 ___ cf

[PATCH] D99062: [clang][ASTImporter] Import "CapturedVLAType" in FieldDecl.

shafik accepted this revision. shafik added a comment. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99062/new/ https://reviews.llvm.org/D99062 ___ cfe-commits mailing list cfe-commits@lists.llvm.or

[PATCH] D98951: [clang][ASTImporter] Add import API for 'const Type *' (NFC).

shafik added a comment. Thank you for adding the test! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D98951/new/ https://reviews.llvm.org/D98951 ___ cfe-commits mailing list cfe-commits@lists.llvm.org htt

[PATCH] D99188: [clang][ASTImporter] Add import of DeducedTemplateSpecializationType.

shafik accepted this revision. shafik added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99188/new/ https://reviews.llvm.org/D99188 ___ c

[PATCH] D99421: [ASTImporter] Import member specialization/instantiation of enum decls

shafik accepted this revision. shafik added a comment. This revision is now accepted and ready to land. LGTM Comment at: clang/unittests/AST/ASTImporterTest.cpp:6256 + EXPECT_TRUE(ToD); + EXPECT_TRUE(ToD->getMemberSpecializationInfo()); +} Is it worth also ve

[PATCH] D99250: [DebugInfo] Fix the mismatching of C++ language tags and Dwarf versions.

shafik added a comment. In D99250#2657390 , @aprantl wrote: >> If LLDB actually does _not_ have behavior change based on dialect, then we >> might as well control language codes based on DWARF version, and the patch >> should proceed. > > @shafik Can you

[PATCH] D99576: [ASTImporter][NFC] Improve test coverage

shafik accepted this revision. shafik added a comment. Thank you for adding these tests! LGTM Comment at: clang/unittests/AST/ASTImporterTest.cpp:3078 + EXPECT_TRUE(ToField->isBitField()); + EXPECT_EQ(3u, ToField->getBitWidthValue(ToTU->getASTContext())); +}

[PATCH] D94067: [clang][ASTImporter] Fix a possible assertion failure `NeedsInjectedClassNameType(Decl)'.

shafik added inline comments. Comment at: clang/lib/AST/ASTImporter.cpp:2901 + // Skip the declaration if injected type is already set. + if (isa(RI->getTypeForDecl())) +continue; Is this to fix the bug or is this for efficiency sake

[PATCH] D94067: [clang][ASTImporter] Fix a possible assertion failure `NeedsInjectedClassNameType(Decl)'.

shafik added inline comments. Comment at: clang/lib/AST/ASTImporter.cpp:2901 + // Skip the declaration if injected type is already set. + if (isa(RI->getTypeForDecl())) +continue; balazske wrote: > shafik wrote: > > Is this to fix th

[PATCH] D94786: [clang][ASTImporter] Add support for importing CXXFoldExpr.

shafik added inline comments. Comment at: clang/unittests/AST/ASTImporterTest.cpp:655 + Lang_CXX17, "", Lang_CXX17, Verifier, + functionTemplateDecl(hasDescendant(cxxFoldExpr(; +} Is it possible to check that we imported four fold expr

[PATCH] D94786: [clang][ASTImporter] Add support for importing CXXFoldExpr.

shafik accepted this revision. shafik added a comment. LGTM, thank you for expanding the test! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D94786/new/ https://reviews.llvm.org/D94786 ___ cfe-commits mai

[PATCH] D112013: [clang][ASTImporter] Fix for importing functions with EST_Unevaluated prototype.

shafik added inline comments. Comment at: clang/unittests/AST/ASTImporterTest.cpp:6180 + ASSERT_FALSE(FromCtor->getTypeSourceInfo()); + // Set a TypeSourceInfo for the function, this state may occur in reality. + TypeSourceInfo *FromTSI = FromTU->getASTContext().getTrivialType

[PATCH] D112013: [clang][ASTImporter] Fix for importing functions with EST_Unevaluated prototype.

shafik added inline comments. Comment at: clang/unittests/AST/ASTImporterTest.cpp:6180 + ASSERT_FALSE(FromCtor->getTypeSourceInfo()); + // Set a TypeSourceInfo for the function, this state may occur in reality. + TypeSourceInfo *FromTSI = FromTU->getASTContext().getTrivialType

[PATCH] D109608: [clang][ASTImporter] Generic attribute import handling (first step).

shafik added inline comments. Comment at: clang/lib/AST/ASTImporter.cpp:711 + +/*template +friend struct AttrArgImporter; Looks like left over unused code? Comment at: clang/lib/AST/ASTImporter.cpp:8448 + +class AttrImporter { + Error

<    7   8   9   10   11   12