[PATCH] D99037: [Matrix] Implement C-style explicit type conversions for matrix types

SaurabhJha added inline comments. Comment at: clang/test/CodeGen/matrix-cast.c:82 + +void cast_unsigned_short_int_to_unsigned_int(unsigned_short_int_5x5 s, unsigned_int_5x5 i) { + // CHECK-LABEL: define{{.*}} void @cast_unsigned_short_int_to_unsigned_int(<25 x i16> %s, <25 x i

[PATCH] D99037: [Matrix] Implement C-style explicit type conversions for matrix types

SaurabhJha added a comment. The windows build failure is solved by itself and its all passing now! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99037/new/ https://reviews.llvm.org/D99037 ___ cfe-commits

[PATCH] D99037: [Matrix] Implement C-style explicit type conversions for matrix types

SaurabhJha added a comment. > LGTM, thanks for working on this! Thanks so much Florian. Can you please also commit this on my behalf as I don't have commit access? Cheers. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99037/new/ https://reviews.l

[PATCH] D99037: [Matrix] Implement C-style explicit type conversions for matrix types

SaurabhJha added a comment. In D99037#2678779 , @fhahn wrote: > Will create a new patch to address your last comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99037/new/ https://reviews.llvm.org/D990

[PATCH] D99037: [Matrix] Implement C-style explicit type conversions for matrix types

SaurabhJha updated this revision to Diff 336395. SaurabhJha added a comment. Replace `matrices` with `matrixes` in comments and rewrite the comment about element types Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99037/new/ https://reviews.llvm.o

[PATCH] D99037: [Matrix] Implement C-style explicit type conversions for matrix types

SaurabhJha added a comment. In D99037#2679131 , @fhahn wrote: > In D99037#2678848 , @SaurabhJha > wrote: > >> In D99037#2678779 , @fhahn wrote: >> >>> >> >> Will create a n

<    1   2