https://github.com/rniwa updated
https://github.com/llvm/llvm-project/pull/130554
>From d2edd9b5fd188476e59790c333497516933532bb Mon Sep 17 00:00:00 2001
From: Ryosuke Niwa
Date: Sun, 9 Mar 2025 23:06:33 -0700
Subject: [PATCH 1/3] [alpha.webkit.ForwardDeclChecker] Add a new WebKit
checker for
https://github.com/rniwa created
https://github.com/llvm/llvm-project/pull/127182
Allow VisitArrayInitLoopExpr, VisitArrayInitIndexExpr, and VisitOpaqueValueExpr
in trivial functions and statements.
>From 2be47498ca7597748ee8b29f5d39d74608c2f4d3 Mon Sep 17 00:00:00 2001
From: Ryosuke Niwa
Dat
https://github.com/rniwa created
https://github.com/llvm/llvm-project/pull/126996
None
>From f7eafbfd258fb0acf60a01d033958f859c426ff3 Mon Sep 17 00:00:00 2001
From: Ryosuke Niwa
Date: Wed, 12 Feb 2025 17:52:45 -0800
Subject: [PATCH] [WebKit Checkers] Treat offsetof as a trivial expression.
--
https://github.com/rniwa updated
https://github.com/llvm/llvm-project/pull/126996
>From f7eafbfd258fb0acf60a01d033958f859c426ff3 Mon Sep 17 00:00:00 2001
From: Ryosuke Niwa
Date: Wed, 12 Feb 2025 17:52:45 -0800
Subject: [PATCH 1/2] [WebKit Checkers] Treat offsetof as a trivial expression.
---
https://github.com/rniwa updated
https://github.com/llvm/llvm-project/pull/126996
>From f7eafbfd258fb0acf60a01d033958f859c426ff3 Mon Sep 17 00:00:00 2001
From: Ryosuke Niwa
Date: Wed, 12 Feb 2025 17:52:45 -0800
Subject: [PATCH 1/3] [WebKit Checkers] Treat offsetof as a trivial expression.
---
https://github.com/rniwa updated
https://github.com/llvm/llvm-project/pull/127182
>From 2be47498ca7597748ee8b29f5d39d74608c2f4d3 Mon Sep 17 00:00:00 2001
From: Ryosuke Niwa
Date: Fri, 14 Feb 2025 00:48:36 -0800
Subject: [PATCH 1/2] [alpha.webkit.UncountedCallArgsChecker] Allow
ArrayInitLoopExp
https://github.com/rniwa closed https://github.com/llvm/llvm-project/pull/127570
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/rniwa updated
https://github.com/llvm/llvm-project/pull/127554
>From d6c4e1a23dc0cc6850c5cfdceecc2e1be8943592 Mon Sep 17 00:00:00 2001
From: Ryosuke Niwa
Date: Mon, 17 Feb 2025 18:18:09 -0800
Subject: [PATCH 1/4] [alpha.webkit.UnretainedLocalVarsChecker] Add a checker
for lo
@@ -3668,6 +3668,12 @@ Here are some examples of situations that we warn about
as they *might* be poten
RefCountable* uncounted = counted.get(); // warn
}
+alpha.webkit.UnretainedLocalVarsChecker
+"""
+The goal of this rule is to
@@ -332,6 +345,14 @@ class UncheckedCallArgsChecker final : public
RawPtrRefCallArgsChecker {
return isUncheckedPtr(QT);
}
+ bool isSafePtr(const CXXRecordDecl *Record) const final {
+return isRefCounted(Record) || isCheckedPtr(Record);
+ }
+
+ bool isSafePtrType
https://github.com/rniwa updated
https://github.com/llvm/llvm-project/pull/128641
>From a4cd301d6176a8ee3441d0c74f6d2c4e32a50cdd Mon Sep 17 00:00:00 2001
From: Ryosuke Niwa
Date: Mon, 24 Feb 2025 23:01:31 -0800
Subject: [PATCH 1/2] [alpha.webkit.NoUnretainedMemberChecker] Add a new WebKit
chec
https://github.com/rniwa created
https://github.com/llvm/llvm-project/pull/128651
Add a new WebKit checker for checking that lambda captures of CF types use
RetainPtr either when ARC is disabled or enabled, and those of NS types use
RetainPtr when ARC is disabled.
>From dc53e0602fcec63bdd1bc8
https://github.com/rniwa updated
https://github.com/llvm/llvm-project/pull/128651
>From dc53e0602fcec63bdd1bc84325ecc16a3f3e293b Mon Sep 17 00:00:00 2001
From: Ryosuke Niwa
Date: Mon, 24 Feb 2025 23:39:13 -0800
Subject: [PATCH 1/2] [alpha.webkit.UnretainedLambdaCapturesChecker] Add a
WebKit ch
https://github.com/rniwa created
https://github.com/llvm/llvm-project/pull/128641
Add a new WebKit checker for member variables and instance variables of NS and
CF types. A member variable or instance variable to a CF type should be
RetainPtr regardless of whether ARC is enabled or disabled, a
https://github.com/rniwa created
https://github.com/llvm/llvm-project/pull/128586
This PR adds alpha.webkit.UnretainedCallArgsChecker by generalizing
RawPtrRefLocalVarsChecker. It checks call arguments of NS or CF types are
backed by a RetainPtr or not. The new checker is effective for NS and
https://github.com/rniwa updated
https://github.com/llvm/llvm-project/pull/128586
>From 90403f77295c0b3e4415263754e22b3c66f31876 Mon Sep 17 00:00:00 2001
From: Ryosuke Niwa
Date: Mon, 24 Feb 2025 13:43:04 -0800
Subject: [PATCH 1/2] [alpha.webkit.UnretainedCallArgsChecker] Add a checker
for NS
@@ -332,6 +345,14 @@ class UncheckedCallArgsChecker final : public
RawPtrRefCallArgsChecker {
return isUncheckedPtr(QT);
}
+ bool isSafePtr(const CXXRecordDecl *Record) const final {
+return isRefCounted(Record) || isCheckedPtr(Record);
+ }
+
+ bool isSafePtrType
https://github.com/rniwa closed https://github.com/llvm/llvm-project/pull/127554
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/rniwa updated
https://github.com/llvm/llvm-project/pull/128586
>From 90403f77295c0b3e4415263754e22b3c66f31876 Mon Sep 17 00:00:00 2001
From: Ryosuke Niwa
Date: Mon, 24 Feb 2025 13:43:04 -0800
Subject: [PATCH 1/3] [alpha.webkit.UnretainedCallArgsChecker] Add a checker
for NS
@@ -117,6 +127,9 @@ bool tryToFindPtrOrigin(
E = call->getArg(0);
continue;
}
+
+if (safeGetName(callee) == "__builtin___CFStringMakeConstantString")
rniwa wrote:
This is for CFSTR.
https://github.com/llvm/llvm-project/pull
@@ -28,6 +29,15 @@ bool tryToFindPtrOrigin(
std::function isSafePtrType,
std::function callback) {
while (E) {
+if (auto *DRE = dyn_cast(E)) {
+ auto *ValDecl = DRE->getDecl();
+ auto QT = ValDecl->getType();
+ auto ValName = ValDecl->getName();
+
https://github.com/rniwa updated
https://github.com/llvm/llvm-project/pull/128586
>From 90403f77295c0b3e4415263754e22b3c66f31876 Mon Sep 17 00:00:00 2001
From: Ryosuke Niwa
Date: Mon, 24 Feb 2025 13:43:04 -0800
Subject: [PATCH 1/5] [alpha.webkit.UnretainedCallArgsChecker] Add a checker
for NS
https://github.com/rniwa updated
https://github.com/llvm/llvm-project/pull/128586
>From 90403f77295c0b3e4415263754e22b3c66f31876 Mon Sep 17 00:00:00 2001
From: Ryosuke Niwa
Date: Mon, 24 Feb 2025 13:43:04 -0800
Subject: [PATCH 1/6] [alpha.webkit.UnretainedCallArgsChecker] Add a checker
for NS
https://github.com/rniwa created
https://github.com/llvm/llvm-project/pull/128679
Add a new WebKit checker to validate the correct use of RetainPtr constructor
as well as adoptNS and adoptCF functions. adoptNS and adoptCf are used for +1
semantics and RetainPtr constructor is used for +0 seman
https://github.com/rniwa updated
https://github.com/llvm/llvm-project/pull/128679
>From b4001f95cf6d35f59ef8af6df8f2bdbe043da380 Mon Sep 17 00:00:00 2001
From: Ryosuke Niwa
Date: Tue, 25 Feb 2025 00:47:45 -0800
Subject: [PATCH 1/2] [alpha.webkit.webkit.RetainPtrCtorAdoptChecker] Add a new
WebK
@@ -332,6 +345,14 @@ class UncheckedCallArgsChecker final : public
RawPtrRefCallArgsChecker {
return isUncheckedPtr(QT);
}
+ bool isSafePtr(const CXXRecordDecl *Record) const final {
+return isRefCounted(Record) || isCheckedPtr(Record);
+ }
+
+ bool isSafePtrType
https://github.com/rniwa updated
https://github.com/llvm/llvm-project/pull/127554
>From d6c4e1a23dc0cc6850c5cfdceecc2e1be8943592 Mon Sep 17 00:00:00 2001
From: Ryosuke Niwa
Date: Mon, 17 Feb 2025 18:18:09 -0800
Subject: [PATCH 1/7] [alpha.webkit.UnretainedLocalVarsChecker] Add a checker
for lo
https://github.com/rniwa updated
https://github.com/llvm/llvm-project/pull/128679
>From b4001f95cf6d35f59ef8af6df8f2bdbe043da380 Mon Sep 17 00:00:00 2001
From: Ryosuke Niwa
Date: Tue, 25 Feb 2025 00:47:45 -0800
Subject: [PATCH 1/3] [alpha.webkit.webkit.RetainPtrCtorAdoptChecker] Add a new
WebK
https://github.com/rniwa created
https://github.com/llvm/llvm-project/pull/133755
Prior to this PR, we were emitting warnings for Objective-C ivars and
properties if the forward declaration of the type appeared first in a
non-system header. This PR fixes the checker so tha we'd ignore ivars an
https://github.com/rniwa closed https://github.com/llvm/llvm-project/pull/133605
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
rniwa wrote:
Thanks for the review!
https://github.com/llvm/llvm-project/pull/133605
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/rniwa updated
https://github.com/llvm/llvm-project/pull/132316
>From 642057c409b1c3b98ee4ecb16e95b5fb5be47a01 Mon Sep 17 00:00:00 2001
From: Ryosuke Niwa
Date: Thu, 20 Mar 2025 17:54:22 -0700
Subject: [PATCH 1/3] [alpha.webkit.RetainPtrCtorAdoptChecker] Support
adopt(cast(co
https://github.com/rniwa created
https://github.com/llvm/llvm-project/pull/132316
This PR adds the support for recognizing calling adoptCF/adoptNS on the result
of a cast operation on the return value of a function which creates NS or CF
types. It also fixes a bug that we weren't reporting mem
https://github.com/rniwa updated
https://github.com/llvm/llvm-project/pull/132833
>From ca50deea7d8096b065d2bf7aa5e007afc8f0a954 Mon Sep 17 00:00:00 2001
From: Ryosuke Niwa
Date: Mon, 24 Mar 2025 14:22:28 -0700
Subject: [PATCH 1/5] [alpha.webkit.RawPtrRefMemberChecker] The checker doesn't
warn
https://github.com/rniwa closed https://github.com/llvm/llvm-project/pull/132833
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
rniwa wrote:
Thank you!
https://github.com/llvm/llvm-project/pull/133804
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -133,6 +141,36 @@ class RawPtrRefMemberChecker
std::optional IsCompatible = isPtrCompatible(QT, IvarCXXRD);
if (IsCompatible && *IsCompatible)
reportBug(Ivar, IvarType, IvarCXXRD, CD);
+} else {
+ std::optional IsCompatible = isPtrCompatible(QT,
https://github.com/rniwa created
https://github.com/llvm/llvm-project/pull/132784
Recognize dynamic_objc_cast, checked_objc_cast, dynamic_cf_cast, and
checked_cf_cast.
>From aed6967708809b964c4969ec4e6477dade61132d Mon Sep 17 00:00:00 2001
From: Ryosuke Niwa
Date: Mon, 24 Mar 2025 10:13:16 -0
rniwa wrote:
Thanks for the review!
https://github.com/llvm/llvm-project/pull/138042
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/rniwa closed https://github.com/llvm/llvm-project/pull/138995
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
rniwa wrote:
Thanks for the review!
https://github.com/llvm/llvm-project/pull/138995
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/rniwa created
https://github.com/llvm/llvm-project/pull/138995
Functions in std::ranges namespace does not store the lambada passed-in as an
arugment in heap so treat such an argument as if it has [[noescape]] in the
WebKit lambda capture checker so that we don't emit warnin
https://github.com/rniwa updated
https://github.com/llvm/llvm-project/pull/138995
Rate limit ยท GitHub
body {
background-color: #f6f8fa;
color: #24292e;
font-family: -apple-system,BlinkMacSystemFont,Segoe
UI,Helvetica,Arial,sans-ser
https://github.com/rniwa closed https://github.com/llvm/llvm-project/pull/138068
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/rniwa closed https://github.com/llvm/llvm-project/pull/138042
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/rniwa updated
https://github.com/llvm/llvm-project/pull/138042
>From d03c8bb9915ff20c3936525a11a8ef113805b124 Mon Sep 17 00:00:00 2001
From: Ryosuke Niwa
Date: Sun, 27 Apr 2025 16:52:13 -0700
Subject: [PATCH 1/2] [RawPtrRefMemberChecker] Add the support for union and
pointer
https://github.com/rniwa updated
https://github.com/llvm/llvm-project/pull/138995
>From d4b5f004e2d91e8d821e20bee6fcb43b87701b9d Mon Sep 17 00:00:00 2001
From: Ryosuke Niwa
Date: Wed, 7 May 2025 16:53:35 -0700
Subject: [PATCH 1/3] [webkit.UncountedLambdaCapturesChecker] Treat every
argument of
@@ -192,7 +202,8 @@ class RawPtrRefMemberChecker
const auto Kind = RD->getTagKind();
// FIMXE: Should we check union members too?
-if (Kind != TagTypeKind::Struct && Kind != TagTypeKind::Class)
+if (Kind != TagTypeKind::Struct && Kind != TagTypeKind::Class &&
-
https://github.com/rniwa created
https://github.com/llvm/llvm-project/pull/141277
This PR adds the WebKit checker support for
[[clang::annotate_type("webkit.pointerconversion")]].
When this attribute is set on the return value of a function, the function is
treated as safe to call anywhere an
https://github.com/rniwa updated
https://github.com/llvm/llvm-project/pull/141293
>From bd7daa355f5c1924475c0818dd4963af7bbffcb1 Mon Sep 17 00:00:00 2001
From: Ryosuke Niwa
Date: Fri, 23 May 2025 13:53:36 -0700
Subject: [PATCH 1/2] [alpha.webkit.NoUnretainedMemberChecker] Recocgnize
NS_REQUIRE
https://github.com/rniwa created
https://github.com/llvm/llvm-project/pull/141293
Allow @property of a raw pointer when NS_REQUIRES_PROPERTY_DEFINITIONS is
specified on the interface since such an interface does not automatically
synthesize raw pointer ivars.
>From bd7daa355f5c1924475c0818dd4
https://github.com/rniwa updated
https://github.com/llvm/llvm-project/pull/141293
>From bd7daa355f5c1924475c0818dd4963af7bbffcb1 Mon Sep 17 00:00:00 2001
From: Ryosuke Niwa
Date: Fri, 23 May 2025 13:53:36 -0700
Subject: [PATCH 1/3] [alpha.webkit.NoUnretainedMemberChecker] Recocgnize
NS_REQUIRE
https://github.com/rniwa edited https://github.com/llvm/llvm-project/pull/141293
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/rniwa updated
https://github.com/llvm/llvm-project/pull/141293
>From bcee06004f24f8488bcc8e84170bf3509daa5fd9 Mon Sep 17 00:00:00 2001
From: Ryosuke Niwa
Date: Fri, 23 May 2025 13:53:36 -0700
Subject: [PATCH] [alpha.webkit.NoUnretainedMemberChecker] Recognize
NS_REQUIRES_PRO
701 - 754 of 754 matches
Mail list logo
