[PATCH] D99949: [AMDGPU][OpenMP] Add amdgpu-arch tool to list AMD GPUs installed

pdhaliwal planned changes to this revision. pdhaliwal added a comment. Working on tests. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99949/new/ https://reviews.llvm.org/D99949 ___ cfe-commits mailing l

[PATCH] D99949: [AMDGPU][OpenMP] Add amdgpu-arch tool to list AMD GPUs installed

pdhaliwal updated this revision to Diff 335761. pdhaliwal marked 10 inline comments as done. pdhaliwal added a comment. Addressed review comments. RE test: Since the tool is contingent on the results of HSA API call, adding a test which would always PASS on all the systems with different AMD GPU

[PATCH] D99949: [AMDGPU][OpenMP] Add amdgpu-arch tool to list AMD GPUs installed

pdhaliwal added a comment. On the testing perspective, the tool Comment at: clang/lib/Driver/ToolChains/AMDGPUOpenMP.cpp:208 assert(GPUArch.startswith("gfx") && "Unsupported sub arch"); + assert(!GPUArch.empty() && "Unable to detect system GPU"); JonChest

[PATCH] D99949: [AMDGPU][OpenMP] Add amdgpu-arch tool to list AMD GPUs installed

pdhaliwal updated this revision to Diff 336037. pdhaliwal added a comment. Herald added subscribers: jansvoboda11, dang. - Addressed review comments - Added LIT test case Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99949/new/ https://reviews.llvm

[PATCH] D99949: [AMDGPU][OpenMP] Add amdgpu-arch tool to list AMD GPUs installed

pdhaliwal updated this revision to Diff 336351. pdhaliwal added a comment. Added tests for the failing cases Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99949/new/ https://reviews.llvm.org/D99949 Files: clang/include/clang/Basic/DiagnosticDriv

[PATCH] D99949: [AMDGPU][OpenMP] Add amdgpu-arch tool to list AMD GPUs installed

pdhaliwal updated this revision to Diff 336353. pdhaliwal marked an inline comment as done. pdhaliwal added a comment. Fix permissions Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99949/new/ https://reviews.llvm.org/D99949 Files: clang/include/

[PATCH] D99949: [AMDGPU][OpenMP] Add amdgpu-arch tool to list AMD GPUs installed

pdhaliwal updated this revision to Diff 337640. pdhaliwal added a comment. Rebase and review comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99949/new/ https://reviews.llvm.org/D99949 Files: clang/include/clang/Basic/DiagnosticDriverKinds

[PATCH] D99949: [AMDGPU][OpenMP] Add amdgpu-arch tool to list AMD GPUs installed

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG7029cffc4e78: [AMDGPU][OpenMP] Add amdgpu-arch tool to list AMD GPUs installed (authored by pdhaliwal). Repository: rG LLVM Github Monorepo CHANG

[PATCH] D99949: [AMDGPU][OpenMP] Add amdgpu-arch tool to list AMD GPUs installed

pdhaliwal added a comment. I've reverted this from main for now as there seems to be issue with executing test script on some CI machines. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99949/new/ https://reviews.llvm.org/D99949 __

[PATCH] D99949: [AMDGPU][OpenMP] Add amdgpu-arch tool to list AMD GPUs installed

pdhaliwal updated this revision to Diff 338810. pdhaliwal added a comment. Reopening this. This version is supposed to fix the buildbot failures on PPC machines. Since I don't have PPC machine I am not sure if this will work. But the logic followed here is motivated from Clang :: Driver/program-p

[PATCH] D99949: [AMDGPU][OpenMP] Add amdgpu-arch tool to list AMD GPUs installed

pdhaliwal updated this revision to Diff 338843. pdhaliwal marked 2 inline comments as done. pdhaliwal added a comment. Review comments addressed. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99949/new/ https://reviews.llvm.org/D99949 Files: cla

[PATCH] D99949: [AMDGPU][OpenMP] Add amdgpu-arch tool to list AMD GPUs installed

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG3194761d2763: [AMDGPU][OpenMP] Add amdgpu-arch tool to list AMD GPUs installed (authored by pdhaliwal). Repository: rG LLVM Github Monorepo CHANG

[PATCH] D99949: [AMDGPU][OpenMP] Add amdgpu-arch tool to list AMD GPUs installed

pdhaliwal updated this revision to Diff 339235. pdhaliwal added a comment. Replaced the return commands in test scripts with exit command. It seems like return is handled bit differently on fedora/rhel machines. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.l

[PATCH] D99949: [AMDGPU][OpenMP] Add amdgpu-arch tool to list AMD GPUs installed

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG722d4d8e7585: [AMDGPU][OpenMP] Add amdgpu-arch tool to list AMD GPUs installed (authored by pdhaliwal). Repository: rG LLVM Github Monorepo CHANG

[PATCH] D94060: [OpenMP][AMDGPU] Use AMDGPU_KERNEL calling convention for entry function

pdhaliwal created this revision. pdhaliwal added reviewers: JonChesterfield, jdoerfert, ABataev. Herald added subscribers: guansong, t-tye, tpr, dstuttard, yaxunl, jvesely, kzhuravl. pdhaliwal requested review of this revision. Herald added subscribers: cfe-commits, sstefan1, wdng. Herald added a

[PATCH] D94060: [OpenMP][AMDGPU] Use AMDGPU_KERNEL calling convention for entry function

This revision was automatically updated to reflect the committed changes. Closed by commit rG4909cb1a0fe9: [OpenMP][AMDGPU] Use AMDGPU_KERNEL calling convention for entry function (authored by pdhaliwal). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/

[PATCH] D94961: [OpenMP] Add OpenMP offloading toolchain skeleton for AMDGPU

pdhaliwal created this revision. pdhaliwal added reviewers: jdoerfert, grokos, JonChesterfield, ronlieb, ABataev. Herald added subscribers: kerbowa, guansong, t-tye, tpr, dstuttard, yaxunl, nhaehnle, jvesely, kzhuravl. pdhaliwal requested review of this revision. Herald added subscribers: cfe-comm

[PATCH] D94961: [OpenMP] Add OpenMP offloading toolchain skeleton for AMDGPU

pdhaliwal updated this revision to Diff 317553. pdhaliwal added a comment. Fix clang-tidy error Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D94961/new/ https://reviews.llvm.org/D94961 Files: clang/lib/Driver/ToolChains/AMDGPUOpenMP.cpp clang/

[PATCH] D94961: [OpenMP] Add OpenMP offloading toolchain skeleton for AMDGPU

pdhaliwal updated this revision to Diff 317810. pdhaliwal added a comment. Herald added a subscriber: mgorny. > Won't this just prevent us from building clang due to the missing cmake > changes? It compiles and builds fine, however, I wasn't actually aware such sanity checking being present. It

[PATCH] D94961: [OpenMP] Add OpenMP offloading toolchain for AMDGPU

pdhaliwal updated this revision to Diff 317831. pdhaliwal added a comment. Fixed failing debian tests Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D94961/new/ https://reviews.llvm.org/D94961 Files: clang/lib/Driver/CMakeLists.txt clang/lib/Dri

[PATCH] D94961: [OpenMP] Add OpenMP offloading toolchain for AMDGPU

pdhaliwal updated this revision to Diff 318120. pdhaliwal added a comment. - Moved common methods of HIP and OpenMP to base ROCMToolChain - Removed unnecessary asserts Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D94961/new/ https://reviews.llvm.or

[PATCH] D111218: [AMDGPU][OpenMP] Mark oulined functions always_inline

pdhaliwal created this revision. pdhaliwal added reviewers: JonChesterfield, jdoerfert, jhuber6, ggeorgakoudis. Herald added subscribers: guansong, t-tye, tpr, dstuttard, yaxunl, kzhuravl. pdhaliwal requested review of this revision. Herald added subscribers: cfe-commits, sstefan1, wdng. Herald add

[PATCH] D102107: [OpenMP] Codegen aggregate for outlined function captures

pdhaliwal added a comment. I have created a patch (D111218 ) with fix for amdgcn. This is a temporary fix. I will still keep on looking into it until I find a real root cause. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.l

[PATCH] D111218: [AMDGPU][OpenMP] Mark oulined functions always_inline

pdhaliwal planned changes to this revision. pdhaliwal added a comment. I don't have any concrete evidence but I have some doubt on presence of function pointers causing backend to behave improperly. Also, here removing optnone alone suffices to fix the issue. Repository: rG LLVM Github Monor

[PATCH] D111218: [AMDGPU][OpenMP] Mark oulined functions always_inline

pdhaliwal updated this revision to Diff 377502. pdhaliwal added a comment. Only removing optnone. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111218/new/ https://reviews.llvm.org/D111218 Files: clang/lib/CodeGen/CGStmtOpenMP.cpp Index: clang

[PATCH] D108552: [OpenMP][AMDGCN] Enable complex functions

pdhaliwal created this revision. pdhaliwal added reviewers: JonChesterfield, ronlieb, ye-luo, jdoerfert, yaxunl, scchan, b-sumner. Herald added subscribers: guansong, jvesely. pdhaliwal requested review of this revision. Herald added subscribers: cfe-commits, sstefan1. Herald added a project: clan

[PATCH] D108774: [OpenMP][FIX] Allow declare variant to work with reference types

pdhaliwal accepted this revision. pdhaliwal added a comment. Confirmed locally that this fixes the linking issue. It has fixed the linking issue on amdgcn as well. Thanks for working on this. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108774/new

[PATCH] D109344: [AMDGPU][OpenMP] Use complex definitions from complex_cmath.h

pdhaliwal created this revision. pdhaliwal added reviewers: ye-luo, jdoerfert, ronlieb, JonChesterfield. Herald added subscribers: guansong, t-tye, tpr, dstuttard, yaxunl, jvesely, kzhuravl. pdhaliwal requested review of this revision. Herald added subscribers: cfe-commits, sstefan1, wdng. Herald

[PATCH] D109344: [AMDGPU][OpenMP] Use complex definitions from complex_cmath.h

pdhaliwal updated this revision to Diff 371008. pdhaliwal added a comment. Add amdgcn to the same arch list as nvptx Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109344/new/ https://reviews.llvm.org/D109344 Files: clang/lib/Headers/openmp_wrapp

[PATCH] D109344: [AMDGPU][OpenMP] Use complex definitions from complex_cmath.h

pdhaliwal added a comment. Hey, Jon, sorry for late reply. I cannot reproduce this issue on nvptx so it seems to occur only on amdgcn. Will it be better if instead the name mangling issue is fixed? Or for the meantime, I could add #ifdef around as a temporary fix. Suggestions? Repository: r

[PATCH] D109344: [AMDGPU][OpenMP] Use complex definitions from complex_cmath.h

pdhaliwal added a comment. Even with declare variant separated using ifdef's, the error is still there. So I don't think we have workaround for this. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109344/new/ https://reviews.llvm.org/D109344 _

<    1   2