[PATCH] D143507: [RISCV][MC] Mark Zawrs extension as non-experimental

reames accepted this revision. reames added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143507/new/ https://reviews.llvm.org/D143507 ___

[PATCH] D141666: [RISCV] Proper support of extensions Zicsr and Zifencei

reames added a comment. JFYI, I have a change out which just documents current status while we wait for a resolution. https://reviews.llvm.org/D143924 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141666/new/ https://reviews.llvm.org/D141666 ___

[PATCH] D143953: [RISCV] Accept zicsr and zifencei command line options

reames created this revision. reames added reviewers: asb, frasercrmck, kito-cheng, jrtc27, craig.topper. Herald added subscribers: luke, VincentWu, vkmr, jdoerfert, evandro, luismarques, apazos, sameer.abuasal, s.egerton, Jim, benna, psnobl, jocewei, PkmX, the_o, brucehoult, MartinMosbeck, rogfe

[PATCH] D143953: [RISCV] Accept zicsr and zifencei command line options

reames added a comment. @jrtc27 Not sure if this changes your take, but I realized the variant being introduced is maybe much less interesting than I'd first thought. We generally make no effort to make sure an extension was defined in the spec version corresponding to our base revision. Give

[PATCH] D143953: [RISCV] Accept zicsr and zifencei command line options

reames added a comment. In D143953#4124649 , @jrtc27 wrote: > In D143953#4124636 , @reames wrote: > >> @jrtc27 Not sure if this changes your take, but I realized the variant being >> introduced is maybe much less

[PATCH] D143953: [RISCV] Accept zicsr and zifencei command line options

reames updated this revision to Diff 497328. reames edited the summary of this revision. reames added a comment. Add docs, and rework description. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143953/new/ https://reviews.llvm.org/D143953 Files: clang/test/Preprocessor/riscv-target-fe

[PATCH] D143953: [RISCV] Accept zicsr and zifencei command line options

reames updated this revision to Diff 497336. reames added a comment. Address @jrtc27's comments. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143953/new/ https://reviews.llvm.org/D143953 Files: clang/test/Preprocessor/riscv-target-features.c llvm/docs/RISCVUsage.rst llvm/lib/Sup

[PATCH] D143953: [RISCV] Accept zicsr and zifencei command line options

reames added a comment. We seem to have rough consensus here, but I'm going to wait roughly 24 hours before landing to give others time to comment. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143953/new/ https://reviews.llvm.org/D143953 __

[PATCH] D143953: [RISCV] Accept zicsr and zifencei command line options

reames added a comment. This was discussed at today's RISCV sync-up call. We have a large conversion pending on the topic of isa compatibility checking, but there was a consensus that this was reasonable and could move forward. I'm going to be landing this change in the near future. CHANGES

[PATCH] D143953: [RISCV] Accept zicsr and zifencei command line options

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG22e199e6afb1: [RISCV] Accept zicsr and zifencei command line options (authored by reames). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D144288: [RISCV] Add missing plumbing and tests for zfa

reames created this revision. reames added reviewers: craig.topper, asb, Joshua-401, kito-cheng, lbenes, jrtc27. Herald added subscribers: luke, VincentWu, vkmr, frasercrmck, jdoerfert, evandro, luismarques, apazos, sameer.abuasal, s.egerton, Jim, benna, psnobl, jocewei, PkmX, the_o, brucehoult,

[PATCH] D144288: [RISCV] Add missing plumbing and tests for zfa

reames updated this revision to Diff 498512. reames added a comment. Address review comment CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144288/new/ https://reviews.llvm.org/D144288 Files: clang/test/Preprocessor/riscv-target-features.c llvm/lib/Support/RISCVISAInfo.cpp llvm/tes

[PATCH] D144288: [RISCV] Add missing plumbing and tests for zfa

This revision was automatically updated to reflect the committed changes. Closed by commit rG495b65348023: [RISCV] Add missing plumbing and tests for zfa (authored by reames). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144288/new/ https://reviews

[PATCH] D149495: [RISCV] Add support for V extension in SiFive7

reames accepted this revision. reames added a comment. This revision is now accepted and ready to land. LGTM, thought please wait for other review feedback to settle. I am very very happy to have this upstream, thank you! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https:

[PATCH] D147610: [RISCV][MC] Add support for experimental Zfbfmin extension

reames accepted this revision. reames added a comment. This revision is now accepted and ready to land. LGTM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147610/new/ https://reviews.llvm.org/D147610 ___ cfe-commits mailing list cfe-commits@l

[PATCH] D147611: [RISCV][MC] Add support for experimental Zvfbfmin extension

reames accepted this revision. reames added a comment. LGTM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147611/new/ https://reviews.llvm.org/D147611 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mail

[PATCH] D147612: [RISCV][MC] Add support for experimental Zvfbfwma extension

reames accepted this revision. reames added a comment. LGTM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147612/new/ https://reviews.llvm.org/D147612 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mail

[PATCH] D149246: [RISCV] Relax rules for ordering s/z/x prefixed extensions in ISA naming strings

reames accepted this revision. reames added a comment. This revision is now accepted and ready to land. I generally think this is a good idea. I'd ask you add this to RISCVUsage under "The current known variances from the specification are", and mention it at the next sync up call, but otherwis

[PATCH] D148066: [RISCV] Add Smaia and Ssaia extensions support

reames added a comment. In D148066#4294924 , @kito-cheng wrote: >> My concern would be that as we don't gate CSR names on enabling the relevant >> extension, people could start using CSR names and encodings that could >> change, without opting in via -

[PATCH] D149314: [RISCV] Remove support for attribute interrupt("user").

reames added a comment. In D149314#4302300 , @aaron.ballman wrote: > In D149314#4302266 , @asb wrote: > >> In D149314#4302203 , >> @aaron.ballman wrote: >> >>> Is this a

[PATCH] D149710: [RISCV] Add sifive-x280 processor with all of its extensions

reames accepted this revision. reames added a comment. This revision is now accepted and ready to land. Mechanically, this looks fine. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D149710/new/ https://reviews.llvm.org/D149710 _

[PATCH] D117091: [Clang] Add attributes alloc_size and alloc_align to mm_malloc

reames added a comment. In D117091#3265986 , @xbolva00 wrote: > Ping @reames Not qualified to review clang/c++ library semantic changes. Also, did we implement allocalign in LLVM? Last I knew it was a clang only attribute. If we did, it's missing fr

[PATCH] D115003: [funcattrs] Infer writeonly argument attribute [part 2]

reames updated this revision to Diff 397124. reames edited the summary of this revision. reames added a comment. Rework account for only being to infer on nocapture arguments. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115003/new/ https://reviews.llvm.org/D115003 Files: llvm/lib/T

[PATCH] D115003: [funcattrs] Infer writeonly argument attribute [part 2]

reames added inline comments. Comment at: llvm/lib/Transforms/IPO/FunctionAttrs.cpp:728 + } else if (CB.hasFnAttr(Attribute::WriteOnly) || + CB.dataOperandHasImpliedAttr(UseIndex, Attribute::WriteOnly)) { +IsWrite = true; nikic wrote

[PATCH] D115003: [funcattrs] Infer writeonly argument attribute [part 2]

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG0b09313cd533: [funcattrs] Infer writeonly argument attribute [part 2] (authored by reames). Changed prior to commit: https://reviews.llvm.org/D115

[PATCH] D115387: [instcombine] Canonicalize constant index type to i64 for extractelement/insertelement

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGe6ad9ef4e7ae: [instcombine] Canonicalize constant index type to i64 for… (authored by reames). Herald added subscribers: cfe-commits, kerbowa, pengfe

[PATCH] D115021: [funcatts] Rewrite callsite operand handling in memory access inference

reames added a comment. I'm starting to split this into individual pieces with the writeonly dependence removed. The first one handles indirect calls, and is posted as D115916 . Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://review

[PATCH] D115916: [funcattrs] Consistently treat calling a function pointer as a non-capturing read

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG33cbaab1416b: [funcattrs] Consistently treat calling a function pointer as a non-capturing… (authored by reames). Herald added a project: clang. Hera

[PATCH] D115021: [funcatts] Rewrite callsite operand handling in memory access inference

reames added a comment. D115961 and D115964 were the next two pieces of this, both have now landed. The last bit is honoring call site parameter attributes on indirect calls outside the SCC. I'll post that separately and th

[PATCH] D115021: [funcatts] Rewrite callsite operand handling in memory access inference

reames abandoned this revision. reames added a comment. This has been replaced by a series of smaller patches implementing individual parts. The last of which - parameter attributes on indirect calls - is out for review as D116118 . Repository: rG LLVM Gith

[PATCH] D100226: [funcattrs] Add the maximal set of implied attributes to definitions

This revision was automatically updated to reflect the committed changes. Closed by commit rGf549176ad976: [funcattrs] Add the maximal set of implied attributes to definitions (authored by reames). Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github

<    1   2