[PATCH] D37200: [AST] Traverse CXXOperatorCallExpr in LexicallyOrderedRecursiveASTVisitor

2017-09-06 Thread Phabricator via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL312633: [AST] Traverse CXXOperatorCallExpr in LexicallyOrderedRecursiveASTVisitor (authored by krobelus). Changed prior to commit: https://reviews.llvm.org/D37200?vs=112951&id=113999#toc Repository:

[PATCH] D37383: [AST] Add TableGen for StmtDataCollectors

2017-09-06 Thread Phabricator via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL312634: [AST] Add TableGen for StmtDataCollectors (authored by krobelus). Changed prior to commit: https://reviews.llvm.org/D37383?vs=113547&id=114000#toc Repository: rL LLVM https://reviews.llvm.or

[PATCH] D37491: [Preamble] Fixed preamble breaking with BOM presence (and particularly, fluctuating BOM presence)

2017-09-06 Thread Cameron via Phabricator via cfe-commits
cameron314 added a comment. Thanks for the response! > How are various preprocessor offests (and SourceLocation offsets) are > calculated? Do they account for BOM presence and ignore it? Everything is in byte offsets; the `SourceLocation` after the BOM is not the same as before the BOM. The le

[PATCH] D37474: [PCH] Allow VFS to be used for tests that generate PCH files

2017-09-06 Thread Cameron via Phabricator via cfe-commits
cameron314 added a comment. I'll change the overlay to only allow access to the PCH. I agree that it would be nice to only read the PCH using real filesystem APIs in order to be symmetrical, but this seems non-trivial. It also feels like a step in the wrong direction -- ideally the VFS would ho

[PATCH] D37474: [PCH] Allow VFS to be used for tests that generate PCH files

2017-09-06 Thread Cameron via Phabricator via cfe-commits
cameron314 updated this revision to Diff 114016. cameron314 added a comment. Here's an updated patch that allows only the PCH to be accessed from the real FS when a VSF is present. Tests still pass. https://reviews.llvm.org/D37474 Files: lib/Frontend/ASTUnit.cpp unittests/Frontend/CMakeLis

[PATCH] D37474: [PCH] Allow VFS to be used for tests that generate PCH files

2017-09-07 Thread Cameron via Phabricator via cfe-commits
cameron314 added a comment. Looking at the way remapped buffers are handled, I just remembered that they must exist on the file system (at the very least, in a directory that exists) or the remapping is not taken into account. So that pretty much rules out the other approach, I think. https:/

[PATCH] D37491: [Preamble] Fixed preamble breaking with BOM presence (and particularly, fluctuating BOM presence)

2017-09-07 Thread Cameron via Phabricator via cfe-commits
cameron314 added a comment. > Maybe there's a third option option to remove the BOM from the buffer before > passing it to clang? > Could you elaborate on your use-case a little more? Is there no way to > consistently always pass buffers either with or without BOM? > Out of two options you men

[PATCH] D36410: [OpenCL] Handle taking address of block captures

2017-09-07 Thread Phabricator via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL312728: [OpenCL] Handle taking an address of block captures. (authored by stulova). Changed prior to commit: https://reviews.llvm.org/D36410?vs=110015&id=114197#toc Repository: rL LLVM https://revie

[PATCH] D37491: [Preamble] Fixed preamble breaking with BOM presence (and particularly, fluctuating BOM presence)

2017-09-07 Thread Cameron via Phabricator via cfe-commits
cameron314 updated this revision to Diff 114228. cameron314 added a comment. Here's an updated patch. The code required to make it work is much simpler when the BOM is simply ignored :-) https://reviews.llvm.org/D37491 Files: include/clang/Frontend/PrecompiledPreamble.h include/clang/Lex/L

[PATCH] D37565: [Sema] -Wtautological-compare: handle comparison of unsigned with 0S.

2017-09-07 Thread Phabricator via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL312750: [Sema] -Wtautological-compare: handle comparison of unsigned with 0S. (authored by lebedevri). Changed prior to commit: https://reviews.llvm.org/D37565?vs=114260&id=114265#toc Repository: rL

[PATCH] D37382: Fixed a crash in code completion.

2017-09-08 Thread Phabricator via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL312788: Fixed a crash in code completion. (authored by ibiryukov). Repository: rL LLVM https://reviews.llvm.org/D37382 Files: cfe/trunk/lib/Parse/ParseDecl.cpp cfe/trunk/test/CodeCompletion/crash-

[PATCH] D37620: [Sema] Put tautological comparison of unsigned and zero into it's own flag

2017-09-08 Thread Phabricator via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL312792: [Sema] Put tautological comparison of unsigned and zero into it's own flag (authored by lebedevri). Changed prior to commit: https://reviews.llvm.org/D37620?vs=114351&id=114358#toc Repository:

[PATCH] D37624: add support for -fno-instrument-functions and -finstrument-functions-exclude-{file, function}-list= to match gcc options.

2017-09-08 Thread kchoi via Phabricator via cfe-commits
choikwa created this revision. Builds on previous Differential https://reviews.llvm.org/D2219 Changes include: - Using unordered_map with SourceLocation.ID (raw encoding) as key - Demangle only if !isExternC. Used dyn_cast((Decl*)CurFuncDecl) for this - Modified an existing C testcase to test f

[PATCH] D37624: add support for -fno-instrument-functions and -finstrument-functions-exclude-{file, function}-list= to match gcc options.

2017-09-08 Thread kchoi via Phabricator via cfe-commits
choikwa updated this revision to Diff 114380. choikwa added a comment. addressed code review. made doc consistent with functionality. https://reviews.llvm.org/D37624 Files: docs/ClangCommandLineReference.rst include/clang/Driver/Options.td include/clang/Frontend/CodeGenOptions.h lib/Cod

[PATCH] D37624: add support for -fno-instrument-functions and -finstrument-functions-exclude-{file, function}-list= to match gcc options.

2017-09-08 Thread kchoi via Phabricator via cfe-commits
choikwa added a comment. Forgot to hang Cache to CodeGenModule, will do that shortly https://reviews.llvm.org/D37624 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D37624: add support for -fno-instrument-functions and -finstrument-functions-exclude-{file, function}-list= to match gcc options.

2017-09-08 Thread kchoi via Phabricator via cfe-commits
choikwa updated this revision to Diff 114388. choikwa added a comment. renamed and moved Cache to SourceLocToFileNameMap in CodeGenModule https://reviews.llvm.org/D37624 Files: docs/ClangCommandLineReference.rst include/clang/Driver/Options.td include/clang/Frontend/CodeGenOptions.h lib

[PATCH] D37474: [PCH] Allow VFS to be used for tests that generate PCH files

2017-09-08 Thread Cameron via Phabricator via cfe-commits
cameron314 added inline comments. Comment at: lib/Frontend/ASTUnit.cpp:1014 +/// with another virtual file system. +class PCHOverlayFileSystem : public vfs::FileSystem +{ ilya-biryukov wrote: > Maybe create a combination of `InMemoryFileSystem` and `OverlayFileSy

[PATCH] D37474: [PCH] Allow VFS to be used for tests that generate PCH files

2017-09-08 Thread Cameron via Phabricator via cfe-commits
cameron314 updated this revision to Diff 114414. cameron314 added a comment. The latest patch. I think this one should do the trick :-) https://reviews.llvm.org/D37474 Files: include/clang/Frontend/PrecompiledPreamble.h lib/Frontend/ASTUnit.cpp unittests/Frontend/CMakeLists.txt unittest

[PATCH] D37491: [Preamble] Fixed preamble breaking with BOM presence (and particularly, fluctuating BOM presence)

2017-09-08 Thread Cameron via Phabricator via cfe-commits
cameron314 added a comment. It seems there's other users of `PrecompiledPreamble` that would have to be fixed, yes. If we go with my original fix of taking into account the BOM in the preamble bounds, there's no way of reusing the PCH when the BOM appears/disappears. I still maintain this is a

[PATCH] D37668: [X86][intrinsics] lower _mm[256|512]_mask[z]_set1_epi[8|16|32|64] intrinsic to IR

2017-09-10 Thread jina via Phabricator via cfe-commits
jina.nahias created this revision. this is clang part , the llvm part is https://reviews.llvm.org/differential/diff/114515/ https://reviews.llvm.org/D37668 Files: lib/Headers/avx512bwintrin.h lib/Headers/avx512fintrin.h lib/Headers/avx512vlbwintrin.h lib/Headers/avx512vlintrin.h test

[PATCH] D37413: [X86][MS-InlineAsm] Extended support for variables / identifiers on memory / immediate expressions

2017-09-10 Thread coby via Phabricator via cfe-commits
coby updated this revision to Diff 114520. coby added a comment. Herald added a subscriber: eraman. addressed Simon's comments Repository: rL LLVM https://reviews.llvm.org/D37413 Files: include/clang/Parse/Parser.h include/clang/Sema/Sema.h lib/Parse/ParseStmtAsm.cpp lib/Sema/SemaStm

[PATCH] D37413: [X86][MS-InlineAsm] Extended support for variables / identifiers on memory / immediate expressions

2017-09-11 Thread coby via Phabricator via cfe-commits
coby updated this revision to Diff 114536. coby added reviewers: myatsina, m_zuckerman. Repository: rL LLVM https://reviews.llvm.org/D37413 Files: include/clang/Parse/Parser.h include/clang/Sema/Sema.h lib/Parse/ParseStmtAsm.cpp lib/Sema/SemaStmtAsm.cpp test/CodeGen/ms-inline-asm-enu

[PATCH] D37662: [AST] Make RecursiveASTVisitor visit TemplateDecls in source order

2017-09-11 Thread Phabricator via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL312911: [AST] Make RecursiveASTVisitor visit TemplateDecls in source order (authored by krobelus). Repository: rL LLVM https://reviews.llvm.org/D37662 Files: cfe/trunk/include/clang/AST/LexicallyOrd

[PATCH] D37668: [X86][intrinsics] lower _mm[256|512]_mask[z]_set1_epi[8|16|32|64] intrinsic to IR

2017-09-11 Thread jina via Phabricator via cfe-commits
jina.nahias updated this revision to Diff 114594. jina.nahias added a comment. delete from include/clang/Basic/BuiltinsX86.def and include/clang/Basic/BuiltinsX86_64.def https://reviews.llvm.org/D37668 Files: include/clang/Basic/BuiltinsX86.def include/clang/Basic/BuiltinsX86_64.def Inde

[PATCH] D37474: [PCH] Allow VFS to be used for tests that generate PCH files

2017-09-11 Thread Cameron via Phabricator via cfe-commits
cameron314 updated this revision to Diff 114604. cameron314 added a comment. Final diff, will commit soon. Thanks! https://reviews.llvm.org/D37474 Files: include/clang/Frontend/PrecompiledPreamble.h lib/Frontend/ASTUnit.cpp unittests/Frontend/CMakeLists.txt unittests/Frontend/PCHPreambl

[PATCH] D37474: [PCH] Allow VFS to be used for tests that generate PCH files

2017-09-11 Thread Cameron via Phabricator via cfe-commits
cameron314 added inline comments. Comment at: include/clang/Frontend/PrecompiledPreamble.h:100 /// PreambleBounds used to build the preamble PreambleBounds getBounds() const; ilya-biryukov wrote: > Not introduced by this change, but could you also add a f

[PATCH] D37474: [PCH] Allow VFS to be used for tests that generate PCH files

2017-09-11 Thread Cameron via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL312917: [PCH] Allow VFS to be used for tests that generate PCH files (authored by cameron314). Changed prior to commit: https://reviews.llvm.org/D37474?vs=114604&id=114612#toc Repository: rL LLVM ht

[PATCH] D36642: [Lexer] Report more precise skipped regions (PR34166)

2017-09-11 Thread Phabricator via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL312947: [Lexer] Report more precise skipped regions (PR34166) (authored by vedantk). Changed prior to commit: https://reviews.llvm.org/D36642?vs=114433&id=114676#toc Repository: rL LLVM https://revi

[PATCH] D37647: [ubsan-minimal] Document the new runtime

2017-09-11 Thread Phabricator via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL312957: [ubsan-minimal] Document the new runtime (authored by vedantk). Changed prior to commit: https://reviews.llvm.org/D37647?vs=114449&id=114703#toc Repository: rL LLVM https://reviews.llvm.org/

[PATCH] D37649: [Driver] Support ubsan-minimal on Darwin

2017-09-11 Thread Phabricator via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL312958: [Driver] Support ubsan-minimal on Darwin (authored by vedantk). Changed prior to commit: https://reviews.llvm.org/D37649?vs=114458&id=114704#toc Repository: rL LLVM https://reviews.llvm.org/

[PATCH] D37668: [X86][intrinsics] lower _mm[256|512]_mask[z]_set1_epi[8|16|32|64] intrinsic to IR

2017-09-11 Thread jina via Phabricator via cfe-commits
jina.nahias updated this revision to Diff 114765. https://reviews.llvm.org/D37668 Files: include/clang/Basic/BuiltinsX86.def include/clang/Basic/BuiltinsX86_64.def lib/Headers/avx512bwintrin.h lib/Headers/avx512fintrin.h lib/Headers/avx512vlbwintrin.h lib/Headers/avx512vlintrin.h te

[PATCH] D37700: Fix recording preamble's conditional stack in skipped PP branches.

2017-09-12 Thread Phabricator via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL313014: Fix recording preamble's conditional stack in skipped PP branches. (authored by ibiryukov). Repository: rL LLVM https://reviews.llvm.org/D37700 Files: cfe/trunk/lib/Lex/PPDirectives.cpp cf

[PATCH] D37668: [X86][intrinsics] lower _mm[256|512]_mask[z]_set1_epi[8|16|32|64] intrinsic to IR

2017-09-12 Thread jina via Phabricator via cfe-commits
jina.nahias updated this revision to Diff 114836. https://reviews.llvm.org/D37668 Files: include/clang/Basic/BuiltinsX86.def include/clang/Basic/BuiltinsX86_64.def lib/Headers/avx512bwintrin.h lib/Headers/avx512fintrin.h lib/Headers/avx512vlbwintrin.h lib/Headers/avx512vlintrin.h te

[PATCH] D35385: [Driver] Darwin: Link in the profile runtime archive first

2017-09-12 Thread Phabricator via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL313065: [Driver] Darwin: Link in the profile runtime archive first (authored by vedantk). Changed prior to commit: https://reviews.llvm.org/D35385?vs=106538&id=114877#toc Repository: rL LLVM https:/

[PATCH] D37777: [Driver] Disable uwtable by default in -ffreestanding mode

2017-09-12 Thread Phabricator via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL313087: [Driver] Disable uwtable by default in -ffreestanding mode (authored by vedantk). Changed prior to commit: https://reviews.llvm.org/D3?vs=114927&id=114929#toc Repository: rL LLVM https:/

[PATCH] D37598: [ubsan] Enable -fsanitize=function on Darwin

2017-09-12 Thread Phabricator via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL313097: [ubsan] Enable -fsanitize=function test on Darwin (authored by vedantk). Changed prior to commit: https://reviews.llvm.org/D37598?vs=114268&id=114944#toc Repository: rL LLVM https://reviews.

[PATCH] D37597: [ubsan] Function Sanitizer: Don't require writable text segments

2017-09-12 Thread Phabricator via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL313096: [ubsan] Function Sanitizer: Don't require writable text segments (authored by vedantk). Changed prior to commit: https://reviews.llvm.org/D37597?vs=114932&id=114943#toc Repository: rL LLVM h

[PATCH] D37668: [X86][intrinsics] lower _mm[256|512]_mask[z]_set1_epi[8|16|32|64] intrinsic to IR

2017-09-12 Thread jina via Phabricator via cfe-commits
jina.nahias updated this revision to Diff 114978. https://reviews.llvm.org/D37668 Files: include/clang/Basic/BuiltinsX86.def include/clang/Basic/BuiltinsX86_64.def lib/Headers/avx512bwintrin.h lib/Headers/avx512fintrin.h lib/Headers/avx512vlbwintrin.h lib/Headers/avx512vlintrin.h te

[PATCH] D37413: [X86][MS-InlineAsm] Extended support for variables / identifiers on memory / immediate expressions

2017-09-12 Thread coby via Phabricator via cfe-commits
coby added inline comments. Comment at: lib/Sema/SemaStmtAsm.cpp:617 +return; + } else if (Res->isRValue()) { +bool Enum = isa(T) && Res->EvaluateAsRValue(Eval, Context); rnk wrote: > RKSimon wrote: > > (style) Split these instead of an if-elseif chain

[PATCH] D37668: [X86][intrinsics] lower _mm[256|512]_mask[z]_set1_epi[8|16|32|64] intrinsic to IR

2017-09-13 Thread jina via Phabricator via cfe-commits
jina.nahias added inline comments. Comment at: include/clang/Basic/BuiltinsX86.def:981 -TARGET_BUILTIN(__builtin_ia32_pbroadcastd512_gpr_mask, "V16iiV16iUs", "", "avx512f") TARGET_BUILTIN(__builtin_ia32_pbroadcastq512_mem_mask, "V8LLiLLiV8LLiUc", "", "avx512f") TARGET_BUILTIN

[PATCH] D37491: [Preamble] Fixed preamble breaking with BOM presence (and particularly, fluctuating BOM presence)

2017-09-13 Thread Cameron via Phabricator via cfe-commits
cameron314 updated this revision to Diff 115104. cameron314 edited the summary of this revision. cameron314 added a comment. Alright, I've changed the patch so that the preamble takes into account the BOM presence and is invalidated when it changes. This automatically fixes all clients of `Preco

[PATCH] D37491: [Preamble] Fixed preamble breaking with BOM presence (and particularly, fluctuating BOM presence)

2017-09-14 Thread Cameron via Phabricator via cfe-commits
cameron314 added inline comments. Comment at: include/clang/Lex/Lexer.h:52 + /// a BOM is present at the start of the file. + unsigned StartOffset; + /// \brief Size of the preamble in bytes. ilya-biryukov wrote: > We could simplify it further by removing `Sta

[PATCH] D37491: [Preamble] Fixed preamble breaking with BOM presence (and particularly, fluctuating BOM presence)

2017-09-14 Thread Cameron via Phabricator via cfe-commits
cameron314 added inline comments. Comment at: include/clang/Lex/Lexer.h:52 + /// a BOM is present at the start of the file. + unsigned StartOffset; + /// \brief Size of the preamble in bytes. ilya-biryukov wrote: > cameron314 wrote: > > ilya-biryukov wrote: >

[PATCH] D36595: [WebAssembly] Remove invalid lld arguments

2017-09-14 Thread Phabricator via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL313299: [WebAssembly] Remove invliad lld arguments (authored by sbc). Repository: rL LLVM https://reviews.llvm.org/D36595 Files: cfe/trunk/lib/Driver/ToolChains/WebAssembly.cpp Index: cfe/trunk/li

[PATCH] D37873: [WebAssembly] Fix wasm-toolchain.c tests

2017-09-14 Thread Phabricator via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL313307: [WebAssembly] Fix wasm-toolchain.c tests (authored by sbc). Repository: rL LLVM https://reviews.llvm.org/D37873 Files: cfe/trunk/test/Driver/wasm-toolchain.c Index: cfe/trunk/test/Driver/w

[PATCH] D37892: [X86] Use native shuffle vector for the perm2f128 intrinsics

2017-09-15 Thread Phabricator via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL313418: [X86] Use native shuffle vector for the perm2f128 intrinsics (authored by ctopper). Changed prior to commit: https://reviews.llvm.org/D37892?vs=115427&id=115518#toc Repository: rL LLVM https

[PATCH] D37938: [X86] Remove unnecessary extra encodings from the CPU name enum in clang

2017-09-16 Thread Phabricator via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL313462: [X86] Remove unnecessary extra encodings from the CPU name enum in clang (authored by ctopper). Changed prior to commit: https://reviews.llvm.org/D37938?vs=115512&id=115540#toc Repository: rL

[PATCH] D37466: D37461: fixups for existing InlineAsm tests + adding new ones

2017-09-17 Thread coby via Phabricator via cfe-commits
coby added a comment. ping Repository: rL LLVM https://reviews.llvm.org/D37466 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D37413: [X86][MS-InlineAsm] Extended support for variables / identifiers on memory / immediate expressions

2017-09-17 Thread coby via Phabricator via cfe-commits
coby updated this revision to Diff 115564. coby added a comment. addressed @rnk 's suggestions: cuteness out c++ mischief in Repository: rL LLVM https://reviews.llvm.org/D37413 Files: include/clang/Parse/Parser.h include/clang/Sema/Sema.h lib/Parse/ParseStmtAsm.cpp lib/Sema/SemaStmtA

[PATCH] D37941: [X86] Move even more of our CPU to feature mapping switch to use fallthroughs

2017-09-17 Thread Phabricator via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL313497: [X86] Move even more of our CPU to feature mapping switch to use fallthroughs (authored by ctopper). Changed prior to commit: https://reviews.llvm.org/D37941?vs=115517&id=115585#toc Repository:

[PATCH] D37668: [X86][intrinsics] lower _mm[256|512]_mask[z]_set1_epi[8|16|32|64] intrinsic to IR

2017-09-18 Thread jina via Phabricator via cfe-commits
jina.nahias updated this revision to Diff 115622. jina.nahias added a comment. rebase on @craig.topper commit. https://reviews.llvm.org/D37668 Files: include/clang/Basic/BuiltinsX86.def include/clang/Basic/BuiltinsX86_64.def lib/Headers/avx512bwintrin.h lib/Headers/avx512fintrin.h li

[PATCH] D37668: [X86][intrinsics] lower _mm[256|512]_mask[z]_set1_epi[8|16|32|64] intrinsic to IR

2017-09-18 Thread jina via Phabricator via cfe-commits
jina.nahias added inline comments. Comment at: lib/Headers/avx512fintrin.h:9742 #ifdef __x86_64__ static __inline__ __m512i __DEFAULT_FN_ATTRS craig.topper wrote: > Please remove the #ifdef __x86_64__ from this. It should work in 32-bits as > well. the curre

[PATCH] D37903: Fix assume-filename handling in clang-format.el

2017-09-18 Thread Philipp via Phabricator via cfe-commits
phst added a comment. Thanks, generally looks good, but a couple of notes: - This is actually a bug in clang-format, which can easily be triggered with `clang-format -output-replacements-xml -assume-filename '' -offset 0 -length 10 -cursor 5 <<< ' = 1234;'` It's fine to work around bugs,

[PATCH] D37668: [X86][intrinsics] lower _mm[256|512]_mask[z]_set1_epi[8|16|32|64] intrinsic to IR

2017-09-19 Thread jina via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL313624: Lowering Mask Set1 intrinsics to LLVM IR (authored by jina.nahias). Changed prior to commit: https://reviews.llvm.org/D37668?vs=115622&id=115823#toc Repository: rL LLVM https://reviews.llvm.

[PATCH] D37903: Fix assume-filename handling in clang-format.el

2017-09-19 Thread Philipp via Phabricator via cfe-commits
phst added inline comments. Comment at: tools/clang-format/clang-format.el:125 If called interactively uses the region or the current statement if there is no active region. If no style is given uses `clang-format-style'." (interactive Please document the A

[PATCH] D37903: Fix assume-filename handling in clang-format.el

2017-09-19 Thread Philipp via Phabricator via cfe-commits
phst accepted this revision. phst added a comment. This revision is now accepted and ready to land. Your use case sounds good to me. Please be sure to document the new parameter, though. Comment at: tools/clang-format/clang-format.el:154 + `("-outpu

[PATCH] D37042: Teach clang to tolerate the 'p = nullptr + n' idiom used by glibc

2017-09-19 Thread Phabricator via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL313666: Teach clang to tolerate the 'p = nullptr + n' idiom used by glibc (authored by akaylor). Changed prior to commit: https://reviews.llvm.org/D37042?vs=115262&id=115889#toc Repository: rL LLVM

[PATCH] D37629: [Sema] Move some stuff into -Wtautological-unsigned-enum-zero-compare

2017-09-19 Thread Phabricator via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL313677: [Sema] Move some stuff into -Wtautological-unsigned-enum-zero-compare (authored by lebedevri). Changed prior to commit: https://reviews.llvm.org/D37629?vs=115890&id=115903#toc Repository: rL

[PATCH] D37972: [clangd] Introduced Logger interface.

2017-09-20 Thread Phabricator via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL313730: [clangd] Introduced Logger interface. (authored by ibiryukov). Repository: rL LLVM https://reviews.llvm.org/D37972 Files: clang-tools-extra/trunk/clangd/CMakeLists.txt clang-tools-extra/tr

[PATCH] D37629: [Sema] Move some stuff into -Wtautological-unsigned-enum-zero-compare

2017-09-20 Thread Phabricator via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL313745: [Sema] Move some stuff into -Wtautological-unsigned-enum-zero-compare (authored by lebedevri). Changed prior to commit: https://reviews.llvm.org/D37629?vs=115903&id=115977#toc Repository: rL

[PATCH] D38032: [clangd] Serialize onDiagnosticsReady callbacks for the same file.

2017-09-20 Thread Phabricator via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL313754: [clangd] Serialize onDiagnosticsReady callbacks for the same file. (authored by ibiryukov). Repository: rL LLVM https://reviews.llvm.org/D38032 Files: clang-tools-extra/trunk/clangd/ClangdSe

[PATCH] D38077: [clangd] Put inacessible items to the end of completion list.

2017-09-20 Thread Phabricator via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL313759: [clangd] Put inacessible items to the end of completion list. (authored by ibiryukov). Repository: rL LLVM https://reviews.llvm.org/D38077 Files: clang-tools-extra/trunk/clangd/ClangdUnit.cp

[PATCH] D37491: [Preamble] Fixed preamble breaking with BOM presence (and particularly, fluctuating BOM presence)

2017-09-20 Thread Cameron via Phabricator via cfe-commits
cameron314 updated this revision to Diff 116043. cameron314 added a comment. Final diff. Test passes! https://reviews.llvm.org/D37491 Files: include/clang/Frontend/PrecompiledPreamble.h include/clang/Lex/Lexer.h include/clang/Lex/PreprocessorOptions.h lib/Frontend/FrontendActions.cpp

[PATCH] D37491: [Preamble] Fixed preamble breaking with BOM presence (and particularly, fluctuating BOM presence)

2017-09-20 Thread Cameron via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL313796: [PCH] Fixed preamble breaking with BOM presence (and particularly, fluctuating… (authored by cameron314). Changed prior to commit: https://reviews.llvm.org/D37491?vs=116043&id=116049#toc Reposi

[PATCH] D37978: [analyzer] Fix an assertion fail in VirtualCallChecker

2017-09-21 Thread Phabricator via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL313866: [analyzer] Fix an assertion fail in VirtualCallChecker (authored by xazax). Changed prior to commit: https://reviews.llvm.org/D37978?vs=115656&id=116145#toc Repository: rL LLVM https://revie

[PATCH] D38123: [driver] [cl] Add/fix c++17/c++latest

2017-09-21 Thread daxpedda via Phabricator via cfe-commits
daxpedda created this revision. Current "/std:c++latest" adds "-std=c++17", VS has it's own "/std:c++17" for that now. This is my first commit by the way, please tell me if there is anything I can do to improve. Thanks. https://reviews.llvm.org/D38123 Files: lib/Driver/ToolChains/Clang.cpp

[PATCH] D38123: [driver] [cl] Add/fix c++17/c++latest

2017-09-21 Thread daxpedda via Phabricator via cfe-commits
daxpedda updated this revision to Diff 116154. daxpedda added a comment. Discovered that these flags were tested and added new test. https://reviews.llvm.org/D38123 Files: lib/Driver/ToolChains/Clang.cpp test/Driver/cl-options.c Index: test/Driver/cl-options.c

[PATCH] D38123: [driver] [cl] Add/fix c++17/c++latest

2017-09-21 Thread daxpedda via Phabricator via cfe-commits
daxpedda added a comment. According to this the default is still c++14. I do not have commit access, I would prefer if somebody else commits this in my stead. Comment at: test/Driver

[PATCH] D35796: [analyzer] Delete with non-virtual destructor check

2017-09-22 Thread Phabricator via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL313973: [analyzer] Add new delete with non-virtual destructor check (authored by xazax). Changed prior to commit: https://reviews.llvm.org/D35796?vs=116060&id=116319#toc Repository: rL LLVM https://

[PATCH] D34512: Add preliminary Cross Translation Unit support library

2017-09-22 Thread Phabricator via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL313975: Add Cross Translation Unit support library (authored by xazax). Changed prior to commit: https://reviews.llvm.org/D34512?vs=116195&id=116327#toc Repository: rL LLVM https://reviews.llvm.org/

[PATCH] D38081: Set completion priority of destructors and operators to CCP_Unlikely.

2017-09-22 Thread Phabricator via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL314019: Set completion priority of destructors and operators to CCP_Unlikely. (authored by ibiryukov). Repository: rL LLVM https://reviews.llvm.org/D38081 Files: cfe/trunk/lib/Sema/SemaCodeComplete.

[PATCH] D37903: Fix assume-filename handling in clang-format.el

2017-09-25 Thread Philipp via Phabricator via cfe-commits
phst added inline comments. Comment at: tools/clang-format/clang-format.el:123 +(defun clang-format-region (start end &optional style assume-file-name) + "Use clang-format to format the code between START and END according to STYLE +using ASSUME-FILE-NAME to locate a style confi

[PATCH] D38231: fixing a bug in mask[z]_set1

2017-09-25 Thread jina via Phabricator via cfe-commits
jina.nahias created this revision. https://reviews.llvm.org/D38231 Files: lib/Headers/avx512vlintrin.h Index: lib/Headers/avx512vlintrin.h === --- lib/Headers/avx512vlintrin.h +++ lib/Headers/avx512vlintrin.h @@ -5761,15 +5761,15

[PATCH] D38231: fixing a bug in mask[z]_set1

2017-09-25 Thread jina via Phabricator via cfe-commits
jina.nahias updated this revision to Diff 116513. https://reviews.llvm.org/D38231 Files: lib/Headers/avx512vlintrin.h test/CodeGen/avx512vl-builtins.c Index: test/CodeGen/avx512vl-builtins.c === --- test/CodeGen/avx512vl-builti

[PATCH] D62623: Reduce memory consumption of coverage dumps

2019-05-30 Thread serge via Phabricator via cfe-commits
serge-sans-paille added a comment. @kwk: looks like you're still compiling with clang-7, this patch is to be applied on the master version of LLVM/clang, then you can install it and use it to recompile llvm/lld with coverage info. Does it make sense to you? Repository: rG LLVM Github Monore

[PATCH] D62690: Modify StepsLeft counter behaivior for constexprs

2019-05-30 Thread wasiher via Phabricator via cfe-commits
wasiher created this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. When I was trying to remove limits from constexpr steps (I wanted to give compiler as much time as it it needs), I found -fconstexpr-steps option. Naively i decided that -fconstexpr-steps=-1 is

[PATCH] D62657: [OpenCL] Fix OpenCL/SPIR version metadata

2019-05-30 Thread Phabricator via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rC362102: [OpenCL] Fix OpenCL/SPIR version metadata in C++ mode. (authored by stulova, committed by ). Herald added a project: clang. Changed prior to commit: https://reviews.llvm.org/D62657?vs=202169&id=

[PATCH] D62693: Support codesigning bundles and forcing

2019-05-30 Thread Phabricator via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL362169: Support codesigning bundles and forcing (authored by cbieneman, committed by ). Changed prior to commit: https://reviews.llvm.org/D62693?vs=202239&id=202320#toc Repository: rL LLVM CHANGES S

[PATCH] D62709: Fix -DBUILD_SHARED_LIBS=ON build after rL362160

2019-05-30 Thread Phabricator via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL362180: Fix -DBUILD_SHARED_LIBS=ON build after rL362160 (authored by sbc, committed by ). Changed prior to commit: https://reviews.llvm.org/D62709?vs=202335&id=202343#toc Repository: rL LLVM CHANGES

[PATCH] D62399: [clang] Add storage for APValue in ConstantExpr

2019-05-31 Thread Tyker via Phabricator via cfe-commits
Tyker added a comment. Herald added a subscriber: rnkovacs. ping @rsmith Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62399/new/ https://reviews.llvm.org/D62399 ___ cfe-commits mailing list cfe-commits@lists.llvm.or

[PATCH] D62445: [test] Fix plugin tests

2019-06-02 Thread Phabricator via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL362328: [test] Fix plugin tests (authored by dhinton, committed by ). Changed prior to commit: https://reviews.llvm.org/D62445?vs=202573&id=202605#toc Repository: rL LLVM CHANGES SINCE LAST ACTION

[PATCH] D62638: [analyzer] A Python script to prettify the ExplodedGraph dumps.

2019-06-02 Thread Phabricator via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL362340: [analyzer] exploded-graph-rewriter: Initial commit. (authored by dergachev, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit: https:

[PATCH] D62616: [CodeComplete] Add a bit more whitespace to completed patterns

2019-06-03 Thread Phabricator via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL362363: [CodeComplete] Add a bit more whitespace to completed patterns (authored by ibiryukov, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commi

[PATCH] D62729: [ARM] Fix recent breakage of -mfpu=none.

2019-06-03 Thread Phabricator via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL362380: [ARM] Fix recent breakage of -mfpu=none. (authored by statham, committed by ). Herald added a subscriber: kristina. Changed prior to commit: https://reviews.llvm.org/D62729?vs=202681&id=202688#t

[PATCH] D62299: [PR41567][Sema] Fixed cast kind in addr space conversions

2019-06-03 Thread Phabricator via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL362409: [PR41567][Sema] Fixed cast kind in addr space conversions (authored by stulova, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit: ht

[PATCH] D61446: Generalize the pass registration mechanism used by Polly to any third-party tool

2019-06-03 Thread serge via Phabricator via cfe-commits
serge-sans-paille updated this revision to Diff 202795. serge-sans-paille added a comment. Herald added a project: clang. Herald added a subscriber: cfe-commits. - provide minimal documentation - fix testing configuration - validate locally with both shared and static libraries, using monorepo or

[PATCH] D61790: [C++20] add Basic consteval specifier

2019-06-03 Thread Tyker via Phabricator via cfe-commits
Tyker added a comment. @rsmith ping CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61790/new/ https://reviews.llvm.org/D61790 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D59467: [clang] Adding the Likelihood Attribute from C++2a

2019-06-04 Thread Tyker via Phabricator via cfe-commits
Tyker reclaimed this revision. Tyker added a comment. I closed it originally because it was inactive and i was working on other reviews. but i learned this is not how it is supposed to be done. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59467/new/ https://reviews.llvm.org/D59467

[PATCH] D60763: Prototype OpenCL BIFs using Tablegen

2019-06-04 Thread Pierre via Phabricator via cfe-commits
Pierre added a comment. In D60763#1527870 , @thakis wrote: > From what I can tell, the only client of OpenCLBuiltins.td is currently > lib/Sema. Do you expect that to change? If not, does it make more sense to > move the .td file to there? > > Do you exp

[PATCH] D62615: [CodeComplete] Include more text into typed chunks of pattern completions

2019-06-04 Thread Phabricator via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL362479: [CodeComplete] Include more text into typed chunks of pattern completions (authored by ibiryukov, committed by ). Herald added subscribers: llvm-commits, arphaman. Herald added a project: LLVM. Ch

[PATCH] D62476: [clangd] Support offsets for parameters in signatureHelp

2019-06-04 Thread Phabricator via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL362481: [clangd] Support offsets for parameters in signatureHelp (authored by ibiryukov, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit: h

[PATCH] D62623: Reduce memory consumption of coverage dumps

2019-06-04 Thread serge via Phabricator via cfe-commits
serge-sans-paille updated this revision to Diff 202896. serge-sans-paille marked an inline comment as done. serge-sans-paille added a comment. Update comment + force reduced memory consumption. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62623/new

[PATCH] D61446: Generalize the pass registration mechanism used by Polly to any third-party tool

2019-06-04 Thread serge via Phabricator via cfe-commits
serge-sans-paille updated this revision to Diff 202908. serge-sans-paille added a comment. - reorder registration to make sure options are correctly taken into account - make LINK_POLLY_INTO_TOOLS obsolete in favor of just using LLVM_LINK_POLLY_INTO_TOOLS Repository: rG LLVM Github Monorepo

[PATCH] D61446: Generalize the pass registration mechanism used by Polly to any third-party tool

2019-06-04 Thread serge via Phabricator via cfe-commits
serge-sans-paille added a comment. @philip.pfaffe : NewPM integeration actually works thanks to ``Register${Name}Passes(llvm::PassBuilder &PB)``. It's already used by Polly for NewPM integration and we mimic that. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://revie

[PATCH] D61446: Generalize the pass registration mechanism used by Polly to any third-party tool

2019-06-04 Thread serge via Phabricator via cfe-commits
serge-sans-paille added a comment. @beanz turns out the depdendency problem was just a matter of moving the `register_llvm_extension` call at the top of the file. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61446/new/ https://reviews.llvm.org/D6

[PATCH] D61446: Generalize the pass registration mechanism used by Polly to any third-party tool

2019-06-04 Thread serge via Phabricator via cfe-commits
serge-sans-paille updated this revision to Diff 202950. serge-sans-paille added a comment. Take into account @philip.pfaffe remarks and improve support for new PM. - harmonize static/dynamic loading, although two functions are still needed, one for dynamic loading and one for static loading (new

[PATCH] D62623: Reduce memory consumption of coverage dumps

2019-06-04 Thread serge via Phabricator via cfe-commits
serge-sans-paille added inline comments. Comment at: clang/lib/CodeGen/CoverageMappingGen.cpp:1393 + size_t CoverageMappingSize = 0; + for (auto &S : CoverageMappings) { +CoverageMappingSize += S.size(); vsk wrote: > It doesn't look like the CoverageMapping

[PATCH] D61446: Generalize the pass registration mechanism used by Polly to any third-party tool

2019-06-04 Thread serge via Phabricator via cfe-commits
serge-sans-paille updated this revision to Diff 203029. serge-sans-paille added a comment. - make it possible for client code to speicify the registration function for new PM, thanks @philip.pfaffe for the hint. @Meinersbur this should be ok now. CHANGES SINCE LAST ACTION https://reviews.llvm

[PATCH] D62780: msabi: Fix exponential mangling time for even more contrived inputs

2019-06-04 Thread Phabricator via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL362560: msabi: Fix exponential mangling time for even more contrived inputs (authored by nico, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commi

[PATCH] D61446: Generalize the pass registration mechanism used by Polly to any third-party tool

2019-06-04 Thread serge via Phabricator via cfe-commits
serge-sans-paille updated this revision to Diff 203086. serge-sans-paille added a comment. - get Rid of the constraint on initializePasses : it can be registered suing a static constructor, no need to clutter the API with it Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION htt

<    17   18   19   20   21   22   23   24   25   26   >