[PATCH] D57674: [clang-tidy] Add options to bugprone-argument-comment to add missing argument comments to literals

MyDeveloperDay updated this revision to Diff 185385. MyDeveloperDay marked 6 inline comments as done. MyDeveloperDay added a comment. Address review comments CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57674/new/ https://reviews.llvm.org/D57674 Files: clang-tidy/bugprone/ArgumentCo

[PATCH] D57674: [clang-tidy] Add options to bugprone-argument-comment to add missing argument comments to literals

MyDeveloperDay marked an inline comment as done. MyDeveloperDay added inline comments. Comment at: clang-tidy/bugprone/ArgumentCommentCheck.cpp:257 Ctx->getLangOpts()); }; @aaron.ballman, slight aside (and not in the code

[PATCH] D57813: [clangd] Enable clangd on Objective-C in VSCode

This revision was automatically updated to reflect the committed changes. Closed by commit rCTE353295: [clangd] Enable clangd on Objective-C in VSCode (authored by ibiryukov, committed by ). Changed prior to commit: https://reviews.llvm.org/D57813?vs=185518&id=185534#toc Repository: rCTE Cla

[PATCH] D57814: [clangd] Update dev dependencies of clangd-vscode

This revision was automatically updated to reflect the committed changes. Closed by commit rL353296: [clangd] Update dev dependencies of clangd-vscode (authored by ibiryukov, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit: https://

[PATCH] D57787: [clang-tidy] modernize-avoid-c-arrays: avoid main function (PR40604)

This revision was automatically updated to reflect the committed changes. Closed by commit rL353327: [clang-tidy] modernize-avoid-c-arrays: avoid main function (PR40604) (authored by lebedevri, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to

[PATCH] D57674: [clang-tidy] Add options to bugprone-argument-comment to add missing argument comments to literals

MyDeveloperDay updated this revision to Diff 185632. MyDeveloperDay marked 5 inline comments as done. MyDeveloperDay added a comment. -Address review comments -Ignore argument comment addition for macro inputs -Add unit tests to cover the above -Fix clang-tidy suggestion (from readability-identifi

[PATCH] D57674: [clang-tidy] Add options to bugprone-argument-comment to add missing argument comments to literals

MyDeveloperDay marked 3 inline comments as done. MyDeveloperDay added inline comments. Comment at: clang-tidy/bugprone/ArgumentCommentCheck.cpp:1 -//===--- ArgumentCommentCheck.cpp - clang-tidy ===// // aaron.ballman wrote: > Why did

[PATCH] D57619: [analyzer] Canonicalize variable declarations in VarRegion objects.

This revision was automatically updated to reflect the committed changes. Closed by commit rL353353: [analyzer] Canonicalize declarations within variable regions. (authored by dergachev, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit

[PATCH] D54976: [analyzer] Got rid of the `Z3ConstraintManager` class

This revision was automatically updated to reflect the committed changes. Closed by commit rC353371: Got rid of the `Z3ConstraintManager` class (authored by mramalho, committed by ). Herald added a project: clang. Herald added a subscriber: cfe-commits. Changed prior to commit: https://reviews.

[PATCH] D54977: [analyzer] Moved the whole SMT API to a single file. NFC.

This revision was automatically updated to reflect the committed changes. Closed by commit rC353372: Moved the whole SMT API to a single file. NFC. (authored by mramalho, committed by ). Herald added a project: clang. Herald added a subscriber: cfe-commits. Changed prior to commit: https://revi

[PATCH] D54978: Move the SMT API to LLVM

This revision was automatically updated to reflect the committed changes. Closed by commit rC353373: Move the SMT API to LLVM (authored by mramalho, committed by ). Herald added a project: clang. Herald added a subscriber: cfe-commits. Changed prior to commit: https://reviews.llvm.org/D54978?vs

[PATCH] D57824: [OpenCL][PR40603] In C++ preserve backwards compatibility with OpenCL C v2.0

This revision was automatically updated to reflect the committed changes. Closed by commit rL353431: [OpenCL][PR40603] In C++ preserve compatibility with OpenCL C v2.0 (authored by stulova, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to com

[PATCH] D57896: Variable names rule

MyDeveloperDay added a comment. does the readability-identifier-naming check need to be changed to support multiple allowed case types? - key: readability-identifier-naming.VariableCase value:camelBack,CamelBack Repository: rG LLVM Github Monorepo CHANGES SINCE L

[PATCH] D40988: Clang-format: add finer-grained options for putting all arguments on one line

aol-nnov added a comment. would love such a feature too! also, there is kind of similar review https://reviews.llvm.org/D14484?id=39647 (by @djasper , also rejected. which is really sad) CHANGES SINCE LAST ACTION https://reviews.llvm.org/D40988/new/ https://reviews.llvm.org/D40988 __

[PATCH] D57674: [clang-tidy] Add options to bugprone-argument-comment to add missing argument comments to literals

MyDeveloperDay updated this revision to Diff 185947. MyDeveloperDay marked 2 inline comments as done. MyDeveloperDay added a comment. Pre-Commit Changes - add FIXME wording to test - move local header include after libraries - rebase CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57674/n

[PATCH] D57896: Variable names rule

MyDeveloperDay added a comment. > I personally would be happy to change the settings from `camelBack` to > `aNy_CasE`. Should we come up with a new style? UpperOrLowerCamelCase, I don't mind going and doing that in the readability-identifier-naming check, given that I just wrote up all the

[PATCH] D57674: [clang-tidy] Add options to bugprone-argument-comment to add missing argument comments to literals

This revision was automatically updated to reflect the committed changes. Closed by commit rL353535: [clang-tidy] Add options to bugprone-argument-comment to add missing argument… (authored by paulhoad, committed by ). Herald added a project: LLVM. Changed prior to commit: https://reviews.llvm

[PATCH] D57966: [clang-tidy] add camelBackOrCase casing style to readability-identifier-naming to support change to variable naming policy (if adopted)

MyDeveloperDay created this revision. MyDeveloperDay added reviewers: michaelplatings, aaron.ballman, JonasToth, hokein. MyDeveloperDay added a project: clang-tools-extra. Herald added a subscriber: xazax.hun. Herald added a project: clang. Introduction of a new variable policy (as outlined in D5

[PATCH] D57961: [X86] Add explicit alignment to __m128/__m128i/__m128d/etc. to allow matching of MSVC behavior with #pragma pack.

This revision was automatically updated to reflect the committed changes. Closed by commit rC353555: [X86] Add explicit alignment to __m128/__m128i/__m128d/etc. to allow matching… (authored by ctopper, committed by ). Changed prior to commit: https://reviews.llvm.org/D57961?vs=185996&id=186015

[PATCH] D57976: -gmodules: Don't emit incomplete breadcrumbs pointing to nonexistant PCM files.

This revision was automatically updated to reflect the committed changes. Closed by commit rL353578: -gmodules: Don't emit incomplete breadcrumbs pointing to nonexistant PCM files. (authored by adrian, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed

[PATCH] D57981: [analyzer] strlcat() syntax check: Fix an off-by-one error.

This revision was automatically updated to reflect the committed changes. Closed by commit rL353583: [analyzer] CStringSyntaxChecks: Fix an off-by-one error in the strlcat() check. (authored by dergachev, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Chang

[PATCH] D40854: [clang-tidy] WIP implement cppcoreguidelines check for mixed integer arithmetic

MyDeveloperDay added inline comments. Herald added a project: clang. Comment at: clang-tidy/cppcoreguidelines/MixedIntArithmeticCheck.h:1 +//===--- MixedIntArithmeticCheck.h - clang-tidy--*- C++ -*-===// +// I guess the license has to be updated

[PATCH] D33841: [clang-tidy] redundant keyword check

MyDeveloperDay added inline comments. Comment at: clang-tidy/readability/RedundantExternCheck.cpp:45 + + int offset = Text.find("extern"); + current convention would be that this should be Offset CHANGES SINCE LAST ACTION https://reviews.llvm.org/D33841/new/

[PATCH] D57528: [tools] Fix python DeprecationWarning: invalid escape sequence

serge-sans-paille accepted this revision. serge-sans-paille added a comment. This revision is now accepted and ready to land. Herald added a project: clang. LGTM, do you have commit right? Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57528/new/ https://reviews.l

[PATCH] D57662: [clang-tidy] Parallelise clang-tidy-diff.py

MyDeveloperDay added a comment. Just a question.. If clang tidy is running with -fix in parallel, what stops each clang-tidy invocation altering a common header at the same time? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57662/new/ https://reviews.llvm.org/D57662 ___

[PATCH] D57896: Variable names rule

MyDeveloperDay added a comment. > Sounds good to me. I see that you've made D57966 > a child of this issue, but we could swap > the dependency around so that once your patch is applied I can update this > patch to use `camelBackOrCase`. I'm OK if we want to do

[PATCH] D57662: [clang-tidy] Parallelise clang-tidy-diff.py

MyDeveloperDay added a comment. > You are right. May be it worth disabling `-fix` for `j != 1`. I only say this because I think I might have seen it happen when I was running `run-clang-tidy.py` over a large code base with a fairly aggressive check/fixit, but frankly I was too new to LLVM to kn

[PATCH] D57528: [tools] Fix python DeprecationWarning: invalid escape sequence

This revision was automatically updated to reflect the committed changes. Closed by commit rL353707: [tools] Fix python DeprecationWarning: invalid escape sequence (authored by serge_sans_paille, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior

[PATCH] D57528: [tools] Fix python DeprecationWarning: invalid escape sequence

serge-sans-paille added a comment. @MarcoFalke it's in, thanks for the patch o/ Repository: rL LLVM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57528/new/ https://reviews.llvm.org/D57528 ___ cfe-commits mailing list cfe-commits@lists.l

[PATCH] D58061: Fix a few tests that were missing ':' on CHECK lines and weren't testing anything.

This revision was automatically updated to reflect the committed changes. Closed by commit rC353744: Fix a few tests that were missing ':' on CHECK lines and weren't testing… (authored by nico, committed by ). Herald added a project: clang. Changed prior to commit: https://reviews.llvm.org/D580

[PATCH] D57918: Add an attribute that causes clang to emit fortified calls to C stdlib functions

This revision was automatically updated to reflect the committed changes. Closed by commit rL353765: Add a new attribute, fortify_stdlib (authored by epilk, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.llvm.org/D

[PATCH] D10833: Retrieve BinaryOperator::getOpcode and BinaryOperator::getOpcodeStr via libclang and its python interface

dyhe83 added a comment. In D10833#970906 , @milianw wrote: > still looks good to me. can someone else please review and commit this? ping Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D10833/new/ https://reviews.llvm.org/

[PATCH] D58111: [Sema] Fix a crash in access checking for deduction guides

This revision was automatically updated to reflect the committed changes. Closed by commit rC353840: [Sema] Fix a crash in access checking for deduction guides (authored by ibiryukov, committed by ). Changed prior to commit: https://reviews.llvm.org/D58111?vs=186447&id=186450#toc Repository:

[PATCH] D57977: [HIP] compile option code-object-v3 propagate to llc

This revision was automatically updated to reflect the committed changes. Closed by commit rC353880: [HIP] Handle compile -m options and propagate into LLC (authored by aaronenyeshi, committed by ). Changed prior to commit: https://reviews.llvm.org/D57977?vs=186528&id=186534#toc Repository:

[PATCH] D58178: [clang-tidy] RawStringLiteralCheck: isRawStringLiteral doesn't check all erroneous cases

MyDeveloperDay added a comment. Rather than sending a review, probably the reproducible case as to why it crash is more important, it might be better to write up your bug at https://bugs.llvm.org/ I tried to repoduce this and I can't see how I could make a string literal without a double quote

[PATCH] D58152: [Sema] Delay checking whether objc_designated_initializer is being applied to an init method

This revision was automatically updated to reflect the committed changes. Closed by commit rC353976: [Sema] Delay checking whether objc_designated_initializer is being applied to… (authored by epilk, committed by ). Changed prior to commit: https://reviews.llvm.org/D58152?vs=186712&id=186717#t

[PATCH] D58161: Print a note to the called macro when diagnosing err_embedded_directive

This revision was automatically updated to reflect the committed changes. Closed by commit rL354009: Print a note to the called macro when diagnosing err_embedded_directive (authored by nico, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to c

[PATCH] D57948: [Sema] Fix a regression introduced in "[AST][Sema] Remove CallExpr::setNumArgs"

This revision was automatically updated to reflect the committed changes. Closed by commit rC354035: [Sema] Fix a regression introduced in "[AST][Sema] Remove CallExpr::setNumArgs" (authored by brunoricci, committed by ). Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.o

[PATCH] D57936: [CodeGenObjC] When available, emit a direct call to objc_alloc_init(cls) instead of [objc_alloc(cls) init]

This revision was automatically updated to reflect the committed changes. Closed by commit rC354056: [CodeGenObjC] Emit [[X alloc] init] as objc_alloc_init(X) when available (authored by epilk, committed by ). Changed prior to commit: https://reviews.llvm.org/D57936?vs=186784&id=186894#toc Rep

[PATCH] D58157: Stop enabling clang-tools-extra automatically when clang is in LLVM_ENABLE_PROJECTS

This revision was automatically updated to reflect the committed changes. Closed by commit rL354057: Stop enabling clang-tools-extra automatically when clang is in… (authored by nico, committed by ). Herald added a project: LLVM. Changed prior to commit: https://reviews.llvm.org/D58157?vs=18655

[PATCH] D58145: [Sema] Fix a bogus -Wconversion warning

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rL354074: [Sema] Fix-up a -Wfloat-conversion diagnostic (authored by epilk, committed by ). Herald added a project: LLVM. He

[PATCH] D58254: [Sema] Diagnose floating point conversions based on target semantics

This revision was automatically updated to reflect the committed changes. Closed by commit rC354190: [Sema] Diagnose floating point conversions based on target semantics (authored by epilk, committed by ). Herald added a project: clang. Changed prior to commit: https://reviews.llvm.org/D58254?v

[PATCH] D57087: [clang-tidy] add OverrideMacro to modernize-use-override check

MyDeveloperDay updated this revision to Diff 187155. MyDeveloperDay marked 10 inline comments as done. MyDeveloperDay added a comment. Address review comments - change OverrideMacro to OverrideSpelling - change FinalMacro to FinalSpelling - fix unit tests - show warning without fix-it if Macros a

[PATCH] D57087: [clang-tidy] add OverrideMacro to modernize-use-override check

MyDeveloperDay added inline comments. Comment at: clang-tidy/modernize/UseOverrideCheck.cpp:32 +: ClangTidyCheck(Name, Context), + OverrideMacro(Options.get("OverrideMacro", "override")), + FinalMacro(Options.get("FinalMacro", "final")) {} alexfh wr

[PATCH] D57267: [AST] Factor out the logic of the various Expr::Ignore*

This revision was automatically updated to reflect the committed changes. Closed by commit rL354215: [AST] Factor out the logic of the various Expr::Ignore* (authored by brunoricci, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit: h

[PATCH] D47127: [RISCV] Default enable RISCV linker relaxation

This revision was automatically updated to reflect the committed changes. Closed by commit rC354222: [RISCV] Default enable RISCV linker relaxation (authored by shiva, committed by ). Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D47127/new/ https://reviews.llvm.or

[PATCH] D50488: [Analyzer] Checker for non-determinism caused by sorting of pointer-like elements

whisperity added a comment. Yeah, it seems upstream has moved away due to @Szelethus' implementation of a much more manageable "checker dependency" system. You most likely will have to rebase your patch first, then check what you missed which got added to other merged, existing checkers. Repo

[PATCH] D57087: [clang-tidy] add OverrideMacro to modernize-use-override check

MyDeveloperDay added a comment. In D57087#1400578 , @malcolm.parsons wrote: > Some Clang warnings use PP.getLastMacroWithSpelling() to determine the user's > macro automatically. This would be a neat trick, but mainly I think users would either be usin

[PATCH] D49754: Add -m(no-)spe, and e500 CPU definitions and support to clang

vit9696 added a comment. @jhibbits, @kthomsen, it appears that current patchset has issues when handling && on me. I have it applied over llvm 8.0.0 rc2, and the following code returns 0 to me with -O2 and below: #include #define FEQUAL(x,y) (((x) - (y)) < 0.01) // could put fabs if

[PATCH] D28462: clang-format: Add new style option AlignConsecutiveMacros

MyDeveloperDay added a comment. @djasper and @klimek you both look relatively inactive in the last couple of weeks/month, is there anyone else who acts as a gate keeper for clang-format or can anyone add a LGTM? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D28462/new/ https://reviews.

[PATCH] D58387: [clangd] Add an option in the code to not display number of fixes

This revision was automatically updated to reflect the committed changes. Closed by commit rL354349: [clangd] Add an option in the code to not display number of fixes (authored by ibiryukov, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to co

[PATCH] D49754: Add -m(no-)spe, and e500 CPU definitions and support to clang

vit9696 added a comment. This is a series of patches, which I believe should merged altogether. Currently the following patches are relevant: - https://reviews.llvm.org/D49754 - https://reviews.llvm.org/D54409 - https://reviews.llvm.org/D54583 - https://reviews.llvm.org/D56703 The patches are i

[PATCH] D58404: [clang-format] Add basic support for formatting C# files

MyDeveloperDay created this revision. MyDeveloperDay added reviewers: djasper, klimek, krasimir, benhamilton, JonasToth. MyDeveloperDay added a project: clang. Herald added subscribers: jdoerfert, mgorny. This revision adds basic support for formatting C# files with clang-format, I know the barr

[PATCH] D49754: Add -m(no-)spe, and e500 CPU definitions and support to clang

vit9696 added a comment. @nemanjai, sorry, under merging I meant committing into llvm upstream. Comment at: lib/Basic/Targets/PPC.cpp:318 + Features["spe"] = llvm::StringSwitch(CPU) +.Case("e500", true) +.Case("8548", true) -

[PATCH] D58440: [clangd] Store index in '.clangd/index' instead of '.clangd-index'

This revision was automatically updated to reflect the committed changes. Closed by commit rL354505: [clangd] Store index in '.clangd/index' instead of '.clangd-index' (authored by ibiryukov, committed by ). Changed prior to commit: https://reviews.llvm.org/D58440?vs=187627&id=187629#toc Repos

[PATCH] D58447: [clangd] Fix a crash in Selection

This revision was automatically updated to reflect the committed changes. Closed by commit rL354507: [clangd] Fix a crash in Selection (authored by ibiryukov, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.llvm.org

[PATCH] D58365: [attributes] Add a MIG server routine attribute.

This revision was automatically updated to reflect the committed changes. Closed by commit rL354530: [attributes] Add an attribute for server routines in Mach kernel and extensions. (authored by dergachev, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Chan

[PATCH] D57523: Fix uninitialized value in ABIArgInfo

serge-sans-paille added a comment. @hans agreed; Thanks for taking the time to try to reproduce the original issue o/ Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57523/new/ https://reviews.llvm.org/D57523 ___ cfe-

[PATCH] D57523: Fix uninitialized value in ABIArgInfo

This revision was automatically updated to reflect the committed changes. Closed by commit rL354546: [NFC] Always initialize all members in ABIArgInfo (authored by serge_sans_paille, committed by ). Herald added a project: LLVM. Changed prior to commit: https://reviews.llvm.org/D57523?vs=184529

[PATCH] D57896: Variable names rule

MyDeveloperDay added a comment. In D57896#1402280 , @zturner wrote: > Since someone already accepted this, I suppose I should mark require changes > to formalize my dissent As it was Chris @lattner who accepted it, is your request for changes just base

[PATCH] D52150: [clang-format] BeforeHash added to IndentPPDirectives

MyDeveloperDay added a comment. Could you add some text into the docs/ReleaseNotes.rst to say you are adding a new option take a look at https://clang.llvm.org/extra/ReleaseNotes.html#improvements-to-clang-tidy for an example CHANGES SINCE LAST ACTION https://reviews.llvm.org/D52150/new/

[PATCH] D52150: [clang-format] BeforeHash added to IndentPPDirectives

MyDeveloperDay marked an inline comment as done. MyDeveloperDay added inline comments. Comment at: lib/Format/UnwrappedLineFormatter.cpp:15 #include #define DEBUG_TYPE "format-formatter" Nice! its the irony of clang-format code is that its not clang formatte

[PATCH] D58178: [clang-tidy] RawStringLiteralCheck: isRawStringLiteral doesn't check all erroneous cases

MyDeveloperDay added a comment. Could I ask if you don't want to pursue this review that you Abandon it. Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58178/new/ https://reviews.llvm.org/D58178 ___ cfe-

[PATCH] D57687: [clang-format] Add style option AllowShortLambdasOnASingleLine

MyDeveloperDay added a comment. Could you add a line in the docs/ReleaseNotes.rst to say what you are adding CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57687/new/ https://reviews.llvm.org/D57687 ___ cfe-commits mailing list cfe-commits@l

[PATCH] D57687: [clang-format] Add style option AllowShortLambdasOnASingleLine

MyDeveloperDay added inline comments. Comment at: clang/lib/Format/Format.cpp:649 LLVMStyle.AllowShortIfStatementsOnASingleLine = false; + LLVMStyle.AllowShortLambdasOnASingleLine = FormatStyle::SLS_All; LLVMStyle.AllowShortLoopsOnASingleLine = false; What

[PATCH] D58178: [clang-tidy] RawStringLiteralCheck: isRawStringLiteral doesn't check all erroneous cases

MyDeveloperDay added a comment. In D58178#1405430 , @gmit wrote: > In D58178#1405397 , @MyDeveloperDay > wrote: > > > Could I ask if you don't want to pursue this review that you Abandon it. > > > Sure, I already w

[PATCH] D58404: [clang-format] Add basic support for formatting C# files

MyDeveloperDay updated this revision to Diff 187748. MyDeveloperDay added a comment. Add to release notes CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58404/new/ https://reviews.llvm.org/D58404 Files: docs/ClangFormat.rst docs/ClangFormatStyleOptions.rst docs/ReleaseNotes.rst

[PATCH] D28462: clang-format: Add new style option AlignConsecutiveMacros

MyDeveloperDay added a comment. I'm not a code owner here but we seem to be lacking people who are either available, able, willing or allowed to approve code reviews for some of the code in the clang-tooling (not just clang format). The code owners do an extremely good job at doing a deep revi

[PATCH] D28462: clang-format: Add new style option AlignConsecutiveMacros

MyDeveloperDay added a comment. In D28462#1405711 , @klimek wrote: > In D28462#1405360 , @MyDeveloperDay > wrote: > > > I'm not a code owner here but we seem to be lacking people who are either > > available, able

[PATCH] D28462: clang-format: Add new style option AlignConsecutiveMacros

MyDeveloperDay added a comment. > Yes, we are, and as you said, it needs a set of patches to learn the code > base enough to contribute, to build up trust. This is easiest when the code > base is currently under active development, but many people consider > clang-format "good enough" minus bug

[PATCH] D58404: [clang-format] Add basic support for formatting C# files

MyDeveloperDay added a comment. Note to self...Underdevelopment: - adding support for => (JSBigArrow) for C# Lambas - adding support for $"liternal {string} with arguments" CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58404/new/ https://reviews.llvm.org/D58404 _

[PATCH] D57896: Variable names rule

MyDeveloperDay added a comment. In D57896#1406336 , @zturner wrote: > ... I can't argue with anything you say.. but I guess to reinforce your point introducing what is effectively a 3rd style would likely cause even more jarring... Repository: rG

[PATCH] D57896: Variable names rule

MyDeveloperDay added a comment. In D57896#1406407 , @zturner wrote: > If I read the post correctly, it was actually agreeing with me (because it > said "to reinforce your point...". Meaning that something such as > `lowerCaseCamel` would be the third st

[PATCH] D57558: [analyzer] MIGChecker: A checker for Mach Interface Generator calling convention.

This revision was automatically updated to reflect the committed changes. Closed by commit rC354635: [analyzer] MIGChecker: A checker for Mach Interface Generator conventions. (authored by dergachev, committed by ). Herald added a subscriber: cfe-commits. Changed prior to commit: https://review

[PATCH] D58368: [analyzer] MIGChecker: Implement bug reporter visitors.

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rL354641: [analyzer] MIGChecker: Improve intermediate diagnostic notes. (authored by dergachev, committed by ). Herald added

[PATCH] D58392: [analyzer] MIGChecker: Fix false negatives for releases in automatic destructors.

This revision was automatically updated to reflect the committed changes. Closed by commit rL354642: [analyzer] MIGChecker: Fix an FN when the object is released in a destructor. (authored by dergachev, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed

[PATCH] D58397: [analyzer] MIGChecker: Pour more data into the checker.

This revision was automatically updated to reflect the committed changes. Closed by commit rL354643: [analyzer] MIGChecker: Add support for more APIs. (authored by dergachev, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit: https://

[PATCH] D58404: [clang-format] Add basic support for formatting C# files

MyDeveloperDay updated this revision to Diff 187969. MyDeveloperDay added a comment. Increase C# formatting capabilities - don't split regions markers across lines - lexer support for verbatim string literals - support for interpolated string literals (C#6) - support for interpolated verbatim st

[PATCH] D58504: [OpenCL][8.0.0 Release] Notes for OpenCL

This revision was automatically updated to reflect the committed changes. Closed by commit rL354799: Release notes for OpenCL (authored by stulova, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.llvm.org/D58504?vs=

[PATCH] D35271: Fix printing policy for AST context loaded from file

This revision was automatically updated to reflect the committed changes. Closed by commit rL311787: [Frontend] Fix printing policy for AST context loaded from file (authored by vedantk). Changed prior to commit: https://reviews.llvm.org/D35271?vs=112334&id=112718#toc Repository: rL LLVM ht

[PATCH] D37002: [clang-diff] Treat CXXCtorInitializer as a node

This revision was automatically updated to reflect the committed changes. Closed by commit rL311865: [clang-diff] Treat CXXCtorInitializer as a node (authored by krobelus). Changed prior to commit: https://reviews.llvm.org/D37002?vs=112134&id=112841#toc Repository: rL LLVM https://reviews.l

[PATCH] D36336: [X86] Add support for __builtin_cpu_init

This revision was automatically updated to reflect the committed changes. Closed by commit rL311874: [X86] Add support for __builtin_cpu_init (authored by ctopper). Changed prior to commit: https://reviews.llvm.org/D36336?vs=109800&id=112851#toc Repository: rL LLVM https://reviews.llvm.org/

[PATCH] D34275: [analyzer] Re-implemente current virtual calls checker in a path-sensitive way

This revision was automatically updated to reflect the committed changes. Closed by commit rL311877: [analyzer][GSoC] Re-implemente current virtual calls checker in a path… (authored by xazax). Changed prior to commit: https://reviews.llvm.org/D34275?vs=112196&id=112857#toc Repository: rL LL

[PATCH] D35678: Omit sumbodule semantics for TS modules

This revision was automatically updated to reflect the committed changes. Closed by commit rL312007: [modules-ts] Omit submodule semantics for TS modules (authored by borisk). Changed prior to commit: https://reviews.llvm.org/D35678?vs=110875&id=113098#toc Repository: rL LLVM https://review

[PATCH] D35020: [Modules] Add ability to specify module name to module file mapping

This revision was automatically updated to reflect the committed changes. Closed by commit rL312105: [modules] Add ability to specify module name to module file mapping (authored by borisk). Changed prior to commit: https://reviews.llvm.org/D35020?vs=111826&id=113207#toc Repository: rL LLVM

[PATCH] D37287: [X86] Implement broadcastf32x2 and broadcasti32x2 intrinsics using __builtin_shufflevector instead builtins

This revision was automatically updated to reflect the committed changes. Closed by commit rL312135: [X86] Implement broadcastf32x2 and broadcasti32x2 intrinsics using… (authored by ctopper). Changed prior to commit: https://reviews.llvm.org/D37287?vs=113199&id=113275#toc Repository: rL LLVM

[PATCH] D30691: [analyzer] Support for naive cross translational unit analysis

whisperity added a comment. The Python code here still uses `mangled name` in their wording. Does this mean this patch is yet to be updated with the USR management in the parent patch? Comment at: tools/scan-build-py/libscanbuild/analyze.py:165 +with open(filename,

[PATCH] D27810: FileManager: mark virtual file entries as valid entries

cameron314 added a comment. The `IsValid = true` line coincidentally fixes a tangentially related bug -- see https://reviews.llvm.org/D20338 (in which I tried to introduce the same fix almost a year earlier, but nobody accepted the review). I guess I have to maintain the test for that case out

[PATCH] D37413: [X86][MS-InlineAsm] Extended support for variables / identifiers on memory / immediate expressions

coby created this revision. Allow the proper recognition of Enum values and global variables inside ms inline-asm memory / immediate expressions, as they require some additional overhead and treated incorrect if doesn't early recognized. supersedes https://reviews.llvm.org/D33277, https://review

[PATCH] D37413: [X86][MS-InlineAsm] Extended support for variables / identifiers on memory / immediate expressions

coby updated this revision to Diff 113659. Repository: rL LLVM https://reviews.llvm.org/D37413 Files: include/clang/Parse/Parser.h include/clang/Sema/Sema.h lib/Parse/ParseStmtAsm.cpp lib/Sema/SemaStmtAsm.cpp Index: lib/Parse/ParseStmtAsm.cpp ==

[PATCH] D35775: [x86][inline-asm]Extend support for memory reference expression

coby abandoned this revision. coby added a comment. superseded by https://reviews.llvm.org/D37412 Repository: rL LLVM https://reviews.llvm.org/D35775 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/li

[PATCH] D37282: clangd: Tolerate additional headers

This revision was automatically updated to reflect the committed changes. Closed by commit rL312483: clangd: Tolerate additional headers (authored by ibiryukov). Repository: rL LLVM https://reviews.llvm.org/D37282 Files: clang-tools-extra/trunk/clangd/JSONRPCDispatcher.cpp clang-tools-ext

[PATCH] D37466: D37461: fixups for existing InlineAsm tests + adding new ones

coby created this revision. Herald added a subscriber: eraman. Repository: rL LLVM https://reviews.llvm.org/D37466 Files: test/CodeGen/ms-inline-asm-64.c test/CodeGen/ms-inline-asm-offset-err.cpp test/CodeGen/ms-inline-asm-offset.c test/CodeGen/ms-inline-asm.c test/CodeGen/ms-inline-

[PATCH] D37448: Fix cast assertion on MS inline assembly with vector spills (PR34021)

coby added a comment. might be a bit unrelated - but do we've got a hint regarding why is this even an issue? by all means - it doesn't seems right for an empty ms inline-asm statement to affect successful compilation, without even mentioning the involvement of the encapsulating function's retu

[PATCH] D37474: [PCH] Allow VFS to be used for tests that generate PCH files

cameron314 created this revision. Herald added a subscriber: mgorny. When using a virtual file-system (VFS) and a preamble file (PCH) is generated, it is generated on-disk in the real file-system instead of in the VFS (which I guess makes sense, since the VFS is read-only). However, when subsequ

[PATCH] D20338: [PCH] Fixed overridden files always invalidating preamble even when unchanged

cameron314 abandoned this revision. cameron314 added a comment. This patch is obsolete. While waiting over a year for a review, somebody else came across the same fix (for a different manifestation of the same bug) in https://reviews.llvm.org/D27810 and managed to get it through. I think my test

[PATCH] D37474: [PCH] Allow VFS to be used for tests that generate PCH files

cameron314 added a comment. I suppose we could do the overlay manually in all the tests that need it; I guess it depends on what the goal of the VFS support is. To my mind, it doesn't make sense that a file is placed in the RealFS in the first place if a VFS is used, but this is quite entrenche

[PATCH] D37491: [Preamble] Fixed preamble breaking with BOM presence (and particularly, fluctuating BOM presence)

cameron314 created this revision. This patch fixes preamble skipping when the preamble region includes a byte order mark (BOM). Previously, parsing would fail if preamble PCH generation was enabled and a BOM was present. This also fixes the preamble incorrectly being invalidated when a BOM appe

[PATCH] D37428: Debug info: Fixed faulty debug locations for attributed statements

This revision was automatically updated to reflect the committed changes. Closed by commit rL312623: Debug info: Fixed faulty debug locations for attributed statements (authored by karka). Changed prior to commit: https://reviews.llvm.org/D37428?vs=113803&id=113968#toc Repository: rL LLVM h

[PATCH] D36998: [AST] Traverse templates in LexicallyOrderedRecursiveASTVisitor

This revision was automatically updated to reflect the committed changes. Closed by commit rL312631: [AST] Traverse templates in LexicallyOrderedRecursiveASTVisitor (authored by krobelus). Repository: rL LLVM https://reviews.llvm.org/D36998 Files: cfe/trunk/include/clang/AST/LexicallyOrdere

<    16   17   18   19   20   21   22   23   24   25   >