[PATCH] D61589: [CodeComplete] Add a trailing semicolons to some pattern completions

2019-05-06 Thread Phabricator via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL360042: [CodeComplete] Add a trailing semicolons to some pattern completions (authored by ibiryukov, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to

[PATCH] D61399: [OpenMP][Clang] Support for target math functions

2019-05-06 Thread Phabricator via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rC360063: [OpenMP][Clang] Support for target math functions (authored by gbercea, committed by ). Changed prior to commit: https://reviews.llvm.org/D61399?vs=198311&id=198314#toc Repository: rC Clang

[PATCH] D60934: [clang] adding explicit(bool) from c++2a

2019-05-07 Thread Tyker via Phabricator via cfe-commits
Tyker added a comment. could you commit this for me ? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60934/new/ https://reviews.llvm.org/D60934 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/li

[PATCH] D58547: [clangd] Introduce intermediate representation of formatted text

2019-05-07 Thread Phabricator via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL360151: [clangd] Introduce intermediate representation of formatted text (authored by ibiryukov, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to com

[PATCH] D60454: [OpenCL] Prevent mangling kernel functions

2019-05-07 Thread Phabricator via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rC360152: [OpenCL] Prevent mangling kernel functions. (authored by stulova, committed by ). Herald added a project: clang. Changed prior to commit: https://reviews.llvm.org/D60454?vs=197934&id=198467#toc

[PATCH] D61545: [analyzer] Fix a crash in RVO from within blocks.

2019-05-07 Thread Phabricator via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rC360202: [analyzer] Fix a crash when doing RVO from within blocks. (authored by dergachev, committed by ). Changed prior to commit: https://reviews.llvm.org/D61545?vs=198535&id=198555#toc Repository:

[PATCH] D61642: [clang-tidy] Do not show incorrect fix in modernize-make-unique

2019-05-08 Thread Phabricator via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL360231: [clang-tidy] Do not show incorrect fix in modernize-make-unique (authored by ibiryukov, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to comm

[PATCH] D58236: Make address space conversions a bit stricter.

2019-05-08 Thread Phabricator via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL360258: [Sema][OpenCL] Make address space conversions a bit stricter. (authored by stulova, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit:

[PATCH] D61399: [OpenMP][Clang] Support for target math functions

2019-05-08 Thread Phabricator via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rC360265: [OpenMP][Clang] Support for target math functions (authored by gbercea, committed by ). Changed prior to commit: https://reviews.llvm.org/D61399?vs=198664&id=198677#toc Repository: rC Clang

[PATCH] D61475: Update an information about ReSharper C++ and clang-tidy custom binary integration

2019-05-08 Thread Phabricator via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL360277: [clang-tidy] Update documentation on ReSharper integration. (authored by dergachev, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit:

[PATCH] D61639: Add Triple::isSPIR() to simplify code

2019-05-09 Thread Phabricator via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL360323: [SPIR] Simplified target checking. (authored by stulova, committed by ). Herald added a subscriber: kristina. Changed prior to commit: https://reviews.llvm.org/D61639?vs=198429&id=198780#toc Re

[PATCH] D61506: [OpenCL] Switch to C++17

2019-05-09 Thread Phabricator via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL360330: [OpenCL] Switched CXX mode to be derived from C++17 (authored by stulova, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit: https://

[PATCH] D61724: [clangd] Use AsyncTaskRunner in BackgroundIndex instead of std::thread

2019-05-09 Thread Phabricator via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL360332: [clangd] Use AsyncTaskRunner in BackgroundIndex instead of std::thread (authored by ibiryukov, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior

[PATCH] D61488: [OpenCL] Make global ctor init function a kernel

2019-05-09 Thread Phabricator via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL360342: [OpenCL] Make global ctor init function a kernel (authored by stulova, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit: https://rev

[PATCH] D60934: [clang] adding explicit(bool) from c++2a

2019-05-09 Thread Tyker via Phabricator via cfe-commits
Tyker marked an inline comment as done. Tyker added inline comments. Comment at: cfe/trunk/lib/Parse/ParseDecl.cpp:3939 + "both or neither of isAlreadyConsumed and " + "RangeEnd needs to be set"); +DS.Se

[PATCH] D50993: [clangd] Increase stack size of the new threads on macOS

2019-05-09 Thread Dmitry via Phabricator via cfe-commits
Dmitry.Kozhevnikov added a comment. In D50993#1496250 , @ilya-biryukov wrote: > We should definitely land this. > > @Dmitry.Kozhevnikov, you don't have commit access, right? Should we land > these two revisions for you? The depending review was never d

[PATCH] D50993: [clangd] Increase stack size of the new threads on macOS

2019-05-09 Thread Dmitry via Phabricator via cfe-commits
Dmitry.Kozhevnikov added a comment. In D50993#1496946 , @ilya-biryukov wrote: > I'd still put it into LLVM to avoid platform-specific code in clangd. > Maybe `std::abort()` in the added `...Async` function if threads are > disabled? It's a bit unusual,

[PATCH] D52097: [OPENMP] Move OMPClauseReader/Writer classes to ASTReader/Writer - NFC

2018-09-15 Thread Phabricator via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL342322: [OPENMP] Move OMPClauseReader/Writer classes to ASTReader/Writer (NFC) (authored by kli, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.llvm.or

[PATCH] D52135: Hello, i would like to suggest a fix for one of the checks in clang-tidy.The bug was reported in https://bugs.llvm.org/show_bug.cgi?id=32575 where you can find more information.

2018-09-15 Thread Idriss via Phabricator via cfe-commits
IdrissRio created this revision. IdrissRio added reviewers: aaron.ballman, hokein, alexfh. Herald added a subscriber: cfe-commits. [Clang-Tidy: modernize] Fix for modernize-redundant-void-arg: complains about variable cast to void Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D

[PATCH] D52135: [Clang-Tidy: modernize] Fix for modernize-redundant-void-arg: complains about variable cast to void

2018-09-15 Thread Idriss via Phabricator via cfe-commits
IdrissRio added a comment. In https://reviews.llvm.org/D52135#1235950, @lebedev.ri wrote: > > It will now completely skip all the explicitly instantiated functions, no? In my opinion, for this kind of check, we don't have the necessity to take in consideration the function instantiation. W

[PATCH] D52135: [Clang-Tidy: modernize] Fix for modernize-redundant-void-arg: complains about variable cast to void

2018-09-16 Thread Idriss via Phabricator via cfe-commits
IdrissRio updated this revision to Diff 165683. IdrissRio edited the summary of this revision. IdrissRio added a comment. Thank you @JonasToth. I have update the patch and i have added two cases. The first an instantiation of a non-templated function. The second is the instantiation of a templatic

[PATCH] D52151: Also manages clang-X as tool for scan-build

2018-09-16 Thread Phabricator via Phabricator via cfe-commits
This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rC342350: Also manages clang-X as tool for scan-build (authored by sylvestre, committed by ). Changed prior to commit: ht

[PATCH] D52153: scan-build: Add support of the option --exclude like in scan-build-py

2018-09-16 Thread Phabricator via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL342359: scan-build: Add support of the option --exclude like in scan-build-py (authored by sylvestre, committed by ). Herald added a subscriber: llvm-commits. Repository: rL LLVM https://reviews.llvm.o

[PATCH] D45719: [clang-Format] Fix indentation of member call after block

2018-09-17 Thread Phabricator via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rC342363: [clang-Format] Fix indentation of member call after block (authored by ibiryukov, committed by ). Repository: rC Clang https://reviews.llvm.org/D45719 Files: lib/Format/ContinuationIndenter.

[PATCH] D52135: [Clang-Tidy: modernize] Fix for modernize-redundant-void-arg: complains about variable cast to void

2018-09-17 Thread Idriss via Phabricator via cfe-commits
IdrissRio updated this revision to Diff 165741. IdrissRio added a comment. Thank you @JonasToth. As you suggest I have added the test for the templatic function. Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D52135 Files: clang-tidy/modernize/RedundantVoidArgCheck.cpp test

[PATCH] D52135: [Clang-Tidy: modernize] Fix for modernize-redundant-void-arg: complains about variable cast to void

2018-09-17 Thread Idriss via Phabricator via cfe-commits
IdrissRio added a comment. In https://reviews.llvm.org/D52135#1236690, @JonasToth wrote: > LG from my side. > I guess you found this in a real code base, if so could you please verify > its fixed now. Actually I'm searching for the bug in bugzilla and I try to fix them. > If @aaron.ballman,

[PATCH] D52135: [Clang-Tidy: modernize] Fix for modernize-redundant-void-arg: complains about variable cast to void

2018-09-17 Thread Idriss via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rCTE342388: [Clang-Tidy: modernize] Fix for modernize-redundant-void-arg: complains about… (authored by IdrissRio, committed by ). Changed prior to commit: https://reviews.llvm.org/D52135?vs=165741&id=16

[PATCH] D51220: [clang-tidy] run-clang-tidy fails using python 3.7

2018-09-19 Thread Andi via Phabricator via cfe-commits
Abpostelnicu updated this revision to Diff 166095. https://reviews.llvm.org/D51220 Files: clang-tidy/tool/run-clang-tidy.py Index: clang-tidy/tool/run-clang-tidy.py === --- clang-tidy/tool/run-clang-tidy.py +++ clang-tidy/tool/ru

[PATCH] D51220: [clang-tidy] run-clang-tidy fails using python 3.7

2018-09-19 Thread Andi via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL342540: [clang-tidy] run-clang-tidy.py - fails using python 3.7 (authored by Abpostelnicu, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.llvm.org/D512

[PATCH] D52074: [PowerPC] [Clang] Add vector int128 pack/unpack builtins

2018-09-19 Thread qshanz via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL342614: [PowerPC] [Clang] Add vector int128 pack/unpack builtins (authored by qshanz, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.llvm.org/D52074?vs

[PATCH] D52271: [Sema] Ensure that we retain __restrict qualifiers when substituting a reference type.

2018-09-20 Thread Phabricator via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rC342672: [Sema] Retain __restrict qualifiers when substituting a reference type. (authored by epilk, committed by ). Changed prior to commit: https://reviews.llvm.org/D52271?vs=166224&id=166334#toc Repo

[PATCH] D52253: Fix an assert in the implementation of -Wquoted-include-in-framework-header

2018-09-20 Thread Phabricator via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL342679: Fix an assert in -Wquoted-include-in-framework-header (authored by epilk, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.llvm.org/D52253?vs=166

[PATCH] D49916: [CodeGen] Add to emitted DebugLoc information about coverage when it's required

2018-09-21 Thread calixte via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rC342717: [CodeGen] Add to emitted DebugLoc information about coverage when it's required (authored by calixte, committed by ). Changed prior to commit: https://reviews.llvm.org/D49916?vs=164860&id=166416

[PATCH] D52267: [AST] Various optimizations + refactoring in DeclarationName(Table)

2018-09-21 Thread Phabricator via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rC342729: [AST] Various optimizations + refactoring in DeclarationName(Table) (authored by brunoricci, committed by ). Repository: rC Clang https://reviews.llvm.org/D52267 Files: include/clang/AST/Dec

[PATCH] D52323: Add necessary support for storing code-model to module IR.

2018-09-21 Thread Phabricator via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL342758: Add necessary support for storing code-model to module IR. (authored by ctice, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.llvm.org/D52323?v

[PATCH] D47687: [Sema] Missing -Wlogical-op-parentheses warnings in macros (PR18971)

2018-09-21 Thread Xing via Phabricator via cfe-commits
Higuoxing updated this revision to Diff 166583. Higuoxing added a comment. I update the *SuggestParentheses* function, now, it could deal with parentheses inside macros https://reviews.llvm.org/D47687 Files: lib/Sema/SemaExpr.cpp test/Sema/parentheses.c Index: test/Sema/parentheses.c

[PATCH] D45179: [libc++] Add _LIBCPP_ENABLE_NODISCARD and _LIBCPP_NODISCARD_EXT to allow pre-C++2a [[nodiscard]]

2018-09-22 Thread Phabricator via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rCXX342808: [libc++] Add _LIBCPP_ENABLE_NODISCARD and _LIBCPP_NODISCARD_EXT to allow pre… (authored by lebedevri, committed by ). Herald added subscribers: libcxx-commits, ldionne. Repository: rCXX libc++

[PATCH] D45179: [libc++] Add _LIBCPP_ENABLE_NODISCARD and _LIBCPP_NODISCARD_EXT to allow pre-C++2a [[nodiscard]]

2018-09-22 Thread Phabricator via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL342808: [libc++] Add _LIBCPP_ENABLE_NODISCARD and _LIBCPP_NODISCARD_EXT to allow pre… (authored by lebedevri, committed by ). Changed prior to commit: https://reviews.llvm.org/D45179?vs=154724&id=166607

[PATCH] D52268: [AST] Squeeze some bits in LinkageComputer

2018-09-25 Thread Phabricator via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL342973: [AST] Squeeze some bits in LinkageComputer::QueryType (authored by brunoricci, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.llvm.org/D52268?v

[PATCH] D45050: [clang-tidy] New checker for not null-terminated result caused by strlen(), size() or equal length

2018-09-25 Thread Whisperity via Phabricator via cfe-commits
whisperity added a comment. I have checked the results, thank you for uploading them, they look solid to me, although I'm not exactly a developer for these projects, without full understanding of what and where allocates and true path-sensitive analysis and memory modelling, they look good. (E.

[PATCH] D51388: [analyzer] NFC: Legalize state manager factory injection.

2018-09-25 Thread Phabricator via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL343035: [analyzer] NFC: Legalize state manager factory injection. (authored by dergachev, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.llvm.org/D5138

[PATCH] D51390: [analyzer] CallDescription: Improve array management.

2018-09-25 Thread Phabricator via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rC343037: [analyzer] NFC: CallDescription: Improve array management. (authored by dergachev, committed by ). Repository: rC Clang https://reviews.llvm.org/D51390 Files: include/clang/StaticAnalyzer/Co

[PATCH] D52133: [analyzer] A testing facility for testing relationships between symbols.

2018-09-25 Thread Phabricator via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rC343048: [analyzer] Add a testing facility for testing relationships between symbols. (authored by dergachev, committed by ). Repository: rL LLVM https://reviews.llvm.org/D52133 Files: docs/analyzer/

[PATCH] D52133: [analyzer] A testing facility for testing relationships between symbols.

2018-09-25 Thread Phabricator via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL343048: [analyzer] Add a testing facility for testing relationships between symbols. (authored by dergachev, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit: https://rev

[PATCH] D52189: [analyzer] Fix a crash regression on casting opaque symbolic pointers from unrelated base classes to derived classes.

2018-09-25 Thread Phabricator via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rC343051: [analyzer] Fix a crash on casting symbolic pointers to derived classes. (authored by dergachev, committed by ). Repository: rL LLVM https://reviews.llvm.org/D52189 Files: lib/StaticAnalyzer/

[PATCH] D52189: [analyzer] Fix a crash regression on casting opaque symbolic pointers from unrelated base classes to derived classes.

2018-09-25 Thread Phabricator via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL343051: [analyzer] Fix a crash on casting symbolic pointers to derived classes. (authored by dergachev, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.

[PATCH] D52359: [OPENMP] Add support for OMP5 requires directive + unified_address clause

2018-09-25 Thread Phabricator via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rC343063: [OPENMP] Add support for OMP5 requires directive + unified_address clause (authored by kli, committed by ). Changed prior to commit: https://reviews.llvm.org/D52359?vs=166471&id=167042#toc Repo

[PATCH] D52422: [clangd] Handle template args for disabled function arg snippets

2018-09-25 Thread Phabricator via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL343066: [clangd] Handle template args for disabled function arg snippets (authored by ibiryukov, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.llvm.or

[PATCH] D52420: [clangd] Fix crash if pending computations were active on exit

2018-09-25 Thread Phabricator via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL343067: [clangd] Fix crash if pending computations were active on exit (authored by ibiryukov, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.llvm.org/

[PATCH] D52259: [CUDA] Fix two failed test cases using --cuda-path-ignore-env

2018-09-26 Thread Phabricator via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rC343075: [CUDA] Fix two failed test cases using --cuda-path-ignore-env (authored by jiadinggai, committed by ). Repository: rC Clang https://reviews.llvm.org/D52259 Files: test/Driver/cuda-detect.cu

[PATCH] D50488: [Analyzer] Checker for non-determinism caused by sorting of pointer-like elements

2018-09-26 Thread Whisperity via Phabricator via cfe-commits
whisperity added a comment. Hey @mgrang! Let's see some results on some projects and answer NoQ's comment, then I think we can put this in for all the world to see. https://reviews.llvm.org/D50488 ___ cfe-commits mailing list cfe-commits@lists.llvm

[PATCH] D52390: [analyzer] Add StackSizeChecker to StaticAnalyzer

2018-09-26 Thread Whisperity via Phabricator via cfe-commits
whisperity added a comment. One final nit apart from a few in-line comments (most of them are just arguing with @Szelethus anyways 😛): KB vs. KiB (remember how a 2 TB hard drive appears as 1.8 TB on your machine? Because it's TiB!) is one of my pet peeve

[PATCH] D45050: [clang-tidy] New checker for not null-terminated result caused by strlen(), size() or equal length

2018-09-26 Thread Whisperity via Phabricator via cfe-commits
whisperity added a subscriber: baloghadamsoftware. whisperity added inline comments. Comment at: clang-tidy/bugprone/NotNullTerminatedResultCheck.cpp:1038 + + SmallString<128> NewAddNullTermExprStr; + NewAddNullTermExprStr = "\n"; aaron.ballman wrote: > This sh

[PATCH] D52034: [Clang] Add options -Xclang -coverage-filter and -Xclang -coverage-exclude to filter the files to instrument with gcov

2018-09-26 Thread calixte via Phabricator via cfe-commits
calixte updated this revision to Diff 167101. calixte added a comment. Fix tests Repository: rC Clang https://reviews.llvm.org/D52034 Files: include/clang/Driver/CC1Options.td include/clang/Frontend/CodeGenOptions.h lib/CodeGen/BackendUtil.cpp lib/Frontend/CompilerInvocation.cpp te

[PATCH] D52034: [Clang] Add options -Xclang -coverage-filter and -Xclang -coverage-exclude to filter the files to instrument with gcov

2018-09-26 Thread calixte via Phabricator via cfe-commits
calixte added a comment. I reported a bug for gcc: https://gcc.gnu.org/bugzilla/show_bug.cgi?id=87442 @vsk I'd like to add documentation in Docs/UsersManual.rst, but I've no idea on what's a good place for this (I look for option -coverage-no-function-names-in-data, but I didn't get anything). S

[PATCH] D52530: [analyzer] scan-build: if --status-bugs is passed, don't forget about the exit status of the actual build

2018-09-26 Thread Phabricator via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rC343105: [analyzer] scan-build: if --status-bugs is passed, don't forget about the exit… (authored by lebedevri, committed by ). Repository: rC Clang https://reviews.llvm.org/D52530 Files: tools/scan

[PATCH] D52392: [X86] For lzcnt/tzcnt intrinsics use cttz/ctlz intrinsics with zero_undef flag set to false.

2018-09-26 Thread Phabricator via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rC343126: [X86] For lzcnt/tzcnt intrinsics use cttz/ctlz intrinsics with zero_undef flag… (authored by ctopper, committed by ). Changed prior to commit: https://reviews.llvm.org/D52392?vs=166606&id=167159

[PATCH] D47687: [Sema] Missing -Wlogical-op-parentheses warnings in macros (PR18971)

2018-09-26 Thread Xing via Phabricator via cfe-commits
Higuoxing added a comment. Ping. Now, this patch could give fix-it note on parentheses in macros. https://reviews.llvm.org/D47687 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D52589: [clang][ubsan][NFC] Slight test cleanup in preparation for D50901

2018-09-27 Thread Phabricator via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL343251: [clang][ubsan][NFC] Slight test cleanup in preparation for D50901 (authored by lebedevri, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.llvm.o

[PATCH] D52434: [OpenMP] Make default distribute schedule for NVPTX target regions in SPMD mode achieve coalescing

2018-09-27 Thread Phabricator via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rC343253: [OpenMP] Make default distribute schedule for NVPTX target regions in SPMD mode… (authored by gbercea, committed by ). Changed prior to commit: https://reviews.llvm.org/D52434?vs=167326&id=16737

[PATCH] D52629: [OpenMP] Make default parallel for schedule in NVPTX target regions in SPMD mode achieve coalescing

2018-09-27 Thread Phabricator via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rC343260: [OpenMP] Make default parallel for schedule in NVPTX target regions in SPMD… (authored by gbercea, committed by ). Changed prior to commit: https://reviews.llvm.org/D52629?vs=167386&id=167387#to

[PATCH] D52574: NFC: Fix some darwin linker warnings introduced in r338385

2018-09-27 Thread Phabricator via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rC343263: NFC: Fix some darwin linker warnings introduced in r338385 (authored by epilk, committed by ). Changed prior to commit: https://reviews.llvm.org/D52574?vs=167193&id=167394#toc Repository: rC

[PATCH] D52644: [ARM] Prevent DSP and SIM32 being set for v6m

2018-09-28 Thread Phabricator via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rC343309: [ARM] Prevent DSP and SIM32 being set for v6m (authored by sam_parker, committed by ). Herald added a subscriber: cfe-commits. Changed prior to commit: https://reviews.llvm.org/D52644?vs=167444&

[PATCH] D52586: [X86] Add the movbe instruction intrinsics from icc.

2018-09-28 Thread Phabricator via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rC343343: [X86] Add the movbe instruction intrinsics from icc. (authored by ctopper, committed by ). Repository: rC Clang https://reviews.llvm.org/D52586 Files: lib/Basic/Targets/X86.cpp lib/Headers

[PATCH] D52586: [X86] Add the movbe instruction intrinsics from icc.

2018-09-28 Thread Phabricator via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL343343: [X86] Add the movbe instruction intrinsics from icc. (authored by ctopper, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.llvm.org/D52586?vs=16

[PATCH] D52339: Support enums with a fixed underlying type in all language modes

2018-09-28 Thread Phabricator via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rC343360: Support enums with a fixed underlying type in all language modes. (authored by epilk, committed by ). Changed prior to commit: https://reviews.llvm.org/D52339?vs=166397&id=167538#toc Repository

[PATCH] D52665: [X86] Add more of the icc unaligned load/store to/from 128 bit vector intrinsics

2018-09-29 Thread Phabricator via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rC343388: [X86] Add more of the icc unaligned load/store to/from 128 bit vector intrinsics (authored by ctopper, committed by ). Repository: rC Clang https://reviews.llvm.org/D52665 Files: lib/Headers

[PATCH] D52742: [analyzer][WIP] Add macro expansions to the plist output

2018-10-02 Thread Whisperity via Phabricator via cfe-commits
whisperity added a subscriber: gamesh411. whisperity added a comment. Your code looks good, just minor comments going on inline. Trying to think of more cases to test for, in case someone generously misuses FLMs, as seen here in an example if you scroll down a bit: https://gcc.gnu.org/onlinedocs

[PATCH] D52738: [AST] Pack the bit-fields of FunctionProtoType into Type.

2018-10-02 Thread Phabricator via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL343579: [AST] Pack the bit-fields of FunctionProtoType into Type. (authored by brunoricci, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.llvm.org/D527

[PATCH] D52667: [analyzer] Fix conversion from LocAsInteger to Loc symbol.

2018-10-02 Thread Phabricator via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rC343631: [analyzer] Fix symbol discovery in nonloc::LocAsInteger values. (authored by dergachev, committed by ). Repository: rC Clang https://reviews.llvm.org/D52667 Files: lib/StaticAnalyzer/Core/SV

[PATCH] D52722: [analyzer] Move StdCLibraryFunctions to apiModeling

2018-10-02 Thread Phabricator via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL343632: [analyzer] Promote StdCLibraryFunctionsChecker to the apiModeling category. (authored by dergachev, committed by ). Herald added a subscriber: llvm-commits. Repository: rL LLVM https://reviews.

[PATCH] D52742: [analyzer][PlistMacroExpansion] Part 1.: New expand-macros flag

2018-10-03 Thread Whisperity via Phabricator via cfe-commits
whisperity added inline comments. Comment at: test/Analysis/Inputs/expected-plists/plist-macros-with-expansion.cpp.plist:6 + clang_version +clang version 8.0.0 (http://mainstream.inf.elte.hu/Szelethus/clang 85a6dda64587a5a18482f091cbcf020fbd3ec1dd) (https://github.com/llvm-mirr

[PATCH] D51855: [constexpr] Fix ICE when memcpy() is given a pointer to an incomplete array

2018-10-04 Thread Phabricator via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL343761: [constexpr] Fix ICE when memcpy() is given a pointer to an incomplete array (authored by petr.pavlu, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit: https://rev

[PATCH] D52842: clang-format: Don't insert spaces in front of :: for Java 8 Method References.

2018-10-05 Thread Phabricator via Phabricator via cfe-commits
This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rL343872: clang-format: Don't insert spaces in front of :: for Java 8 Method References. (authored by nico, committed by ).

[PATCH] D51657: [CMake] Link to compiler-rt if LIBUNWIND_USE_COMPILER_RT is ON.

2018-10-08 Thread Phabricator via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL343990: [CMake] Link to compiler-rt if LIBUNWIND_USE_COMPILER_RT is ON. (authored by cdavis, committed by ). Herald added a subscriber: llvm-commits. Repository: rL LLVM https://reviews.llvm.org/D51657

[PATCH] D52983: [analyzer] Support Reinitializes attribute in MisusedMovedObject check

2018-10-09 Thread Phabricator via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL344017: [analyzer] Support Reinitializes attribute in MisusedMovedObject check (authored by xazax, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.llvm.

[PATCH] D52742: [analyzer][PlistMacroExpansion] Part 1.: New expand-macros flag

2018-10-09 Thread Whisperity via Phabricator via cfe-commits
whisperity added inline comments. Comment at: test/Analysis/Inputs/expected-plists/plist-macros-with-expansion.cpp.plist:346 + + /home/eumakri/Documents/2codechecker_dev_env/llvm/tools/clang/test/Analysis/plist-macros-with-expansion.cpp + Same here, as @xaza

[PATCH] D57345: Make clang/test/Index/pch-from-libclang.c pass in more places

2019-01-31 Thread Phabricator via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL352803: Make clang/test/Index/pch-from-libclang.c pass in more places (authored by nico, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.llvm.org/D57345

[PATCH] D56555: Add Attribute to define nonlazy objc classes

2019-01-31 Thread Joe via Phabricator via cfe-commits
joedaniels29 updated this revision to Diff 184671. joedaniels29 marked 4 inline comments as done. joedaniels29 added a comment. Herald added a project: clang. Docs changes, formatting. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56555/new/ https://reviews.llvm.

[PATCH] D55782: Fix isInSystemMacro to handle pasted token

2019-01-31 Thread Phabricator via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL352838: Fix isInSystemMacro to handle pasted macros (authored by serge_sans_paille, committed by ). Herald added a project: LLVM. Changed prior to commit: https://reviews.llvm.org/D55782?vs=184275&id=18

[PATCH] D55782: Fix isInSystemMacro to handle pasted token

2019-01-31 Thread serge via Phabricator via cfe-commits
serge-sans-paille marked an inline comment as done. serge-sans-paille added a comment. Herald added a subscriber: llvm-commits. It's in, thanks @rsmith for the review. Repository: rL LLVM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55782/new/ https://reviews.llvm.org/D55782

[PATCH] D57573: Disable tidy checks with too many hits

2019-02-01 Thread Phabricator via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rC352862: Disable tidy checks with too many hits (authored by ibiryukov, committed by ). Changed prior to commit: https://reviews.llvm.org/D57573?vs=184714&id=184715#toc Repository: rC Clang CHANGES S

[PATCH] D57521: [CMake] External compiler-rt-configure requires LLVMTestingSupport when including tests

2019-02-01 Thread Phabricator via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL352881: [CMake] External compiler-rt-configure requires LLVMTestingSupport when… (authored by stefan.graenitz, committed by ). Herald added a project: LLVM. Repository: rL LLVM CHANGES SINCE LAST ACTIO

[PATCH] D57585: [AST][OpenMP] OpenMP Sections / Section constructs contain Structured blocks

2019-02-01 Thread Phabricator via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rC352882: [AST][OpenMP] OpenMP Sections / Section constructs contain Structured blocks (authored by lebedevri, committed by ). Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D5

[PATCH] D57592: Replace uses of %T with %t in from previous frontend test differential

2019-02-02 Thread Phabricator via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL352971: Replace uses of %T with %t in from previous frontend test differential (authored by nico, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to co

[PATCH] D56935: [NewPM] Add support for new-PM plugins to clang

2019-02-02 Thread Phabricator via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rC352972: [NewPM] Add support for new-PM plugins to clang (authored by pfaffe, committed by ). Changed prior to commit: https://reviews.llvm.org/D56935?vs=183715&id=184922#toc Repository: rC Clang CHA

[PATCH] D57649: [ASTDump] Add a flag indicating whether a CXXThisExpr is implicit

2019-02-03 Thread Phabricator via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rC353003: [ASTDump] Add a flag indicating whether a CXXThisExpr is implicit (authored by brunoricci, committed by ). Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57649/new/

[PATCH] D57266: [AST] Update the comments of the various Expr::Ignore* + Related cleanups

2019-02-03 Thread Phabricator via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL353006: [AST] Update the comments of the various Expr::Ignore* + Related cleanups (authored by brunoricci, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed pr

[PATCH] D57674: [clang-tidy] Add options to bugprone-argument-comment to add missing argument comments to literals

2019-02-04 Thread MyDeveloperDay via Phabricator via cfe-commits
MyDeveloperDay created this revision. MyDeveloperDay added reviewers: JonasToth, alexfh, hokein, aaron.ballman, Eugene.Zelenko. MyDeveloperDay added a project: clang-tools-extra. Herald added a subscriber: xazax.hun. Herald added a project: clang. bugprone-argument-comment only supports identifyi

[PATCH] D57674: [clang-tidy] Add options to bugprone-argument-comment to add missing argument comments to literals

2019-02-04 Thread MyDeveloperDay via Phabricator via cfe-commits
MyDeveloperDay marked an inline comment as done. MyDeveloperDay added inline comments. Comment at: docs/ReleaseNotes.rst:89 +- The :doc:`bugprone-argument-comment + ` now supports note to self, I will reorganize this alphabetically, on next revision Reposit

[PATCH] D57674: [clang-tidy] Add options to bugprone-argument-comment to add missing argument comments to literals

2019-02-04 Thread MyDeveloperDay via Phabricator via cfe-commits
MyDeveloperDay added a comment. An example of this checker run over clang-tidy/modernize is given here D57675: [clang-tidy] DO NOT SUBMIT.. example diff of applying bugprone-argument-comments with AddCommentsToXXXLiterals options Repository: rCTE Clang Tool

[PATCH] D57655: clang-format with UseTab: Always sometimes doesn't insert the right amount of tabs.

2019-02-04 Thread MyDeveloperDay via Phabricator via cfe-commits
MyDeveloperDay added a comment. There guys set a high barrier of entry, you need to at least start by adding some unit tests (or someone will break your code in the future), if you think it was a bug it might be worth logging that in bugzilla too! Repository: rC Clang CHANGES SINCE LAST ACT

[PATCH] D57674: [clang-tidy] Add options to bugprone-argument-comment to add missing argument comments to literals

2019-02-04 Thread MyDeveloperDay via Phabricator via cfe-commits
MyDeveloperDay updated this revision to Diff 185014. MyDeveloperDay added a comment. Fix release note alphabetic order Add examples of Fixit into the documentation CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57674/new/ https://reviews.llvm.org/D57674 Files: clang-tidy/bugprone/Argu

[PATCH] D57640: [NewPM][MSan] Add Options Handling

2019-02-04 Thread Phabricator via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rC353090: [NewPM][MSan] Add Options Handling (authored by pfaffe, committed by ). Herald added a project: clang. Herald added a subscriber: cfe-commits. Changed prior to commit: https://reviews.llvm.org/D

[PATCH] D57674: [clang-tidy] Add options to bugprone-argument-comment to add missing argument comments to literals

2019-02-04 Thread MyDeveloperDay via Phabricator via cfe-commits
MyDeveloperDay updated this revision to Diff 185148. MyDeveloperDay edited the summary of this revision. MyDeveloperDay added a comment. Address review comments Add support for additional StringLiterals,CharacterLiterals,UserDefinedLiterals and NullPtrs Simplify the Options names from "AddCommen

[PATCH] D57712: [SemaObjC] Don't infer the availabilty of messages to +new from -init if the receiver has Class type

2019-02-04 Thread Phabricator via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rC353115: [SemaObjC] Don't infer the availabilty of +new from -init if the receiver has… (authored by epilk, committed by ). Changed prior to commit: https://reviews.llvm.org/D57712?vs=185150&id=185175#to

[PATCH] D56555: Add Attribute to define nonlazy objc classes

2019-02-04 Thread Phabricator via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL353116: [OBJC] Add attribute to mark Objective C class as non-lazy (authored by joseph_daniels, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to comm

[PATCH] D57642: [X86] Update clobber list in a test after D57641. Remove filter for 'fpsw' in MS inline asm clobber list generation since the backend now uses 'fpsr'.

2019-02-04 Thread Phabricator via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL353142: [X86] Change MS inline asm clobber list filter to check for 'fpsr' instead of… (authored by ctopper, committed by ). Herald added a project: LLVM. Repository: rL LLVM CHANGES SINCE LAST ACTION

[PATCH] D57524: Fix ICE on attempt to add an addr space qual to a type qualified by an addr space

2019-02-05 Thread Phabricator via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rC353160: Fix ICE on reference binding with mismatching addr spaces. (authored by stulova, committed by ). Herald added a project: clang. Changed prior to commit: https://reviews.llvm.org/D57524?vs=185024

[PATCH] D57674: [clang-tidy] Add options to bugprone-argument-comment to add missing argument comments to literals

2019-02-05 Thread MyDeveloperDay via Phabricator via cfe-commits
MyDeveloperDay added inline comments. Comment at: clang-tidy/bugprone/ArgumentCommentCheck.cpp:228-236 +static bool isStringLiteral(const Expr *Arg) { + const auto *Cast = dyn_cast(Arg); + return Cast ? isa(Cast->getSubExpr()) : false; +} + +static bool isNullPtrLiteral(const E

<    15   16   17   18   19   20   21   22   23   24   >