[PATCH] D60151: [clang-tidy] Rename llvm checkers to llvm-project

MyDeveloperDay added a comment. are we supporting "-llvm-*" in existing .clang-tidy files? If people selectively turn checkers off, won't all of a sudden everyone start getting llvm-project checks and fixes turned back on? https://github.com/search?q=-llvm-%2A&type=Code maybe we need to add so

[PATCH] D54881: [clang-format] Prevent Clang-Format from editing leading whitespace on lines outside of the format range

MyDeveloperDay added a comment. > I agree and would be happy with the change if it would only change the > line-filtered workflow, but this afaict (unless I'm missing something :) will > also affect the workflow where the provided range is 0-length range, which > has an implicit "format stuff

[PATCH] D60542: Add support for attributes on @implementations in Objective-C

This revision was automatically updated to reflect the committed changes. Closed by commit rC358200: Add support for attributes on @implementations in Objective-C (authored by epilk, committed by ). Changed prior to commit: https://reviews.llvm.org/D60542?vs=194594&id=194716#toc Repository:

[PATCH] D60544: Support objc_nonlazy_class attribute on Objective-C implementations

This revision was automatically updated to reflect the committed changes. Closed by commit rL358201: Support objc_nonlazy_class attribute on Objective-C implementations (authored by epilk, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to comm

[PATCH] D60151: [clang-tidy] Rename llvm checkers to llvm-project

MyDeveloperDay added a comment. >> I suppose we could keep the names and directory structure and just change >> the namespace. That would just be a special case in the scripts. Haven't >> looked into it yet, but will do so as soon as I can. > > Isn't that matching done on strings? I.e. is t

[PATCH] D60123: [AST] Forbid copy/move of statements/types.

This revision was automatically updated to reflect the committed changes. Closed by commit rC358283: [AST] Forbid copy/move of statements/types (authored by brunoricci, committed by ). Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60123/new/ https://reviews.llvm.o

[PATCH] D60029: Add const children() accessors to all AST nodes.

This revision was automatically updated to reflect the committed changes. Closed by commit rC358288: [AST][NFC] Add const children() accessors to all AST nodes (authored by brunoricci, committed by ). Changed prior to commit: https://reviews.llvm.org/D60029?vs=193288&id=194897#toc Repository:

[PATCH] D40577: Clang support for simd functions

mmasten updated this revision to Diff 194917. mmasten added a comment. Rebased and updated test. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D40577/new/ https://reviews.llvm.org/D40577 Files: clang/lib/CodeGen/CGOpenMPRuntime.cpp clang/test/OpenMP/declare_simd_codegen.cpp Index:

[PATCH] D40577: Clang support for simd functions

mmasten marked 2 inline comments as done. mmasten added inline comments. Comment at: clang/lib/CodeGen/CGOpenMPRuntime.cpp:9615 + + std::string Buffer; + if (Fn->hasFnAttribute("vector-variants")) { ABataev wrote: > 1. Why this change is required? > 2. Why not

[PATCH] D60561: [clang] fixing diagnostics of constexpr callstack

Tyker added a comment. @rsmith i don't think collecting theses values is expansive compared to evaluating the expression. but i agree that we can disable the collection of these values when it isn't needed. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60561/new/ https://reviews.llvm.

[PATCH] D60112: [analyzer] Treat write into a top-level parameter variable with destructor as escape.

This revision was automatically updated to reflect the committed changes. Closed by commit rC358321: [analyzer] Escape pointers stored into top-level parameters with destructors. (authored by dergachev, committed by ). Changed prior to commit: https://reviews.llvm.org/D60112?vs=193229&id=194993

[PATCH] D60561: [clang] fixing diagnostics of constexpr callstack

Tyker added a comment. the impact was much higher than i expected, around 1% slower in average on 50 compilation of SemaDecl with -fsyntax-only. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60561/new/ https://reviews.llvm.org/D60561 ___

[PATCH] D59746: [CommandLineParser] Add DefaultOption flag

This revision was automatically updated to reflect the committed changes. Closed by commit rL358337: [CommandLineParser] Add DefaultOption flag (authored by dhinton, committed by ). Herald added a subscriber: kristina. Changed prior to commit: https://reviews.llvm.org/D59746?vs=194899&id=195020

[PATCH] D60561: [clang] fixing diagnostics of constexpr callstack

Tyker updated this revision to Diff 195055. Tyker added a comment. i changed the way arguments are stored. to make it more controllable. added an argument call stack where it is needed. this version slows down compilation by around 0.5% in average over 200 run for SemaDecl -fsyntax-only CHANGES

[PATCH] D60561: [clang] fixing diagnostics of constexpr callstack

Tyker updated this revision to Diff 195056. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60561/new/ https://reviews.llvm.org/D60561 Files: clang/lib/AST/ExprConstant.cpp clang/test/SemaCXX/constant-expression-cxx1y.cpp Index: clang/test/SemaCXX/constant-expression-cxx1y.cpp ===

[PATCH] D60363: [clang-format] [PR41170] Break after return type ignored with certain comments positions

MyDeveloperDay updated this revision to Diff 195057. MyDeveloperDay added a comment. use endsWith() as it ignored comments CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60363/new/ https://reviews.llvm.org/D60363 Files: clang/lib/Format/TokenAnnotator.h clang/unittests/Format/Format

[PATCH] D60363: [clang-format] [PR41170] Break after return type ignored with certain comments positions

This revision was automatically updated to reflect the committed changes. Closed by commit rL358375: [clang-format] [PR41170] Break after return type ignored with certain comments… (authored by paulhoad, committed by ). Herald added a project: LLVM. Changed prior to commit: https://reviews.llvm

[PATCH] D59746: [CommandLineParser] Add DefaultOption flag

This revision was automatically updated to reflect the committed changes. Closed by commit rL358428: [CommandLineParser] Add DefaultOption flag (authored by dhinton, committed by ). Changed prior to commit: https://reviews.llvm.org/D59746?vs=195218&id=195220#toc Repository: rL LLVM CHANGES

[PATCH] D60674: [X86] Restore the pavg intrinsics.

This revision was automatically updated to reflect the committed changes. Closed by commit rL358427: [X86] Restore the pavg intrinsics. (authored by ctopper, committed by ). Changed prior to commit: https://reviews.llvm.org/D60674?vs=195090&id=195219#toc Repository: rL LLVM CHANGES SINCE LA

[PATCH] D60763: Prototype OpenCL BIFs using Tablegen

Pierre created this revision. Pierre added reviewers: Anastasia, svenvh. Herald added subscribers: cfe-commits, yaxunl, mgorny. Herald added a project: clang. **This is a re-upload of the patch from Joey GOULY, posted at: https://reviews.llvm.org/D53023 . I am re-uploading it because I will conti

[PATCH] D60763: Prototype OpenCL BIFs using Tablegen

Pierre updated this revision to Diff 195336. Pierre added a comment. Deleted blank line CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60763/new/ https://reviews.llvm.org/D60763 Files: clang/include/clang/Basic/CMakeLists.txt clang/include/clang/Basic/OpenCLBuiltins.td clang/lib/S

[PATCH] D60764: Add clang cc1 option to generate OpenCL builtin functions

Pierre created this revision. Pierre added reviewers: svenvh, Anastasia. Herald added subscribers: cfe-commits, kristina, yaxunl. Herald added a project: clang. Clang cc1 currently sets the -finclude-default-header flag by default, including the opencl-c.h header file. This patch adds a -fgenera

[PATCH] D60274: [ELF] Implement Dependent Libraries Feature

bd1976llvm updated this revision to Diff 195495. bd1976llvm added a comment. No longer shortening "dependent libraries" to "deplibs" except for the .deplibs section (as this takes up bytes on disk). CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60274/new/ https://reviews.llvm.org/D6027

[PATCH] D60362: [clang-format] [PR39719] clang-format converting object-like macro to function-like macro

MyDeveloperDay added a comment. @klimek one possible solution to this might be to replace the "keyword" back to an identifier in a '#define ' scenario Maybe something like this? bool FormatTokenLexer::tryConvertKeyWordDefines() { // ensure #define keyword x = tok::hash,tok::identifier,to

[PATCH] D60853: clang-format converts a keyword macro definition to a macro function

MyDeveloperDay added a comment. LGTM Comment at: clang/lib/Format/UnwrappedLineParser.cpp:808 - if (FormatTok->Tok.getKind() != tok::identifier) { + if (!FormatTok->Tok.getIdentifierInfo()) { IncludeGuard = IG_Rejected; Is this equivalent to saying som

[PATCH] D60362: [clang-format] [PR39719] clang-format converting object-like macro to function-like macro

MyDeveloperDay abandoned this revision. MyDeveloperDay added a comment. Abandoning in favor of D60853: clang-format converts a keyword macro definition to a macro function Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60362/new/

[PATCH] D60835: [Serialization] Stable serialization order for OpenCLTypeExtMap and OpenCLDeclExtMap

This revision was automatically updated to reflect the committed changes. Closed by commit rL358674: [Serialization] Stable serialization order for OpenCLTypeExtMap and… (authored by brunoricci, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior t

[PATCH] D60875: [OpenMP] Add checks for requires and target directives.

This revision was automatically updated to reflect the committed changes. Closed by commit rC358709: [OpenMP] Add checks for requires and target directives. (authored by gbercea, committed by ). Changed prior to commit: https://reviews.llvm.org/D60875?vs=195793&id=195803#toc Repository: rC C

[PATCH] D60886: [OpenMP][NFC] Fix requires target test.

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rC358711: [OpenMP][NFC] Fix requires target test. (authored by gbercea, committed by ). Repository: rC Clang CHANGES SIN

[PATCH] D60732: [analyzer] NFC: Use -verify=... in MoveChecker tests.

This revision was automatically updated to reflect the committed changes. Closed by commit rL358719: [analyzer] NFC: MoveChecker: Refactor tests to use -verify=prefix. (authored by dergachev, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to c

[PATCH] D60739: [analyzer] NFC: Re-use reusable unittest mocks.

This revision was automatically updated to reflect the committed changes. Closed by commit rL358720: [analyzer] NFC: Make reusable unittest mocks reusable. (authored by dergachev, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit: htt

[PATCH] D60742: [analyzer] RegionStore: Enable loading default bindings from variables.

This revision was automatically updated to reflect the committed changes. Closed by commit rC358722: [analyzer] Make default bindings to variables actually work. (authored by dergachev, committed by ). Changed prior to commit: https://reviews.llvm.org/D60742?vs=195500&id=195842#toc Repository:

[PATCH] D58367: [analyzer] NFC: Improve upon the concept of BugReporterVisitor.

This revision was automatically updated to reflect the committed changes. Closed by commit rL358781: Reapply "[analyzer] Introduce a simplified API for adding custom path notes." (authored by dergachev, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed

[PATCH] D60934: [clang] adding explicit(bool) from c++2a

Tyker created this revision. Tyker added a reviewer: rsmith. Herald added a reviewer: martong. Herald added a reviewer: shafik. Herald added a project: clang. Herald added a subscriber: cfe-commits. this patch adds support for the explicit bool specifier. added parsing for explicit bool specifier

[PATCH] D60523: [clang] Bugfixe for 41400

Tyker added a comment. awaiting feedback on this Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60523/new/ https://reviews.llvm.org/D60523 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org

[PATCH] D60934: [clang] adding explicit(bool) from c++2a

Tyker marked 2 inline comments as done. Tyker added inline comments. Comment at: clang/lib/Sema/DeclSpec.cpp:959 + // Each decl-specifier shall appear at most once in a complete + // decl-specifier-seq, except that long may appear twice. + if (hasExplicitSpecifier()) { ---

[PATCH] D60934: [clang] adding explicit(bool) from c++2a

Tyker updated this revision to Diff 195973. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60934/new/ https://reviews.llvm.org/D60934 Files: clang/include/clang/AST/Decl.h clang/include/clang/AST/DeclBase.h clang/include/clang/AST/DeclCXX.h clang/include/clang/ASTMatchers/ASTMatch

[PATCH] D60934: [clang] adding explicit(bool) from c++2a

Tyker updated this revision to Diff 195990. Tyker added a comment. @Quuxplusone @riccibruno fixed / answered feedback CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60934/new/ https://reviews.llvm.org/D60934 Files: clang/include/clang/AST/Decl.h clang/include/clang/AST/DeclBase.h

[PATCH] D29707: Fix improper microsoft-pure-definition warning on template class

This revision was automatically updated to reflect the committed changes. Closed by commit rL358849: [Sema][MSVC] Fix bogus microsoft-pure-definition warning on member function of… (authored by brunoricci, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Chan

[PATCH] D60570: [Sema] Add more tests for the behavior of argument-dependent name lookup

This revision was automatically updated to reflect the committed changes. Closed by commit rL358881: [Sema][NFC] Add more tests for the behavior of argument-dependent name lookup (authored by brunoricci, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Change

[PATCH] D60573: [Sema] ADL: Associated namespaces for class types and enumeration types (CWG 1691)

This revision was automatically updated to reflect the committed changes. Closed by commit rC358882: [Sema] ADL: Associated namespaces for class types and enumeration types (CWG… (authored by brunoricci, committed by ). Changed prior to commit: https://reviews.llvm.org/D60573?vs=194765&id=19605

[PATCH] D60808: [analyzer] pr41335: NoStoreFuncVisitor: Fix crash when no-store event is in a body-farmed function.

This revision was automatically updated to reflect the committed changes. Closed by commit rC358945: [analyzer] PR41335: Fix crash when no-store event is in a body-farmed function. (authored by dergachev, committed by ). Changed prior to commit: https://reviews.llvm.org/D60808?vs=195851&id=1961

[PATCH] D60899: [analyzer] Unbreak body farms in presence of multiple declarations.

This revision was automatically updated to reflect the committed changes. Closed by commit rL358946: [analyzer] Unbreak body farms in presence of multiple declarations. (authored by dergachev, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to

[PATCH] D59924: [PowerPC] [Clang] Port MMX intrinsics and basic test cases to Power

This revision was automatically updated to reflect the committed changes. Closed by commit rC358949: [PowerPC] [Clang] Port MMX intrinsics and basic test cases to Power (authored by chaofan, committed by ). Changed prior to commit: https://reviews.llvm.org/D59924?vs=194446&id=196182#toc Reposi

[PATCH] D60996: [clang-format] Fix bug in reflow of block comments containing CR/LF

MyDeveloperDay accepted this revision. MyDeveloperDay added a comment. This revision is now accepted and ready to land. This looks logical to me, seems to fit with what ``WhitespaceManager::appendNewlineText`` is doing LGTM Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.ll

[PATCH] D59977: [Lexer] Fix an off-by-one bug in Lexer::getAsCharRange() - NFC.

This revision was automatically updated to reflect the committed changes. Closed by commit rC359035: Re-apply r357823 "[Lexer] NFC: Fix an off-by-one bug in getAsCharRange()." (authored by dergachev, committed by ). Changed prior to commit: https://reviews.llvm.org/D59977?vs=196310&id=196323#t

[PATCH] D59121: [analyzer] Fix macro names in diagnostics within bigger macros.

This revision was automatically updated to reflect the committed changes. Closed by commit rC359037: [analyzer] Fix macro names in diagnostics within bigger macros. (authored by dergachev, committed by ). Changed prior to commit: https://reviews.llvm.org/D59121?vs=192917&id=196329#toc Reposito

[PATCH] D61029: clang-cl: List valid values for /std: in /? output

This revision was automatically updated to reflect the committed changes. Closed by commit rL359107: clang-cl: List valid values for /std: in /? output (authored by nico, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit: https://revi

[PATCH] D60764: Add clang cc1 option to generate OpenCL builtin functions

Pierre updated this revision to Diff 196474. Pierre marked an inline comment as done. Pierre added a comment. The name of the command line option has been updated. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60764/new/ https://reviews.llvm.org/D60764 Files: clang/include/clang/Basi

[PATCH] D60523: [clang] Don't segfault on incorrect using directive (PR41400)

Tyker added a subscriber: jkooker. Tyker added a comment. @jkooker i don't think it is possible for `ASTContext::getDependentNameType` to deal with `NSS = nullptr` except by reporting the error. we probably don't want to just report the error because the error could have been handled before invo

[PATCH] D59802: [clang-tidy] Add new checker: llvm-prefer-isa-or-dyn-cast-in-conditionals

This revision was automatically updated to reflect the committed changes. Closed by commit rL359142: [clang-tidy] Add new checker: llvm-prefer-isa-or-dyn-cast-in-conditionals (authored by dhinton, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prio

[PATCH] D60764: Add clang cc1 option to generate OpenCL builtin functions

Pierre updated this revision to Diff 196590. Pierre added a comment. Forgot to update one argument CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60764/new/ https://reviews.llvm.org/D60764 Files: clang/include/clang/Basic/LangOptions.def clang/include/clang/Driver/CC1Options.td cl

[PATCH] D60763: Prototype OpenCL BIFs using Tablegen

Pierre updated this revision to Diff 196591. Pierre marked 10 inline comments as done. Pierre added a comment. In this new patch: - Documentation has been added - The multiclasses in OpenCLBuiltins.td filehave been slighly changed to have a more generic way to generate function prototypes - In C

[PATCH] D60763: Prototype OpenCL BIFs using Tablegen

Pierre added a comment. Other comments: 1- When a header file is included, its function declarations are decorated with the "nounwind" attribute, meaning that the function is not supposed to throw an exception. This decorator is currently not added with the new mechanism. The "readnone" decorato

[PATCH] D59814: [Testing] Move clangd::Annotations to llvm testing support

This revision was automatically updated to reflect the committed changes. Closed by commit rL359179: [Testing] Move clangd::Annotations to llvm testing support (authored by ibiryukov, committed by ). Changed prior to commit: https://reviews.llvm.org/D59814?vs=196599&id=196602#toc Repository:

[PATCH] D60763: Prototype OpenCL BIFs using Tablegen

Pierre added a comment. I also think we could reduce the size of the tables. To sum up how this is working right now: 1. The isOpenCLBuiltin(char* functionName) funcion is called to determine if a function is part of OpenCL builtin functions. If so, it returns its associated pair (index, number

[PATCH] D60274: [ELF] Implement Dependent Libraries Feature

bd1976llvm added a comment. I am keen to keep this moving. I think there are a few things outstanding: 1. Need to resolve concerns w.r.t the design. 2. I need to find out whether I should be doing validation when reading the metadata in LLVM. 3. The LLD side needs a more detailed review. @jykn

[PATCH] D60988: [analyzer] Fix crash when returning C++ objects from ObjC messages-to-nil.

This revision was automatically updated to reflect the committed changes. Closed by commit rC359262: [analyzer] Fix crash when returning C++ objects from ObjC messages-to-nil. (authored by dergachev, committed by ). Changed prior to commit: https://reviews.llvm.org/D60988?vs=196161&id=196780#to

[PATCH] D60991: [analyzer] RetainCount: Allow offsets in return values.

This revision was automatically updated to reflect the committed changes. Closed by commit rC359263: [analyzer] RetainCount: Allow offsets in return values. (authored by dergachev, committed by ). Changed prior to commit: https://reviews.llvm.org/D60991?vs=196170&id=196781#toc Repository: rC

[PATCH] D61161: [analyzer] RetainCount: Add a suppression for functions that follow "the Matching rule".

This revision was automatically updated to reflect the committed changes. Closed by commit rC359264: [analyzer] RetainCount: Add a suppression for "the Matching rule". (authored by dergachev, committed by ). Changed prior to commit: https://reviews.llvm.org/D61161?vs=196764&id=196782#toc Repos

[PATCH] D61173: [BPF] do not generate predefined macro bpf

This revision was automatically updated to reflect the committed changes. Closed by commit rL359310: [BPF] do not generate predefined macro bpf (authored by yhs, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.llvm.

[PATCH] D60934: [clang] adding explicit(bool) from c++2a

Tyker marked 2 inline comments as done. Tyker added inline comments. Comment at: clang/include/clang/AST/DeclCXX.h:2033 + + void setExplicitSpecifier(ExplicitSpecInfo ESI); + rsmith wrote: > Generally we don't want to have setters in the AST; the AST is intended

[PATCH] D61222: [clang-format] Fix bug in determineTokenType() for TT_StartOfName

MyDeveloperDay accepted this revision. MyDeveloperDay added a comment. This revision is now accepted and ready to land. LGTM Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61222/new/ https://reviews.llvm.org/D61222 __

[PATCH] D60934: [clang] adding explicit(bool) from c++2a

Tyker marked an inline comment as done. Tyker added a comment. Fixed based on Feedback from @rsmith @martong @Rakete. feedback that weren't fixed have comment explaining why. Comment at: clang/include/clang/AST/DeclCXX.h:2033 + + void setExplicitSpecifier(ExplicitSpecInfo

[PATCH] D59465: [analyzer] Add example plugin for checker option handling

whisperity added a comment. @Szelethus I know the dependent patch D59464 will move `examples/analyzer-plugin` to `test/Analysis/plugins/...`, but this patch still seems to affect `examples/`. Are you sure this is the right diff? Because you are adding brand new

[PATCH] D57922: [analyzer] Insert checker options into AnalyzerOption::ConfigTable

whisperity added a comment. I think this is good. Patch still marked as //Needs review// for some reason. 😦 Can we look up this `blocking review` thing? Perhaps this could be marked ready to roll once the dependency patch is ironed out. Comment at: lib/StaticAnalyzer/Frontend

[PATCH] D57858: [analyzer] Add a new frontend flag to display all checker options

whisperity added a comment. @dcoughlin How would removing the `USAGE` part of the dump and keeping only the list of options and their formatted help sound? That way, this option will not invite the user to directly call the analyzer. In D57858#1432714 ,

[PATCH] D61260: [clang-tidy] Extend bugprone-sizeof-expression to check sizeof(pointers to structures)

whisperity added inline comments. Comment at: test/clang-tidy/bugprone-sizeof-expression.cpp:196 typedef const MyStruct TMyStruct; + typedef const MyStruct *PMyStruct; While I trust Clang and the matchers to unroll the type and still match, I'd prefer also

[PATCH] D61285: [analyzer] SmartPtrModeling: Fix a null dereference.

This revision was automatically updated to reflect the committed changes. Closed by commit rC359530: [analyzer] SmartPtrModeling: Fix a null dereference. (authored by dergachev, committed by ). Changed prior to commit: https://reviews.llvm.org/D61285?vs=197222&id=197251#toc Repository: rC Cl

[PATCH] D61051: [analyzer] Treat functions without runtime branches as "small".

This revision was automatically updated to reflect the committed changes. Closed by commit rC359531: [analyzer] Treat functions without run-time branches as "small". (authored by dergachev, committed by ). Changed prior to commit: https://reviews.llvm.org/D61051?vs=197248&id=197253#toc Reposit

[PATCH] D59413: Fix isInSystemMacro in presence of macro and pasted token

serge-sans-paille added a comment. @rsmith : up :-) Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59413/new/ https://reviews.llvm.org/D59413 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.

[PATCH] D60934: [clang] adding explicit(bool) from c++2a

Tyker marked 2 inline comments as done. Tyker added inline comments. Comment at: clang/include/clang/AST/DeclBase.h:1539-1541 +uint64_t NumCtorInitializers : 64 - NumDeclContextBits - +NumFunctionDeclBits - +/*Other used bits in CXXConstructorDecl*/ 3; ---

[PATCH] D61264: Fix inconsistency in calculating DIAG_START values

This revision was automatically updated to reflect the committed changes. Closed by commit rL359558: Fix inconsistency in calculating DIAG_START_ values. (authored by russell_gallop, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit:

[PATCH] D60934: [clang] adding explicit(bool) from c++2a

Tyker added inline comments. Comment at: clang/include/clang/AST/DeclCXX.h:2033 + + void setExplicitSpecifier(ExplicitSpecInfo ESI); + Tyker wrote: > Tyker wrote: > > rsmith wrote: > > > Generally we don't want to have setters in the AST; the AST is intended >

[PATCH] D61338: [WebAssembly] Use the "wasm32-wasi" triple in tests

This revision was automatically updated to reflect the committed changes. Closed by commit rC359630: [WebAssembly] Use the "wasm32-wasi" triple in tests (authored by djg, committed by ). Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61338/new/ https://reviews.llvm

[PATCH] D61297: [clang-format] Fix bug that misses some function-like macro usages

MyDeveloperDay accepted this revision. MyDeveloperDay added a comment. This revision is now accepted and ready to land. LGTM Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61297/new/ https://reviews.llvm.org/D61297 __

[PATCH] D61281: [clang-format] Fixed self assignment

MyDeveloperDay added a comment. Did this case some issue? Does this fix something if so can we add a test, because maybe the line isn't needed Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61281/new/ https://reviews.llvm.org/D61281 ___

[PATCH] D61276: [clang-format] Fix bug in block comment reflow that joins * and /

MyDeveloperDay added a comment. Thanks for the patch, is this case only limited to * Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61276/new/ https://reviews.llvm.org/D61276 ___ cfe-commits mailing list cfe-commits@l

[PATCH] D61256: [clang-format][docs] Fix the Google C++ and Chromium style guide URLs

MyDeveloperDay accepted this revision. MyDeveloperDay added a comment. This revision is now accepted and ready to land. Thanks for the patch, thanks also for changing to https as I believe this was a change suggested in clang tidy docs too Repository: rG LLVM Github Monorepo CHANGES SINCE LA

[PATCH] D60934: [clang] adding explicit(bool) from c++2a

Tyker added inline comments. Comment at: clang/include/clang/AST/DeclCXX.h:2579 +assert( +!ES.getExpr() || +CXXConstructorDeclBits.HasTrailingExplicitSpecifier && Rakete wrote: > Your or needs parens or the disambiguation is wrong. i don't

[PATCH] D61222: [clang-format] Fix a bug in AlignConsecutiveDeclarations

MyDeveloperDay accepted this revision. MyDeveloperDay added a comment. This revision is now accepted and ready to land. LGTM Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61222/new/ https://reviews.llvm.org/D61222 __

[PATCH] D58404: [clang-format] Add basic support for formatting C# files

MyDeveloperDay marked an inline comment as done. MyDeveloperDay added inline comments. Comment at: lib/Format/FormatTokenLexer.cpp:249 + Identifier->ColumnWidth += Question->ColumnWidth; + Identifier->Type = Identifier->Type; + Tokens.erase(Tokens.end() - 1);

[PATCH] D61324: Make check-clang depend on the clang-check binary always

This revision was automatically updated to reflect the committed changes. Closed by commit rL359717: Make check-clang depend on the clang-check binary always (authored by nico, committed by ). Changed prior to commit: https://reviews.llvm.org/D61324?vs=197370&id=197614#toc Repository: rL LLV

[PATCH] D60934: [clang] adding explicit(bool) from c++2a

Tyker added inline comments. Comment at: clang/lib/Sema/SemaInit.cpp:9361 // Only consider converting constructors. -if (GD->isExplicit()) +if (!GD->isMaybeNotExplicit()) continue; rsmith wrote: > Tyker wrote: > > rsmith wrote:

[PATCH] D61304: [OpenCL][PR41609] Deduce static data members to __global addr space

This revision was automatically updated to reflect the committed changes. Closed by commit rL359789: [OpenCL] Deduce static data members to __global addr space. (authored by stulova, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit:

[PATCH] D61319: [PR41674] [OpenCL] Fix initialisation of this via pointer

This revision was automatically updated to reflect the committed changes. Closed by commit rC359798: [OpenCL] Fix initialisation of this via pointer. (authored by stulova, committed by ). Changed prior to commit: https://reviews.llvm.org/D61319?vs=197749&id=197800#toc Repository: rC Clang C

[PATCH] D61418: Another attempt to fix "could not find clang-check" lit warning in analyzer-less builds

This revision was automatically updated to reflect the committed changes. Closed by commit rL359820: Another attempt to fix "could not find clang-check" lit warning in analyzer… (authored by nico, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior

[PATCH] D60763: Prototype OpenCL BIFs using Tablegen

Pierre updated this revision to Diff 197932. Pierre marked 39 inline comments as done. Pierre added a comment. Requested changes have been made in this diff. Some comments/ TODO have not been done yet. They will be done in a next patch. This first patch is meant to start introducing the featur

[PATCH] D60763: Prototype OpenCL BIFs using Tablegen

Pierre added inline comments. Comment at: clang/include/clang/Basic/OpenCLBuiltins.td:65 +class QualType { + // How to get the QualType. Can be one of ("field", "func") + string AccessMethod = _AccessMethod; Anastasia wrote: > I don't think "field" and "func" a

[PATCH] D61276: [clang-format] Fix bug in block comment reflow that joins * and /

MyDeveloperDay accepted this revision. MyDeveloperDay added a comment. This revision is now accepted and ready to land. LGTM Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61276/new/ https://reviews.llvm.org/D61276 __

[PATCH] D61281: [clang-format] Fixed self assignment

MyDeveloperDay added a comment. In D61281#1488022 , @RKSimon wrote: > In D61281#1485833 , @MyDeveloperDay > wrote: > > > Did this cause some issue? Does this fix something if so can we add a test, > > because mayb

[PATCH] D61269: [CommandLine] Change help output to prefix long options with `--` instead of `-`. NFC . Part 3 of 5

This revision was automatically updated to reflect the committed changes. Closed by commit rL359909: [CommandLine] Change help output to prefix long options with `--` instead of `… (authored by dhinton, committed by ). Herald added a subscriber: kristina. Changed prior to commit: https://review

[PATCH] D61474: [CUDA][Clang][Bugfix] Add missing CUDA 9.2 case

This revision was automatically updated to reflect the committed changes. Closed by commit rC359910: [CUDA][Clang][Bugfix] Add missing CUDA 9.2 case (authored by gbercea, committed by ). Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61474/new/ https://reviews.llvm

[PATCH] D61270: [CommandLine] Enable Grouping for short options by default. Part 4 of 5

This revision was automatically updated to reflect the committed changes. Closed by commit rL359917: [CommandLine] Enable Grouping for short options by default. Part 4 of 5 (authored by dhinton, committed by ). Herald added a subscriber: kristina. Changed prior to commit: https://reviews.llvm.

[PATCH] D61345: Allow 'CodeGenObjC/illegal-UTF8.m' test for 32-bit targets.

gkistanova accepted this revision. gkistanova added a comment. This revision is now accepted and ready to land. Thanks for fixing this, Vlad! Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61345/new/ https://reviews.llvm.org/D61345 _

[PATCH] D61552: [clang] Adapt ASTMatcher to explicit(bool) specifier

Tyker created this revision. Tyker added a reviewer: klimek. Herald added a project: clang. Herald added a subscriber: cfe-commits. Changes: - add an ast matcher for deductiong guide. - allow isExplicit matcher for deductiong guide. - add hasExplicitSpecifier matcher which matches for declaration

[PATCH] D61556: [clang] fixing -ast-print for variadic parameter pack in lambda capture

Tyker added a comment. could you commit it for me please ? Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61556/new/ https://reviews.llvm.org/D61556 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://list

[PATCH] D61345: Allow 'CodeGenObjC/illegal-UTF8.m' test for 32-bit targets.

This revision was automatically updated to reflect the committed changes. Closed by commit rL360005: The 'CodeGenObjC/illegal-UTF8.m' get failed with Clang built with 32-bit… (authored by gkistanova, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed pr

[PATCH] D60552: [X86] Enable intrinsics of AVX512_BF16, which are supported for BFLOAT16 in Cooper Lake

This revision was automatically updated to reflect the committed changes. Closed by commit rL360018: Enable intrinsics of AVX512_BF16, which are supported for BFLOAT16 in Cooper… (authored by LuoYuanke, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed

[PATCH] D60934: [clang] adding explicit(bool) from c++2a

Tyker added a comment. yes i am on it. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60934/new/ https://reviews.llvm.org/D60934 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/m

<    14   15   16   17   18   19   20   21   22   23   >