[PATCH] D53263: Fix places where the return type of a FunctionDecl was being used in place of the function type

2018-11-10 Thread Ben via Phabricator via cfe-commits
bobsayshilol added a comment. Thanks! I don't have commit access to land this myself. https://reviews.llvm.org/D53263 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D53263: Fix places where the return type of a FunctionDecl was being used in place of the function type

2018-11-10 Thread Ben via Phabricator via cfe-commits
bobsayshilol added a comment. In https://reviews.llvm.org/D53263#1294383, @kristina wrote: > I can do it if you'd like, will be a moment though. Thanks and much appreciated! https://reviews.llvm.org/D53263 ___ cfe-commits mailing list cfe-commits

[PATCH] D53974: [clang-tidy] new check: bugprone-too-small-loop-variable

2018-11-11 Thread Whisperity via Phabricator via cfe-commits
whisperity added a comment. In https://reviews.llvm.org/D53974#1294385, @ztamas wrote: > I also tested on LLVm code. > The output is here: > https://gist.github.com/tzolnai/fe4f23031d3f9fdbdbf1ee38abda00a4 > > I found 362 warnings. > > Around 95% of these warnings are similar to the next exampl

[PATCH] D53263: Fix places where the return type of a FunctionDecl was being used in place of the function type

2018-11-11 Thread Ben via Phabricator via cfe-commits
bobsayshilol added a comment. In https://reviews.llvm.org/D53263#1294477, @kristina wrote: > Huge apologies, it seems I can't get this to patch cleanly against my fork > and therefore can't test it before committing, which is something I generally > always do. I'll leave it to someone else. Aga

[PATCH] D50318: Support Swift in platform availability attribute

2018-11-11 Thread Phabricator via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rC346633: Support Swift in platform availability attribute (authored by mwu, committed by ). Repository: rC Clang https://reviews.llvm.org/D50318 Files: include/clang/Basic/Attr.td include/clang/Bas

[PATCH] D52034: [Clang] Add options -fprofile-filter-files and -fprofile-exclude-files to filter the files to instrument with gcov

2018-11-12 Thread calixte via Phabricator via cfe-commits
calixte updated this revision to Diff 173622. calixte added a comment. Update ReleaseNotes Repository: rC Clang https://reviews.llvm.org/D52034 Files: docs/ReleaseNotes.rst docs/UsersManual.rst include/clang/Driver/Options.td include/clang/Frontend/CodeGenOptions.h lib/CodeGen/Back

[PATCH] D52034: [Clang] Add options -fprofile-filter-files and -fprofile-exclude-files to filter the files to instrument with gcov

2018-11-12 Thread calixte via Phabricator via cfe-commits
calixte updated this revision to Diff 173623. calixte added a comment. Forgot the ellipsis in the release notes. Repository: rC Clang https://reviews.llvm.org/D52034 Files: docs/ReleaseNotes.rst docs/UsersManual.rst include/clang/Driver/Options.td include/clang/Frontend/CodeGenOption

[PATCH] D52034: [Clang] Add options -fprofile-filter-files and -fprofile-exclude-files to filter the files to instrument with gcov

2018-11-12 Thread calixte via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rC346642: [Clang] Add options -fprofile-filter-files and -fprofile-exclude-files to… (authored by calixte, committed by ). Changed prior to commit: https://reviews.llvm.org/D52034?vs=173623&id=173627#toc

[PATCH] D54416: [GCOV] fix test after patch rL346642

2018-11-12 Thread calixte via Phabricator via cfe-commits
calixte created this revision. calixte added a reviewer: marco-c. Herald added a subscriber: cfe-commits. Test is failing under windows, so fix it Repository: rC Clang https://reviews.llvm.org/D54416 Files: test/CodeGen/code-coverage-filter.c Index: test/CodeGen/code-coverage-filter.c ==

[PATCH] D54416: [GCOV] fix test after patch rL346642

2018-11-12 Thread calixte via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL346644: [GCOV] fix test after patch rL346642 (authored by calixte, committed by ). Herald added a subscriber: llvm-commits. Repository: rL LLVM https://reviews.llvm.org/D54416 Files: cfe/trunk/test/

[PATCH] D54310: Make clang-based tools find libc++ on MacOS

2018-11-12 Thread Phabricator via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL346652: Make clang-based tools find libc++ on MacOS (authored by ibiryukov, committed by ). Herald added a subscriber: llvm-commits. Repository: rL LLVM https://reviews.llvm.org/D54310 Files: cfe/tr

[PATCH] D54311: Add a test checking clang-tidy can find libc++ on Mac

2018-11-12 Thread Phabricator via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rCTE346653: Add a test checking clang-tidy can find libc++ on Mac (authored by ibiryukov, committed by ). Changed prior to commit: https://reviews.llvm.org/D54311?vs=173659&id=173664#toc Repository: rC

[PATCH] D54414: [Sema] Make sure we substitute an instantiation-dependent default template parameter

2018-11-12 Thread Phabricator via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL346709: [Sema] Make sure we substitute an instantiation-dependent default template… (authored by epilk, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.

[PATCH] D54426: [clang-cl] Do not allow using both /Zc:dllexportInlines- and /fallback flag

2018-11-12 Thread Phabricator via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rC346733: [clang-cl] Do not allow using both /Zc:dllexportInlines- and /fallback flag (authored by tikuta, committed by ). Changed prior to commit: https://reviews.llvm.org/D54426?vs=173810&id=173811#toc

[PATCH] D53771: [clang-tidy] Avoid C arrays check

2018-11-14 Thread Phabricator via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL346835: [clang-tidy] Avoid C arrays check (authored by lebedevri, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.llvm.org/D53771?vs=173514&id=173996#to

[PATCH] D54524: [AST] Pack UnaryOperator

2018-11-15 Thread Phabricator via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL346951: [AST] Pack UnaryOperator (authored by brunoricci, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.llvm.org/D54524?vs=174024&id=174195#toc Repos

[PATCH] D54525: [AST] Pack MemberExpr

2018-11-15 Thread Phabricator via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rC346953: [AST] Pack MemberExpr (authored by brunoricci, committed by ). Changed prior to commit: https://reviews.llvm.org/D54525?vs=174026&id=174196#toc Repository: rC Clang https://reviews.llvm.org/

[PATCH] D54526: [AST] Pack BinaryOperator

2018-11-15 Thread Phabricator via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rC346954: [AST] Pack BinaryOperator (authored by brunoricci, committed by ). Repository: rC Clang https://reviews.llvm.org/D54526 Files: include/clang/AST/Expr.h include/clang/AST/Stmt.h Index: inc

[PATCH] D54166: [AST] Store the string data in StringLiteral in a trailing array of chars

2018-11-15 Thread Phabricator via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL346969: [AST] Store the string data in StringLiteral in a trailing array of chars (authored by brunoricci, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit: https://revie

[PATCH] D54600: [Clang] Add options -fprofile-filter-files and -fprofile-exclude-files to filter the files to instrument with gcov (after revert https://reviews.llvm.org/rL346659)

2018-11-15 Thread calixte via Phabricator via cfe-commits
calixte created this revision. calixte added a reviewer: marco-c. Herald added a subscriber: cfe-commits. the previous patch (https://reviews.llvm.org/rC346642) has been reverted because of test failure under windows. So this patch fix the test cfe/trunk/test/CodeGen/code-coverage-filter.c. Rep

[PATCH] D49754: Add -m(no-)spe, and e500 CPU definitions and support to clang

2018-11-16 Thread vit9696 via Phabricator via cfe-commits
vit9696 added a comment. Thanks for the fix. I made a quick check of the mentioned patch, and it looks like it does solve the issue. However, besides the previous crash, which remains unfixed as of 7.0.1rc2, there is another instruction selection failure crash that may be caused by the change.

[PATCH] D53764: [OpenCL] Enable address spaces for references in C++

2018-11-16 Thread Phabricator via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL347059: [OpenCL] Enable address spaces for references in C++ (authored by stulova, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.llvm.org/D53764?vs=17

[PATCH] D54600: [Clang] Add options -fprofile-filter-files and -fprofile-exclude-files to filter the files to instrument with gcov (after revert https://reviews.llvm.org/rL346659)

2018-11-17 Thread calixte via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rC347144: [Clang] Add options -fprofile-filter-files and -fprofile-exclude-files to… (authored by calixte, committed by ). Changed prior to commit: https://reviews.llvm.org/D54600?vs=174281&id=174512#toc

[PATCH] D54672: clang-include-fixer.el: support remote files

2018-11-17 Thread Philipp via Phabricator via cfe-commits
phst created this revision. phst added a reviewer: klimek. Herald added a subscriber: cfe-commits. Support remote files (e.g., Tramp) in the Emacs integration for clang-include-fixer Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D54672 Files: include-fixer/tool/clang-include

[PATCH] D54634: [OpenCL] Fix address space deduction in template args

2018-11-19 Thread Phabricator via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL347189: [OpenCL] Fix address space deduction in template args. (authored by stulova, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.llvm.org/D54634?vs=

[PATCH] D53069: [analyzer][www] Update avaible_checks.html

2018-11-19 Thread Whisperity via Phabricator via cfe-commits
whisperity added a comment. Let's register the ID... Superseded by https://reviews.llvm.org/D54429. https://reviews.llvm.org/D53069 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D53949: [clang][CodeGen] Implicit Conversion Sanitizer: discover the world of CompoundAssign operators

2018-11-19 Thread Phabricator via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL347258: [clang][CodeGen] Implicit Conversion Sanitizer: discover the world of… (authored by lebedevri, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.l

[PATCH] D53231: [Sema] Fix PR38987: keep end location of a direct initializer list

2018-11-19 Thread Phabricator via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rC347261: [Sema] Fix PR38987: keep end location of a direct initializer list (authored by vedantk, committed by ). Changed prior to commit: https://reviews.llvm.org/D53231?vs=169526&id=174667#toc Reposit

[PATCH] D53244: [Coverage] Fix PR39258: support coverage regions that start deeper than they end

2018-11-19 Thread Phabricator via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rC347262: [Coverage] Fix PR39258: support coverage regions that start deeper than they end (authored by vedantk, committed by ). Changed prior to commit: https://reviews.llvm.org/D53244?vs=172042&id=17466

[PATCH] D51295: Allow resetting of NumCreatedFIDsForFileID

2018-11-20 Thread Phabricator via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rC347304: Allow force updating the NumCreatedFIDsForFileID. (authored by vvassilev, committed by ). Repository: rC Clang https://reviews.llvm.org/D51295 Files: include/clang/Basic/SourceManager.h In

[PATCH] D54675: [AST] Store the expressions in ParenListExpr in a trailing array

2018-11-20 Thread Phabricator via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL347320: [AST] Store the expressions in ParenListExpr in a trailing array (authored by brunoricci, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.llvm.o

[PATCH] D54675: [AST] Store the expressions in ParenListExpr in a trailing array

2018-11-20 Thread Phabricator via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rC347320: [AST] Store the expressions in ParenListExpr in a trailing array (authored by brunoricci, committed by ). Repository: rC Clang https://reviews.llvm.org/D54675 Files: include/clang/AST/Expr.h

[PATCH] D52695: [clang][Parse] Diagnose useless null statements (PR39111)

2018-11-20 Thread Phabricator via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rC347339: [clang][Parse] Diagnose useless null statements / empty init-statements (authored by lebedevri, committed by ). Changed prior to commit: https://reviews.llvm.org/D52695?vs=174624&id=174812#toc

[PATCH] D54757: [clang-tidy] new check: bugprone-branch-clone

2018-11-21 Thread Whisperity via Phabricator via cfe-commits
whisperity added a comment. Bar the previous comments, I really like this. The test suite is massive and well-constructed. Do we know of any real-world findings, maybe even from LLVM? Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D54757 __

[PATCH] D54757: [clang-tidy] new check: bugprone-branch-clone

2018-11-21 Thread Whisperity via Phabricator via cfe-commits
whisperity added a comment. In https://reviews.llvm.org/D54757#1305306, @Eugene.Zelenko wrote: > In https://reviews.llvm.org/D54757#1305114, @whisperity wrote: > > > Bar the previous comments, I really like this. The test suite is massive > > and well-constructed. Do we know of any real-world fi

[PATCH] D54441: [OPENMP] Support relational-op !- (not-equal) as one of the canonical forms of random access iterator

2018-11-21 Thread Phabricator via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL347405: [OPENMP] Support relational-op != (not-equal) as one of the canonical (authored by kli, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.llvm.or

[PATCH] D54638: [OpenMP] remove redundant MapTypeModifierSpecified flag in ParseOpenMP.cpp (NFC)

2018-11-21 Thread Phabricator via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL347408: [OPENMP] remove redundant MapTypeModifierSpecified flag in ParseOpenMP.cpp (NFC) (authored by kli, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit: https://revie

[PATCH] D54708: [OPENMP] NFC: Refactor code for parsing omp declare target directive and its clauses

2018-11-21 Thread Phabricator via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rC347411: [OPENMP] Refactor code for parsing omp declare target directive and its clauses… (authored by kli, committed by ). Changed prior to commit: https://reviews.llvm.org/D54708?vs=174627&id=174963#to

[PATCH] D54829: [clangd] Cleanup: make diagnostics callbacks from TUScheduler non-racy

2018-11-22 Thread Phabricator via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rCTE347468: [clangd] Cleanup: make diagnostics callbacks from TUScheduler non-racy (authored by ibiryukov, committed by ). Changed prior to commit: https://reviews.llvm.org/D54829?vs=175053&id=175055#toc

[PATCH] D54760: [clangd] Cleanup: make the diags callback global in TUScheduler

2018-11-22 Thread Phabricator via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL347474: [clangd] Cleanup: make the diags callback global in TUScheduler (authored by ibiryukov, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.llvm.org

[PATCH] D52311: [clangd] Add support for hierarchical documentSymbol

2018-11-23 Thread Phabricator via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL347498: [clangd] Add support for hierarchical documentSymbol (authored by ibiryukov, committed by ). Herald added a subscriber: llvm-commits. Repository: rL LLVM https://reviews.llvm.org/D52311 Files:

[PATCH] D33029: [clang-format] add option for dangling parenthesis

2018-11-24 Thread Sergey via Phabricator via cfe-commits
DevAlone added a comment. So, will it be added? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D33029/new/ https://reviews.llvm.org/D33029 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/

[PATCH] D53807: Create a diagnostic group for warn_call_to_pure_virtual_member_function_from_ctor_dtor, so it can be turned into an error using Werror

2018-11-26 Thread Phabricator via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rC347555: Create a diagnostic group for warn_call_to_pure_virtual_member_function_from_ct… (authored by sylvestre, committed by ). Changed prior to commit: https://reviews.llvm.org/D53807?vs=171502&id=17

[PATCH] D52275: [Index] Expose USR generation for types

2018-11-26 Thread Phabricator via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rC347558: [Index] Expose USR generation for types (authored by ibiryukov, committed by ). Herald added a subscriber: arphaman. Changed prior to commit: https://reviews.llvm.org/D52275?vs=166167&id=175252#

[PATCH] D52273: [clangd] Initial implementation of expected types

2018-11-26 Thread Phabricator via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL347559: [clangd] Initial implementation of expected types (authored by ibiryukov, committed by ). Herald added a subscriber: llvm-commits. Repository: rL LLVM CHANGES SINCE LAST ACTION https://review

[PATCH] D52274: [clangd] Collect and store expected types in the index

2018-11-26 Thread Phabricator via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL347560: [clangd] Collect and store expected types in the index (authored by ibiryukov, committed by ). Herald added a subscriber: llvm-commits. Repository: rL LLVM CHANGES SINCE LAST ACTION https://r

[PATCH] D52276: [clangd] Add type boosting in code completion

2018-11-26 Thread Phabricator via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rCTE347562: [clangd] Add type boosting in code completion (authored by ibiryukov, committed by ). Changed prior to commit: https://reviews.llvm.org/D52276?vs=175258&id=175260#toc Repository: rCTE Clang

[PATCH] D54425: [AArch64] Add aarch64_vector_pcs function attribute to Clang

2018-11-26 Thread Phabricator via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rC347571: [AArch64] Add aarch64_vector_pcs function attribute to Clang (authored by s.desmalen, committed by ). Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D54425/new/ http

[PATCH] D54878: [clangd] NFC: Prefer `isa<>` to `dyn_cast<>` to do the checking.

2018-11-26 Thread Phabricator via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rCTE347635: [clangd] NFC: Prefer `isa<>` to `dyn_cast<>` to do the checking. (authored by henrywong, committed by ). Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.or

[PATCH] D54792: add -march=cascadelake support in clang

2018-11-27 Thread Phabricator via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rC347682: [X86] Add -march=cascadelake support in clang. (authored by ctopper, committed by ). Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D54792/new/ https://reviews.llvm.

[PATCH] D53100: clang: Add ARCTargetInfo

2018-11-27 Thread Phabricator via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rC347699: [clang][ARC] Add ARCTargetInfo (authored by tkrasnukha, committed by ). Changed prior to commit: https://reviews.llvm.org/D53100?vs=175290&id=175549#toc Repository: rC Clang CHANGES SINCE LA

[PATCH] D54958: [OPENMP] remove redundant ColonExpected flag in ParseOpenMP.cpp - (NFC)

2018-11-27 Thread Phabricator via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL347723: [OPENMP] remove redundant ColonExpected flag in ParseOpenMP.cpp (NFC) (authored by kli, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.llvm.org

[PATCH] D51865: [clang-tidy] Added a test -export-fixes with relative paths.

2018-11-28 Thread Phabricator via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rCTE347760: [clang-tidy] Added a test -export-fixes with relative paths. (authored by ibiryukov, committed by ). Changed prior to commit: https://reviews.llvm.org/D51865?vs=164688&id=175682#toc Repositor

[PATCH] D54974: [analyzer] Cleanup constructors in the Z3 backend

2018-11-28 Thread Phabricator via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rC34: [analyzer] Cleanup constructors in the Z3 backend (authored by mramalho, committed by ). Herald added a subscriber: cfe-commits. Changed prior to commit: https://reviews.llvm.org/D54974?vs=17557

[PATCH] D54858: [OpenCL] Improve diagnostics for address spaces in template instantiation

2018-11-29 Thread Phabricator via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL347865: [OpenCL] Improve diags for addr spaces in templates (authored by stulova, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.llvm.org/D54858?vs=175

[PATCH] D54970: [OpenMP] Add a new version of the SPMD deinit kernel function

2018-11-29 Thread Phabricator via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rC347915: [OpenMP] Add a new version of the SPMD deinit kernel function (authored by gbercea, committed by ). Changed prior to commit: https://reviews.llvm.org/D54970?vs=175573&id=175940#toc Repository:

[PATCH] D55037: [-gmodules] Honor -fdebug-prefix-map in the debug info inside PCMs.

2018-11-29 Thread Phabricator via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rC347926: [-gmodules] Honor -fdebug-prefix-map in the debug info inside PCMs. (authored by adrian, committed by ). Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55037/new/ h

[PATCH] D18860: [analyzer] Fix the "Zombie symbols" issue.

2018-11-29 Thread Phabricator via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rC347953: [analyzer] Fix the "Zombie Symbols" bug. (authored by dergachev, committed by ). Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D18860/new/ https://reviews.llvm.org/

[PATCH] D54017: [analyzer] NullabilityChecker: Invariant violation should only be triggered for symbols.

2018-11-29 Thread Phabricator via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rC347954: [analyzer] Nullability: Don't detect post factum violation on concrete values. (authored by dergachev, committed by ). Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/

[PATCH] D54013: [analyzer] NFC: MallocChecker: Avoid redundant transitions.

2018-11-29 Thread Phabricator via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rC347955: [analyzer] MallocChecker: Avoid redundant transitions. (authored by dergachev, committed by ). Changed prior to commit: https://reviews.llvm.org/D54013?vs=172629&id=176030#toc Repository: rC

[PATCH] D55121: Make several Python scripts portable across Python2 and Python 3

2018-11-30 Thread serge via Phabricator via cfe-commits
serge-sans-paille created this revision. serge-sans-paille added reviewers: ddunbar, djasper. Herald added subscribers: cfe-commits, kadircet, arphaman, whisperity. Mostly: - portability of print through from __future__ import print_function - xrange -> range - range(...) -> list(range(

[PATCH] D55121: Make several Python scripts portable across Python2 and Python 3

2018-11-30 Thread serge via Phabricator via cfe-commits
serge-sans-paille added a comment. Conversion using the ``futurize`` script, then manual review. For the sake of reviewer sanity, I've left all the difficult part to further separate commits. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55121/new/ https://revie

[PATCH] D55121: Make several Python scripts portable across Python2 and Python 3

2018-11-30 Thread serge via Phabricator via cfe-commits
serge-sans-paille updated this revision to Diff 176141. serge-sans-paille added a comment. Use generic ``from __future__ import `` line whenever it makes sense CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55121/new/ https://reviews.llvm.org/D55121 Files: bindings/python/clang/cindex

[PATCH] D55137: Honor -fdebug-prefix-map when creating function names for the debug info.

2018-11-30 Thread Phabricator via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rC348060: Honor -fdebug-prefix-map when creating function names for the debug info. (authored by adrian, committed by ). Changed prior to commit: https://reviews.llvm.org/D55137?vs=176194&id=176225#toc R

[PATCH] D55121: Make several Python scripts portable across Python2 and Python 3

2018-12-03 Thread serge via Phabricator via cfe-commits
serge-sans-paille updated this revision to Diff 176330. serge-sans-paille edited the summary of this revision. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55121/new/ https://reviews.llvm.org/D55121 Files: bindings/python/clang/cindex.py docs/tools/dump_format_style.py tools/scan-

[PATCH] D55128: [CMake] Store path to vendor-specific headers in clang-headers target property

2018-12-03 Thread Phabricator via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL348116: [CMake] Store path to vendor-specific headers in clang-headers target property (authored by stefan.graenitz, committed by ). Repository: rL LLVM CHANGES SINCE LAST ACTION https://reviews.llvm

[PATCH] D55121: Make several Python scripts portable across Python2 and Python 3

2018-12-03 Thread Phabricator via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL348127: Portable Python script across version (authored by serge_sans_paille, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.llvm.org/D55121?vs=176330&

[PATCH] D54900: [Sema] Avoid CallExpr::setNumArgs in Sema::BuildCallToObjectOfClassType

2018-12-03 Thread Phabricator via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL348134: [Sema] Avoid CallExpr::setNumArgs in Sema::BuildCallToObjectOfClassType (authored by brunoricci, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews

[PATCH] D55124: [CodeComplete] Cleanup access checking in code completion

2018-12-03 Thread Phabricator via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL348135: [CodeComplete] Cleanup access checking in code completion (authored by ibiryukov, committed by ). Herald added a subscriber: llvm-commits. Repository: rL LLVM CHANGES SINCE LAST ACTION https:

[PATCH] D54961: [AArch64] Add command-line option for SSBS

2018-12-03 Thread Phabricator via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rC348142: [AArch64] Add command-line option for SSBS (authored by pabbar01, committed by ). Changed prior to commit: https://reviews.llvm.org/D54961?vs=175537&id=176388#toc Repository: rC Clang CHANGE

[PATCH] D54902: [AST][Sema] Remove CallExpr::setNumArgs

2018-12-03 Thread Phabricator via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL348145: [AST][Sema] Remove CallExpr::setNumArgs (authored by brunoricci, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.llvm.org/D54902?vs=175434&id=17

[PATCH] D55139: [clangd] Avoid memory-mapping files on Windows

2018-12-03 Thread Phabricator via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rCTE348147: [clangd] Avoid memory-mapping files on Windows (authored by ibiryukov, committed by ). Changed prior to commit: https://reviews.llvm.org/D55139?vs=176382&id=176401#toc Repository: rCTE Clan

[PATCH] D55085: Avoid emitting redundant or unusable directories in DIFile metadata entries

2018-12-03 Thread Phabricator via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rC348154: Avoid emitting redundant or unusable directories in DIFile metadata entries. (authored by adrian, committed by ). Changed prior to commit: https://reviews.llvm.org/D55085?vs=176152&id=176422#toc

[PATCH] D55151: [gcov/Darwin] Ensure external symbols are exported when using an export list

2018-12-03 Thread Phabricator via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL348187: [gcov/Darwin] Ensure external symbols are exported when using an export list (authored by vedantk, committed by ). Herald added subscribers: llvm-commits, delcypher. Changed prior to commit: htt

[PATCH] D54017: [analyzer] NullabilityChecker: Invariant violation should only be triggered for symbols.

2018-12-03 Thread Phabricator via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL348188: Re-apply r347954 "[analyzer] Nullability: Don't detect post factum violation..." (authored by dergachev, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit: https:

[PATCH] D54457: [AST] Generate unique identifiers for CXXCtorInitializer objects.

2018-12-03 Thread Phabricator via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL348198: [AST] Generate unique identifiers for CXXCtorInitializer objects. (authored by dergachev, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.llvm.o

[PATCH] D54488: [AST] [analyzer] NFC: Reuse code in stable ID dumping methods.

2018-12-03 Thread Phabricator via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL348199: [AST] [analyzer] NFC: Reuse code in stable ID dumping methods. (authored by dergachev, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.llvm.org/

[PATCH] D54459: [analyzer] Dump reproducible identifiers for objects under construction.

2018-12-03 Thread Phabricator via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rC348200: [analyzer] Dump stable identifiers for objects under construction. (authored by dergachev, committed by ). Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D54459/new/

[PATCH] D54556: [analyzer] MoveChecker Pt.1: Give MisusedMovedObject checker a more consistent name.

2018-12-03 Thread Phabricator via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rC348201: [analyzer] Rename MisusedMovedObjectChecker to MoveChecker (authored by dergachev, committed by ). Changed prior to commit: https://reviews.llvm.org/D54556?vs=174123&id=176484#toc Repository:

[PATCH] D54372: [analyzer] MisusedMovedObject: NFC: Remove dead code after D18860

2018-12-03 Thread Phabricator via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL348208: [analyzer] MoveChecker: NFC: Remove the workaround for the "zombie symbols" bug. (authored by dergachev, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit: https:/

[PATCH] D54557: [analyzer] MoveChecker Pt.2: Restrict the warning to STL objects and locals.

2018-12-03 Thread Phabricator via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rC348210: [analyzer] MoveChecker: Restrict to locals and std:: objects. (authored by dergachev, committed by ). Changed prior to commit: https://reviews.llvm.org/D54557?vs=174475&id=176491#toc Repository

[PATCH] D54560: [analyzer] MoveChecker Pt.3: Improve warning messages a bit.

2018-12-03 Thread Phabricator via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rC348229: [analyzer] MoveChecker: Improve warning and note messages. (authored by dergachev, committed by ). Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D54560/new/ https:/

[PATCH] D54563: [analyzer] MoveChecker Pt.4: Add a few more state reset methods.

2018-12-03 Thread Phabricator via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rC348235: [analyzer] MoveChecker: Add more common state resetting methods. (authored by dergachev, committed by ). Changed prior to commit: https://reviews.llvm.org/D54563?vs=176512&id=176537#toc Reposit

[PATCH] D55221: [AST] Make ArrayTypeTraitExpr non-polymorphic.

2018-12-04 Thread Phabricator via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL348276: [AST][NFC] Make ArrayTypeTraitExpr non polymorphic (authored by brunoricci, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.llvm.org/D55221?vs=1

[PATCH] D55222: [AST] Assert that no statement/expression class is polymorphic

2018-12-04 Thread Phabricator via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rC348278: [AST] Assert that no statement/expression class is polymorphic (authored by brunoricci, committed by ). Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55222/new/ ht

[PATCH] D55225: [AST] Assert that no type class is polymorphic

2018-12-04 Thread Phabricator via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL348281: [AST] Assert that no type class is polymorphic (authored by brunoricci, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.llvm.org/D55225?vs=17641

[PATCH] D54630: Move detection of libc++ include dirs to Driver on MacOS

2018-12-05 Thread Phabricator via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rC348365: Move detection of libc++ include dirs to Driver on MacOS (authored by ibiryukov, committed by ). Changed prior to commit: https://reviews.llvm.org/D54630?vs=174358&id=176805#toc Repository: r

[PATCH] D55127: [OpenCL] Diagnose conflicting address spaces between template definition and its instantiation

2018-12-05 Thread Phabricator via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rC348382: [OpenCL] Diagnose conflicting address spaces in templates. (authored by stulova, committed by ). Changed prior to commit: https://reviews.llvm.org/D55127?vs=176793&id=176841#toc Repository: r

[PATCH] D54866: Cleanups in IdentifierInfo following the removal of PTH

2018-12-05 Thread Phabricator via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rC348384: [Basic] Cleanups in IdentifierInfo following the removal of PTH (authored by brunoricci, committed by ). Changed prior to commit: https://reviews.llvm.org/D54866?vs=175143&id=176843#toc Reposit

[PATCH] D55260: [CodeComplete] Fix a crash in access checks of inner classes

2018-12-05 Thread Phabricator via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rC348387: [CodeComplete] Fix a crash in access checks of inner classes (authored by ibiryukov, committed by ). Changed prior to commit: https://reviews.llvm.org/D55260?vs=176823&id=176847#toc Repository:

[PATCH] D55322: Mention changes to libc++ include dir lookup in release notes.

2018-12-05 Thread Phabricator via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rC348394: Mention changes to libc++ include dir lookup in release notes. (authored by ibiryukov, committed by ). Changed prior to commit: https://reviews.llvm.org/D55322?vs=176809&id=176854#toc Repositor

[PATCH] D55377: Allow forwarding -fdebug-compilation-dir to cc1as

2018-12-06 Thread Phabricator via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL348515: Allow forwarding -fdebug-compilation-dir to cc1as (authored by nico, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.llvm.org/D55377?vs=177004&i

[PATCH] D55331: [CodeComplete] Fix assertion failure

2018-12-07 Thread Phabricator via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL348590: [CodeComplete] Fix assertion failure (authored by ibiryukov, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.llvm.org/D55331?vs=176836&id=177187

[PATCH] D55433: [clang-tidy] Adding a new modernize use nodiscard checker

2018-12-07 Thread MyDeveloperDay via Phabricator via cfe-commits
MyDeveloperDay added a comment. In D55433#1323106 , @lebedev.ri wrote: > Have you evaluated this on some major C++ projects yet? > I suspect this may have pretty low SNR. Internally yes (on millions of lines), but you are correct high noise level, howe

[PATCH] D49754: Add -m(no-)spe, and e500 CPU definitions and support to clang

2018-12-07 Thread vit9696 via Phabricator via cfe-commits
vit9696 added a comment. In D49754#1321078 , @glaubitz wrote: > I have applied this patch to the llvm-toolchain-7 package in Debian and did > not see any regressions on x86_64 or 32-Bit PowerPC. Additionally, I have > included the patches from https://re

[PATCH] D55433: [clang-tidy] Adding a new modernize use nodiscard checker

2018-12-07 Thread MyDeveloperDay via Phabricator via cfe-commits
MyDeveloperDay added a comment. I'm trying to generate an example of the modernize-use-nodiscard checker on something open source...as I developed this checker on Windows I struggled a little getting cmake to build me the json file to run clang-tidy over everything and a lot of projects aren't

[PATCH] D55433: [clang-tidy] Adding a new modernize use nodiscard checker

2018-12-07 Thread MyDeveloperDay via Phabricator via cfe-commits
MyDeveloperDay updated this revision to Diff 177295. MyDeveloperDay added a comment. Address some (not all yet) review comments CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55433/new/ https://reviews.llvm.org/D55433 Files: clang-tidy/modernize/CMakeLists.txt clang-tidy/modernize/M

[PATCH] D55433: [clang-tidy] Adding a new modernize use nodiscard checker

2018-12-07 Thread MyDeveloperDay via Phabricator via cfe-commits
MyDeveloperDay marked 12 inline comments as done. MyDeveloperDay added inline comments. Comment at: clang-tidy/modernize/UseNodiscardCheck.cpp:28-30 +bool isOperator(const FunctionDecl *D) { + return D->getNameAsString().find("operator") != std::string::npos; +}

[PATCH] D55433: [clang-tidy] Adding a new modernize use nodiscard checker

2018-12-07 Thread MyDeveloperDay via Phabricator via cfe-commits
MyDeveloperDay updated this revision to Diff 177311. MyDeveloperDay marked 3 inline comments as done. MyDeveloperDay added a comment. Move more of the conditional checks into the matchers CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55433/new/ https://reviews.llvm.org/D55433 Files:

[PATCH] D55433: [clang-tidy] Adding a new modernize use nodiscard checker

2018-12-07 Thread MyDeveloperDay via Phabricator via cfe-commits
MyDeveloperDay updated this revision to Diff 177312. MyDeveloperDay added a comment. Move the conditional checks into matchers CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55433/new/ https://reviews.llvm.org/D55433 Files: clang-tidy/modernize/CMakeLists.txt clang-tidy/modernize/Mo

<    10   11   12   13   14   15   16   17   18   19   >