[PATCH] D41500: ananas: Add shared library support

2017-12-21 Thread Rink via Phabricator via cfe-commits
zhmu created this revision. zhmu added a reviewer: ed. Herald added a subscriber: cfe-commits. The Ananas Operating System (https://github.com/zhmu/ananas) has shared library support as of commit 57739c0b6ece56dd4872aedf30264ed4b9412c77. This change adds the necessary settings to clang so that s

[PATCH] D41478: [analyzer] Fix zero-initialization of stack VLAs under ARC.

2017-12-21 Thread Phabricator via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rC321290: [analyzer] Fix zero-initialization of stack VLAs under ObjC ARC. (authored by dergachev, committed by ). Repository: rC Clang https://reviews.llvm.org/D41478 Files: lib/StaticAnalyzer/Core/R

[PATCH] D41326: [clang-tidy] Added diagnostics about incorrect usage of NOLINT comment

2017-12-21 Thread Anton via Phabricator via cfe-commits
xgsa added a comment. Ping. https://reviews.llvm.org/D41326 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D41557: [x86][icelake][vbmi2]

2017-12-23 Thread coby via Phabricator via cfe-commits
coby created this revision. Herald added subscribers: cfe-commits, mgorny. added intrinsics support for (while of) vbmi2 instructions, matching a similar work on the backend Repository: rC Clang https://reviews.llvm.org/D41557 Files: include/clang/Basic/BuiltinsX86.def include/clang/Dri

[PATCH] D41326: [clang-tidy] Added diagnostics about incorrect usage of NOLINT comment

2017-12-23 Thread Anton via Phabricator via cfe-commits
xgsa marked 13 inline comments as done. xgsa added a comment. Aaron, thank you for your review and sorry for the coding convention mistakes -- I still cannot get used to the llvm coding convention, because it quite differs from the one I have been using in my projects. Commen

[PATCH] D41326: [clang-tidy] Added diagnostics about incorrect usage of NOLINT comment

2017-12-23 Thread Anton via Phabricator via cfe-commits
xgsa updated this revision to Diff 128091. xgsa marked an inline comment as done. xgsa added a comment. Review comments applied. Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D41326 Files: clang-tidy/ClangTidyDiagnosticConsumer.cpp clang-tidy/ClangTidyDiagnosticConsumer.h

[PATCH] D41326: [clang-tidy] Added diagnostics about incorrect usage of NOLINT comment

2017-12-23 Thread Anton via Phabricator via cfe-commits
xgsa updated this revision to Diff 128092. xgsa added a comment. The full diff (but not only the incremental one) was uploaded. Please, skip previous revision. Sorry. https://reviews.llvm.org/D41326 Files: clang-tidy/ClangTidy.cpp clang-tidy/ClangTidyDiagnosticConsumer.cpp clang-tidy/Cla

[PATCH] D40381: Parse concept definition

2017-12-23 Thread changyu via Phabricator via cfe-commits
changyu marked 27 inline comments as done. changyu added inline comments. Comment at: lib/Sema/SemaTemplate.cpp:7713 + + if (!ConstraintExpr->isTypeDependent() && + ConstraintExpr->getType() != Context.BoolTy) { faisalv wrote: > saar.raz wrote: > > faisalv

[PATCH] D40381: Parse concept definition

2017-12-23 Thread changyu via Phabricator via cfe-commits
changyu updated this revision to Diff 128094. changyu marked an inline comment as done. https://reviews.llvm.org/D40381 Files: include/clang/AST/DeclTemplate.h include/clang/AST/RecursiveASTVisitor.h include/clang/Basic/DeclNodes.td include/clang/Basic/DiagnosticParseKinds.td include/cl

[PATCH] D41558: [x86][icelake][vbmi2]

2017-12-23 Thread coby via Phabricator via cfe-commits
coby created this revision. coby added a reviewer: craig.topper. Herald added a subscriber: mgorny. added intrinsics support for VNNI instructions, matching a similar work on the backend (https://reviews.llvm.org/D40208) Repository: rC Clang https://reviews.llvm.org/D41558 Files: include/

[PATCH] D41564: [x86][icelake][bitalg]

2017-12-24 Thread coby via Phabricator via cfe-commits
coby created this revision. coby added a reviewer: craig.topper. Herald added a subscriber: mgorny. added intrinsics support for bitalg instructions, matching a similar work on the backend (https://reviews.llvm.org/D40222) Repository: rC Clang https://reviews.llvm.org/D41564 Files: includ

[PATCH] D40381: Parse concept definition

2017-12-24 Thread changyu via Phabricator via cfe-commits
changyu added a comment. I don't have commit privilege. And also there's one more problem we might want to address first. Thank you. Comment at: lib/Parse/ParseTemplate.cpp:181 +TemplateParameterList *TPL = ParamLists[0]; +if (TPL->getLAngleLoc().getLocWithOffset(1) =

[PATCH] D40381: Parse concept definition

2017-12-24 Thread changyu via Phabricator via cfe-commits
changyu updated this revision to Diff 128123. changyu marked 2 inline comments as done. https://reviews.llvm.org/D40381 Files: include/clang/AST/DeclTemplate.h include/clang/AST/RecursiveASTVisitor.h include/clang/Basic/DeclNodes.td include/clang/Basic/DiagnosticParseKinds.td include/cl

[PATCH] D40381: Parse concept definition

2017-12-24 Thread changyu via Phabricator via cfe-commits
changyu added a comment. I moved some template param checks from `Parser::ParseTemplateDeclarationOrSpecialization` to `Parser::ParseConceptDefinition` and `Sema::ActOnConceptDefinition`. Comment at: lib/Parse/ParseTemplate.cpp:181 +TemplateParameterList *TPL = ParamLists

[PATCH] D41248: [libcxx] Suppress unused warning on apple.

2017-12-24 Thread Phabricator via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL321435: [libcxx] Suppress unused warning on apple. (authored by dhinton, committed by ). Repository: rL LLVM https://reviews.llvm.org/D41248 Files: libcxx/trunk/src/experimental/filesystem/operation

[PATCH] D41573: [x86][icelake][vpclmulqdq]

2017-12-25 Thread coby via Phabricator via cfe-commits
coby created this revision. coby added a reviewer: craig.topper. Herald added a subscriber: mgorny. added intrinsics support for vpclmulqdq instructions, matching a similar work on the backend (https://reviews.llvm.org/D40101) Repository: rC Clang https://reviews.llvm.org/D41573 Files: in

[PATCH] D41573: [x86][icelake][vpclmulqdq]

2017-12-25 Thread coby via Phabricator via cfe-commits
coby updated this revision to Diff 128139. coby added a comment. removing guards to allow better diags Repository: rC Clang https://reviews.llvm.org/D41573 Files: include/clang/Basic/BuiltinsX86.def include/clang/Driver/Options.td lib/Basic/Targets/X86.cpp lib/Basic/Targets/X86.h l

[PATCH] D41326: [clang-tidy] Added diagnostics about incorrect usage of NOLINT comment

2017-12-25 Thread Anton via Phabricator via cfe-commits
xgsa marked 5 inline comments as done. xgsa added inline comments. Comment at: clang-tidy/ClangTidyDiagnosticConsumer.cpp:276 + + using NolintMap = std::unordered_map xgsa wrote: > > aaron.ballman wrote: > > > Is there a better LLVM ADT to use here? > > This data structure provi

[PATCH] D41326: [clang-tidy] Added diagnostics about incorrect usage of NOLINT comment

2017-12-25 Thread Anton via Phabricator via cfe-commits
xgsa updated this revision to Diff 128144. xgsa marked an inline comment as done. xgsa added a comment. Herald added a subscriber: mgrang. Review comments applied. Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D41326 Files: clang-tidy/ClangTidy.cpp clang-tidy/ClangTidyDiagn

[PATCH] D41582: [x86][icelake][gfni]

2017-12-26 Thread coby via Phabricator via cfe-commits
coby created this revision. coby added a reviewer: craig.topper. Herald added a subscriber: mgorny. added intrinsics support for gfni instructions, matching a similar work on the backend (https://reviews.llvm.org/D40373) Repository: rC Clang https://reviews.llvm.org/D41582 Files: include/

[PATCH] D41582: [x86][icelake][gfni]

2017-12-26 Thread coby via Phabricator via cfe-commits
coby updated this revision to Diff 128168. coby added a comment. add forgotten undef[s] Repository: rC Clang https://reviews.llvm.org/D41582 Files: include/clang/Basic/BuiltinsX86.def include/clang/Driver/Options.td lib/Basic/Targets/X86.cpp lib/Basic/Targets/X86.h lib/Headers/CMak

[PATCH] D41583: [x86][icelake][vaes]

2017-12-26 Thread coby via Phabricator via cfe-commits
coby created this revision. coby added a reviewer: craig.topper. Herald added a subscriber: mgorny. added intrinsics support for vaes instructions, matching a similar work on the backend (https://reviews.llvm.org/D40078) Repository: rC Clang https://reviews.llvm.org/D41583 Files: include/

[PATCH] D41557: [x86][icelake][vbmi2]

2017-12-26 Thread coby via Phabricator via cfe-commits
coby marked 2 inline comments as done. coby added inline comments. Comment at: lib/Basic/Targets/X86.cpp:589 +// Enable BWI instruction if VBMI/VBMI2 is being enabled. +if (Name.startswith("avx512vbmi") && Enabled) Features["avx512bw"] = true; crai

[PATCH] D41557: [x86][icelake][vbmi2]

2017-12-26 Thread coby via Phabricator via cfe-commits
coby updated this revision to Diff 128171. coby added a comment. addressed comments Repository: rC Clang https://reviews.llvm.org/D41557 Files: include/clang/Basic/BuiltinsX86.def include/clang/Driver/Options.td lib/Basic/Targets/X86.cpp lib/Basic/Targets/X86.h lib/Headers/CMakeLis

[PATCH] D41557: [x86][icelake][vbmi2]

2017-12-26 Thread coby via Phabricator via cfe-commits
coby updated this revision to Diff 128172. coby added a comment. tests Repository: rC Clang https://reviews.llvm.org/D41557 Files: include/clang/Basic/BuiltinsX86.def include/clang/Driver/Options.td lib/Basic/Targets/X86.cpp lib/Basic/Targets/X86.h lib/Headers/CMakeLists.txt lib/

[PATCH] D41583: [x86][icelake][vaes]

2017-12-26 Thread coby via Phabricator via cfe-commits
coby added inline comments. Comment at: lib/Basic/Targets/X86.cpp:573 setMMXLevel(Features, AMD3DNowAthlon, Enabled); } else if (Name == "aes") { if (Enabled) craig.topper wrote: > Shouldn't -aes imply -vaes? how come? perhaps i'm missing here someth

[PATCH] D41573: [x86][icelake][vpclmulqdq]

2017-12-26 Thread coby via Phabricator via cfe-commits
coby added inline comments. Comment at: lib/Basic/Targets/X86.cpp:577 } else if (Name == "pclmul") { if (Enabled) setSSELevel(Features, SSE2, Enabled); craig.topper wrote: > I think we should disable vpclmulqdq when pclmul is being disabled. agreed

[PATCH] D41573: [x86][icelake][vpclmulqdq]

2017-12-26 Thread coby via Phabricator via cfe-commits
coby updated this revision to Diff 128183. coby added a comment. turning off pclmul forbids enabling vpclmulqdq Repository: rC Clang https://reviews.llvm.org/D41573 Files: include/clang/Basic/BuiltinsX86.def include/clang/Driver/Options.td lib/Basic/Targets/X86.cpp lib/Basic/Targets/

[PATCH] D41583: [x86][icelake][vaes]

2017-12-26 Thread coby via Phabricator via cfe-commits
coby updated this revision to Diff 128185. coby added a comment. turning aes off forbids enabling vaes Repository: rC Clang https://reviews.llvm.org/D41583 Files: include/clang/Basic/BuiltinsX86.def include/clang/Driver/Options.td lib/Basic/Targets/X86.cpp lib/Basic/Targets/X86.h l

[PATCH] D41582: [x86][icelake][gfni]

2017-12-27 Thread coby via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rC321477: [x86][icelake][gfni] (authored by coby, committed by ). Changed prior to commit: https://reviews.llvm.org/D41582?vs=128168&id=128207#toc Repository: rC Clang https://reviews.llvm.org/D41582

[PATCH] D41583: [x86][icelake][vaes]

2017-12-27 Thread coby via Phabricator via cfe-commits
coby closed this revision. coby added a comment. closed by commit https://reviews.llvm.org/rC321474 (https://reviews.llvm.org/rL321474) Repository: rC Clang https://reviews.llvm.org/D41583 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D41573: [x86][icelake][vpclmulqdq]

2017-12-27 Thread coby via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL321480: [x86][icelake][vpclmulqdq] (authored by coby, committed by ). Changed prior to commit: https://reviews.llvm.org/D41573?vs=128183&id=128210#toc Repository: rL LLVM https://reviews.llvm.org/D4

[PATCH] D41564: [x86][icelake][bitalg]

2017-12-27 Thread coby via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL321483: [x86][icelake][bitalg] (authored by coby, committed by ). Changed prior to commit: https://reviews.llvm.org/D41564?vs=128109&id=128213#toc Repository: rL LLVM https://reviews.llvm.org/D41564

[PATCH] D41558: [x86][icelake][vnni]

2017-12-27 Thread coby via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL321484: [x86][icelake][vnni] (authored by coby, committed by ). Changed prior to commit: https://reviews.llvm.org/D41558?vs=128099&id=128216#toc Repository: rL LLVM https://reviews.llvm.org/D41558

[PATCH] D41557: [x86][icelake][vbmi2]

2017-12-27 Thread coby via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL321487: [x86][icelake][vbmi2] (authored by coby, committed by ). Changed prior to commit: https://reviews.llvm.org/D41557?vs=128172&id=128221#toc Repository: rL LLVM https://reviews.llvm.org/D41557

[PATCH] D41492: [Frontend] Correctly handle instantiating ctors with skipped bodies

2017-12-28 Thread Phabricator via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rC321520: [Frontend] Correctly handle instantiating ctors with skipped bodies (authored by ibiryukov, committed by ). Changed prior to commit: https://reviews.llvm.org/D41492?vs=127882&id=128290#toc Repo

[PATCH] D41492: [Frontend] Correctly handle instantiating ctors with skipped bodies

2017-12-28 Thread Phabricator via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL321520: [Frontend] Correctly handle instantiating ctors with skipped bodies (authored by ibiryukov, committed by ). Repository: rL LLVM https://reviews.llvm.org/D41492 Files: cfe/trunk/lib/Sema/Sema

[PATCH] D41495: [clangd] Skip function bodies when building the preamble

2017-12-28 Thread Phabricator via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL321521: [clangd] Skip function bodies when building the preamble (authored by ibiryukov, committed by ). Repository: rL LLVM https://reviews.llvm.org/D41495 Files: clang-tools-extra/trunk/clangd/Cla

[PATCH] D41500: ananas: Add shared library support

2017-12-29 Thread Rink via Phabricator via cfe-commits
zhmu added a comment. @ed I tried to keep things as much in line as the other ::linker::Construct() functions do. Do you wish to stray from that path? I actually prefer to keep it like this as it's quite readable already, but YMMV of course :-) Repository: rC Clang https://reviews.llvm.org

[PATCH] D41326: [clang-tidy] Added diagnostics about incorrect usage of NOLINT comment

2018-01-02 Thread Anton via Phabricator via cfe-commits
xgsa added inline comments. Comment at: clang-tidy/ClangTidyDiagnosticConsumer.cpp:839-840 +case NolintCommentType::Nolint: + Message = "there is no diagnostics on this line, " +"the NOLINT comment is redundant"; + break;

[PATCH] D41326: [clang-tidy] Added diagnostics about incorrect usage of NOLINT comment

2018-01-02 Thread Anton via Phabricator via cfe-commits
xgsa updated this revision to Diff 128431. xgsa added a comment. Rename the check `nolint-usage` => `readability-nolint-usage` for consistency. Update diagnostics message according to the review comments. Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D41326 Files: clang-tidy/

[PATCH] D41512: [Sema] -Wtautological-constant-compare is too good. Cripple it.

2018-01-03 Thread Phabricator via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL321691: [Sema] -Wtautological-constant-compare is too good. Cripple it. (authored by lebedevri, committed by ). Changed prior to commit: https://reviews.llvm.org/D41512?vs=128470&id=128494#toc Reposito

[PATCH] D37014: [clang-tidy] Add a checker to remove useless intermediate variables before return statements with comparisons

2018-01-03 Thread Andi via Phabricator via cfe-commits
Abpostelnicu added inline comments. Comment at: clang-tidy/readability/UnnecessaryIntermediateVarCheck.cpp:376 +// expression wouldn't really benefit readability. Therefore we abort. +if (NewReturnLength > MaximumLineLength) { + return; lebedev.ri wr

[PATCH] D41717: [CGBuiltin] Handle unsigned mul overflow properly (PR35750)

2018-01-03 Thread Phabricator via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL321771: [CGBuiltin] Handle unsigned mul overflow properly (PR35750) (authored by vedantk, committed by ). Changed prior to commit: https://reviews.llvm.org/D41717?vs=128567&id=128574#toc Repository:

[PATCH] D41743: Debug Info: Support DW_AT_calling_convention on composite types.

2018-01-04 Thread Phabricator via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL321844: Debug Info: Support DW_AT_calling_convention on composite types. (authored by adrian, committed by ). Herald added a reviewer: deadalnix. Changed prior to commit: https://reviews.llvm.org/D41743

[PATCH] D41039: Add support for attribute "trivial_abi"

2018-01-04 Thread Phabricator via Phabricator via cfe-commits
This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rC321845: Debug Info: Support DW_AT_calling_convention on composite types. (authored by adrian, committed by ). Changed pri

[PATCH] D41039: Add support for attribute "trivial_abi"

2018-01-04 Thread Phabricator via Phabricator via cfe-commits
This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rL321845: Debug Info: Support DW_AT_calling_convention on composite types. (authored by adrian, committed by ). Changed pri

[PATCH] D41538: [analyzer] Fix some checker's output plist not containing the checker name #2

2018-01-06 Thread Phabricator via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rC321933: [analyzer] Fix some check's output plist not containing the check name (authored by xazax, committed by ). Changed prior to commit: https://reviews.llvm.org/D41538?vs=128630&id=128845#toc Repos

[PATCH] D41326: [clang-tidy] Added diagnostics about incorrect usage of NOLINT comment

2018-01-06 Thread Anton via Phabricator via cfe-commits
xgsa added inline comments. Comment at: clang-tidy/ClangTidyDiagnosticConsumer.cpp:839-840 +case NolintCommentType::Nolint: + Message = "there is no diagnostics on this line, " +"the NOLINT comment is redundant"; + break;

[PATCH] D41326: [clang-tidy] Added diagnostics about incorrect usage of NOLINT comment

2018-01-07 Thread Anton via Phabricator via cfe-commits
xgsa updated this revision to Diff 128893. xgsa added a comment. Fixed showing the check in -list-checks. Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D41326 Files: clang-tidy/ClangTidy.cpp clang-tidy/ClangTidyDiagnosticConsumer.cpp clang-tidy/ClangTidyDiagnosticConsumer

[PATCH] D40478: Added control flow architecture protection Flag

2018-01-09 Thread Phabricator via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rC322063: Added Control Flow Protection Flag (authored by orenb, committed by ). Changed prior to commit: https://reviews.llvm.org/D40478?vs=128601&id=129041#toc Repository: rC Clang https://reviews.l

[PATCH] D41842: [libunwind][MIPS]: Rename Registers_mips_n64 to Registers_mips_newabi.

2018-01-09 Thread Phabricator via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL322093: [libunwind][MIPS]: Rename Registers_mips_n64 to Registers_mips_newabi. (authored by jhb, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.llvm.or

[PATCH] D41807: [cmake] Delete redundant install command for clang-refactor.

2018-01-09 Thread Phabricator via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rC322147: [cmake] Delete redundant install command for clang-refactor. (authored by dhinton, committed by ). Changed prior to commit: https://reviews.llvm.org/D41807?vs=128864&id=129192#toc Repository:

[PATCH] D41901: [clangd] Remove duplicates from code completion

2018-01-10 Thread Phabricator via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL322185: [clangd] Remove duplicates from code completion (authored by ibiryukov, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.llvm.org/D41901?vs=12924

[PATCH] D41907: [clangd] Pass Context to onDiagnosticsReady callback

2018-01-10 Thread Phabricator via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL322199: [clangd] Pass Context to onDiagnosticsReady callback (authored by ibiryukov, committed by ). Herald added a subscriber: llvm-commits. Repository: rL LLVM https://reviews.llvm.org/D41907 Files:

[PATCH] D41830: [libc++] Fix PR#35780 - make std::experimental::filesystem::remove and remove_all return false or 0 if the file doesn't exist

2018-01-11 Thread Phabricator via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL322293: Make std::experimental::filesystem::remove and remove_all return false or 0 if… (authored by vaartis, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit: https://re

[PATCH] D43779: [Tooling] [0/1] Refactor FrontendActionFactory::create() to return std::unique_ptr<>

2018-02-27 Thread Phabricator via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rC326201: [Tooling] [0/1] Refactor FrontendActionFactory::create() to return std… (authored by lebedevri, committed by ). Repository: rC Clang https://reviews.llvm.org/D43779 Files: docs/LibTooling.r

[PATCH] D43780: [Tooling] [1/1] Refactor FrontendActionFactory::create() to return std::unique_ptr<>

2018-02-27 Thread Phabricator via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL326202: [Tooling] [1/1] Refactor FrontendActionFactory::create() to return std… (authored by lebedevri, committed by ). Herald added subscribers: llvm-commits, ilya-biryukov. Changed prior to commit: h

[PATCH] D43779: [Tooling] [0/1] Refactor FrontendActionFactory::create() to return std::unique_ptr<>

2018-02-27 Thread Phabricator via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL326201: [Tooling] [0/1] Refactor FrontendActionFactory::create() to return std… (authored by lebedevri, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews

[PATCH] D43585: [libunwind] Permit additional compiler and linker flags to be passed to tests.

2018-02-27 Thread Phabricator via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL326223: [libunwind] Permit additional compiler and linker flags to be passed to tests. (authored by jhb, committed by ). Herald added a subscriber: llvm-commits. Repository: rL LLVM https://reviews.llv

[PATCH] D43497: [analyzer] Introduce correct lifetime extension behavior in simple cases.

2018-02-27 Thread Phabricator via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rC326236: [analyzer] Introduce correct lifetime extension behavior in simple cases. (authored by dergachev, committed by ). Repository: rC Clang https://reviews.llvm.org/D43497 Files: include/clang/St

[PATCH] D43533: [CFG] [analyzer] NFC: Refactor ConstructionContext into a finite set of cases.

2018-02-27 Thread Phabricator via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL326238: [CFG] NFC: Refactor ConstructionContext into a finite set of cases. (authored by dergachev, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.llvm

[PATCH] D43657: [analyzer] dump() dynamic type info and taint into state dumps.

2018-02-27 Thread Phabricator via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rC326239: [analyzer] Self-debug: Dump dynamic type info and taint with the program state. (authored by dergachev, committed by ). Repository: rC Clang https://reviews.llvm.org/D43657 Files: include/cl

[PATCH] D43657: [analyzer] dump() dynamic type info and taint into state dumps.

2018-02-27 Thread Phabricator via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL326239: [analyzer] Self-debug: Dump dynamic type info and taint with the program state. (authored by dergachev, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit: https://

[PATCH] D43689: [analyzer] Disable constructor inlining when lifetime extension through fields occurs.

2018-02-27 Thread Phabricator via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rC326240: [analyzer] Disable constructor inlining when lifetime extending through a field. (authored by dergachev, committed by ). Changed prior to commit: https://reviews.llvm.org/D43689?vs=135669&id=136

[PATCH] D43659: [analyzer] Don't crash when dynamic type of a concrete region is hard-set with placement new.

2018-02-27 Thread Phabricator via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL326245: [analyzer] Don't crash when dynamic type of a variable is set via placement new. (authored by dergachev, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit: https:/

[PATCH] D43666: [analyzer] When constructing a temporary without construction context, track it for destruction anyway.

2018-02-27 Thread Phabricator via Phabricator via cfe-commits
This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rL326246: [analyzer] Track temporaries without construction contexts for destruction. (authored by dergachev, committed by )

[PATCH] D43714: [analyzer] Don't do anything when trivial-copying an empty class object.

2018-02-27 Thread Phabricator via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL326247: [analyzer] Fix trivial copy for empty objects. (authored by dergachev, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.llvm.org/D43714?vs=135771

[PATCH] D43791: [analyzer] Suppress MallocChecker positives in destructors with atomics.

2018-02-27 Thread Phabricator via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL326249: [analyzer] MallocChecker: Suppress false positives in shared pointers. (authored by dergachev, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.l

[PATCH] D43791: [analyzer] Suppress MallocChecker positives in destructors with atomics.

2018-02-27 Thread Phabricator via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rC326249: [analyzer] MallocChecker: Suppress false positives in shared pointers. (authored by dergachev, committed by ). Repository: rL LLVM https://reviews.llvm.org/D43791 Files: lib/StaticAnalyzer/C

[PATCH] D39074: [libunwind][MIPS]: Add support for unwinding in N32 processes.

2018-02-27 Thread Phabricator via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rUNW326250: [libunwind][MIPS]: Add support for unwinding in N32 processes. (authored by jhb, committed by ). Changed prior to commit: https://reviews.llvm.org/D39074?vs=133660&id=136144#toc Repository:

[PATCH] D43798: [analyzer] UndefinedAssignment: Fix warning message on implicit copy/move constructors.

2018-02-27 Thread Phabricator via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL326258: [analyzer] UndefinedAssignmentChecker: Better warning message in implicit ctors. (authored by dergachev, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit: https:/

[PATCH] D30691: [analyzer] Support for naive cross translational unit analysis

2018-02-28 Thread Phabricator via Phabricator via cfe-commits
This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rC326323: [analyzer] Support for naive cross translation unit analysis (authored by xazax, committed by ). Changed prior to

[PATCH] D30691: [analyzer] Support for naive cross translational unit analysis

2018-02-28 Thread Phabricator via Phabricator via cfe-commits
This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rL326323: [analyzer] Support for naive cross translation unit analysis (authored by xazax, committed by ). Herald added a su

[PATCH] D43852: [OpenMP] Extend NVPTX SPMD implementation of combined constructs

2018-02-28 Thread Phabricator via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL326368: [OpenMP] Extend NVPTX SPMD implementation of combined constructs (authored by cbertol, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.llvm.org/

[PATCH] D43840: [CFG] [analyzer] Fix a crash on finding construction context for implicit constructor conversion.

2018-02-28 Thread Phabricator via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rC326402: [CFG] [analyzer] Recall that we only skip NoOp casts in construction contexts. (authored by dergachev, committed by ). Repository: rL LLVM https://reviews.llvm.org/D43840 Files: lib/Analysis

[PATCH] D43840: [CFG] [analyzer] Fix a crash on finding construction context for implicit constructor conversion.

2018-02-28 Thread Phabricator via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL326402: [CFG] [analyzer] Recall that we only skip NoOp casts in construction contexts. (authored by dergachev, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit: https://r

[PATCH] D42645: New simple Checker for mmap calls

2018-02-28 Thread Phabricator via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL326405: [analyzer] Add a checker for mmap()s which are both writable and executable. (authored by dergachev, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit: https://rev

[PATCH] D43804: [analyzer] Enable cfg-temporary-dtors by default?

2018-03-01 Thread Phabricator via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL326461: [analyzer] Enable cfg-temporary-dtors by default. (authored by dergachev, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.llvm.org/D43804?vs=136

[PATCH] D43969: Improve completion experience for headers

2018-03-01 Thread Philipp via Phabricator via cfe-commits
phst created this revision. phst added a reviewer: klimek. Herald added a subscriber: cfe-commits. When calling `completing-read', we should provide a default to prevent the behavior described in https://github.com/DarwinAwardWinner/ido-completing-read-plus#why-does-ret-sometimes-not-select-the-

[PATCH] D43969: Improve completion experience for headers

2018-03-01 Thread Philipp via Phabricator via cfe-commits
phst updated this revision to Diff 136597. phst added a comment. Revert bogus additions Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D43969 Files: include-fixer/tool/clang-include-fixer.el Index: include-fixer/tool/clang-include-fixer.el ===

[PATCH] D43969: Improve completion experience for headers

2018-03-01 Thread Philipp via Phabricator via cfe-commits
phst updated this revision to Diff 136598. phst added a comment. Fix condition Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D43969 Files: include-fixer/tool/clang-include-fixer.el Index: include-fixer/tool/clang-include-fixer.el

[PATCH] D44000: [clang] Fix use-after-free on code completion

2018-03-02 Thread Phabricator via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL326569: [clang] Fix use-after-free on code completion (authored by ibiryukov, committed by ). Herald added a subscriber: llvm-commits. Repository: rL LLVM https://reviews.llvm.org/D44000 Files: clan

[PATCH] D43847: [clang-tidy] Add check: replace string::find(...) == 0 with absl::StartsWith

2018-03-02 Thread ahedberg via Phabricator via cfe-commits
ahedberg added a comment. In https://reviews.llvm.org/D43847#1024018, @aaron.ballman wrote: > In https://reviews.llvm.org/D43847#1023452, @hokein wrote: > > > In https://reviews.llvm.org/D43847#1021967, @aaron.ballman wrote: > > > > > I need a bit more context because I'm unfamiliar with `absl`.

[PATCH] D43818: Better OpenBSD frontend support

2018-03-03 Thread Phabricator via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL326645: Better OpenBSD frontend support (authored by kamil, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.llvm.org/D43818?vs=136804&id=136903#toc Rep

[PATCH] D43961: OpenBSD Driver basic sanitiser support

2018-03-03 Thread Phabricator via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rC326648: OpenBSD Driver basic sanitiser support (authored by kamil, committed by ). Repository: rC Clang https://reviews.llvm.org/D43961 Files: lib/Driver/ToolChains/OpenBSD.cpp lib/Driver/ToolChai

[PATCH] D39159: [analyzer] Improves the logic of GenericTaintChecker identifying stdin.

2018-03-05 Thread Phabricator via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rC326709: [analyzer] Improves the logic of GenericTaintChecker identifying stdin. (authored by henrywong, committed by ). Repository: rC Clang https://reviews.llvm.org/D39159 Files: lib/StaticAnalyzer

[PATCH] D41102: Setup clang-doc frontend framework

2018-03-06 Thread Athos via Phabricator via cfe-commits
Athosvk added a comment. My apologies for getting back on this so late! In https://reviews.llvm.org/D41102#1017683, @juliehockett wrote: > So, as an idea (as this diff implements), I updated the string references to > be a struct, which holds the USR of the referenced type (for serialization,

[PATCH] D43741: [Analyzer] More accurate modeling about the increment operator of the operand with type bool.

2018-03-06 Thread Phabricator via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL326776: [Analyzer] More accurate modeling about the increment operator of the operand… (authored by henrywong, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit: https://r

[PATCH] D43741: [Analyzer] More accurate modeling about the increment operator of the operand with type bool.

2018-03-06 Thread Phabricator via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rC326776: [Analyzer] More accurate modeling about the increment operator of the operand… (authored by henrywong, committed by ). Repository: rC Clang https://reviews.llvm.org/D43741 Files: include/cla

[PATCH] D44075: [analyzer] CStringChecker.cpp: Remove the duplicated check about null dereference on dest-buffer or src-buffer.

2018-03-06 Thread Phabricator via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rC326782: [analyzer] CStringChecker.cpp: Remove the duplicated check about null… (authored by henrywong, committed by ). Changed prior to commit: https://reviews.llvm.org/D44075?vs=136936&id=137167#toc R

[PATCH] D41102: Setup clang-doc frontend framework

2018-03-07 Thread Athos via Phabricator via cfe-commits
Athosvk added a comment. In https://reviews.llvm.org/D41102#1028760, @juliehockett wrote: > If you take a look at the follow-on patch to this (D43341 > ), you'll see that that is where the pointer > is added in (since it is irrelevant to the mapper portion, as i

[PATCH] D43625: [OpenMP] Remove implicit data sharing code gen that aims to use device shared memory

2018-03-07 Thread Phabricator via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rC326948: [OpenMP] Remove implicit data sharing code gen that aims to use device shared… (authored by gbercea, committed by ). Changed prior to commit: https://reviews.llvm.org/D43625?vs=136570&id=137475#

[PATCH] D41976: Low-hanging fruit optimization in string::__move_assign().

2018-03-08 Thread Phabricator via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rCXX327064: Low-hanging fruit optimization in string::__move_assign(). (authored by vedantk, committed by ). Changed prior to commit: https://reviews.llvm.org/D41976?vs=130819&id=137647#toc Repository:

[PATCH] D44051: [CFG] [analyzer] Add construction context for implicit constructor conversions.

2018-03-08 Thread Phabricator via Phabricator via cfe-commits
This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rL327096: [CFG] [analyzer] Add construction context for implicit constructor conversions. (authored by dergachev, committed

[PATCH] D44250: MmapWriteExecChecker supporting mprotect call

2018-03-08 Thread Phabricator via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL327098: [analyzer] MmapWriteExecChecker: Add support for mprotect(). (authored by dergachev, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.llvm.org/D4

[PATCH] D44300: [SemaOverload] Fixed crash on code completion

2018-03-09 Thread Phabricator via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL327134: [SemaOverload] Fixed crash on code completion (authored by ibiryukov, committed by ). Herald added a subscriber: llvm-commits. Repository: rL LLVM https://reviews.llvm.org/D44300 Files: cfe/

[PATCH] D16403: Add scope information to CFG

2018-03-12 Thread Phabricator via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rC327258: [analyzer] Add scope information to CFG (authored by chefmax, committed by ). Repository: rC Clang https://reviews.llvm.org/D16403 Files: include/clang/Analysis/AnalysisDeclContext.h inclu

[PATCH] D44142: [clangd] Revamp handling of diagnostics.

2018-03-12 Thread Phabricator via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rCTE327282: [clangd] Revamp handling of diagnostics. (authored by ibiryukov, committed by ). Changed prior to commit: https://reviews.llvm.org/D44142?vs=138004&id=138018#toc Repository: rCTE Clang Tool

[PATCH] D44069: Test Driver sanitise, unsupported on OpenBSD

2018-03-12 Thread Phabricator via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL327317: Check that ubsan is the only supported sanitizer on OpenBSD (authored by vedantk, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.llvm.org/D4406

<    6   7   8   9   10   11   12   13   14   15   >