[PATCH] D150670: [WebAssembly] Disable generation of fshl/fshr for rotates

pmatos updated this revision to Diff 523149. pmatos added a comment. Generate rotates for 64bits as well. Add tests. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150670/new/ https://reviews.llvm.org/D150670 Files: clang/lib/CodeGen/CGBuiltin.cp

[PATCH] D150670: [WebAssembly] Disable generation of fshl/fshr for rotates

pmatos added a comment. Ready for review. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150670/new/ https://reviews.llvm.org/D150670 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.

[PATCH] D150670: [WebAssembly] Disable generation of fshl/fshr for rotates

pmatos added a comment. In D150670#4351147 , @nikic wrote: > This doesn't looks like a wasm specific problem. You get essentially the same > issue on any target that has a rotate instruction but no funnel shift > instruction. Here are just a couple exam

[PATCH] D150670: [WebAssembly] Disable generation of fshl/fshr for rotates

pmatos added a comment. In D150670#4351147 , @nikic wrote: > Lowering to a rotate intrinsic only "solves" this for wasm and will at the > same time make these rotates completely opaque to optimization -- heck, it > looks like we don't even support const

[PATCH] D150670: [WebAssembly] Disable generation of fshl/fshr for rotates

pmatos added a comment. @nikic Thank you for the thorough suggestions above. I will have to look at this closer next week and will work on an alternative solution. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150670/new/ https://reviews.llvm.org/

[PATCH] D139010: [clang][WebAssembly] Implement support for table types and builtins

pmatos updated this revision to Diff 523741. pmatos added a comment. Remove modifications from Type.h and move them to WebAssembly files. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139010/new/ https://reviews.llvm.org/D139010 Files: clang/doc

[PATCH] D139010: [clang][WebAssembly] Implement support for table types and builtins

pmatos added a comment. In D139010#4350869 , @tlively wrote: > It looks like the LLVM-side changes are generally moving Wasm type > classification functions to a more global location. Since no other backend > should care about these things, it would be

[PATCH] D139010: [clang][WebAssembly] Implement support for table types and builtins

pmatos marked an inline comment as done. pmatos added inline comments. Comment at: clang/test/Sema/builtins-wasm.c:12-13 + __builtin_wasm_table_size(table, table);// expected-error {{too many arguments to function call, expected 1, have 2}} + void *a = __builtin_wa

[PATCH] D139010: [clang][WebAssembly] Implement support for table types and builtins

pmatos updated this revision to Diff 517166. pmatos marked 3 inline comments as done. pmatos added a comment. Fix Wasm table tests. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139010/new/ https://reviews.llvm.org/D139010 Files: clang/docs/Lang

[PATCH] D139010: [clang][WebAssembly] Implement support for table types and builtins

pmatos added a comment. Thanks for the comments - I am working on addressing these at the moment. The LLVM part of the patch is just some refactoring and therefore should be pretty trivial, pinging @tlively in case he has some time. Comment at: clang/test/Sema/wasm-refs-and-ta

[PATCH] D139010: [clang][WebAssembly] Implement support for table types and builtins

pmatos updated this revision to Diff 517478. pmatos marked 6 inline comments as done. pmatos added a comment. Complete fixing tests. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139010/new/ https://reviews.llvm.org/D139010 Files: clang/docs/Lan

[PATCH] D139010: [clang][WebAssembly] Implement support for table types and builtins

pmatos marked 2 inline comments as done. pmatos added inline comments. Comment at: clang/include/clang/Basic/BuiltinsWebAssembly.def:205-210 +TARGET_BUILTIN(__builtin_wasm_table_set, "viii", "t", "reference-types") +TARGET_BUILTIN(__builtin_wasm_table_get, "iii", "t", "referenc

[PATCH] D139010: [clang][WebAssembly] Implement support for table types and builtins

pmatos updated this revision to Diff 517521. pmatos marked 2 inline comments as done. pmatos added a comment. Update a few more tests. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139010/new/ https://reviews.llvm.org/D139010 Files: clang/docs/L

[PATCH] D139010: [clang][WebAssembly] Implement support for table types and builtins

pmatos marked an inline comment as done. pmatos added inline comments. Comment at: clang/test/Sema/wasm-refs-and-tables.c:17 +static __externref_t t6[] = {0}; // expected-error {{only zero-length WebAssembly tables are currently supported}} +__externref_t t7[0]; // e

[PATCH] D139010: [clang][WebAssembly] Implement support for table types and builtins

pmatos updated this revision to Diff 517525. pmatos marked an inline comment as done. pmatos added a comment. Quick fixup of test. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139010/new/ https://reviews.llvm.org/D139010 Files: clang/docs/Langu

[PATCH] D139010: [clang][WebAssembly] Implement support for table types and builtins

pmatos added inline comments. Comment at: clang/test/SemaCXX/wasm-refs-and-tables.cpp:35 +task<__externref_t[]> g() { + co_return table; +} @aaron.ballman I tried and failed to create a good testcase for co_return. However creating coroutines seems to be an std

[PATCH] D139010: [clang][WebAssembly] Implement support for table types and builtins

pmatos updated this revision to Diff 517535. pmatos added a comment. Add documentation for table builtins. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139010/new/ https://reviews.llvm.org/D139010 Files: clang/docs/LanguageExtensions.rst clan

[PATCH] D139010: [clang][WebAssembly] Implement support for table types and builtins

pmatos marked an inline comment as done. pmatos added a comment. I think we are almost there. @aaron.ballman what do you think? Comment at: clang/test/Sema/wasm-refs-and-tables.c:81 + + funcref_t func = __builtin_wasm_ref_null_func(0); // expected-error {{too many arguments t

[PATCH] D152126: [WebAssembly] Add tests ensuring rotates persist

pmatos created this revision. pmatos added reviewers: dschuff, tlively. Herald added subscribers: asb, wingo, sunfish, jgravelle-google, sbc100. Herald added a project: All. pmatos requested review of this revision. Herald added subscribers: llvm-commits, cfe-commits, aheejin. Herald added projects

[PATCH] D152126: [WebAssembly] Add tests ensuring rotates persist

This revision was automatically updated to reflect the committed changes. Closed by commit rG9571a28ee4e8: [WebAssembly] Add tests ensuring rotates persist (authored by pmatos). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152126/new/ https://revie

[PATCH] D139010: [clang][WebAssembly] Implement support for table types and builtins

pmatos added a comment. In D139010#4400303 , @aaron.ballman wrote: > Spotted a typo in the docs, but otherwise LGTM (thanks for your patience > while I was out last week). Thanks for your time one this. Repository: rG LLVM Github Monorepo CHANGES

[PATCH] D139010: [clang][WebAssembly] Implement support for table types and builtins

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG55aeb23fe008: [clang][WebAssembly] Implement support for table types and builtins (authored by pmatos). Changed prior to commit: https://reviews.l

[PATCH] D122215: [WebAssembly] Initial support for reference type externref in clang

pmatos added a comment. In D122215#3991648 , @MoritzS wrote: > Thanks for the patch! I just tried it out and I think this enables many > interesting use cases for WebAssembly when using C/C++. > > Currently the lowering to wasm does not work when using e

[PATCH] D122215: [WebAssembly] Initial support for reference type externref in clang

pmatos added a comment. In D122215#3995105 , @pmatos wrote: > In D122215#3991648 , @MoritzS wrote: > >> Thanks for the patch! I just tried it out and I think this enables many >> interesting use cases for WebAsse

[PATCH] D122215: [WebAssembly] Initial support for reference type externref in clang

pmatos updated this revision to Diff 483203. pmatos added a comment. Force mem2reg on all optimization levels to avoid allocas. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122215/new/ https://reviews.llvm.org/D122215 Files: clang/include/clang

[PATCH] D122215: [WebAssembly] Initial support for reference type externref in clang

pmatos added a comment. In D122215#3991648 , @MoritzS wrote: > Thanks for the patch! I just tried it out and I think this enables many > interesting use cases for WebAssembly when using C/C++. > > Currently the lowering to wasm does not work when using e

[PATCH] D27800: Add overload of TransformToPotentiallyEvaluated for TypeSourceInfo

pmatos created this revision. pmatos added a reviewer: efriedma. pmatos added a subscriber: cfe-commits. Adds overload of ransformToPotentiallyEvaluated for TypeSourceInfo to properly deal with VLAs in nested calls of sizeof and typeof. Fixes #31042. https://reviews.llvm.org/D27800 Files: in

[PATCH] D26843: Make sizeof expression context partially evaluated

pmatos added a comment. Please refer to the new one: https://reviews.llvm.org/D27800 https://reviews.llvm.org/D26843 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D27800: Add overload of TransformToPotentiallyEvaluated for TypeSourceInfo

pmatos added a comment. @efriedma Here's the new patch, thanks for your help getting here. https://reviews.llvm.org/D27800 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D26843: Make sizeof expression context partially evaluated

pmatos accepted this revision. pmatos added a reviewer: pmatos. pmatos added a comment. This revision is now accepted and ready to land. Abandoning this revision. https://reviews.llvm.org/D26843 ___ cfe-commits mailing list cfe-commits@lists.llvm.or

[PATCH] D26843: Make sizeof expression context partially evaluated

pmatos closed this revision. pmatos added a comment. This is not supposed to be marked as accepted. https://reviews.llvm.org/D26843 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D27800: Add overload of TransformToPotentiallyEvaluated for TypeSourceInfo

pmatos added a comment. Apologies for the delay over the holiday season, I will look into this later on after office hours. https://reviews.llvm.org/D27800 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailma

[PATCH] D27800: Add overload of TransformToPotentiallyEvaluated for TypeSourceInfo

pmatos updated this revision to Diff 91980. pmatos marked an inline comment as done. https://reviews.llvm.org/D27800 Files: include/clang/Sema/Sema.h lib/Sema/SemaExpr.cpp test/SemaCXX/pr31042.cpp Index: test/SemaCXX/pr31042.cpp

[PATCH] D27800: Add overload of TransformToPotentiallyEvaluated for TypeSourceInfo

pmatos added a comment. Has this been fixed upstream already? https://reviews.llvm.org/D27800 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D27800: Add overload of TransformToPotentiallyEvaluated for TypeSourceInfo

pmatos added a comment. Ah no, my mistake. I had the patch applied when I ran the test. https://reviews.llvm.org/D27800 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D27800: Add overload of TransformToPotentiallyEvaluated for TypeSourceInfo

pmatos updated this revision to Diff 85328. pmatos added a comment. Here's an updated patch including the test. Hope this is now ok for submission. Please accept my apologies with regards to the delaying in submitting this. https://reviews.llvm.org/D27800 Files: include/clang/Sema/Sema.h l

[PATCH] D27800: Add overload of TransformToPotentiallyEvaluated for TypeSourceInfo

pmatos marked 3 inline comments as done. pmatos added a comment. Thanks for the comments. https://reviews.llvm.org/D27800 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D27800: Add overload of TransformToPotentiallyEvaluated for TypeSourceInfo

pmatos added inline comments. Comment at: lib/Sema/SemaExpr.cpp:4031 // C99 6.5.3.4p4: the type (an unsigned integer type) is size_t. + if (isUnevaluatedContext() && ExprKind == UETT_SizeOf && + TInfo->getType()->isVariablyModifiedType()) efriedma wrote:

[PATCH] D27800: Add overload of TransformToPotentiallyEvaluated for TypeSourceInfo

pmatos updated this revision to Diff 91684. pmatos added a comment. @efriedma I have uploaded a new patch taking your comments into consideration and rebased on most recent clang sources. https://reviews.llvm.org/D27800 Files: include/clang/Sema/Sema.h lib/Sema/SemaExpr.cpp Index: lib/Se

[PATCH] D27800: Add overload of TransformToPotentiallyEvaluated for TypeSourceInfo

pmatos updated this revision to Diff 91685. pmatos added a comment. Added missing testcase to previous patch. https://reviews.llvm.org/D27800 Files: include/clang/Sema/Sema.h lib/Sema/SemaExpr.cpp test/SemaCXX/pr31042.cpp Index: test/SemaCXX/pr31042.cpp =

[PATCH] D26843: Make sizeof expression context partially evaluated

pmatos added a subscriber: eli.friedman. pmatos added a comment. OK, with a lot of help from @eli.friedman I have now a fix. Shall I reuse this review by submitting a new diff or open a new one? https://reviews.llvm.org/D26843 ___ cfe-commits maili

[PATCH] D101608: [WebAssembly] Support for WebAssembly globals in LLVM IR

pmatos accepted this revision. pmatos added a comment. This revision is now accepted and ready to land. This looks good to me - I will rebase D95425 on this. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101608/new

[PATCH] D101608: [WebAssembly] Support for WebAssembly globals in LLVM IR

pmatos added a comment. A quick note - apparently phab felt that since I accepted the revision, it's now ready to land. Probably obvious but I accepted expecting @tlively comments to be addressed first. :) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.

[PATCH] D95425: Implementation of global.get/set for reftypes in LLVM IR

pmatos updated this revision to Diff 342708. pmatos added a comment. Herald added a project: clang. Herald added a subscriber: cfe-commits. Fix patch submitted to phab... Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95425/new/ https://reviews.llvm

[PATCH] D95425: Implementation of global.get/set for reftypes in LLVM IR

pmatos updated this revision to Diff 342712. pmatos added a comment. Fix patch set... again! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95425/new/ https://reviews.llvm.org/D95425 Files: clang/lib/Basic/Targets/WebAssembly.cpp llvm/include/l

[PATCH] D95425: Implementation of global.get/set for reftypes in LLVM IR

pmatos updated this revision to Diff 342718. pmatos added a comment. Fix broken merge of table ins reordering commit Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95425/new/ https://reviews.llvm.org/D95425 Files: clang/lib/Basic/Targets/WebAssem

[PATCH] D95425: Implementation of global.get/set for reftypes in LLVM IR

pmatos updated this revision to Diff 342729. pmatos added a comment. Removed extraneous changes to previous patches Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95425/new/ https://reviews.llvm.org/D95425 Files: clang/lib/Basic/Targets/WebAssemb

[PATCH] D95425: Implementation of global.get/set for reftypes in LLVM IR

pmatos marked 7 inline comments as done. pmatos added inline comments. Comment at: llvm/lib/CodeGen/MachineOperand.cpp:1174 + } else +OS << ", opaque "; if (getAlign() != getBaseAlign()) tlively wrote: > Is there a test that demonstrates this printing? Al

[PATCH] D95425: Implementation of global.get/set for reftypes in LLVM IR

pmatos updated this revision to Diff 343685. pmatos added a comment. - Simplifies some of code in the middle-end. - Removes setComdat and adds setWeak Small improvements to address comments in review. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D9

[PATCH] D95425: Implementation of global.get/set for reftypes in LLVM IR

pmatos updated this revision to Diff 343695. pmatos added a comment. Making the linter happy... Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95425/new/ https://reviews.llvm.org/D95425 Files: clang/lib/Basic/Targets/WebAssembly.cpp llvm/includ

[PATCH] D27800: Add overload of TransformToPotentiallyEvaluated for TypeSourceInfo

pmatos updated this revision to Diff 398935. pmatos added a comment. Herald added a subscriber: wingo. Herald added a project: clang. After a long hiatus on this bug, this is still failing on HEAD so lets get it fixed. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://r

[PATCH] D27800: Add overload of TransformToPotentiallyEvaluated for TypeSourceInfo

pmatos added a comment. Fixes https://github.com/llvm/llvm-project/issues/30390 Comment at: test/SemaCXX/pr31042.cpp:1 +// RUN: %clang_cc1 -triple x86_64-unknown-linux-gnu -fsyntax-only -disable-free %s + efriedma wrote: > Oh, this testcase doesn't actually cr

[PATCH] D27800: Add overload of TransformToPotentiallyEvaluated for TypeSourceInfo

pmatos added a comment. Fixes https://github.com/llvm/llvm-project/issues/30390 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D27800/new/ https://reviews.llvm.org/D27800 ___ cfe-commits mailing list cfe-c

[PATCH] D27800: Add overload of TransformToPotentiallyEvaluated for TypeSourceInfo

pmatos added a comment. @efriedma I know it has been a long time, but are you still able to review this? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D27800/new/ https://reviews.llvm.org/D27800 ___ cfe-c

[PATCH] D27800: Add overload of TransformToPotentiallyEvaluated for TypeSourceInfo

pmatos added a comment. In D27800#3235066 , @efriedma wrote: > Looks like all the review comments have been addressed. LGTM Thanks for the review, but unfortunately I found an issue right before committing, taking a look at it now. Repository: rG LL

[PATCH] D27800: [clang] Fix crash for sizeof on VLAs

pmatos updated this revision to Diff 399320. pmatos retitled this revision from "Add overload of TransformToPotentiallyEvaluated for TypeSourceInfo" to "[clang] Fix crash for sizeof on VLAs". pmatos edited the summary of this revision. pmatos added a comment. Ensure that we only call transform o

[PATCH] D27800: [clang] Fix crash for sizeof on VLAs

pmatos added a comment. In D27800#3235066 , @efriedma wrote: > Looks like all the review comments have been addressed. LGTM Minor change. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D27800/new/ https://r

[PATCH] D27800: [clang] Fix crash for sizeof on VLAs

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG968be05b8fdc: [clang] Fix crash for sizeof on VLAs (authored by pmatos). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://

[PATCH] D111154: [WebAssembly] Implementation of table.get/set for reftypes in LLVM IR

pmatos updated this revision to Diff 379917. pmatos added a comment. Herald added subscribers: cfe-commits, ormris, jdoerfert, steven_wu. Herald added a project: clang. Simplified a lot of code that required some further fixes and de-duplication. Most importantly, I added many more testcases to e

[PATCH] D111154: [WebAssembly] Implementation of table.get/set for reftypes in LLVM IR

pmatos marked 4 inline comments as done. pmatos added inline comments. Comment at: llvm/test/CodeGen/WebAssembly/externref-tableget.ll:8 + +define %externref @get_externref_from_table(i32 %i) { + %p = getelementptr [0 x %externref], [0 x %externref] addrspace (1)* @externref_ta

[PATCH] D111154: [WebAssembly] Implementation of table.get/set for reftypes in LLVM IR

pmatos updated this revision to Diff 380337. pmatos added a comment. Use reference to pointer instead of pointer to pointer as @tlively suggested. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D54/new/ https://reviews.llvm.org/D54 Files:

[PATCH] D111154: [WebAssembly] Implementation of table.get/set for reftypes in LLVM IR

This revision was automatically updated to reflect the committed changes. Closed by commit rG6d0c7bc17de8: [WebAssembly] Implementation of table.get/set for reftypes in LLVM IR (authored by pmatos). Changed prior to commit: https://reviews.llvm.org/D54?vs=380337&id=380872#toc Repository:

[PATCH] D111154: [WebAssembly] Implementation of table.get/set for reftypes in LLVM IR

pmatos added a comment. In D54#3074221 , @tlively wrote: > Nice! Just a couple nits but I think this is good to go. Perfect, thanks for the comments. Fixed nits and landed. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://

<    1   2   3