[PATCH] D147834: [clang][driver] Pass `-femulated-tls` through to the linker in LTO mode

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGa78816a6b6de: [clang][driver] Pass `-femulated-tls` through to the linker in LTO mode (authored by paulkirth). Repository: rG LLVM Github Monorepo

[PATCH] D146463: [CodeGen][RISCV] Change Shadow Call Stack Register to X3

paulkirth added a comment. @asb Are we happy with the state of consensus w.r.t. using `x3`? I think the lingering concerns from the psABI discussion have been resolved. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146463/new/ https://reviews.llv

[PATCH] D146463: [CodeGen][RISCV] Change Shadow Call Stack Register to X3

paulkirth added inline comments. Comment at: clang/lib/Driver/SanitizerArgs.cpp:307 +bool shadowCallStackDSLConflicts(const llvm::opt::ArgList &Args, + const llvm::Triple &TT) { mcgrathr wrote: > I'm guessing that "DSL" stands fo

[PATCH] D146463: [CodeGen][RISCV] Change Shadow Call Stack Register to X3

paulkirth updated this revision to Diff 512276. paulkirth marked 7 inline comments as done. paulkirth added a comment. Remove `-msmall-data-limit` related changes. There was a misunderstanding on my part about default linker behavior. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST AC

[PATCH] D146463: [CodeGen][RISCV] Change Shadow Call Stack Register to X3

paulkirth added inline comments. Comment at: clang/lib/Driver/SanitizerArgs.cpp:573 + Kinds & SanitizerKind::ShadowCallStack) + << "-msmall-data-limit=0"; +} jrtc27 wrote: > jrtc27 wrote: > > paulkirth wrote: > > > jrt

[PATCH] D146463: [CodeGen][RISCV] Change Shadow Call Stack Register to X3

paulkirth updated this revision to Diff 512277. paulkirth added a comment. Remove dead declaration. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146463/new/ https://reviews.llvm.org/D146463 Files: clang/docs/ShadowCallStack.rst clang/lib/Driv

[PATCH] D146463: [CodeGen][RISCV] Change Shadow Call Stack Register to X3

paulkirth updated this revision to Diff 512489. paulkirth marked 2 inline comments as done. paulkirth added a comment. Add spaces to parantheticals. Shorten link to discussion on psABI. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146463/new/ http

[PATCH] D148031: [clang][driver][NFC] Add hasShadowCallStack to SanitizerArgs

paulkirth created this revision. paulkirth added reviewers: phosek, abrachet, dvyukov, vitalybuka, aaron.ballman. Herald added a project: All. paulkirth requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Currently, we can't check if ShadowCall

[PATCH] D148034: [clang][driver] Disable GP relaxation with RISC-V ShadowCallStack

paulkirth created this revision. paulkirth added reviewers: phosek, mcgrathr, jrtc27, craig.topper, aaron.ballman. Herald added subscribers: VincentWu, vkmr, luismarques, sameer.abuasal, s.egerton, Jim, PkmX, rogfer01, shiva0217, kito-cheng, simoncook, asb, arichardson. Herald added a project: A

[PATCH] D148031: [clang][driver][NFC] Add hasShadowCallStack to SanitizerArgs

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG723f7d3a0891: [clang][driver][NFC] Add hasShadowCallStack to SanitizerArgs (authored by paulkirth). Repository: rG LLVM Github Monorepo CHANGES S

[PATCH] D146463: [CodeGen][RISCV] Change Shadow Call Stack Register to X3

This revision was automatically updated to reflect the committed changes. Closed by commit rGaa1d2693c256: [CodeGen][RISCV] Change Shadow Call Stack Register to X3 (authored by paulkirth). Changed prior to commit: https://reviews.llvm.org/D146463?vs=512489&id=512972#toc Repository: rG LLVM G

[PATCH] D146777: [clang] Preliminary fat-lto-object support

paulkirth updated this revision to Diff 513766. paulkirth added a comment. Rebase. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146777/new/ https://reviews.llvm.org/D146777 Files: clang/include/clang/Basic/CodeGenOptions.def clang/include/cla

[PATCH] D146777: [clang] Preliminary fat-lto-object support

paulkirth updated this revision to Diff 525902. paulkirth added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146777/new/ https://reviews.llvm.org/D146777 Files: clang/docs/ReleaseNotes.rst clang/include/clang/Basic/CodeGenOp

[PATCH] D146777: [clang] Preliminary fat-lto-object support

paulkirth updated this revision to Diff 527075. paulkirth added a comment. Rebase. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146777/new/ https://reviews.llvm.org/D146777 Files: clang/docs/ReleaseNotes.rst clang/include/clang/Basic/CodeGenO

[PATCH] D143692: [clang][driver] Emit error when enabling emulated tls on unsupported architectures

paulkirth created this revision. paulkirth added reviewers: arichardson, hiraditya, jrtc27, phosek. Herald added subscribers: luismarques, s.egerton, PkmX, simoncook. Herald added a project: All. paulkirth requested review of this revision. Herald added subscribers: cfe-commits, pcwang-thead, MaskR

[PATCH] D143692: [clang][driver] Emit error when enabling emulated tls on unsupported architectures

paulkirth updated this revision to Diff 496290. paulkirth added a comment. Address comments. - use render and remove redundant/incorrect call to `AddLastArg`. - add test to make sure we don't issue an error when emulated TLS is disabled on unsupported platforms Repository: rG LLVM Github Mon

[PATCH] D143692: [clang][driver] Emit error when enabling emulated tls on unsupported architectures

paulkirth updated this revision to Diff 496529. paulkirth added a comment. Rebase on parent revision Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143692/new/ https://reviews.llvm.org/D143692 Files: clang/lib/Driver/ToolChains/Clang.cpp clang/

[PATCH] D143692: [clang][driver] Emit error when enabling emulated tls on unsupported architectures

paulkirth updated this revision to Diff 496553. paulkirth added a comment. Address comments. - improve FileCheck directive in test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143692/new/ https://reviews.llvm.org/D143692 Files: clang/lib/Drive

[PATCH] D143692: [clang][driver] Emit error when enabling emulated tls on unsupported architectures

paulkirth abandoned this revision. paulkirth added a comment. Based on discussion at the LLVM RISC-V community call, we're going to support emulated TLS in RISC-V, so we can abandon this patch. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143692/n

[PATCH] D131618: [WIP][Do NOT review] LLD related changes for -ffat-lto-objects support

paulkirth commandeered this revision. paulkirth edited reviewers, added: arda; removed: paulkirth. paulkirth added a comment. I'll be updating this patch soon with a rebased version. Likely that will need to be split up into a series of smaller patches. There is also some design work that needs

[PATCH] D131618: [clang][llvm][lld] FatLTO Prototype

paulkirth updated this revision to Diff 499913. paulkirth retitled this revision from "[WIP][Do NOT review] LLD related changes for -ffat-lto-objects support" to "[clang][llvm][lld] FatLTO Prototype". paulkirth edited the summary of this revision. paulkirth added a comment. Rebase revision. Aband

[PATCH] D131618: [clang][llvm][lld] FatLTO Prototype

paulkirth added inline comments. Comment at: lld/test/ELF/fatlto/Inputs/a-fatLTO.yaml:23 +AddressAlign:0x1 +Content: 4243C0DE35140500620C30244D59BE669DFBB44F1BC8244401320500210C7B020B022100020016000781239141C80449061032399201840C250508

[PATCH] D131618: [clang][llvm][lld] FatLTO Prototype

paulkirth added a comment. Seems like the `EmbedBitcodePass` comes straight from D130777 . It may make more sense to drop that part of the patch here, and rebase on top of it. On the downside, from what I can see this patch and D130777

[PATCH] D146777: [clang] Preliminary fat-lto-object support

paulkirth updated this revision to Diff 514331. paulkirth added a comment. Rebase. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146777/new/ https://reviews.llvm.org/D146777 Files: clang/include/clang/Basic/CodeGenOptions.def clang/include/cla

[PATCH] D146777: [clang] Preliminary fat-lto-object support

paulkirth updated this revision to Diff 514430. paulkirth added a comment. Rebase. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146777/new/ https://reviews.llvm.org/D146777 Files: clang/include/clang/Basic/CodeGenOptions.def clang/include/cla

[PATCH] D146777: [clang] Preliminary fat-lto-object support

paulkirth updated this revision to Diff 514432. paulkirth added a comment. Rebase. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146777/new/ https://reviews.llvm.org/D146777 Files: clang/include/clang/Basic/CodeGenOptions.def clang/include/cla

[PATCH] D146987: [Assignment Tracking] Enable by default

paulkirth added a comment. I think we may have an issue due to this. I'm basing that on the blamelist, but I'm still bisecting our build, which may take some time to confirm. Can you take a look, and revert if it's not a quick fix? FAILED: obj/third_party/mesa/src/compiler/nir/nir.nir_opt_uni

[PATCH] D146987: [Assignment Tracking] Enable by default

paulkirth added a comment. Here are the reproducers, though I haven't reduced them yet. F27193433: clang-crashreports.zip Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146987/new/ https://reviews.llvm.org/D1469

[PATCH] D140722: [OpenMP] Prefix outlined and reduction func names with original func's name

paulkirth added a comment. I'm seeing some test failures in our CI: Clang :: OpenMP/parallel_masked.cpp Clang :: OpenMP/parallel_masked_target.cpp Bot: https://ci.chromium.org/ui/p/fuchsia/builders/toolchain.ci/clang-linux-x64-rbe/b8783369579855138017/overview If this will be hard to fix, can

[PATCH] D140722: [OpenMP] Prefix outlined and reduction func names with original func's name

paulkirth added a comment. Sorry, I missed that this was already reverted. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140722/new/ https://reviews.llvm.org/D140722 ___ cfe-commits mailing list cfe-comm

[PATCH] D146987: [Assignment Tracking] Enable by default

paulkirth added a comment. Here are reduced cases. I didn't bother bisecting flags, but the test case is quite small F27199288: clang-crashreports.zip struct a {}; struct b { struct b *c; struct b *d; }; _Bool e; inline void g(struct b *p1)

[PATCH] D146777: [clang] Preliminary fat-lto-object support

paulkirth updated this revision to Diff 515880. paulkirth added a comment. Add relese note. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146777/new/ https://reviews.llvm.org/D146777 Files: clang/docs/ReleaseNotes.rst clang/include/clang/Basic

[PATCH] D146777: [clang] Preliminary fat-lto-object support

paulkirth updated this revision to Diff 515910. paulkirth added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146777/new/ https://reviews.llvm.org/D146777 Files: clang/docs/ReleaseNotes.rst clang/include/clang/Basic/CodeGenOp

[PATCH] D131618: [clang][llvm][lld] FatLTO Prototype

paulkirth abandoned this revision. paulkirth added a comment. This can be abandoned in favor of https://reviews.llvm.org/D146776, https://reviews.llvm.org/D146777, and https://reviews.llvm.org/D146778 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D1

[PATCH] D115907: [misexpect] Re-implement MisExpect Diagnostics

paulkirth added a comment. Thanks for the report Hans. In D115907#4295363 , @hans wrote: > We gave this a try in Chromium: > https://bugs.chromium.org/p/chromium/issues/detail?id=1434989 > > While the diagnostics are interesting, two things make this le

[PATCH] D115907: [misexpect] Re-implement MisExpect Diagnostics

paulkirth added a comment. In D115907#4296154 , @hans wrote: > In D115907#4295923 , @paulkirth > wrote: > >>> 2. Due to inlining etc., it often gets the source locations wrong, which >>> means it points at code

[PATCH] D149206: [clang][driver] Enable MisExpect diagnostics flag outside of CC!

paulkirth created this revision. paulkirth added reviewers: hans, tejohnson, phosek. Herald added a project: All. paulkirth requested review of this revision. Herald added subscribers: cfe-commits, MaskRay. Herald added a project: clang. Previously we only accepted the `-fdiagnostics-misexpect-tol

[PATCH] D146987: [Assignment Tracking] Enable by default

paulkirth added a comment. @jmorse Sorry it took me a bit to set up, but I ran an experiment in our CI that reverted the change that disabled this as default and tried it for x86. It looks like this patch is working OK for us now: https://ci.chromium.org/raw/build/logs.chromium.org/fuchsia/led/

[PATCH] D149206: [clang][driver] Enable MisExpect diagnostics flag outside of CC1

paulkirth added inline comments. Comment at: clang/test/Profile/misexpect-branch.c:10 // RUN: %clang_cc1 %s -O2 -o - -emit-llvm -fprofile-instrument-use-path=%t.profdata -verify=foo -fdiagnostics-misexpect-tolerance=10 -Wmisexpect -debug-info-kind=line-tables-only +// RUN: %c

[PATCH] D149206: [clang][driver] Enable MisExpect diagnostics flag outside of CC1

paulkirth updated this revision to Diff 517199. paulkirth added a comment. Migrate to a Driver test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D149206/new/ https://reviews.llvm.org/D149206 Files: clang/lib/Driver/ToolChains/Clang.cpp clang/t

[PATCH] D146987: [Assignment Tracking] Enable by default

paulkirth added a comment. In D146987#4299353 , @Orlando wrote: > In D146987#4299081 , @paulkirth > wrote: > >> @jmorse Sorry it took me a bit to set up, but I ran an experiment in our CI >> that reverted the ch

[PATCH] D149206: [clang][driver] Enable MisExpect diagnostics flag outside of CC1

paulkirth updated this revision to Diff 517243. paulkirth marked an inline comment as done. paulkirth added a comment. Update test to check if the flag is in cc1, instead of just looking for a warning. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D

[PATCH] D149206: [clang][driver] Enable MisExpect diagnostics flag outside of CC1

paulkirth added inline comments. Comment at: clang/test/Driver/clang_f_opts.c:144 +// RUN: %clang -### -S -fprofile-instr-use=%t.profdata -fdiagnostics-misexpect-tolerance=10 -Wmisexpect %s 2>&1 | FileCheck %s --check-prefix=CHECK-MISEXPECT-TOLLERANCE +// CHECK-MISEXPECT-TOLLER

[PATCH] D146777: [clang] Preliminary fat-lto-object support

paulkirth updated this revision to Diff 517416. paulkirth added a comment. Rebase. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146777/new/ https://reviews.llvm.org/D146777 Files: clang/docs/ReleaseNotes.rst clang/include/clang/Basic/CodeGenO

[PATCH] D146777: [clang] Preliminary fat-lto-object support

paulkirth updated this revision to Diff 517706. paulkirth added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146777/new/ https://reviews.llvm.org/D146777 Files: clang/docs/ReleaseNotes.rst clang/include/clang/Basic/CodeGenOp

[PATCH] D149206: [clang][driver] Enable MisExpect diagnostics flag outside of CC1

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG61976af3ba93: [clang][driver] Enable MisExpect diagnostics flag outside of CC1 (authored by paulkirth). Repository: rG LLVM Github Monorepo CHANG

[PATCH] D151954: [clang-format] Fix overlapping whitespace replacements before PPDirective

paulkirth added a comment. This patch seems to introduce some significant regressions to formatting. I've filed https://github.com/llvm/llvm-project/issues/63170 with some candidate code. I'll try to reduce the case as I can, but I'm guessing something is incorrect w/ how the indentation level

[PATCH] D151954: [clang-format] Fix overlapping whitespace replacements before PPDirective

paulkirth added a comment. I'd also suggest reverting this until it can be fixed Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151954/new/ https://reviews.llvm.org/D151954 ___ cfe-commits mailing list cf

[PATCH] D152473: [clang-format] Add test case for issue 63170

paulkirth created this revision. paulkirth added a reviewer: owenpan. Herald added projects: All, clang, clang-format. Herald added a subscriber: cfe-commits. Herald added reviewers: rymiel, HazardyKnusperkeks, MyDeveloperDay. paulkirth requested review of this revision. Herald added a comment. NO

[PATCH] D152473: [clang-format] Add test case for issue 63170

paulkirth added a comment. In D152473#4407832 , @owenpan wrote: > Can you add the test to clang/unittests/Format/FormatTest.cpp instead? Please > also include the full diff. See > https://llvm.org/docs/Phabricator.html#requesting-a-review-via-the-web-in

[PATCH] D152473: [clang-format] Add test case for issue 63170

paulkirth added a comment. The point of this patch was to show a regression. I'm not trying to fix anything per se. I'd like https://reviews.llvm.org/D151954 and anything that depends on it reverted, since it breaks `clang-format`. My understanding was that @owenpan was reluctant to revert sin

[PATCH] D152473: [clang-format] Add test case for issue 63170

paulkirth updated this revision to Diff 52. paulkirth added a comment. Revert patches introducing regression & add unit test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152473/new/ https://reviews.llvm.org/D152473 Files: clang/docs/ClangFo

[PATCH] D152473: [clang-format] Add test case for issue 63170

paulkirth updated this revision to Diff 530004. paulkirth edited the summary of this revision. paulkirth added reverted changes: rGd2627cf88d25: [clang-format] Add the KeepEmptyLinesAtEOF option, rG4b9764959dc4: [clang-format] Fix overlapping replacements before PPDirectives, D152305: [clang-form

[PATCH] D152473: [clang-format] Add test case for issue 63170

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGb6a718016c0f: [clang-format] Add test case for issue 63170 (authored by paulkirth). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D152473: [clang-format] Add test case for issue 63170

paulkirth added a comment. In D152473#4409975 , @MyDeveloperDay wrote: > In D152473#4409146 , @paulkirth > wrote: > >> The point of this patch was to show a regression. I'm not trying to fix >> anything per se.

[PATCH] D152584: [clang-format] Remove redundant test case

paulkirth created this revision. paulkirth added reviewers: owenpan, MyDeveloperDay. Herald added projects: All, clang, clang-format. Herald added a subscriber: cfe-commits. Herald added reviewers: rymiel, HazardyKnusperkeks. paulkirth requested review of this revision. Herald added a comment. NOT

[PATCH] D152584: [clang-format] Remove redundant test case

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGa28a46665529: [clang-format] Remove redundant test case (authored by paulkirth). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D152473: [clang-format] Add test case for issue 63170

paulkirth marked an inline comment as done. paulkirth added a comment. In D152473#4410331 , @MyDeveloperDay wrote: > My additional concern is, is the original patch is the root cause of the > regression?, so I’m struggling to understand why this in part

[PATCH] D152804: [clang-format] Propose a new solution to - Fix overlapping replacements before PPDirectives

paulkirth accepted this revision. paulkirth added a comment. This revision is now accepted and ready to land. Thanks for looking into this. LGTM from me. I'll keep an eye on our CI when this lands and let you know if we encounter any problems. Repository: rG LLVM Github Monorepo CHANGES SINC

[PATCH] D146777: [clang] Preliminary fat-lto-object support

paulkirth updated this revision to Diff 531534. paulkirth added a comment. Rebase and pass fat-lto-objects to LLD from clang. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146777/new/ https://reviews.llvm.org/D146777 Files: clang/docs/ReleaseNot

[PATCH] D146777: [clang] Preliminary fat-lto-object support

paulkirth added inline comments. Comment at: clang/lib/CodeGen/BackendUtil.cpp:1065 + if (CodeGenOpts.FatLTO) { +// Set EnableSplitLTOUnit, since the config above won't +if (!TheModule->getModuleFlag("EnableSplitLTOUnit")) tejohnson wrote: > Can you expa

[PATCH] D146777: [clang] Preliminary fat-lto-object support

paulkirth updated this revision to Diff 532212. paulkirth marked an inline comment as done. paulkirth added a comment. Rebase, address comments, and add missing test cases. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146777/new/ https://reviews.l

[PATCH] D146777: [clang] Preliminary fat-lto-object support

paulkirth updated this revision to Diff 532272. paulkirth added a comment. Rebase and fix run line in test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146777/new/ https://reviews.llvm.org/D146777 Files: clang/docs/ReleaseNotes.rst clang/incl

[PATCH] D146777: [clang] Preliminary fat-lto-object support

paulkirth marked an inline comment as done. paulkirth added inline comments. Comment at: clang/test/Driver/fatlto.c:1 + tejohnson wrote: > Is this empty file meant to contain something? No, this was just a mistake in my commit. I had the linker checks in another

[PATCH] D139154: [clang-doc] Add template support

paulkirth added a comment. Can we also update the end-to-end tests with some relevant test cases? I think that's especially important, given that I'm not sure the unittests are running as part of the normal test suite. Overall this is mostly LGTM with some minor comments/questions. =

[PATCH] D139154: [clang-doc] Add template support

paulkirth accepted this revision. paulkirth added a comment. This revision is now accepted and ready to land. This is basically LGTM. There are a few comments I think could be phrased a bit more clearly, but otherwise are more or less fine. Comment at: clang-tools-extra/clang-

[PATCH] D139154: [clang-doc] Add template support

paulkirth added inline comments. Comment at: clang-tools-extra/clang-doc/Representation.h:205 + + // The literal contents of the code for that specifies this template parameter + // for this declaration. Typical values will be "class T" and

[PATCH] D119996: [safestack] Support safestack in stack size diagnostics

paulkirth created this revision. Herald added a subscriber: hiraditya. paulkirth updated this revision to Diff 409705. paulkirth added a comment. paulkirth updated this revision to Diff 409797. tstellar added a subscriber: serge-sans-paille. paulkirth edited the summary of this revision. paulkirth

[PATCH] D119996: [safestack] Support safestack in stack size diagnostics

paulkirth added inline comments. Comment at: llvm/lib/CodeGen/AsmPrinter/AsmPrinter.cpp:1211 const MachineFrameInfo &FrameInfo = MF.getFrameInfo(); - uint64_t StackSize = FrameInfo.getStackSize(); + uint64_t StackSize = + FrameInfo.getStackSize() + FrameInfo.getUnsafeSt

[PATCH] D119996: [safestack] Support safestack in stack size diagnostics

paulkirth updated this revision to Diff 413556. paulkirth added a comment. Update emitStackSection to emit the size of the combined stack Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119996/new/ https://reviews.llvm.org/D119996 Files: clang/tes

[PATCH] D119996: [safestack] Support safestack in stack size diagnostics

paulkirth added subscribers: seaneveson, MatzeB. paulkirth added a comment. @MatzeB @seaneveson Can either of you confirm that the logic we're inserting here is not in conflict with the stack size section? Based on D39788 and the original RFC, I would say accoun

[PATCH] D115907: [misexpect] Re-implement MisExpect Diagnostics

paulkirth added a comment. ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115907/new/ https://reviews.llvm.org/D115907 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/c

[PATCH] D115907: [misexpect] Re-implement MisExpect Diagnostics

paulkirth created this revision. Herald added subscribers: abrachet, ormris, dexonsmith, wenlei, phosek, hiraditya, mgorny. paulkirth updated this revision to Diff 394995. paulkirth added a comment. paulkirth updated this revision to Diff 394997. paulkirth added reviewers: phosek, mcgrathr, leonar

[PATCH] D115907: [misexpect] Re-implement MisExpect Diagnostics

paulkirth updated this revision to Diff 395502. paulkirth added a comment. - [misexpect] Add missing tests and modify diagnostic Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115907/new/ https://reviews.llvm.org/D115907 Files: clang/include/clan

[PATCH] D115907: [misexpect] Re-implement MisExpect Diagnostics

paulkirth updated this revision to Diff 395517. paulkirth added a comment. - [misexpect] Add missing tests and modify diagnostic Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115907/new/ https://reviews.llvm.org/D115907 Files: clang/include/clan

[PATCH] D115907: [misexpect] Re-implement MisExpect Diagnostics

paulkirth updated this revision to Diff 395727. paulkirth added a comment. - [misexpect] Add missing tests and modify diagnostic Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115907/new/ https://reviews.llvm.org/D115907 Files: clang/include/clan

<    1   2   3   4