Re: [clang] 028571d - [clang][Driver] Correct tool search path priority

2020-06-22 Thread Nico Weber via cfe-commits
Hi, https://reviews.llvm.org/D79988 is apparently a "Restricted Differential Revision" and I don't have permissions to do that. This being an open source project, this is not something we do. I'm guessing it's not intentional? This also breaks check-clang on macOS: http://45.33.8.238/mac/15950/st

[clang] 4d5c448 - Revert "[clang driver] Move default module cache from system temporary directory"

2020-06-26 Thread Nico Weber via cfe-commits
Author: Nico Weber Date: 2020-06-26T13:25:45-04:00 New Revision: 4d5c4489435dc1cb3d4989614e96b157c74afdea URL: https://github.com/llvm/llvm-project/commit/4d5c4489435dc1cb3d4989614e96b157c74afdea DIFF: https://github.com/llvm/llvm-project/commit/4d5c4489435dc1cb3d4989614e96b157c74afdea.diff LO

[clang-tools-extra] 8f73c44 - Revert "[clang-tidy] Reworked enum options handling(again)"

2020-06-29 Thread Nico Weber via cfe-commits
Author: Nico Weber Date: 2020-06-28T21:49:29-04:00 New Revision: 8f73c4432b5fa8510c99a5053c07dc70a610e1fb URL: https://github.com/llvm/llvm-project/commit/8f73c4432b5fa8510c99a5053c07dc70a610e1fb DIFF: https://github.com/llvm/llvm-project/commit/8f73c4432b5fa8510c99a5053c07dc70a610e1fb.diff LO

[clang] b9d50bd - Fix pr31836 on Windows too, and correctly handle repeated separators.

2020-05-01 Thread Nico Weber via cfe-commits
Author: Nico Weber Date: 2020-05-01T14:17:01-04:00 New Revision: b9d50bdff211eb806dce5bc42167a6b9c0cac6e6 URL: https://github.com/llvm/llvm-project/commit/b9d50bdff211eb806dce5bc42167a6b9c0cac6e6 DIFF: https://github.com/llvm/llvm-project/commit/b9d50bdff211eb806dce5bc42167a6b9c0cac6e6.diff LO

Re: [clang] 740a164 - PR46377: Fix dependence calculation for function types and typedef

2020-07-31 Thread Nico Weber via cfe-commits
Heads-up: This causes Chromium's build to fail with clang-cl: /usr/local/google/home/thakis/src/chrome/src/third_party/llvm/clang/lib/AST/ASTContext.cpp:4823: clang::QualType clang::ASTContext::getPackExpansionType(clang::QualType, llvm::Optional, bool): Assertion `(!ExpectPackInType || Pattern->c

Re: [clang] 740a164 - PR46377: Fix dependence calculation for function types and typedef

2020-07-31 Thread Nico Weber via cfe-commits
Sorry, the repro link should've pointed to https://bugs.chromium.org/p/chromium/issues/detail?id=1110981#c22 which has a nicer stack. On Fri, Jul 31, 2020 at 7:22 PM Nico Weber wrote: > Heads-up: This causes Chromium's build to fail with > > clang-cl: > /usr/local/google/home/thakis/src/chrome/s

Re: [clang] ed5a18f - PR30738: Implement two-phase name lookup for fold-expressions.

2020-08-06 Thread Nico Weber via cfe-commits
Hi, it looks like this broke check-clang-tools, see e.g. http://45.33.8.238/linux/24975/step_8.txt Nico On Thu, Aug 6, 2020 at 7:57 PM Richard Smith via cfe-commits < cfe-commits@lists.llvm.org> wrote: > > Author: Richard Smith > Date: 2020-08-06T16:56:39-07:00 > New Revision: ed5a18fc0399dce99

[clang] 82057e3 - clang: Fix minor grammar-o in diag added in c354b2e3b

2020-08-13 Thread Nico Weber via cfe-commits
Author: Nico Weber Date: 2020-08-13T10:06:40-04:00 New Revision: 82057e3f39e624dbaa5bbd7497c359f704347f6f URL: https://github.com/llvm/llvm-project/commit/82057e3f39e624dbaa5bbd7497c359f704347f6f DIFF: https://github.com/llvm/llvm-project/commit/82057e3f39e624dbaa5bbd7497c359f704347f6f.diff LO

[clang] 8fc7a90 - Let normalize() for posix style convert backslash to slash unconditionally.

2020-05-05 Thread Nico Weber via cfe-commits
Author: Nico Weber Date: 2020-05-05T13:54:55-04:00 New Revision: 8fc7a907b93a8e9eef96e872f8f926db3ebfe9b6 URL: https://github.com/llvm/llvm-project/commit/8fc7a907b93a8e9eef96e872f8f926db3ebfe9b6 DIFF: https://github.com/llvm/llvm-project/commit/8fc7a907b93a8e9eef96e872f8f926db3ebfe9b6.diff LO

[clang] e42fee7 - Add a test for "clang --version".

2020-05-07 Thread Nico Weber via cfe-commits
Author: Nico Weber Date: 2020-05-07T12:15:01-04:00 New Revision: e42fee75b8107177de5b27cb461172d326cf6141 URL: https://github.com/llvm/llvm-project/commit/e42fee75b8107177de5b27cb461172d326cf6141 DIFF: https://github.com/llvm/llvm-project/commit/e42fee75b8107177de5b27cb461172d326cf6141.diff LO

[clang] d038383 - Make -Wnonportable-include-path ignore drive case on Windows.

2020-05-07 Thread Nico Weber via cfe-commits
Author: Nico Weber Date: 2020-05-07T15:54:09-04:00 New Revision: d03838343f2199580a1942eb353901add38af909 URL: https://github.com/llvm/llvm-project/commit/d03838343f2199580a1942eb353901add38af909 DIFF: https://github.com/llvm/llvm-project/commit/d03838343f2199580a1942eb353901add38af909.diff LO

[clang] e9b4113 - Add a flag that controls if clang-tidy and clang-include-fixer are built into libclang.

2020-05-08 Thread Nico Weber via cfe-commits
Author: Nico Weber Date: 2020-05-08T11:41:45-04:00 New Revision: e9b4113902850667e4e96b0aabe158b87670d051 URL: https://github.com/llvm/llvm-project/commit/e9b4113902850667e4e96b0aabe158b87670d051 DIFF: https://github.com/llvm/llvm-project/commit/e9b4113902850667e4e96b0aabe158b87670d051.diff LO

[clang-tools-extra] e20fcf0 - Unbreak clang-tidy tests after D79599 / e9b4113902850.

2020-05-08 Thread Nico Weber via cfe-commits
Author: Nico Weber Date: 2020-05-08T12:37:33-04:00 New Revision: e20fcf0504e598c4f9f6ee77ca56d7431f9194c3 URL: https://github.com/llvm/llvm-project/commit/e20fcf0504e598c4f9f6ee77ca56d7431f9194c3 DIFF: https://github.com/llvm/llvm-project/commit/e20fcf0504e598c4f9f6ee77ca56d7431f9194c3.diff LO

[clang] 51d938b - Fix bugs when an included file name is typo corrected.

2020-05-08 Thread Nico Weber via cfe-commits
Author: Nico Weber Date: 2020-05-08T13:33:39-04:00 New Revision: 51d938bc94433b03cfbe60758642dbe70269ae3b URL: https://github.com/llvm/llvm-project/commit/51d938bc94433b03cfbe60758642dbe70269ae3b DIFF: https://github.com/llvm/llvm-project/commit/51d938bc94433b03cfbe60758642dbe70269ae3b.diff LO

[clang] bc98dc1 - Try to heal bots after https://reviews.llvm.org/D79655

2020-05-16 Thread Nico Weber via cfe-commits
Author: Nico Weber Date: 2020-05-16T20:32:58-04:00 New Revision: bc98dc12d8382b45ff9beed82236c9274f4435ff URL: https://github.com/llvm/llvm-project/commit/bc98dc12d8382b45ff9beed82236c9274f4435ff DIFF: https://github.com/llvm/llvm-project/commit/bc98dc12d8382b45ff9beed82236c9274f4435ff.diff LO

[clang] 3735505 - Fix a few doc typos to cycle bots.

2020-05-16 Thread Nico Weber via cfe-commits
Author: Nico Weber Date: 2020-05-16T20:38:28-04:00 New Revision: 3735505e4ffd0117de93d344fc0549151a205d11 URL: https://github.com/llvm/llvm-project/commit/3735505e4ffd0117de93d344fc0549151a205d11 DIFF: https://github.com/llvm/llvm-project/commit/3735505e4ffd0117de93d344fc0549151a205d11.diff LO

Re: [clang] 6d2b75e - [clang-misexpect] Fixed typo which causes that --pgo-warn-misexpect option is not passed in the compiler invocation

2020-05-19 Thread Nico Weber via cfe-commits
This breaks check-clang: http://45.33.8.238/linux/18098/step_7.txt Please take a look, and revert if it takes a while to fix. On Tue, May 19, 2020 at 5:12 PM Dávid Bolvanský via cfe-commits < cfe-commits@lists.llvm.org> wrote: > > Author: Dávid Bolvanský > Date: 2020-05-19T23:12:08+02:00 > New R

Re: [PATCH] D24775: Add -Wignored-pragma-intrinsic flag

2016-09-20 Thread Nico Weber via cfe-commits
Thanks! Some bikesheddy comments, ignore as you see fit: - I think it's good to keep Chromium's bug tracker out of LLVM as far as possible (most LLVM devs don't need to care about Chromium, and since Chromium's bug tracker refers to LLVM's bug tracker frequently since chromium depends on llvm, add

Re: [PATCH] D24775: Add -Wignored-pragma-intrinsic flag

2016-09-21 Thread Nico Weber via cfe-commits
On Tue, Sep 20, 2016 at 4:21 PM, Albert Gutowski wrote: > OK, thanks for the note about referring to Chromium, I fixed that. > As to -Wunknown-pragma, I feel that it would be inconsistent with other > pragmas unless I moved whole pragma to lexer instead of parser - I've just > discovered that I c

Re: [libcxx] r281673 - [libc++] Fix and document visibility attributes for Clang, GCC and Windows.

2016-10-07 Thread Nico Weber via cfe-commits
This caused https://llvm.org/bugs/show_bug.cgi?id=30642 On Thu, Sep 15, 2016 at 6:27 PM, Eric Fiselier via cfe-commits < cfe-commits@lists.llvm.org> wrote: > Author: ericwf > Date: Thu Sep 15 17:27:07 2016 > New Revision: 281673 > > URL: http://llvm.org/viewvc/llvm-project?rev=281673&view=rev > L

r283747 - Revert r283680.

2016-10-10 Thread Nico Weber via cfe-commits
Author: nico Date: Mon Oct 10 09:10:00 2016 New Revision: 283747 URL: http://llvm.org/viewvc/llvm-project?rev=283747&view=rev Log: Revert r283680. Breaks bootstrap builds on (at least) Windows: In file included from D:\buildslave\clang-x64-ninja-win7\llvm\lib\Support\Allocator.cpp:14: In file in

Re: r283680 - [CUDA] Support and std::min/max on the device.

2016-10-10 Thread Nico Weber via cfe-commits
This broke bootstrap builds, I reverted it for now in r283747. On Sat, Oct 8, 2016 at 6:16 PM, Justin Lebar via cfe-commits < cfe-commits@lists.llvm.org> wrote: > Author: jlebar > Date: Sat Oct 8 17:16:12 2016 > New Revision: 283680 > > URL: http://llvm.org/viewvc/llvm-project?rev=283680&view=re

r283753 - Revert r283683 because r283680 got reverted.

2016-10-10 Thread Nico Weber via cfe-commits
Author: nico Date: Mon Oct 10 09:20:35 2016 New Revision: 283753 URL: http://llvm.org/viewvc/llvm-project?rev=283753&view=rev Log: Revert r283683 because r283680 got reverted. Modified: cfe/trunk/lib/Headers/CMakeLists.txt Modified: cfe/trunk/lib/Headers/CMakeLists.txt URL: http://llvm.org/

[PATCH] D10840: clang-format: Add Block{Begin,End}Macros option

2016-10-10 Thread Nico Weber via cfe-commits
thakis added a comment. I noticed that using this slows down clang-format about 300% -- https://llvm.org/bugs/show_bug.cgi?id=30656 Repository: rL LLVM https://reviews.llvm.org/D10840 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http:

[PATCH] D25458: Don't create builtin declaration when looking for typo corrections in C++

2016-10-10 Thread Nico Weber via cfe-commits
thakis added a comment. rtrieu: Is there some global "are we in typo correction?" bit somewhere already? Comment at: lib/CodeGen/CGBuiltin.cpp:800 + case Builtin::BI_byteswap_ulong: + case Builtin::BI_byteswap_uint64: case Builtin::BI__builtin_bswap16: Is

Re: [libcxx] r284214 - XFAIL aligned allocation tests for older Clang versions

2016-10-14 Thread Nico Weber via cfe-commits
This is breaking tests for me: Unexpected Passing Tests (4): libc++ :: std/language.support/support.dynamic/new.delete/new.delete.array/new_align_val_t.pass.cpp libc++ :: std/language.support/support.dynamic/new.delete/new.delete.array/new_align_val_t_nothrow.pass.cpp libc++ :: std/lan

Re: [libcxx] r284214 - XFAIL aligned allocation tests for older Clang versions

2016-10-16 Thread Nico Weber via cfe-commits
See the Mac bot here: https://codereview.chromium.org/2416293003/ -> https://build.chromium.org/p/tryserver.chromium.mac/builders/mac_upload_clang/builds/105/steps/package%20clang/logs/stdio I think that bot uses Xcode 8's compiler. I haven't tried again since 2 days ago. On Sat, Oct 15, 2016 at 4

[clang] db6a534 - Revert "[test][clang] run test for lld emitting dwarf-aranages only if lld is presented"

2022-09-14 Thread Nico Weber via cfe-commits
Author: Nico Weber Date: 2022-09-14T12:17:41-04:00 New Revision: db6a53450facdfead8b0c8d20cfa361a785945fd URL: https://github.com/llvm/llvm-project/commit/db6a53450facdfead8b0c8d20cfa361a785945fd DIFF: https://github.com/llvm/llvm-project/commit/db6a53450facdfead8b0c8d20cfa361a785945fd.diff LO

[clang] 5631d20 - Revert "[clang] fix generation of .debug_aranges with LTO"

2022-09-14 Thread Nico Weber via cfe-commits
Author: Nico Weber Date: 2022-09-14T12:43:24-04:00 New Revision: 5631d20bfc9f77d15435badf6ce34e1a56c27e1c URL: https://github.com/llvm/llvm-project/commit/5631d20bfc9f77d15435badf6ce34e1a56c27e1c DIFF: https://github.com/llvm/llvm-project/commit/5631d20bfc9f77d15435badf6ce34e1a56c27e1c.diff LO

[clang] [ObjC] Fix offsets following `[[no_unique_address]]` for `@encode()` (PR #71321)

2023-11-06 Thread Nico Weber via cfe-commits
https://github.com/nico approved this pull request. lg2m https://github.com/llvm/llvm-project/pull/71321 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[llvm] [clang] [RISCV] Collapse fast unaligned access into a single feature [nfc-ish] (PR #73971)

2023-12-05 Thread Nico Weber via cfe-commits
nico wrote: ref https://github.com/rust-lang/rust/pull/118610 https://github.com/llvm/llvm-project/pull/73971 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [APINotes] Upstream APINotesManager (PR #72389)

2023-11-17 Thread Nico Weber via cfe-commits
nico wrote: I was wondering what this is. It looks like we have documentation that describes it at https://clang.llvm.org/docs/APINotes.html (in case anyone else is wondering too). https://github.com/llvm/llvm-project/pull/72389 ___ cfe-commits maili

[clang] Perf/lexer faster slow get char and size (PR #70543)

2023-10-29 Thread Nico Weber via cfe-commits
nico wrote: This breaks building: http://45.33.8.238/linux/121901/step_4.txt Please take a look and revert for now if it takes a while to fix. https://github.com/llvm/llvm-project/pull/70543 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http

[clang] 1c876ff - Revert "Perf/lexer faster slow get char and size (#70543)"

2023-10-29 Thread Nico Weber via cfe-commits
Author: Nico Weber Date: 2023-10-29T21:11:39-04:00 New Revision: 1c876ff5155c4feeb2b2885eb3e6abda17c4b7f4 URL: https://github.com/llvm/llvm-project/commit/1c876ff5155c4feeb2b2885eb3e6abda17c4b7f4 DIFF: https://github.com/llvm/llvm-project/commit/1c876ff5155c4feeb2b2885eb3e6abda17c4b7f4.diff LO

[clang] Perf/lexer faster slow get char and size (PR #70543)

2023-10-29 Thread Nico Weber via cfe-commits
nico wrote: Reverted in 1c876ff5155c4feeb2b2885eb3e6abda17c4b7f4 for now. https://github.com/llvm/llvm-project/pull/70543 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang] Separate bit-field padding diagnostics into -Wpadded-bitfield (PR #70978)

2023-11-02 Thread Nico Weber via cfe-commits
https://github.com/nico approved this pull request. lgtm https://github.com/llvm/llvm-project/pull/70978 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang] Separate bit-field padding diagnostics into -Wpadded-bitfield (PR #70978)

2023-11-02 Thread Nico Weber via cfe-commits
https://github.com/nico closed https://github.com/llvm/llvm-project/pull/70978 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [analyzer] Move alpha checker EnumCastOutOfRange to optin (PR #67157)

2023-12-12 Thread Nico Weber via cfe-commits
=?utf-8?q?Donát?= Nagy , =?utf-8?q?Donát?= Nagy Message-ID: In-Reply-To: nico wrote: This breaks check-clang everywhere, e.g.: https://lab.llvm.org/buildbot/#/builders/139/builds/55404 http://45.33.8.238/linux/125647/step_7.txt Please take a look and revert for now if it takes a while to fix

[clang] [analyzer] Fix broken testcase (PR #75216)

2023-12-12 Thread Nico Weber via cfe-commits
https://github.com/nico approved this pull request. https://github.com/llvm/llvm-project/pull/75216 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [analyzer] Fix broken testcase (PR #75216)

2023-12-12 Thread Nico Weber via cfe-commits
https://github.com/nico closed https://github.com/llvm/llvm-project/pull/75216 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [analyzer] Fix broken testcase (PR #75216)

2023-12-12 Thread Nico Weber via cfe-commits
nico wrote: This made bots happy again. Thanks for the quick fix! https://github.com/llvm/llvm-project/pull/75216 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [clangd] Add test for GH75115 (PR #75116)

2023-12-13 Thread Nico Weber via cfe-commits
nico wrote: The test is failing on our bots: https://logs.chromium.org/logs/chromium/buildbucket/cr-buildbucket/8761812675757485889/+/u/package_clang/stdout?format=raw ``` FAIL: Clangd :: GH75115.test (21263 of 79608) TEST 'Clangd :: GH75115.test' FAILED **

[clang-tools-extra] [clangd] Add test for GH75115 (PR #75116)

2023-12-13 Thread Nico Weber via cfe-commits
nico wrote: Aha, it assumes that the build is with assertions enabled, which isn't always true. (Do a release build, or a debug build with `-DLLVM_ENABLE_ASSERTIONS=NO`.) How about just reverting this and landing the test together with the fix? https://github.com/llvm/llvm-project/pull/75116 _

[clang-tools-extra] d860480 - Revert "[clangd] Add test for GH75115 (#75116)"

2023-12-13 Thread Nico Weber via cfe-commits
Author: Nico Weber Date: 2023-12-13T16:24:40-05:00 New Revision: d860480f9b20b308a677daf45f7bfe1da2a03ac7 URL: https://github.com/llvm/llvm-project/commit/d860480f9b20b308a677daf45f7bfe1da2a03ac7 DIFF: https://github.com/llvm/llvm-project/commit/d860480f9b20b308a677daf45f7bfe1da2a03ac7.diff LO

[clang-tools-extra] [clangd] Add test for GH75115 (PR #75116)

2023-12-13 Thread Nico Weber via cfe-commits
nico wrote: I've reverted this for now in d860480f9b20b308a677daf45f7bfe1da2a03ac7. https://github.com/llvm/llvm-project/pull/75116 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [AArch64][SME] Warn when using a streaming builtin from a non-streaming function (PR #74064)

2023-12-13 Thread Nico Weber via cfe-commits
nico wrote: On my system, this increases the compilation time of SemaChecking.cpp from 7 seconds to 2 minutes 46 seconds (using clang as a host compiler). That seems excessive. Let's please find a way to not make compilation so slow, and let's consider reverting this until a faster approach is

[clang-tools-extra] [clangd] Add test for GH75115 (PR #75116)

2023-12-14 Thread Nico Weber via cfe-commits
nico wrote: Seems like unnecessary complexity to me fwiw. So far, we've put tests for things that work in the test suite and put a record of things that assert in the bug tracker :) https://github.com/llvm/llvm-project/pull/75116 ___ cfe-commits mail

[llvm] [clang] [clang][MBD] set up module build daemon infrastructure (PR #67562)

2023-12-14 Thread Nico Weber via cfe-commits
nico wrote: This seems like something that shouldn't be in the compiler binary itself. There should be a separate binary for this type of thing. https://github.com/llvm/llvm-project/pull/67562 ___ cfe-commits mailing list cfe-commits@lists.llvm.org ht

[clang] [AArch64][SME] Warn when using a streaming builtin from a non-streaming function (PR #75487)

2023-12-14 Thread Nico Weber via cfe-commits
nico wrote: If it's not too much trouble, could you `git cherry-pick c60663d128f8e0dccd418bdf16ecc403b96aa74a` into this? (Cool if not, ofc.) https://github.com/llvm/llvm-project/pull/75487 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https

[llvm] [clang] [AMDGPU][GFX12] Add new v_permlane16 variants (PR #75475)

2023-12-18 Thread Nico Weber via cfe-commits
nico wrote: Looks like the new test might be failing on macOS/arm64: http://45.33.8.238/macm1/75171/step_11.txt Maybe it just needs something like 806761a7629df268c8aed49657aeccffa6bca449, but maybe the assert isn't benign. Do you want to switch the test to use `-mtriple`, or do you want to r

[llvm] [clang] [AMDGPU][GFX12] Add new v_permlane16 variants (PR #75475)

2023-12-18 Thread Nico Weber via cfe-commits
nico wrote: That did the trick, thanks! https://github.com/llvm/llvm-project/pull/75475 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang] Add `intrin0.h` header to mimic `intrin0.h` used by MSVC STL for clang-cl (PR #75711)

2023-12-18 Thread Nico Weber via cfe-commits
nico wrote: Is `intrin0.h` a header that ships with MSVC's compiler, or with MS's STL? If the latter, shouldn't everything just work already? https://github.com/llvm/llvm-project/pull/75711 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https

[clang] [clang] Add `intrin0.h` header to mimic `intrin0.h` used by MSVC STL for clang-cl (PR #75711)

2023-12-18 Thread Nico Weber via cfe-commits
nico wrote: Looks like it belongs to MSVC: https://github.com/microsoft/STL/blob/a806c6960f1687590ffd4244794c753aa819/stl/inc/yvals_core.h#L2040 So I think the right order here is: 1. Add intrin0.h header 2. Wait for a release 3. Change MSSTL to include that in clang builds as well 4. Wait

[clang] [clang] Add `intrin0.h` header to mimic `intrin0.h` used by MSVC STL for clang-cl (PR #75711)

2023-12-18 Thread Nico Weber via cfe-commits
nico wrote: In other words, please undo the changes to `clang/lib/Headers/immintrin.h` for now. https://github.com/llvm/llvm-project/pull/75711 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe

[clang] [Sema] Add -Wc++11-narrowing-const-reference (PR #76094)

2023-12-22 Thread Nico Weber via cfe-commits
@@ -6158,12 +6158,24 @@ def err_illegal_initializer_type : Error<"illegal initializer type %0">; def ext_init_list_type_narrowing : ExtWarn< "type %0 cannot be narrowed to %1 in initializer list">, InGroup, DefaultError, SFINAEFailure; +// *_narrowing_const_reference diagn

[clang] [Sema] Add -Wc++11-narrowing-const-reference (PR #76094)

2023-12-22 Thread Nico Weber via cfe-commits
https://github.com/nico edited https://github.com/llvm/llvm-project/pull/76094 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Sema] Add -Wc++11-narrowing-const-reference (PR #76094)

2023-12-22 Thread Nico Weber via cfe-commits
https://github.com/nico approved this pull request. Thanks! I'm going to merge this since it'll unblock quite a few people. I have a minor comment below that can be addressed in a follow-up. https://github.com/llvm/llvm-project/pull/76094 ___ cfe-comm

[clang] [Sema] Add -Wc++11-narrowing-const-reference (PR #76094)

2023-12-22 Thread Nico Weber via cfe-commits
https://github.com/nico closed https://github.com/llvm/llvm-project/pull/76094 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [CMake] Move check for dlfcn.h and dladdr to clang (PR #76163)

2023-12-22 Thread Nico Weber via cfe-commits
nico wrote: Can you say what motivated this? Change looks fine, but it looks like it fixes a problem someone reported somewhere but this doesn't say what the problem says. https://github.com/llvm/llvm-project/pull/76163 ___ cfe-commits mailing list cf

[clang] [llvm] [CMake] Move check for dlfcn.h and dladdr to clang (PR #76163)

2023-12-22 Thread Nico Weber via cfe-commits
nico wrote: Thanks! https://github.com/llvm/llvm-project/pull/76163 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang][Sema] Diagnose unexpanded packs in the template argument lists of function template specializations (PR #76677)

2024-01-03 Thread Nico Weber via cfe-commits
nico wrote: This broke check-clang-tools: http://45.33.8.238/linux/127018/step_8.txt Please take a look and revert for now if it takes a while to fix. https://github.com/llvm/llvm-project/pull/76677 ___ cfe-commits mailing list cfe-commits@lists.llvm.

[clang] [clang-format] Optimize processing .clang-format-ignore files (PR #76733)

2024-01-03 Thread Nico Weber via cfe-commits
nico wrote: This seems to cause test failures on win: http://45.33.8.238/win/87705/step_7.txt https://github.com/llvm/llvm-project/pull/76733 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-c

[clang] [clang-format] Optimize processing .clang-format-ignore files (PR #76733)

2024-01-10 Thread Nico Weber via cfe-commits
nico wrote: This still breaks tests on win: http://45.33.8.238/win/88113/step_7.txt Please take a look and revert for now if it takes a while to fix. (Maybe it's possible to rewrite the test to not need grep -Fx – none of the other tests seem to need it.) https://github.com/llvm/llvm-project/

[clang] [Clang] Implement the 'counted_by' attribute (PR #76348)

2024-01-10 Thread Nico Weber via cfe-commits
nico wrote: Reverted in 2dce77201c0c6b541a53aa7a09ec06e7561e8f74 for now. https://github.com/llvm/llvm-project/pull/76348 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [clang] cce06da - Test and document some C99 DRs

2022-06-30 Thread Nico Weber via cfe-commits
Looks like this might break tests: http://45.33.8.238/linux/80043/step_7.txt On Thu, Jun 30, 2022, 9:47 PM Aaron Ballman via cfe-commits < cfe-commits@lists.llvm.org> wrote: > > Author: Aaron Ballman > Date: 2022-06-30T15:46:47-04:00 > New Revision: cce06da1ecf789658551ca5f3b255c361f063abf > > UR

[clang] b1f0efc - [clang-format] Tweak help text a bit

2022-07-03 Thread Nico Weber via cfe-commits
Author: Nico Weber Date: 2022-07-03T21:54:14+02:00 New Revision: b1f0efc06acc27ea07632452d9cf50eb7cc0c7f1 URL: https://github.com/llvm/llvm-project/commit/b1f0efc06acc27ea07632452d9cf50eb7cc0c7f1 DIFF: https://github.com/llvm/llvm-project/commit/b1f0efc06acc27ea07632452d9cf50eb7cc0c7f1.diff LO

[clang] 1ab37d9 - [clang-format] Update documentation

2022-07-04 Thread Nico Weber via cfe-commits
Author: Nico Weber Date: 2022-07-04T21:42:08+02:00 New Revision: 1ab37d996ce376129fa435b63ca50246cc8c2f8d URL: https://github.com/llvm/llvm-project/commit/1ab37d996ce376129fa435b63ca50246cc8c2f8d DIFF: https://github.com/llvm/llvm-project/commit/1ab37d996ce376129fa435b63ca50246cc8c2f8d.diff LO

[clang] e9fe20d - Revert "[Clang] Add a warning on invalid UTF-8 in comments."

2022-07-06 Thread Nico Weber via cfe-commits
Author: Nico Weber Date: 2022-07-06T22:51:52+02:00 New Revision: e9fe20dab39edb911afacdb6ed9ec2c7499a59cf URL: https://github.com/llvm/llvm-project/commit/e9fe20dab39edb911afacdb6ed9ec2c7499a59cf DIFF: https://github.com/llvm/llvm-project/commit/e9fe20dab39edb911afacdb6ed9ec2c7499a59cf.diff LO

[clang] 67aea3b - [clang] Make Driver tests pass when running with temp dir containing "crt"

2022-03-28 Thread Nico Weber via cfe-commits
Author: Nico Weber Date: 2022-03-28T16:06:43-04:00 New Revision: 67aea3b65cc5417a06712a22a2dfb5f3f7f43eff URL: https://github.com/llvm/llvm-project/commit/67aea3b65cc5417a06712a22a2dfb5f3f7f43eff DIFF: https://github.com/llvm/llvm-project/commit/67aea3b65cc5417a06712a22a2dfb5f3f7f43eff.diff LO

[clang] 50186b6 - Revert "[GH54588]Fix ItaniumMangler for NTTP unnamed unions w/ unnamed structs"

2022-04-03 Thread Nico Weber via cfe-commits
Author: Nico Weber Date: 2022-04-03T17:21:27-04:00 New Revision: 50186b63d1807d389f31c515377d94185795ab44 URL: https://github.com/llvm/llvm-project/commit/50186b63d1807d389f31c515377d94185795ab44 DIFF: https://github.com/llvm/llvm-project/commit/50186b63d1807d389f31c515377d94185795ab44.diff LO

[clang] a97e309 - fix comment typos to cycle bots

2022-04-04 Thread Nico Weber via cfe-commits
Author: Nico Weber Date: 2022-04-04T10:18:08-04:00 New Revision: a97e3097cfdfea5a20d3b867571c42ffa0666b01 URL: https://github.com/llvm/llvm-project/commit/a97e3097cfdfea5a20d3b867571c42ffa0666b01 DIFF: https://github.com/llvm/llvm-project/commit/a97e3097cfdfea5a20d3b867571c42ffa0666b01.diff LO

[clang] 0eb7d86 - Revert "[InstrProf] Add new format for -fprofile-list="

2022-08-04 Thread Nico Weber via cfe-commits
Author: Nico Weber Date: 2022-08-04T13:04:59-04:00 New Revision: 0eb7d86f5873ce897894339a3cc5bc69ca507bee URL: https://github.com/llvm/llvm-project/commit/0eb7d86f5873ce897894339a3cc5bc69ca507bee DIFF: https://github.com/llvm/llvm-project/commit/0eb7d86f5873ce897894339a3cc5bc69ca507bee.diff LO

[clang] 3fbbf28 - unbreak Modules/cxx20-export-import.cpp with LLVM_APPEND_VC_REV=OFF after 6635f48e4aba

2022-08-05 Thread Nico Weber via cfe-commits
Author: Nico Weber Date: 2022-08-05T19:50:23-04:00 New Revision: 3fbbf28173406ed74c9791d172fff5c5b1aab823 URL: https://github.com/llvm/llvm-project/commit/3fbbf28173406ed74c9791d172fff5c5b1aab823 DIFF: https://github.com/llvm/llvm-project/commit/3fbbf28173406ed74c9791d172fff5c5b1aab823.diff LO

[clang] 452095f - [clang/darwin] Pass libclang_rt.profile last on linker command

2021-07-27 Thread Nico Weber via cfe-commits
Author: Nico Weber Date: 2021-07-27T07:51:06-04:00 New Revision: 452095fe2f58528c174ca780265f227439e3e07e URL: https://github.com/llvm/llvm-project/commit/452095fe2f58528c174ca780265f227439e3e07e DIFF: https://github.com/llvm/llvm-project/commit/452095fe2f58528c174ca780265f227439e3e07e.diff LO

[clang] e6c58e6 - [clang] Remove stdint.h include from a test

2022-03-21 Thread Nico Weber via cfe-commits
Author: Nico Weber Date: 2022-03-21T14:30:12-04:00 New Revision: e6c58e6fd32f5b8f4e789763843f1f1df19f2d25 URL: https://github.com/llvm/llvm-project/commit/e6c58e6fd32f5b8f4e789763843f1f1df19f2d25 DIFF: https://github.com/llvm/llvm-project/commit/e6c58e6fd32f5b8f4e789763843f1f1df19f2d25.diff LO

[clang] e22a60b - Revert "Reland "[Driver] Default CLANG_DEFAULT_PIE_ON_LINUX to ON"""

2022-04-07 Thread Nico Weber via cfe-commits
Author: Nico Weber Date: 2022-04-07T10:07:07-04:00 New Revision: e22a60b1c898a760a73417fa225c2fbe0609a69f URL: https://github.com/llvm/llvm-project/commit/e22a60b1c898a760a73417fa225c2fbe0609a69f DIFF: https://github.com/llvm/llvm-project/commit/e22a60b1c898a760a73417fa225c2fbe0609a69f.diff LO

[clang] a60e9b3 - unbreak Modules/cxx20-export-import.cpp with LLVM_APPEND_VC_REV after fa34951fbc9bde75

2022-04-08 Thread Nico Weber via cfe-commits
Author: Nico Weber Date: 2022-04-08T19:43:40-04:00 New Revision: a60e9b373f30ff1fc2af96cf6730d4ca461d1ba5 URL: https://github.com/llvm/llvm-project/commit/a60e9b373f30ff1fc2af96cf6730d4ca461d1ba5 DIFF: https://github.com/llvm/llvm-project/commit/a60e9b373f30ff1fc2af96cf6730d4ca461d1ba5.diff LO

[clang] d29f8a5 - [Clang] Override method ModuleImportRead in MultiplexASTDeserializationListener

2022-04-11 Thread Nico Weber via cfe-commits
Author: Guoxiong Li Date: 2022-04-11T08:38:37-04:00 New Revision: d29f8a5f83501f69621687c09ba4b3c75033bada URL: https://github.com/llvm/llvm-project/commit/d29f8a5f83501f69621687c09ba4b3c75033bada DIFF: https://github.com/llvm/llvm-project/commit/d29f8a5f83501f69621687c09ba4b3c75033bada.diff L

[clang-tools-extra] dd47ab7 - Revert "[clang-tidy] Add portability-std-allocator-const check"

2022-04-14 Thread Nico Weber via cfe-commits
Author: Nico Weber Date: 2022-04-14T09:20:51-04:00 New Revision: dd47ab750b584a320bf61d58a3965a03f3871c1b URL: https://github.com/llvm/llvm-project/commit/dd47ab750b584a320bf61d58a3965a03f3871c1b DIFF: https://github.com/llvm/llvm-project/commit/dd47ab750b584a320bf61d58a3965a03f3871c1b.diff LO

[clang] b3b2538 - [lld/coff] Make lld-link work in a non-MSVC shell, add /winsysroot:

2022-02-11 Thread Nico Weber via cfe-commits
Author: Peter Kasting Date: 2022-02-11T13:55:18-05:00 New Revision: b3b2538df100ec7f6587b0ee70819a3c8ee2c27e URL: https://github.com/llvm/llvm-project/commit/b3b2538df100ec7f6587b0ee70819a3c8ee2c27e DIFF: https://github.com/llvm/llvm-project/commit/b3b2538df100ec7f6587b0ee70819a3c8ee2c27e.diff

[clang] 6f1147f - [clang] Expose -fprofile-use in clang-cl

2022-02-11 Thread Nico Weber via cfe-commits
Author: Nico Weber Date: 2022-02-11T16:16:02-05:00 New Revision: 6f1147f825d087f8486a685024078fe08dba755c URL: https://github.com/llvm/llvm-project/commit/6f1147f825d087f8486a685024078fe08dba755c DIFF: https://github.com/llvm/llvm-project/commit/6f1147f825d087f8486a685024078fe08dba755c.diff LO

[clang] 73e585e - Reland "[lld/coff] Make lld-link work in a non-MSVC shell, add /winsysroot:"

2022-02-11 Thread Nico Weber via cfe-commits
Author: Nico Weber Date: 2022-02-11T17:07:33-05:00 New Revision: 73e585e44d68cf77e2e3274e98c9615156a7d909 URL: https://github.com/llvm/llvm-project/commit/73e585e44d68cf77e2e3274e98c9615156a7d909 DIFF: https://github.com/llvm/llvm-project/commit/73e585e44d68cf77e2e3274e98c9615156a7d909.diff LO

[clang] 125abb6 - Revert "Add support for floating-point option `ffp-eval-method` and for"

2022-02-15 Thread Nico Weber via cfe-commits
Author: Nico Weber Date: 2022-02-15T22:02:25-05:00 New Revision: 125abb61f7ae52f9dbf4b82d5f90b70ef107fb62 URL: https://github.com/llvm/llvm-project/commit/125abb61f7ae52f9dbf4b82d5f90b70ef107fb62 DIFF: https://github.com/llvm/llvm-project/commit/125abb61f7ae52f9dbf4b82d5f90b70ef107fb62.diff LO

[clang] 5d110ed - Revert "[NFC] Update new warning to test"

2022-02-15 Thread Nico Weber via cfe-commits
Author: Nico Weber Date: 2022-02-15T22:23:26-05:00 New Revision: 5d110ed4cd475b9b70bc9faecfe4f0767740c5a3 URL: https://github.com/llvm/llvm-project/commit/5d110ed4cd475b9b70bc9faecfe4f0767740c5a3 DIFF: https://github.com/llvm/llvm-project/commit/5d110ed4cd475b9b70bc9faecfe4f0767740c5a3.diff LO

[clang] c5fb05f - Reland: Make lld-link work in a non-MSVC shell, add /winsysroot:

2022-02-16 Thread Nico Weber via cfe-commits
Author: Peter Kasting Date: 2022-02-16T09:22:39-05:00 New Revision: c5fb05f663f2ac0cbedb318d03b91d44900ab9de URL: https://github.com/llvm/llvm-project/commit/c5fb05f663f2ac0cbedb318d03b91d44900ab9de DIFF: https://github.com/llvm/llvm-project/commit/c5fb05f663f2ac0cbedb318d03b91d44900ab9de.diff

[clang] 8dbc6b5 - Revert "[randstruct] Check final randomized layout ordering"

2022-04-22 Thread Nico Weber via cfe-commits
Author: Nico Weber Date: 2022-04-22T08:27:32-04:00 New Revision: 8dbc6b560055ff5068ff45b550482ba62c36b5a5 URL: https://github.com/llvm/llvm-project/commit/8dbc6b560055ff5068ff45b550482ba62c36b5a5 DIFF: https://github.com/llvm/llvm-project/commit/8dbc6b560055ff5068ff45b550482ba62c36b5a5.diff LO

[clang] f693280 - [cc1as] Add support for emitting the build version load command for -darwin-target-variant

2022-04-22 Thread Nico Weber via cfe-commits
Author: Byoungchan Lee Date: 2022-04-22T08:38:07-04:00 New Revision: f69328049e9e7fde7a314de785c76c1b93e069b2 URL: https://github.com/llvm/llvm-project/commit/f69328049e9e7fde7a314de785c76c1b93e069b2 DIFF: https://github.com/llvm/llvm-project/commit/f69328049e9e7fde7a314de785c76c1b93e069b2.diff

[clang] a45764f - [git-clang-format] Add some examples to the help text

2022-04-22 Thread Nico Weber via cfe-commits
Author: Nico Weber Date: 2022-04-22T15:14:04-04:00 New Revision: a45764f2f9cf0d2d6ec5bd871cc9c36ebf785ccc URL: https://github.com/llvm/llvm-project/commit/a45764f2f9cf0d2d6ec5bd871cc9c36ebf785ccc DIFF: https://github.com/llvm/llvm-project/commit/a45764f2f9cf0d2d6ec5bd871cc9c36ebf785ccc.diff LO

[clang] c94a02e - [git-clang-format] Change run line from python to python3

2022-04-22 Thread Nico Weber via cfe-commits
Author: Nico Weber Date: 2022-04-22T15:14:51-04:00 New Revision: c94a02e0e223bcce3b2c88741fae35d31a2d4f1d URL: https://github.com/llvm/llvm-project/commit/c94a02e0e223bcce3b2c88741fae35d31a2d4f1d DIFF: https://github.com/llvm/llvm-project/commit/c94a02e0e223bcce3b2c88741fae35d31a2d4f1d.diff LO

[clang] 26c82f3 - Revert "[clangd] More precisely enable clang warnings through ClangTidy options"

2022-04-29 Thread Nico Weber via cfe-commits
Author: Nico Weber Date: 2022-04-29T20:34:10-04:00 New Revision: 26c82f3d1de11cdada57e499b63a05d24e18b656 URL: https://github.com/llvm/llvm-project/commit/26c82f3d1de11cdada57e499b63a05d24e18b656 DIFF: https://github.com/llvm/llvm-project/commit/26c82f3d1de11cdada57e499b63a05d24e18b656.diff LO

[clang] d489268 - [clang/mac] Make -mmacos-version-min the canonical spelling over -mmacosx-version-min

2022-07-12 Thread Nico Weber via cfe-commits
Author: Nico Weber Date: 2022-07-12T11:03:51-04:00 New Revision: d489268392d231492827c5b0a3be88b707e1fd31 URL: https://github.com/llvm/llvm-project/commit/d489268392d231492827c5b0a3be88b707e1fd31 DIFF: https://github.com/llvm/llvm-project/commit/d489268392d231492827c5b0a3be88b707e1fd31.diff LO

[clang] 953ba18 - [clang/ios] Make -mios-version-min the canonical spelling over -miphoneos-version-min

2022-07-12 Thread Nico Weber via cfe-commits
Author: Nico Weber Date: 2022-07-12T15:09:04-04:00 New Revision: 953ba18fda9230c0ac382e90c62b3f48af311db7 URL: https://github.com/llvm/llvm-project/commit/953ba18fda9230c0ac382e90c62b3f48af311db7 DIFF: https://github.com/llvm/llvm-project/commit/953ba18fda9230c0ac382e90c62b3f48af311db7.diff LO

[clang] 422e6e7 - [docs] Document git-clang-format

2022-07-13 Thread Nico Weber via cfe-commits
Author: Nico Weber Date: 2022-07-13T21:06:00-04:00 New Revision: 422e6e762935b4466c2ef1871df6917ab1c31262 URL: https://github.com/llvm/llvm-project/commit/422e6e762935b4466c2ef1871df6917ab1c31262 DIFF: https://github.com/llvm/llvm-project/commit/422e6e762935b4466c2ef1871df6917ab1c31262.diff LO

[clang] 620ca75 - fix comment typo to cycle bots

2022-07-25 Thread Nico Weber via cfe-commits
Author: Nico Weber Date: 2022-07-26T01:55:10-04:00 New Revision: 620ca754e3f769f2be4668feccee84071d785be3 URL: https://github.com/llvm/llvm-project/commit/620ca754e3f769f2be4668feccee84071d785be3 DIFF: https://github.com/llvm/llvm-project/commit/620ca754e3f769f2be4668feccee84071d785be3.diff LO

[clang] 42915e2 - [gn build] (manually) port a2f2dfde48ac (clang-fuzzer-dictionary)

2022-05-09 Thread Nico Weber via cfe-commits
Author: Nico Weber Date: 2022-05-09T18:28:58-04:00 New Revision: 42915e2be231983a6476eabc059d114d60742ded URL: https://github.com/llvm/llvm-project/commit/42915e2be231983a6476eabc059d114d60742ded DIFF: https://github.com/llvm/llvm-project/commit/42915e2be231983a6476eabc059d114d60742ded.diff LO

[clang] 93a8225 - [CodeGen] Use ABI alignment for C++ new expressions

2022-05-10 Thread Nico Weber via cfe-commits
Author: Daniel Bertalan Date: 2022-05-10T16:02:23+01:00 New Revision: 93a8225da1f983cccb3e4b5e762369121aaa7dd5 URL: https://github.com/llvm/llvm-project/commit/93a8225da1f983cccb3e4b5e762369121aaa7dd5 DIFF: https://github.com/llvm/llvm-project/commit/93a8225da1f983cccb3e4b5e762369121aaa7dd5.dif

[clang] e0fcdf5 - Revert "In MSVC compatibility mode, friend function declarations behave as function declarations"

2022-05-13 Thread Nico Weber via cfe-commits
Author: Nico Weber Date: 2022-05-13T09:48:01-04:00 New Revision: e0fcdf5496ca686c8cebb63b63af86e666b42ab3 URL: https://github.com/llvm/llvm-project/commit/e0fcdf5496ca686c8cebb63b63af86e666b42ab3 DIFF: https://github.com/llvm/llvm-project/commit/e0fcdf5496ca686c8cebb63b63af86e666b42ab3.diff LO

[clang] d39928e - clang-cl: Move /Zc: tests from cl-options.c to cl-zc.cpp

2022-05-18 Thread Nico Weber via cfe-commits
Author: Nico Weber Date: 2022-05-18T11:01:10-04:00 New Revision: d39928e2cc393a21c8367ef318019166124f4b56 URL: https://github.com/llvm/llvm-project/commit/d39928e2cc393a21c8367ef318019166124f4b56 DIFF: https://github.com/llvm/llvm-project/commit/d39928e2cc393a21c8367ef318019166124f4b56.diff LO

[clang] [OBJC] Allow __attribute__((NSObject)) types be used as lightweight generic specifiers (PR #84593)

2024-03-15 Thread Nico Weber via cfe-commits
nico wrote: @rjmccall Do you have an opinion on this? https://github.com/llvm/llvm-project/pull/84593 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [DXIL] implement dot intrinsic lowering for integers (PR #85662)

2024-03-19 Thread Nico Weber via cfe-commits
nico wrote: Also failing on http://45.33.8.238/linux/133623/step_7.txt It's been broken for over an hour now. Time to revert and fix async? https://github.com/llvm/llvm-project/pull/85662 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https:/

<    1   2   3   4   5   6   7   8   9   10   >