[PATCH] D113707: [clang] Make -masm=intel affect inline asm style

thakis updated this revision to Diff 387399. thakis added a comment. minor test expectations update CHANGES SINCE LAST ACTION https://reviews.llvm.org/D113707/new/ https://reviews.llvm.org/D113707 Files: clang/include/clang/Basic/CodeGenOptions.def clang/include/clang/Basic/CodeGenOption

[PATCH] D113707: [clang] Make -masm=intel affect inline asm style

thakis added a comment. (Here are a few revisions I read through while researching this patch: da081a8e1f295ffdd670f87dba19f470a9a5acaa and fc416faaa07c5 (and 4f2791617e2fa) and aa23fa9f435d2 1778831a3d1d2 split the "ms" inline asm out isSimple added in 19fe116fc0b35, meaningfully used in b737b

[PATCH] D113707: [clang] Make -masm=intel affect inline asm style

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGae98182cf734: [clang] Make -masm=intel affect inline asm style (authored by thakis). Herald added a project: clang. Repository: rG LLVM Github Mon

[PATCH] D113707: [clang] Make -masm=intel affect inline asm style

thakis marked 3 inline comments as done. thakis added a comment. Derp, I landed this without replying to the comments. I'll do a follow-up commit for them right now. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D113707/new/ https://reviews.llvm.or

[PATCH] D113707: [clang] Make -masm=intel affect inline asm style

thakis added a comment. https://reviews.llvm.org/rGb1ad813b474a Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D113707/new/ https://reviews.llvm.org/D113707 ___ cfe-commits mailing list cfe-commits@lists.l

[PATCH] D114120: [clang] Remove CLANG_ROUND_TRIP_CC1_ARGS and always roundtrip in +assert builds

thakis created this revision. thakis added reviewers: dexonsmith, jansvoboda11. Herald added a subscriber: mgorny. thakis requested review of this revision. This removes the ability to disable roundtripping in assert builds. (Roundtripping happens by default in assert builds both before and after

[PATCH] D113707: [clang] Make -masm=intel affect inline asm style

thakis added a comment. This contained a bug in that I didn't change CompilerInvocation::GenerateCodeGenArgs() to serialize the new flag correctly, so in build configs that do roundtripping the test failed. I fixed the marshalling in https://reviews.llvm.org/rG36873fb768dbedeb3e9167117d3bb63b3

[PATCH] D114120: [clang] Remove CLANG_ROUND_TRIP_CC1_ARGS and always roundtrip in +assert builds

thakis marked an inline comment as done. thakis added inline comments. Comment at: clang/lib/Frontend/CompilerInvocation.cpp:615 // May perform round-trip of command line arguments. By default, the round-trip // is enabled if CLANG_ROUND_TRIP_CC1_ARGS was defined during build.

[PATCH] D114120: [clang] Remove CLANG_ROUND_TRIP_CC1_ARGS and always roundtrip in +assert builds

This revision was automatically updated to reflect the committed changes. thakis marked an inline comment as done. Closed by commit rG3950e1be8d6e: [clang] Remove CLANG_ROUND_TRIP_CC1_ARGS and always roundtrip in +assert builds (authored by thakis). Herald added a project: clang. Changed prior to

[PATCH] D110216: [clang] retain type sugar in auto / template argument deduction

thakis added a comment. > So, some notes: > > - We should probably also do an AKA on the type diff. > - Chromium should use a clearer name for that typedef perhaps? Though calling > the first template parameter of span as `T` is common, maybe a better name > here would be `element_type`. > > Hav

[PATCH] D113118: [clang][AST] Check context of record in structural equivalence.

thakis added a comment. Looks like this breaks tests on windows: http://45.33.8.238/win/49558/step_7.txt Please take a look and revert for now if it takes a while to fix. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D113118/new/ https://reviews.ll

[PATCH] D114660: [clang] Fix -Wreturn-type false positive in @try statements

thakis created this revision. thakis added a reviewer: hans. thakis requested review of this revision. After 04f30795f16638 , -Wreturn-type has an effect on functions that contain @try/@catch statements. CheckFallThrough() was

[PATCH] D112287: [clang] Implement CFG construction for @try and @catch

thakis added a comment. In D112287#3146956 , @comanea wrote: > I believe there is an issue that this change introduced. It is described > here. https://bugs.llvm.org/show_bug.cgi?id=52473 > If anyone could provide some insight, it would be much appreciat

[PATCH] D114660: [clang] Fix -Wreturn-type false positive in @try statements

thakis added a comment. For future self, related changes I looked at: https://reviews.llvm.org/rG04c6851cd6053 (made it so that calls don't add edges to try cfg blocks) https://reviews.llvm.org/rG33979f75a0fd8 (added -Wreturn-type in the first place) https://reviews.llvm.org/rG0c2ec779cf680d228

[PATCH] D114660: [clang] Fix -Wreturn-type false positive in @try statements

thakis added a comment. https://reviews.llvm.org/rG06b602e540cd94d09ccbb39d63b151860a4022d2 (added the c++ exception checks to the warning) CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114660/new/ https://reviews.llvm.org/D114660 ___ cfe-co

[PATCH] D114867: [clang-cl] Set _MSVC_LANG to 202002L with /std:c++20

thakis created this revision. thakis added a reviewer: hans. thakis requested review of this revision. MSVC says this should be 202002L for /std:c++20, and of VS16.11 that's indeed the case (older versions warn that they don't understand /std:c++20, and then cl.exe defaults to C++14 and sets _MSVC

[PATCH] D114867: [clang-cl] Set _MSVC_LANG to 202002L with /std:c++20

thakis added a comment. For reference: https://godbolt.org/z/3rnKovjTG CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114867/new/ https://reviews.llvm.org/D114867 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/c

[PATCH] D114867: [clang-cl] Set _MSVC_LANG to 202002L with /std:c++20

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG3f643f166494: [clang-cl] Set _MSVC_LANG to 202002L with /std:c++20 (authored by thakis). Herald added a project: clang. Repository: rG LLVM Github

[PATCH] D114619: [Analyzer][solver] Do not remove the simplified symbol from the eq class

thakis added a comment. The test sometimes fails flakily: http://45.33.8.238/macm1/22813/step_7.txt Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114619/new/ https://reviews.llvm.org/D114619 ___ cfe-comm

[PATCH] D114619: [Analyzer][solver] Do not remove the simplified symbol from the eq class

thakis added a comment. Thanks for the fix! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114619/new/ https://reviews.llvm.org/D114619 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://list

[PATCH] D114952: [clang-cl] Define _MSVC_LANG for -std=c++2b

thakis created this revision. thakis added a reviewer: hans. thakis requested review of this revision. This matches the value that msvc v19.29 VS16.11 uses for _MSVC_LANG with /std:c++latest. https://reviews.llvm.org/D114952 Files: clang/lib/Basic/Targets/OSTargets.cpp clang/test/Preprocess

[PATCH] D114952: [clang-cl] Define _MSVC_LANG for -std=c++2b

thakis added a comment. (for reference: https://godbolt.org/z/W6n6jqz4Y) CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114952/new/ https://reviews.llvm.org/D114952 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org

[PATCH] D114952: [clang-cl] Define _MSVC_LANG for -std=c++2b

This revision was automatically updated to reflect the committed changes. Closed by commit rG2a2b3a3e3df7: [clang-cl] Define _MSVC_LANG for -std=c++2b (authored by thakis). Herald added a project: clang. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D

[PATCH] D114974: [clang][Darwin] Remove old lld implementation handling

thakis accepted this revision. thakis added a comment. This revision is now accepted and ready to land. \o/ Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114974/new/ https://reviews.llvm.org/D114974 ___

[PATCH] D115015: CodeGen: Strip exception specifications from function types in CFI type names.

thakis accepted this revision. thakis added a comment. This revision is now accepted and ready to land. lg Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115015/new/ https://reviews.llvm.org/D115015 ___ c

[PATCH] D115015: CodeGen: Strip exception specifications from function types in CFI type names.

This revision was automatically updated to reflect the committed changes. Closed by commit rG0a14674f276b: CodeGen: Strip exception specifications from function types in CFI type names. (authored by pcc, committed by thakis). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION http

[PATCH] D115015: CodeGen: Strip exception specifications from function types in CFI type names.

thakis added a comment. I patched this in and verified that it fixes the make_top_domain_list_variables issue in https://bugs.chromium.org/p/chromium/issues/detail?id=1273966 and went ahead and landed this. Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://revi

[PATCH] D115049: Fall back on Android triple w/o API level for runtimes search

thakis added a comment. Looks like this breaks tests on Windows: https://buildkite.com/llvm-project/premerge-checks/builds/68330#746376c2-ce48-4ffc-b60f-515619dee28c Failed Tests (2): Clang :: Driver/ve-toolchain.c Clang :: Driver/ve-toolchain.cpp Repository: rG LLVM Github Monorepo

[PATCH] D136474: [CodeView][clang] Add flag to disable emitting command line into CodeView

thakis added a comment. There will be other problems like this. We don't care about having the command in the debug info and we'd rather get rid of this class of bugs Once And For All :) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136474/new/ h

[PATCH] D136022: [clang] Add time profile for constant evaluation

thakis added inline comments. Comment at: clang/unittests/Support/TimeProfilerTest.cpp:11 +#include "clang/Frontend/FrontendActions.h" +#include "clang/Lex/PreprocessorOptions.h" + Why is this in clang/unittests/Support (a new binary to boot)? This doesn't use a

[PATCH] D136602: NFC: [clang] Template argument cleanups.

thakis added inline comments. Comment at: clang-tools-extra/clang-tidy/modernize/UseTransparentFunctorsCheck.cpp:101 +const TemplateArgument &Arg = +FunctorParentType->template_arguments()[ArgNum]; if (Arg.getKind() != TemplateArgument::Type) Th

[PATCH] D135340: [PGO] Make emitted symbols hidden

thakis added a comment. This is still breaking ` Profile-x86_64 :: instrprof-darwin-dead-strip.c` on mac. I'm reverting this again for now. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135340/new/ https://reviews.llvm.org/D135340 ___ cfe-

[PATCH] D136533: [clang] Fix missing diagnostic of declaration use when accessing TypeDecls through typename access

thakis added a comment. +1, this breaks building LLVM on macOS. This isn't limited to libFuzzer. See the many hits for "error:" on https://logs.chromium.org/logs/chromium/buildbucket/cr-buildbucket/8799329305964156353/+/u/package_clang/stdout?format=raw Let's revert this until LLVM can build ag

[PATCH] D136474: [CodeView][clang] Add flag to disable emitting command line into CodeView

thakis accepted this revision. thakis added a comment. This revision is now accepted and ready to land. Thanks! Please mention the default value of the flag in the commit message. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136474/new/ https://r

[PATCH] D136700: clang: Add a cmake toggle to disable libclang's libxml2 dependency

thakis created this revision. thakis added a reviewer: hans. Herald added a project: All. thakis requested review of this revision. By default, libclang will still depend on libxml2 according to LLVM_ENABLE_LIBXML2, but with this it's possible to make libclang not depend on libxml2 even though LLV

[PATCH] D136474: [CodeView][clang] Disable emitting command line into CodeView by default and add flag to enable

thakis added a comment. FWIW we do have precedent of deviating from cl.exe for determinism reasons. I think having deterministic output is a good default. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136474/new/ https://reviews.llvm.org/D136474

[PATCH] D136474: [CodeView][clang] Disable emitting command line into CodeView by default and add flag to enable

thakis added a comment. > This is true, but the cc1 flag isn't inherently non-deterministic. I would > prefer to fix the determinism bugs instead of adding flags and more > divergence. See https://reviews.llvm.org/D136474#3875546 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTIO

[PATCH] D136474: [CodeView][clang] Disable emitting command line into CodeView by default and add flag to enable

thakis added a comment. (In other words, all known people who care about clang's determinism do not care about having the command recorded in the debug data -- and some (me :) ) mentioned concerns about determinism about the patch adding that feature. It seems weird to put those people on the h

[PATCH] D136700: clang: Add a cmake toggle to disable libclang's libxml2 dependency

This revision was automatically updated to reflect the committed changes. Closed by commit rGdf239a6c17fa: clang: Add a cmake toggle to disable libclang's libxml2 dependency (authored by thakis). Herald added a project: clang. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION htt

[PATCH] D136474: [CodeView][clang] Disable emitting command line into CodeView by default and add flag to enable

thakis added a comment. > I read that, and I'm indicating that I don't agree. Chromium's requirements > are driven by its particular usage of a cross-compiling distributed build > system, which may not represent the average user's needs. Are you saying that it's a good thing if clang produces d

[PATCH] D136474: [CodeView][clang] Disable emitting command line into CodeView by default and add flag to enable

thakis added a comment. In D136474#3888455 , @aganea wrote: > In D136474#3888330 , @thakis wrote: > >>> I read that, and I'm indicating that I don't agree. Chromium's requirements >>> are driven by its particular

[PATCH] D136474: [CodeView][clang] Disable emitting command line into CodeView by default and add flag to enable

thakis added a comment. > That works for me, I just want to make it clear that the long term goal for > the project is that we emit the command line in LF_BUILDINFO by default, > rather than disabling it once and for all. If it's not ready yet, great, > let's disable it and continue. Fully on

[PATCH] D135366: [clang][Interp] Implement String- and CharacterLiterals

thakis added a comment. One of your commits doesn't build on windows with clang-cl as host compiler: http://45.33.8.238/win/68965/step_4.txt Please take a look and revert for now if it takes a while to fix. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm

[PATCH] D136533: [clang] Fix missing diagnostic of declaration use when accessing TypeDecls through typename access

thakis added a comment. In D136533#3893032 , @ldionne wrote: > In D136533#3892949 , @ldionne wrote: > >> 2. Shipping this change does mean that anyone building anything with a new >> Clang and a not-yet-updated l

[PATCH] D136533: [clang] Fix missing diagnostic of declaration use when accessing TypeDecls through typename access

thakis added subscribers: aeubanks, hans. thakis added a comment. Adding @hans @aeubanks since they were involved over there too. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136533/new/ https://reviews.llvm.org/D136533 __

[PATCH] D136474: [CodeView][clang] Disable emitting command line into CodeView by default and add flag to enable

thakis added a comment. Just to be clear, in any case, this patch here is ready to go as long as it doesn't flip the default, yes? > @thakis do you mind explaining the issues you see and how to replicate them > and I can have a look. See above (`-fmessage-length` gets embedded and is machine-d

[PATCH] D131528: [Clang] Restrict non fixed enum to a value outside the range of the enumeration values warning to context requiring a constant expression

thakis added a comment. We're also still seeing the diag fire after this: https://ci.chromium.org/p/chromium/builders/ci/ToTLinux (And we cleaned up our codebase back when it was still an error.) Our bots have been red since the change to turn this into a warning landed. Repository: rG LLVM

[PATCH] D131255: Fix Wbitfield-constant-conversion on 1-bit signed bitfield

thakis added inline comments. Comment at: clang/lib/Sema/SemaChecking.cpp:13069 - // therefore don't strictly fit into a signed bitfield of width 1. - if (FieldWidth == 1 && Value == 1) -return false; This was to suppress false positives. All instances we'v

[PATCH] D131704: [Clang] Tighten restrictions on enum out of range diagnostic

thakis added a comment. > This is constant initialization, so this is indeed expected. Do we have a test for this in clang? It seems that the diag appeared for that case after the change that turned this diag into a disable-able warning. Given it's intentional, we should make sure we test that

[PATCH] D131704: [Clang] Tighten restrictions on enum out of range diagnostic

thakis added a comment. In D131704#3717950 , @shafik wrote: > In D131704#3717774 , @akhuang wrote: > >> We're seeing this warning in code with global constants, e.g. >> >> const Enum x = static_cast(-1); >> >> i

[PATCH] D116203: [clang] adds unary type transformations as compiler built-ins

thakis added a comment. This breaks building on windows: http://45.33.8.238/win/64423/step_4.txt Please take a look and revert for now if it takes a while to fix. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116203/new/ https://reviews.llvm.org/D

[PATCH] D116203: [clang] adds unary type transformations as compiler built-ins

thakis added a comment. Reverted this (and follow-ups) in aacf1a9742f714dd432117d82d19a007289c3dee for now. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116203/new/ https://rev

[PATCH] D131818: [clang][diagnostics] Don't warn about unreachable code in constexpr if

thakis added a comment. Thanks! Can you add a test for non-constexpr unreachable code within the constexpr if and test that that still warns? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131818/new/ https://reviews.llvm.org/D131818

[PATCH] D127641: [clang-cl][MSVC] Enable /Zc:alignedNew for C++17 and /Zc:sizedDealloc by default

thakis added inline comments. Comment at: clang/lib/Driver/ToolChains/Clang.cpp:6649 + } else if (IsCPP17Onwards) { +CmdArgs.push_back("-faligned-allocation"); } Do we want to do this in the driver? From what I understand, we already do this (MSVC or not

[PATCH] D131818: [clang][diagnostics] Don't warn about unreachable code in constexpr if

thakis accepted this revision. thakis added a comment. This revision is now accepted and ready to land. Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131818/new/ https://reviews.llvm.org/D131818

[PATCH] D131214: [clang][Driver] Pass correct reproduce flag to lld-link

thakis added a comment. The removal of the explicit target broke the test on Mac: http://45.33.8.238/macm1/42754/step_7.txt (Just need to be more permissive about leading underscores) Please take a look and revert for now if it takes a while to fix. Repository: rG LLVM Github Monorepo CHAN

[PATCH] D130586: [cmake] Use `CMAKE_INSTALL_LIBDIR` too

thakis added a comment. When this relands and it's not too much trouble, it'd be nice if you could reland d3a1dbc4907b59690f9013cdb6221573ca4233f1 in the commit that relands this. Repository: rG LLVM Github Monorepo CHAN

[PATCH] D132258: clang/apple: Infer simulator env from -mios-simulator-version-min flag

thakis created this revision. thakis added a reviewer: akyrtzi. Herald added subscribers: pengfei, kristof.beyls. Herald added a project: All. thakis requested review of this revision. Herald added a subscriber: MaskRay. Before this patch, clang would consider `-target x86_64-apple-darwin -mios-si

[PATCH] D132258: clang/apple: Infer simulator env from -mios-simulator-version-min flag

thakis added a comment. (Ref https://bugs.chromium.org/p/chromium/issues/detail?id=1265937#c4 , https://bugs.chromium.org/p/chromium/issues/detail?id=1265937#c6) CHANGES SINCE LAST ACTION https://reviews.llvm.org/D132258/new/ https://reviews.llvm.org/D132258

[PATCH] D132258: clang/apple: Infer simulator env from -mios-simulator-version-min flag

thakis added a comment. To reproduce the warnings that this attempts to fix: % /Applications/CMake.app/Contents/bin/cmake -GNinja -DCMAKE_BUILD_TYPE=Release -DLLVM_ENABLE_ASSERTIONS=ON -DLLVM_ENABLE_PROJECTS='clang;lld' -DLLVM_ENABLE_RUNTIMES='compiler-rt' -DLLVM_APPEND_VC_REV=NO -DLLVM_TARG

[PATCH] D132300: [clang][lldb][cmake] Use new `*_INSTALL_LIBDIR_BASENAME` CPP macro

thakis added a comment. I fixed up the gn build after this in 804d4594cbe217ae817b6786b0e9965283f78aa2 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D132300/new/ https://reviews.

[PATCH] D132300: [clang][lldb][cmake] Use new `*_INSTALL_LIBDIR_BASENAME` CPP macro

thakis added a comment. (ie if you revert that, it'd be appreciated if you could revert that in the same commit) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D132300/new/ https://reviews.llvm.org/D132300 __

[PATCH] D132258: clang/apple: Infer simulator env from -mios-simulator-version-min flag

This revision was automatically updated to reflect the committed changes. Closed by commit rG3affbae5300d: clang/apple: Infer simulator env from -mios-simulator-version-min= flag (authored by thakis). Herald added a project: clang. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D132379: [Support] Class for response file expansion

thakis added a comment. Can you say what you're trying to do? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D132379/new/ https://reviews.llvm.org/D132379 ___ cfe-commits mailing list cfe-commits@lists.llv

[PATCH] D132399: [clang/test] Correctly specify simulator env in target flag in fsanitize.c

thakis created this revision. thakis added a reviewer: hans. Herald added a project: All. thakis requested review of this revision. Putting "simulator" in the `-target` flag requires putting it in the "environment" part of the triple, which is the 4th `-`-separated component. Some places in the t

[PATCH] D132400: [clang] Remove a FIXME that we can't fix

thakis created this revision. thakis added a reviewer: hans. Herald added subscribers: pengfei, kristof.beyls. Herald added a project: All. thakis requested review of this revision. Herald added a subscriber: MaskRay. I added this recently, but it looks like several tests very intentionally check

[PATCH] D132444: [clang] Allow using -rtlib=platform to switching to the default rtlib on all targets

thakis added a comment. Do we have precedent for "platform" for this? For fuse-ld=, one is supposed to use `-fuse-ld=` (without anything after the `=`) to get the default ld. That's not great (...but it can't collide with actual linker names, i suppose). Using "platform" (or any other self-desc

[PATCH] D132400: [clang] Remove a FIXME that we can't fix

This revision was automatically updated to reflect the committed changes. Closed by commit rGcd24120c9d95: [clang] Remove a FIXME that we can't fix (authored by thakis). Herald added a project: clang. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D132

[PATCH] D132400: [clang] Remove a FIXME that we can't fix

thakis added a comment. Thanks, fixed commit message. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D132400/new/ https://reviews.llvm.org/D132400 ___ cfe-commits mailing list cfe-commits@lists.llvm.org ht

[PATCH] D132399: [clang/test] Correctly specify simulator env in target flag in fsanitize.c

thakis added a comment. Thanks! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D132399/new/ https://reviews.llvm.org/D132399 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D132399: [clang/test] Correctly specify simulator env in target flag in fsanitize.c

This revision was automatically updated to reflect the committed changes. Closed by commit rG0565e65a6967: [clang/test] Correctly specify simulator env in target flag in fsanitize.c (authored by thakis). Herald added a project: clang. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTI

[PATCH] D132444: [clang] Allow using -rtlib=platform to switching to the default rtlib on all targets

thakis added a comment. Makes sense to me. Maybe @hans has an opinion too. WDYT about accepting the same string for -fuse-ld= to mean "platform linker" there as well? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D132444/new/ https://reviews.llvm.

[PATCH] D132486: SONAME introduce option CLANG_FORCE_MATCHING_LIBCLANG_SOVERSION

thakis added a comment. Was this reviewed by anyone on the original change? As far as I can tell, there was no agreement on the original change or here that reverting is the way to go. Was this discussed elsewhere? (I don't have an opinion on which approach is better myself.) Repository: rG

[PATCH] D130020: [OpenMP] Deprecate the old driver for OpenMP offloading

thakis added a comment. This caused: In file included from ../../clang/lib/Driver/ToolChains/Cuda.cpp:9: ../../clang/lib/Driver/ToolChains/Cuda.h:193:29: warning: private field 'OK' is not used [-Wunused-private-field] const Action::OffloadKind OK; ^ Repos

[PATCH] D130020: [OpenMP] Deprecate the old driver for OpenMP offloading

thakis added a comment. ps: Thank you to everyone who's been working on having fewer offload wrapper binaries! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130020/new/ https://reviews.llvm.org/D130020

[PATCH] D132754: [clang] Add __is_target_variant_{os,environment} builtins

thakis created this revision. thakis added a reviewer: hans. Herald added a subscriber: kristof.beyls. Herald added a project: All. thakis requested review of this revision. Xcode 13's clang has them. For the included testcase, Xcode's clang behaves like the implementation in this patch. Availabi

[PATCH] D132754: [clang] Add __is_target_variant_{os,environment} builtins

thakis added a comment. Another patch to make open-source clang more like Xcode's clang, needed to parse system headers. https://github.com/nico/hack/blob/main/notes/catalyst.md has some background information on catalyst triples and zippered code. CHANGES SINCE LAST ACTION https://reviews.

[PATCH] D132754: [clang] Add __is_target_variant_{os,environment} builtins

thakis added inline comments. Comment at: clang/lib/Lex/PPMacroExpansion.cpp:1713 // FIXME: This is inconsistent; we usually suggest detecting // builtin macros via #ifdef. Don't add more cases here. .Case("__is_target_arch", true) ---

[PATCH] D131632: [clang] Enable output of SARIF diagnostics

thakis added a comment. This adds warnings: [498/568] CXX obj/clang/lib/Frontend/Frontend.SARIFDiagnostic.o ../../clang/lib/Frontend/SARIFDiagnostic.cpp:74:25: warning: unused variable 'Filename' [-Wunused-variable] llvm::StringRef Filename = ^ In file i

[PATCH] D132754: [clang] Add __is_target_variant_{os,environment} builtins

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG396f40a79fc9: [clang] Add __is_target_variant_{os,environment} builtins (authored by thakis). Herald added a project: clang. Repository: rG LLVM G

[PATCH] D131614: [clang][dataflow] Extend transfer functions for other `CFGElement`s

thakis added a comment. I don't know how you commited this, but the commit message is missing all the (great!) details that are here on the review. See here: https://github.com/llvm/llvm-project/commit/4b815eb4fde0202434c6 or here: https://reviews.llvm.org/rG4b815eb4fde0202434c63 Please update

[PATCH] D134063: [clang] Make --ld-path= work with -fuse-ld=lld

thakis created this revision. thakis added a reviewer: MaskRay. Herald added a subscriber: StephenFan. Herald added a project: All. thakis requested review of this revision. This allows using --ld-path= to set a custom linker path, while still informing clang that the binary at that path is an lld

[PATCH] D83015: [Driver] Add --ld-path= and deprecate -fuse-ld=/abs/path and -fuse-ld=rel/path

thakis added a comment. > Yes, specify both options. -fuse-ld= specifies the flavor while --ld-path= > specifies a path the Clang Driver does not want to detect. Thanks, made D134063 for that. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D134063: [clang] Make --ld-path= work with -fuse-ld=lld

This revision was automatically updated to reflect the committed changes. Closed by commit rG31142c429053: [clang] Make --ld-path= work with -fuse-ld=lld (authored by thakis). Herald added a project: clang. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.or

[PATCH] D134544: [clang-cl] Implement /ZH: flag

thakis created this revision. thakis added a reviewer: hans. Herald added a project: All. thakis requested review of this revision. Herald added a subscriber: MaskRay. Based on a patch by Arlo Siemsen (D98438 )! https://reviews.llvm.org/D134544 Files: clang/in

[PATCH] D98438: Clang: Allow selecting the hash algorithm for file checksums in debug info.

thakis added a comment. Herald added a subscriber: MaskRay. Herald added a project: All. I addressed pending comments, did some other minor tweaks, and uploaded the modified diff to D134544 . Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION ht

[PATCH] D134544: [clang-cl] Implement /ZH: flag

thakis updated this revision to Diff 462503. thakis added a comment. tweak CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134544/new/ https://reviews.llvm.org/D134544 Files: clang/include/clang/Basic/CodeGenOptions.def clang/include/clang/Basic/CodeGenOptions.h clang/include/clang

[PATCH] D134544: [clang-cl] Implement /ZH: flag

thakis added a comment. In D134544#3811867 , @probinson wrote: > Probably we should reject the -gsrc... option if we're emitting DWARF, which > requires MD5 (at least so far). It's a cc1 option. As those aren't considered user facing, we don't do a lot

[PATCH] D134544: [clang-cl] Implement /ZH: flag

thakis added inline comments. Comment at: clang/include/clang/Basic/CodeGenOptions.def:344 +/// Set debug info source file hashing algorithm +ENUM_CODEGENOPT(DebugSrcHashAlgorithm, SrcHashAlgorithm, 2, CSK_MD5) hans wrote: > ultra nit: period. But maybe the com

[PATCH] D134544: [clang-cl] Implement /ZH: flag

thakis added inline comments. Comment at: clang/test/CodeGen/debug-info-file-checksum.c:3 +// RUN: %S/Inputs/debug-info-file-checksum.c -o - | FileCheck %s +// RUN: %clang -emit-llvm -S -g -gcodeview -gsrc-hash-algorithm=md5 -x c \ +// RUN: %S/Inputs/debug-info-file-check

[PATCH] D134544: [clang-cl] Implement /ZH: flag

thakis added inline comments. Comment at: clang/test/CodeGen/debug-info-file-checksum.c:3 +// RUN: %S/Inputs/debug-info-file-checksum.c -o - | FileCheck %s +// RUN: %clang -emit-llvm -S -g -gcodeview -gsrc-hash-algorithm=md5 -x c \ +// RUN: %S/Inputs/debug-info-file-check

[PATCH] D134544: [clang-cl] Implement /ZH: flag

thakis updated this revision to Diff 462596. thakis added a comment. don't accidentally add a flag for this to the gcc-style driver CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134544/new/ https://reviews.llvm.org/D134544 Files: clang/include/clang/Basic/CodeGenOptions.def clang/i

[PATCH] D134544: [clang-cl] Implement /ZH: flag

thakis updated this revision to Diff 462731. thakis added a comment. final tweaks CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134544/new/ https://reviews.llvm.org/D134544 Files: clang/include/clang/Basic/CodeGenOptions.def clang/include/clang/Basic/CodeGenOptions.h clang/includ

[PATCH] D134544: [clang-cl] Implement /ZH: flag

thakis added inline comments. Comment at: clang/include/clang/Basic/CodeGenOptions.h:106 + enum SrcHashAlgorithm { +CSK_MD5, +CSK_SHA1, hans wrote: > thakis wrote: > > hans wrote: > > > what does CSK stand for here? > > I'm guessing "check sum kind", but

[PATCH] D134544: [clang-cl] Implement /ZH: flag

This revision was automatically updated to reflect the committed changes. Closed by commit rGea8371247f63: [clang-cl] Implement /ZH: flag (authored by thakis). Herald added a project: clang. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134544/new/

[PATCH] D134456: [PGO] Consider parent context when weighing branches with likelyhood.

thakis added a comment. Maybe we could have a `-f` flag to control whether to prefer annotations or profile data when they conflict? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134456/new/ https://reviews.llvm.org/D134456 __

[PATCH] D134657: [Driver] pass -fcrash-diagnostics-dir to LTO

thakis added a comment. This breaks `Driver/crash-diagnostics-dir-2.c` on my mac: FAIL: Clang :: Driver/crash-diagnostics-dir-2.c (7510 of 15804) TEST 'Clang :: Driver/crash-diagnostics-dir-2.c' FAILED Script: -- : 'RUN: at line 3'; /Users/th

[PATCH] D134657: [Driver] pass -fcrash-diagnostics-dir to LTO

thakis added a comment. Thank you! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134657/new/ https://reviews.llvm.org/D134657 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.or

[PATCH] D132416: [Driver][Fuchsia] Add default linker flags

thakis added a comment. This breaks tests on non-linux: http://45.33.8.238/macm1/45619/step_7.txt http://45.33.8.238/win/67193/step_7.txt Please take a look and revert for now if it takes a while to fix. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.or

[PATCH] D119130: [clangd] NFC: Move stdlib headers handling to Clang

thakis added a comment. Herald added a project: All. This makes clang-format depend on clang's AST library, which it shouldn't. Could this move into a dedicated library, or in some library that Format doesn't depend on? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https:/

<    8   9   10   11   12   13   14   15   16   17   >