[PATCH] D71769: [clang-format] C# formatting a class with inheritance followed by an attribute specifier assume its a braces initializer

MyDeveloperDay created this revision. MyDeveloperDay added reviewers: mitchell-stellar, klimek, sammccall. MyDeveloperDay added a project: clang-format. Herald added a project: clang. MyDeveloperDay edited the summary of this revision. https://bugs.llvm.org/show_bug.cgi?id=44340 The rule that pre

[PATCH] D71769: [clang-format] C# formatting a class with inheritance followed by an attribute specifier assume its a braces initializer

This revision was automatically updated to reflect the committed changes. Closed by commit rG2f209ccfbe5e: [clang-format] C# formatting a class with inheritance followed by an attribute… (authored by MyDeveloperDay). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://revie

[PATCH] D75791: [clang-format] Added new option IndentExternBlock

MyDeveloperDay added a comment. you need documentation and release note changes too Comment at: clang/unittests/Format/FormatTest.cpp:31 +class FormatTest +: public ::testing::Test { // FormatTest is a Fixture, data is reused protected: is this comment nec

[PATCH] D75791: [clang-format] Added new option IndentExternBlock

MyDeveloperDay added inline comments. Comment at: clang/lib/Format/UnwrappedLineParser.cpp:1088 if (FormatTok->Tok.is(tok::l_brace)) { -if (Style.BraceWrapping.AfterExternBlock) { - parseBlock(/*MustBeDeclaration=*/true); -} else { +if (Sty

[PATCH] D75791: [clang-format] Added new option IndentExternBlock

MyDeveloperDay added a comment. your patch seems to be missing the other files CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75791/new/ https://reviews.llvm.org/D75791 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.ll

[PATCH] D73768: clang-format: [JS] document InsertTrailingCommas.

MyDeveloperDay accepted this revision. MyDeveloperDay added a comment. This revision is now accepted and ready to land. LGTM thank you Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73768/new/ https://reviews.llvm.org/D73768 _

[PATCH] D70926: [clang-format] Add option for not breaking line before ObjC params

This revision was automatically updated to reflect the committed changes. Closed by commit rG70c98671fa7b: [clang-format] Add option for not breaking line before ObjC params (authored by MyDeveloperDay). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D

[PATCH] D73354: clang-format: insert trailing commas into containers.

MyDeveloperDay added a comment. In D73354#1854115 , @mprobst wrote: > This has landed as https://reviews.llvm.org/rGa324fcf1ae6 (not sure why this > hasn't closed automatically). Thank you, as for not autoclosing my guess it because perhaps you dropped

[PATCH] D74043: [clang-format] Do not treat C# attribute targets as labels

MyDeveloperDay added a comment. LGTM, thanks for the patch (I've seen this in the wild where the AssemblyInfo.cs gets a bit messed up. Comment at: clang/lib/Format/FormatTokenLexer.cpp:287 + auto &Target = *(Tokens.end() - 2); + auto &Colon = *(Tokens.end() - 1); + -

[PATCH] D72326: [clang-format] Rebased on master: Add option to specify explicit config file

MyDeveloperDay accepted this revision. MyDeveloperDay added a comment. This revision is now accepted and ready to land. In the absence of any other comments, This LGTM, this may help to resolve D68569: [clang-format] Also look for .{ext}.clang-format file , I thi

[PATCH] D44609: [clang-format] New option BeforeLambdaBody to manage lambda line break inside function parameter call (in Allman style)

MyDeveloperDay accepted this revision. MyDeveloperDay added a comment. This revision is now accepted and ready to land. This patch is nearly 2 years old, and there has been a lot of discussion and I can see you've put a lot of work into adding the tests which prove it works, from my perspective

[PATCH] D44609: [clang-format] New option BeforeLambdaBody to manage lambda line break inside function parameter call (in Allman style)

MyDeveloperDay added a comment. Correct follow that description on how to request commit access Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D44609/new/ https://reviews.llvm.org/D44609 ___ cfe-commits

[PATCH] D72827: clang-format: [JS] Handle keyword-named methods.

MyDeveloperDay accepted this revision. MyDeveloperDay added a comment. LGTM thanks for the patch Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72827/new/ https://reviews.llvm.org/D72827 ___ cfe-commits

[PATCH] D72793: [clang-format] Expand the SpacesAroundConditions option to include catch statements

MyDeveloperDay accepted this revision. MyDeveloperDay added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72793/new/ https://reviews.llvm.org/D72793 ___

[PATCH] D72150: Allow space after C-style cast in C# code

This revision was automatically updated to reflect the committed changes. Closed by commit rGd82adf328fb5: Allow space after C-style cast in C# code (authored by MyDeveloperDay). Changed prior to commit: https://reviews.llvm.org/D72150?vs=236048&id=238991#toc Repository: rG LLVM Github Monor

[PATCH] D72276: [clang-format] Add IndentCaseBlocks option

This revision was automatically updated to reflect the committed changes. Closed by commit rG14c044756e77: [clang-format] Add IndentCaseBlocks option (authored by MyDeveloperDay). Changed prior to commit: https://reviews.llvm.org/D72276?vs=236740&id=238992#toc Repository: rG LLVM Github Mono

[PATCH] D72793: [clang-format] Expand the SpacesAroundConditions option to include catch statements

This revision was automatically updated to reflect the committed changes. Closed by commit rGea2be452542c: [clang-format] Expand the SpacesAroundConditions option to include catch… (authored by MyDeveloperDay). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llv

[PATCH] D70926: [clang-format] Add option for not breaking line before ObjC params

MyDeveloperDay requested changes to this revision. MyDeveloperDay added a comment. This revision now requires changes to proceed. I need you to rebase this fix, also you need to clang-format it as well. Format.h/ContinuationIndenter.cpp and FormatTestObjC.cpp all failed clang-format check Repo

[PATCH] D72793: [clang-format] Expand the SpacesAroundConditions option to include catch statements

MyDeveloperDay added a subscriber: hans. MyDeveloperDay added a comment. In D72793#1828625 , @timwoj wrote: > I know that 10.0 was branch recently. Any chance this can make it over? I don't personally ever do this because I only use the snapshot builds.

[PATCH] D71512: [clang-format] Fix short block when braking after control statement

MyDeveloperDay requested changes to this revision. MyDeveloperDay added a comment. This revision now requires changes to proceed. In D71512#1815512 , @Bouska wrote: > Ping @MyDeveloperDay @klimek Comment at: clang/lib/Format/Unwrappe

[PATCH] D44609: [Clang-Format] New option BeforeLambdaBody to manage lambda line break inside function parameter call (in Allman style)

MyDeveloperDay added a comment. Please can you regenerate the ClangFormatStyleOptions.rst using docs/tools/dump_style.py and add an entry into the clang release notes in the clang-format section Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D44609/

[PATCH] D44609: [clang-format] New option BeforeLambdaBody to manage lambda line break inside function parameter call (in Allman style)

MyDeveloperDay added a comment. I think if you can fix the missing documentation it looks pretty good to go. I do like the use of the static functions and the extensive test cases.. thank you. Comment at: clang/lib/Format/ContinuationIndenter.cpp:1442 +// Search for any p

[PATCH] D72911: clang-format: fix spacing in `operator const char*()`

MyDeveloperDay added a comment. @krasimir Thanks for fixing this, as it looks like I broke it.. its much appreciated Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72911/new/ https://reviews.llvm.org/D72911 __

[PATCH] D70926: [clang-format] Add option for not breaking line before ObjC params

MyDeveloperDay added inline comments. Comment at: clang/docs/ReleaseNotes.rst:164 + +- Clang-format now supports JavaScript null operators. + is this line part of this patch? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llv

[PATCH] D72144: Treat C# `using` as a control statement

MyDeveloperDay requested changes to this revision. MyDeveloperDay added a comment. This revision now requires changes to proceed. In D72144#1834265 , @jbcoe wrote: > Removed test snippets that did not exercise new code. Actually i would prefer we didn't

[PATCH] D73354: clang-format: insert trailing commas into containers.

MyDeveloperDay added a comment. I'm a little uncomfortable about all the tests changing, and I'm unsure if we should be changing the default behaviour. The rules in the past here was to show that this is part of a public style guide. The assumption here is google style wants this. Could you ple

[PATCH] D73354: clang-format: insert trailing commas into containers.

MyDeveloperDay added a comment. FYI maybe related D33029: [clang-format] add option for dangling parenthesis Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73354/new/ https://reviews.llvm.org/D73354

[PATCH] D73354: clang-format: insert trailing commas into containers.

MyDeveloperDay added a comment. Nit: Could you add an entry for ReleaseNotes.rst and regenerate the ClangFormatStyleOption.rst with the docs/tools/dump_style.py Comment at: clang/unittests/Format/FormatTestJS.cpp:1229 " (param): param is {\n" -

[PATCH] D73354: clang-format: insert trailing commas into containers.

MyDeveloperDay added inline comments. Comment at: clang/lib/Format/Format.cpp:2531 +}); + auto Env = Ok, this comment is more a discussion point rather than a review comment. Was there a reason you needed to put the TrailingCommaInserter pass after the F

[PATCH] D72326: [clang-format] Rebased on master: Add option to specify explicit config file

MyDeveloperDay added a comment. Nit: please add a release note and regenerate the ClangFormatStyleOptions.rst (if there are any changes because you modified Format.h). Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72326/new/ https://reviews.llvm.org/D72326 __

[PATCH] D73622: [clang-format] Improve support for multiline C# strings

MyDeveloperDay added a comment. these are great patches you are making... Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73622/new/ https://reviews.llvm.org/D73622 ___ cfe-commits mailing list cfe-commi

[PATCH] D73354: clang-format: insert trailing commas into containers.

MyDeveloperDay accepted this revision. MyDeveloperDay added a comment. I'm happy if you are, I think given that you've really been one of the main contributors of clang-format [JS] for the last number of years you are the best person to probably assess the impact on Javascript code. Thanks for

[PATCH] D73354: clang-format: insert trailing commas into containers.

MyDeveloperDay added a comment. Nit: don't forget the ClangFormatStyleOption.rst and ReleaseNote.rst changes Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73354/new/ https://reviews.llvm.org/D73354 ___

[PATCH] D144709: [clang-format] Improve QualifierAlignment

MyDeveloperDay added a comment. In D144709#4188921 , @AlexanderHederstaf wrote: > What is the next step in the process? Anything I should do? If you have commit access you can go ahead and commit, if not and you want one of us to do it, we need your na

[PATCH] D145888: [clang-format] Fix non-case colons in Verilog case lines

MyDeveloperDay added inline comments. Comment at: clang/lib/Format/TokenAnnotator.cpp:4424 -if (Line.First->isOneOf(tok::kw_default, tok::kw_case)) - return Style.SpaceBeforeCaseColon; const FormatToken *Next = Right.getNextNonComment(); Hmm.. this

[PATCH] D125171: Add a new clang-format option AlwaysBreakBeforeFunctionParameters

MyDeveloperDay requested changes to this revision. MyDeveloperDay added inline comments. This revision now requires changes to proceed. Comment at: clang/docs/ClangFormatStyleOptions.rst:1372 +.. _AlwaysBreakBeforeFunctionParameters: + +**AlwaysBreakBeforeFunctionParameters** (``

[PATCH] D146101: [clang-format] Add DesignatedInitializerIndentWidth option.

MyDeveloperDay requested changes to this revision. MyDeveloperDay added inline comments. This revision now requires changes to proceed. Comment at: clang/include/clang/Format/Format.h:2031 + /// }; + /// } + unsigned DesignatedInitializerIndentWidth; End

[PATCH] D146042: [clang-format] Fix numerous issues with "LambdaBodyIndentation: OuterScope" option

MyDeveloperDay requested changes to this revision. MyDeveloperDay added inline comments. This revision now requires changes to proceed. Comment at: clang/docs/ClangFormatStyleOptions.rst:3540 + someMethod(someOtherMethod( + [](SomeReallyLongLambdaSignatureArgume

[PATCH] D146101: [clang-format] Add DesignatedInitializerIndentWidth option.

MyDeveloperDay added inline comments. Comment at: clang/lib/Format/Format.cpp:1372 LLVMStyle.DerivePointerAlignment = false; + LLVMStyle.DesignatedInitializerIndentWidth = 4; LLVMStyle.DisableFormat = false; so lets say someone is using an IndentWidth of 2

[PATCH] D146247: [clang-format] Support TypeScript satisfies operator

MyDeveloperDay added a comment. I would like to see an annotator test just to be sure its getting annotated correctly. apart from that it looks pretty good, would you add this to the release notes please? Comment at: clang/unittests/Format/FormatTestJS.cpp:2186 +TEST_F(Forma

[PATCH] D125171: Add a new clang-format option AlwaysBreakBeforeFunctionParameters

MyDeveloperDay added inline comments. Comment at: clang/docs/ClangFormatStyleOptions.rst:1372 +.. _AlwaysBreakBeforeFunctionParameters: + +**AlwaysBreakBeforeFunctionParameters** (``Boolean``) :versionbadge:`clang-format 16.0` jrmolin wrote: > MyDeveloperDay wro

[PATCH] D146434: [clang-format] Fix support for ObjC blocks with pointer return types

MyDeveloperDay added inline comments. Comment at: clang/unittests/Format/FormatTest.cpp:22178 "});"); - verifyFormat("Block b = ^int *(A *a, B *b) {}"); + verifyFormat("Block b = ^int *(A *a, B *b) {\n" + "};"); I don’t like us cha

[PATCH] D146101: [clang-format] Add DesignatedInitializerIndentWidth option.

MyDeveloperDay added a comment. What I'd really like to see, is... in the event that `IndentWidth` is set and I do NOTset `DesignatedInitializerIndentWidth` , then `DesignatedInitializerIndentWidth` would inherit from that (not the default as you have here), if I set IndentWidth to 3 Design

[PATCH] D146042: [clang-format] Fix numerous issues with "LambdaBodyIndentation: OuterScope" option

MyDeveloperDay added inline comments. Comment at: clang/unittests/Format/FormatTest.cpp:21918-21927 + verifyFormat("Result doSomething(Promise promise) {\n" + " return promise.then(\n" + " [this, obj = std::move(s)](int evaluated) mutable {\n" +

[PATCH] D145435: Choose style (file) from within code for use in IDEs

MyDeveloperDay added a comment. I'm kind of with @owenpan on this one, I don't hate the feature, but I think it goes against the sprit of "clang-format", we are only the custodians here (for now), I don't want to break too much the ethos of the original authors which I think was to help end the

[PATCH] D146501: [clang-format] Don't format already formatted integer literals

MyDeveloperDay added a comment. Do we have any unit tests for this that we can pump a shed load of examples at? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146501/new/ https://reviews.llvm.org/D146501

[PATCH] D146434: [clang-format] Fix support for ObjC blocks with pointer return types

MyDeveloperDay accepted this revision. MyDeveloperDay added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146434/new/ https://reviews.llvm.org/D146434 ___

[PATCH] D146403: [clang-format] More work on space around operators in Verilog

MyDeveloperDay accepted this revision. MyDeveloperDay added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146403/new/ https://reviews.llvm.org/D146403 ___

[PATCH] D146401: [clang-format] Don't squash Verilog escaped identifiers

MyDeveloperDay added inline comments. Comment at: clang/unittests/Format/FormatTestVerilog.cpp:897 } +} // namespace +} // namespace test is this correct? do you have an anonymous namespace? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION ht

[PATCH] D146247: [clang-format] Support TypeScript satisfies operator

MyDeveloperDay added a comment. 1. your diff is messed up 2. you have to get an accept before anyone will commit for you. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146247/new/ https://reviews.llvm.org/D146247 __

[PATCH] D146247: [clang-format] Support TypeScript satisfies operator

MyDeveloperDay added a comment. Can you add a github issue and reference it here Comment at: clang/unittests/Format/TokenAnnotatorTest.cpp:1445 + EXPECT_TOKEN(Tokens[3], tok::identifier, TT_Unknown); + EXPECT_TOKEN(Tokens[4], tok::identifier, TT_StartOfName); + EXPECT_TOKEN(

[PATCH] D145813: [clang-format] Respect Cpp11BraceListStyle when aligning array of structures

MyDeveloperDay added inline comments. Comment at: clang/unittests/Format/FormatTest.cpp:20273 + Style.ColumnLimit = 20; + EXPECT_EQ( + "demo = std::array<\n" hch12907 wrote: > MyDeveloperDay wrote: > > any reason you didn't use verifyFormat here? > No part

[PATCH] D144170: [clang-format] Add simple macro replacements in formatting.

MyDeveloperDay added a comment. I know this is like "telling my grandmother to suck eggs" but @klimek the change here to Format.h means you need to regenerate ClangFormatStyleOptions.rst via docs/tools/dump_format_style.py Impacting the next change to generate - D125171: Add a new clang-format

[PATCH] D125171: Add a new clang-format option AlwaysBreakBeforeFunctionParameters

MyDeveloperDay added inline comments. Comment at: clang/docs/ClangFormatStyleOptions.rst:3663 +.. _Macros: + jrmolin wrote: > I didn't modify this section in the header at all. I assume someone modified > the Format.h file and didn't update the docs. that need

[PATCH] D146704: [clang-format] NFC Format.h and ClangFormatStyleOptions.rst are out of date

MyDeveloperDay created this revision. MyDeveloperDay added reviewers: klimek, owenpan, HazardyKnusperkeks, rymiel. MyDeveloperDay added a project: clang-format. Herald added a project: All. MyDeveloperDay requested review of this revision. Herald added a project: clang. Regenerate the style docume

[PATCH] D146704: [clang-format] NFC Format.h and ClangFormatStyleOptions.rst are out of date

MyDeveloperDay added a comment. This is a missed change as part of D144170: [clang-format] Add simple macro replacements in formatting. and as this is NFC and its blocking other reviews I'm going to go ahead and commit, but I'm passing this by your eyes and I'

[PATCH] D146704: [clang-format] NFC Format.h and ClangFormatStyleOptions.rst are out of date

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG7a5b95732ade: [clang-format] NFC Format.h and ClangFormatStyleOpti

[PATCH] D125171: Add a new clang-format option AlwaysBreakBeforeFunctionParameters

MyDeveloperDay added a comment. if you go ahead an rebase your should get rG7a5b95732ade: [clang-format] NFC Format.h and ClangFormatStyleOptions.rst are out of date that will remove the need for the Macro section in the rst

[PATCH] D146704: [clang-format] NFC Format.h and ClangFormatStyleOptions.rst are out of date

MyDeveloperDay updated this revision to Diff 507666. MyDeveloperDay added a comment. Ok it seems a fix has already been landed but its not correct (missing version) CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146704/new/ https://reviews.llvm.org/D146704 Files: clang/docs/ClangForma

[PATCH] D146704: [clang-format] NFC Format.h and ClangFormatStyleOptions.rst are out of date

MyDeveloperDay updated this revision to Diff 507668. MyDeveloperDay added a comment. incorrect yaml code block CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146704/new/ https://reviews.llvm.org/D146704 Files: clang/docs/ClangFormatStyleOptions.rst Index: clang/docs/ClangFormatStyle

[PATCH] D146704: [clang-format] NFC Format.h and ClangFormatStyleOptions.rst are out of date

MyDeveloperDay updated this revision to Diff 507670. MyDeveloperDay added a comment. I've got out of practice... correct the diff properly CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146704/new/ https://reviews.llvm.org/D146704 Files: clang/docs/ClangFormatStyleOptions.rst clang/

[PATCH] D125171: Add a new clang-format option AlwaysBreakBeforeFunctionParameters

MyDeveloperDay added a comment. Please rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125171/new/ https://reviews.llvm.org/D125171 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://li

[PATCH] D146704: [clang-format] NFC Format.h and ClangFormatStyleOptions.rst are out of date

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGb94175b0ee57: [clang-format] NFC Format.h and ClangFormatStyleOptions.rst are out of date (authored by MyDeveloperDay). Repository: rG LLVM Github

[PATCH] D146895: [clang-format] Don't annotate left brace of struct as FunctionLBrace

MyDeveloperDay accepted this revision. MyDeveloperDay added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146895/new/ https://reviews.llvm.org/D146895 ___

[PATCH] D146926: [clang-format] Add option to decorate reflowed block comments

MyDeveloperDay added a comment. You need to regenerate the documentation after changing Format.h Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146926/new/ https://reviews.llvm.org/D146926 ___ cfe-commits

[PATCH] D146926: [clang-format] Add option to decorate reflowed block comments

MyDeveloperDay added a comment. You need to add unit tests Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146926/new/ https://reviews.llvm.org/D146926 ___ cfe-commits mailing list cfe-commits@lists.llvm.o

[PATCH] D146926: [clang-format] Add option to decorate reflowed block comments

MyDeveloperDay added a comment. no you need to run clang/doc/tools/dump_format_style.py This will regnerate ClangFormatStyleOptions.rst from the Format.h change you have here, you then need to include that rst file in the review Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D146926: [clang-format] Add option to decorate reflowed block comments

MyDeveloperDay added inline comments. Comment at: clang/include/clang/Format/Format.h:2022 + /// \version 17 + bool DecorateReflowedComments; + you are not setting the default value for this so it could be uninitialized, you need to set that in the LLVMStyle s

[PATCH] D144709: [clang-format] Improve QualifierAlignment

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGcd7ab4b5c168: [clang-format] Improve QualifierAlignment (authored by AlexanderHederstaf, committed by MyDeveloperDay). Changed prior to commit: ht

[PATCH] D147003: [clang-format] JSON Add ability to add a space before the colon

MyDeveloperDay created this revision. MyDeveloperDay added reviewers: owenpan, HazardyKnusperkeks, rymiel. MyDeveloperDay added projects: clang, clang-format. Herald added a project: All. MyDeveloperDay requested review of this revision. I've seen a couple of request for extra Json formatting to m

[PATCH] D146844: [clang-format] Handle '_' in ud-suffix for IntegerLiteralSeparator

MyDeveloperDay accepted this revision. MyDeveloperDay added a comment. This revision is now accepted and ready to land. I'm not going to use it, but I like what you've done ;-) CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146844/new/ https://reviews.llvm.org/D146844 __

[PATCH] D147003: [clang-format] JSON Add ability to add a space before the colon

MyDeveloperDay marked an inline comment as done. MyDeveloperDay added inline comments. Comment at: clang/lib/Format/TokenAnnotator.cpp:4155 if (Right.is(tok::colon)) - return false; + return Style.SpaceBeforeJsonColon; } else if (Style.isCSharp()) {

[PATCH] D144709: [clang-format] Improve left to right const

MyDeveloperDay added a comment. when I originally did this work, I checked out the whole fresh area of LLVM and applied the both east then back to west const and built both to ensure I didn't break anything. Please ensure you do the same, I'm going to be honest you are changing it massively, I

[PATCH] D144709: [clang-format] Improve left to right const

MyDeveloperDay added a comment. can you rebase please Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144709/new/ https://reviews.llvm.org/D144709 ___ cfe-commits mailing list cfe-commits@lists.llvm.org ht

[PATCH] D144709: [clang-format] Improve QualifierAlignment

MyDeveloperDay added a comment. As tests currently fail can you set it to "planned changes" until they pass [ FAILED ] 5 tests, listed below: [ FAILED ] QualifierFixerTest.RightQualifier [ FAILED ] QualifierFixerTest.LeftQualifier [ FAILED ] QualifierFixerTest.ConstVolatileQualifi

[PATCH] D144884: [clang-format] Only add pragma continuation indentation for 'omp' clauses

MyDeveloperDay added inline comments. Comment at: clang/lib/Format/ContinuationIndenter.cpp:1280 +FormatToken *PragmaType = State.Line->First->Next->Next; +if (PragmaType && PragmaType->TokenText.equals("omp")) + return CurrentState.Indent + Style.ContinuationIndentW

[PATCH] D144884: [clang-format] Only add pragma continuation indentation for 'omp' clauses

MyDeveloperDay added a comment. without this change what does this look like? EXPECT_EQ( "#pragma omp target \\\n" "reduction(+ : var) \\\n" "map(to : A[0 : N]) \\\n" "map(to : B[0 : N]) \\\n" "map(from : C[0 : N]) \\\n" "first

[PATCH] D144709: [clang-format] Improve QualifierAlignment

MyDeveloperDay accepted this revision. MyDeveloperDay added a comment. This revision is now accepted and ready to land. Firstly let me say thank you for this review, your perseverance demonstrates to me that there is a desire to make this capability better, which tells me that a feature that ult

[PATCH] D144709: [clang-format] Improve QualifierAlignment

MyDeveloperDay added a comment. In D144709#4169219 , @rymiel wrote: > This patch also fixes: https://github.com/llvm/llvm-project/issues/56111, > https://github.com/llvm/llvm-project/issues/58696, and > https://github.com/llvm/llvm-project/issues/54730

[PATCH] D144709: [clang-format] Improve QualifierAlignment

MyDeveloperDay accepted this revision. MyDeveloperDay added a comment. I might have been tempted to handle the comments in a separate commit, I don't like to do too much in one go or the review gets hard to manage. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://revie

[PATCH] D145344: [clang-format] Don't annotate left brace of class as FunctionLBrace

MyDeveloperDay accepted this revision. MyDeveloperDay added a comment. This revision is now accepted and ready to land. Thanks for this, LGTM (maybe we can cherry pick this to 16.0) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145344/new/ https://

[PATCH] D145344: [clang-format] Don't annotate left brace of class as FunctionLBrace

MyDeveloperDay added a comment. The upshot of this is better TT_FunctionLBrace/TT_ClassLBrace detection, which is great becuase if a class `{` or function `{` is incorrectly detected we are then in unknown territory as to how it might become formatted, since you introduced these Annotator test

[PATCH] D145435: Choose style (file) from within code for use in IDEs

MyDeveloperDay added a comment. This is going to need unit tests A full context diff Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145435/new/ https://reviews.llvm.org/D145435 ___ cfe-commits mailing lis

[PATCH] D145813: [clang-format] Respect Cpp11BraceListStyle when aligning array of structures

MyDeveloperDay added inline comments. Comment at: clang/unittests/Format/FormatTest.cpp:20273 + Style.ColumnLimit = 20; + EXPECT_EQ( + "demo = std::array<\n" any reason you didn't use verifyFormat here? Repository: rG LLVM Github Monorepo CHANGES SINC

[PATCH] D153205: [clang-format] Add new block type ListInit

MyDeveloperDay added inline comments. Comment at: clang/lib/Format/FormatToken.cpp:79 bool FormatToken::opensBlockOrBlockTypeList(const FormatStyle &Style) const { + auto bk = getBlockKind(); // C# Does not indent object initialisers as continuations. Hazard

[PATCH] D153205: [clang-format] Add new block type ListInit

MyDeveloperDay added inline comments. Comment at: clang/unittests/Format/FormatTest.cpp:25511 + // Designated initializers. + verifyFormat("int LongVariable[1] = {\n" + "[0] = 1000, [1] = 2000\n" nit [2] Repos

[PATCH] D153205: [clang-format] Add new block type ListInit

MyDeveloperDay added a comment. In principle I like this as its annoyed me for years Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153205/new/ https://reviews.llvm.org/D153205 ___ cfe-commits mailing lis

[PATCH] D153338: [clang-format] vim integration: Mention python3 variant of bindings

MyDeveloperDay accepted this revision. MyDeveloperDay added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153338/new/ https://reviews.llvm.org/D153338 ___

[PATCH] D153205: [clang-format] Add new block type ListInit

MyDeveloperDay added a comment. My only concern is that this changes behaviour without someone making the conscious decision to make that change, now as much as I can't understand why someone would want to put the `}` onto the same line, it will only take on person to say "hey I liked it like t

[PATCH] D152975: [clang-format] Allow break after return keyword

MyDeveloperDay added inline comments. Comment at: clang/lib/Format/Format.cpp:1484 LLVMStyle.PenaltyBreakFirstLessLess = 120; + LLVMStyle.PenaltyBreakReturn = 100; LLVMStyle.PenaltyBreakString = 1000; is 100 the current penalty? Comment

[PATCH] D153228: [clang-format] Fixed bad performance with enabled qualifier fixer.

MyDeveloperDay accepted this revision. MyDeveloperDay added a comment. Thank you for the detailed analysis Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153228/new/ https://reviews.llvm.org/D153228 ___ c

[PATCH] D153585: [clang-format] Fix align consecutive declarations over function pointers

MyDeveloperDay added a comment. Can you reference the GitHub bug Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153585/new/ https://reviews.llvm.org/D153585 ___ cfe-commits mailing list cfe-commits@lists.

[PATCH] D153228: [clang-format] Fixed bad performance with enabled qualifier fixer.

MyDeveloperDay added a comment. For us to land this for you we'll need your name and email Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153228/new/ https://reviews.llvm.org/D153228 ___ cfe-commits maili

[PATCH] D89918: Fix issue: clang-format result is not consistent if "// clang-format off" is followed by macro definition.

MyDeveloperDay added a subscriber: aaron.ballman. MyDeveloperDay added a comment. @owenpan @HazardyKnusperkeks @rymiel what are your feeling on how we should close old clang-format reviews like this? (@aaron.ballman any thoughts on how it should be done?) we end up with lots of reviews that ei

[PATCH] D154091: [clang-format] Prefer breaking long strings at new lines

MyDeveloperDay added a comment. is there a git issue for this, I'm struggling to understand the problem we are solving. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154091/new/ https://reviews.llvm.org/D154091 ___

[PATCH] D147176: [clang-format] NFC ensure Style operator== remains sorted for ease of editing

MyDeveloperDay created this revision. MyDeveloperDay added reviewers: HazardyKnusperkeks, owenpan. MyDeveloperDay added projects: clang-format, clang. Herald added a project: All. MyDeveloperDay requested review of this revision. D144170: [clang-format] Add simple macro replacements in formatting.

[PATCH] D147003: [clang-format] JSON Add ability to add a space before the colon

MyDeveloperDay updated this revision to Diff 509439. MyDeveloperDay marked 2 inline comments as done. MyDeveloperDay added a comment. add missing unit test let's go defensive on the JsColon detection CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147003/new/ https://reviews.llvm.org/D147

[PATCH] D147003: [clang-format] JSON Add ability to add a space before the colon

MyDeveloperDay added inline comments. Comment at: clang/lib/Format/TokenAnnotator.cpp:4155 if (Right.is(tok::colon)) - return false; + return Style.SpaceBeforeJsonColon; } else if (Style.isCSharp()) { owenpan wrote: > MyDeveloperDay wrote: > > o

[PATCH] D147176: [clang-format] NFC ensure Style operator== remains sorted for ease of editing

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG07616c5db0cd: [clang-format] NFC ensure Style operator== remains sorted for ease of editing (authored by MyDeveloperDay). Repository: rG LLVM Gith

[PATCH] D147003: [clang-format] JSON Add ability to add a space before the colon

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGaf98f3b1f4db: [clang-format] JSON Add ability to add a space before the colon (authored by MyDeveloperDay). Repository: rG LLVM Github Monorepo C

<    14   15   16   17   18   19   20   21   22   23   >