[PATCH] D76300: [ARM,CDE] Implement CDE vreinterpret intrinsics

2020-03-17 Thread Mikhail Maltsev via Phabricator via cfe-commits
miyuki created this revision. miyuki added reviewers: simon_tatham, MarkMurrayARM, dmgreen, ostannard. Herald added subscribers: cfe-commits, danielkiss, kristof.beyls. Herald added a project: clang. miyuki added a parent revision: D76299: [ARM,CDE] Implement CDE unpredicated Q-register intrinsics

[PATCH] D76296: [ARM,CDE] Implement GPR CDE intrinsics

2020-03-17 Thread Mikhail Maltsev via Phabricator via cfe-commits
miyuki updated this revision to Diff 250848. miyuki added a comment. Fixed formatting and a clang-tidy warning. Not renaming `SelectCDE_CXxD` (as clang-tidy suggests) for consistency with other `Select*` methods. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76296/new/ https://reviews.

[PATCH] D76298: [ARM,CDE] Implement CDE S and D-register intrinsics

2020-03-18 Thread Mikhail Maltsev via Phabricator via cfe-commits
miyuki updated this revision to Diff 251038. miyuki added a comment. Fixed formatting CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76298/new/ https://reviews.llvm.org/D76298 Files: clang/include/clang/Basic/arm_cde.td clang/test/CodeGen/arm-cde-vfp.c clang/test/Sema/arm-cde-imme

[PATCH] D76299: [ARM,CDE] Implement CDE unpredicated Q-register intrinsics

2020-03-18 Thread Mikhail Maltsev via Phabricator via cfe-commits
miyuki updated this revision to Diff 251039. miyuki added a comment. Fixed formatting. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76299/new/ https://reviews.llvm.org/D76299 Files: clang/include/clang/Basic/arm_cde.td clang/test/CodeGen/arm-cde-vec.c clang/test/Sema/arm-cde-imm

[PATCH] D76359: [ARM,MVE] Add intrinsics for the VQDMLAD family.

2020-03-18 Thread Mikhail Maltsev via Phabricator via cfe-commits
miyuki accepted this revision. miyuki added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76359/new/ https://reviews.llvm.org/D76359 ___

[PATCH] D76299: [ARM,CDE] Implement CDE unpredicated Q-register intrinsics

2020-03-20 Thread Mikhail Maltsev via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rG969034b86037: [ARM,CDE] Implement CDE unpredicated Q-register intrinsics (authored by miyuki). Changed prior to commit: https://reviews.llvm.org/D76299?vs=251039&id=251635#toc Repository: rG LLVM Git

[PATCH] D76298: [ARM,CDE] Implement CDE S and D-register intrinsics

2020-03-20 Thread Mikhail Maltsev via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rGd22e66171251: [ARM,CDE] Implement CDE S and D-register intrinsics (authored by miyuki). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76298/new/ https://rev

[PATCH] D76300: [ARM,CDE] Implement CDE vreinterpret intrinsics

2020-03-20 Thread Mikhail Maltsev via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rG6ae3eff8baac: [ARM,CDE] Implement CDE vreinterpret intrinsics (authored by miyuki). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76300/new/ https://reviews

[PATCH] D76296: [ARM,CDE] Implement GPR CDE intrinsics

2020-03-20 Thread Mikhail Maltsev via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rG7a85e3585ec5: [ARM,CDE] Implement GPR CDE intrinsics (authored by miyuki). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76296/new/ https://reviews.llvm.org

[PATCH] D73906: [ARM] Make ARM::ArchExtKind use 64-bit underlying type, NFCI

2020-02-03 Thread Mikhail Maltsev via Phabricator via cfe-commits
miyuki created this revision. miyuki added reviewers: simon_tatham, eli.friedman, ostannard, dmgreen. Herald added subscribers: llvm-commits, cfe-commits, hiraditya, kristof.beyls. Herald added projects: clang, LLVM. This patch changes the underlying type of the ARM::ArchExtKind enumeration to uin

[PATCH] D73906: [ARM] Make ARM::ArchExtKind use 64-bit underlying type, NFCI

2020-02-03 Thread Mikhail Maltsev via Phabricator via cfe-commits
miyuki updated this revision to Diff 242114. miyuki added a comment. Fix one missing unsigned->uint64_t occurrence CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73906/new/ https://reviews.llvm.org/D73906 Files: clang/lib/Basic/Targets/ARM.cpp clang/lib/Driver/ToolChains/Arch/ARM.cp

[PATCH] D73906: [ARM] Make ARM::ArchExtKind use 64-bit underlying type, NFCI

2020-02-04 Thread Mikhail Maltsev via Phabricator via cfe-commits
miyuki updated this revision to Diff 242277. miyuki added a comment. More missing unsigned->uint64_t changes, removed a redundant `getAEKID` function (identical to `parseArchExt`). CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73906/new/ https://reviews.llvm.org/D73906 Files: clang/

[PATCH] D73906: [ARM] Make ARM::ArchExtKind use 64-bit underlying type, NFCI

2020-02-04 Thread Mikhail Maltsev via Phabricator via cfe-commits
miyuki added a comment. In D73906#1856615 , @simon_tatham wrote: > I wonder if it's worth temporarily redefining all the existing `AEK_FOO` ids > to values that don't fit in 32 bits, and making sure the whole test suite > still passes. That should catch

[PATCH] D73906: [ARM] Make ARM::ArchExtKind use 64-bit underlying type, NFCI

2020-02-04 Thread Mikhail Maltsev via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rG7128aace600f: [ARM] Make ARM::ArchExtKind use 64-bit underlying type, NFCI (authored by miyuki). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73906/new/ ht

[PATCH] D74044: [ARM] Add initial support for Custom Datapath Extension (CDE)

2020-02-05 Thread Mikhail Maltsev via Phabricator via cfe-commits
miyuki created this revision. miyuki added reviewers: simon_tatham, ostannard, dmgreen, eli.friedman. Herald added subscribers: llvm-commits, cfe-commits, hiraditya, kristof.beyls. Herald added projects: clang, LLVM. This patch adds assembly-level support for a new Arm M-profile architecture exten

[PATCH] D74134: [ARM][MVE] Add fixed point vector conversion intrinsics

2020-02-06 Thread Mikhail Maltsev via Phabricator via cfe-commits
miyuki created this revision. miyuki added reviewers: simon_tatham, ostannard, MarkMurrayARM, dmgreen. Herald added subscribers: llvm-commits, cfe-commits, hiraditya, kristof.beyls. Herald added projects: clang, LLVM. This patch implements the following Arm ACLE MVE intrinsics: - vcvtq_n_* - vcvt

[PATCH] D74134: [ARM][MVE] Add fixed point vector conversion intrinsics

2020-02-06 Thread Mikhail Maltsev via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rG2694cc3dca94: [ARM][MVE] Add fixed point vector conversion intrinsics (authored by miyuki). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74134/new/ https:/

[PATCH] D74333: [ARM,MVE] Add intrinsics for FP rounding operations.

2020-02-11 Thread Mikhail Maltsev via Phabricator via cfe-commits
miyuki added a comment. > vrintn behaves the same as vrintx vrintx is not mentioned anywhere in the patch. Should it say "llvm.rint" instead? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74333/new/ https://reviews.llvm.org/D74333

[PATCH] D74044: [ARM] Add initial support for Custom Datapath Extension (CDE)

2020-02-11 Thread Mikhail Maltsev via Phabricator via cfe-commits
miyuki updated this revision to Diff 243902. miyuki added a comment. Added IT and VPT predication. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74044/new/ https://reviews.llvm.org/D74044 Files: clang/test/Driver/arm-cde.c llvm/include/llvm/Support/ARMTargetParser.def llvm/includ

[PATCH] D74335: [ARM,MVE] Add intrinsics vclzq and vclsq.

2020-02-12 Thread Mikhail Maltsev via Phabricator via cfe-commits
miyuki accepted this revision. miyuki added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74335/new/ https://reviews.llvm.org/D74335 ___

[PATCH] D74620: [ARM,MVE] Add vector-scalar intrinsics

2020-02-14 Thread Mikhail Maltsev via Phabricator via cfe-commits
miyuki added a comment. I would prefer not to format the Clang test cases to avoid code churn. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74620/new/ https://reviews.llvm.org/D74620 ___ cfe-commits m

[PATCH] D74620: [ARM,MVE] Add vector-scalar intrinsics

2020-02-17 Thread Mikhail Maltsev via Phabricator via cfe-commits
miyuki marked an inline comment as done. miyuki added inline comments. Comment at: clang/test/CodeGen/arm-mve-intrinsics/vaddq.c:2 // NOTE: Assertions have been autogenerated by utils/update_cc_test_checks.py -// RUN: %clang_cc1 -triple thumbv8.1m.main-arm-none-eabi -target-feat

[PATCH] D74044: [ARM] Add initial support for Custom Datapath Extension (CDE)

2020-02-17 Thread Mikhail Maltsev via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rGdd4d09376209: [ARM] Add initial support for Custom Datapath Extension (CDE) (authored by miyuki). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74044/new/ h

[PATCH] D74721: [ARM,MVE] Add vbrsrq intrinsics family

2020-02-17 Thread Mikhail Maltsev via Phabricator via cfe-commits
miyuki created this revision. miyuki added reviewers: simon_tatham, dmgreen, ostannard, MarkMurrayARM. Herald added subscribers: llvm-commits, cfe-commits, hiraditya, kristof.beyls. Herald added projects: clang, LLVM. miyuki added a parent revision: D74620: [ARM,MVE] Add vector-scalar intrinsics.

[PATCH] D74044: [ARM] Add initial support for Custom Datapath Extension (CDE)

2020-02-17 Thread Mikhail Maltsev via Phabricator via cfe-commits
miyuki added a comment. @SjoerdMeijer, thanks for the heads up. Will fix in a followup patch. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74044/new/ https://reviews.llvm.org/D74044 ___ cfe-commits ma

[PATCH] D74732: [ARM,CDE] Cosmetic changes, additonal driver tests

2020-02-17 Thread Mikhail Maltsev via Phabricator via cfe-commits
miyuki created this revision. miyuki added reviewers: SjoerdMeijer, simon_tatham, dmgreen. Herald added subscribers: llvm-commits, cfe-commits, hiraditya, kristof.beyls. Herald added projects: clang, LLVM. This is a follow-up patch addressing post-commit comments in https://reviews.llvm.org/D74044

[PATCH] D74732: [ARM,CDE] Cosmetic changes, additonal driver tests

2020-02-18 Thread Mikhail Maltsev via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rG58f66f8af01d: [ARM,CDE] Cosmetic changes, additonal driver tests (authored by miyuki). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74732/new/ https://revi

[PATCH] D74721: [ARM,MVE] Add vbrsrq intrinsics family

2020-02-18 Thread Mikhail Maltsev via Phabricator via cfe-commits
miyuki updated this revision to Diff 245187. miyuki added a comment. Rebased on master CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74721/new/ https://reviews.llvm.org/D74721 Files: clang/include/clang/Basic/arm_mve.td clang/test/CodeGen/arm-mve-intrinsics/vbrsrq.c llvm/include/

[PATCH] D74721: [ARM,MVE] Add vbrsrq intrinsics family

2020-02-18 Thread Mikhail Maltsev via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rG63809d365e56: [ARM,MVE] Add vbrsrq intrinsics family (authored by miyuki). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74721/new/ https://reviews.llvm.org

[PATCH] D69840: [Basic] Make SourceLocation usable as key in hash maps, NFCI

2020-01-17 Thread Mikhail Maltsev via Phabricator via cfe-commits
miyuki added a comment. ping^4 CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69840/new/ https://reviews.llvm.org/D69840 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D70183: Detect source location overflow due includes

2020-01-17 Thread Mikhail Maltsev via Phabricator via cfe-commits
miyuki accepted this revision. miyuki added a comment. This revision is now accepted and ready to land. LGTM, but since we both work at Arm, let's wait a week for other folks to chime in if they have any objections. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://revi

[PATCH] D44783: [Targets] Adjust ARM data layout

2018-03-22 Thread Mikhail Maltsev via Phabricator via cfe-commits
miyuki created this revision. miyuki added a reviewer: hfinkel. Herald added subscribers: kristof.beyls, javed.absar, dschuff. The DataLayout structure now includes function pointer alignment, on ARM targets it is set to 8 bits. The front end needs to be adjusted to produce matching data layout st

[PATCH] D45255: [CodeGen] Add an option to suppress output of llvm.ident

2018-04-04 Thread Mikhail Maltsev via Phabricator via cfe-commits
miyuki created this revision. miyuki added a reviewer: faisalv. Herald added subscribers: JDevlieghere, aprantl. By default Clang outputs its version (including git commit hash, in case of trunk builds) into object and assembly files. It might be useful to have an option to disable this, especiall

[PATCH] D45255: [CodeGen] Add an option to suppress output of llvm.ident

2018-04-11 Thread Mikhail Maltsev via Phabricator via cfe-commits
miyuki added a comment. ping https://reviews.llvm.org/D45255 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D149458: [Driver] Pass --target2= to linker from baremetal toolchain

2023-04-28 Thread Mikhail Maltsev via Phabricator via cfe-commits
miyuki created this revision. miyuki added reviewers: peter.smith, phosek, michaelplatings. Herald added subscribers: abidh, kristof.beyls. Herald added a project: All. miyuki requested review of this revision. Herald added subscribers: cfe-commits, MaskRay. Herald added a project: clang. Accordin

[PATCH] D149458: [Driver] Pass --target2= to linker from baremetal toolchain

2023-04-28 Thread Mikhail Maltsev via Phabricator via cfe-commits
This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG024bb62ffd07: [Driver] Pass --target2= to linker from baremetal toolchain (authored by miyuki). Repository: rG LLVM Github Monorepo CHANGES SINCE

[PATCH] D41992: [libcxx] Avoid spurious construction of valarray elements

2018-01-12 Thread Mikhail Maltsev via Phabricator via cfe-commits
miyuki created this revision. miyuki added reviewers: EricWF, mclow.lists. Currently libc++ implements some operations on valarray by using the resize method. This method has a parameter with a default value. Because of this, valarray may spuriously construct and destruct objects of valarray's ele

[PATCH] D41629: [libcxx] Improve accuracy of complex asinh and acosh

2018-01-15 Thread Mikhail Maltsev via Phabricator via cfe-commits
miyuki added a comment. ping https://reviews.llvm.org/D41629 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D41179: [Sema] Diagnose template specializations with C linkage

2018-01-15 Thread Mikhail Maltsev via Phabricator via cfe-commits
miyuki added a comment. ping^2 https://reviews.llvm.org/D41179 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D41992: [libcxx] Avoid spurious construction of valarray elements

2018-01-19 Thread Mikhail Maltsev via Phabricator via cfe-commits
miyuki added a comment. ping https://reviews.llvm.org/D41992 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D42291: [libcxx] Correctly handle invalid regex character class names

2018-01-19 Thread Mikhail Maltsev via Phabricator via cfe-commits
miyuki created this revision. miyuki added reviewers: EricWF, mclow.lists. Currently when a regular expression contains an invalid character class name std::regex constructors throw an std::regex_error with std::regex_constants::error_brack code. This patch changes the code to std::regex_constant

[PATCH] D41629: [libcxx] Improve accuracy of complex asinh and acosh

2018-01-23 Thread Mikhail Maltsev via Phabricator via cfe-commits
miyuki added a comment. ping^2 https://reviews.llvm.org/D41629 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D42291: [libcxx] Correctly handle invalid regex character class names

2018-01-24 Thread Mikhail Maltsev via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rCXX323322: [libcxx] Correctly handle invalid regex character class names (authored by miyuki, committed by ). Repository: rCXX libc++ https://reviews.llvm.org/D42291 Files: include/regex test/std/r

[PATCH] D42291: [libcxx] Correctly handle invalid regex character class names

2018-01-24 Thread Mikhail Maltsev via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL323322: [libcxx] Correctly handle invalid regex character class names (authored by miyuki, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.llvm.org/D422

[PATCH] D42545: [Sema] Classify conversions from enum to float as narrowing

2018-01-25 Thread Mikhail Maltsev via Phabricator via cfe-commits
miyuki created this revision. miyuki added reviewers: faisalv, rsmith. According to [dcl.init.list]p7: A narrowing conversion is an implicit conversion - ... - from an integer type or unscoped enumeration type to a floating-point type, except where the source is a constant expressio

[PATCH] D41992: [libcxx] Avoid spurious construction of valarray elements

2018-01-26 Thread Mikhail Maltsev via Phabricator via cfe-commits
miyuki added a comment. ping^2 https://reviews.llvm.org/D41992 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D42693: [libcxx] Handle invalid escaped characters in POSIX regex

2018-01-30 Thread Mikhail Maltsev via Phabricator via cfe-commits
miyuki created this revision. miyuki added reviewers: EricWF, mclow.lists. Currently when parsing basic POSIX regular expressions libc++ silently skips invalid escaped characters and trailing escapes. This patch changes the behavior, so that a std::regex_error with code set to error_escape is thro

[PATCH] D42693: [libcxx] Handle invalid escaped characters in POSIX regex

2018-01-31 Thread Mikhail Maltsev via Phabricator via cfe-commits
miyuki added inline comments. Comment at: include/regex:3465 +case '{': +case '}': +break; Quuxplusone wrote: > FWIW, I don't understand what's going on in this switch. > Is it intentional that `'('` and `'|'` now take diff

[PATCH] D42693: [libcxx] Handle invalid escaped characters in POSIX regex

2018-02-01 Thread Mikhail Maltsev via Phabricator via cfe-commits
miyuki updated this revision to Diff 132352. miyuki edited the summary of this revision. miyuki added a comment. Updated __parse_QUOTED_CHAR_ERE. Added more test cases. https://reviews.llvm.org/D42693 Files: include/regex test/std/re/re.regex/re.regex.construct/bad_escape.pass.cpp Index: t

[PATCH] D42693: [libcxx] Handle invalid escaped characters in POSIX regex

2018-02-01 Thread Mikhail Maltsev via Phabricator via cfe-commits
miyuki added inline comments. Comment at: include/regex:3490 { switch (*__temp) { mclow.lists wrote: > Do we need any more cases here? Probably not, but we should throw an exception here as well. https://reviews.ll

[PATCH] D94224: [clang][AST] Get rid of an alignment hack in DeclObjC.h [NFCI]

2021-01-07 Thread Mikhail Maltsev via Phabricator via cfe-commits
miyuki created this revision. miyuki added reviewers: dexonsmith, aprantl. miyuki requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This patch utilizes the `alignas` specifier and removes the workaround which used a union object for the same

[PATCH] D94231: [clang][Sema] Compare SourceLocations directly [NFCI]

2021-01-07 Thread Mikhail Maltsev via Phabricator via cfe-commits
miyuki created this revision. miyuki added reviewers: dexonsmith, aprantl, rsmith. miyuki requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. The ordered comparison operators are defined for the SourceLocation class, so SourceLocation objects c

[PATCH] D94224: [clang][AST] Get rid of an alignment hack in DeclObjC.h [NFCI]

2021-01-07 Thread Mikhail Maltsev via Phabricator via cfe-commits
miyuki updated this revision to Diff 315113. miyuki added a comment. Fixed formatting. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D94224/new/ https://reviews.llvm.org/D94224 Files: clang/include/clang/AST/DeclObjC.h clang/lib/AST/DeclObjC.cp

[PATCH] D94237: [clang] Use SourceLocations in unions

2021-01-07 Thread Mikhail Maltsev via Phabricator via cfe-commits
miyuki created this revision. miyuki added reviewers: dexonsmith, aprantl, rsmith. Herald added a subscriber: jfb. miyuki requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Currently, there are many instances where `SourceLocation` objects are

[PATCH] D94231: [clang][Sema] Compare SourceLocations directly [NFCI]

2021-01-09 Thread Mikhail Maltsev via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rG9f76788b0930: [clang][Sema] Compare SourceLocations directly [NFCI] (authored by miyuki). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D94231/new/ https://r

[PATCH] D94224: [clang][AST] Get rid of an alignment hack in DeclObjC.h [NFCI]

2021-01-09 Thread Mikhail Maltsev via Phabricator via cfe-commits
miyuki updated this revision to Diff 315601. miyuki edited the summary of this revision. miyuki added a comment. Removed alignas Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D94224/new/ https://reviews.llvm.org/D94224 Files: clang/include/clang/

[PATCH] D94224: [clang][AST] Get rid of an alignment hack in DeclObjC.h [NFCI]

2021-01-11 Thread Mikhail Maltsev via Phabricator via cfe-commits
miyuki added inline comments. Comment at: clang/include/clang/AST/DeclObjC.h:660 + /// Location of the left and right angle brackets. + alignas(ObjCTypeParamDecl *) SourceRange Brackets; /// The number of parameters in the list, which are tail-allocated. apr

[PATCH] D94237: [clang] Use SourceLocations in unions [NFCI]

2021-01-11 Thread Mikhail Maltsev via Phabricator via cfe-commits
miyuki updated this revision to Diff 315759. miyuki added a comment. Fixed a typo in the word "implicit" Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D94237/new/ https://reviews.llvm.org/D94237 Files: clang/include/clang/AST/DependentDiagnostic.

[PATCH] D94224: [clang][AST] Get rid of an alignment hack in DeclObjC.h [NFCI]

2021-01-12 Thread Mikhail Maltsev via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rGc1e08f0073e3: [clang][AST] Get rid of an alignment hack in DeclObjC.h [NFCI] (authored by miyuki). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D94224/new/

[PATCH] D94237: [clang] Use SourceLocations in unions [NFCI]

2021-01-13 Thread Mikhail Maltsev via Phabricator via cfe-commits
miyuki added a comment. In D94237#2493844 , @dblaikie wrote: > Do you need to run the destructor before placement new in these situations? No, because there is no active union member in any of those situations. And if even if there was an active member,

[PATCH] D94596: [clang][AST] Encapsulate DeclarationNameLoc, NFCI

2021-01-13 Thread Mikhail Maltsev via Phabricator via cfe-commits
miyuki created this revision. miyuki added reviewers: aprantl, dexonsmith, rsmith, faisalv. Herald added a subscriber: arphaman. miyuki requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This change makes `DeclarationNameLoc` a proper class an

[PATCH] D69903: [Basic] Introduce PODSourceLocation, NFCI

2021-01-13 Thread Mikhail Maltsev via Phabricator via cfe-commits
miyuki abandoned this revision. miyuki added a comment. Abandoning in favor of D94237 and D94596 . CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69903/new/ https://reviews.llvm.org/D69903 __

[PATCH] D94599: [clang][Tooling] Get rid of a hack in SymbolOccurrences, NFCI

2021-01-13 Thread Mikhail Maltsev via Phabricator via cfe-commits
miyuki created this revision. miyuki added reviewers: aprantl, dexonsmith, arphaman. miyuki requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. The class `SymbolOccurrences` can store either a single `SourceRange` in-place or multiple `SourceRa

[PATCH] D94601: [clang-tidy] Use DenseSet in UpgradeDurationConversionsCheck, NFCI

2021-01-13 Thread Mikhail Maltsev via Phabricator via cfe-commits
miyuki created this revision. miyuki added reviewers: aprantl, dexonsmith, EricWF. Herald added a subscriber: xazax.hun. miyuki requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This change replaces `unordered_set` (which used to store intern

[PATCH] D94237: [clang] Use SourceLocations in unions [NFCI]

2021-01-13 Thread Mikhail Maltsev via Phabricator via cfe-commits
miyuki updated this revision to Diff 316414. miyuki added a comment. Refactored `SLocEntry` in a similar way. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D94237/new/ https://reviews.llvm.org/D94237 Files: clang/include/clang/AST/DependentDiagno

[PATCH] D94237: [clang] Use SourceLocations in unions [NFCI]

2021-01-14 Thread Mikhail Maltsev via Phabricator via cfe-commits
This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG17f8c458de63: [clang] Use SourceLocations in unions [NFCI] (authored by miyuki). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D94237: [clang] Use SourceLocations in unions [NFCI]

2021-01-14 Thread Mikhail Maltsev via Phabricator via cfe-commits
miyuki added a comment. > This revision was landed with ongoing or failed builds. The only failures were clang-format warnings, they looked bogus to me. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D94237/new/ https://reviews.llvm.org/D94237

[PATCH] D94601: [clang-tidy] Use DenseSet in UpgradeDurationConversionsCheck, NFCI

2021-01-14 Thread Mikhail Maltsev via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rG176f5e95e1af: [clang-tidy] Use DenseSet in UpgradeDurationConversionsCheck… (authored by miyuki). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.o

[PATCH] D94599: [clang][Tooling] Get rid of a hack in SymbolOccurrences, NFCI

2021-01-19 Thread Mikhail Maltsev via Phabricator via cfe-commits
miyuki added a comment. I will wait until the end of this week to see if anyone has objections. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D94599/new/ https://reviews.llvm.org/D94599 ___ cfe-commits ma

[PATCH] D94599: [clang][Tooling] Get rid of a hack in SymbolOccurrences, NFCI

2021-01-19 Thread Mikhail Maltsev via Phabricator via cfe-commits
miyuki updated this revision to Diff 317627. miyuki edited the summary of this revision. miyuki added a comment. Added `static_assert`s that check that `SourceRange` and `SourceLocation` are trivially destructible. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://revie

[PATCH] D94596: [clang][AST] Encapsulate DeclarationNameLoc, NFCI

2021-01-20 Thread Mikhail Maltsev via Phabricator via cfe-commits
miyuki added a comment. ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D94596/new/ https://reviews.llvm.org/D94596 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bi

<    1   2   3