[PATCH] D143059: [NFC] Enable selecting multiple multilibs

michaelplatings updated this revision to Diff 499500. michaelplatings marked 2 inline comments as done. michaelplatings added a comment. Rebase and apply changes requested by @peter.smith Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143059/new/ ht

[PATCH] D143075: BareMetal ToolChain multilib layering

michaelplatings updated this revision to Diff 499503. michaelplatings added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143075/new/ https://reviews.llvm.org/D143075 Files: clang/lib/Driver/ToolChains/BareMetal.cpp clang/lib

[PATCH] D143587: [Docs] Multilib design

michaelplatings updated this revision to Diff 499511. michaelplatings marked 8 inline comments as done. michaelplatings added a comment. Rebase and apply changes requested by @MaskRay and @peter.smith Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D14

[PATCH] D143587: [Docs] Multilib design

michaelplatings added inline comments. Comment at: clang/docs/Multilib.rst:237 + +Stable API +-- MaskRay wrote: > What does "API" refer to? A function defined in llvm-project/clang/lib? Changed "API" to "interface" and reworded to hopefully make it cleare

[PATCH] D142905: [Driver] Change multilib selection algorithm

michaelplatings updated this revision to Diff 499791. michaelplatings marked 2 inline comments as done. michaelplatings added a comment. - Rename args to options as suggested by @phosek - Add more comments to hopefully make the difference between flags and options clearer. Repository: rG LLVM

[PATCH] D142905: [Driver] Change multilib selection algorithm

michaelplatings added inline comments. Comment at: clang/include/clang/Driver/Multilib.h:41 + flag_set Flags; + arg_list PrintArgs; phosek wrote: > This is just a suggestion, but GCC documentation refers to these as either > "options" or "switches", not "arg

[PATCH] D142932: Multilib YAML parsing

michaelplatings updated this revision to Diff 499824. michaelplatings added a comment. PrintArgs -> PrintOptions Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142932/new/ https://reviews.llvm.org/D142932 Files: clang/include/clang/Driver/Multili

[PATCH] D142986: Enable multilib.yaml in the BareMetal ToolChain

michaelplatings updated this revision to Diff 499953. michaelplatings added a comment. PrintArgs -> PrintOptions Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142986/new/ https://reviews.llvm.org/D142986 Files: clang/lib/Driver/ToolChain.cpp c

[PATCH] D143075: BareMetal ToolChain multilib layering

michaelplatings updated this revision to Diff 499962. michaelplatings added a comment. PrintArgs -> PrintOptions Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143075/new/ https://reviews.llvm.org/D143075 Files: clang/lib/Driver/ToolChains/BareMe

[PATCH] D143587: [Docs] Multilib design

michaelplatings updated this revision to Diff 499963. michaelplatings added a comment. PrintArgs -> PrintOptions Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143587/new/ https://reviews.llvm.org/D143587 Files: clang/docs/Multilib.rst clang/do

[PATCH] D150752: [bolt] Use correct output paths and passthrough necessary options

michaelplatings added inline comments. Comment at: bolt/CMakeLists.txt:88 + if(CMAKE_SYSROOT) +list(APPEND extra_args -DCMAKE_SYSROOT=${CMAKE_SYSROOT}) + endif() The [[ https://cmake.org/cmake/help/latest/variable/CMAKE_TOOLCHAIN_FILE.html | documentation

[PATCH] D150902: [ARM][Driver] Warn if -mhard-float is incompatible

michaelplatings created this revision. michaelplatings added reviewers: stuij, pratlucas. Herald added subscribers: dmgreen, kristof.beyls. Herald added a project: All. michaelplatings requested review of this revision. Herald added subscribers: cfe-commits, MaskRay. Herald added a project: clang.

[PATCH] D150752: [bolt] Use correct output paths and passthrough necessary options

michaelplatings accepted this revision. michaelplatings added a comment. This revision is now accepted and ready to land. LGTM Comment at: bolt/CMakeLists.txt:88 + if(CMAKE_SYSROOT) +list(APPEND extra_args -DCMAKE_SYSROOT=${CMAKE_SYSROOT}) + endif() phose

[PATCH] D146757: [Driver] Enable defining multilib print options independently of flags

michaelplatings updated this revision to Diff 518997. michaelplatings added a comment. Chagne code to allow defining multilib flags verbatim Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146757/new/ https://reviews.llvm.org/D146757 Files: clang/

[PATCH] D142932: Multilib YAML parsing

michaelplatings updated this revision to Diff 518999. michaelplatings added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142932/new/ https://reviews.llvm.org/D142932 Files: clang/include/clang/Driver/Multilib.h clang/lib/Dri

[PATCH] D142933: Add -print-multi-selection-flags-experimental option

michaelplatings updated this revision to Diff 519000. michaelplatings added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142933/new/ https://reviews.llvm.org/D142933 Files: clang/include/clang/Driver/Options.td clang/include

[PATCH] D142986: Enable multilib.yaml in the BareMetal ToolChain

michaelplatings updated this revision to Diff 519001. michaelplatings added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142986/new/ https://reviews.llvm.org/D142986 Files: clang/lib/Driver/ToolChains/Arch/ARM.cpp clang/lib/

[PATCH] D143059: [Driver] Enable selecting multiple multilibs

michaelplatings updated this revision to Diff 519002. michaelplatings added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143059/new/ https://reviews.llvm.org/D143059 Files: clang/include/clang/Driver/Multilib.h clang/include

[PATCH] D143075: BareMetal ToolChain multilib layering

michaelplatings updated this revision to Diff 519003. michaelplatings added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143075/new/ https://reviews.llvm.org/D143075 Files: clang/lib/Driver/ToolChains/BareMetal.cpp clang/lib

[PATCH] D143587: [Docs] Multilib design

michaelplatings updated this revision to Diff 519004. michaelplatings added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143587/new/ https://reviews.llvm.org/D143587 Files: clang/docs/Multilib.rst clang/docs/index.rst Index

[PATCH] D146757: [Driver] Enable defining multilib flags verbatim

michaelplatings updated this revision to Diff 519005. michaelplatings added a comment. Re-run arc diff with clang-format in PATH Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146757/new/ https://reviews.llvm.org/D146757 Files: clang/include/clan

[PATCH] D150902: [ARM][Driver] Warn if -mhard-float is incompatible

michaelplatings updated this revision to Diff 528461. michaelplatings added a comment. Add variable specifically for the purpose of specifying whether or not FP regs are available. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150902/new/ https://

[PATCH] D150902: [ARM][Driver] Warn if -mhard-float is incompatible

michaelplatings marked an inline comment as done. michaelplatings added inline comments. Comment at: clang/lib/Driver/ToolChains/Arch/ARM.cpp:151 + const std::vector &Features) { + if (llvm::find(Features, "-fpregs") == Features.end()) +return; --

[PATCH] D150902: [ARM][Driver] Warn if -mhard-float is incompatible

michaelplatings updated this revision to Diff 528465. michaelplatings marked an inline comment as done. michaelplatings added a comment. Restore tweak to tests to use -### to run faster. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150902/new/ htt

[PATCH] D150902: [ARM][Driver] Warn if -mhard-float is incompatible

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG1d511e1864f1: [ARM][Driver] Warn if -mhard-float is incompatible (authored by michaelplatings). Repository: rG LLVM Github Monorepo CHANGES SINCE

[PATCH] D150902: [ARM][Driver] Warn if -mhard-float is incompatible

michaelplatings added a comment. Thanks Tom, I'll work on it now. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150902/new/ https://reviews.llvm.org/D150902 ___ cfe-commits mailing list cfe-commits@lists

[PATCH] D150902: [ARM][Driver] Warn if -mhard-float is incompatible

michaelplatings added a comment. Reverted. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150902/new/ https://reviews.llvm.org/D150902 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists

[PATCH] D150902: [ARM][Driver] Warn if -mhard-float is incompatible

michaelplatings added a comment. Relanded with the warning in the "OptionIgnored" group which fixes the test failure. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150902/new/ https://reviews.llvm.org/D150902 _

[PATCH] D151438: [NFC][Driver] Change Multilib flag representation

michaelplatings updated this revision to Diff 528826. michaelplatings added a comment. Herald added a subscriber: ormris. Update unit tests Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151438/new/ https://reviews.llvm.org/D151438 Files: clang/i

[PATCH] D142932: Multilib YAML parsing

michaelplatings updated this revision to Diff 528932. michaelplatings added a comment. Rebase on D151438 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142932/new/ https://reviews.llvm.org/D142932 Files: clang/i

[PATCH] D142932: Multilib YAML parsing

michaelplatings marked 2 inline comments as done. michaelplatings added inline comments. Comment at: clang/include/clang/Driver/Multilib.h:150-152 + bool parseYaml(llvm::MemoryBufferRef, + llvm::SourceMgr::DiagHandlerTy = nullptr, + void *DiagHand

[PATCH] D142932: Multilib YAML parsing

michaelplatings updated this revision to Diff 528955. michaelplatings marked an inline comment as done. michaelplatings added a comment. Update unit tests Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142932/new/ https://reviews.llvm.org/D142932 F

[PATCH] D142933: Add -print-multi-selection-flags-experimental option

michaelplatings updated this revision to Diff 529013. michaelplatings added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142933/new/ https://reviews.llvm.org/D142933 Files: clang/include/clang/Driver/Options.td clang/include

[PATCH] D142986: Enable multilib.yaml in the BareMetal ToolChain

michaelplatings updated this revision to Diff 529016. michaelplatings marked an inline comment as done. michaelplatings added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142986/new/ https://reviews.llvm.org/D142986 Files: cla

[PATCH] D142986: Enable multilib.yaml in the BareMetal ToolChain

michaelplatings added inline comments. Comment at: clang/lib/Driver/ToolChains/BareMetal.cpp:183 - SmallString<128> SysRootDir; - llvm::sys::path::append(SysRootDir, getDriver().Dir, "../lib/clang-runtimes", - getDriver().getTargetTriple()); ---

[PATCH] D143059: [Driver] Enable selecting multiple multilibs

michaelplatings updated this revision to Diff 529017. michaelplatings added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143059/new/ https://reviews.llvm.org/D143059 Files: clang/include/clang/Driver/Multilib.h clang/include

[PATCH] D143075: BareMetal ToolChain multilib layering

michaelplatings updated this revision to Diff 529021. michaelplatings marked an inline comment as done. michaelplatings added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143075/new/ https://reviews.llvm.org/D143075 Files: cla

[PATCH] D143075: BareMetal ToolChain multilib layering

michaelplatings added inline comments. Comment at: clang/lib/Driver/ToolChains/BareMetal.cpp:228 + +llvm::SmallVector BareMetal::getOrderedMultilibs() const { + // Get multilibs in reverse order because they're ordered most-specific last. phosek wrote: > Can you

[PATCH] D151437: [NFC][Driver] Change MultilibBuilder interface

This revision was automatically updated to reflect the committed changes. Closed by commit rG47b431d6617d: [NFC][Driver] Change MultilibBuilder interface (authored by michaelplatings). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151437/new/ https:

[PATCH] D151438: [NFC][Driver] Change Multilib flag representation

This revision was automatically updated to reflect the committed changes. Closed by commit rGce8fa36e59e1: [NFC][Driver] Change Multilib flag representation (authored by michaelplatings). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151438/new/ htt

[PATCH] D152353: [NFC][Driver] Change MultilibBuilder flags argument order

michaelplatings created this revision. michaelplatings added reviewers: phosek, simon_tatham. Herald added a subscriber: abrachet. Herald added a project: All. michaelplatings requested review of this revision. Herald added subscribers: cfe-commits, MaskRay. Herald added a project: clang. Follow u

[PATCH] D151437: [NFC][Driver] Change MultilibBuilder interface

michaelplatings marked an inline comment as done. michaelplatings added inline comments. Comment at: clang/include/clang/Driver/MultilibBuilder.h:80 + /// \p Flag must be a flag accepted by the driver. + MultilibBuilder &flag(bool Required, StringRef Flag); p

[PATCH] D142932: Multilib YAML parsing

michaelplatings updated this revision to Diff 529269. michaelplatings added a comment. @phosek thanks for your suggestion, that's now implemented. In practise for LLVM Embedded Toolchain for Arm we haven't yet needed `NoMatchFlags` so I've removed that feature. Repository: rG LLVM Github Mon

[PATCH] D142933: Add -print-multi-selection-flags-experimental option

michaelplatings updated this revision to Diff 529313. michaelplatings marked 2 inline comments as done. michaelplatings added a comment. Rename option and support fewer options as suggested by @phosek Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D14

[PATCH] D142986: Enable multilib.yaml in the BareMetal ToolChain

michaelplatings updated this revision to Diff 529315. michaelplatings marked an inline comment as done. michaelplatings added a comment. Change string literal as suggested by @phosek Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142986/new/ https:/

[PATCH] D143059: [Driver] Enable selecting multiple multilibs

michaelplatings updated this revision to Diff 529316. michaelplatings added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143059/new/ https://reviews.llvm.org/D143059 Files: clang/include/clang/Driver/Multilib.h clang/include

[PATCH] D143075: BareMetal ToolChain multilib layering

michaelplatings updated this revision to Diff 529318. michaelplatings added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143075/new/ https://reviews.llvm.org/D143075 Files: clang/lib/Driver/ToolChains/BareMetal.cpp clang/lib

[PATCH] D143075: BareMetal ToolChain multilib layering

michaelplatings added inline comments. Comment at: clang/lib/Driver/ToolChains/BareMetal.cpp:242-246 + // No multilibs selected so return a single default multilib. + static llvm::SmallVector Default = {Multilib()}; + return llvm::iterator_range< + llvm::SmallVector::cons

[PATCH] D152353: [NFC][Driver] Change MultilibBuilder flags argument order

michaelplatings updated this revision to Diff 529530. michaelplatings marked an inline comment as done. michaelplatings added a comment. Negate->Disallow Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152353/new/ https://reviews.llvm.org/D152353 Fi

[PATCH] D152353: [NFC][Driver] Change MultilibBuilder flags argument order

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGb4507dcaeafc: [NFC][Driver] Change MultilibBuilder flags argument order (authored by michaelplatings). Repository: rG LLVM Github Monorepo CHANGE

[PATCH] D142932: Multilib YAML parsing

michaelplatings updated this revision to Diff 529563. michaelplatings added a comment. FlagMap->Mappings Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142932/new/ https://reviews.llvm.org/D142932 Files: clang/include/clang/Driver/Multilib.h cl

[PATCH] D142933: [Driver] Add -print-multi-flags-experimental option

michaelplatings updated this revision to Diff 529564. michaelplatings added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142933/new/ https://reviews.llvm.org/D142933 Files: clang/include/clang/Driver/Options.td clang/include

[PATCH] D142986: Enable multilib.yaml in the BareMetal ToolChain

michaelplatings updated this revision to Diff 529565. michaelplatings added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142986/new/ https://reviews.llvm.org/D142986 Files: clang/lib/Driver/ToolChain.cpp clang/lib/Driver/Too

[PATCH] D143059: [Driver] Enable selecting multiple multilibs

michaelplatings updated this revision to Diff 529566. michaelplatings added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143059/new/ https://reviews.llvm.org/D143059 Files: clang/include/clang/Driver/Multilib.h clang/include

[PATCH] D143075: BareMetal ToolChain multilib layering

michaelplatings updated this revision to Diff 529567. michaelplatings added a comment. Simplify code as suggested by @phosek Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143075/new/ https://reviews.llvm.org/D143075 Files: clang/lib/Driver/ToolC

[PATCH] D143587: [Docs] Multilib design

michaelplatings updated this revision to Diff 529569. michaelplatings added a comment. Update docs to reflect recent changes Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143587/new/ https://reviews.llvm.org/D143587 Files: clang/docs/Multilib.rs

[PATCH] D143587: [Docs] Multilib design

michaelplatings updated this revision to Diff 529588. michaelplatings added a comment. FlagMap->Mappings Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143587/new/ https://reviews.llvm.org/D143587 Files: clang/docs/Multilib.rst clang/docs/index

[PATCH] D142932: Multilib YAML parsing

This revision was automatically updated to reflect the committed changes. Closed by commit rG4794bdab7aed: [Driver] Multilib YAML parsing (authored by michaelplatings). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142932/new/ https://reviews.llvm.o

[PATCH] D142933: [Driver] Add -print-multi-flags-experimental option

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGa794ab92b41f: [Driver] Add -print-multi-flags-experimental option (authored by michaelplatings). Changed prior to commit: https://reviews.llvm.org

[PATCH] D142986: Enable multilib.yaml in the BareMetal ToolChain

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGb4eebc8674e1: [Driver] Enable multilib.yaml in the BareMetal ToolChain (authored by michaelplatings). Repository: rG LLVM Github Monorepo CHANGES

[PATCH] D143059: [Driver] Enable selecting multiple multilibs

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGedc1130c0ac0: [Driver] Enable selecting multiple multilibs (authored by michaelplatings). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D143075: BareMetal ToolChain multilib layering

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGab2c80bb1256: [Driver] BareMetal ToolChain multilib layering (authored by michaelplatings). Repository: rG LLVM Github Monorepo CHANGES SINCE LAS

[PATCH] D143587: [Docs] Multilib design

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGa5aeba737694: [Docs] Multilib design (authored by michaelplatings). Changed prior to commit: https://reviews.llvm.org/D143587?vs=529588&id=531184#

[PATCH] D139822: Allow using BareMetal toolchain with LLVM_ENABLE_PER_TARGET_RUNTIME_DIR compiler-rt

michaelplatings created this revision. michaelplatings added reviewers: abidh, jroelofs. michaelplatings added a project: clang. Herald added subscribers: dberris, ki.stfu. Herald added a project: All. michaelplatings requested review of this revision. Herald added subscribers: cfe-commits, MaskRay

[PATCH] D139822: Allow using BareMetal toolchain with LLVM_ENABLE_PER_TARGET_RUNTIME_DIR compiler-rt

This revision was automatically updated to reflect the committed changes. Closed by commit rG620d2bfdadeb: [clang] Allow using BareMetal toolchain with LLVM_ENABLE_PER_TARGET_RUNTIME_DIR… (authored by michaelplatings). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://rev

<    1   2   3