MaxEW707 wrote:
@Endilll Wondering if this PR gets the green check from you.
I would like to get this merged before the clang-19 branch is created and just
want to get the green light from a more senior member of the community before
merging. Thanks :).
https://github.com/llvm/llvm-project/pu
https://github.com/MaxEW707 created
https://github.com/llvm/llvm-project/pull/99426
We have had quite a few issues created around how Clang treats intrinsics vs
how MSVC treats intrinsics.
While I was writing this I also added some sections on behaviour changes that
caught me while porting my
https://github.com/MaxEW707 updated
https://github.com/llvm/llvm-project/pull/99426
>From 37f6bb1a6bc061357f1971c59c101ef7e6b53141 Mon Sep 17 00:00:00 2001
From: MaxEW707
Date: Thu, 11 Jul 2024 23:07:35 -0700
Subject: [PATCH 1/4] Update MSVC compatibility docs
---
clang/docs/MSVCCompatibility
@@ -154,3 +154,133 @@ a hint suggesting how to fix the problem.
As of this writing, Clang is able to compile a simple ATL hello world
application. There are still issues parsing WRL headers for modern Windows 8
MaxEW707 wrote:
Ya its on my todo list to clean t
https://github.com/MaxEW707 closed
https://github.com/llvm/llvm-project/pull/99426
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/MaxEW707 created
https://github.com/llvm/llvm-project/pull/99833
MSDN docs for reference:
https://learn.microsoft.com/en-us/cpp/build/reference/zc-referencebinding-enforce-reference-binding-rules?view=msvc-170
The warning referenced in that MSDN article:
https://learn.micros
https://github.com/MaxEW707 edited
https://github.com/llvm/llvm-project/pull/99833
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/MaxEW707 edited
https://github.com/llvm/llvm-project/pull/99833
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/MaxEW707 edited
https://github.com/llvm/llvm-project/pull/99833
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/MaxEW707 edited
https://github.com/llvm/llvm-project/pull/99833
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/MaxEW707 edited
https://github.com/llvm/llvm-project/pull/99833
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/MaxEW707 created
https://github.com/llvm/llvm-project/pull/90547
https://godbolt.org/z/verKj4cnj for reference.
https://godbolt.org/z/z3W9v7o4n for reference.
For global functions and static methods the MSVC ABI returns structs/classes
with a reference type non static data m
@@ -1144,11 +1167,13 @@ bool MicrosoftCXXABI::classifyReturnType(CGFunctionInfo
&FI) const {
if (!RD)
return false;
- bool isTrivialForABI = RD->canPassInRegisters() &&
- isTrivialForMSVC(RD, FI.getReturnType(), CGM);
-
// MSVC always returns
https://github.com/MaxEW707 created
https://github.com/llvm/llvm-project/pull/98105
Fixes https://github.com/llvm/llvm-project/issues/94366.
>From f9def27dcbfe6ce1a55fd5c41d15d55b05d9a056 Mon Sep 17 00:00:00 2001
From: MaxEW707
Date: Mon, 8 Jul 2024 19:14:11 -0700
Subject: [PATCH 1/2] Fix erro
https://github.com/MaxEW707 updated
https://github.com/llvm/llvm-project/pull/98105
>From f9def27dcbfe6ce1a55fd5c41d15d55b05d9a056 Mon Sep 17 00:00:00 2001
From: MaxEW707
Date: Mon, 8 Jul 2024 19:14:11 -0700
Subject: [PATCH 1/3] Fix erroneous `-Wmissing-prototypes` for Win32 entry
points
---
https://github.com/MaxEW707 updated
https://github.com/llvm/llvm-project/pull/98105
>From f9def27dcbfe6ce1a55fd5c41d15d55b05d9a056 Mon Sep 17 00:00:00 2001
From: MaxEW707
Date: Mon, 8 Jul 2024 19:14:11 -0700
Subject: [PATCH 1/4] Fix erroneous `-Wmissing-prototypes` for Win32 entry
points
---
https://github.com/MaxEW707 updated
https://github.com/llvm/llvm-project/pull/98105
>From f9def27dcbfe6ce1a55fd5c41d15d55b05d9a056 Mon Sep 17 00:00:00 2001
From: MaxEW707
Date: Mon, 8 Jul 2024 19:14:11 -0700
Subject: [PATCH 1/5] Fix erroneous `-Wmissing-prototypes` for Win32 entry
points
---
https://github.com/MaxEW707 closed
https://github.com/llvm/llvm-project/pull/98105
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
MaxEW707 wrote:
> Maybe we should just be testing if the copy-assignment operator is deleted?
> For reference, MSVC also returns the following indirectly:
>
> ```
> struct Test
> {
> int x;
> Test& operator=(const Test&) = delete;
> };
> Test foo();
> Test test(Test x)
> {
> return x;
https://github.com/MaxEW707 updated
https://github.com/llvm/llvm-project/pull/90547
>From f404db44d3770cdb8ac5123c16c0b04314eda698 Mon Sep 17 00:00:00 2001
From: MaxEW707
Date: Mon, 29 Apr 2024 22:09:52 -0400
Subject: [PATCH 1/4] [clang][CodeGen] Fix MS ABI for classes with non static
data mem
@@ -1131,13 +1132,18 @@ static bool isTrivialForMSVC(const CXXRecordDecl *RD,
QualType Ty,
return false;
if (RD->hasNonTrivialCopyAssignment())
return false;
+ if (RD->needsImplicitCopyAssignment() && !RD->hasSimpleCopyAssignment())
MaxEW707 wrote:
https://github.com/MaxEW707 edited
https://github.com/llvm/llvm-project/pull/90547
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -1131,13 +1132,18 @@ static bool isTrivialForMSVC(const CXXRecordDecl *RD,
QualType Ty,
return false;
if (RD->hasNonTrivialCopyAssignment())
return false;
+ if (RD->needsImplicitCopyAssignment() && !RD->hasSimpleCopyAssignment())
MaxEW707 wrote:
https://github.com/MaxEW707 updated
https://github.com/llvm/llvm-project/pull/90547
>From f404db44d3770cdb8ac5123c16c0b04314eda698 Mon Sep 17 00:00:00 2001
From: MaxEW707
Date: Mon, 29 Apr 2024 22:09:52 -0400
Subject: [PATCH 1/5] [clang][CodeGen] Fix MS ABI for classes with non static
data mem
https://github.com/MaxEW707 updated
https://github.com/llvm/llvm-project/pull/90547
>From f404db44d3770cdb8ac5123c16c0b04314eda698 Mon Sep 17 00:00:00 2001
From: MaxEW707
Date: Mon, 29 Apr 2024 22:09:52 -0400
Subject: [PATCH 1/6] [clang][CodeGen] Fix MS ABI for classes with non static
data mem
https://github.com/MaxEW707 closed
https://github.com/llvm/llvm-project/pull/90547
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/MaxEW707 created
https://github.com/llvm/llvm-project/pull/91689
I noticed this when changing some of my local projects to use my preferred
driver mode, GCC, instead of the CL driver mode.
>From looking at the rest of code and from my own understanding the driver mode
>is s
https://github.com/MaxEW707 created
https://github.com/llvm/llvm-project/pull/92477
https://godbolt.org/z/G1K8Wszn9 for reference.
Starting with MSVC 1920+, VS2019, C++17 auto NTTP now adds `M ` to the
mangled name to avoid name collisions with different deduced types.
This PR fixes pointers.
https://github.com/MaxEW707 updated
https://github.com/llvm/llvm-project/pull/92477
>From 7b73c2b907b09ec87197e9613c4abc27ff52083b Mon Sep 17 00:00:00 2001
From: MaxEW707
Date: Thu, 16 May 2024 21:03:46 -0400
Subject: [PATCH 1/2] [clang-cl][AST] Fix auto NTTP MSVC 1920+ mangling
---
clang/doc
https://github.com/MaxEW707 updated
https://github.com/llvm/llvm-project/pull/92477
>From 139c51074b43623ea7b206080056823e216fedac Mon Sep 17 00:00:00 2001
From: MaxEW707
Date: Thu, 16 May 2024 21:03:46 -0400
Subject: [PATCH 1/2] [clang-cl][AST] Fix auto NTTP MSVC 1920+ mangling
---
clang/doc
https://github.com/MaxEW707 edited
https://github.com/llvm/llvm-project/pull/92477
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
MaxEW707 wrote:
@huangqinjin The error is "fatal error C1060: compiler is out of heap space"
which is unrelated.
I haven't figured out how to resend the event to trigger a build retry without
pushing an empty commit.
I usually just do `git commit -m "rebuild" --allow-empty` and then push that
@@ -291,6 +291,7 @@ LANGOPT(HIPStdParInterposeAlloc, 1, 0, "Replace allocations
/ deallocations with
LANGOPT(OpenACC , 1, 0, "OpenACC Enabled")
+LANGOPT(MSVCEnableStdcMacro , 1, 0, "Define __STDC__ with
'-fms-compatability'")
MaxEW707 wrote:
```s
@@ -2934,6 +2934,10 @@ def fms_compatibility : Flag<["-"],
"fms-compatibility">, Group,
Visibility<[ClangOption, CC1Option, CLOption]>,
HelpText<"Enable full Microsoft Visual C++ compatibility">,
MarshallingInfoFlag>;
+def fms_define_stdc : Flag<["-"], "fms-define-stdc">
https://github.com/MaxEW707 edited
https://github.com/llvm/llvm-project/pull/68690
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -8065,6 +8069,9 @@ void Clang::AddClangCLArgs(const ArgList &Args, types::ID
InputType,
CmdArgs.push_back("-fno-wchar");
}
+ if (!types::isCXX(InputType) && Args.hasArg(options::OPT_fms_define_stdc))
+ CmdArgs.push_back("-fms-define-stdc");
MaxEW707
https://github.com/MaxEW707 edited
https://github.com/llvm/llvm-project/pull/68690
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/MaxEW707 edited
https://github.com/llvm/llvm-project/pull/91689
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
MaxEW707 wrote:
@huangqinjin Try rebasing you changes on top of latest main. Looks like Windows
CI is passing there including flang commits which are the source files that are
causing msvc to run out of heap space.
https://github.com/llvm/llvm-project/pull/89772
___
https://github.com/MaxEW707 updated
https://github.com/llvm/llvm-project/pull/91689
>From b43a6302009b9a11ef672f3bd01e10342102de44 Mon Sep 17 00:00:00 2001
From: MaxEW707
Date: Thu, 9 May 2024 21:21:22 -0400
Subject: [PATCH 1/2] [clang][Driver] Fix enabling strict alising by default
when the e
https://github.com/MaxEW707 approved this pull request.
LGTM!
@xbjfk Let us know if you require one of us to commit on your behalf due to not
having commit access.
https://github.com/llvm/llvm-project/pull/68690
___
cfe-commits mailing list
cfe-commi
https://github.com/MaxEW707 updated
https://github.com/llvm/llvm-project/pull/91689
>From 3b0967e0a8f564d761ea10858854776ede396bdf Mon Sep 17 00:00:00 2001
From: MaxEW707
Date: Thu, 9 May 2024 21:21:22 -0400
Subject: [PATCH 1/2] [clang][Driver] Fix enabling strict alising by default
when the e
https://github.com/MaxEW707 closed
https://github.com/llvm/llvm-project/pull/91689
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/MaxEW707 closed
https://github.com/llvm/llvm-project/pull/68690
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/MaxEW707 updated
https://github.com/llvm/llvm-project/pull/99833
>From c66fee7969fc4bd8b5ce79085f0fc09cbc4147da Mon Sep 17 00:00:00 2001
From: MaxEW707
Date: Fri, 21 Jun 2024 20:37:40 -0700
Subject: [PATCH 01/10] Support MSVC lvalue to temporary reference binding
---
clang/
https://github.com/MaxEW707 updated
https://github.com/llvm/llvm-project/pull/99833
>From c66fee7969fc4bd8b5ce79085f0fc09cbc4147da Mon Sep 17 00:00:00 2001
From: MaxEW707
Date: Fri, 21 Jun 2024 20:37:40 -0700
Subject: [PATCH 01/11] Support MSVC lvalue to temporary reference binding
---
clang/
@@ -4446,6 +4446,24 @@ CompareStandardConversionSequences(Sema &S,
SourceLocation Loc,
T1 = S.Context.getQualifiedType(UnqualT1, T1Quals);
if (isa(T2) && T2Quals)
T2 = S.Context.getQualifiedType(UnqualT2, T2Quals);
+
+ if (S.getLangOpts().MSVCReferen
https://github.com/MaxEW707 updated
https://github.com/llvm/llvm-project/pull/99833
>From c66fee7969fc4bd8b5ce79085f0fc09cbc4147da Mon Sep 17 00:00:00 2001
From: MaxEW707
Date: Fri, 21 Jun 2024 20:37:40 -0700
Subject: [PATCH 01/12] Support MSVC lvalue to temporary reference binding
---
clang/
https://github.com/MaxEW707 edited
https://github.com/llvm/llvm-project/pull/99833
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/MaxEW707 created
https://github.com/llvm/llvm-project/pull/104722
Reapply https://github.com/llvm/llvm-project/pull/102848.
The description in this PR will detail the changes from the reverted original
PR above.
For `auto&&` return types that can partake in reference collap
https://github.com/MaxEW707 closed
https://github.com/llvm/llvm-project/pull/104722
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/MaxEW707 created
https://github.com/llvm/llvm-project/pull/105999
Fixes https://github.com/llvm/llvm-project/pull/104722.
Missed handling `decltype(auto)` trailing return types for lambdas.
This was a mistake and regression on my part with my PR,
https://github.com/llvm/llvm
MaxEW707 wrote:
@zmodem
I have a fix for https://ci.chromium.org/ui/p/chromium/builders/ci/ToTWin.
This was an accidental regression on my part, sorry.
The fix is here https://github.com/llvm/llvm-project/pull/105999.
https://github.com/llvm/llvm-project/pull/104722
__
https://github.com/MaxEW707 closed
https://github.com/llvm/llvm-project/pull/105999
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
MaxEW707 wrote:
> LLVM Buildbot has detected a new failure on builder `sanitizer-x86_64-linux`
> running on `sanitizer-buildbot1` while building `clang` at step 2 "annotate".
>
> Full details are available at:
> https://lab.llvm.org/buildbot/#/builders/66/builds/3102
> Here is the relevant pie
https://github.com/MaxEW707 approved this pull request.
LGTM!
Looks CI failed due to MSVC "fatal error C1060: compiler is out of heap space"
inside a flang source file.
I would try syncing upto main since I know flang has had quite of changes that
overall reduce MSVC's memory usage at least a
MaxEW707 wrote:
> Rebased on latest main. Let's see what CI say.
Looks like CI is happy. Do you need someone to commit the change on your behalf
or do you have commit access?
https://github.com/llvm/llvm-project/pull/90731
___
cfe-commits mailing lis
https://github.com/MaxEW707 closed
https://github.com/llvm/llvm-project/pull/90731
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/MaxEW707 created
https://github.com/llvm/llvm-project/pull/97007
Fixes https://github.com/llvm/llvm-project/issues/70899.
This is a continuation of https://github.com/llvm/llvm-project/pull/92477 for
pointers to member data and pointers to member functions.
The mangled name
@@ -0,0 +1,24 @@
+// RUN: %clang_cc1 -std=c++17 -fms-compatibility-version=19.20 -emit-llvm %s
-o - -fms-extensions -fdelayed-template-parsing -triple=x86_64-pc-windows-msvc
| FileCheck --check-prefix=AFTER %s
+// RUN: %clang_cc1 -std=c++17 -fms-compatibility-version=19.14 -emit
https://github.com/MaxEW707 edited
https://github.com/llvm/llvm-project/pull/97007
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/MaxEW707 edited
https://github.com/llvm/llvm-project/pull/97007
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -1767,12 +1805,12 @@ void MicrosoftCXXNameMangler::mangleTemplateArg(const
TemplateDecl *TD,
const CXXRecordDecl *RD = MPT->getMostRecentCXXRecordDecl();
if (MPT->isMemberFunctionPointerType() &&
!isa(TD)) {
-mangleMemberFunctionPointer(RD, nul
https://github.com/MaxEW707 edited
https://github.com/llvm/llvm-project/pull/97007
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/MaxEW707 updated
https://github.com/llvm/llvm-project/pull/97007
>From 762eb6deea8082902c7d278014fb9485f89a2ccf Mon Sep 17 00:00:00 2001
From: MaxEW707
Date: Wed, 26 Jun 2024 16:59:17 -0700
Subject: [PATCH 1/5] Fix MSVC 1920+ auto NTTP mangling for pointers to members
---
c
https://github.com/MaxEW707 closed
https://github.com/llvm/llvm-project/pull/107509
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
MaxEW707 wrote:
@efriedma-quic What is the process for getting a fix into a milestone such as
the upcoming 19.1.2 milestone. I read the docs on `cherry-pick` but I couldn't
find any information about who decides what is considered suitable for a patch
release.
I am going to defer to you if you
https://github.com/MaxEW707 closed
https://github.com/llvm/llvm-project/pull/112066
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
MaxEW707 wrote:
> Not sure how you're actually hitting the error you reported; the clang header
> directory should count as a system header, so the warning should normally be
> suppressed, I think.
It is counted as a system header and I could not repro the warning in my local
tests. I was goi
@@ -44,7 +44,7 @@ unsigned char _InterlockedCompareExchange128_rel(__int64
volatile *_Destination,
__int64 *_ComparandResult);
#endif
-#ifdef __x86_64__
+#ifdef __x86_64__ && !defined(__arm64ec__)
MaxEW707 wrot
https://github.com/MaxEW707 updated
https://github.com/llvm/llvm-project/pull/112066
>From 52e2175eb672fa9a97f9c1480a3cfb727b7c3dce Mon Sep 17 00:00:00 2001
From: MaxEW707
Date: Fri, 11 Oct 2024 19:01:59 -0700
Subject: [PATCH 1/2] Fix extra tokens inside intrin0.h preprocessor directive
---
c
MaxEW707 wrote:
I put a PR with a fix, https://github.com/llvm/llvm-project/pull/112066.
This should probably go into 19.1.2 but I am familiar with that process.
If someone with more experience in the project can give guidance there that
would be appreciated :).
https://github.com/llvm/llvm-p
https://github.com/MaxEW707 created
https://github.com/llvm/llvm-project/pull/112066
Fixes https://github.com/llvm/llvm-project/pull/87717.
>From 52e2175eb672fa9a97f9c1480a3cfb727b7c3dce Mon Sep 17 00:00:00 2001
From: MaxEW707
Date: Fri, 11 Oct 2024 19:01:59 -0700
Subject: [PATCH] Fix extra to
MaxEW707 wrote:
> Windows should use `-fuse-ld=lld` as well, not `-fuse-ld=lld-link`
Is `-fuse-ld=lld-link` intended to be an allowable option?
Right now we don't issue any error if a user passes in `lld-link`.
I am interpreting your statement as suggesting we should do something like
followi
@@ -0,0 +1,15 @@
+// REQUIRES: aarch64-registered-target
+//
+// RUN: echo "int main() {} " > %t.c
+//
+// RUN: %clang --target=aarch64-pc-windows-msvc -O3 -flto -fuse-ld=lld -c %t.c
-o %t.o
+// RUN: %clang --target=aarch64-pc-windows-msvc -O3 -flto -fuse-ld=lld -###
%t.o 2>&1 |
https://github.com/MaxEW707 edited
https://github.com/llvm/llvm-project/pull/113966
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -0,0 +1,15 @@
+// REQUIRES: aarch64-registered-target
+//
+// RUN: echo "int main() {} " > %t.c
+//
+// RUN: %clang --target=aarch64-pc-windows-msvc -O3 -flto -fuse-ld=lld -c %t.c
-o %t.o
+// RUN: %clang --target=aarch64-pc-windows-msvc -O3 -flto -fuse-ld=lld -###
%t.o 2>&1 |
https://github.com/MaxEW707 approved this pull request.
LGTM!
Would like a final look over from @MaskRay before merging :).
https://github.com/llvm/llvm-project/pull/113966
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org
https://github.com/MaxEW707 created
https://github.com/llvm/llvm-project/pull/109607
Similar to previous PRs I've done to change some `IsCLMode` checks to
`isWindowsMSVCEnvironment`.
I stumbled into this one accidentally last week. I did some greps and I think
this is the last one for now. All
https://github.com/MaxEW707 closed
https://github.com/llvm/llvm-project/pull/109607
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/MaxEW707 updated
https://github.com/llvm/llvm-project/pull/117845
>From 58a26201c8582fc573aa681867d57c236e799acb Mon Sep 17 00:00:00 2001
From: MaxEW707
Date: Tue, 26 Nov 2024 19:45:10 -0800
Subject: [PATCH 1/2] Fix MS Mangle concept uneval context template
instantiation cra
@@ -0,0 +1,25 @@
+// RUN: %clang_cc1 -std=c++20 -fms-compatibility
-fms-compatibility-version=19.33 -emit-llvm %s -o - -triple=x86_64-windows-msvc
| FileCheck %s
+
+template
+concept C = requires
+{
+{ T::test([](){}) };
+};
+
+template
+struct Widget {};
+
+template
+stru
@@ -7272,6 +7272,11 @@ void Clang::ConstructJob(Compilation &C, const JobAction
&JA,
CmdArgs.push_back("-fdelayed-template-parsing");
}
+ if (Args.hasFlag(options::OPT_fms_reference_binding,
+ options::OPT_fno_ms_reference_binding,
+
https://github.com/MaxEW707 edited
https://github.com/llvm/llvm-project/pull/99833
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/MaxEW707 updated
https://github.com/llvm/llvm-project/pull/99833
>From c66fee7969fc4bd8b5ce79085f0fc09cbc4147da Mon Sep 17 00:00:00 2001
From: MaxEW707
Date: Fri, 21 Jun 2024 20:37:40 -0700
Subject: [PATCH 01/13] Support MSVC lvalue to temporary reference binding
---
clang/
https://github.com/MaxEW707 updated
https://github.com/llvm/llvm-project/pull/99833
>From 0a705b1a8e9673cd5e803ffe392dacfa0f06c40f Mon Sep 17 00:00:00 2001
From: MaxEW707
Date: Fri, 21 Jun 2024 20:37:40 -0700
Subject: [PATCH 01/26] Support MSVC lvalue to temporary reference binding
---
clang/
https://github.com/MaxEW707 updated
https://github.com/llvm/llvm-project/pull/99833
>From 0a705b1a8e9673cd5e803ffe392dacfa0f06c40f Mon Sep 17 00:00:00 2001
From: MaxEW707
Date: Fri, 21 Jun 2024 20:37:40 -0700
Subject: [PATCH 01/27] Support MSVC lvalue to temporary reference binding
---
clang/
https://github.com/MaxEW707 updated
https://github.com/llvm/llvm-project/pull/99833
>From 0a705b1a8e9673cd5e803ffe392dacfa0f06c40f Mon Sep 17 00:00:00 2001
From: MaxEW707
Date: Fri, 21 Jun 2024 20:37:40 -0700
Subject: [PATCH 01/14] Support MSVC lvalue to temporary reference binding
---
clang/
https://github.com/MaxEW707 updated
https://github.com/llvm/llvm-project/pull/99833
>From 0a705b1a8e9673cd5e803ffe392dacfa0f06c40f Mon Sep 17 00:00:00 2001
From: MaxEW707
Date: Fri, 21 Jun 2024 20:37:40 -0700
Subject: [PATCH 01/15] Support MSVC lvalue to temporary reference binding
---
clang/
https://github.com/MaxEW707 updated
https://github.com/llvm/llvm-project/pull/99833
>From 0a705b1a8e9673cd5e803ffe392dacfa0f06c40f Mon Sep 17 00:00:00 2001
From: MaxEW707
Date: Fri, 21 Jun 2024 20:37:40 -0700
Subject: [PATCH 01/20] Support MSVC lvalue to temporary reference binding
---
clang/
@@ -0,0 +1,87 @@
+// RUN: %clang_cc1 -triple x86_64-windows-msvc %s -emit-llvm -fms-extensions
-fms-compatibility -fms-reference-binding -Wno-microsoft-reference-binding -o -
| FileCheck %s
+
+struct A {};
+struct B : A {};
+
+void fAPickConstRef(A&) {}
+void fAPickConstRef(cons
https://github.com/MaxEW707 updated
https://github.com/llvm/llvm-project/pull/99833
>From 0a705b1a8e9673cd5e803ffe392dacfa0f06c40f Mon Sep 17 00:00:00 2001
From: MaxEW707
Date: Fri, 21 Jun 2024 20:37:40 -0700
Subject: [PATCH 01/23] Support MSVC lvalue to temporary reference binding
---
clang/
https://github.com/MaxEW707 updated
https://github.com/llvm/llvm-project/pull/99833
>From 0a705b1a8e9673cd5e803ffe392dacfa0f06c40f Mon Sep 17 00:00:00 2001
From: MaxEW707
Date: Fri, 21 Jun 2024 20:37:40 -0700
Subject: [PATCH 01/22] Support MSVC lvalue to temporary reference binding
---
clang/
https://github.com/MaxEW707 updated
https://github.com/llvm/llvm-project/pull/99833
>From 0a705b1a8e9673cd5e803ffe392dacfa0f06c40f Mon Sep 17 00:00:00 2001
From: MaxEW707
Date: Fri, 21 Jun 2024 20:37:40 -0700
Subject: [PATCH 01/25] Support MSVC lvalue to temporary reference binding
---
clang/
https://github.com/MaxEW707 updated
https://github.com/llvm/llvm-project/pull/99833
>From 0a705b1a8e9673cd5e803ffe392dacfa0f06c40f Mon Sep 17 00:00:00 2001
From: MaxEW707
Date: Fri, 21 Jun 2024 20:37:40 -0700
Subject: [PATCH 01/24] Support MSVC lvalue to temporary reference binding
---
clang/
https://github.com/MaxEW707 updated
https://github.com/llvm/llvm-project/pull/99833
>From 0a705b1a8e9673cd5e803ffe392dacfa0f06c40f Mon Sep 17 00:00:00 2001
From: MaxEW707
Date: Fri, 21 Jun 2024 20:37:40 -0700
Subject: [PATCH 01/21] Support MSVC lvalue to temporary reference binding
---
clang/
MaxEW707 wrote:
> I'd like to see this change make it into the repo, as I'm in a similar
> situation with a 6+ million line codebase. What's the next steps to advance
> this?
Hey sorry. I've been busy with other work prios and an msvc mangling bug. I
still intend to get back to this as I also
https://github.com/MaxEW707 closed
https://github.com/llvm/llvm-project/pull/117845
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
MaxEW707 wrote:
@shafik
@AaronBallman
@zmodem
I believe I addressed all the feedback. Let me know if I missed anything.
Feel free to ping anyone else I may have missed above :).
https://github.com/llvm/llvm-project/pull/99833
___
cfe-commits mailin
101 - 199 of 199 matches
Mail list logo
