[PATCH] D134454: [Driver][Distro] Fix ArchLinux triplet and sysroot detection

manojgupta added a comment. Thanks for the patch. Can you please post a full diff (git diff -U). Adding @MaskRay as a reviewer. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134454/new/ https://reviews.llvm.org/D134454 ___

[PATCH] D134478: BareMetal: detect usr/include/c++/v1 path in sysroot

manojgupta created this revision. manojgupta added reviewers: MaskRay, barannikov88, abidh. Herald added subscribers: StephenFan, ki.stfu. Herald added a project: All. manojgupta requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Currently bar

[PATCH] D134478: BareMetal: detect usr/include/c++/v1 path in sysroot

manojgupta added a comment. friendly ping for review. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134478/new/ https://reviews.llvm.org/D134478 ___ cfe-commits mailing list cfe-commits@lists.llvm.org ht

[PATCH] D134478: BareMetal: detect usr/include/c++/v1 path in sysroot

manojgupta updated this revision to Diff 465647. manojgupta added a comment. address comments and check CI. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134478/new/ https://reviews.llvm.org/D134478 Files: clang/lib/Driver/ToolChains/BareMetal.c

[PATCH] D134478: BareMetal: detect usr/include/c++/v1 path in sysroot

This revision was automatically updated to reflect the committed changes. Closed by commit rG5e5d21462d1e: BareMetal: detect usr/include/c++/v1 path in sysroot (authored by manojgupta). Changed prior to commit: https://reviews.llvm.org/D134478?vs=465647&id=466250#toc Repository: rG LLVM Gith

[PATCH] D136712: Define _GNU_SOURCE for arm baremetal in C++ mode.

manojgupta updated this revision to Diff 472961. manojgupta added a comment. restore back to C++ only Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136712/new/ https://reviews.llvm.org/D136712 Files: clang/lib/Basic/Targets/ARM.cpp clang/test/

[PATCH] D136712: Define _GNU_SOURCE for arm baremetal in C++ mode.

manojgupta updated this revision to Diff 472962. manojgupta added a comment. Restore back to C++ only. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136712/new/ https://reviews.llvm.org/D136712 Files: clang/lib/Basic/Targets/ARM.cpp clang/test

[PATCH] D136712: Define _GNU_SOURCE for arm baremetal in C++ mode.

manojgupta updated this revision to Diff 473004. manojgupta added a comment. Updated test. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136712/new/ https://reviews.llvm.org/D136712 Files: clang/lib/Basic/Targets/ARM.cpp clang/test/Preprocesso

[PATCH] D136712: Define _GNU_SOURCE for arm baremetal in C++ mode.

This revision was automatically updated to reflect the committed changes. Closed by commit rG2497d5aa7716: Define _GNU_SOURCE for arm baremetal in C++ mode. (authored by manojgupta). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136712/new/ https://

[PATCH] D73534: [DebugInfo] Enable the debug entry values feature by default

manojgupta added a comment. Still causing a crash using a previously supplied test https://bugs.chromium.org/p/chromium/issues/detail?id=1061533#c7. Any reason this was not tested with a previous repro? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73534/new/ https://reviews.llvm.org/

[PATCH] D73534: [DebugInfo] Enable the debug entry values feature by default

manojgupta added a comment. Thanks for the quick fix, verified that the crash is fixed on trunk. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73534/new/ https://reviews.llvm.org/D73534 ___ cfe-commits mailing list cfe-commits@lists.llvm.or

[PATCH] D62627: [NFC] Do not run CGProfilePass when -fno-integrated-as is on

manojgupta added a comment. Thanks, Noticed a few typos. Rest lgtm but deferring to other reviewers for now for approval. Comment at: clang/lib/CodeGen/BackendUtil.cpp:1110 PTO.SLPVectorization = CodeGenOpts.VectorizeSLP; + PTO.CallGrpahProfile = CodeGenOpts.CallGraphProf

[PATCH] D71082: Allow system header to provide their own implementation of some builtin

manojgupta added a comment. We believe this change (relanded as https://reviews.llvm.org/rGd437fba8ef626b6d8b7928540f630163a9b04021) is causing a mis-compile in Linux kernel 4.4 builds resulting in local test failures. Chrome OS bug: https://bugs.chromium.org/p/chromium/issues/detail?id=1066638

[PATCH] D71082: Allow system header to provide their own implementation of some builtin

manojgupta added a comment. Sure, I am trying to root cause the issue. Will report back hopefully soon. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71082/new/ https://reviews.llvm.org/D71082 ___ cfe-

[PATCH] D71082: Allow system header to provide their own implementation of some builtin

manojgupta added subscribers: nickdesaulniers, llozano, srhines. manojgupta added a comment. I was able to reduce to following: typedef unsigned int u32; typedef unsigned long long u64; typedef unsigned long size_t; void fortify_panic(const char *name) __attribute__((noreturn)) ; voi

[PATCH] D71082: Allow system header to provide their own implementation of some builtin

manojgupta added a comment. Unfortunately, cherry-picking the kernel patches didn't work including latest memcpy for x86 (https://github.com/torvalds/linux/commit/170d13ca3a2fdaaa0283399247631b76b441cca2 and https://github.com/torvalds/linux/commit/c228d294f2040c3a5f5965ff04d4947d0bf6e7da ).

[PATCH] D71082: Allow system header to provide their own implementation of some builtin

manojgupta added a comment. Yes, it'd be nice if all of the FORTIFY handling can be improved. For a simple call like memcpy of 8 bytes in the example, there is no reason to emit all these stack/range checks since they'd degrade memcpy performance. I still think this change should be reverted if

[PATCH] D75758: [Sema] Add -Wpointer-to-enum-cast and -Wvoid-pointer-to-enum-cast

manojgupta added a comment. Thanks, Verified that this fixes the kernel warnings in my local builds with https://gist.github.com/nathanchance/767cccf4d093c1342e1994083518815e! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75758/new/ https://review

[PATCH] D73534: [DebugInfo] Enable the debug entry values feature by default

manojgupta added a comment. Hi, I see another crash with this change when building gdb. Reduced test case: struct type *a(type *, type *, long, long); enum b {}; static int empty_array(type *, int c) { type *d = a(__null, d, c, c - 1); } long e; b f() { empty_array(0, e); } Repros with: clang -

[PATCH] D48680: Add missing visibility annotation for __base

manojgupta added a comment. Friendly ping @pcc and @ldionne . We have been carrying this patch I think for too long now. Also, we have not discovered any LTO issues elsewhere so can't tell from our side if there are other places in libc++ that need visibility annotations. Repository: rCXX l

[PATCH] D48680: Add missing visibility annotation for __base

manojgupta added a comment. Thanks a lot! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D48680/new/ https://reviews.llvm.org/D48680 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.

[PATCH] D44815: [AArch64]: Add support for parsing rN registers.

manojgupta created this revision. manojgupta added reviewers: kristof.beyls, rengolin, peter.smith, t.p.northover. Herald added subscribers: eraman, javed.absar. Allow rN registers to be simply parsed as correspoing xN registers. The "register ... asm("rN")" is an command to the compiler's registe

[PATCH] D44815: [AArch64]: Add support for parsing rN registers.

manojgupta updated this revision to Diff 139556. manojgupta added a comment. Indenting and a minor fix. Repository: rC Clang https://reviews.llvm.org/D44815 Files: lib/Basic/Targets/AArch64.cpp test/CodeGen/aarch64-inline-asm.c Index: test/CodeGen/aarch64-inline-asm.c =

[PATCH] D44815: [AArch64]: Add support for parsing rN registers.

manojgupta added a comment. Add more context from the email communication with Peter Smith and Robin Murphy. On 22/03/18 02:34, Manoj Gupta wrote: > Hi Robin, > > this is Manoj from Google. I was looking into implementing support for > parsing "r" registers in clang for AArch64 based on lkml t

[PATCH] D44815: [AArch64]: Add support for parsing rN registers.

manojgupta added a comment. In https://reviews.llvm.org/D44815#1046451, @srhines wrote: > Peter also requested that a test be added to make sure that rY was not > accepted by the Clang assembler as a true synonym for xY. Yes, I am working on that. Wanted to send this out first. Repository:

[PATCH] D44815: [AArch64]: Add support for parsing rN registers.

manojgupta updated this revision to Diff 139759. manojgupta added a comment. 1. Added test case to verify register names are not renamed in unsupported cases. 2. Updated formatting. Repository: rC Clang https://reviews.llvm.org/D44815 Files: lib/Basic/Targets/AArch64.cpp test/CodeGen/aa

[PATCH] D44815: [AArch64]: Add support for parsing rN registers.

This revision was automatically updated to reflect the committed changes. Closed by commit rL328829: [AArch64]: Add support for parsing rN registers. (authored by manojgupta, committed by ). Herald added a subscriber: llvm-commits. Repository: rL LLVM https://reviews.llvm.org/D44815 Files:

[PATCH] D45233: [Driver] Update GCC libraries detection logic for Gentoo.

manojgupta created this revision. manojgupta added a reviewer: mgorny. 1. Find GCC's LDPATH from the actual GCC config file. 2. Make library detection to take into account crossdev installed cross-compiler gcc libraries even when a sysroot is specified. 3. Avoid picking libraries from a similar n

[PATCH] D45233: [Driver] Update GCC libraries detection logic for Gentoo.

manojgupta added a comment. Michał, will appreciate if you can test this on your (multiple?) Gentoo configurations. Will work on updating the testcases after that. To test it locally, I used the following : $ cat test.cpp #include #include int main() { std::cout << " Hello, Worl

[PATCH] D45233: [Driver] Update GCC libraries detection logic for Gentoo.

manojgupta added a reviewer: chandlerc. manojgupta added a comment. Chandler, I recall that you are also a Gentoo user so please take a look. Repository: rC Clang https://reviews.llvm.org/D45233 ___ cfe-commits mailing list cfe-commits@lists.llvm

[PATCH] D45233: [Driver] Update GCC libraries detection logic for Gentoo.

manojgupta updated this revision to Diff 141019. manojgupta added a comment. Address requested changes. Repository: rC Clang https://reviews.llvm.org/D45233 Files: lib/Driver/ToolChains/Gnu.cpp lib/Driver/ToolChains/Gnu.h Index: lib/Driver/ToolChains/Gnu.h ==

[PATCH] D45233: [Driver] Update GCC libraries detection logic for Gentoo.

manojgupta marked 3 inline comments as done. manojgupta added inline comments. Comment at: lib/Driver/ToolChains/Gnu.cpp:2303 + std::pair GentooLibs = ConfLine.split(':'); + GentooScanPaths.push_back(GentooLibs.first.str()); + if (!GentooLib

[PATCH] D45233: [Driver] Update GCC libraries detection logic for Gentoo.

manojgupta added reviewers: thakis, rnk. manojgupta added a comment. Adding more reviewers. Repository: rC Clang https://reviews.llvm.org/D45233 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinf

[PATCH] D45289: Disable -fmerge-all-constants as default.

manojgupta created this revision. manojgupta added reviewers: rjmccall, rsmith, chandlerc. "-fmerge-all-constants" is a non-conforming optimization and should not be the default. It is also causing miscompiles when building Linux Kernel (https://lkml.org/lkml/2018/3/20/872). Fixes PR18538. Repo

[PATCH] D45289: Disable -fmerge-all-constants as default.

manojgupta added a comment. Thanks a lot for the quick review! There a bunch of broken tests because of different IR generated. Is it preferable to fix them individually or add the option -fmerge-all-constants to clang arguments to avoid figuring out changes needed to fix the tests? Reposito

[PATCH] D45289: Disable -fmerge-all-constants as default.

manojgupta updated this revision to Diff 141075. manojgupta added a comment. Removed unused CC1 option and updated broken tests. Repository: rC Clang https://reviews.llvm.org/D45289 Files: include/clang/Driver/Options.td lib/AST/ExprConstant.cpp lib/Driver/ToolChains/Clang.cpp lib/Fr

[PATCH] D45289: Disable -fmerge-all-constants as default.

manojgupta updated this revision to Diff 141081. manojgupta added a comment. Bring back Help Text for "-fno-merge-all-constants" Repository: rC Clang https://reviews.llvm.org/D45289 Files: include/clang/Driver/Options.td lib/AST/ExprConstant.cpp lib/Driver/ToolChains/Clang.cpp lib/Fr

[PATCH] D45289: Disable -fmerge-all-constants as default.

manojgupta added inline comments. Comment at: include/clang/Driver/Options.td:1286 def fno_merge_all_constants : Flag<["-"], "fno-merge-all-constants">, Group, Flags<[CC1Option]>, HelpText<"Disallow merging of constants">; def fno_modules : Flag <["-"], "fno-modules">, Gr

[PATCH] D45233: [Driver] Update GCC libraries detection logic for Gentoo.

manojgupta updated this revision to Diff 141084. manojgupta added a comment. Fix some typos. Reduced indent in the loop. Repository: rC Clang https://reviews.llvm.org/D45233 Files: lib/Driver/ToolChains/Gnu.cpp lib/Driver/ToolChains/Gnu.h Index: lib/Driver/ToolChains/Gnu.h =

[PATCH] D45233: [Driver] Update GCC libraries detection logic for Gentoo.

manojgupta updated this revision to Diff 141096. manojgupta added a comment. Fix a bug in passing the actual path when libraries are present in sysroot. Repository: rC Clang https://reviews.llvm.org/D45233 Files: lib/Driver/ToolChains/Gnu.cpp lib/Driver/ToolChains/Gnu.h test/Driver/In

[PATCH] D45233: [Driver] Update GCC libraries detection logic for Gentoo.

manojgupta added a comment. Modified an existing gentoo sysroot as the test case. Please let me know if you want me checkin a new sysroot. Repository: rC Clang https://reviews.llvm.org/D45233 ___ cfe-commits mailing list cfe-commits@lists.llvm.o

[PATCH] D45233: [Driver] Update GCC libraries detection logic for Gentoo.

manojgupta updated this revision to Diff 141099. manojgupta added a comment. Avoid double appending of sysroot prefix to base path. Repository: rC Clang https://reviews.llvm.org/D45233 Files: lib/Driver/ToolChains/Gnu.cpp lib/Driver/ToolChains/Gnu.h test/Driver/Inputs/gentoo_linux_gcc

[PATCH] D45289: Disable -fmerge-all-constants as default.

This revision was automatically updated to reflect the committed changes. Closed by commit rC329300: Disable -fmerge-all-constants as default. (authored by manojgupta, committed by ). Changed prior to commit: https://reviews.llvm.org/D45289?vs=141081&id=141164#toc Repository: rC Clang https

[PATCH] D45289: Disable -fmerge-all-constants as default.

This revision was automatically updated to reflect the committed changes. Closed by commit rL329300: Disable -fmerge-all-constants as default. (authored by manojgupta, committed by ). Herald added a subscriber: llvm-commits. Repository: rL LLVM https://reviews.llvm.org/D45289 Files: cfe/tru

[PATCH] D45233: [Driver] Update GCC libraries detection logic for Gentoo.

manojgupta updated this revision to Diff 141182. manojgupta added a comment. Updated tests and added a sysroot to test that LDLIBS are picked by parsing /etc/env.d/gcc/tuple-version file. Repository: rC Clang https://reviews.llvm.org/D45233 Files: lib/Driver/ToolChains/Gnu.cpp lib/Driver

[PATCH] D45233: [Driver] Update GCC libraries detection logic for Gentoo.

manojgupta added a comment. My understanding is that some of the tests are failing since we are scanning for Gentoo specific GCC installation first in both sysroot and "/". So, clang succeeds in find the libraries in "/usr/lib/gcc" even when sysroot argument is passed. Previously, "/usr/lib/gcc

[PATCH] D45233: [Driver] Update GCC libraries detection logic for Gentoo.

manojgupta added a comment. I think the tests are already broken in Gentoo when clang is installed in /usr/bin even without this patch. The tests only work if clang binary is not installed in /usr/bin. RootCause is the existing lines in Gnu.cpp: // Then look for gcc installed alongs

[PATCH] D45233: [Driver] Update GCC libraries detection logic for Gentoo.

manojgupta updated this revision to Diff 141295. manojgupta edited the summary of this revision. manojgupta added a comment. Can solve crossdev issue by passing -gcc-toolchain=/usr so just detect gcc libs as an offset to sysroot for now. Repository: rC Clang https://reviews.llvm.org/D45233 F

[PATCH] D45233: [Driver] Update GCC libraries detection logic for Gentoo.

manojgupta added a comment. Michał, can you give the latest change a try? Hopefully it should not break any tests. Repository: rC Clang https://reviews.llvm.org/D45233 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org

[PATCH] D45233: [Driver] Update GCC libraries detection logic for Gentoo.

manojgupta added a comment. I can't reproduce this using the trunk llvm. Does it pass for you if %clang is replaced by %clang++ in the test case? Repository: rC Clang https://reviews.llvm.org/D45233 ___ cfe-commits mailing list cfe-commits@lists

[PATCH] D45233: [Driver] Update GCC libraries detection logic for Gentoo.

This revision was automatically updated to reflect the committed changes. Closed by commit rC329512: [Driver] Update GCC libraries detection logic for Gentoo. (authored by manojgupta, committed by ). Changed prior to commit: https://reviews.llvm.org/D45233?vs=141295&id=141501#toc Repository:

[PATCH] D137379: [-Wunsafe-buffer-usage] Add warnings for unsafe buffer accesses by array subscript operations

manojgupta added a comment. This is firing even in checked length codes, is that expected? example: https://godbolt.org/z/Todje76ao std::optional result; bool ReadDevice(uint8_t* data, size_t len) { if (!result) return false; memset(data, 0, len); if (len > 0) data[0] =

[PATCH] D144331: [libc++][format] Implements formatter thread::id.

manojgupta added a comment. Just a heads up, with this change, we are hitting issues in building gdb. Appreciate any ideas on what is wrong. aarch64-cros-linux-gnu-clang++ -x c++-I. -I. -I./config -DLOCALEDIR="\"/usr/share/locale\"" -DHAVE_CONFIG_H -I./../include/opcode -I../bfd -I./..

[PATCH] D144331: [libc++][format] Implements formatter thread::id.

manojgupta added a comment. I have opened a bug at issuetracker.google.com/issues/277967395 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144331/new/ https://reviews.llvm.org/D144331 ___ cfe-commits mail

[PATCH] D144331: [libc++][format] Implements formatter thread::id.

manojgupta added a comment. Hmm, looking deeper, gdb (actually binutils), is doing something weird. https://github.com/bminor/binutils-gdb/blob/master/include/safe-ctype.h /* Prevent the users of safe-ctype.h from accidently using the routines from ctype.h. Initially, the approach was to

[PATCH] D144331: [libc++][format] Implements formatter thread::id.

manojgupta added a comment. Thanks, sent a patch to gdb at https://sourceware.org/pipermail/gdb-patches/2023-April/198870.html Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144331/new/ https://reviews.llvm.org/D144331

[PATCH] D150226: [Clang] Remove ability to downgrade warning on the diagnostic for setting a non fixed enum to a value outside the range of the enumeration values

manojgupta added a comment. We also use Wno-enum-constexpr-conversion in ChromeOS. There are many packages that break with this warning. One of them is boost which is used in many other packages. The errors in boost were: ./boost/mpl/aux_/integral_wrapper.hpp:73:31: error: integer value -1 i

[PATCH] D150226: [Clang] Remove ability to downgrade warning on the diagnostic for setting a non fixed enum to a value outside the range of the enumeration values

manojgupta added a comment. > I was under the impression from https://github.com/boostorg/mpl/issues/69 > that this was fixed but there are a number of issues off of the main one and > maybe I am confused. Seems like boost 1.81 has the mentioned fix. I can try it and see if the warning still f

[PATCH] D150226: [Clang] Remove ability to downgrade warning on the diagnostic for setting a non fixed enum to a value outside the range of the enumeration values

manojgupta added a comment. In D150226#4338738 , @manojgupta wrote: >> I was under the impression from https://github.com/boostorg/mpl/issues/69 >> that this was fixed but there are a number of issues off of the main one and >> maybe I am confused. > >

[PATCH] D150226: [Clang] Remove ability to downgrade warning on the diagnostic for setting a non fixed enum to a value outside the range of the enumeration values

manojgupta added a comment. https://github.com/bminor/binutils-gdb/blob/master/include/diagnostics.h gdb only suppresses the warning. So this patch will likely break gdb. As per commit: https://github.com/bminor/binutils-gdb/commit/ae61525fcf456ab395d55c45492a106d1275873a Since the current c

[PATCH] D150226: [Clang] Remove ability to downgrade warning on the diagnostic for setting a non fixed enum to a value outside the range of the enumeration values

manojgupta added a comment. In D150226#4342516 , @aaron.ballman wrote: > In D150226#4340166 , @manojgupta > wrote: > >> https://github.com/bminor/binutils-gdb/blob/master/include/diagnostics.h >> >> gdb only sup

[PATCH] D139717: Revert "[Driver] Remove Joined -X"

manojgupta added a comment. The removal is also breaking ChromeOS builds which use -Xpattern in some cases. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139717/new/ https://reviews.llvm.org/D139717 ___

[PATCH] D139717: Revert "[Driver] Remove Joined -X"

manojgupta added a comment. We use -Xcompiler and -Xlinker which are passed in programs and they raise error now. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139717/new/ https://reviews.llvm.org/D139717 _

[PATCH] D139717: Revert "[Driver] Remove Joined -X"

manojgupta added a comment. Xlinker still works. Xcompiler is failing. A google search will show that Xcompiler is a wide-spread option used by many packages. Whether or not GCC supports it is not relevant. Please do not remove options just because you do not use them. Repository: rG LLVM G

[PATCH] D140224: [Driver] Revert D139717 and add -Xparser instead

manojgupta added a comment. Without -Xcompiler, ChromeOS code will break. It may not be supported by GCC but it is supported in some other compilers like Cuda and a few others if you search. Also being supported by libtool makes it more important to keep it working. Repository: rG LLVM Gith

[PATCH] D140224: [Driver] Revert D139717 and add -Xparser instead

manojgupta added a comment. Here are a few instances of Xcompiler usage for a non-exhaustive search (I can't look inside package tarballs if they are using it ): https://chromium.googlesource.com/chromiumos/overlays/chromiumos-overlay/+/main/net-vpn/openvpn/openvpn-2.4.4.ebuild#74 https://chromi

[PATCH] D140224: [Driver] Revert D139717 and add -Xparser instead

manojgupta added a subscriber: rpbeltran. manojgupta added a comment. > If ChromeOS needs time for migration, I think -Xcompiler can be temporarily > ignored. If you can wait for a few weeks, that'd be great. We are already fighting with a large number of ToT issues. And this change makes our b

[PATCH] D32132: [AArch64][clang] Pass cpu/arch information to assembler for AArch64.

manojgupta created this revision. Herald added subscribers: rengolin, aemerson. Pass Cpu/Arch options to assembler for AArch64 with no-integrated-as. This fixes PR20019. https://reviews.llvm.org/D32132 Files: lib/Driver/ToolChains/Gnu.cpp test/Driver/linux-as.c Index: test/Driver/linux-as

[PATCH] D32161: Testing commit access.

manojgupta created this revision. Test commit access. https://reviews.llvm.org/D32161 Files: unittests/Driver/ToolChainTest.cpp Index: unittests/Driver/ToolChainTest.cpp === --- unittests/Driver/ToolChainTest.cpp +++ unittests/

[PATCH] D29773: Add support for armv7ve flag in clang (PR31358).

manojgupta created this revision. Herald added subscribers: rengolin, aemerson. This is a followup change to add v7ve support to clang for gcc compatibility. Armv7ve addition to llvm is currently being reviewed at https://reviews.llvm.org/D29472 . https://reviews.llvm.org/D29773 Files: lib/Ba

[PATCH] D35038: [libunwind] Add a test harness

manojgupta added inline comments. Comment at: test/lit.cfg:36 +else: +lit_config.fatal('Could not find libcxx test directory for test imports' + ' in: %s' % libcxx_test_src_root) I do not have libcxx checked out since I am want to use only

[PATCH] D35038: [libunwind] Add a test harness

manojgupta added inline comments. Comment at: test/lit.cfg:36 +else: +lit_config.fatal('Could not find libcxx test directory for test imports' + ' in: %s' % libcxx_test_src_root) jroelofs wrote: > manojgupta wrote: > > I do not have libcxx

[PATCH] D92892: [clang] Change builtin object size to be compatible with GCC when sub-object is invalid

manojgupta added a comment. This CL has caused two issues in Chrome OS : Compilation fail with FORTIFY: https://bugs.chromium.org/p/chromium/issues/detail?id=1168199 Runtime failures: https://bugs.chromium.org/p/chromium/issues/detail?id=1167504 I have requested George to take a look but will it

[PATCH] D111009: Update inline builtin handling to honor gnu inline attribute

manojgupta added a comment. I am noticing a clang crash with ToT after this change. - testcase -- long a; char b, d; extern inline __attribute__((always_inline)) __attribute__((gnu_inline)) unsigned long strlen() { return a; } c(void) { strlen(&b); return 0; } unsig

[PATCH] D112059: Fix inline builtin handling in case of redefinition

manojgupta added a comment. thanks, I can verify that it fixes the crash we were seeing. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112059/new/ https://reviews.llvm.org/D112059 ___ cfe-commits mailing

[PATCH] D112091: libfuzzer: All building libfuzzer for ARM32

manojgupta created this revision. manojgupta added a reviewer: metzman. Herald added subscribers: kristof.beyls, mgorny. manojgupta requested review of this revision. Herald added a project: Sanitizers. Herald added a subscriber: Sanitizers. We need libfuzzer libraries on Arm32 so that we can fuzz

<    1   2