[PATCH] D72282: [clang-tidy] Add `bugprone-unintended-adl`

logan-5 updated this revision to Diff 243307. logan-5 marked an inline comment as done. logan-5 added a comment. Changed `Whitelist` to `AllowedIdentifiers`. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72282/new/ https://reviews.llvm.org/D72282

[PATCH] D72378: [clang-tidy] Add `bugprone-reserved-identifier`

logan-5 added a comment. Great! In that case, I'll need help committing this, as well as the thing it depends on, https://reviews.llvm.org/D72284 (which has also been LGTM'd). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72378/new/ https://review

[PATCH] D72378: [clang-tidy] Add `bugprone-reserved-identifier`

logan-5 updated this revision to Diff 238640. logan-5 added a comment. Should be good now. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72378/new/ https://reviews.llvm.org/D72378 Files: clang-tools-extra/clang-tidy/bugprone/BugproneTidyModule.c

[PATCH] D72282: [clang-tidy] Add `bugprone-unintended-adl`

logan-5 updated this revision to Diff 240691. logan-5 added a comment. Rebased with trunk. Updated whitelist to include more standard designated customization points . Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://

[PATCH] D152764: [clang-tidy] Reserved-identifier: Improved AllowedIdentifiers option to support regular expressions

logan-5 added a comment. Thanks for the patch. This seems like it'll make the check much more useful. Comment at: clang-tools-extra/clang-tidy/bugprone/ReservedIdentifierCheck.cpp:48 + Options.get("AllowedIdentifiers", ""))) { + for (const auto &Identifier : AllowedId

[PATCH] D116824: [clang-tidy] Fix RenamerClangTidyChecks suggesting invalid macro identifiers

logan-5 created this revision. logan-5 added reviewers: njames93, aaron.ballman. logan-5 added a project: clang-tools-extra. Herald added subscribers: carlosgalvezp, xazax.hun. logan-5 requested review of this revision. Herald added a subscriber: cfe-commits. This behavior was fixed for regular id

[PATCH] D116824: [clang-tidy] Fix RenamerClangTidyChecks suggesting invalid macro identifiers

This revision was automatically updated to reflect the committed changes. Closed by commit rG988c3f5f9692: [clang-tidy] Fix RenamerClangTidyChecks suggesting invalid macro identifiers (authored by logan-5). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.or

[PATCH] D72282: [clang-tidy] Add `bugprone-unintended-adl`

logan-5 added a comment. It's been a year and a half since I heard anything about this patch and I'd honestly kind of forgotten about it. I'm still around/lurking though, and would assist with getting it landed if it's still good to go. Comment at: clang-tools-extra/clang-tid

[PATCH] D115374: [NFC][clang] Return std::strings built from raw_string_ostreams more efficiently

logan-5 created this revision. logan-5 added a reviewer: aaron.ballman. logan-5 added a project: clang. Herald added subscribers: abrachet, ctetreau, dexonsmith, martong. logan-5 requested review of this revision. Herald added a subscriber: cfe-commits. Returning `OS.str()` is guaranteed to copy t

[PATCH] D115374: [NFC][clang] Return std::strings built from raw_string_ostreams more efficiently

logan-5 added inline comments. Comment at: clang/include/clang/StaticAnalyzer/Checkers/SValExplainer.h:36 +OS.flush(); +return Str; } Quuxplusone wrote: > FWIW, it appears to me that in most (all?) of these cases, what's really > wanted is not "a stri

[PATCH] D115374: [NFC][clang] Return std::strings built from raw_string_ostreams more efficiently

logan-5 added a comment. In D115374#3181383 , @dexonsmith wrote: > I don't feel strongly, but IMO the code might be a bit harder to > read/maintain with the explicit flush. I worry that it'd be easy to move the > `flush()` away from the `return`. Not s

[PATCH] D115374: [NFC][clang] Return std::strings built from raw_string_ostreams more efficiently

logan-5 updated this revision to Diff 392996. logan-5 added a comment. Eliminate some explicit `.flush()`es by using temporary `raw_string_ostream`s where possible. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115374/new/ https://reviews.llvm.org

[PATCH] D115374: [NFC][clang] Return std::strings built from raw_string_ostreams more efficiently

logan-5 added a comment. To be clear, it sounds like we should //either// add `.take()` for moving the string out of `raw_string_ostream`'s string reference, //or// make `raw_string_ostream` not need to be flushed (after which there won't be as clear a use for `.take()`, since you can just use

[PATCH] D115374: [NFC][clang] Return std::strings built from raw_string_ostreams more efficiently

logan-5 updated this revision to Diff 393262. logan-5 added a comment. Removed `.flush()`es. Seems like this might be able to land without https://reviews.llvm.org/D115421? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115374/new/ https://reviews.

[PATCH] D115374: [NFC][clang] Return std::strings built from raw_string_ostreams more efficiently

This revision was automatically updated to reflect the committed changes. Closed by commit rG715c72b4fbf4: [NFC][analyzer] Return underlying strings directly instead of OS.str() (authored by logan-5). Changed prior to commit: https://reviews.llvm.org/D115374?vs=393262&id=393319#toc Repository:

<    1   2