[PATCH] D92198: [clangd] Implement remote index handshake

kbobyrev created this revision. Herald added subscribers: cfe-commits, usaxena95, kadircet, arphaman. Herald added a project: clang. kbobyrev requested review of this revision. Herald added subscribers: MaskRay, ilya-biryukov. WIP. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/

[PATCH] D92198: [clangd] Implement remote index handshake

kbobyrev planned changes to this revision. kbobyrev added a comment. This is not working properly yet. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92198/new/ https://reviews.llvm.org/D92198 ___ cfe-com

[PATCH] D92198: [clangd] Implement remote index handshake

kbobyrev updated this revision to Diff 307936. kbobyrev added a comment. Remove some logs. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92198/new/ https://reviews.llvm.org/D92198 Files: clang-tools-extra/clangd/index/Index.h clang-tools-extra

[PATCH] D92198: [clangd] Implement remote index handshake

kbobyrev updated this revision to Diff 307942. kbobyrev added a comment. This is working now. However, the handshake is actually deferred for ProjectAwareIndex until the first request. I tried to invoke it via something like `Opts.StaticIdx->estimateMemoryUsage()` in `ClangdMain.cpp` but the probl

[PATCH] D92198: [clangd] Implement remote index handshake

kbobyrev updated this revision to Diff 307943. kbobyrev added a comment. Remove unused header. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92198/new/ https://reviews.llvm.org/D92198 Files: clang-tools-extra/clangd/index/remote/Client.cpp cla

[PATCH] D92201: [clangd] Make sure project-aware index is up-to-date for estimateMemoryUsage()

kbobyrev created this revision. kbobyrev added a reviewer: sammccall. Herald added subscribers: cfe-commits, usaxena95, arphaman. Herald added a project: clang. kbobyrev requested review of this revision. Herald added subscribers: MaskRay, ilya-biryukov. Repository: rG LLVM Github Monorepo http

[PATCH] D92202: [clangd] Add symbol origin for remote index

kbobyrev created this revision. kbobyrev added a reviewer: sammccall. Herald added subscribers: cfe-commits, usaxena95, arphaman. Herald added a project: clang. kbobyrev requested review of this revision. Herald added subscribers: MaskRay, ilya-biryukov. Makes it easier to diagnose remote index is

[PATCH] D91952: [clangd] Add support for within-file rename of complicated fields

This revision was automatically updated to reflect the committed changes. Closed by commit rGabfcb606c2f8: [clangd] Add support for within-file rename of complicated fields (authored by kbobyrev). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91952/n

[PATCH] D92220: [clangd] Add support for static fields in rename

kbobyrev created this revision. kbobyrev added a reviewer: hokein. Herald added subscribers: cfe-commits, usaxena95, kadircet, arphaman. Herald added a project: clang. kbobyrev requested review of this revision. Herald added subscribers: MaskRay, ilya-biryukov. Follow-up on D91952

[PATCH] D92220: [clangd] Add support for static fields in rename

kbobyrev updated this revision to Diff 308008. kbobyrev added a comment. Add comments and a check to ensure proper behavior. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92220/new/ https://reviews.llvm.org/D92220 Files: clang-tools-extra/clangd

[PATCH] D92201: [clangd] Make sure project-aware index is up-to-date for estimateMemoryUsage()

kbobyrev added a comment. Hm, yes, this makes sense. I just found it awkward that memory usage estimate will spike right after the first request but that's actually the reality (loading the index is deferred until the first actual index request). My confusion here is that I don't really underst

[PATCH] D92202: [clangd] Add symbol origin for remote index

kbobyrev updated this revision to Diff 308016. kbobyrev added a comment. Don't assign additional Remote Origin: overwrite it. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92202/new/ https://reviews.llvm.org/D92202 Files: clang-tools-extra/clang

[PATCH] D92202: [clangd] Add symbol origin for remote index

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG4169c520f6d7: [clangd] Add symbol origin for remote index (authored by kbobyrev). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D92198: [clangd] Implement remote index handshake

kbobyrev updated this revision to Diff 308269. kbobyrev marked 3 inline comments as done. kbobyrev added a comment. Herald added a subscriber: jfb. Use WaitForStateChange instead. Simplify code structure. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org

[PATCH] D92198: [clangd] Implement remote index handshake

kbobyrev added a comment. Yes, the idea here is to provide logging for gRPC server state. My original thought was that default `HealthCheck` might not be enough and we might want to add more things in the mechanism but I guess it's not obvious what these extensions might be and getting `grpc_co

[PATCH] D92788: [clangd] NFC: Use SmallVector where possible

kbobyrev created this revision. kbobyrev added a reviewer: sammccall. Herald added subscribers: usaxena95, kadircet, arphaman, javed.absar. kbobyrev requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added a project: clang. SmallVector with def

[PATCH] D92788: [clangd] NFC: Use SmallVector where possible

kbobyrev added a comment. I've excluded the cases where the size does not seem arbitrary (e.g. `1`/ code relying on `sizeof(Something) == Value`, e.g. dex payloads and CodeCompletion bundles). The rest looks fairly innocent but I don't know all the code around changed lines. Repository: rG

[PATCH] D89529: [clangd][remote] Add Windows paths support

kbobyrev requested changes to this revision. kbobyrev added a comment. This revision now requires changes to proceed. In D89529#2337197 , @ArcsinX wrote: > In D89529#2334517 , @kbobyrev wrote: > >> The solution woul

[PATCH] D89529: [clangd][remote] Add Windows paths support

kbobyrev added inline comments. Comment at: clang-tools-extra/clangd/index/remote/marshalling/Marshalling.cpp:59 +RemoteIndexRoot, llvm::sys::path::Style::windows); +llvm::StringRef Path(*this->RemoteIndexRoot); +if (!Path.endswith(PosixSeparator)) ---

[PATCH] D89529: [clangd][remote] Add Windows paths support

kbobyrev requested changes to this revision. kbobyrev added a comment. This revision now requires changes to proceed. Also, please hit "Done" on the comments you resolved so that it's easier to track which ones are fixed, otherwise it's hard to follow :( The patch looks good now, almost ready to

[PATCH] D89529: [clangd][remote] Add Windows paths support

kbobyrev accepted this revision. kbobyrev added a comment. This revision is now accepted and ready to land. Thank you for the patch! Ready to land it now. Please update the patch message before commiting though: > Without this patch 7 marshalling tests fails on Windows. > This patch contains the

[PATCH] D88553: [clangd] Stash a patch piece

kbobyrev updated this revision to Diff 299281. kbobyrev added a comment. Add support for compound statements. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88553/new/ https://reviews.llvm.org/D88553 Files: clang-tools-extra/clangd/SemanticSelect

[PATCH] D88553: [clangd] Stash a patch piece

kbobyrev updated this revision to Diff 299284. kbobyrev added a comment. Add one more test and remove unused include. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88553/new/ https://reviews.llvm.org/D88553 Files: clang-tools-extra/clangd/Semant

[PATCH] D88553: [clangd] Start using SyntaxTrees for folding ranges feature

kbobyrev added a comment. @sammccall I've reduced the patch to the bare minimum (compound statements) as I've had some issues with couple of other kinds of folding ranges and I'll be adding support for the node kinds one by one. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D89771: [clangd] NFC: Resolve Clang-Tidy warnings in Protocol.cpp

kbobyrev created this revision. kbobyrev added a reviewer: kadircet. Herald added subscribers: cfe-commits, usaxena95, arphaman. Herald added a project: clang. kbobyrev requested review of this revision. Herald added subscribers: MaskRay, ilya-biryukov. Repository: rG LLVM Github Monorepo https

[PATCH] D89771: [clangd] NFC: Resolve Clang-Tidy warnings in Protocol.cpp

kbobyrev updated this revision to Diff 299288. kbobyrev added a comment. Add forgotten fixes. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89771/new/ https://reviews.llvm.org/D89771 Files: clang-tools-extra/clangd/Protocol.cpp Index: clang-to

[PATCH] D89771: [clangd] NFC: Resolve Clang-Tidy warnings in Protocol.cpp

This revision was automatically updated to reflect the committed changes. Closed by commit rG691eb814c1ae: [clangd] NFC: Resolve Clang-Tidy warnings in Protocol.cpp (authored by kbobyrev). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89771/new/ htt

[PATCH] D88553: [clangd] Start using SyntaxTrees for folding ranges feature

kbobyrev added inline comments. Comment at: clang-tools-extra/clangd/SemanticSelection.cpp:52-55 +const syntax::Token *FirstToken = Tree->findFirstLeaf()->getToken(), +*LastToken = Tree->findLastLeaf()->getToken(); +assert(FirstToken->kind() == tok

[PATCH] D88553: [clangd] Start using SyntaxTrees for folding ranges feature

kbobyrev updated this revision to Diff 299438. kbobyrev marked 9 inline comments as done. kbobyrev added a comment. Resolve review comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88553/new/ https://reviews.llvm.org/D88553 Files: clang-to

[PATCH] D88553: [clangd] Start using SyntaxTrees for folding ranges feature

kbobyrev updated this revision to Diff 299449. kbobyrev added a comment. Resolve comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88553/new/ https://reviews.llvm.org/D88553 Files: clang-tools-extra/clangd/SemanticSelection.cpp clang-too

[PATCH] D89851: [clangd] Separate final_result into a different message; NFC

kbobyrev created this revision. kbobyrev added a reviewer: sammccall. Herald added subscribers: cfe-commits, usaxena95, kadircet, arphaman. Herald added a project: clang. kbobyrev requested review of this revision. Herald added subscribers: MaskRay, ilya-biryukov. Repository: rG LLVM Github Mono

[PATCH] D89852: [clangd] Use SmallString instead of std::string in marshalling code; NFC

kbobyrev created this revision. kbobyrev added a reviewer: kadircet. Herald added subscribers: cfe-commits, usaxena95, arphaman. Herald added a project: clang. kbobyrev requested review of this revision. Herald added subscribers: MaskRay, ilya-biryukov. Repository: rG LLVM Github Monorepo https

[PATCH] D89862: [clangd] Give the server information about client's remote index protocol version

kbobyrev created this revision. kbobyrev added a reviewer: sammccall. Herald added subscribers: cfe-commits, usaxena95, arphaman. Herald added a project: clang. kbobyrev requested review of this revision. Herald added subscribers: MaskRay, ilya-biryukov. Repository: rG LLVM Github Monorepo http

[PATCH] D84232: [clangd] Set minimum gRPC version to 1.27

kbobyrev updated this revision to Diff 299618. kbobyrev added a comment. Rebase on top of master. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84232/new/ https://reviews.llvm.org/D84232 Files: clang-tools-extra/clangd/index/remote/README.md l

[PATCH] D88553: [clangd] Start using SyntaxTrees for folding ranges feature

kbobyrev updated this revision to Diff 299619. kbobyrev marked an inline comment as done. kbobyrev added a comment. Prevent code duplication for const-nonconst versions of the same function. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88553/new/

[PATCH] D88553: [clangd] Start using SyntaxTrees for folding ranges feature

kbobyrev updated this revision to Diff 299620. kbobyrev added a comment. Fix a typo and remove invalid const-ness. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88553/new/ https://reviews.llvm.org/D88553 Files: clang-tools-extra/clangd/SemanticS

[PATCH] D84232: [clangd] Set minimum gRPC version to 1.27

kbobyrev updated this revision to Diff 299623. kbobyrev added a comment. Add macOS version check. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84232/new/ https://reviews.llvm.org/D84232 Files: clang-tools-extra/clangd/index/remote/README.md l

[PATCH] D84232: [clangd] Set minimum gRPC version to 1.27

kbobyrev added a comment. https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=965217 is not going anywhere, I think we should just add this check and not check for the correct patch on Debian (and macOS is different anyway). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION http

[PATCH] D89862: [clangd] Give the server information about client's remote index protocol version

kbobyrev added inline comments. Comment at: clang-tools-extra/clangd/index/remote/ProtocolVersion.h:4 +namespace remote { +static const char *RemoteIndexProtocolVersion = "0.1.0"; +} Not sure if having a separate file with a hard-coded string is a good idea, sho

[PATCH] D89870: [clangd] Drop template argument lists from completions followed by

kbobyrev created this revision. kbobyrev added a reviewer: sammccall. Herald added subscribers: cfe-commits, usaxena95, kadircet, arphaman. Herald added a project: clang. kbobyrev requested review of this revision. Herald added subscribers: MaskRay, ilya-biryukov. Now, given `template foo() {}` w

[PATCH] D89882: [clangd] Offset enum values by when marshalling

kbobyrev created this revision. kbobyrev added a reviewer: sammccall. Herald added subscribers: cfe-commits, usaxena95, arphaman. Herald added a project: clang. kbobyrev requested review of this revision. Herald added subscribers: MaskRay, ilya-biryukov. This will allow us detect missing values.

[PATCH] D89851: [clangd] Separate final_result into a different message; NFC

kbobyrev updated this revision to Diff 299705. kbobyrev added a comment. Fix proto formatting Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89851/new/ https://reviews.llvm.org/D89851 Files: clang-tools-extra/clangd/index/remote/Client.cpp clan

[PATCH] D89935: [clangd] NFC: Update FIXME comment regarding lack of c/dtor support

kbobyrev created this revision. kbobyrev added a reviewer: kadircet. Herald added subscribers: cfe-commits, usaxena95, arphaman. Herald added a project: clang. kbobyrev requested review of this revision. Herald added subscribers: MaskRay, ilya-biryukov. Both `SymbolKind` and `indexSymbolKindToSymb

[PATCH] D89935: [clangd] NFC: Update FIXME comment regarding lack of c/dtor support

kbobyrev updated this revision to Diff 299891. kbobyrev marked an inline comment as done. kbobyrev added a comment. Fix typo. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89935/new/ https://reviews.llvm.org/D89935 Files: clang-tools-extra/clang

[PATCH] D89935: [clangd] NFC: Update FIXME comment regarding lack of c/dtor support

kbobyrev added inline comments. Comment at: clang-tools-extra/clangd/FindSymbols.cpp:182 index::SymbolInfo SymInfo = index::getSymbolInfo(&ND); - // FIXME: this is not classifying constructors, destructors and operators - //correctly (they're all "methods"). + // FI

[PATCH] D89935: [clangd] NFC: Update FIXME comment regarding lack of c/dtor support

kbobyrev added a comment. In D89935#2346648 , @kadircet wrote: > Am I missing something? We still have: > > case index::SymbolKind::Constructor: > case index::SymbolKind::Destructor: > return SymbolKind::Constructor; > > in Protocol.cpp. E.g. Const

[PATCH] D89935: [clangd] NFC: Update FIXME comment regarding lack of c/dtor support

kbobyrev added a comment. I thought the point of the comment was us not handling it properly rather than LSP not supporting it (e.g. LSP does support `Operator` but we do not). Then, the comment about ctor and dtor being indistinguishable probably belongs to `Protocol.h/cpp` and `SymbolKind` th

[PATCH] D89862: [clangd] Give the server information about client's remote index protocol version

kbobyrev updated this revision to Diff 299932. kbobyrev marked an inline comment as done. kbobyrev added a comment. Use ClientContext::AddMetadata to propagate VCS version info. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89862/new/ https://revie

[PATCH] D89862: [clangd] Give the server information about client's remote index protocol version

kbobyrev updated this revision to Diff 299933. kbobyrev added a comment. Remove formatting change. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89862/new/ https://reviews.llvm.org/D89862 Files: clang-tools-extra/clangd/index/remote/Client.cpp

[PATCH] D89862: [clangd] Give the server information about client's remote index protocol version

kbobyrev added a comment. In D89862#2346645 , @kadircet wrote: > Regarding versioning of grpc layer. In addition to including a version number > in every request, looks like there's the concept of "versioned-services". > > So we basically change the packa

[PATCH] D89852: [clangd] Use SmallString instead of std::string in marshalling code; NFC

kbobyrev updated this revision to Diff 299934. kbobyrev marked 3 inline comments as done. kbobyrev added a comment. Get rid of llvm::Optional in local and remote paths. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89852/new/ https://reviews.llvm.o

[PATCH] D89862: [clangd] Give the server information about client's remote index protocol version

kbobyrev updated this revision to Diff 300066. kbobyrev added a comment. Add package versioning and make current version v1. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89862/new/ https://reviews.llvm.org/D89862 Files: clang-tools-extra/clangd

[PATCH] D89862: [clangd] Give the server information about client's remote index protocol version

This revision was not accepted when it landed; it landed in state "Needs Revision". This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG81e5f298c431: [clangd] Give the server information about client'

[PATCH] D89852: [clangd] Get rid of llvm::Optional in Remote- and LocalIndexRoot; NFC

kbobyrev updated this revision to Diff 300079. kbobyrev marked an inline comment as done. kbobyrev added a comment. Resolve post-LGTM comment. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89852/new/ https://reviews.llvm.org/D89852 Files: clang-

[PATCH] D89852: [clangd] Get rid of llvm::Optional in Remote- and LocalIndexRoot; NFC

kbobyrev updated this revision to Diff 300080. kbobyrev added a comment. Rebase on top of master Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89852/new/ https://reviews.llvm.org/D89852 Files: clang-tools-extra/clangd/index/remote/marshalling/Ma

[PATCH] D89852: [clangd] Get rid of llvm::Optional in Remote- and LocalIndexRoot; NFC

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG68486f9c3a50: [clangd] Get rid of llvm::Optional in Remote- and LocalIndexRoot; NFC (authored by kbobyrev). Repository: rG LLVM Github Monorepo C

[PATCH] D89852: [clangd] Get rid of llvm::Optional in Remote- and LocalIndexRoot; NFC

kbobyrev added inline comments. Comment at: clang-tools-extra/clangd/index/remote/marshalling/Marshalling.cpp:60 +llvm::StringRef Path(this->RemoteIndexRoot); +if (!is_separator(this->RemoteIndexRoot.back(), + llvm::sys::path::Style::posix)) -

[PATCH] D90016: [clangd] NFC: Rely on ADL in llvm::sys::path calls in marshalling

kbobyrev created this revision. kbobyrev added a reviewer: kadircet. Herald added subscribers: cfe-commits, usaxena95, arphaman. Herald added a project: clang. kbobyrev requested review of this revision. Herald added subscribers: MaskRay, ilya-biryukov. Spelling out `llvm::sys::path::` twice does

[PATCH] D90016: [clangd] NFC: Rely on ADL in llvm::sys::path calls in marshalling

kbobyrev added a comment. The ones you proposed would not work without `using llvm::sys::path::*` which I avoid :( They have to have an argument from `llvm::sys::path::` in order for the lookup to be performed correctly. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https:

[PATCH] D90016: [clangd] NFC: Rely on ADL in llvm::sys::path calls in marshalling

kbobyrev updated this revision to Diff 300222. kbobyrev added a comment. Add using directives for llvm::sys::path functions used more than once. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90016/new/ https://reviews.llvm.org/D90016 Files: clan

[PATCH] D89882: [clangd] Offset enum values by when marshalling

kbobyrev updated this revision to Diff 300229. kbobyrev added a comment. Migrate to proto2 syntax. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89882/new/ https://reviews.llvm.org/D89882 Files: clang-tools-extra/clangd/index/remote/Index.proto

[PATCH] D89882: [clangd] Offset enum values by when marshalling

kbobyrev updated this revision to Diff 300230. kbobyrev marked 3 inline comments as done. kbobyrev added a comment. Remove outdated comment. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89882/new/ https://reviews.llvm.org/D89882 Files: clang-to

[PATCH] D89882: [clangd] Migrate to proto2 syntax

kbobyrev updated this revision to Diff 300231. kbobyrev added a comment. Remove a newline. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89882/new/ https://reviews.llvm.org/D89882 Files: clang-tools-extra/clangd/index/remote/Index.proto clang-

[PATCH] D90031: [clang] Split remote index service definition into a separate file.

kbobyrev accepted this revision. kbobyrev added a comment. This revision is now accepted and ready to land. LGTM, Thank you! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90031/new/ https://reviews.llvm.org/D90031 _

[PATCH] D89882: [clangd] Migrate to proto2 syntax

kbobyrev updated this revision to Diff 300246. kbobyrev added a comment. Remove unnecessary comment and fix a typo. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89882/new/ https://reviews.llvm.org/D89882 Files: clang-tools-extra/clangd/index/re

[PATCH] D89882: [clangd] Migrate to proto2 syntax

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG421a2a0dbbd6: [clangd] Migrate to proto2 syntax (authored by kbobyrev). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://r

[PATCH] D90016: [clangd] NFC: Rely on ADL in llvm::sys::path calls in marshalling

kbobyrev updated this revision to Diff 300249. kbobyrev marked an inline comment as done. kbobyrev added a comment. Resolve the comment Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90016/new/ https://reviews.llvm.org/D90016 Files: clang-tools-e

[PATCH] D90016: [clangd] NFC: Add using directives to avoid spelling out llvm::sys::path

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGe6c4d880fa8c: [clangd] NFC: Add using directives to avoid spelling out llvm::sys::path (authored by kbobyrev). Repository: rG LLVM Github Monorepo

[PATCH] D90047: [clangd] Fix remote-server build and add it to check-clangd

kbobyrev accepted this revision. kbobyrev added a comment. This revision is now accepted and ready to land. Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90047/new/ https://reviews.llvm.org/D90047 __

[PATCH] D88553: [clangd] Start using SyntaxTrees for folding ranges feature

kbobyrev updated this revision to Diff 300479. kbobyrev marked 3 inline comments as done. kbobyrev added a comment. Decompose locations and add checks for FileID == MainFileID. Also, rebase on top of master. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm

[PATCH] D88553: [clangd] Start using SyntaxTrees for folding ranges feature

kbobyrev added inline comments. Comment at: clang-tools-extra/clangd/SemanticSelection.cpp:60 + *RBrace = cast_or_null( + Stmt->findChild(syntax::NodeRole::CloseParen)); +if (!LBrace || !RBrace) sammccall wrote: > strictly this

[PATCH] D89851: [clangd] Separate final_result into a different message; NFC

kbobyrev updated this revision to Diff 300528. kbobyrev added a comment. Rebase on top of master, use proto2 syntax. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89851/new/ https://reviews.llvm.org/D89851 Files: clang-tools-extra/clangd/index/r

[PATCH] D90116: [clangd] Escape Unicode characters to fix Windows builds

kbobyrev created this revision. kbobyrev added reviewers: kadircet, sammccall. Herald added subscribers: cfe-commits, usaxena95, arphaman. Herald added a project: clang. kbobyrev requested review of this revision. Herald added subscribers: MaskRay, ilya-biryukov. Fixes: https://github.com/clangd/c

[PATCH] D90116: [clangd] Escape Unicode characters to fix Windows builds

kbobyrev updated this revision to Diff 300535. kbobyrev added a comment. Use u8 string literals. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90116/new/ https://reviews.llvm.org/D90116 Files: clang-tools-extra/clangd/CodeComplete.h clang-tool

[PATCH] D90116: [clangd] Escape Unicode characters to fix Windows builds

kbobyrev added a comment. Hmm, I see. From the looks of it, the solution for several projects would be add_compile_options("$<$:/utf-8>") add_compile_options("$<$:/utf-8>") But I'm not sure if it makes sense in our case and I don't see many `add_compile_options` in LLVM. Also, I don't have

[PATCH] D89935: [clangd] NFC: Update FIXME comment regarding lack of c/dtor support

kbobyrev updated this revision to Diff 300660. kbobyrev added a comment. Only drop the bits about "they're all considered methods", update XRefs.cpp. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89935/new/ https://reviews.llvm.org/D89935 Files:

[PATCH] D89935: [clangd] NFC: Update FIXME comment regarding lack of c/dtor support

kbobyrev updated this revision to Diff 300661. kbobyrev added a comment. Rebase on top of master. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89935/new/ https://reviews.llvm.org/D89935 Files: clang-tools-extra/clangd/FindSymbols.cpp clang-to

[PATCH] D89935: [clangd] NFC: Update FIXME comment regarding lack of c/dtor support

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG1704704e762f: [clangd] NFC: Update FIXME comment regarding lack of c/dtor support (authored by kbobyrev). Repository: rG LLVM Github Monorepo CHA

[PATCH] D89851: [clangd] Separate final_result into a different message

kbobyrev updated this revision to Diff 300936. kbobyrev marked 3 inline comments as done. kbobyrev added a comment. Address post-LGTM comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89851/new/ https://reviews.llvm.org/D89851 Files: clang

[PATCH] D89851: [clangd] Separate final_result into a different message

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGd26dd743084a: [clangd] Separate final_result into a different message (authored by kbobyrev). Repository: rG LLVM Github Monorepo CHANGES SINCE L

[PATCH] D90215: [CMake] Support inter-proto dependencies in generate_protos.

kbobyrev added inline comments. Comment at: llvm/cmake/modules/FindGRPC.cmake:118 + # DEPENDS arg is a list of "Foo.proto". + foreach(ImportedProto IN LISTS PROTO_DEPENDS) +# Foo.proto -> Foo.pb.h On line 89 the argument is called `DEPENDS` (also in the com

[PATCH] D88553: [clangd] Start using SyntaxTrees for folding ranges feature

kbobyrev updated this revision to Diff 301008. kbobyrev added a comment. Address post-LGTM comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88553/new/ https://reviews.llvm.org/D88553 Files: clang-tools-extra/clangd/SemanticSelection.cpp

[PATCH] D88553: [clangd] Start using SyntaxTrees for folding ranges feature

kbobyrev updated this revision to Diff 301009. kbobyrev added a comment. Resolve merge conflict. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88553/new/ https://reviews.llvm.org/D88553 Files: clang-tools-extra/clangd/SemanticSelection.cpp cla

[PATCH] D88553: [clangd] Start using SyntaxTrees for folding ranges feature

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG5ad6bbacf091: [clangd] Start using SyntaxTrees for folding ranges feature (authored by kbobyrev). Repository: rG LLVM Github Monorepo CHANGES SIN

[PATCH] D90291: [clangd] Add lit tests for remote index

kbobyrev created this revision. kbobyrev added a reviewer: kadircet. Herald added subscribers: cfe-commits, usaxena95, arphaman, mgorny. Herald added a project: clang. kbobyrev requested review of this revision. Herald added subscribers: MaskRay, ilya-biryukov. Repository: rG LLVM Github Monorep

[PATCH] D90291: [clangd] Add lit tests for remote index

kbobyrev updated this revision to Diff 301268. kbobyrev added a comment. Fix test except shutting down part :( Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90291/new/ https://reviews.llvm.org/D90291 Files: clang-tools-extra/clangd/test/CMakeLis

[PATCH] D90291: [clangd] Add lit tests for remote index

kbobyrev updated this revision to Diff 301298. kbobyrev added a comment. Push the Franken-pytest. Benefits: doesn't fail, is platform independent (to be determined). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90291/new/ https://reviews.llvm.org/

[PATCH] D90291: [clangd] Add lit tests for remote index

kbobyrev updated this revision to Diff 301303. kbobyrev added a comment. Don't change the existing Python formatting. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90291/new/ https://reviews.llvm.org/D90291 Files: clang-tools-extra/clangd/test/C

[PATCH] D90215: [CMake] Support inter-proto dependencies in generate_protos.

kbobyrev added a comment. LGTM, thanks! Comment at: llvm/cmake/modules/FindGRPC.cmake:118 + # DEPENDS arg is a list of "Foo.proto". + foreach(ImportedProto IN LISTS PROTO_DEPENDS) +# Foo.proto -> Foo.pb.h sammccall wrote: > kbobyrev wrote: > > On line 89

[PATCH] D89126: [clangd] Support CodeActionParams.only

kbobyrev accepted this revision. kbobyrev added a comment. This revision is now accepted and ready to land. Sorry, it seems I forgot about this one :( LG Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89126/new/ https://reviews.llvm.org/D89126 ___

[PATCH] D90376: [clangd] Add requests logging to clangd-index-server

kbobyrev created this revision. kbobyrev added a reviewer: kadircet. Herald added subscribers: cfe-commits, usaxena95, arphaman. Herald added a project: clang. kbobyrev requested review of this revision. Herald added subscribers: MaskRay, ilya-biryukov. This will allow us to track metrics of the s

[PATCH] D90291: [clangd] Add lit tests for remote index

kbobyrev updated this revision to Diff 301606. kbobyrev marked 8 inline comments as done. kbobyrev added a comment. Resolve review comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90291/new/ https://reviews.llvm.org/D90291 Files: clang-to

[PATCH] D90291: [clangd] Add lit tests for remote index

kbobyrev updated this revision to Diff 301607. kbobyrev added a comment. Rebase on top of master. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90291/new/ https://reviews.llvm.org/D90291 Files: clang-tools-extra/clangd/test/CMakeLists.txt clan

[PATCH] D90291: [clangd] Add lit tests for remote index

kbobyrev added inline comments. Comment at: clang-tools-extra/clangd/test/remote-index/pipeline.test:3 +# RUN: clangd-indexer %/S/../Inputs/remote-index/Source.cpp > %t.in.dex +# RUN: python %/S/pipeline_helper.py --input-file-name=%s --server-address=0.0.0.0:50051 --test-direct

[PATCH] D90291: [clangd] Add lit tests for remote index

kbobyrev updated this revision to Diff 301619. kbobyrev marked an inline comment as done. kbobyrev added a comment. Rebase on top of master, don't force forward slashes in project root, format Python helper. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.

[PATCH] D90291: [clangd] Add lit tests for remote index

kbobyrev updated this revision to Diff 302213. kbobyrev marked 6 inline comments as done. kbobyrev added a comment. Resolve post-LGTM commentts, increase index hot reload frequency. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90291/new/ https://r

[PATCH] D90291: [clangd] Add lit tests for remote index

kbobyrev added inline comments. Comment at: clang-tools-extra/clangd/test/remote-index/pipeline_helper.py:36 + ], + stderr=subprocess.PIPE) + kadircet wrote: > nit: formatting looks off, is this really what yapf offers? Y

[PATCH] D90291: [clangd] Add lit tests for remote index

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG76a168bce01d: [clangd] Add lit tests for remote index (authored by kbobyrev). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION htt

[PATCH] D90291: [clangd] Add lit tests for remote index

kbobyrev added inline comments. Comment at: clang-tools-extra/clangd/test/remote-index/pipeline_helper.py:51 + clangd_process.wait() + os.kill(index_server_process.pid, 9) + kadircet wrote: > can we rather use `signal.SIGXXX` here instead of `9` ? > > Also rat

[PATCH] D90587: [clangd] Control the delay between index hot reloading in remote-server-index

kbobyrev created this revision. kbobyrev added a reviewer: kadircet. Herald added subscribers: cfe-commits, usaxena95, arphaman. Herald added a project: clang. kbobyrev requested review of this revision. Herald added subscribers: MaskRay, ilya-biryukov. This helps reduce the time needed for remote

<    5   6   7   8   9   10   11   12   13   14   >