[PATCH] D55062: [clangd] Partition include graph on auto-index.

kadircet updated this revision to Diff 176356. kadircet added a comment. - Rebase Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55062/new/ https://reviews.llvm.org/D55062 Files: clangd/index/Background.cpp unittests/clangd/BackgroundIndexTests.

[PATCH] D55224: [clangd] Introduce loading of shards within auto-index

kadircet created this revision. kadircet added a reviewer: ilya-biryukov. Herald added subscribers: cfe-commits, arphaman, jkorous, MaskRay, ioeric. Whenever a change happens on a CDB, load shards associated with that CDB before issuing re-index actions. Repository: rCTE Clang Tools Extra htt

[PATCH] D55062: [clangd] Partition include graph on auto-index.

kadircet updated this revision to Diff 176415. kadircet marked 3 inline comments as done. kadircet added a comment. - Addresss comments - Make sure there are no uninitialized values in IncludeGraphNode. Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D5

[PATCH] D55260: [CodeComplete] Fix a crash in access checks of inner classes

kadircet added inline comments. Comment at: lib/Sema/SemaCodeComplete.cpp:1348 +} +return Results.getSema().IsSimplyAccessible(ND, Cls, BaseType); + } I suppose `Cls` should be `NamingClass` Repository: rC Clang CHANGES SINCE LAST ACTION https://r

[PATCH] D55062: [clangd] Partition include graph on auto-index.

kadircet updated this revision to Diff 176594. kadircet marked 2 inline comments as done. kadircet added a comment. - Address comments Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55062/new/ https://reviews.llvm.org/D55062 Files: clangd/Headers.

[PATCH] D55062: [clangd] Partition include graph on auto-index.

This revision was automatically updated to reflect the committed changes. Closed by commit rL348252: [clangd] Partition include graph on auto-index. (authored by kadircet, committed by ). Herald added a subscriber: llvm-commits. Repository: rL LLVM CHANGES SINCE LAST ACTION https://reviews.l

[PATCH] D55260: [CodeComplete] Fix a crash in access checks of inner classes

kadircet added a comment. I believe also we need another test case where `Cls` and `NamingClass` are different. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55260/new/ https://reviews.llvm.org/D55260 ___ cfe-commit

[PATCH] D55275: [clangd] Dont provide locations for non-existent files.

kadircet created this revision. kadircet added a reviewer: hokein. Herald added subscribers: cfe-commits, arphaman, jkorous, MaskRay, ioeric, ilya-biryukov. We were getting assertion errors when we had bad file names, instead we should skip those. Repository: rCTE Clang Tools Extra https://r

[PATCH] D55275: [clangd] Dont provide locations for non-existent files.

kadircet updated this revision to Diff 176774. kadircet marked an inline comment as done. kadircet added a comment. - Revert rL346488 partially. Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55275/new/ https://rev

[PATCH] D55275: [clangd] Dont provide locations for non-existent files.

This revision was automatically updated to reflect the committed changes. Closed by commit rL348359: [clangd] Dont provide locations for non-existent files. (authored by kadircet, committed by ). Herald added a subscriber: llvm-commits. Repository: rL LLVM CHANGES SINCE LAST ACTION https://r

[PATCH] D55315: [clangd] Only reduce priority of a thread for indexing.

kadircet created this revision. kadircet added a reviewer: ilya-biryukov. Herald added subscribers: cfe-commits, jfb, arphaman, jkorous, MaskRay, ioeric. We'll soon have tasks pending for reading shards from disk, we want them to have normal priority. Because: - They are not CPU intensive, mostly

[PATCH] D55315: [clangd] Only reduce priority of a thread for indexing.

kadircet updated this revision to Diff 176834. kadircet marked 2 inline comments as done. kadircet added a comment. - Move priority change logic into enqueueTask Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55315/new/ https://reviews.llvm.org/D5531

[PATCH] D55260: [CodeComplete] Fix a crash in access checks of inner classes

kadircet accepted this revision. kadircet added a comment. This revision is now accepted and ready to land. LGTM, thanks! Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55260/new/ https://reviews.llvm.org/D55260 ___ c

[PATCH] D55331: [CodeComplete] Fix assertion failure

kadircet accepted this revision. kadircet added a comment. This revision is now accepted and ready to land. LGTM Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55331/new/ https://reviews.llvm.org/D55331 ___ cfe-commit

[PATCH] D55224: [clangd] Introduce loading of shards within auto-index

kadircet updated this revision to Diff 177005. kadircet added a comment. - Fix a few problems that come up in the field test. Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55224/new/ https://reviews.llvm.org/D55224 Files: clangd/SourceCode.cpp

[PATCH] D55315: [clangd] Only reduce priority of a thread for indexing.

kadircet updated this revision to Diff 177007. kadircet marked 2 inline comments as done. kadircet added a comment. - Delete redundant comment Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55315/new/ https://reviews.llvm.org/D55315 Files: clangd/

[PATCH] D55315: [clangd] Only reduce priority of a thread for indexing.

kadircet added inline comments. Comment at: clangd/index/Background.cpp:202 std::lock_guard Lock(QueueMu); -Queue.push_back(std::move(T)); +if (Priority == ThreadPriority::Low) { + Queue.push_back(Bind( ilya-biryukov wrote: > Since we might be i

[PATCH] D55417: [clangd] Change diskbackedstorage to be atomic

kadircet created this revision. kadircet added a reviewer: ilya-biryukov. Herald added subscribers: cfe-commits, jfb, arphaman, jkorous, MaskRay, ioeric. There was a chance that multiple clangd instances could try to write same shard, in which case we would get a malformed file most likely. This p

[PATCH] D55417: [clangd] Change diskbackedstorage to be atomic

kadircet updated this revision to Diff 177146. kadircet added a comment. - Fix returns Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55417/new/ https://reviews.llvm.org/D55417 Files: clangd/index/BackgroundIndexStorage.cpp Index: clangd/index/B

[PATCH] D55417: [clangd] Change disk-backed storage to be atomic

kadircet updated this revision to Diff 177181. kadircet marked 2 inline comments as done. kadircet added a comment. - Address comments Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55417/new/ https://reviews.llvm.org/D55417 Files: clangd/index/Ba

[PATCH] D55315: [clangd] Only reduce priority of a thread for indexing.

kadircet added inline comments. Comment at: clangd/index/Background.cpp:202 std::lock_guard Lock(QueueMu); -Queue.push_back(std::move(T)); +if (Priority == ThreadPriority::Low) { + Queue.push_back(Bind( ilya-biryukov wrote: > kadircet wrote: > >

[PATCH] D55315: [clangd] Only reduce priority of a thread for indexing.

kadircet updated this revision to Diff 177188. kadircet marked 3 inline comments as done. kadircet added a comment. - Move priority change logic to runner - Change storage for tasks from deque to list, since we only pop from front but we might end up adding into middle. Repository: rCTE Clang

[PATCH] D55431: [CodeComplete] Set preferred type to bool on conditions

kadircet accepted this revision. kadircet added a comment. This revision is now accepted and ready to land. LGTM Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55431/new/ https://reviews.llvm.org/D55431 ___ cfe-commit

[PATCH] D58541: [CodeComplete] Propagate preferred type for function arguments in more cases

kadircet accepted this revision. kadircet added a comment. This revision is now accepted and ready to land. Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58541/new/ https://reviews.llvm.org/D58541

[PATCH] D58448: [clangd] Improve global code completion when scope specifier is unresolved.

kadircet added a comment. LG Do we have any metrics regarding change in completion quality? Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58448/new/ https://reviews.llvm.org/D58448 ___ cfe-commits mail

[PATCH] D56718: [clangd] Update docs to mention YCM integration and new LSP features

kadircet updated this revision to Diff 188327. kadircet added a comment. Herald added a project: clang. - Revert YCM related parts Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56718/new/ https://reviews.llvm.org/D56718 Files: docs/clangd.rst I

[PATCH] D56718: [clangd] Update docs to mention YCM integration and new LSP features

kadircet updated this revision to Diff 188329. kadircet added a comment. - Rebase Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56718/new/ https://reviews.llvm.org/D56718 Files: docs/clangd/index.rst Index: docs/clangd/index.rst ===

[PATCH] D56718: [clangd] Update docs to mention YCM integration and new LSP features

This revision was automatically updated to reflect the committed changes. Closed by commit rL354865: [clangd] Update docs to mention YCM integration and new LSP features (authored by kadircet, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Repository: rL

[PATCH] D58340: [clang][Index] Visit UsingDecls and generate USRs for them

This revision was automatically updated to reflect the committed changes. Closed by commit rL354878: [clang][Index] Visit UsingDecls and generate USRs for them (authored by kadircet, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Repository: rL LLVM CHAN

[PATCH] D58340: [clang][Index] Visit UsingDecls and generate USRs for them

kadircet updated this revision to Diff 188361. kadircet marked an inline comment as done. kadircet added a comment. - Revert SymbolSubKind change - Add test to check for SymbolKind Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58340/new/ https://reviews.llvm.org/

[PATCH] D58341: [clangd] Index UsingDecls

This revision was automatically updated to reflect the committed changes. Closed by commit rCTE354879: [clangd] Index UsingDecls (authored by kadircet, committed by ). Changed prior to commit: https://reviews.llvm.org/D58341?vs=188170&id=188363#toc Repository: rCTE Clang Tools Extra CHANGES

[PATCH] D58814: [clang][Index] Constructors and Destructors do not reference class

kadircet created this revision. kadircet added reviewers: akyrtzi, gribozavr. Herald added subscribers: cfe-commits, arphaman. Herald added a project: clang. In current indexing logic we get references to class itself when we see a constructor/destructor which is not true. Eventough spelling is sa

[PATCH] D58815: [clangd] Make sure constructors do not reference class

kadircet created this revision. kadircet added a reviewer: gribozavr. Herald added subscribers: cfe-commits, arphaman, jkorous, MaskRay, ioeric, ilya-biryukov. Herald added a project: clang. kadircet added a parent revision: D58814: [clang][Index] Constructors and Destructors do not reference cla

[PATCH] D58815: [clangd] Make sure constructors do not reference class

kadircet updated this revision to Diff 188878. kadircet marked an inline comment as done. kadircet added a comment. Re-arrange test location Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58815/new/ https://reviews.llvm.org/D58815 Files: unittests

[PATCH] D56370: [clangd] Add support for type hierarchy (super types only for now)

kadircet added inline comments. Comment at: clang-tools-extra/clangd/ClangdServer.cpp:365 Callback CB) { - auto Action = [Sel](decltype(CB) CB, std::string File, -std::string TweakID, -Expecte

[PATCH] D58880: [WIP] [Looking for API feedback] [clangd] Type hierarchy subtypes

kadircet added a comment. For starters, what about just introducing a new field `Bases` into the `Symbol`. Which can store symbol IDs for the parents of the mentioned symbol, then during index build we can simply add same relations from base to this symbol. This should help us get rid of `Relat

[PATCH] D58814: [clang][Index] Constructors and Destructors do not reference class

kadircet added a comment. I agree with Dmitri's reasoning. I believe this should be handled inside the `renamer`s logic as mentioned in option 1. But if you believe this should not be the case, I am also happy to move logic of `adding a reference to class` on constructors&destructors to the con

[PATCH] D58880: [WIP] [Looking for API feedback] [clangd] Type hierarchy subtypes

kadircet added a comment. Sorry I didn't notice the mailing thread beforehand, looks like Sam had a good point regarding performing operations on types rather than symbols(http://lists.llvm.org/pipermail/clangd-dev/2019-January/000241.html). Does current implementation take this into account by

[PATCH] D58600: [clangd] Emit source to Diagnostic.

kadircet accepted this revision. kadircet added a comment. This revision is now accepted and ready to land. LGTM Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58600/new/ https://reviews.llvm.org/D58600

[PATCH] D56370: [clangd] Add support for type hierarchy (super types only for now)

kadircet added inline comments. Comment at: clang-tools-extra/clangd/ClangdServer.cpp:365 Callback CB) { - auto Action = [Sel](decltype(CB) CB, std::string File, -std::string TweakID, -Expecte

[PATCH] D59079: [clang][Tooling] Delete dots and dotdots when generating absolute paths

kadircet created this revision. kadircet added a reviewer: hokein. Herald added a project: clang. Herald added a subscriber: cfe-commits. GetAllFiles interface returns absolute paths, but keeps dots and dot dots. This patch makes those paths canonical by deleting them. Repository: rC Clang ht

[PATCH] D59083: [clangd] Store explicit template specializations in index for code navigation purposes

kadircet created this revision. kadircet added reviewers: hokein, gribozavr. Herald added subscribers: cfe-commits, jdoerfert, arphaman, jkorous, MaskRay, ioeric, ilya-biryukov. Herald added a project: clang. This introduces ~4k new symbols, and ~10k refs for LLVM. We need that information for pr

[PATCH] D59084: [clangd] Remove ./ and ../ in the file paths

kadircet created this revision. kadircet added a reviewer: hokein. Herald added subscribers: cfe-commits, arphaman, jkorous, MaskRay, ioeric, ilya-biryukov. Herald added a project: clang. Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D59084 Files: clangd/index/Background.cpp

[PATCH] D59086: [clangd] Adjust compile commands to be applicable for tooling

kadircet created this revision. kadircet added reviewers: gribozavr, hokein. Herald added subscribers: cfe-commits, jdoerfert, arphaman, jkorous, MaskRay, ioeric, ilya-biryukov. Herald added a project: clang. As can be seen in https://github.com/llvm-mirror/clang/blob/master/lib/Tooling/Tooling.

[PATCH] D59086: [clangd] Adjust compile commands to be applicable for tooling

kadircet updated this revision to Diff 189682. kadircet added a comment. - Update the diff, sorry for the confusion Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59086/new/ https://reviews.llvm.org/D59086 Files: clangd/GlobalCompilationDatabase.c

[PATCH] D58814: [clang][Index] Constructors and Destructors do not reference class

kadircet updated this revision to Diff 189695. kadircet added a comment. - Add NameReference role kind, and tag references from constructors/destructors to the class with that kind. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58814/new/ https://reviews.llvm.or

[PATCH] D59086: [clangd] Adjust compile commands to be applicable for tooling

kadircet marked an inline comment as done. kadircet added inline comments. Comment at: clangd/GlobalCompilationDatabase.h:116 + /// Adjusts given compile command for clangd. + tooling::CompileCommand adjustArguments(tooling::CompileCommand Cmd) const; + hokein

[PATCH] D58814: [clang][Index] Constructors and Destructors do not reference class

kadircet added a comment. As discussed offline constructor calls are a different issue, coming from even a different layer than Indexing API. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58814/new/ https://reviews.llvm.org/D58814

[PATCH] D58814: [clang][Index] Constructors and Destructors do not reference class

kadircet updated this revision to Diff 189703. kadircet marked 2 inline comments as done. kadircet added a comment. - Delete extra parens Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58814/new/ https://reviews.llvm.org/D58814 Files: include/clang/Index/IndexS

[PATCH] D59086: [clangd] Adjust compile commands to be applicable for tooling

kadircet updated this revision to Diff 189706. kadircet marked 2 inline comments as done. kadircet added a comment. - Change testing strategy Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59086/new/ https://reviews.llvm.org/D59086 Files: clangd/G

[PATCH] D59092: [clangd] Deduplicate Refs on the fly.

kadircet accepted this revision. kadircet added inline comments. This revision is now accepted and ready to land. Comment at: clangd/index/Ref.cpp:44 RefSlab RefSlab::Builder::build() && { // We can reuse the arena, as it only has unique strings and we need them all. -

[PATCH] D59086: [clangd] Adjust compile commands to be applicable for tooling

kadircet marked an inline comment as done. kadircet added inline comments. Comment at: clangd/GlobalCompilationDatabase.cpp:24 llvm::StringRef ResourceDir) { + // Clangd does not generate dependency file. + Cmd.CommandLine = tooling::getClangStripDependenc

[PATCH] D58880: [WIP] [Looking for API feedback] [clangd] Type hierarchy subtypes

kadircet added a comment. Hi Nathan, I would also suggest splitting up current changes so that we can start reviewing them, which might result in other changes in your planned changes and help reduce duplicate work both on our and your side. Also please have a look at D59083

[PATCH] D59083: [clangd] Store explicit template specializations in index for code navigation purposes

kadircet updated this revision to Diff 189817. kadircet marked 3 inline comments as done. kadircet added a comment. - Address comments Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59083/new/ https://reviews.llvm.org/D59083 Files: clangd/CodeComp

[PATCH] D58814: [clang][Index] Mark references from Constructors and Destructors to class as NameReference

This revision was automatically updated to reflect the committed changes. Closed by commit rC355668: [clang][Index] Mark references from Constructors and Destructors to class as… (authored by kadircet, committed by ). Changed prior to commit: https://reviews.llvm.org/D58814?vs=189703&id=189818#

[PATCH] D59086: [clangd] Adjust compile commands to be applicable for tooling

kadircet updated this revision to Diff 189819. kadircet marked 3 inline comments as done. kadircet added a comment. - Address comments Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59086/new/ https://reviews.llvm.org/D59086 Files: clangd/GlobalCo

[PATCH] D59086: [clangd] Adjust compile commands to be applicable for tooling

This revision was automatically updated to reflect the committed changes. Closed by commit rL355669: [clangd] Adjust compile commands to be applicable for tooling (authored by kadircet, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Repository: rL LLVM C

[PATCH] D59084: [clangd] Remove ./ and ../ in the file paths

kadircet updated this revision to Diff 189828. kadircet added a comment. Herald added a subscriber: jdoerfert. - Add tests Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59084/new/ https://reviews.llvm.org/D59084 Files: clangd/index/Background.cpp

[PATCH] D59079: [clang][Tooling] Delete dots and dotdots when generating absolute paths

This revision was automatically updated to reflect the committed changes. kadircet marked an inline comment as done. Closed by commit rL355678: [clang][Tooling] Delete dots and dotdots when generating absolute paths (authored by kadircet, committed by ). Herald added a project: LLVM. Herald added

[PATCH] D58815: [clangd] Make sure constructors do not reference class

kadircet updated this revision to Diff 189831. kadircet added a comment. - Make use of NameReference symbol role Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58815/new/ https://reviews.llvm.org/D58815 Files: clangd/XRefs.cpp clangd/index/Symbo

[PATCH] D58815: [clangd] Make sure constructors do not reference class

kadircet updated this revision to Diff 189832. kadircet marked an inline comment as done. kadircet added a comment. - Address comments Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58815/new/ https://reviews.llvm.org/D58815 Files: clangd/XRefs.cp

[PATCH] D58815: [clangd] Make sure constructors do not reference class

This revision was automatically updated to reflect the committed changes. Closed by commit rCTE355679: [clangd] Make sure constructors do not reference class (authored by kadircet, committed by ). Changed prior to commit: https://reviews.llvm.org/D58815?vs=189832&id=189833#toc Repository: rC

[PATCH] D59084: [clangd] Remove ./ and ../ in the file paths

This revision was automatically updated to reflect the committed changes. Closed by commit rCTE355681: [clangd] Remove ./ and ../ in the file paths (authored by kadircet, committed by ). Changed prior to commit: https://reviews.llvm.org/D59084?vs=189828&id=189835#toc Repository: rCTE Clang T

[PATCH] D58749: [index-while-building] IndexRecordHasher

kadircet added inline comments. Comment at: clang/lib/Index/IndexRecordHasher.h:41 + /// Returns hash for all declaration occurences in \c Record. + llvm::hash_code hashRecord(const FileIndexRecord &Record); + llvm::hash_code hash(const Decl *D); Why expose ha

[PATCH] D59205: [clangd] Respect Origin option in createStaticIndexingAction

kadircet created this revision. kadircet added a reviewer: ioeric. Herald added subscribers: cfe-commits, arphaman, jkorous, MaskRay, ilya-biryukov. Herald added a project: clang. Currently createStaticIndexingAction always set Origin to Static, which makes it hard to change it later on by differ

[PATCH] D59205: [clangd] Respect Origin option in createStaticIndexingAction

This revision was automatically updated to reflect the committed changes. Closed by commit rCTE355820: [clangd] Respect Origin option in createStaticIndexingAction (authored by kadircet, committed by ). Changed prior to commit: https://reviews.llvm.org/D59205?vs=190062&id=190066#toc Repository

[PATCH] D59083: [clangd] Store explicit template specializations in index for code navigation purposes

kadircet added a comment. In D59083#1424509 , @nridge wrote: > Is any representation of the template arguments stored in the index? No we only have, class name if you want to do a "name based" search/lookup. But symbol IDs for template specializations a

[PATCH] D56370: [clangd] Add support for type hierarchy (super types only for now)

kadircet marked an inline comment as done. kadircet added a comment. In D56370#1424177 , @nridge wrote: > Fix a (somewhat amusing) typo where I wrote '0' instead of 'O' in a > fromJSON() implementation > > (Does the fact that this didn't cause any test fa

[PATCH] D56370: [clangd] Add support for type hierarchy (super types only for now)

kadircet added inline comments. Comment at: clang-tools-extra/unittests/clangd/XRefsTests.cpp:1496 +TEST(FindRecordTypeAt, TypeOrVariable) { + Annotations Source(R"cpp( Sorry for not pointing this out before, but it would be great if you could move related te

[PATCH] D58749: [index-while-building] IndexRecordHasher

kadircet added a comment. > I basically didn't really like the idea of testing against hard-coded hash > values in unittests as I consider it to be an implementation detail. I was > thinking about integration tests that would work around this by both writing > index and reading index and writin

[PATCH] D56370: [clangd] Add support for type hierarchy (super types only for now)

kadircet added a comment. In D56370#1427075 , @nridge wrote: > Ok, I filed a Theia issue > about it for now. Thanks! In D56370#1427076 , @nridge wrote: > Are the

[PATCH] D59083: [clangd] Store explicit template specializations in index for code navigation purposes

kadircet updated this revision to Diff 190382. kadircet marked an inline comment as done. kadircet added a comment. - Agree on ilya-biryukov@'s suggestion, changing fuzzyfind to skip template (partial) specializations for now. Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION ht

[PATCH] D59083: [clangd] Store explicit template specializations in index for code navigation purposes

kadircet added a comment. In D59083#1426105 , @ilya-biryukov wrote: > To split this into multiple independent changes, we could start with storing > the symbols for template specializations, but only showing the primary > template in the results of work

[PATCH] D59302: [clangd] Surface diagnostics from headers inside main file

kadircet created this revision. kadircet added reviewers: ioeric, ilya-biryukov. Herald added subscribers: cfe-commits, jdoerfert, arphaman, jkorous, MaskRay. Herald added a project: clang. Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D59302 Files: clangd/ClangdServer.cpp cl

[PATCH] D59083: [clangd] Store explicit template specializations in index for code navigation purposes

This revision was automatically updated to reflect the committed changes. Closed by commit rL356125: [clangd] Store explicit template specializations in index for code navigation… (authored by kadircet, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Reposit

[PATCH] D59350: [clangd] Build Dex index after loading all shards in BackgroundIndex.

kadircet accepted this revision. kadircet added inline comments. This revision is now accepted and ready to land. Comment at: clangd/index/Background.cpp:609 + reset(IndexedSymbols.buildIndex(IndexType::Heavy, DuplicateHandling::Merge)); + vlog("BackgroundIndex: built symbol in

[PATCH] D59354: [clangd] Print arguments in template specializations

kadircet created this revision. kadircet added a reviewer: ilya-biryukov. Herald added subscribers: cfe-commits, arphaman, jkorous, MaskRay, ioeric. Herald added a project: clang. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D59354 Files: clang-tools-extra/clangd/AST.cpp cl

[PATCH] D59354: [clangd] Print arguments in template specializations

kadircet updated this revision to Diff 190617. kadircet marked 3 inline comments as done. kadircet added a comment. Herald added a subscriber: jdoerfert. - Address comments - Add template specializations to fuzzyFind results Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION http

[PATCH] D59354: [clangd] Print arguments in template specializations

kadircet added inline comments. Comment at: clang/lib/AST/TypePrinter.cpp:1644 +llvm::raw_ostream &OS) { + A.getTypeSourceInfo()->getType().print(OS, PP); +} ilya-biryukov wrote: > Maybe print the result of `getTypeLoc()` here, if

[PATCH] D59354: [clangd] Print arguments in template specializations

kadircet updated this revision to Diff 190624. kadircet added a comment. - Get rid of debug printing - Update tests Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59354/new/ https://reviews.llvm.org/D59354 Files: clang-tools-extra/clangd/AST.cpp

[PATCH] D59354: [clangd] Print arguments in template specializations

kadircet updated this revision to Diff 190642. kadircet marked 2 inline comments as done. kadircet added a comment. - Address some of the comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59354/new/ https://reviews.llvm.org/D59354 Files: cl

[PATCH] D59354: [clangd] Print arguments in template specializations

kadircet marked 7 inline comments as done. kadircet added inline comments. Comment at: clang-tools-extra/clangd/AST.cpp:84 +if (auto STL = TL.getAs()) { + std::vector ArgLocs; + for (unsigned I = 0; I < STL.getNumArgs(); I++) ilya-biryukov wrote: >

[PATCH] D59354: [clangd] Print arguments in template specializations

kadircet marked an inline comment as done. kadircet added inline comments. Comment at: clang/lib/AST/TypePrinter.cpp:1646 +break; + case TemplateArgument::ArgKind::Type: +A.getTypeSourceInfo()->getType().print(OS, PP); ilya-biryukov wrote: > Maybe simpli

[PATCH] D56370: [clangd] Add support for type hierarchy (super types only for now)

kadircet accepted this revision. kadircet added a comment. This revision is now accepted and ready to land. LGTM, thanks Nathan! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56370/new/ https://reviews.llvm.org/D56370 ___

[PATCH] D59354: [clangd] Print arguments in template specializations

kadircet added inline comments. Comment at: clang/lib/AST/TypePrinter.cpp:1655 + case TemplateArgument::ArgKind::Expression: + case TemplateArgument::ArgKind::Pack: +A.getArgument().print(PP, OS); ilya-biryukov wrote: > Now that you mentioned other kinds of

[PATCH] D59354: [clangd] Print arguments in template specializations

kadircet updated this revision to Diff 190800. kadircet marked 11 inline comments as done. kadircet added a comment. - Add more tests - Replace switch with if - Use SmallVector Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59354/new/ https://review

[PATCH] D59407: [clangd] Add RelationSlab

kadircet added a comment. This mostly looks good, one high level comment: I believe it makes sense to deduplicate SymbolIDs for RelationSlab. Up until now, we mostly had only one occurence of a SymbolID in a Slab, but RelationSlab does not follow that assumption. Also can you add a few tests aft

[PATCH] D59407: [clangd] Add RelationSlab

kadircet added inline comments. Comment at: clang-tools-extra/clangd/index/Index.h:43 +public: + using value_type = std::pair>; + using const_iterator = std::vector::const_iterator; gribozavr wrote: > `struct Relation`? And in the comments for it, please expla

[PATCH] D59302: [clangd] Surface diagnostics from headers inside main file

kadircet added a comment. In D59302#1431045 , @ilya-biryukov wrote: > I'll look more closely into the details, but just a high-level question now: > why would we want to make this optional and not simply surface these extra > diagnostics? The optional

[PATCH] D59481: [clangd] Count number of references while merging RefSlabs inside FileIndex

kadircet created this revision. kadircet added a reviewer: ilya-biryukov. Herald added subscribers: cfe-commits, jdoerfert, arphaman, mgrang, jkorous, MaskRay, ioeric. Herald added a project: clang. For counting number of references clangd was relying on merging every duplication of a symbol. Unf

[PATCH] D59487: [Tooling] Add more scope specifiers until spelling is not ambiguous.

kadircet accepted this revision. kadircet added a comment. This revision is now accepted and ready to land. LGTM Comment at: lib/Tooling/Core/Lookup.cpp:165 +if (UnspelledScopes.empty()) { + Disambiguated = "::" + Disambiguated; +} else { maybe ret

[PATCH] D59487: [Tooling] Add more scope specifiers until spelling is not ambiguous.

kadircet added inline comments. Comment at: lib/Tooling/Core/Lookup.cpp:165 +if (UnspelledScopes.empty()) { + Disambiguated = "::" + Disambiguated; +} else { ioeric wrote: > kadircet wrote: > > maybe return or break afterwards? > I also struggled a b

[PATCH] D59481: [clangd] Count number of references while merging RefSlabs inside FileIndex

kadircet marked 2 inline comments as done. kadircet added a comment. In D59481#1432881 , @ioeric wrote: > I'm not sure if FileIndex is the correct layer to make decision about how > References is calculated. Currently, we have two use cases in clangd 1) o

[PATCH] D56370: [clangd] Add support for type hierarchy (super types only for now)

This revision was automatically updated to reflect the committed changes. Closed by commit rL356445: [clangd] Add support for type hierarchy (super types only for now) (authored by kadircet, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to co

[PATCH] D59302: [clangd] Surface diagnostics from headers inside main file

kadircet updated this revision to Diff 191265. kadircet added a comment. - Only surface diagnostics with level fatal or error Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59302/new/ https://reviews.llvm.org/D59302 Files: clangd/ClangdServer.cpp

[PATCH] D59481: [clangd] Count number of references while merging RefSlabs inside FileIndex

kadircet marked an inline comment as done. kadircet added inline comments. Comment at: clang-tools-extra/clangd/index/FileIndex.cpp:170 I.first->second = mergeSymbol(I.first->second, Sym); +// We re-count number of references while merging refs from scratch. +

[PATCH] D59302: [clangd] Surface diagnostics from headers inside main file

kadircet updated this revision to Diff 191323. kadircet marked 2 inline comments as done. kadircet added a comment. - Show include stack in diagnostic message - Point to exact include location Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59302/new/

[PATCH] D59302: [clangd] Surface diagnostics from headers inside main file

kadircet planned changes to this revision. kadircet added a comment. - Limit per include directive - Use hardcoded value for limit Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59302/new/ https://reviews.llvm.org/D59302 __

[PATCH] D59354: [clangd] Print arguments in template specializations

kadircet updated this revision to Diff 191460. kadircet marked 2 inline comments as done. kadircet added a comment. - Address comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59354/new/ https://reviews.llvm.org/D59354 Files: clang-tools-ex

[PATCH] D59354: [clangd] Print arguments in template specializations

This revision was automatically updated to reflect the committed changes. Closed by commit rC356541: [clangd] Print arguments in template specializations (authored by kadircet, committed by ). Changed prior to commit: https://reviews.llvm.org/D59354?vs=191460&id=191462#toc Repository: rC Cla

<    1   2   3   4   5   6   7   8   9   10   >